August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: Add a sanity check before using dai driver name
by Jeffy Chen 24 Aug '17

24 Aug '17

The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen <jeffy.chen(a)rock-chips.com> Reported-by: Donglin Peng <dolinux.peng(a)gmail.com> --- sound/soc/soc-core.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 77e7e2a11af0..8ab9ee2b460a 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -978,11 +978,13 @@ struct snd_soc_dai *snd_soc_find_dai( if (dlc->name && strcmp(component->name, dlc->name)) continue; list_for_each_entry(dai, &component->dai_list, list) { - if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) - && strcmp(dai->driver->name, dlc->dai_name)) - continue; - - return dai; + if (!dlc->dai_name) + return dai; + if (!strcmp(dai->name, dlc->dai_name)) + return dai; + if (dai->driver->name && + !strcmp(dai->driver->name, dlc->dai_name)) + return dai; } } -- 2.11.0

3 6

[alsa-devel] [PATCH][alsa-lib] test: apply optimization for v4.14 kernel about changes for TLV data handling on user-defined element set
by Takashi Sakamoto 24 Aug '17

24 Aug '17

At kernel v4.14, in initial state, elements on user-defined sets have write-only flag. When applications write TLV data, then the elements get readable flag and the TLV data is available. Originally TLV data is shared by elements in the same set, thus events are generated for all of elements in the set by the write operation. Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- test/user-ctl-element-set.c | 84 +++++++++++++++++++++++++++++++++++++++------ 1 file changed, 73 insertions(+), 11 deletions(-) diff --git a/test/user-ctl-element-set.c b/test/user-ctl-element-set.c index 8635c156..f3710732 100644 --- a/test/user-ctl-element-set.c +++ b/test/user-ctl-element-set.c @@ -9,6 +9,7 @@ #include "../include/asoundlib.h" #include <sound/tlv.h> +#include <stdbool.h> struct elem_set_trial { snd_ctl_t *handle; @@ -28,6 +29,8 @@ struct elem_set_trial { snd_ctl_elem_value_t *elem_data); int (*allocate_elem_set_tlv)(struct elem_set_trial *trial, unsigned int **tlv); + + bool tlv_readable; }; struct chmap_entry { @@ -420,9 +423,9 @@ static int check_event(struct elem_set_trial *trial, unsigned int mask, continue; /* * I expect each event is generated separately to the same - * element. + * element or several events are generated at once. */ - if (!(snd_ctl_event_elem_get_mask(event) & mask)) + if ((snd_ctl_event_elem_get_mask(event) & mask) != mask) continue; --expected_count; } @@ -561,6 +564,16 @@ static int check_elem_set_props(struct elem_set_trial *trial) if (!snd_ctl_elem_info_is_locked(info)) return -EIO; + /* + * In initial state, any application can register TLV data for + * user-defined element set except for IEC 958 type, thus + * elements in any user-defined set should allow any write + * operation. + */ + if (trial->type != SND_CTL_ELEM_TYPE_IEC958 && + !snd_ctl_elem_info_is_tlv_writable(info)) + return -EIO; + /* Check type-specific properties. */ if (trial->check_elem_props != NULL) { err = trial->check_elem_props(trial, info); @@ -572,6 +585,25 @@ static int check_elem_set_props(struct elem_set_trial *trial) err = snd_ctl_elem_unlock(trial->handle, id); if (err < 0) return err; + + /* + * Till kernel v4.14, ALSA control core allows elements in any + * user-defined set to have TLV_READ flag even if they have no + * TLV data in their initial state. In this case, any read + * operation for TLV data should return -ENXIO. + */ + if (snd_ctl_elem_info_is_tlv_readable(info)) { + unsigned int data[32]; + err = snd_ctl_elem_tlv_read(trial->handle, trial->id, + data, sizeof(data)); + if (err >= 0) + return -EIO; + if (err != -ENXIO) + return err; + + trial->tlv_readable = true; + } + } return 0; @@ -619,6 +651,8 @@ static int check_elems(struct elem_set_trial *trial) static int check_tlv(struct elem_set_trial *trial) { unsigned int *tlv; + int mask; + unsigned int count; unsigned int len; unsigned int *curr; int err; @@ -644,6 +678,36 @@ static int check_tlv(struct elem_set_trial *trial) if (err < 0) goto end; + /* + * Since kernel v4.14, any write operation to an element in user-defined + * set can change state of the other elements in the same set. In this + * case, any TLV data is firstly available after the operation. + */ + if (!trial->tlv_readable) { + mask = SND_CTL_EVENT_MASK_INFO | SND_CTL_EVENT_MASK_TLV; + count = trial->element_count; + } else { + mask = SND_CTL_EVENT_MASK_TLV; + count = 1; + } + err = check_event(trial, mask, count); + if (err < 0) + goto end; + if (!trial->tlv_readable) { + snd_ctl_elem_info_t *info; + snd_ctl_elem_info_alloca(&info); + + snd_ctl_elem_info_set_id(info, trial->id); + err = snd_ctl_elem_info(trial->handle, info); + if (err < 0) + return err; + if (!snd_ctl_elem_info_is_tlv_readable(info)) + return -EIO; + + /* Now TLV data is available for this element set. */ + trial->tlv_readable = true; + } + err = snd_ctl_elem_tlv_read(trial->handle, trial->id, curr, len); if (err < 0) goto end; @@ -690,6 +754,7 @@ int main(void) trial.change_elem_members = change_bool_elem_members; trial.allocate_elem_set_tlv = allocate_bool_elem_set_tlv; + trial.tlv_readable = false; break; case SND_CTL_ELEM_TYPE_INTEGER: trial.element_count = 900; @@ -703,6 +768,7 @@ int main(void) trial.change_elem_members = change_int_elem_members; trial.allocate_elem_set_tlv = allocate_int_elem_set_tlv; + trial.tlv_readable = false; break; case SND_CTL_ELEM_TYPE_ENUMERATED: trial.element_count = 900; @@ -715,6 +781,7 @@ int main(void) trial.check_elem_props = check_enum_elem_props; trial.change_elem_members = change_enum_elem_members; trial.allocate_elem_set_tlv = NULL; + trial.tlv_readable = false; break; case SND_CTL_ELEM_TYPE_BYTES: trial.element_count = 900; @@ -728,6 +795,7 @@ int main(void) trial.change_elem_members = change_bytes_elem_members; trial.allocate_elem_set_tlv = allocate_bytes_elem_set_tlv; + trial.tlv_readable = false; break; case SND_CTL_ELEM_TYPE_IEC958: trial.element_count = 1; @@ -740,6 +808,7 @@ int main(void) trial.check_elem_props = NULL; trial.change_elem_members = change_iec958_elem_members; trial.allocate_elem_set_tlv = NULL; + trial.tlv_readable = false; break; case SND_CTL_ELEM_TYPE_INTEGER64: default: @@ -754,6 +823,7 @@ int main(void) trial.change_elem_members = change_int64_elem_members; trial.allocate_elem_set_tlv = allocate_int64_elem_set_tlv; + trial.tlv_readable = false; break; } @@ -784,7 +854,7 @@ int main(void) /* Check properties of each element in this element set. */ err = check_elem_set_props(&trial); if (err < 0) { - printf("Fail to check propetries of each element with " + printf("Fail to check properties of each element with " "%s type.\n", snd_ctl_elem_type_name(trial.type)); break; @@ -822,14 +892,6 @@ int main(void) snd_ctl_elem_type_name(trial.type)); break; } - err = check_event(&trial, SND_CTL_EVENT_MASK_TLV, 1); - if (err < 0) { - printf("Fail to check an event to change TLV" - "data of an an element set with %s " - "type.\n", - snd_ctl_elem_type_name(trial.type)); - break; - } } /* Test an operation to remove elements in this element set. */ -- 2.11.0

2 1

[alsa-devel] [PATCH 0/3] ALSA: control: delegate TLV eventing to each driver
by Takashi Sakamoto 24 Aug '17

24 Aug '17

Hi, This patchse is the same one which I posted and for merge to upstream. [alsa-devel] [RFC][PATCH 0/3] ALSA: control: delegate TLV eventing to each driver http://mailman.alsa-project.org/pipermail/alsa-devel/2017-August/124382.html Nothing changed from the original one. Takashi Sakamoto (3): ALSA: control: delegate TLV eventing to each driver ALSA: control: queue TLV event for a set of user-defined element ALSA: control: TLV data is unavailable at initial state of user-defined element set sound/core/control.c | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) -- 2.11.0

2 4

[alsa-devel] [PATCH] ALSA: nm256: constify snd_ac97_res_table
by Arvind Yadav 24 Aug '17

24 Aug '17

snd_ac97_res_table are not supposed to change at runtime. All functions working with snd_ac97_res_table provided by <sound/ac97_codec.h> work with const snd_ac97_res_table. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- sound/pci/nm256/nm256.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c index 0ef8054..b97f4ea 100644 --- a/sound/pci/nm256/nm256.c +++ b/sound/pci/nm256/nm256.c @@ -1271,7 +1271,7 @@ static int nm256_ac97_idx(unsigned short reg) } /* static resolution table */ -static struct snd_ac97_res_table nm256_res_table[] = { +static const struct snd_ac97_res_table nm256_res_table[] = { { AC97_MASTER, 0x1f1f }, { AC97_HEADPHONE, 0x1f1f }, { AC97_MASTER_MONO, 0x001f }, -- 1.9.1

2 1

[alsa-devel] [PATCH] sound/oss/pss: fix spelling mistake: "compoents" -> "components"
by Colin King 24 Aug '17

24 Aug '17

From: Colin Ian King <colin.king(a)canonical.com> Trivial fix to spelling mistake in MODULE_PARM_DESC text Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/oss/pss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/oss/pss.c b/sound/oss/pss.c index 33c3a442e162..951b14dec73a 100644 --- a/sound/oss/pss.c +++ b/sound/oss/pss.c @@ -1156,7 +1156,7 @@ MODULE_PARM_DESC(pss_cdrom_port, "Set the PSS CDROM port i/o base (0x340 or othe module_param(pss_enable_joystick, bool, 0); MODULE_PARM_DESC(pss_enable_joystick, "Enables the PSS joystick port (1 to enable, 0 to disable)"); module_param(pss_no_sound, bool, 0); -MODULE_PARM_DESC(pss_no_sound, "Configure sound compoents (0 - no, 1 - yes)"); +MODULE_PARM_DESC(pss_no_sound, "Configure sound components (0 - no, 1 - yes)"); module_param(pss_keep_settings, bool, 0); MODULE_PARM_DESC(pss_keep_settings, "Keep hardware setting at driver unloading (0 - no, 1 - yes)"); module_param(pss_firmware, charp, 0); -- 2.14.1

2 1

[alsa-devel] [RFC][PATCH 0/3] ALSA: control: delegate TLV eventing to each driver
by Takashi Sakamoto 24 Aug '17

24 Aug '17

Hi, This patchset is to avoid a trouble on ALSA control core, kernel API of ALSA control component and ALSA control interface/protocol to handle TLV operations from user space. In a design of ALSA control core, a set of elements is represented by 'struct snd_kcontrol' to share common attributes. The set of elements shares TLV (Type-Length-Value) data, too. On the other hand, in ALSA control interface/protocol for applications, a TLV operation is committed to an element. Totally, the operation can have sub-effect to the other elements in the set. For example, TLV_WRITE operation is expected to change TLV data, which returns to applications. Applications attempt to change the TLV data per element, but in the above design, they can effect to elements in the same set. As a default, ALSA control core has no implementation except for TLV_READ operation. Thus, the above design looks to have no issue. However, in kernel APIs of ALSA control component, developers can program a handler for any request of the TLV operation. Therefore, for elements in a set which has the handler, applications can commit TLV_WRITE and TLV_COMMAND requests. For the above scenario, ALSA control core assist notification. When the handler returns positive value, the core queueing an event for a requested element. However, this includes design defects that the event is not queued for the other element in a set. Actually, developers can program the handlers to keep per-element TLV data, but it depends on each driver. In this patchset, I attempts to solve the above issue, by delegating the event notification to each driver of ALSA control component. Additionally, this patchset includes a solution against an issue in below message thread: [alsa-devel] snd_ctl_add_enumerated_elem_set and TLV http://mailman.alsa-project.org/pipermail/alsa-devel/2017-July/123364.html Takashi Sakamoto (3): ALSA: control: delegate TLV eventing to each driver ALSA: control: queue TLV event for all of elements in an user-defined set ALSA: control: disable TLV data at initial state of user-defined element set sound/core/control.c | 34 ++++++++++++++++++++++------------ 1 file changed, 22 insertions(+), 12 deletions(-) -- 2.11.0

2 5

[alsa-devel] [PATCH] ASoC: soc-ac97: replace codec to component
by Kuninori Morimoto 24 Aug '17

24 Aug '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> codec will be replaced to component soon. AC97 is codec related feature now. Thus this patch replaces codec to component on AC97. To keep compatibility, previous snd_soc_xxx_ac97_codec() is now defined as macro to convert snd_soc_xxx_ac97_component(). Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- - I have no AC97 board. Compile test only had done. include/sound/soc.h | 10 +++++-- sound/soc/soc-ac97.c | 84 +++++++++++++++++++++++++++------------------------- 2 files changed, 51 insertions(+), 43 deletions(-) diff --git a/include/sound/soc.h b/include/sound/soc.h index 180c41b..f8fa9d0 100644 --- a/include/sound/soc.h +++ b/include/sound/soc.h @@ -568,10 +568,14 @@ int snd_soc_test_bits(struct snd_soc_codec *codec, unsigned int reg, unsigned int mask, unsigned int value); #ifdef CONFIG_SND_SOC_AC97_BUS -struct snd_ac97 *snd_soc_alloc_ac97_codec(struct snd_soc_codec *codec); -struct snd_ac97 *snd_soc_new_ac97_codec(struct snd_soc_codec *codec, +#define snd_soc_alloc_ac97_codec(codec) snd_soc_alloc_ac97_component(&codec->component) +#define snd_soc_new_ac97_codec(codec, id, id_mask) snd_soc_new_ac97_component(&codec->component, id, id_mask) +#define snd_soc_free_ac97_codec(ac97) snd_soc_free_ac97_component(ac97) + +struct snd_ac97 *snd_soc_alloc_ac97_component(struct snd_soc_component *component); +struct snd_ac97 *snd_soc_new_ac97_component(struct snd_soc_component *component, unsigned int id, unsigned int id_mask); -void snd_soc_free_ac97_codec(struct snd_ac97 *ac97); +void snd_soc_free_ac97_component(struct snd_ac97 *ac97); int snd_soc_set_ac97_ops(struct snd_ac97_bus_ops *ops); int snd_soc_set_ac97_ops_of_reset(struct snd_ac97_bus_ops *ops, diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index 36dae41..3f424f2 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -44,7 +44,7 @@ struct snd_ac97_gpio_priv { struct gpio_chip gpio_chip; #endif unsigned int gpios_set; - struct snd_soc_codec *codec; + struct snd_soc_component *component; }; static struct snd_ac97_bus soc_ac97_bus = { @@ -57,11 +57,11 @@ static void soc_ac97_device_release(struct device *dev) } #ifdef CONFIG_GPIOLIB -static inline struct snd_soc_codec *gpio_to_codec(struct gpio_chip *chip) +static inline struct snd_soc_component *gpio_to_component(struct gpio_chip *chip) { struct snd_ac97_gpio_priv *gpio_priv = gpiochip_get_data(chip); - return gpio_priv->codec; + return gpio_priv->component; } static int snd_soc_ac97_gpio_request(struct gpio_chip *chip, unsigned offset) @@ -75,20 +75,22 @@ static int snd_soc_ac97_gpio_request(struct gpio_chip *chip, unsigned offset) static int snd_soc_ac97_gpio_direction_in(struct gpio_chip *chip, unsigned offset) { - struct snd_soc_codec *codec = gpio_to_codec(chip); + struct snd_soc_component *component = gpio_to_component(chip); - dev_dbg(codec->dev, "set gpio %d to output\n", offset); - return snd_soc_update_bits(codec, AC97_GPIO_CFG, + dev_dbg(component->dev, "set gpio %d to output\n", offset); + return snd_soc_component_update_bits(component, AC97_GPIO_CFG, 1 << offset, 1 << offset); } static int snd_soc_ac97_gpio_get(struct gpio_chip *chip, unsigned offset) { - struct snd_soc_codec *codec = gpio_to_codec(chip); + struct snd_soc_component *component = gpio_to_component(chip); int ret; - ret = snd_soc_read(codec, AC97_GPIO_STATUS); - dev_dbg(codec->dev, "get gpio %d : %d\n", offset, + if (snd_soc_component_read(component, AC97_GPIO_STATUS, &ret) < 0) + ret = -1; + + dev_dbg(component->dev, "get gpio %d : %d\n", offset, ret < 0 ? ret : ret & (1 << offset)); return ret < 0 ? ret : !!(ret & (1 << offset)); @@ -98,22 +100,24 @@ static void snd_soc_ac97_gpio_set(struct gpio_chip *chip, unsigned offset, int value) { struct snd_ac97_gpio_priv *gpio_priv = gpiochip_get_data(chip); - struct snd_soc_codec *codec = gpio_to_codec(chip); + struct snd_soc_component *component = gpio_to_component(chip); gpio_priv->gpios_set &= ~(1 << offset); gpio_priv->gpios_set |= (!!value) << offset; - snd_soc_write(codec, AC97_GPIO_STATUS, gpio_priv->gpios_set); - dev_dbg(codec->dev, "set gpio %d to %d\n", offset, !!value); + snd_soc_component_write(component, AC97_GPIO_STATUS, + gpio_priv->gpios_set); + dev_dbg(component->dev, "set gpio %d to %d\n", offset, !!value); } static int snd_soc_ac97_gpio_direction_out(struct gpio_chip *chip, unsigned offset, int value) { - struct snd_soc_codec *codec = gpio_to_codec(chip); + struct snd_soc_component *component = gpio_to_component(chip); - dev_dbg(codec->dev, "set gpio %d to output\n", offset); + dev_dbg(component->dev, "set gpio %d to output\n", offset); snd_soc_ac97_gpio_set(chip, offset, value); - return snd_soc_update_bits(codec, AC97_GPIO_CFG, 1 << offset, 0); + return snd_soc_component_update_bits(component, AC97_GPIO_CFG, + 1 << offset, 0); } static const struct gpio_chip snd_soc_ac97_gpio_chip = { @@ -128,24 +132,24 @@ static int snd_soc_ac97_gpio_direction_out(struct gpio_chip *chip, }; static int snd_soc_ac97_init_gpio(struct snd_ac97 *ac97, - struct snd_soc_codec *codec) + struct snd_soc_component *component) { struct snd_ac97_gpio_priv *gpio_priv; int ret; - gpio_priv = devm_kzalloc(codec->dev, sizeof(*gpio_priv), GFP_KERNEL); + gpio_priv = devm_kzalloc(component->dev, sizeof(*gpio_priv), GFP_KERNEL); if (!gpio_priv) return -ENOMEM; ac97->gpio_priv = gpio_priv; - gpio_priv->codec = codec; + gpio_priv->component = component; gpio_priv->gpio_chip = snd_soc_ac97_gpio_chip; gpio_priv->gpio_chip.ngpio = AC97_NUM_GPIOS; - gpio_priv->gpio_chip.parent = codec->dev; + gpio_priv->gpio_chip.parent = component->dev; gpio_priv->gpio_chip.base = -1; ret = gpiochip_add_data(&gpio_priv->gpio_chip, gpio_priv); if (ret != 0) - dev_err(codec->dev, "Failed to add GPIOs: %d\n", ret); + dev_err(component->dev, "Failed to add GPIOs: %d\n", ret); return ret; } @@ -155,7 +159,7 @@ static void snd_soc_ac97_free_gpio(struct snd_ac97 *ac97) } #else static int snd_soc_ac97_init_gpio(struct snd_ac97 *ac97, - struct snd_soc_codec *codec) + struct snd_soc_component *component) { return 0; } @@ -166,8 +170,8 @@ static void snd_soc_ac97_free_gpio(struct snd_ac97 *ac97) #endif /** - * snd_soc_alloc_ac97_codec() - Allocate new a AC'97 device - * @codec: The CODEC for which to create the AC'97 device + * snd_soc_alloc_ac97_component() - Allocate new a AC'97 device + * @component: The COMPONENT for which to create the AC'97 device * * Allocated a new snd_ac97 device and intializes it, but does not yet register * it. The caller is responsible to either call device_add(&ac97->dev) to @@ -175,7 +179,7 @@ static void snd_soc_ac97_free_gpio(struct snd_ac97 *ac97) * * Returns: A snd_ac97 device or a PTR_ERR in case of an error. */ -struct snd_ac97 *snd_soc_alloc_ac97_codec(struct snd_soc_codec *codec) +struct snd_ac97 *snd_soc_alloc_ac97_component(struct snd_soc_component *component) { struct snd_ac97 *ac97; @@ -187,26 +191,26 @@ struct snd_ac97 *snd_soc_alloc_ac97_codec(struct snd_soc_codec *codec) ac97->num = 0; ac97->dev.bus = &ac97_bus_type; - ac97->dev.parent = codec->component.card->dev; + ac97->dev.parent = component->card->dev; ac97->dev.release = soc_ac97_device_release; dev_set_name(&ac97->dev, "%d-%d:%s", - codec->component.card->snd_card->number, 0, - codec->component.name); + component->card->snd_card->number, 0, + component->name); device_initialize(&ac97->dev); return ac97; } -EXPORT_SYMBOL(snd_soc_alloc_ac97_codec); +EXPORT_SYMBOL(snd_soc_alloc_ac97_component); /** - * snd_soc_new_ac97_codec - initailise AC97 device - * @codec: audio codec + * snd_soc_new_ac97_component - initailise AC97 device + * @component: audio component * @id: The expected device ID * @id_mask: Mask that is applied to the device ID before comparing with @id * - * Initialises AC97 codec resources for use by ad-hoc devices only. + * Initialises AC97 component resources for use by ad-hoc devices only. * * If @id is not 0 this function will reset the device, then read the ID from * the device and check if it matches the expected ID. If it doesn't match an @@ -214,20 +218,20 @@ struct snd_ac97 *snd_soc_alloc_ac97_codec(struct snd_soc_codec *codec) * * Returns: A PTR_ERR() on failure or a valid snd_ac97 struct on success. */ -struct snd_ac97 *snd_soc_new_ac97_codec(struct snd_soc_codec *codec, +struct snd_ac97 *snd_soc_new_ac97_component(struct snd_soc_component *component, unsigned int id, unsigned int id_mask) { struct snd_ac97 *ac97; int ret; - ac97 = snd_soc_alloc_ac97_codec(codec); + ac97 = snd_soc_alloc_ac97_component(component); if (IS_ERR(ac97)) return ac97; if (id) { ret = snd_ac97_reset(ac97, false, id, id_mask); if (ret < 0) { - dev_err(codec->dev, "Failed to reset AC97 device: %d\n", + dev_err(component->dev, "Failed to reset AC97 device: %d\n", ret); goto err_put_device; } @@ -237,7 +241,7 @@ struct snd_ac97 *snd_soc_new_ac97_codec(struct snd_soc_codec *codec, if (ret) goto err_put_device; - ret = snd_soc_ac97_init_gpio(ac97, codec); + ret = snd_soc_ac97_init_gpio(ac97, component); if (ret) goto err_put_device; @@ -247,22 +251,22 @@ struct snd_ac97 *snd_soc_new_ac97_codec(struct snd_soc_codec *codec, put_device(&ac97->dev); return ERR_PTR(ret); } -EXPORT_SYMBOL_GPL(snd_soc_new_ac97_codec); +EXPORT_SYMBOL_GPL(snd_soc_new_ac97_component); /** - * snd_soc_free_ac97_codec - free AC97 codec device + * snd_soc_free_ac97_component - free AC97 component device * @ac97: snd_ac97 device to be freed * - * Frees AC97 codec device resources. + * Frees AC97 component device resources. */ -void snd_soc_free_ac97_codec(struct snd_ac97 *ac97) +void snd_soc_free_ac97_component(struct snd_ac97 *ac97) { snd_soc_ac97_free_gpio(ac97); device_del(&ac97->dev); ac97->bus = NULL; put_device(&ac97->dev); } -EXPORT_SYMBOL_GPL(snd_soc_free_ac97_codec); +EXPORT_SYMBOL_GPL(snd_soc_free_ac97_component); static struct snd_ac97_reset_cfg snd_ac97_rst_cfg; -- 1.9.1

2 2

[alsa-devel] [PATCH 00/11] ASoC: make snd_soc_platform_driver const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make snd_soc_platform_driver const. Bhumika Goyal (11): ASoC: codecs: make snd_soc_platform_driver const ASoC: Intel: make snd_soc_platform_driver const ASoC: fsl: make snd_soc_platform_driver const ASoC: nuc900: make snd_soc_platform_driver const ASoC: omap: make snd_soc_platform_driver const ASoC: pxa: make snd_soc_platform_driver const ASoC: qcom: make snd_soc_platform_driver const ASoC: samsung: make snd_soc_platform_driver const ASoC: sh: make snd_soc_platform_driver const ASoC: txx9: make snd_soc_platform_driver const ASoC: soc-utils: make snd_soc_platform_driver const sound/soc/codecs/cs47l24.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/codecs/wm5102.c | 2 +- sound/soc/codecs/wm5110.c | 2 +- sound/soc/fsl/imx-pcm-fiq.c | 2 +- sound/soc/fsl/mpc5200_dma.c | 2 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 +- sound/soc/intel/haswell/sst-haswell-pcm.c | 2 +- sound/soc/intel/skylake/skl-pcm.c | 2 +- sound/soc/nuc900/nuc900-pcm.c | 2 +- sound/soc/omap/omap-pcm.c | 2 +- sound/soc/pxa/mmp-pcm.c | 2 +- sound/soc/pxa/pxa2xx-pcm.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/samsung/idma.c | 2 +- sound/soc/sh/dma-sh7760.c | 2 +- sound/soc/sh/fsi.c | 2 +- sound/soc/sh/rcar/core.c | 2 +- sound/soc/soc-utils.c | 2 +- sound/soc/txx9/txx9aclc.c | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) -- 1.9.1

8 18

[alsa-devel] [ANNOUNCE RESENT] Audio Mini Summit 2017 at Prague, Oct 27
by Takashi Iwai 23 Aug '17

23 Aug '17

Hi, this is a gentle reminder for people who missed the previous announcement for Audio Mini Summit. Below is the content I posted in a month ago. If anyone is interested, please join up! thanks, Takashi === Hi, this is an announcement of Audio Mini Summit 2017. It's an annual meeting we regularly have along with major Linux conferences, and this year, we'll hold the meeting at Prague (Czech Republic) on Friday, October 27, right after GStreamer Summit, ELCE and Open Source Summit Europe. We planned a whole-day meeting, and will likely have an evening dinner event, too. Please note that the meeting will be held in a conference room of SUSE Prague office, not in Hilton hotel where ELCE/OSSE is held. It's located near Hilton, just a couple of blocks away. The address of SUSE office is: Corso II, Křižíkova 148/34, 18600 Praha 8 https://goo.gl/maps/anET1yh3XXu Also, since the conference room is hosted by SUSE, it's an open event at this time; that is, you can attend only this meeting without registration for other Linux Foundation events in that week, too. If you are interested in the event, please fill up the registration form in Google doc spreadsheet below: https://docs.google.com/spreadsheets/d/1a-RaYtTVVtgh_cyRN5GwATiixppGCMEwqw6… Just add yourself in the attendee list from the web page. And, now we are gathering the topics to discuss, too. If you have any interesting topics to be discussed in the meeting, feel free to post to alsa-devel ML. I'm going to write up later. thanks, Takashi

1 0

[alsa-devel] [PATCH] ALSA: aaci: constify amba_id
by Arvind Yadav 23 Aug '17

23 Aug '17

amba_id are not supposed to change at runtime. All functions working with const amba_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- sound/arm/aaci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c index 4140b1b..05562ba 100644 --- a/sound/arm/aaci.c +++ b/sound/arm/aaci.c @@ -1085,7 +1085,7 @@ static int aaci_remove(struct amba_device *dev) return 0; } -static struct amba_id aaci_ids[] = { +static const struct amba_id aaci_ids[] = { { .id = 0x00041041, .mask = 0x000fffff, -- 2.7.4

1 0