August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v1] ASoC: rt5677: Convert I2C driver to ->probe_new()
by Andy Shevchenko 25 Aug '17

25 Aug '17

There is no platform code that uses i2c module table. Remove it altogether and adjust ->probe() to be ->probe_new(). Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- sound/soc/codecs/rt5677.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index c735590c5a25..6448b7a00203 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5009,11 +5009,6 @@ static const struct regmap_config rt5677_regmap = { .num_ranges = ARRAY_SIZE(rt5677_ranges), }; -static const struct i2c_device_id rt5677_i2c_id[] = { - { } -}; -MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); - static const struct of_device_id rt5677_of_match[] = { { .compatible = "realtek,rt5677", RT5677 }, { } @@ -5131,8 +5126,7 @@ static void rt5677_free_irq(struct i2c_client *i2c) regmap_del_irq_chip(i2c->irq, rt5677->irq_data); } -static int rt5677_i2c_probe(struct i2c_client *i2c, - const struct i2c_device_id *id) +static int rt5677_i2c_probe(struct i2c_client *i2c) { struct rt5677_priv *rt5677; int ret; @@ -5279,9 +5273,8 @@ static struct i2c_driver rt5677_i2c_driver = { .of_match_table = rt5677_of_match, .acpi_match_table = ACPI_PTR(rt5677_acpi_match), }, - .probe = rt5677_i2c_probe, + .probe_new = rt5677_i2c_probe, .remove = rt5677_i2c_remove, - .id_table = rt5677_i2c_id, }; module_i2c_driver(rt5677_i2c_driver); -- 2.14.1

3 11

[alsa-devel] Developing a ti-pcm1863 (adc) codec driver
by Oleksandr Müller 25 Aug '17

25 Aug '17

Hello Mr. Brown, I have a soundcard which doesnt have a linux driver. Quick information it has a pcm1863 adc and a pcm5142 dac on it. I began with the sample dt-overlay and edited it to get the playback working. No problem at all using the pcm512x.c codec driver. After that I began with the development of the codec driver, i2c driver and a dt-overlay with 2 sound links as I need the record and playback functionality. Right now the i2c driver seems to work since I get the hardware into the used state "UU" when executing the i2cdetect command and dmesg says "mapping okay". My codec driver has the codec driver and dai definitions and some more functions (here I am stuck). I know that I need the hw_params and some set functions to have the minimal functionality. 1. Question would be towards the dapm_widgets and dapm_routes definitions. When defining the dapm_adc widget do I put there the Capture stream or do I seperate it with "NULL" and then adding the dapm_routes definitions? Which one is correct since I have seen both possibilities (which ad-/disadventages do I have?) 2. Question in my layout plan I need to set the ADC to VIN4 l/r because only this one is connected to the microphone port. I have put it into the sound controls but how would I make this switch from the command line (arecord) or in the players (like vlc) 3. It seems that I have a bug in the code since I cant execute arecord right now it says file doesnt exist. Furthermore I would really be interested in gaining more knowledge about the accesses and routines from e.g. the vlc player using alsa (?) and then the accesses to the hardware? Also the whole registering process in which order are which files executed to get into the state where the os knows my soundcard. Since in a stracktrace I dont see this high level functions executed. I have found some diagramms on a chinese blog which look not bad but it would be a lot better to find it out myself with the os if possible. Here is an example of this kind of diagramm: http://img.blog.csdn.net/20160127104235066?watermark/2/text/aHR0cDovL2Jsb2c… This is knowledge is right now optional but would be very helpful for the understanding. I will attach the codec driver, codec driver-header, i2c driver, dt-overlay and a strack trace (ltrace just hangs up) so it would be possible to find out what is causing the problem right now. Please note that this is my first driver development and the code is work in progress :) Thanks a lot for Your time and Your help! If an information is missing please ask for it and if possible I will try to provide it :) Sanj3k

2 3

[alsa-devel] Question about sound device release timing
by Kuninori Morimoto 25 Aug '17

25 Aug '17

Hi Takashi-san, Mark I noticed snd_soc_dapm_stream_event() is called strange timing if I unbind sound device during playing > aplay xxx.wav & > echo xxxx > /sys/bus/platform/drivers/xxx/unbind ... > Unable to handle kernel paging request at virtual address dead000000000220 > Mem abort info: (snip) > PC is at soc_dapm_dai_stream_event.isra.14+0x20/0xd0 > LR is at snd_soc_dapm_stream_event+0x74/0xa8 (snip) > [<ffff000008715610>] soc_dapm_dai_stream_event.isra.14+0x20/0xd0 > [<ffff00000871989c>] snd_soc_dapm_stream_event+0x74/0xa8 > [<ffff00000871b23c>] close_delayed_work+0x3c/0x50 > [<ffff0000080bbd6c>] process_one_work+0x1ac/0x318 > [<ffff0000080bbf20>] worker_thread+0x48/0x420 > [<ffff0000080c201c>] kthread+0xfc/0x128 > [<ffff0000080842f0>] ret_from_fork+0x10/0x18 > Code: b40005c9 a9bf7bfd 91048120 910003fd (f9409121) > ---[ end trace 6739a0ea1013e0b2 ]--- This snd_soc_dapm_stream_event() was called from close_delayed_work() and it was set on soc_pcm_close() static int soc_pcm_close(struct snd_pcm_substream *substream) { ... if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { if (snd_soc_runtime_ignore_pmdown_time(rtd)) { ... } else { /* start delayed pop wq here for playback streams */ rtd->pop_wait = 1; => queue_delayed_work(system_power_efficient_wq, &rtd->delayed_work, msecs_to_jiffies(rtd->pmdown_time)); } ... } But, this soc_pcm_close() is called *after* flush_delayed_work() of soc_cleanup_card_resources(). It seems this close function seems called from snd_card_free() and this rtd will be freed on soc_remove_pcm_runtimes(). static int soc_cleanup_card_resources(struct snd_soc_card *card) { ... /* make sure any delayed work runs */ list_for_each_entry(rtd, &card->rtd_list, list) { => flush_delayed_work(&rtd->delayed_work); } /* free the ALSA card at first; this syncs with pending operations */ => snd_card_free(card->snd_card); ... => soc_remove_pcm_runtimes(card); ... } Because of this, delayed called close_delayed_work() will call soc_dapm_dai_stream_event() and it access to already freed rtd, and kernel will die. I don't know why, but it seems this close is wokring on other thread (?), but I'm not sure. Q1. does this close function run on other thread ? Q2. I can avoid this delayed close by setting rtd->pmdown_time = 0; before snd_card_free(). but is this correct approach ? I can avoid this delayed calling close_delayed_work() by local patch, but then, re-bind doesn't work correctly. /* * custom kernel for avoiding close_delayed_work() */ > aplay xxx.wav & > echo xxxx > /sys/bus/platform/drivers/rcar_sound/unbind /* unbind codec and card drivers here */ > /* * try re-bind */ /* re-bind codec and card drivers here */ > echo xxxx > /sys/bus/platform/drivers/rcar_sound/bind rcar_sound ec500000.sound: probed asoc-simple-card sound: ak4613-hifi <-> ec500000.sound mapping ok > > aplay xxx.wav Playing WAVE '/home/Calm_16bit_48k.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo ALSA lib pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave PCM not usable aplay: set_params:1204: Broken configuration for this PCM: no configurations available Do you know why or have hint to solve these issue ? Best regards --- Kuninori Morimoto

2 4

[alsa-devel] [lkp-robot] [ALSA] c8da9be4a7: WARNING:at_fs/proc/generic.c:#proc_register
by kernel test robot 25 Aug '17

25 Aug '17

FYI, we noticed the following commit: commit: c8da9be4a75f1f63024a16b976c5be47405c13dc ("ALSA: pcm: Adjust nine function calls together with a variable assignment") https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git for-next in testcase: trinity with following parameters: runtime: 300s test-description: Trinity is a linux system call fuzz tester. test-url: http://codemonkey.org.uk/projects/trinity/ on test machine: qemu-system-i386 -enable-kvm -m 256M caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace): +------------------------------------------------+------------+------------+ | | 97d15a141f | c8da9be4a7 | +------------------------------------------------+------------+------------+ | boot_successes | 4 | 0 | | boot_failures | 2 | 6 | | IP-Config:Auto-configuration_of_network_failed | 2 | 2 | | WARNING:at_fs/proc/generic.c:#proc_register | 0 | 6 | | EIP:proc_register | 0 | 6 | +------------------------------------------------+------------+------------+ [ 8.559972] WARNING: CPU: 0 PID: 1 at fs/proc/generic.c:328 proc_register+0xe4/0x130 [ 8.559972] WARNING: CPU: 0 PID: 1 at fs/proc/generic.c:328 proc_register+0xe4/0x130 [ 8.561652] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-rc3-00171-gc8da9be #1 [ 8.561652] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-rc3-00171-gc8da9be #1 [ 8.562958] task: cf644000 task.stack: cf646000 [ 8.562958] task: cf644000 task.stack: cf646000 [ 8.563748] EIP: proc_register+0xe4/0x130 [ 8.563748] EIP: proc_register+0xe4/0x130 [ 8.564423] EFLAGS: 00210282 CPU: 0 [ 8.564423] EFLAGS: 00210282 CPU: 0 [ 8.565001] EAX: 0000002e EBX: ced3a038 ECX: 00000000 EDX: 00000000 [ 8.565001] EAX: 0000002e EBX: ced3a038 ECX: 00000000 EDX: 00000000 [ 8.566049] ESI: ced3dab0 EDI: cf724d24 EBP: cf647d08 ESP: cf647ce8 [ 8.566049] ESI: ced3dab0 EDI: cf724d24 EBP: cf647d08 ESP: cf647ce8 [ 8.567102] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 [ 8.567102] DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 [ 8.568042] CR0: 80050033 CR2: 00000000 CR3: 021d5000 CR4: 000006b0 [ 8.568042] CR0: 80050033 CR2: 00000000 CR3: 021d5000 CR4: 000006b0 [ 8.569131] Call Trace: [ 8.569131] Call Trace: [ 8.569561] proc_create_data+0x81/0xf0 [ 8.569561] proc_create_data+0x81/0xf0 [ 8.570264] snd_info_register+0x6d/0xe0 [ 8.570264] snd_info_register+0x6d/0xe0 [ 8.570941] snd_pcm_new_stream+0x21b/0x4a0 [ 8.570941] snd_pcm_new_stream+0x21b/0x4a0 [ 8.571694] ? strlcpy+0x33/0x50 [ 8.571694] ? strlcpy+0x33/0x50 [ 8.572252] _snd_pcm_new+0xc6/0x150 [ 8.572252] _snd_pcm_new+0xc6/0x150 [ 8.572874] snd_pcm_new+0x18/0x20 [ 8.572874] snd_pcm_new+0x18/0x20 [ 8.573463] snd_dummy_probe+0xec/0x400 [ 8.573463] snd_dummy_probe+0xec/0x400 [ 8.574103] platform_drv_probe+0x1e/0x60 [ 8.574103] platform_drv_probe+0x1e/0x60 [ 8.574785] really_probe+0x1c2/0x260 [ 8.574785] really_probe+0x1c2/0x260 [ 8.575424] __device_attach_driver+0x72/0xb0 [ 8.575424] __device_attach_driver+0x72/0xb0 [ 8.576183] ? __driver_attach+0xb0/0xb0 [ 8.576183] ? __driver_attach+0xb0/0xb0 [ 8.576844] bus_for_each_drv+0x4f/0x80 [ 8.576844] bus_for_each_drv+0x4f/0x80 [ 8.577486] __device_attach+0x9e/0xd0 [ 8.577486] __device_attach+0x9e/0xd0 [ 8.578113] ? __driver_attach+0xb0/0xb0 [ 8.578113] ? __driver_attach+0xb0/0xb0 [ 8.578772] device_initial_probe+0x12/0x20 [ 8.578772] device_initial_probe+0x12/0x20 [ 8.579486] bus_probe_device+0x77/0x80 [ 8.579486] bus_probe_device+0x77/0x80 [ 8.580201] device_add+0x2fc/0x530 [ 8.580201] device_add+0x2fc/0x530 [ 8.580797] ? dev_set_name+0x19/0x20 [ 8.580797] ? dev_set_name+0x19/0x20 [ 8.581416] platform_device_add+0x124/0x240 [ 8.581416] platform_device_add+0x124/0x240 [ 8.582156] platform_device_register_full+0xe2/0x120 [ 8.582156] platform_device_register_full+0xe2/0x120 [ 8.583002] alsa_card_dummy_init+0x97/0xf4 [ 8.583002] alsa_card_dummy_init+0x97/0xf4 [ 8.583784] ? alsa_seq_midi_event_init+0xc/0xc [ 8.583784] ? alsa_seq_midi_event_init+0xc/0xc [ 8.584604] do_one_initcall+0x80/0x151 [ 8.584604] do_one_initcall+0x80/0x151 [ 8.585270] ? parse_args+0x130/0x2a0 [ 8.585270] ? parse_args+0x130/0x2a0 [ 8.585890] ? kernel_init_freeable+0xe5/0x178 [ 8.585890] ? kernel_init_freeable+0xe5/0x178 [ 8.586630] kernel_init_freeable+0x105/0x178 [ 8.586630] kernel_init_freeable+0x105/0x178 [ 8.587655] ? rest_init+0xf0/0xf0 [ 8.587655] ? rest_init+0xf0/0xf0 [ 8.588230] kernel_init+0xd/0xf0 [ 8.588230] kernel_init+0xd/0xf0 [ 8.588778] ret_from_fork+0x19/0x24 [ 8.588778] ret_from_fork+0x19/0x24 [ 8.589384] Code: af 8d b6 00 00 00 00 6a 01 31 c9 ba 01 00 00 00 b8 90 4e f7 c1 83 c7 7c e8 ba 5a ef ff ff 75 f0 57 68 ac f0 d4 c1 e8 6c 2f e9 ff <0f> ff 6a 01 31 c9 ba 01 00 00 00 b8 78 4e f7 c1 e8 97 5a ef ff [ 8.589384] Code: af 8d b6 00 00 00 00 6a 01 31 c9 ba 01 00 00 00 b8 90 4e f7 c1 83 c7 7c e8 ba 5a ef ff ff 75 f0 57 68 ac f0 d4 c1 e8 6c 2f e9 ff <0f> ff 6a 01 31 c9 ba 01 00 00 00 b8 78 4e f7 c1 e8 97 5a ef ff [ 8.592689] ---[ end trace 8498fc54cd971cf8 ]--- To reproduce: git clone https://github.com/01org/lkp-tests.git cd lkp-tests bin/lkp qemu -k <bzImage> job-script # job-script is attached in this email Thanks, Xiaolong

1 0

[alsa-devel] [PATCH v3] ASoC: Intel: kbl: Add map for Maxim IV Feedback
by Naveen M 25 Aug '17

25 Aug '17

MAX98927 provides IV feedback on the capture widget. Here we are connecting the capture widget to SSP0_RX and SSP0_RX to the algorithm running on host. Signed-off-by: Naveen M <naveen.m(a)intel.com> Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com> v2: rebased on newer kernel (d46b182) v3: moved version changelog info after s-o-b lines --- sound/soc/intel/boards/kbl_rt5663_max98927.c | 5 +++++ sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c index c144214..8d2a1c0 100644 --- a/sound/soc/intel/boards/kbl_rt5663_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c @@ -107,6 +107,11 @@ enum { { "hs_in", NULL, "ssp1 Rx" }, { "ssp1 Rx", NULL, "AIF Capture" }, + /* IV feedback path */ + { "codec0_fb_in", NULL, "ssp0 Rx"}, + { "ssp0 Rx", NULL, "Left HiFi Capture" }, + { "ssp0 Rx", NULL, "Right HiFi Capture" }, + /* DMIC */ { "dmic01_hifi", NULL, "DMIC01 Rx" }, { "DMIC01 Rx", NULL, "DMIC AIF" }, diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c index c2ef538..8d19da9 100644 --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c @@ -119,6 +119,11 @@ enum { { "codec1_in", NULL, "ssp0 Rx" }, { "ssp0 Rx", NULL, "AIF1 Capture" }, + /* IV feedback path */ + { "codec0_fb_in", NULL, "ssp0 Rx"}, + { "ssp0 Rx", NULL, "Left HiFi Capture" }, + { "ssp0 Rx", NULL, "Right HiFi Capture" }, + /* DMIC */ { "DMIC1L", NULL, "DMIC" }, { "DMIC1R", NULL, "DMIC" }, -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix uninitialized return
by Subhransu S. Prusty 25 Aug '17

25 Aug '17

On failure to get dsp_ops, dsp_init returns error without assigning ret. ret is assigned in code path which will never be executed. Fix it. Fixes: f77d443c4c29 ("ASoC: Intel: Skylake: Fix to free resources for dsp_init failure" Reported-by: kbuild test robot <fengguang.wu(a)intel.com> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty(a)intel.com> --- sound/soc/intel/skylake/skl-messages.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c index f0f11f597b21..697d07bc1b5a 100644 --- a/sound/soc/intel/skylake/skl-messages.c +++ b/sound/soc/intel/skylake/skl-messages.c @@ -278,8 +278,8 @@ int skl_init_dsp(struct skl *skl) ops = skl_get_dsp_ops(skl->pci->device); if (!ops) { - goto unmap_mmio; ret = -EIO; + goto unmap_mmio; } loader_ops = ops->loader_ops(); -- 1.9.1

3 2

[alsa-devel] proc_dir_entry 'asound/pcm' already registered
by Fabio Estevam 24 Aug '17

24 Aug '17

Hi, I am running linux-next 20170824 on a imx6q-sabresd and getting the warnings below. Any ideas as to why 'asound/pcm' is getting registered twice? Thanks [ 3.842972] fsl-ssi-dai 202c000.ssi: No cache defaults, reading back from HW [ 3.859270] input: WM8962 Beep Generator as /devices/soc0/soc/2100000.aips-bus/21a0000.i2c/i2c-0/0-001a/input/input1 [ 3.921494] ------------[ cut here ]------------ [ 3.926181] WARNING: CPU: 1 PID: 1 at fs/proc/generic.c:330 proc_register+0xc8/0x13c [ 3.934020] proc_dir_entry 'asound/pcm' already registered [ 3.939609] Modules linked in: [ 3.942712] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.13.0-rc6-next-20170824 #49 [ 3.950301] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 3.956849] Backtrace: [ 3.959340] [<c010ca24>] (dump_backtrace) from [<c010ccf4>] (show_stack+0x18/0x1c) [ 3.966933] r7:00000000 r6:60000013 r5:00000000 r4:c0e79b80 [ 3.972620] [<c010ccdc>] (show_stack) from [<c09ca560>] (dump_stack+0xb4/0xe8) [ 3.979869] [<c09ca4ac>] (dump_stack) from [<c0125654>] (__warn+0xd8/0x104) [ 3.986856] r9:c029892c r8:0000014a r7:00000009 r6:c0c06374 r5:00000000 r4:ec069b48 [ 3.994623] [<c012557c>] (__warn) from [<c01256bc>] (warn_slowpath_fmt+0x3c/0x44) [ 4.002129] r9:ec338f2c r8:00000000 r7:ec338f00 r6:00000001 r5:ec887b40 r4:c0c06404 [ 4.009898] [<c0125684>] (warn_slowpath_fmt) from [<c029892c>] (proc_register+0xc8/0x13c) [ 4.018096] r3:ec338f7d r2:c0c06404 [ 4.021691] r4:ec12c874 [ 4.024254] [<c0298864>] (proc_register) from [<c0298c64>] (proc_create_data+0x80/0xc4) [ 4.032281] r10:ec8a9e00 r9:00000000 r8:00000000 r7:ec138000 r6:ec887a80 r5:c0a900f0 [ 4.040130] r4:ec887b40 [ 4.042695] [<c0298be4>] (proc_create_data) from [<c075456c>] (snd_info_register+0x6c/0xd4) [ 4.051066] r5:ec338f00 r4:ec887a80 [ 4.054670] [<c0754500>] (snd_info_register) from [<c07590ac>] (snd_pcm_new_stream+0x15c/0x454) [ 4.063388] r5:ec145800 r4:00000000 [ 4.066987] [<c0758f50>] (snd_pcm_new_stream) from [<c0759a54>] (_snd_pcm_new+0xb4/0x13c) [ 4.075188] r10:00000000 r9:00000000 r8:00000001 r7:ec138000 r6:ec069ca4 r5:ec069ca8 [ 4.083036] r4:ec145800 [ 4.085593] [<c07599a0>] (_snd_pcm_new) from [<c0759afc>] (snd_pcm_new+0x20/0x28) [ 4.093100] r10:ec069ca8 r9:00000001 r8:ec132c80 r7:00000000 r6:ec8a9a0c r5:00000001 [ 4.100948] r4:00000001 r3:00000001 [ 4.104550] [<c0759adc>] (snd_pcm_new) from [<c0777c0c>] (soc_new_pcm+0x12c/0x45c) [ 4.112139] r4:ec144800 [ 4.114700] [<c0777ae0>] (soc_new_pcm) from [<c076b658>] (snd_soc_register_card+0xc40/0xe38) [ 4.123162] r10:ec144800 r9:ec8cd810 r8:00000002 r7:ec8cd898 r6:ec8cd9d4 r5:ec8cd978 [ 4.131011] r4:c0c8dcb8 [ 4.133570] [<c076aa18>] (snd_soc_register_card) from [<c0778474>] (devm_snd_soc_register_card+0x38/0x78) [ 4.143161] r10:ec224400 r9:ec8cd810 r8:c0aaf308 r7:ec284c10 r6:ec8cd898 r5:ec89b150 [ 4.151009] r4:ec8cd898 [ 4.153575] [<c077843c>] (devm_snd_soc_register_card) from [<c07913a4>] (imx_wm8962_probe+0x244/0x37c) [ 4.162905] r7:ef7d9650 r6:ec284c10 r5:ec284c00 r4:ec8cd898 [ 4.168595] [<c0791160>] (imx_wm8962_probe) from [<c0546780>] (platform_drv_probe+0x54/0xb8) [ 4.177056] r10:00000000 r9:00000000 r8:c0e70228 r7:fffffdfb r6:c0e70228 r5:ec284c10 [ 4.184904] r4:ec284c10 [ 4.187470] [<c054672c>] (platform_drv_probe) from [<c0544bf4>] (driver_probe_device+0x274/0x2fc) [ 4.196365] r7:c15e6c10 r6:00000000 r5:c15e6c0c r4:ec284c10 [ 4.202051] [<c0544980>] (driver_probe_device) from [<c0544d44>] (__driver_attach+0xc8/0xcc) [ 4.210513] r10:c0d00618 r9:c0d6089c r8:00000000 r7:00000000 r6:ec284c44 r5:c0e70228 [ 4.218361] r4:ec284c10 r3:00000000 [ 4.221964] [<c0544c7c>] (__driver_attach) from [<c0542ebc>] (bus_for_each_dev+0x74/0xa8) [ 4.230164] r7:00000000 r6:c0544c7c r5:c0e70228 r4:00000000 [ 4.235852] [<c0542e48>] (bus_for_each_dev) from [<c0544530>] (driver_attach+0x20/0x28) [ 4.243876] r6:c0e3b288 r5:ec132300 r4:c0e70228 [ 4.248520] [<c0544510>] (driver_attach) from [<c054402c>] (bus_add_driver+0x190/0x218) [ 4.256549] [<c0543e9c>] (bus_add_driver) from [<c05456e4>] (driver_register+0x80/0x100) [ 4.264662] r7:c0cf5ec4 r6:c0d60894 r5:c0d4e44c r4:c0e70228 [ 4.270347] [<c0545664>] (driver_register) from [<c05466d4>] (__platform_driver_register+0x38/0x4c) [ 4.279412] r5:c0d4e44c r4:ffffe000 [ 4.283020] [<c054669c>] (__platform_driver_register) from [<c0d4e464>] (imx_wm8962_driver_init+0x18/0x20) [ 4.292702] [<c0d4e44c>] (imx_wm8962_driver_init) from [<c0101c54>] (do_one_initcall+0x44/0x17c) [ 4.301517] [<c0101c10>] (do_one_initcall) from [<c0d00e7c>] (kernel_init_freeable+0x118/0x1d0) [ 4.310238] r8:000000f1 r7:c0cf5ec4 r6:c0d60894 r5:c0e7d000 r4:c0d710e0 [ 4.316967] [<c0d00d64>] (kernel_init_freeable) from [<c09de898>] (kernel_init+0x10/0x118) [ 4.325254] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c09de888 [ 4.333102] r4:00000000 [ 4.335665] [<c09de888>] (kernel_init) from [<c01080f8>] (ret_from_fork+0x14/0x3c) [ 4.343255] r5:c09de888 r4:00000000 [ 4.346962] ---[ end trace 3ea29ef261f4780c ]--- [ 4.351955] ------------[ cut here ]------------ [ 4.356611] WARNING: CPU: 1 PID: 1 at fs/proc/generic.c:330 proc_register+0xc8/0x13c [ 4.364434] proc_dir_entry 'asound/pcm' already registered [ 4.369982] Modules linked in: [ 4.373083] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 4.13.0-rc6-next-20170824 #49 [ 4.381887] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 4.388433] Backtrace: [ 4.390918] [<c010ca24>] (dump_backtrace) from [<c010ccf4>] (show_stack+0x18/0x1c) [ 4.398512] r7:00000000 r6:60000013 r5:00000000 r4:c0e79b80 [ 4.404196] [<c010ccdc>] (show_stack) from [<c09ca560>] (dump_stack+0xb4/0xe8) [ 4.411443] [<c09ca4ac>] (dump_stack) from [<c0125654>] (__warn+0xd8/0x104) [ 4.418430] r9:c029892c r8:0000014a r7:00000009 r6:c0c06374 r5:00000000 r4:ec069b48 [ 4.426196] [<c012557c>] (__warn) from [<c01256bc>] (warn_slowpath_fmt+0x3c/0x44) [ 4.433703] r9:ec338f2c r8:00000000 r7:ec338f00 r6:00000001 r5:ec88c480 r4:c0c06404 [ 4.441470] [<c0125684>] (warn_slowpath_fmt) from [<c029892c>] (proc_register+0xc8/0x13c) [ 4.449668] r3:ec338f7d r2:c0c06404 [ 4.453263] r4:ec12c874 [ 4.455822] [<c0298864>] (proc_register) from [<c0298c64>] (proc_create_data+0x80/0xc4) [ 4.463850] r10:ec8c8000 r9:00000001 r8:00000000 r7:ec138000 r6:ec88c3c0 r5:c0a900f0 [ 4.471698] r4:ec88c480 [ 4.474261] [<c0298be4>] (proc_create_data) from [<c075456c>] (snd_info_register+0x6c/0xd4) [ 4.482632] r5:ec338f00 r4:ec88c3c0 [ 4.486234] [<c0754500>] (snd_info_register) from [<c07590ac>] (snd_pcm_new_stream+0x15c/0x454) [ 4.494953] r5:ec145800 r4:00000000 [ 4.498552] [<c0758f50>] (snd_pcm_new_stream) from [<c0759a6c>] (_snd_pcm_new+0xcc/0x13c) [ 4.506753] r10:00000000 r9:00000000 r8:00000001 r7:ec138000 r6:ec069ca4 r5:00000000 [ 4.514601] r4:ec145800 [ 4.517159] [<c07599a0>] (_snd_pcm_new) from [<c0759afc>] (snd_pcm_new+0x20/0x28) [ 4.524665] r10:ec069ca8 r9:00000001 r8:ec132c80 r7:00000000 r6:ec8a9a0c r5:00000001 [ 4.532513] r4:00000001 r3:00000001 [ 4.536112] [<c0759adc>] (snd_pcm_new) from [<c0777c0c>] (soc_new_pcm+0x12c/0x45c) [ 4.543700] r4:ec144800 [ 4.546260] [<c0777ae0>] (soc_new_pcm) from [<c076b658>] (snd_soc_register_card+0xc40/0xe38) [ 4.554721] r10:ec144800 r9:ec8cd810 r8:00000002 r7:ec8cd898 r6:ec8cd9d4 r5:ec8cd978 [ 4.562569] r4:c0c8dcb8 [ 4.565129] [<c076aa18>] (snd_soc_register_card) from [<c0778474>] (devm_snd_soc_register_card+0x38/0x78) [ 4.574719] r10:ec224400 r9:ec8cd810 r8:c0aaf308 r7:ec284c10 r6:ec8cd898 r5:ec89b150 [ 4.582567] r4:ec8cd898 [ 4.585132] [<c077843c>] (devm_snd_soc_register_card) from [<c07913a4>] (imx_wm8962_probe+0x244/0x37c) [ 4.594460] r7:ef7d9650 r6:ec284c10 r5:ec284c00 r4:ec8cd898 [ 4.600146] [<c0791160>] (imx_wm8962_probe) from [<c0546780>] (platform_drv_probe+0x54/0xb8) [ 4.608607] r10:00000000 r9:00000000 r8:c0e70228 r7:fffffdfb r6:c0e70228 r5:ec284c10 [ 4.616455] r4:ec284c10 [ 4.619019] [<c054672c>] (platform_drv_probe) from [<c0544bf4>] (driver_probe_device+0x274/0x2fc) [ 4.627913] r7:c15e6c10 r6:00000000 r5:c15e6c0c r4:ec284c10 [ 4.633600] [<c0544980>] (driver_probe_device) from [<c0544d44>] (__driver_attach+0xc8/0xcc) [ 4.642062] r10:c0d00618 r9:c0d6089c r8:00000000 r7:00000000 r6:ec284c44 r5:c0e70228 [ 4.649910] r4:ec284c10 r3:00000000 [ 4.653512] [<c0544c7c>] (__driver_attach) from [<c0542ebc>] (bus_for_each_dev+0x74/0xa8) [ 4.661711] r7:00000000 r6:c0544c7c r5:c0e70228 r4:00000000 [ 4.667397] [<c0542e48>] (bus_for_each_dev) from [<c0544530>] (driver_attach+0x20/0x28) [ 4.675421] r6:c0e3b288 r5:ec132300 r4:c0e70228 [ 4.680064] [<c0544510>] (driver_attach) from [<c054402c>] (bus_add_driver+0x190/0x218) [ 4.688093] [<c0543e9c>] (bus_add_driver) from [<c05456e4>] (driver_register+0x80/0x100) [ 4.696206] r7:c0cf5ec4 r6:c0d60894 r5:c0d4e44c r4:c0e70228 [ 4.701889] [<c0545664>] (driver_register) from [<c05466d4>] (__platform_driver_register+0x38/0x4c) [ 4.710954] r5:c0d4e44c r4:ffffe000 [ 4.714558] [<c054669c>] (__platform_driver_register) from [<c0d4e464>] (imx_wm8962_driver_init+0x18/0x20) [ 4.724239] [<c0d4e44c>] (imx_wm8962_driver_init) from [<c0101c54>] (do_one_initcall+0x44/0x17c) [ 4.733053] [<c0101c10>] (do_one_initcall) from [<c0d00e7c>] (kernel_init_freeable+0x118/0x1d0) [ 4.741774] r8:000000f1 r7:c0cf5ec4 r6:c0d60894 r5:c0e7d000 r4:c0d710e0 [ 4.748502] [<c0d00d64>] (kernel_init_freeable) from [<c09de898>] (kernel_init+0x10/0x118) [ 4.756789] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c09de888 [ 4.764637] r4:00000000 [ 4.767197] [<c09de888>] (kernel_init) from [<c01080f8>] (ret_from_fork+0x14/0x3c) [ 4.774787] r5:c09de888 r4:00000000 [ 4.778454] ---[ end trace 3ea29ef261f4780d ]---

2 2

[alsa-devel] [PATCH 0/3] ASoC: remove duplicated definitions
by Kuninori Morimoto 24 Aug '17

24 Aug '17

Hi Mark, Lars-Peter This is not a big-deal, but I think these are duplicated definitions. These patches cleanup it. Kuninori Morimoto (3): ASoC: remove duplicate definition of controls/num_controls ASoC: remove duplicate definition of dapm_widgets/num_dapm_widgets ASoC: remove duplicate definition of dapm_routes/num_dapm_routes include/sound/soc.h | 6 ------ sound/soc/soc-core.c | 28 ++++++++++++---------------- 2 files changed, 12 insertions(+), 22 deletions(-) -- 1.9.1

2 4

[alsa-devel] [asoc:topic/rt5514 12/12] sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function 'rt5514_spi_burst_write'
by kbuild test robot 24 Aug '17

24 Aug '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/rt5514 head: d18420b0a0b8f8f51f55fc654b2e0eb86d8b41d7 commit: d18420b0a0b8f8f51f55fc654b2e0eb86d8b41d7 [12/12] ASoC: rt5514: expose Hotword Model control config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout d18420b0a0b8f8f51f55fc654b2e0eb86d8b41d7 # save the attached .config to linux build tree make.cross ARCH=sparc64 All errors (new ones prefixed by >>): sound/soc/codecs/rt5514.c: In function 'rt5514_dsp_voice_wake_up_put': >> sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function 'rt5514_spi_burst_write' [-Werror=implicit-function-declaration] ret = rt5514_spi_burst_write(0x4ff80000, ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/rt5514_spi_burst_write +343 sound/soc/codecs/rt5514.c 297 298 static int rt5514_dsp_voice_wake_up_put(struct snd_kcontrol *kcontrol, 299 struct snd_ctl_elem_value *ucontrol) 300 { 301 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 302 struct rt5514_priv *rt5514 = snd_soc_component_get_drvdata(component); 303 struct snd_soc_codec *codec = rt5514->codec; 304 const struct firmware *fw = NULL; 305 int ret = 0; 306 307 if (ucontrol->value.integer.value[0] == rt5514->dsp_enabled) 308 return 0; 309 310 if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_OFF) { 311 rt5514->dsp_enabled = ucontrol->value.integer.value[0]; 312 313 if (rt5514->dsp_enabled) { 314 rt5514_enable_dsp_prepare(rt5514); 315 316 request_firmware(&fw, RT5514_FIRMWARE1, codec->dev); 317 if (fw) { 318 #if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI) 319 rt5514_spi_burst_write(0x4ff60000, fw->data, 320 ((fw->size/8)+1)*8); 321 #else 322 dev_err(codec->dev, "There is no SPI driver for" 323 " loading the firmware\n"); 324 #endif 325 release_firmware(fw); 326 fw = NULL; 327 } 328 329 request_firmware(&fw, RT5514_FIRMWARE2, codec->dev); 330 if (fw) { 331 #if IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI) 332 rt5514_spi_burst_write(0x4ffc0000, fw->data, 333 ((fw->size/8)+1)*8); 334 #else 335 dev_err(codec->dev, "There is no SPI driver for" 336 " loading the firmware\n"); 337 #endif 338 release_firmware(fw); 339 fw = NULL; 340 } 341 342 if (rt5514->model_buf && rt5514->model_len) { > 343 ret = rt5514_spi_burst_write(0x4ff80000, 344 rt5514->model_buf, 345 ((rt5514->model_len / 8) + 1) * 8); 346 if (ret) { 347 dev_err(codec->dev, 348 "Model load failed %d\n", ret); 349 return ret; 350 } 351 } else { 352 request_firmware(&fw, RT5514_FIRMWARE3, 353 codec->dev); 354 if (fw) { 355 rt5514_spi_burst_write(0x4ff80000, 356 fw->data, 357 ((fw->size/8)+1)*8); 358 release_firmware(fw); 359 fw = NULL; 360 } 361 } 362 363 /* DSP run */ 364 regmap_write(rt5514->i2c_regmap, 0x18002f00, 365 0x00055148); 366 } else { 367 regmap_multi_reg_write(rt5514->i2c_regmap, 368 rt5514_i2c_patch, ARRAY_SIZE(rt5514_i2c_patch)); 369 regcache_mark_dirty(rt5514->regmap); 370 regcache_sync(rt5514->regmap); 371 } 372 } 373 374 return 0; 375 } 376 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: codecs: msm8916-wcd-analog: always true condition
by Dan Carpenter 24 Aug '17

24 Aug '17

Static checkers complain that unsigned int val is always >= 0. The context is that snd_soc_read() returns -1U on error. This is harmless because we're checking that CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK is not set, and it will always be set for -1U. I could have just removed the check against -1 but I preserved it because I thought it helped with readability. Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c index 4aa878d29098..549c269acc7d 100644 --- a/sound/soc/codecs/msm8916-wcd-analog.c +++ b/sound/soc/codecs/msm8916-wcd-analog.c @@ -949,7 +949,7 @@ static irqreturn_t mbhc_btn_release_irq_handler(int irq, void *arg) u32 val = snd_soc_read(codec, CDC_A_MBHC_RESULT_1); /* check if its BTN0 thats released */ - if ((val >= 0) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK)) + if ((val != -1) && !(val & CDC_A_MBHC_RESULT_1_BTN_RESULT_MASK)) priv->mbhc_btn0_pressed = false; } else {

3 2