August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [GIT PULL]: intel audio firmware updates
by Vinod Koul 23 Aug '17

23 Aug '17

Hi, Please pull to receive updated KBL audio firmware. Along with this time for some cleaning of the exiting files and remove no longer used SKL and BXT fw files. The following changes since commit 7d2c913dcd1be083350d97a8cb1eba24cfacbc8a: ath10k: update year in license (2017-06-22 12:06:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git intel for you to fetch changes up to 7b7513e03eb6949f39fba2eb4b661c31f8ea6f5b: linux-firmware: intel: remove old broxton firmware (2017-08-21 10:35:32 +0530) ---------------------------------------------------------------- Subhransu S. Prusty (1): linux-firmware: intel: Update Kabylake audio firmware Vinod Koul (2): linux-firmware: intel: remove old skylake firmware linux-firmware: intel: remove old broxton firmware WHENCE | 26 +++----------------------- intel/dsp_fw_bxtn_v1118.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v2010.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v430.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v702.bin | Bin 505608 -> 0 bytes intel/dsp_fw_kbl.bin | 2 +- intel/dsp_fw_kbl_v2630.bin | Bin 0 -> 243016 bytes intel/dsp_fw_release_v827.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v869.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v896.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v927.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v948.bin | Bin 221184 -> 0 bytes intel/dsp_fw_release_v951.bin | Bin 221184 -> 0 bytes intel/dsp_fw_release_v958.bin | Bin 221184 -> 0 bytes 14 files changed, 4 insertions(+), 24 deletions(-) delete mode 100644 intel/dsp_fw_bxtn_v1118.bin delete mode 100644 intel/dsp_fw_bxtn_v2010.bin delete mode 100644 intel/dsp_fw_bxtn_v430.bin delete mode 100644 intel/dsp_fw_bxtn_v702.bin create mode 100644 intel/dsp_fw_kbl_v2630.bin delete mode 100644 intel/dsp_fw_release_v827.bin delete mode 100644 intel/dsp_fw_release_v869.bin delete mode 100644 intel/dsp_fw_release_v896.bin delete mode 100644 intel/dsp_fw_release_v927.bin delete mode 100644 intel/dsp_fw_release_v948.bin delete mode 100644 intel/dsp_fw_release_v951.bin delete mode 100644 intel/dsp_fw_release_v958.bin Thanks -- ~Vinod

2 1

[alsa-devel] [PATCH] ASoC: rt5645: make rt5645_platform_data const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make these const as they are only used during a copy operation. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct rt5645_platform_data s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p | e = s(a)p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct rt5645_platform_data s; Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/soc/codecs/rt5645.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index f14f648..efec452 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3559,7 +3559,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) MODULE_DEVICE_TABLE(acpi, rt5645_acpi_match); #endif -static struct rt5645_platform_data general_platform_data = { +static const struct rt5645_platform_data general_platform_data = { .dmic1_data_pin = RT5645_DMIC1_DISABLE, .dmic2_data_pin = RT5645_DMIC_DATA_IN2P, .jd_mode = 3, @@ -3593,7 +3593,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) { } }; -static struct rt5645_platform_data buddy_platform_data = { +static const struct rt5645_platform_data buddy_platform_data = { .dmic1_data_pin = RT5645_DMIC_DATA_GPIO5, .dmic2_data_pin = RT5645_DMIC_DATA_IN2P, .jd_mode = 3, @@ -3610,7 +3610,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) { } }; -static struct rt5645_platform_data gpd_win_platform_data = { +static const struct rt5645_platform_data gpd_win_platform_data = { .jd_mode = 3, .inv_jd1_1 = true, }; -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: tegra: Remove superfluous 'machine' variable
by Arnd Bergmann 23 Aug '17

23 Aug '17

The last cleanup left behind an unused variable: sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove': sound/soc/tegra/tegra_wm8903.c:206:23: error: unused variable 'machine' [-Werror=unused-variable] This removes it as welremoves it as welll Fixes: 2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/tegra/tegra_wm8903.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c index 2384cb9cb95c..18bdae59a4df 100644 --- a/sound/soc/tegra/tegra_wm8903.c +++ b/sound/soc/tegra/tegra_wm8903.c @@ -203,7 +203,6 @@ static int tegra_wm8903_remove(struct snd_soc_card *card) snd_soc_get_pcm_runtime(card, card->dai_link[0].name); struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_codec *codec = codec_dai->codec; - struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card); wm8903_mic_detect(codec, NULL, 0, 0); -- 2.9.0

2 2

[alsa-devel] [PATCH] ALSA: ctxfi: make hw structures const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make these const as they are only used in a copy operation. Done using Coccinelle: @match disable optional_qualifier@ identifier s; @@ static struct hw s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p | e = s(a)p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct hw s; Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/pci/ctxfi/cthw20k1.c | 2 +- sound/pci/ctxfi/cthw20k2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/ctxfi/cthw20k1.c b/sound/pci/ctxfi/cthw20k1.c index 79edd88..8e6eb9d 100644 --- a/sound/pci/ctxfi/cthw20k1.c +++ b/sound/pci/ctxfi/cthw20k1.c @@ -2154,7 +2154,7 @@ static void hw_write_pci(struct hw *hw, u32 reg, u32 data) &container_of(hw, struct hw20k1, hw)->reg_pci_lock, flags); } -static struct hw ct20k1_preset = { +static const struct hw ct20k1_preset = { .irq = -1, .card_init = hw_card_init, diff --git a/sound/pci/ctxfi/cthw20k2.c b/sound/pci/ctxfi/cthw20k2.c index 18ee776..b866d6b 100644 --- a/sound/pci/ctxfi/cthw20k2.c +++ b/sound/pci/ctxfi/cthw20k2.c @@ -2220,7 +2220,7 @@ static void hw_write_20kx(struct hw *hw, u32 reg, u32 data) writel(data, hw->mem_base + reg); } -static struct hw ct20k2_preset = { +static const struct hw ct20k2_preset = { .irq = -1, .card_init = hw_card_init, -- 1.9.1

2 1

[alsa-devel] [PATCH 0/4] constify ac97_pcm structures
by Arvind Yadav 23 Aug '17

23 Aug '17

ac97_pcm are not supposed to change at runtime. All functions working with ac97_pcm provided by <sound/ac97_codec.h> work with const ac97_pcm. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] ALSA: aaci: constify ac97_pcm structures [PATCH 2/4] ALSA: ac97c: constify ac97_pcm structures [PATCH 3/4] ALSA: atiixp: constify ac97_pcm structures [PATCH 4/4] ALSA: intel8x0: constify ac97_pcm structures sound/arm/aaci.c | 2 +- sound/atmel/ac97c.c | 2 +- sound/pci/atiixp.c | 2 +- sound/pci/intel8x0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1

2 5

[alsa-devel] [PATCH] ALSA: Fireface: Use common error handling code in pcm_open()
by SF Markus Elfring 23 Aug '17

23 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Tue, 22 Aug 2017 21:45:42 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/firewire/fireface/ff-pcm.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/firewire/fireface/ff-pcm.c b/sound/firewire/fireface/ff-pcm.c index d12a0e3a4219..40975395a64a 100644 --- a/sound/firewire/fireface/ff-pcm.c +++ b/sound/firewire/fireface/ff-pcm.c @@ -138,16 +138,12 @@ static int pcm_open(struct snd_pcm_substream *substream) return err; err = pcm_init_hw_params(ff, substream); - if (err < 0) { - snd_ff_stream_lock_release(ff); - return err; - } + if (err < 0) + goto release_lock; err = ff->spec->protocol->get_clock(ff, &rate, &src); - if (err < 0) { - snd_ff_stream_lock_release(ff); - return err; - } + if (err < 0) + goto release_lock; if (src != SND_FF_CLOCK_SRC_INTERNAL) { for (i = 0; i < CIP_SFC_COUNT; ++i) { @@ -177,6 +173,10 @@ static int pcm_open(struct snd_pcm_substream *substream) snd_pcm_set_sync(substream); return 0; + +release_lock: + snd_ff_stream_lock_release(ff); + return err; } static int pcm_close(struct snd_pcm_substream *substream) -- 2.14.0

3 4

[alsa-devel] Fixed latency between multiple channels
by cuhl＠eit.uni-kl.de 23 Aug '17

23 Aug '17

Hello Alsa-Developers, currently I try to decide, if ALSA is useable for a certain multi-channel signal processing task. I've read, that even with a realtime kernel the input-output latency varies with time - especially if USB is inbetween. Even so this is not what I actually want, I think the application might be sufficiently robust against this. However I expect to require a fixed latency between multiple ( I2S ) channels. This shall include stereo, but extend to all channels ( between 6 to 12 mono / 3 to 6 srereo channels probably ). So every channel's signal shall be exactly determined to its relative position with respect to the other channels, e. g. it shall be known inside the system which events occured simultanously. Likewise, the processed or generated signals shall be transferred to the outputs in a way, that they occur there with intended and modifiable relative latency to each other. Is this ensured by the ALSA architecture or is it at least possible to ensure it, if it is used? Any comments or answers are appreciated. Kind regards Christian

2 1

[alsa-devel] [asoc:topic/intel 52/54] sound/soc/intel/skylake/skl-messages.c:320:9: warning: 'ret' may be used uninitialized in this function
by kbuild test robot 23 Aug '17

23 Aug '17

tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/intel head: 7b992c24de78a206b3abd07192686d2d5db5012c commit: f77d443c4c299aff5ad9c74811dd063f4d8bebcf [52/54] ASoC: Intel: Skylake: Fix to free resources for dsp_init failure config: x86_64-randconfig-ne0-08232016 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout f77d443c4c299aff5ad9c74811dd063f4d8bebcf # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): sound/soc/intel/skylake/skl-messages.c: In function 'skl_init_dsp': >> sound/soc/intel/skylake/skl-messages.c:320:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^~~ vim +/ret +320 sound/soc/intel/skylake/skl-messages.c bc23ca35c Jeeja KP 2016-03-11 256 d255b0955 Jeeja KP 2015-07-21 257 int skl_init_dsp(struct skl *skl) d255b0955 Jeeja KP 2015-07-21 258 { d255b0955 Jeeja KP 2015-07-21 259 void __iomem *mmio_base; d255b0955 Jeeja KP 2015-07-21 260 struct hdac_ext_bus *ebus = &skl->ebus; d255b0955 Jeeja KP 2015-07-21 261 struct hdac_bus *bus = ebus_to_hbus(ebus); d255b0955 Jeeja KP 2015-07-21 262 struct skl_dsp_loader_ops loader_ops; bc23ca35c Jeeja KP 2016-03-11 263 int irq = bus->irq; 73a675816 Vinod Koul 2016-07-26 264 const struct skl_dsp_ops *ops; f0a550a88 Guneshwor Singh 2017-08-02 265 struct skl_dsp_cores *cores; 73a675816 Vinod Koul 2016-07-26 266 int ret; d255b0955 Jeeja KP 2015-07-21 267 d255b0955 Jeeja KP 2015-07-21 268 /* enable ppcap interrupt */ d255b0955 Jeeja KP 2015-07-21 269 snd_hdac_ext_bus_ppcap_enable(&skl->ebus, true); d255b0955 Jeeja KP 2015-07-21 270 snd_hdac_ext_bus_ppcap_int_enable(&skl->ebus, true); d255b0955 Jeeja KP 2015-07-21 271 d255b0955 Jeeja KP 2015-07-21 272 /* read the BAR of the ADSP MMIO */ d255b0955 Jeeja KP 2015-07-21 273 mmio_base = pci_ioremap_bar(skl->pci, 4); d255b0955 Jeeja KP 2015-07-21 274 if (mmio_base == NULL) { d255b0955 Jeeja KP 2015-07-21 275 dev_err(bus->dev, "ioremap error\n"); d255b0955 Jeeja KP 2015-07-21 276 return -ENXIO; d255b0955 Jeeja KP 2015-07-21 277 } d255b0955 Jeeja KP 2015-07-21 278 73a675816 Vinod Koul 2016-07-26 279 ops = skl_get_dsp_ops(skl->pci->device); f77d443c4 Subhransu S. Prusty 2017-08-22 280 if (!ops) { f77d443c4 Subhransu S. Prusty 2017-08-22 281 goto unmap_mmio; f77d443c4 Subhransu S. Prusty 2017-08-22 282 ret = -EIO; f77d443c4 Subhransu S. Prusty 2017-08-22 283 } bc23ca35c Jeeja KP 2016-03-11 284 73a675816 Vinod Koul 2016-07-26 285 loader_ops = ops->loader_ops(); 73a675816 Vinod Koul 2016-07-26 286 ret = ops->init(bus->dev, mmio_base, irq, 73a675816 Vinod Koul 2016-07-26 287 skl->fw_name, loader_ops, 73a675816 Vinod Koul 2016-07-26 288 &skl->skl_sst); bc23ca35c Jeeja KP 2016-03-11 289 2ac454ffe Jeeja KP 2015-10-22 290 if (ret < 0) f77d443c4 Subhransu S. Prusty 2017-08-22 291 goto unmap_mmio; 2ac454ffe Jeeja KP 2015-10-22 292 7bd86a305 G Kranthi 2017-03-13 293 skl->skl_sst->dsp_ops = ops; f0a550a88 Guneshwor Singh 2017-08-02 294 cores = &skl->skl_sst->cores; f0a550a88 Guneshwor Singh 2017-08-02 295 cores->count = ops->num_cores; f0a550a88 Guneshwor Singh 2017-08-02 296 f0a550a88 Guneshwor Singh 2017-08-02 297 cores->state = kcalloc(cores->count, sizeof(*cores->state), GFP_KERNEL); f77d443c4 Subhransu S. Prusty 2017-08-22 298 if (!cores->state) { f77d443c4 Subhransu S. Prusty 2017-08-22 299 ret = -ENOMEM; f77d443c4 Subhransu S. Prusty 2017-08-22 300 goto unmap_mmio; f77d443c4 Subhransu S. Prusty 2017-08-22 301 } f0a550a88 Guneshwor Singh 2017-08-02 302 f0a550a88 Guneshwor Singh 2017-08-02 303 cores->usage_count = kcalloc(cores->count, sizeof(*cores->usage_count), f0a550a88 Guneshwor Singh 2017-08-02 304 GFP_KERNEL); f0a550a88 Guneshwor Singh 2017-08-02 305 if (!cores->usage_count) { f77d443c4 Subhransu S. Prusty 2017-08-22 306 ret = -ENOMEM; f77d443c4 Subhransu S. Prusty 2017-08-22 307 goto free_core_state; f0a550a88 Guneshwor Singh 2017-08-02 308 } 363d45385 Dharageswari R 2017-08-02 309 d255b0955 Jeeja KP 2015-07-21 310 dev_dbg(bus->dev, "dsp registration status=%d\n", ret); d255b0955 Jeeja KP 2015-07-21 311 f77d443c4 Subhransu S. Prusty 2017-08-22 312 return 0; f77d443c4 Subhransu S. Prusty 2017-08-22 313 f77d443c4 Subhransu S. Prusty 2017-08-22 314 free_core_state: f77d443c4 Subhransu S. Prusty 2017-08-22 315 kfree(cores->state); f77d443c4 Subhransu S. Prusty 2017-08-22 316 f77d443c4 Subhransu S. Prusty 2017-08-22 317 unmap_mmio: f77d443c4 Subhransu S. Prusty 2017-08-22 318 iounmap(mmio_base); f77d443c4 Subhransu S. Prusty 2017-08-22 319 d255b0955 Jeeja KP 2015-07-21 @320 return ret; d255b0955 Jeeja KP 2015-07-21 321 } d255b0955 Jeeja KP 2015-07-21 322 :::::: The code at line 320 was first introduced by commit :::::: d255b09555e8ea0e517a4d3368ec60097ac9cf96 ASoC: Intel: Skylake: Add dsp and ipc init helpers :::::: TO: Jeeja KP <jeeja.kp(a)intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH] ASoC: tegra: Fix unused variable warning
by Takashi Iwai 23 Aug '17

23 Aug '17

Fixes: 2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call") Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/soc/tegra/tegra_wm8903.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c index ce498cc0914b..05f95944669a 100644 --- a/sound/soc/tegra/tegra_wm8903.c +++ b/sound/soc/tegra/tegra_wm8903.c @@ -203,7 +203,6 @@ static int tegra_wm8903_remove(struct snd_soc_card *card) snd_soc_get_pcm_runtime(card, card->dai_link[0].name); struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_codec *codec = codec_dai->codec; - struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card); wm8903_mic_detect(codec, NULL, 0, 0); -- 2.14.0

2 1

[alsa-devel] [PATCH] ASoC: wm8524: remove unnecessary snd_soc_unregister_platform()
by Kuninori Morimoto 23 Aug '17

23 Aug '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> wm8524 doesn't register platform, unregister platform is not needed Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/codecs/wm8524.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8524.c b/sound/soc/codecs/wm8524.c index b66147e..856a695 100644 --- a/sound/soc/codecs/wm8524.c +++ b/sound/soc/codecs/wm8524.c @@ -233,10 +233,8 @@ static int wm8524_codec_probe(struct platform_device *pdev) ret = snd_soc_register_codec(&pdev->dev, &soc_codec_dev_wm8524, &wm8524_dai, 1); - if (ret < 0) { + if (ret < 0) dev_err(&pdev->dev, "Failed to register codec: %d\n", ret); - snd_soc_unregister_platform(&pdev->dev); - } return ret; } -- 1.9.1

2 1