August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH 00/11] ASoC: make snd_soc_platform_driver const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make snd_soc_platform_driver const. Bhumika Goyal (11): ASoC: codecs: make snd_soc_platform_driver const ASoC: Intel: make snd_soc_platform_driver const ASoC: fsl: make snd_soc_platform_driver const ASoC: nuc900: make snd_soc_platform_driver const ASoC: omap: make snd_soc_platform_driver const ASoC: pxa: make snd_soc_platform_driver const ASoC: qcom: make snd_soc_platform_driver const ASoC: samsung: make snd_soc_platform_driver const ASoC: sh: make snd_soc_platform_driver const ASoC: txx9: make snd_soc_platform_driver const ASoC: soc-utils: make snd_soc_platform_driver const sound/soc/codecs/cs47l24.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/codecs/wm5102.c | 2 +- sound/soc/codecs/wm5110.c | 2 +- sound/soc/fsl/imx-pcm-fiq.c | 2 +- sound/soc/fsl/mpc5200_dma.c | 2 +- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +- sound/soc/intel/baytrail/sst-baytrail-pcm.c | 2 +- sound/soc/intel/haswell/sst-haswell-pcm.c | 2 +- sound/soc/intel/skylake/skl-pcm.c | 2 +- sound/soc/nuc900/nuc900-pcm.c | 2 +- sound/soc/omap/omap-pcm.c | 2 +- sound/soc/pxa/mmp-pcm.c | 2 +- sound/soc/pxa/pxa2xx-pcm.c | 2 +- sound/soc/qcom/lpass-platform.c | 2 +- sound/soc/samsung/idma.c | 2 +- sound/soc/sh/dma-sh7760.c | 2 +- sound/soc/sh/fsi.c | 2 +- sound/soc/sh/rcar/core.c | 2 +- sound/soc/soc-utils.c | 2 +- sound/soc/txx9/txx9aclc.c | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) -- 1.9.1

8 18

[alsa-devel] [ANNOUNCE RESENT] Audio Mini Summit 2017 at Prague, Oct 27
by Takashi Iwai 23 Aug '17

23 Aug '17

Hi, this is a gentle reminder for people who missed the previous announcement for Audio Mini Summit. Below is the content I posted in a month ago. If anyone is interested, please join up! thanks, Takashi === Hi, this is an announcement of Audio Mini Summit 2017. It's an annual meeting we regularly have along with major Linux conferences, and this year, we'll hold the meeting at Prague (Czech Republic) on Friday, October 27, right after GStreamer Summit, ELCE and Open Source Summit Europe. We planned a whole-day meeting, and will likely have an evening dinner event, too. Please note that the meeting will be held in a conference room of SUSE Prague office, not in Hilton hotel where ELCE/OSSE is held. It's located near Hilton, just a couple of blocks away. The address of SUSE office is: Corso II, Křižíkova 148/34, 18600 Praha 8 https://goo.gl/maps/anET1yh3XXu Also, since the conference room is hosted by SUSE, it's an open event at this time; that is, you can attend only this meeting without registration for other Linux Foundation events in that week, too. If you are interested in the event, please fill up the registration form in Google doc spreadsheet below: https://docs.google.com/spreadsheets/d/1a-RaYtTVVtgh_cyRN5GwATiixppGCMEwqw6… Just add yourself in the attendee list from the web page. And, now we are gathering the topics to discuss, too. If you have any interesting topics to be discussed in the meeting, feel free to post to alsa-devel ML. I'm going to write up later. thanks, Takashi

1 0

[alsa-devel] [PATCH] ALSA: aaci: constify amba_id
by Arvind Yadav 23 Aug '17

23 Aug '17

amba_id are not supposed to change at runtime. All functions working with const amba_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav <arvind.yadav.cs(a)gmail.com> --- sound/arm/aaci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c index 4140b1b..05562ba 100644 --- a/sound/arm/aaci.c +++ b/sound/arm/aaci.c @@ -1085,7 +1085,7 @@ static int aaci_remove(struct amba_device *dev) return 0; } -static struct amba_id aaci_ids[] = { +static const struct amba_id aaci_ids[] = { { .id = 0x00041041, .mask = 0x000fffff, -- 2.7.4

1 0

[alsa-devel] [GIT PULL]: intel audio firmware updates
by Vinod Koul 23 Aug '17

23 Aug '17

Hi, Please pull to receive updated KBL audio firmware. Along with this time for some cleaning of the exiting files and remove no longer used SKL and BXT fw files. The following changes since commit 7d2c913dcd1be083350d97a8cb1eba24cfacbc8a: ath10k: update year in license (2017-06-22 12:06:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git intel for you to fetch changes up to 7b7513e03eb6949f39fba2eb4b661c31f8ea6f5b: linux-firmware: intel: remove old broxton firmware (2017-08-21 10:35:32 +0530) ---------------------------------------------------------------- Subhransu S. Prusty (1): linux-firmware: intel: Update Kabylake audio firmware Vinod Koul (2): linux-firmware: intel: remove old skylake firmware linux-firmware: intel: remove old broxton firmware WHENCE | 26 +++----------------------- intel/dsp_fw_bxtn_v1118.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v2010.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v430.bin | Bin 505608 -> 0 bytes intel/dsp_fw_bxtn_v702.bin | Bin 505608 -> 0 bytes intel/dsp_fw_kbl.bin | 2 +- intel/dsp_fw_kbl_v2630.bin | Bin 0 -> 243016 bytes intel/dsp_fw_release_v827.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v869.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v896.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v927.bin | Bin 233472 -> 0 bytes intel/dsp_fw_release_v948.bin | Bin 221184 -> 0 bytes intel/dsp_fw_release_v951.bin | Bin 221184 -> 0 bytes intel/dsp_fw_release_v958.bin | Bin 221184 -> 0 bytes 14 files changed, 4 insertions(+), 24 deletions(-) delete mode 100644 intel/dsp_fw_bxtn_v1118.bin delete mode 100644 intel/dsp_fw_bxtn_v2010.bin delete mode 100644 intel/dsp_fw_bxtn_v430.bin delete mode 100644 intel/dsp_fw_bxtn_v702.bin create mode 100644 intel/dsp_fw_kbl_v2630.bin delete mode 100644 intel/dsp_fw_release_v827.bin delete mode 100644 intel/dsp_fw_release_v869.bin delete mode 100644 intel/dsp_fw_release_v896.bin delete mode 100644 intel/dsp_fw_release_v927.bin delete mode 100644 intel/dsp_fw_release_v948.bin delete mode 100644 intel/dsp_fw_release_v951.bin delete mode 100644 intel/dsp_fw_release_v958.bin Thanks -- ~Vinod

2 1

[alsa-devel] [PATCH] ASoC: rt5645: make rt5645_platform_data const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make these const as they are only used during a copy operation. Done using Coccinelle. @match disable optional_qualifier@ identifier s; @@ static struct rt5645_platform_data s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p | e = s(a)p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct rt5645_platform_data s; Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/soc/codecs/rt5645.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index f14f648..efec452 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3559,7 +3559,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) MODULE_DEVICE_TABLE(acpi, rt5645_acpi_match); #endif -static struct rt5645_platform_data general_platform_data = { +static const struct rt5645_platform_data general_platform_data = { .dmic1_data_pin = RT5645_DMIC1_DISABLE, .dmic2_data_pin = RT5645_DMIC_DATA_IN2P, .jd_mode = 3, @@ -3593,7 +3593,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) { } }; -static struct rt5645_platform_data buddy_platform_data = { +static const struct rt5645_platform_data buddy_platform_data = { .dmic1_data_pin = RT5645_DMIC_DATA_GPIO5, .dmic2_data_pin = RT5645_DMIC_DATA_IN2P, .jd_mode = 3, @@ -3610,7 +3610,7 @@ static int rt5645_resume(struct snd_soc_codec *codec) { } }; -static struct rt5645_platform_data gpd_win_platform_data = { +static const struct rt5645_platform_data gpd_win_platform_data = { .jd_mode = 3, .inv_jd1_1 = true, }; -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: tegra: Remove superfluous 'machine' variable
by Arnd Bergmann 23 Aug '17

23 Aug '17

The last cleanup left behind an unused variable: sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove': sound/soc/tegra/tegra_wm8903.c:206:23: error: unused variable 'machine' [-Werror=unused-variable] This removes it as welremoves it as welll Fixes: 2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/tegra/tegra_wm8903.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c index 2384cb9cb95c..18bdae59a4df 100644 --- a/sound/soc/tegra/tegra_wm8903.c +++ b/sound/soc/tegra/tegra_wm8903.c @@ -203,7 +203,6 @@ static int tegra_wm8903_remove(struct snd_soc_card *card) snd_soc_get_pcm_runtime(card, card->dai_link[0].name); struct snd_soc_dai *codec_dai = rtd->codec_dai; struct snd_soc_codec *codec = codec_dai->codec; - struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card); wm8903_mic_detect(codec, NULL, 0, 0); -- 2.9.0

2 2

[alsa-devel] [PATCH] ALSA: ctxfi: make hw structures const
by Bhumika Goyal 23 Aug '17

23 Aug '17

Make these const as they are only used in a copy operation. Done using Coccinelle: @match disable optional_qualifier@ identifier s; @@ static struct hw s = {...}; @ref@ position p; identifier match.s; @@ s@p @good1@ position ref.p; identifier match.s,f,c; expression e; @@ ( e = s@p | e = s(a)p.f | c(...,s@p.f,...) | c(...,s@p,...) ) @bad depends on !good1@ position ref.p; identifier match.s; @@ s@p @depends on forall !bad disable optional_qualifier@ identifier match.s; @@ static + const struct hw s; Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/pci/ctxfi/cthw20k1.c | 2 +- sound/pci/ctxfi/cthw20k2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/ctxfi/cthw20k1.c b/sound/pci/ctxfi/cthw20k1.c index 79edd88..8e6eb9d 100644 --- a/sound/pci/ctxfi/cthw20k1.c +++ b/sound/pci/ctxfi/cthw20k1.c @@ -2154,7 +2154,7 @@ static void hw_write_pci(struct hw *hw, u32 reg, u32 data) &container_of(hw, struct hw20k1, hw)->reg_pci_lock, flags); } -static struct hw ct20k1_preset = { +static const struct hw ct20k1_preset = { .irq = -1, .card_init = hw_card_init, diff --git a/sound/pci/ctxfi/cthw20k2.c b/sound/pci/ctxfi/cthw20k2.c index 18ee776..b866d6b 100644 --- a/sound/pci/ctxfi/cthw20k2.c +++ b/sound/pci/ctxfi/cthw20k2.c @@ -2220,7 +2220,7 @@ static void hw_write_20kx(struct hw *hw, u32 reg, u32 data) writel(data, hw->mem_base + reg); } -static struct hw ct20k2_preset = { +static const struct hw ct20k2_preset = { .irq = -1, .card_init = hw_card_init, -- 1.9.1

2 1

[alsa-devel] [PATCH 0/4] constify ac97_pcm structures
by Arvind Yadav 23 Aug '17

23 Aug '17

ac97_pcm are not supposed to change at runtime. All functions working with ac97_pcm provided by <sound/ac97_codec.h> work with const ac97_pcm. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] ALSA: aaci: constify ac97_pcm structures [PATCH 2/4] ALSA: ac97c: constify ac97_pcm structures [PATCH 3/4] ALSA: atiixp: constify ac97_pcm structures [PATCH 4/4] ALSA: intel8x0: constify ac97_pcm structures sound/arm/aaci.c | 2 +- sound/atmel/ac97c.c | 2 +- sound/pci/atiixp.c | 2 +- sound/pci/intel8x0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1

2 5

[alsa-devel] [PATCH] ALSA: Fireface: Use common error handling code in pcm_open()
by SF Markus Elfring 23 Aug '17

23 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Tue, 22 Aug 2017 21:45:42 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/firewire/fireface/ff-pcm.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/firewire/fireface/ff-pcm.c b/sound/firewire/fireface/ff-pcm.c index d12a0e3a4219..40975395a64a 100644 --- a/sound/firewire/fireface/ff-pcm.c +++ b/sound/firewire/fireface/ff-pcm.c @@ -138,16 +138,12 @@ static int pcm_open(struct snd_pcm_substream *substream) return err; err = pcm_init_hw_params(ff, substream); - if (err < 0) { - snd_ff_stream_lock_release(ff); - return err; - } + if (err < 0) + goto release_lock; err = ff->spec->protocol->get_clock(ff, &rate, &src); - if (err < 0) { - snd_ff_stream_lock_release(ff); - return err; - } + if (err < 0) + goto release_lock; if (src != SND_FF_CLOCK_SRC_INTERNAL) { for (i = 0; i < CIP_SFC_COUNT; ++i) { @@ -177,6 +173,10 @@ static int pcm_open(struct snd_pcm_substream *substream) snd_pcm_set_sync(substream); return 0; + +release_lock: + snd_ff_stream_lock_release(ff); + return err; } static int pcm_close(struct snd_pcm_substream *substream) -- 2.14.0

3 4

[alsa-devel] Fixed latency between multiple channels
by cuhl＠eit.uni-kl.de 23 Aug '17

23 Aug '17

Hello Alsa-Developers, currently I try to decide, if ALSA is useable for a certain multi-channel signal processing task. I've read, that even with a realtime kernel the input-output latency varies with time - especially if USB is inbetween. Even so this is not what I actually want, I think the application might be sufficiently robust against this. However I expect to require a fixed latency between multiple ( I2S ) channels. This shall include stereo, but extend to all channels ( between 6 to 12 mono / 3 to 6 srereo channels probably ). So every channel's signal shall be exactly determined to its relative position with respect to the other channels, e. g. it shall be known inside the system which events occured simultanously. Likewise, the processed or generated signals shall be transferred to the outputs in a way, that they occur there with intended and modifiable relative latency to each other. Is this ensured by the ALSA architecture or is it at least possible to ensure it, if it is used? Any comments or answers are appreciated. Kind regards Christian

2 1