- Alsa-devel - mailman.alsa-project.org

[PATCH v2] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rk_spdif_runtime_resume()
by Wang Jingjin 14 Dec '22

14 Dec '22

rk_spdif_runtime_resume() may have called clk_prepare_enable() before return from failed branches, add missing clk_disable_unprepare() in this case. Fixes: f874b80e1571 ("ASoC: rockchip: Add rockchip SPDIF transceiver driver") Signed-off-by: Wang Jingjin <wangjingjin1(a)huawei.com> --- changes in v2: - Match the subject to the content --- sound/soc/rockchip/rockchip_spdif.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockchip_spdif.c index 8bef572d3cbc..5b4f00457587 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -88,6 +88,7 @@ static int __maybe_unused rk_spdif_runtime_resume(struct device *dev) ret = clk_prepare_enable(spdif->hclk); if (ret) { + clk_disable_unprepare(spdif->mclk); dev_err(spdif->dev, "hclk clock enable failed %d\n", ret); return ret; } -- 2.25.1

2 1

ucm2: add profile for the Samsung Galaxy Note II (Midas)
by GitHub pull_request - opened 14 Dec '22

14 Dec '22

alsa-project/alsa-ucm-conf pull request #250 was opened from FrostI7Alex: Might need few changes in the future, but for now - it works. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/250 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/250.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Hans de Goede 14 Dec '22

14 Dec '22

Hello Moises, On 12/13/22 18:35, Moises Cardona wrote: > The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, > with the exception of the added SIM Card Slot. > Therefore, I'm submitting this patch which properly initializes the audio > and enables the headphone jack to work, just like it does in the > HP Stream 7. > > Signed-off-by: Moises Cardona <moisesmcardona(a)gmail.com> Thank you for your patch. According to this review: http://techlife101.com/hp-stream-8-review/ The Stream 8 has 2 speakers, so you should drop the BYT_RT5640_MONO_SPEAKER part so that both speakers will be used. Regards, Hans > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..1d964b1ceff4 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

1 0

[PATCH 0/2] dt-bindings: sound: ti, pcm3168a: json-schema conversion and fixes
by Geert Uytterhoeven 14 Dec '22

14 Dec '22

Hi all, This patch series is an attempt to convert the existing DT binding documentation for the Texas Instruments PCM3168A Audio Codec to json-schema ("another one bites the dust" ;-). It consists of two parts: 1. The actual DT binding conversion, 2. An RFC patch to fix the impedance mismatch between the bindings and the description in the Shimafuji Kingfisher board DTS. I'm not super-familiar with the audio details, so I would be very grateful to receive your comments. Thanks! Geert Uytterhoeven (2): dt-bindings: sound: ti,pcm3168a: Convert to json-schema [RFC] arm64: dts: renesas: ulcb-kf: Fix pcm3168a audio codec node .../devicetree/bindings/sound/ti,pcm3168a.txt | 56 ---------- .../bindings/sound/ti,pcm3168a.yaml | 105 ++++++++++++++++++ arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 5 +- 3 files changed, 107 insertions(+), 59 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.txt create mode 100644 Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml -- 2.25.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

4 9

Re: ASoC: soc-pcm: Don't zero TDM masks in __soc_pcm_open() breaks SOF Audio in Lenovo laptops
by Richard Fitzgerald 13 Dec '22

13 Dec '22

On 9/12/22 16:18, Mark Brown wrote: > On Fri, Dec 09, 2022 at 05:38:54PM +0200, Péter Ujfalusi wrote: >> On 09/12/2022 16:42, Pierre-Louis Bossart wrote: > >>> Agree with the analysis, so what would be the least bad recommendation? >>> a) revert the "don't zero TDM masks" patch >>> b) backport the change to use set_stream()? > >> I would vote for b) unless other platforms report regressions. > > I don't really care either way given the backport policy. Neither do I. If you want to minimize risk, revert the patch in older backports. Lessons learned: Don't hijack a data member to pass something different from what it is intended to hold. Don't depend on a bug. Don't assume all code is using a data member for what is supposed to be in that member.

3 2

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Pierre-Louis Bossart 13 Dec '22

13 Dec '22

You need to resubmit and CC Mark Brown, Takashi Iwai, the alsa-mailing list and Hans de Goede On 12/13/22 05:59, Moises Cardona wrote: > The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB, > with the exception of the added SIM Card Slot. > Therefore, I'm submitting this patch which properly initializes the audio > and enables the headphone jack to work, just like it does in the > HP Stream 7. > > Signed-off-by: Moises Cardona <moisesmcardona(a)gmail.com> > --- > sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index fb9d9e271845..1d964b1ceff4 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* HP Stream 8 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"), > + }, > + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | > + BYT_RT5640_MONO_SPEAKER | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_SSP0_AIF1 | > + BYT_RT5640_MCLK_EN), > + }, > { /* I.T.Works TW891 */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

1 0

[PATCH] ALSA: conf: Save SND_CONFIG_TYPE_REAL with at least one decimal
by Simon Svanbom 13 Dec '22

13 Dec '22

Hi, patch for saving SND_CONFIG_TYPE_REAL with at least one decimal as to not misinterpret the value as an integer in snd_config_get_real. Example would be the sofvol configuration property min_dB and max_dB, that are required to have at least one decimal. All the best // Simon

2 1

[PATCH v2 0/4] ASoC: microchip: power saving features and cleanups
by Claudiu Beznea 13 Dec '22

13 Dec '22

Hi, The following series adds runtime PM and suspend to RAM features for mchp-pdmc driver. Along with it 2 cleanup patches were added: - patch 1/4: use vendor,device.yaml file format for Microchip AT91 ASoC bindings - patch 4/4: use FIELD_PREP() in mchp-spdiftx.c Thank you, Claudiu Beznea Changes in v2: - s/microchip,sama7g5-i2s-mcc/microchip,sama7g5-i2smcc as this is the 1st available compatible Claudiu Beznea (4): ASoC: dt-bindings: microchip: use proper naming syntax ASoC: mchp-pdmc: use runtime pm for clock power saving ASoC: mchp-pdmc: add support for suspend to RAM ASoC: mchp-spdiftx: use FIELD_PREP() where possible .../bindings/sound/mchp,i2s-mcc.yaml | 108 ------------- ...,pdmc.yaml => microchip,sama7g5-pdmc.yaml} | 0 ...rx.yaml => microchip,sama7g5-spdifrx.yaml} | 0 ...tx.yaml => microchip,sama7g5-spdiftx.yaml} | 0 sound/soc/atmel/mchp-pdmc.c | 145 ++++++++++++------ sound/soc/atmel/mchp-spdiftx.c | 8 +- 6 files changed, 101 insertions(+), 160 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml rename Documentation/devicetree/bindings/sound/{microchip,pdmc.yaml => microchip,sama7g5-pdmc.yaml} (100%) rename Documentation/devicetree/bindings/sound/{mchp,spdifrx.yaml => microchip,sama7g5-spdifrx.yaml} (100%) rename Documentation/devicetree/bindings/sound/{mchp,spdiftx.yaml => microchip,sama7g5-spdiftx.yaml} (100%) -- 2.34.1

3 6

[PATCH 4.9 04/31] ALSA: seq: Fix function prototype mismatch in snd_seq_expand_var_event
by Greg Kroah-Hartman 12 Dec '22

12 Dec '22

From: Kees Cook <keescook(a)chromium.org> [ Upstream commit 05530ef7cf7c7d700f6753f058999b1b5099a026 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. seq_copy_in_user() and seq_copy_in_kernel() did not have prototypes matching snd_seq_dump_func_t. Adjust this and remove the casts. There are not resulting binary output differences. This was found as a result of Clang's new -Wcast-function-type-strict flag, which is more sensitive than the simpler -Wcast-function-type, which only checks for type width mismatches. Reported-by: kernel test robot <lkp(a)intel.com> Link: https://lore.kernel.org/lkml/202211041527.HD8TLSE1-lkp@intel.com Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: "Gustavo A. R. Silva" <gustavoars(a)kernel.org> Cc: alsa-devel(a)alsa-project.org Signed-off-by: Kees Cook <keescook(a)chromium.org> Link: https://lore.kernel.org/r/20221118232346.never.380-kees@kernel.org Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/core/seq/seq_memory.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c index 4c8cbcd89887..42f4aa841051 100644 --- a/sound/core/seq/seq_memory.c +++ b/sound/core/seq/seq_memory.c @@ -126,15 +126,19 @@ EXPORT_SYMBOL(snd_seq_dump_var_event); * expand the variable length event to linear buffer space. */ -static int seq_copy_in_kernel(char **bufptr, const void *src, int size) +static int seq_copy_in_kernel(void *ptr, void *src, int size) { + char **bufptr = ptr; + memcpy(*bufptr, src, size); *bufptr += size; return 0; } -static int seq_copy_in_user(char __user **bufptr, const void *src, int size) +static int seq_copy_in_user(void *ptr, void *src, int size) { + char __user **bufptr = ptr; + if (copy_to_user(*bufptr, src, size)) return -EFAULT; *bufptr += size; @@ -163,8 +167,7 @@ int snd_seq_expand_var_event(const struct snd_seq_event *event, int count, char return newlen; } err = snd_seq_dump_var_event(event, - in_kernel ? (snd_seq_dump_func_t)seq_copy_in_kernel : - (snd_seq_dump_func_t)seq_copy_in_user, + in_kernel ? seq_copy_in_kernel : seq_copy_in_user, &buf); return err < 0 ? err : newlen; } -- 2.35.1

1 0

[PATCH 4.14 06/38] ALSA: seq: Fix function prototype mismatch in snd_seq_expand_var_event
by Greg Kroah-Hartman 12 Dec '22

12 Dec '22

From: Kees Cook <keescook(a)chromium.org> [ Upstream commit 05530ef7cf7c7d700f6753f058999b1b5099a026 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP attacks. If they are not identical, there is a failure at run time, which manifests as either a kernel panic or thread getting killed. seq_copy_in_user() and seq_copy_in_kernel() did not have prototypes matching snd_seq_dump_func_t. Adjust this and remove the casts. There are not resulting binary output differences. This was found as a result of Clang's new -Wcast-function-type-strict flag, which is more sensitive than the simpler -Wcast-function-type, which only checks for type width mismatches. Reported-by: kernel test robot <lkp(a)intel.com> Link: https://lore.kernel.org/lkml/202211041527.HD8TLSE1-lkp@intel.com Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: "Gustavo A. R. Silva" <gustavoars(a)kernel.org> Cc: alsa-devel(a)alsa-project.org Signed-off-by: Kees Cook <keescook(a)chromium.org> Link: https://lore.kernel.org/r/20221118232346.never.380-kees@kernel.org Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/core/seq/seq_memory.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c index ab1112e90f88..6f413c711535 100644 --- a/sound/core/seq/seq_memory.c +++ b/sound/core/seq/seq_memory.c @@ -126,15 +126,19 @@ EXPORT_SYMBOL(snd_seq_dump_var_event); * expand the variable length event to linear buffer space. */ -static int seq_copy_in_kernel(char **bufptr, const void *src, int size) +static int seq_copy_in_kernel(void *ptr, void *src, int size) { + char **bufptr = ptr; + memcpy(*bufptr, src, size); *bufptr += size; return 0; } -static int seq_copy_in_user(char __user **bufptr, const void *src, int size) +static int seq_copy_in_user(void *ptr, void *src, int size) { + char __user **bufptr = ptr; + if (copy_to_user(*bufptr, src, size)) return -EFAULT; *bufptr += size; @@ -163,8 +167,7 @@ int snd_seq_expand_var_event(const struct snd_seq_event *event, int count, char return newlen; } err = snd_seq_dump_var_event(event, - in_kernel ? (snd_seq_dump_func_t)seq_copy_in_kernel : - (snd_seq_dump_func_t)seq_copy_in_user, + in_kernel ? seq_copy_in_kernel : seq_copy_in_user, &buf); return err < 0 ? err : newlen; } -- 2.35.1

1 0