- Alsa-devel - mailman.alsa-project.org

Build Fails with AUTOMAKE v1.16.5 on Ubuntu - Solution Provided
by GitHub issues - opened 09 Dec '22

09 Dec '22

alsa-project/alsa-utils issue #182 was opened from frkli1965: I found that the prescribed compilation method in the 'INSTALL' file did not work on Ubuntu with Linux kernel v6.0.9 using 'automake 'and 'aclocal' v1.16.5! The following errors were encountered:- Updating EXTRA_DIST in m4/Makefile.am (backup is in m4/Makefile.am~) Updating configure.ac (backup is in configure.ac~) Adding an entry to ChangeLog (backup is in ChangeLog~) Please run 'aclocal -I m4' to regenerate the aclocal.m4 file. You need aclocal from GNU automake 1.9 (or newer) to do this. Then run 'autoconf' to regenerate the configure file. You might also want to copy the convenience header file gettext.h from the /usr/share/gettext directory into your package. It is a wrapper around <libintl.h> that implements the configure --disable-nls option. Press Return to acknowledge the previous two paragraphs. configure.ac:466: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:466: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 autoheader: error: '/usr/bin/autom4te' failed with exit status: 1 configure.ac:466: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:466: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 automake: error: autoconf failed with exit status: 1 configure.ac:466: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES. ./lib/autoconf/status.m4:289: AC_CONFIG_FILES is expanded from... configure.ac:466: the top level autom4te: error: /usr/bin/m4 failed with exit status: 1 ****************************************** THE FIX ****************************************** git clone https://github.com/alsa-project/alsa-utils.git cd alsa-utils wget https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.gu… wget https://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/config/config/config.sub aclocal --force -I m4 autoreconf -fiv gettextize autoheader automake --foreign --copy --add-missing ./configure --disable-alsatest --disable-alsaconf --disable-bat --disable-xmlto --with-curses=ncursesw make ********************************************************************************************* Despite lots of warnings as follows:- libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, configure.ac:22: warning: The macro `AM_PROG_LIBTOOL' is obsolete. configure.ac:26: warning: The macro `AC_ERROR' is obsolete. configure.ac:223: warning: The macro `AC_HEADER_STDC' is obsolete. configure.ac:313: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:397: warning: The macro `AC_HEADER_TIME' is obsolete. configure.ac:466: warning: AC_OUTPUT should be used without arguments. alsactl/Makefile.am:69: warning: '%'-style pattern rules are a GNU make extension gettextize: *** po/Makefile.in.in exists: use option -f if you really want to delete it. and ones regarding the .po files e.g. fr.po:828: warning: internationalised messages should not contain the '\r' escape sequence eu.po:849: warning: internationalised messages should not contain the '\r' escape sequence etc... The build and installation succeeded nevertheless. One other issue was that 'alsamixer' refused to run unless a system link was created for 'libasound_module_ctl_pipewire.so' as follows:- sudo ln -s /usr/local/lib/x86_64-linux-gnu/alsa-lib/libasound_module_ctl_pipewire.so /usr/local/lib/alsa-lib/libasound_module_ctl_pipewire.so which is most likely an Ubuntu (Debian) specific problem. The following toolchain was utilised:- aclocal (GNU automake) 1.16.5 autoreconf (GNU Autoconf) 2.71 gettextize (GNU gettext-tools) 0.21 autoheader (GNU Autoconf) 2.71 automake (GNU automake) 1.16.5 gcc version 12.1.0 (Ubuntu 12.1.0-2ubuntu1~22.04) You're welcome!!! Issue URL : https://github.com/alsa-project/alsa-utils/issues/182 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

What device should I have
by GitHub issues - opened 08 Dec '22

08 Dec '22

alsa-project/tinycompress issue #21 was opened from Duty-rok: Hello, I am tesing your library now. lsmod says that kernel has snd_compress module loaded. I have file.mp3 and try to execute cplay next way: $ cplay file.mp3 Next logs were written to output: Unable to open Compress device 0:0 ERR: cannot open device '/dev/snd/comprC0D0': No such file or directory I looked through the contents of the /dev/snd/ folder and found nothing that had prefix 'compr'. So, what device should I have to test it? Issue URL : https://github.com/alsa-project/tinycompress/issues/21 Repository URL: https://github.com/alsa-project/tinycompress

1 0

[PATCH] ASoC: dt-bindings: fsl-sai: Reinstate i.MX93 SAI compatible string
by Marek Vasut 08 Dec '22

08 Dec '22

The ASoC: dt-bindings: fsl-sai: Fix mx6ul and mx7d compatible strings dropped i.MX93 SAI compatible string, reinstate it. Fixes: 81b6c043e7ba ("ASoC: dt-bindings: fsl-sai: Fix mx6ul and mx7d compatible strings") Signed-off-by: Marek Vasut <marex(a)denx.de> --- Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt(a)linaro.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Shengjiu Wang <shengjiu.wang(a)nxp.com> Cc: devicetree(a)vger.kernel.org To: alsa-devel(a)alsa-project.org --- Documentation/devicetree/bindings/sound/fsl,sai.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml index 022da1f4583d6..c59e4edd7570c 100644 --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml @@ -38,6 +38,7 @@ properties: - fsl,imx8mq-sai - fsl,imx8qm-sai - fsl,imx8ulp-sai + - fsl,imx93-sai - fsl,vf610-sai reg: -- 2.35.1

2 1

topology: propagate nhlt plugin error to main program
by GitHub pull_request - opened 08 Dec '22

08 Dec '22

alsa-project/alsa-utils pull request #181 was opened from aiChaoSONG: Let's propagate nhlt plugin error to main program, so that we don't generate a wrong nhlt blob silently. Signed-off-by: Chao Song <chao.song(a)linux.intel.com> Request URL : https://github.com/alsa-project/alsa-utils/pull/181 Patch URL : https://github.com/alsa-project/alsa-utils/pull/181.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH] ASoC: rockchip: spdif: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume()
by Wang Jingjin 08 Dec '22

08 Dec '22

The clk_disable_unprepare() should be called in the error handling of rockchip_pdm_runtime_resume(). Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller") Signed-off-by: Wang Jingjin <wangjingjin1(a)huawei.com> --- sound/soc/rockchip/rockchip_pdm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index a7549f827235..5b1e47bdc376 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -431,6 +431,7 @@ static int rockchip_pdm_runtime_resume(struct device *dev) ret = clk_prepare_enable(pdm->hclk); if (ret) { + clk_disable_unprepare(pdm->clk); dev_err(pdm->dev, "hclock enable failed %d\n", ret); return ret; } -- 2.25.1

3 2

[PATCH 1/3] ASoC: dt-bindings: fsl-sai: Fix mx6ul and mx7d compatible strings
by Marek Vasut 08 Dec '22

08 Dec '22

Describe existing used combinations of compatible strings on MX6UL and MX7D, which are backward compatible with MX6SX. Add the missing imx7d-sai compatible string which is used on i.MX7 . Signed-off-by: Marek Vasut <marex(a)denx.de> --- Cc: Fabio Estevam <festevam(a)gmail.com> Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt(a)linaro.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Nicolin Chen <nicoleotsuka(a)gmail.com> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Shengjiu Wang <shengjiu.wang(a)gmail.com> Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: alsa-devel(a)alsa-project.org To: devicetree(a)vger.kernel.org --- .../devicetree/bindings/sound/fsl,sai.yaml | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml index 11aab891288d2..05bad828cc353 100644 --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml @@ -18,15 +18,12 @@ description: | properties: compatible: oneOf: - - enum: - - fsl,vf610-sai - - fsl,imx6sx-sai - - fsl,imx6ul-sai - - fsl,imx7ulp-sai - - fsl,imx8mq-sai - - fsl,imx8qm-sai - - fsl,imx8ulp-sai - - fsl,imx93-sai + - items: + - enum: + - fsl,imx6ul-sai + - fsl,imx7d-sai + - const: fsl,imx6sx-sai + - items: - enum: - fsl,imx8mm-sai @@ -34,6 +31,15 @@ properties: - fsl,imx8mp-sai - const: fsl,imx8mq-sai + - items: + - enum: + - fsl,imx6sx-sai + - fsl,imx7ulp-sai + - fsl,imx8mq-sai + - fsl,imx8qm-sai + - fsl,imx8ulp-sai + - fsl,vf610-sai + reg: maxItems: 1 -- 2.35.1

3 8

ucm2: alc4080 - add support for MSI PRO Z790-A WIFI
by GitHub pull_request - opened 08 Dec '22

08 Dec '22

alsa-project/alsa-ucm-conf pull request #248 was opened from adrianrudnik: Frontpanel did not work, with this change, back and frontpanel work correctly. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/248 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/248.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: soc-pcm.c: Clear DAIs parameters after stream_active is updated
by Chancel Liu 07 Dec '22

07 Dec '22

DAIs parameters should be cleared if there's no active stream. Before, we implemented it in soc_pcm_hw_free() by detecting stream_active. If the running stream is the last active stream, we're going to clear parameters. However it will cause DAIs parameters never be cleared if there're more than one stream. For example, we have stream1 and stream2 about to stop. stream2 executes soc_pcm_hw_free() before stream1 executes soc_pcm_close(). At the moment, stream2 should clear DAIs parameters. Since stream_active is not yet updated by stream1 in soc_pcm_close(), stream2 will not clear DAIs parameters. In result both stream1 and stream2 don't clear the parameters. This patch moves DAIs parameters cleanup after stream_active is updated. Signed-off-by: Chancel Liu <chancel.liu(a)nxp.com> --- sound/soc/soc-pcm.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index fb87d6d23408..85a7f0a3eb70 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -709,8 +709,17 @@ static int soc_pcm_clean(struct snd_soc_pcm_runtime *rtd, snd_soc_dpcm_mutex_assert_held(rtd); - if (!rollback) + if (!rollback) { snd_soc_runtime_deactivate(rtd, substream->stream); + /* clear the corresponding DAIs parameters when going to be inactive */ + for_each_rtd_dais(rtd, i, dai) { + if (snd_soc_dai_active(dai) == 0) + soc_pcm_set_dai_params(dai, NULL); + + if (snd_soc_dai_stream_active(dai, substream->stream) == 0) + snd_soc_dai_digital_mute(dai, 1, substream->stream); + } + } for_each_rtd_dais(rtd, i, dai) snd_soc_dai_shutdown(dai, substream, rollback); @@ -945,15 +954,6 @@ static int soc_pcm_hw_clean(struct snd_soc_pcm_runtime *rtd, snd_soc_dpcm_mutex_assert_held(rtd); - /* clear the corresponding DAIs parameters when going to be inactive */ - for_each_rtd_dais(rtd, i, dai) { - if (snd_soc_dai_active(dai) == 1) - soc_pcm_set_dai_params(dai, NULL); - - if (snd_soc_dai_stream_active(dai, substream->stream) == 1) - snd_soc_dai_digital_mute(dai, 1, substream->stream); - } - /* run the stream event */ snd_soc_dapm_stream_stop(rtd, substream->stream); -- 2.25.1

2 1

[PATCH] ASoC: codecs: wcd-clsh: Remove the unused function
by Jiapeng Chong 07 Dec '22

07 Dec '22

The function wcd_clsh_set_buck_mode() is defined in the wcd-clsh-v2.c file, but not called elsewhere, so remove this unused function. sound/soc/codecs/wcd-clsh-v2.c:133:20: warning: unused function 'wcd_clsh_enable_status'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3348 Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- sound/soc/codecs/wcd-clsh-v2.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sound/soc/codecs/wcd-clsh-v2.c b/sound/soc/codecs/wcd-clsh-v2.c index 4c7ebc7fb400..a75db27e5205 100644 --- a/sound/soc/codecs/wcd-clsh-v2.c +++ b/sound/soc/codecs/wcd-clsh-v2.c @@ -130,12 +130,6 @@ static inline void wcd_enable_clsh_block(struct wcd_clsh_ctrl *ctrl, ctrl->clsh_users = 0; } -static inline bool wcd_clsh_enable_status(struct snd_soc_component *comp) -{ - return snd_soc_component_read(comp, WCD9XXX_A_CDC_CLSH_CRC) & - WCD9XXX_A_CDC_CLSH_CRC_CLK_EN_MASK; -} - static inline void wcd_clsh_set_buck_mode(struct snd_soc_component *comp, int mode) { -- 2.20.1.7.g153144c

2 1

[PATCH] ASoC: rockchip: pdm: Add missing clk_disable_unprepare() in rockchip_pdm_runtime_resume()
by Wang Jingjin 07 Dec '22

07 Dec '22

The clk_disable_unprepare() should be called in the error handling of rockchip_pdm_runtime_resume(). Fixes: fc05a5b22253 ("ASoC: rockchip: add support for pdm controller") Signed-off-by: Wang Jingjin <wangjingjin1(a)huawei.com> --- sound/soc/rockchip/rockchip_pdm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c index a7549f827235..5b1e47bdc376 100644 --- a/sound/soc/rockchip/rockchip_pdm.c +++ b/sound/soc/rockchip/rockchip_pdm.c @@ -431,6 +431,7 @@ static int rockchip_pdm_runtime_resume(struct device *dev) ret = clk_prepare_enable(pdm->hclk); if (ret) { + clk_disable_unprepare(pdm->clk); dev_err(pdm->dev, "hclock enable failed %d\n", ret); return ret; } -- 2.25.1

2 1