- Alsa-devel - mailman.alsa-project.org

[PATCH AUTOSEL 6.1 07/85] ASoC: Intel: avs: Add quirk for KBL-R RVP platform
by Sasha Levin 18 Dec '22

18 Dec '22

From: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> [ Upstream commit 9d0737fa0e7530313634c0ecd75f09a95ba8d44a ] KBL-R RVPs contain built-in rt298 codec which requires different PLL clock and .dai_fmt configuration than seen on other boards. Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Link: https://lore.kernel.org/r/20221010121955.718168-5-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/avs/boards/rt298.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/avs/boards/rt298.c b/sound/soc/intel/avs/boards/rt298.c index b28d36872dcb..58c9d9edecf0 100644 --- a/sound/soc/intel/avs/boards/rt298.c +++ b/sound/soc/intel/avs/boards/rt298.c @@ -6,6 +6,7 @@ // Amadeusz Slawinski <amadeuszx.slawinski(a)linux.intel.com> // +#include <linux/dmi.h> #include <linux/module.h> #include <sound/jack.h> #include <sound/pcm.h> @@ -14,6 +15,16 @@ #include <sound/soc-acpi.h> #include "../../../codecs/rt298.h" +static const struct dmi_system_id kblr_dmi_table[] = { + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_BOARD_NAME, "Kabylake R DDR4 RVP"), + }, + }, + {} +}; + static const struct snd_kcontrol_new card_controls[] = { SOC_DAPM_PIN_SWITCH("Headphone Jack"), SOC_DAPM_PIN_SWITCH("Mic Jack"), @@ -96,9 +107,15 @@ avs_rt298_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_param { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0); + unsigned int clk_freq; int ret; - ret = snd_soc_dai_set_sysclk(codec_dai, RT298_SCLK_S_PLL, 19200000, SND_SOC_CLOCK_IN); + if (dmi_first_match(kblr_dmi_table)) + clk_freq = 24000000; + else + clk_freq = 19200000; + + ret = snd_soc_dai_set_sysclk(codec_dai, RT298_SCLK_S_PLL, clk_freq, SND_SOC_CLOCK_IN); if (ret < 0) dev_err(rtd->dev, "Set codec sysclk failed: %d\n", ret); @@ -139,7 +156,10 @@ static int avs_create_dai_link(struct device *dev, const char *platform_name, in dl->platforms = platform; dl->num_platforms = 1; dl->id = 0; - dl->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; + if (dmi_first_match(kblr_dmi_table)) + dl->dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; + else + dl->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS; dl->init = avs_rt298_codec_init; dl->be_hw_params_fixup = avs_rt298_be_fixup; dl->ops = &avs_rt298_ops; -- 2.35.1

1 0

[PATCH AUTOSEL 6.1 06/85] ASoC: codecs: rt298: Add quirk for KBL-R RVP platform
by Sasha Levin 18 Dec '22

18 Dec '22

From: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> [ Upstream commit 953dbd1cef18ce9ac0d69c1bd735b929fe52a17e ] KBL-R RVP platforms also use combojack, so we need to enable that configuration for them. Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Link: https://lore.kernel.org/r/20221010121955.718168-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/rt298.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c index a2ce52dafea8..cea26f3a02b6 100644 --- a/sound/soc/codecs/rt298.c +++ b/sound/soc/codecs/rt298.c @@ -1166,6 +1166,13 @@ static const struct dmi_system_id force_combo_jack_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Geminilake") } }, + { + .ident = "Intel Kabylake R RVP", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_MATCH(DMI_PRODUCT_NAME, "Kabylake Client platform") + } + }, { } }; -- 2.35.1

1 0

No front panel profile on Xonar D1
by GitHub issues - opened 18 Dec '22

18 Dec '22

alsa-project/alsa-ucm-conf issue #252 was opened from realnc: There is no way to switch to front panel headphone output through pipewire. I have to open a terminal, run `alsamixer` and unmute the "Front Panel" element every time I want to switch to/from front panel input and output: ![image](https://user-images.githubusercontent.com/1665903/208296363-67272f79-b3b9-4783-9f75-8527f0db8457.png) I've been told by a pipewire dev that alsa-ucm-conf must provide a profile, otherwise it can't work. My sound card is an Asus Xonar D1. `alsa-info.sh`: http://alsa-project.org/db/?f=beaa1236f0889f1f0ad8474c4c1825fb9488af1f Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/252 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Dell XPS 9320: Mic-Mute LED not working
by GitHub issues - edited 18 Dec '22

18 Dec '22

alsa-project/alsa-ucm-conf issue #251 was edited from heftig: The mic-mute LED on my XPS 9320 does not work. Reading `/sys/class/sound/ctl-led/mic/card0/list` outputs `52 18`. Control 18 is the expected `rt714 FU02 Capture Switch` set in `ucm2/codecs/rt715-sdca/init.conf`. Control 52 is: ``` numid=52,iface=MIXER,name='PGA5.0 5 Master Capture Switch' ; type=BOOLEAN,access=rw------,values=2 : values=on,on ``` In this state, the LED does turn on when both switches are off, but muting via PipeWire only toggles control 18. Detaching the LED from `52` (so that only `18` remains) makes it work properly. I've tried finding out how 52 gets attached, but couldn't find anything. Is this done in-kernel? Linux 6.1 ALSA 1.2.8 Arch Linux Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/251 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Dell XPS 9320: Mic-Mute LED not working
by GitHub issues - opened 18 Dec '22

18 Dec '22

alsa-project/alsa-ucm-conf issue #251 was opened from heftig: The mic-mute LED on my XPS 9320 does not work. Reading `/sys/class/sound/ctl-led/mic/card0/list` outputs `52 18`. Control `18` is the expected `rt714 FU02 Capture Switch` set in `ucm2/codecs/rt715-sdca/init.conf`. Control `52` is: ``` numid=52,iface=MIXER,name='PGA5.0 5 Master Capture Switch' ; type=BOOLEAN,access=rw------,values=2 : values=on,on ``` In this state, the LED does turn on when both switches are off, but muting via PipeWire only toggles control 18. Detaching the LED from `52` (so that only `18` remains) makes it work properly. I've tried finding out how `52` gets attached, but couldn't find anything. Is this done in-kernel? Linux 6.1 ALSA 1.2.8 Arch Linux Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/251 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

RE: [PATCH] ASoC: amd: yc: Add Razer Blade 14 2022 into DMI table
by Limonciello, Mario 16 Dec '22

16 Dec '22

[Public] > -----Original Message----- > From: Wim Van Boven <wimvanboven(a)gmail.com> > Sent: Friday, December 16, 2022 02:18 > Cc: wimvanboven(a)gmail.com; Liam Girdwood <lgirdwood(a)gmail.com>; > Mark Brown <broonie(a)kernel.org>; Jaroslav Kysela <perex(a)perex.cz>; > Takashi Iwai <tiwai(a)suse.com>; Limonciello, Mario > <Mario.Limonciello(a)amd.com>; Saba Kareem, Syed > <Syed.SabaKareem(a)amd.com>; Leohearts <leohearts(a)leohearts.com>; > Brent Mendelsohn <mendiebm(a)gmail.com>; Xiaoyan Li > <lxy.lixiaoyan(a)gmail.com>; linkt <xazrael(a)hotmail.com>; alsa-devel@alsa- > project.org; linux-kernel(a)vger.kernel.org > Subject: [PATCH] ASoC: amd: yc: Add Razer Blade 14 2022 into DMI table > > Razer Blade 14 (2022) - RZ09-0427 needs the quirk to enable the built in > microphone > > Signed-off-by: Wim Van Boven <wimvanboven(a)gmail.com> Thanks! Link: https://bugzilla.kernel.org/show_bug.cgi?id=216801 Reviewed-by: Mario Limonciello <mario.limonciello(a)amd.com> > --- > sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x- > mach.c > index 1f0b5527c594..469c5e79e0ea 100644 > --- a/sound/soc/amd/yc/acp6x-mach.c > +++ b/sound/soc/amd/yc/acp6x-mach.c > @@ -220,6 +220,13 @@ static const struct dmi_system_id > yc_acp_quirk_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book > Pro 14 2022"), > } > }, > + { > + .driver_data = &acp6x_card, > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Razer"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Blade 14 > (2022) - RZ09-0427"), > + } > + }, > {} > }; > > -- > 2.38.1

1 0

aplay,axfer: Replace off64_t with off_t
by GitHub pull_request - opened 15 Dec '22

15 Dec '22

alsa-project/alsa-utils pull request #183 was opened from kraj: Also replace lseek64 with lseek. _FILE_OFFSET_BITS=64 is passed to needed platforms since configure uses AC_SYS_LARGEFILE macro. Therefore off_t is already 64-bit and lseek is same as lseek64. Additionally this fixes buils with latest musl where these lfs64 functions are moved out from _GNU_SOURCE and under _LARGEFILE64_SOURCE macro alone. This makes the builds fail on 32-bit platforms even though default off_t on musl is 64-bit always. Signed-off-by: Khem Raj <raj.khem(a)gmail.com> Request URL : https://github.com/alsa-project/alsa-utils/pull/183 Patch URL : https://github.com/alsa-project/alsa-utils/pull/183.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH] ASoC: lochnagar: Fix unused lochnagar_of_match warning
by Krzysztof Kozlowski 15 Dec '22

15 Dec '22

lochnagar_of_match is used unconditionally, so COMPILE_TEST builds without OF warn: sound/soc/codecs/lochnagar-sc.c:247:34: error: ‘lochnagar_of_match’ defined but not used [-Werror=unused-const-variable=] Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- sound/soc/codecs/lochnagar-sc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/lochnagar-sc.c b/sound/soc/codecs/lochnagar-sc.c index 13fbd8830b09..5e0bd0d24ed3 100644 --- a/sound/soc/codecs/lochnagar-sc.c +++ b/sound/soc/codecs/lochnagar-sc.c @@ -253,7 +253,7 @@ MODULE_DEVICE_TABLE(of, lochnagar_of_match); static struct platform_driver lochnagar_sc_codec_driver = { .driver = { .name = "lochnagar-soundcard", - .of_match_table = of_match_ptr(lochnagar_of_match), + .of_match_table = lochnagar_of_match, }, .probe = lochnagar_sc_probe, -- 2.34.1

2 1

[PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access
by Rouven Czerwinski 15 Dec '22

15 Dec '22

From: Marco Felsch <m.felsch(a)pengutronix.de> According the reference manuals [1], [2] updating register 0x14/1c should only be done after #shdn bit is set to 0. [1] https://datasheets.maximintegrated.com/en/ds/MAX98089.pdf [2] https://datasheets.maximintegrated.com/en/ds/MAX98088.pdf Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> --- sound/soc/codecs/max98088.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c index 405ec16be2b6..7f108e147355 100644 --- a/sound/soc/codecs/max98088.c +++ b/sound/soc/codecs/max98088.c @@ -977,6 +977,8 @@ static int max98088_dai1_hw_params(struct snd_pcm_substream *substream, rate = params_rate(params); + snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); + switch (params_width(params)) { case 16: snd_soc_component_update_bits(component, M98088_REG_14_DAI1_FORMAT, @@ -990,8 +992,6 @@ static int max98088_dai1_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); - if (rate_value(rate, &regval)) return -EINVAL; @@ -1047,6 +1047,8 @@ static int max98088_dai2_hw_params(struct snd_pcm_substream *substream, rate = params_rate(params); + snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); + switch (params_width(params)) { case 16: snd_soc_component_update_bits(component, M98088_REG_1C_DAI2_FORMAT, @@ -1060,8 +1062,6 @@ static int max98088_dai2_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - snd_soc_component_update_bits(component, M98088_REG_51_PWR_SYS, M98088_SHDNRUN, 0); - if (rate_value(rate, &regval)) return -EINVAL; -- 2.38.1

3 5

Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
by Mark Brown 14 Dec '22

14 Dec '22

On Wed, 14 Dec 2022 07:08:30 -0500, Moises Cardona wrote: > The bytcr_rt5640.c file already supports the HP Stream 7. > > The HP Stream 8 is almost identical in terms of the hardware > with the exception of it having stereo speakers, a SIM > card slot and the obvious size difference. > > Signed-off-by Moises Cardona <moisesmcardona(a)gmail.com> > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] Add HP Stream 8 to bytcr_rt5640.c commit: ff5870a76c2abda389650d3711cdddc031d12665 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark

1 0