- Alsa-devel - mailman.alsa-project.org

[PATCH v7 0/6] ASoC: fsl: add memory to memory function for ASRC
by Shengjiu Wang 13 Dec '24

13 Dec '24

This function is base on the accelerator implementation for compress API: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") Audio signal processing also has the requirement for memory to memory similar as Video. This asrc memory to memory (memory ->asrc->memory) case is a non real time use case. User fills the input buffer to the asrc module, after conversion, then asrc sends back the output buffer to user. So it is not a traditional ALSA playback and capture case. Because we had implemented the "memory -> asrc ->i2s device-> codec" use case in ALSA. Now the "memory->asrc->memory" needs to reuse the code in asrc driver, so the patch 1 and patch 2 is for refining the code to make it can be shared by the "memory->asrc->memory" driver. Other change is to add memory to memory support for two kinds of i.MX ASRC modules. changes in v7: - add 'select SND_COMPRESS_OFFLOAD' for fixing compile issue with imx_v6_v7_defconfig changes in v6: - rebase to latest tree, change to use 'MODULE_IMPORT_NS("DMA_BUF")' - Add Acked-by: Vinod Koul for patch 1/6 changes in v5: - Drop Jaroslav Kysela's patch as it has been merged. - Add Jaroslav Kysela's Acked-by tag, received in v3. changes in v4: - remove the RFC tag, no comments receive in v3 - Add Jaroslav Kysela's patch in this patch set. because it may be better for reviewing in a full patch set. - Fix the list_for_each_entry_reverse to list_for_each_entry_safe_reverse - Fix some coding style issues in Jaroslav Kysela's patch changes in v3: - use Jaroslav's suggestion for header file compress_params.h (PATCH 01) - remove the ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE definition - remove ASRC_RATIO_MOD in this version because it uses .set_metadata() Will wait Jaroslav's update or other better method in the future. - Address some comments from Pierre. changes in v2: - Remove the changes in compress API - drop the SNDRV_COMPRESS_SRC_RATIO_MOD - drop the SND_AUDIOCODEC_SRC and struct snd_dec_src - define private metadata key value ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE/ASRC_RATIO_MOD Shengjiu Wang (6): ALSA: compress: Add output rate and output format support ASoC: fsl_asrc: define functions for memory to memory usage ASoC: fsl_easrc: define functions for memory to memory usage ASoC: fsl_asrc_m2m: Add memory to memory function ASoC: fsl_asrc: register m2m platform device ASoC: fsl_easrc: register m2m platform device include/uapi/sound/compress_params.h | 23 +- sound/soc/fsl/Kconfig | 2 + sound/soc/fsl/Makefile | 2 +- sound/soc/fsl/fsl_asrc.c | 179 ++++++- sound/soc/fsl/fsl_asrc.h | 2 + sound/soc/fsl/fsl_asrc_common.h | 70 +++ sound/soc/fsl/fsl_asrc_m2m.c | 727 +++++++++++++++++++++++++++ sound/soc/fsl/fsl_easrc.c | 261 +++++++++- sound/soc/fsl/fsl_easrc.h | 4 + 9 files changed, 1261 insertions(+), 9 deletions(-) create mode 100644 sound/soc/fsl/fsl_asrc_m2m.c -- 2.34.1

3 9

[PATCH v6 0/6] ASoC: fsl: add memory to memory function for ASRC
by Shengjiu Wang 13 Dec '24

13 Dec '24

This function is base on the accelerator implementation for compress API: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") Audio signal processing also has the requirement for memory to memory similar as Video. This asrc memory to memory (memory ->asrc->memory) case is a non real time use case. User fills the input buffer to the asrc module, after conversion, then asrc sends back the output buffer to user. So it is not a traditional ALSA playback and capture case. Because we had implemented the "memory -> asrc ->i2s device-> codec" use case in ALSA. Now the "memory->asrc->memory" needs to reuse the code in asrc driver, so the patch 1 and patch 2 is for refining the code to make it can be shared by the "memory->asrc->memory" driver. Other change is to add memory to memory support for two kinds of i.MX ASRC modules. changes in v6: - rebase to latest tree, change to use 'MODULE_IMPORT_NS("DMA_BUF")' - Add Acked-by: Vinod Koul for patch 1/6 changes in v5: - Drop Jaroslav Kysela's patch as it has been merged. - Add Jaroslav Kysela's Acked-by tag, received in v3. changes in v4: - remove the RFC tag, no comments receive in v3 - Add Jaroslav Kysela's patch in this patch set. because it may be better for reviewing in a full patch set. - Fix the list_for_each_entry_reverse to list_for_each_entry_safe_reverse - Fix some coding style issues in Jaroslav Kysela's patch changes in v3: - use Jaroslav's suggestion for header file compress_params.h (PATCH 01) - remove the ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE definition - remove ASRC_RATIO_MOD in this version because it uses .set_metadata() Will wait Jaroslav's update or other better method in the future. - Address some comments from Pierre. changes in v2: - Remove the changes in compress API - drop the SNDRV_COMPRESS_SRC_RATIO_MOD - drop the SND_AUDIOCODEC_SRC and struct snd_dec_src - define private metadata key value ASRC_OUTPUT_FORMAT/ASRC_OUTPUT_RATE/ASRC_RATIO_MOD Shengjiu Wang (6): ALSA: compress: Add output rate and output format support ASoC: fsl_asrc: define functions for memory to memory usage ASoC: fsl_easrc: define functions for memory to memory usage ASoC: fsl_asrc_m2m: Add memory to memory function ASoC: fsl_asrc: register m2m platform device ASoC: fsl_easrc: register m2m platform device include/uapi/sound/compress_params.h | 23 +- sound/soc/fsl/Kconfig | 1 + sound/soc/fsl/Makefile | 2 +- sound/soc/fsl/fsl_asrc.c | 179 ++++++- sound/soc/fsl/fsl_asrc.h | 2 + sound/soc/fsl/fsl_asrc_common.h | 70 +++ sound/soc/fsl/fsl_asrc_m2m.c | 727 +++++++++++++++++++++++++++ sound/soc/fsl/fsl_easrc.c | 261 +++++++++- sound/soc/fsl/fsl_easrc.h | 4 + 9 files changed, 1260 insertions(+), 9 deletions(-) create mode 100644 sound/soc/fsl/fsl_asrc_m2m.c -- 2.34.1

2 7

Re: [syzbot] [tipc?] kernel BUG in __pskb_pull_tail
by syzbot 13 Dec '24

13 Dec '24

syzbot has bisected this issue to: commit de4f5fed3f231a8ff4790bf52975f847b95b85ea Author: Jens Axboe <axboe(a)kernel.dk> Date: Wed Mar 29 14:52:15 2023 +0000 iov_iter: add iter_iovec() helper bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17424730580000 start commit: 96b6fcc0ee41 Merge branch 'net-dsa-cleanup-eee-part-1' git tree: net-next final oops: https://syzkaller.appspot.com/x/report.txt?x=14c24730580000 console output: https://syzkaller.appspot.com/x/log.txt?x=10c24730580000 kernel config: https://syzkaller.appspot.com/x/.config?x=1362a5aee630ff34 dashboard link: https://syzkaller.appspot.com/bug?extid=4f66250f6663c0c1d67e syz repro: https://syzkaller.appspot.com/x/repro.syz?x=166944f8580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1287ecdf980000 Reported-by: syzbot+4f66250f6663c0c1d67e(a)syzkaller.appspotmail.com Fixes: de4f5fed3f23 ("iov_iter: add iter_iovec() helper") For information about bisection process see: https://goo.gl/tpsmEJ#bisection

2 1

[GIT PULL] ASoC fixes for v6.12-rc2
by Mark Brown 12 Dec '24

12 Dec '24

The following changes since commit fac04efc5c793dccbd07e2d59af9f90b7fc0dca4: Linux 6.13-rc2 (2024-12-08 14:03:39 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.12-rc2 for you to fetch changes up to 255cc582e6e16191a20d54bcdbca6c91d3e90c5e: ASoC: Intel: sof_sdw: Add space for a terminator into DAIs array (2024-12-12 11:08:49 +0000) ---------------------------------------------------------------- ASoC: Fixes for v6.13 A small pile of driver specific fixes, all quite small and not particularly major. ---------------------------------------------------------------- Charles Keepax (1): ASoC: Intel: sof_sdw: Add space for a terminator into DAIs array Shenghao Ding (1): ASoC: tas2781: Fix calibration issue in stress test Shengjiu Wang (2): ASoC: fsl_xcvr: change IFACE_PCM to IFACE_MIXER ASoC: fsl_spdif: change IFACE_PCM to IFACE_MIXER Stephen Gordon (1): ASoC: audio-graph-card: Call of_node_put() on correct node Venkata Prasad Potturu (1): ASoC: amd: yc: Fix the wrong return value sound/soc/amd/yc/acp6x-mach.c | 13 +++++++++---- sound/soc/codecs/tas2781-i2c.c | 2 +- sound/soc/fsl/fsl_spdif.c | 2 +- sound/soc/fsl/fsl_xcvr.c | 2 +- sound/soc/generic/audio-graph-card2.c | 2 +- sound/soc/intel/boards/sof_sdw.c | 8 ++++++-- 6 files changed, 19 insertions(+), 10 deletions(-)

2 1

Re: [PATCH v6 4/6] ASoC: fsl_asrc_m2m: Add memory to memory function
by Shengjiu Wang 12 Dec '24

12 Dec '24

On Wed, Dec 11, 2024 at 11:28 PM Mark Brown <broonie(a)kernel.org> wrote: > > On Wed, Dec 11, 2024 at 11:08:47AM +0800, Shengjiu Wang wrote: > > Implement the ASRC memory to memory function using > > the compress framework, user can use this function with > > compress ioctl interface. > > > > This feature can be shared by ASRC and EASRC drivers > > This breaks an imx_v6_v7_defconfig build: > > arm-linux-gnueabihf-ld: sound/soc/fsl/fsl_asrc_m2m.o: in function `fsl_asrc_m2m_ > init': > fsl_asrc_m2m.c:(.text+0x7ac): undefined reference to `snd_compress_new' > > Looks like we're missing some select statements. Thanks for noticing this issue. Sorry about that, I will fix it. Best regards Shengjiu Wang

1 0

git clone failure
by GitHub issues - opened 12 Dec '24

12 Dec '24

alsa-project/tinycompress issue #27 was opened from antonio-fr: Working on embedded project, there's a recipe for a system that uses tinycompress, and points to the alsa-project git server. Unfortunately, tinycompress can't be downloaded, leading the building system unable to make the system image. ``` $ git clone git://git.alsa-project.org/tinycompress.git Cloning into 'tinycompress'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` It worked yesterday, And I can see the project [there in the web interface](https://git.alsa-project.org/?p=tinycompress.git;a=tree). But right now, no luck. Issue URL : https://github.com/alsa-project/tinycompress/issues/27 Repository URL: https://github.com/alsa-project/tinycompress

1 0

Re: [PATCH v2 30/37] ALSA: seq: Automatic conversion of UMP events
by Mike Lothian 11 Dec '24

11 Dec '24

Hi I'm not sure when this first appeared but I see the following when compiling/linking with Clang 19.1.5 vmlinux.o: warning: objtool: cc_ev_to_ump_midi2+0x5a5: return with modified stack frame This is the only commit I can see that has cc_ev_to_ump_midi2 in it Cheers Mike

2 1

[PATCH v1] ASoC: tas2781: Fix calibration issue in stress test
by Shenghao Ding 11 Dec '24

11 Dec '24

One specific test condition: the default registers of p[j].reg ~ p[j+3].reg are 0, TASDEVICE_REG(0x00, 0x14, 0x38)(PLT_FLAG_REG), TASDEVICE_REG(0x00, 0x14, 0x40)(SINEGAIN_REG), and TASDEVICE_REG(0x00, 0x14, 0x44)(SINEGAIN2_REG). After first calibration, they are freshed to TASDEVICE_REG(0x00, 0x1a, 0x20), TASDEVICE_REG(0x00, 0x16, 0x58)(PLT_FLAG_REG), TASDEVICE_REG(0x00, 0x14, 0x44)(SINEGAIN_REG), and TASDEVICE_REG(0x00, 0x16, 0x64)(SINEGAIN2_REG) via "Calibration Start" kcontrol. In second calibration, the p[j].reg ~ p[j+3].reg have already become tas2781_cali_start_reg. However, p[j+2].reg, TASDEVICE_REG(0x00, 0x14, 0x44)(SINEGAIN_REG), will be freshed to TASDEVICE_REG(0x00, 0x16, 0x64), which is the third register in the input params of the kcontrol. This is why only first calibration can work, the second-time, third-time or more-time calibration always failed without reboot. Of course, if no p[j].reg is in the list of tas2781_cali_start_reg, this stress test can work well. Fixes: 49e2e353fb0d ("ASoC: tas2781: Add Calibration Kcontrols for Chromebook") Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- sound/soc/codecs/tas2781-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index be2ca5eb6c93..fb8cd2284fe8 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -370,7 +370,7 @@ static void sngl_calib_start(struct tasdevice_priv *tas_priv, int i, tasdevice_dev_read(tas_priv, i, p[j].reg, (int *)&p[j].val[0]); } else { - switch (p[j].reg) { + switch (tas2781_cali_start_reg[j].reg) { case 0: { if (!reg[0]) continue; -- 2.34.1

1 0

rt722: add headset mic led control
by GitHub pull_request - edited 11 Dec '24

11 Dec '24

alsa-project/alsa-ucm-conf pull request #487 was edited from shumingfan: rt722: add headset mic led control Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/487 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/487.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v4 00/24] Add audio support for the Renesas RZ/G3S SoC
by Claudiu 10 Dec '24

10 Dec '24

From: Claudiu Beznea <claudiu.beznea.uj(a)bp.renesas.com> Hi, Series enables the audio support for the Renesas RZ/G3S SoC along with runtime PM and suspend to RAM. Patches: - 01-03/24 - update versaclock3 clock generator driver to support the 5L35023 hardware variant; versaclock3 provides clocks for the audio devices (SSIF, DA7212 codec) - 04-19/24 - add SSIF support for the RZ/G3S SoC; fixes and cleanups were also included - 20-24/24 - add device tree support Merge strategy, if any: - clock patches (01-03/24) can go the clock tree - audio patches (04-19/24) can go through the audio tree - device tree patches (20-24/24) can go through the Renesas tree Thank you, Claudiu Beznea Changes in v4: - added patch 18/24 "ASoC: dt-bindings: renesas,rz-ssi: Remove DMA description" - collected tags - addressed review comments - dropped already integrated patches - the changelog for each patch is detailed within the individual patches Changes in v3: - use renesas instead of sh in audio patches title - use proper fixes tag for patch "ASoC: renesas: rz-ssi: Terminate all the DMA transactions" - collected tags Changes in v2: - fixed typos pointed out in the review process - dropped da7213 patches already applied - dropped patch "ASoC: sh: rz-ssi: Use a proper bitmask for clear bits" as requested in the review process Claudiu Beznea (24): clk: versaclock3: Prepare for the addition of 5L35023 device dt-bindings: clock: versaclock3: Document 5L35023 Versa3 clock generator clk: versaclock3: Add support for the 5L35023 variant ASoC: renesas: rz-ssi: Terminate all the DMA transactions ASoC: renesas: rz-ssi: Use only the proper amount of dividers ASoC: renesas: rz-ssi: Fix typo on SSI_RATES macro comment ASoC: renesas: rz-ssi: Remove pdev member of struct rz_ssi_priv ASoC: renesas: rz-ssi: Remove the rz_ssi_get_dai() function ASoC: renesas: rz-ssi: Remove the first argument of rz_ssi_stream_is_play() ASoC: renesas: rz-ssi: Use readl_poll_timeout_atomic() ASoC: renesas: rz-ssi: Use temporary variable for struct device ASoC: renesas: rz-ssi: Use goto label names that specify their actions ASoC: renesas: rz-ssi: Rely on the ASoC subsystem to runtime resume/suspend the SSI ASoC: renesas: rz-ssi: Enable runtime PM autosuspend support ASoC: renesas: rz-ssi: Add runtime PM support ASoC: renesas: rz-ssi: Issue software reset in hw_params API ASoC: renesas: rz-ssi: Add suspend to RAM support ASoC: dt-bindings: renesas,rz-ssi: Remove DMA description ASoC: dt-bindings: renesas,rz-ssi: Document the Renesas RZ/G3S SoC arm64: dts: renesas: r9a08g045: Add SSI nodes arm64: dts: renesas: rzg3s-smarc-som: Add versa3 clock generator node arm64: dts: renesas: Add da7212 audio codec node arm64: dts: renesas: rzg3s-smarc: Enable SSI3 arm64: dts: renesas: rzg3s-smarc: Add sound card .../bindings/clock/renesas,5p35023.yaml | 1 + .../bindings/sound/renesas,rz-ssi.yaml | 19 +- arch/arm64/boot/dts/renesas/r9a08g045.dtsi | 94 ++++++++ .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 47 +++- arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 63 +++++ drivers/clk/clk-versaclock3.c | 67 ++++-- sound/soc/renesas/rz-ssi.c | 226 +++++++++++------- 7 files changed, 388 insertions(+), 129 deletions(-) -- 2.39.2

2 27