July 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH 00/10] Introduce STM32 Firewall framework
by Gatien Chevallier 25 Jul '23

25 Jul '23

Introduce STM32 Firewall framework for STM32MP1x and STM32MP2x platforms. STM32MP1x(ETZPC) and STM32MP2x(RIFSC) Firewall controllers register to the framework to offer firewall services such as access granting. This series of patches is a new approach on the previous STM32 system bus, history is available here: https://lore.kernel.org/lkml/20230127164040.1047583/ The need for such framework arises from the fact that there are now multiple hardware firewalls implemented across multiple products. Drivers are shared between different products, using the same code. When it comes to firewalls, the purpose mostly stays the same: Protect hardware resources. But the implementation differs, and there are multiple types of firewalls: peripheral, memory, ... Some hardware firewall controllers such as the RIFSC implemented on STM32MP2x platforms may require to take ownership of a resource before being able to use it, hence the requirement for firewall services to take/release the ownership of such resources. On the other hand, hardware firewall configurations are becoming more and more complex. These mecanisms prevent platform crashes or other firewall-related incoveniences by denying access to some resources. The stm32 firewall framework offers an API that is defined in firewall controllers drivers to best fit the specificity of each firewall. For every peripherals protected by either the ETZPC or the RIFSC, the firewall framework checks the firewall controlelr registers to see if the peripheral's access is granted to the Linux kernel. If not, the peripheral is configured as secure, the node is marked populated, so that the driver is not probed for that device. The firewall framework relies on the feature-domain-controller device tree bindings: https://lore.kernel.org/lkml/0c0a82bb-18ae-d057-562b. It is used by peripherals to reference a domain controller, in this case a firewall feature domain. The bus uses the ID referenced by the feature-domains property to know where to look in the firewall to get the security configuration for the peripheral. This allows a device tree description rather than a hardcoded peripheral table in the bus driver. The STM32 ETZPC device is responsible for filtering accesses based on security level, or co-processor isolation for any resource connected to it. The RIFSC is responsible for filtering accesses based on Compartment ID / security level / privilege level for any resource connected to it. STM32MP13/15/25 SoC device tree files are updated in this series to implement this mecanism. Oleksii Moisieiev (1): dt-bindings: Document common device controller bindings Gatien Chevallier (9): dt-bindings: bus: add device tree bindings for RIFSC dt-bindings: bus: add device tree bindings for ETZPC dt-bindings: treewide: add feature-domains description in binding files firewall: introduce stm32_firewall framework bus: rifsc: introduce RIFSC firewall controller driver arm64: dts: st: add RIFSC as a domain controller for STM32MP25x boards bus: etzpc: introduce ETZPC firewall controller driver ARM: dts: stm32: add ETZPC as a system bus for STM32MP15x boards ARM: dts: stm32: add ETZPC as a system bus for STM32MP13x boards .../bindings/bus/st,stm32-etzpc.yaml | 90 + .../bindings/bus/st,stm32-rifsc.yaml | 101 + .../bindings/crypto/st,stm32-hash.yaml | 4 + .../devicetree/bindings/dma/st,stm32-dma.yaml | 4 + .../bindings/dma/st,stm32-dmamux.yaml | 4 + .../feature-domain-controller.yaml | 84 + .../devicetree/bindings/i2c/st,stm32-i2c.yaml | 4 + .../bindings/iio/adc/st,stm32-adc.yaml | 4 + .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 4 + .../bindings/iio/dac/st,stm32-dac.yaml | 4 + .../bindings/media/cec/st,stm32-cec.yaml | 4 + .../bindings/media/st,stm32-dcmi.yaml | 4 + .../memory-controllers/st,stm32-fmc2-ebi.yaml | 4 + .../bindings/mfd/st,stm32-lptimer.yaml | 4 + .../bindings/mfd/st,stm32-timers.yaml | 5 + .../devicetree/bindings/mmc/arm,pl18x.yaml | 4 + .../devicetree/bindings/net/stm32-dwmac.yaml | 4 + .../bindings/phy/phy-stm32-usbphyc.yaml | 4 + .../bindings/regulator/st,stm32-vrefbuf.yaml | 4 + .../devicetree/bindings/rng/st,stm32-rng.yaml | 4 + .../bindings/serial/st,stm32-uart.yaml | 4 + .../bindings/sound/st,stm32-i2s.yaml | 4 + .../bindings/sound/st,stm32-sai.yaml | 4 + .../bindings/sound/st,stm32-spdifrx.yaml | 4 + .../bindings/spi/st,stm32-qspi.yaml | 4 + .../devicetree/bindings/spi/st,stm32-spi.yaml | 4 + .../devicetree/bindings/usb/dwc2.yaml | 4 + MAINTAINERS | 7 + arch/arm/boot/dts/st/stm32mp131.dtsi | 1027 +++--- arch/arm/boot/dts/st/stm32mp133.dtsi | 51 +- arch/arm/boot/dts/st/stm32mp13xc.dtsi | 19 +- arch/arm/boot/dts/st/stm32mp13xf.dtsi | 19 +- arch/arm/boot/dts/st/stm32mp151.dtsi | 2757 +++++++++-------- arch/arm/boot/dts/st/stm32mp153.dtsi | 52 +- arch/arm/boot/dts/st/stm32mp15xc.dtsi | 19 +- arch/arm64/Kconfig.platforms | 1 + arch/arm64/boot/dts/st/stm32mp251.dtsi | 5 +- drivers/bus/Kconfig | 10 + drivers/bus/Makefile | 1 + drivers/bus/stm32_etzpc.c | 137 + drivers/bus/stm32_firewall.c | 252 ++ drivers/bus/stm32_firewall.h | 83 + drivers/bus/stm32_rifsc.c | 248 ++ include/linux/bus/stm32_firewall_device.h | 134 + 44 files changed, 3276 insertions(+), 1918 deletions(-) create mode 100644 Documentation/devicetree/bindings/bus/st,stm32-etzpc.yaml create mode 100644 Documentation/devicetree/bindings/bus/st,stm32-rifsc.yaml create mode 100644 Documentation/devicetree/bindings/feature-controllers/feature-domain-controller.yaml create mode 100644 drivers/bus/stm32_etzpc.c create mode 100644 drivers/bus/stm32_firewall.c create mode 100644 drivers/bus/stm32_firewall.h create mode 100644 drivers/bus/stm32_rifsc.c create mode 100644 include/linux/bus/stm32_firewall_device.h -- 2.25.1

6 42

[GIT PULL] ASoC updates for v6.6-early
by Mark Brown 25 Jul '23

25 Jul '23

The following changes since commit 6eaae198076080886b9e7d57f4ae06fa782f90ef: Linux 6.5-rc3 (2023-07-23 15:24:10 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-v6.6-early for you to fetch changes up to 85d12eda2382cd5b93eed720b5a08f39d42cfef4: ALSA: hda: Adding support for CS35L56 on HDA (2023-07-24 18:42:26 +0100) ---------------------------------------------------------------- ASoC: Updates for v6.6 Here's an initial batch of updates for ASoC for this release cycle. We've got a bunch of new drivers in here, a bit of core work from Morimoto-san and quite a lot of janitorial work. There's several updates that pull in changes from other subsystems in order to build on them: - An adaptor to allow use of IIO DACs and ADCs in ASoC which pulls in some IIO changes. - Create a library function for intlog10() and use it in the NAU8825 driver. - Include the ASoC tests, including the topology tests, in the default KUnit full test coverage. This also involves enabling UML builds of ALSA since that's the default KUnit test environment which pulls in the addition of some stubs to the driver. - More factoring out from Morimoto-san. - Convert a lot of drivers to use the more modern maple tree register cache. - Support for AMD machines with MAX98388 and NAU8821, Cirrus Logic CS35L36, Intel AVS machines with ES8336 and RT5663 and NXP i.MX93. ---------------------------------------------------------------- Amadeusz Sławiński (2): ASoC: Intel: avs: Add rt5663 machine board ASoC: Intel: avs: Load rt5663 board on KBL-based platforms Andreas Kemnade (1): ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Andy Shevchenko (8): ASoC: rt5677: Refactor GPIO support code ASoC: rt5677: Use agnostic irq_domain_create_linear() ASoC: rt5677: Use device_get_match_data() ASoC: rt5677: Sort headers alphabetically lib/math: Move dvb_math.c into lib/math/int_log.c lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX identifier ASoC: nau8825: Replace copied'n'pasted intlog10() Arnd Bergmann (1): ASoC: amd: acp: fix SND_SOC_AMD_ACP_PCI depdenencies Bjorn Andersson (1): ASoC: codecs: lpass: Log clk_get() failures Brent Lu (1): ASoC: Intel: sof_rt5682: add jsl_rt5650 board config Cezary Rojewski (6): ASoC: codecs: es8316: Add support for 24 MHz MCLK ASoC: codecs: es8316: Add support for S24_3LE format ASoC: Intel: avs: Add es8336 machine board ASoC: Intel: avs: Load es8336 board on KBL-based platforms ASoC: Intel: avs: rt5682: Add missing components ASoC: Intel: avs: rt5682: Tidy up hw_params() Chancel Liu (3): ASoC: imx-pcm-rpmsg: Set PCM hardware parameters separately ASoC: dt-bindings: fsl_rpmsg: Add compatible string for i.MX93 ASoC: fsl_rpmsg: Add support for i.MX93 platform Cristian Ciocaltea (3): ASoC: amd: vangogh: Make use of DRV_NAME ASoC: amd: vangogh: Use dmi_first_match() for DMI quirk handling ASoC: amd: vangogh: Add support for NAU8821/MAX98388 variant Dan Carpenter (1): ASoC: amd: acp: delete unnecessary NULL check Francesco Dolcini (3): ASoC: dt-bindings: nau8822: Add #sound-dai-cells ASoC: dt-bindings: nau8822: Add MCLK clock ASoC: dt-bindings: wm8904: Convert to dtschema Frank Li (1): ASoC: codec: wm8960: add additional probe check for codec identification Herve Codina (13): ASoC: dt-bindings: Add audio-iio-aux ASoC: dt-bindings: simple-card: Add additional-devs subnode iio: inkern: Check error explicitly in iio_channel_read_max() iio: consumer.h: Fix raw values documentation notes iio: inkern: Remove the 'unused' variable usage in iio_channel_read_max() iio: inkern: Fix headers inclusion order minmax: Introduce {min,max}_array() iio: inkern: Use max_array() to get the maximum value from an array iio: inkern: Replace a FIXME comment by a TODO one iio: inkern: Add a helper to query an available minimum raw value ASoC: soc-dapm.h: Convert macros to return a compound literal ASoC: codecs: Add support for the generic IIO auxiliary devices ASoC: simple-card: Handle additional devices Jack Yu (1): ASoC: rt722-sdca: Remove redundant sdca mask Konrad Dybcio (1): ASoC: Convert pm8916-wcd-analog-codec to YAML Kuninori Morimoto (10): ASoC: soc-core.c: initialize dlc on snd_soc_get_dai_id() ASoC: soc-core.c: cleanup soc_dai_link_sanity_check() ASoC: soc-core: protect dlc->of_node under mutex ASoC: soc-dai.c: add DAI get/match functions ASoC: soc-core.c: enable multi Component ASoC: soc-core.c: add snd_soc_get_dai_via_args() ASoC: soc-core.c: add snd_soc_dlc_use_cpu_as_platform() ASoC: soc-core.c: add snd_soc_copy_dai_args() ASoC: simple-card-utils.c: enable multi Component support ASoC: simple-card.c: enable multi Component support Mark Brown (88): Merge existing fixes from asoc/for-6.5 into new branch Add support for IIO devices in ASoC ASoC: remove copy of intlog10() ASoC: Intel: avs: New boards and fixes to existing AMD Vangogh support for NAU8821/MAX98388 ASoC: mt8188: add memory-region support Add acpi mahine id's for vangogh platform and Refactor acp legacy driver and add ASoC: rt5677: Refactor GPIO and use ASoC: Another set of platform remove conversions ASoC: ad1836: Update to use maple tree register cache ASoC: ad1980: Update to use maple tree register cache ASoC: adau1372: Update to use maple tree register cache ASoC: adau1373: Update to use maple tree register cache ASoC: adau1701: Update to use maple tree register cache ASoC: adau1761: Update to use maple tree register cache ASoC: adau1781: Update to use maple tree register cache ASoC: adau1977: Update to use maple tree register cache ASoC: adau7118: Update to use maple tree register cache ASoC: adav80x: Update to use maple tree register cache ASoC: ad: Update Analog Devices drivers to maple tree ASoC: wcd9335: Update to use maple tree register cache ASoC: wcd938x: Update to use maple tree register cache ASoC: wsa881x: Update to use maple tree register cache ASoC: wsa883x: Update to use maple tree register cache ASoC: qcom: Use the maple tree register cache Add support for rpmsg sound card on i.MX93 platform Add Probe functionality support for amd platforms. ASoC: cs35l36: Update to use maple tree register cache ASoC: cs35l41: Update to use maple tree register cache ASoC: cs35l45: Update to use maple tree register cache ASoC: cs35l56: Update to use maple tree register cache ASoC: cs42l51: Update to use maple tree register cache ASoC: cs4265: Update to use maple tree register cache ASoC: cs4270: Update to use maple tree register cache ASoC: cs42l52: Update to use maple tree register cache ASoC: cs42l56: Update to use maple tree register cache ASoC: cs42xx8: Update to use maple tree register cache ASoC: cs4349: Update to use maple tree register cache ASoC: wm2200: Update to use maple tree register cache ASoC: wm5100: Update to use maple tree register cache ASoC: wm9081: Update to use maple tree register cache ASoC: wm9090: Update to use maple tree register cache ASoC: wm8510: Update to use maple tree register cache ASoC: wm8523: Update to use maple tree register cache ASoC: wm8580: Update to use maple tree register cache ASoC: wm8711: Update to use maple tree register cache ASoC: wm8728: Update to use maple tree register cache ASoC: wm8731: Update to use maple tree register cache ASoC: wm8737: Update to use maple tree register cache ASoC: wm8741: Update to use maple tree register cache ASoC: wm8750: Update to use maple tree register cache ASoC: wm8753: Update to use maple tree register cache ASoC: wm8770: Update to use maple tree register cache ASoC: wm8776: Update to use maple tree register cache ASoC: wm8804: Update to use maple tree register cache ASoC: wm8900: Update to use maple tree register cache ASoC: wm8903: Update to use maple tree register cache ASoC: wm8904: Update to use maple tree register cache ASoC: wm8960: Update to use maple tree register cache ASoC: wm8961: Update to use maple tree register cache ASoC: wm8962: Update to use maple tree register cache ASoC: wm8991: Update to use maple tree register cache ASoC: wm8993: Update to use maple tree register cache ASoC: wm8995: Update to use maple tree register cache ASoC: wm8996: Update to use maple tree register cache ASoC: wm8940: Update to use maple tree register cache ASoC: wm8955: Update to use maple tree register cache ASoC: wm8971: Update to use maple tree register cache ASoC: wm8978: Update to use maple tree register cache ASoC: wm8983: Update to use maple tree register cache ASoC: wm8985: Update to use maple tree register cache ASoC: wm8988: Update to use maple tree register cache ASoC: wm9705: Update to use maple tree register cache ASoC: wm9712: Update to use maple tree register cache ASoC: wm9713: Update to use maple tree register cache driver core: Provide stubs for !IOMEM builds platform: Provide stubs for !HAS_IOMEM builds ALSA: Enable build with UML kunit: Enable ASoC in all_tests.config ASoC: topology: Add explicit build option ASoC: add multi Component support ASoC: cirrus: Use the maple tree register cache ASoC: Improve coverage in default KUnit runs ASoC: dt-bindings: nau8822: minor updates ASoC: codecs: msm8916-wcd-analog: Cleanup DT bindings ASoC: Merge up fixes from mainline ALSA: hda: Adding support for CS35L56 on HDA Mastan Katragadda (1): ASoC: SOF: amd: refactor PSP smn_read Matus Gajdos (1): ASoC: fsl_spdif: Add support for 22.05 kHz sample rate Maxim Kochetkov (1): ASoC: dwc: Add TDM mode support Min-Hua Chen (1): ASoC: q6dsp: q6apm: make g_apm static Randy Dunlap (1): ASoC: stac9766: fix build errors with REGMAP_AC97 Richard Fitzgerald (5): ASoC: cs35l56: Patch soft registers to defaults ASoC: cs35l56: Move runtime suspend/resume to shared library ASoC: cs35l56: Move cs_dsp init into shared library ASoC: cs35l56: Move part of cs35l56_init() to shared library ALSA: hda: Fix missing header dependencies Rob Herring (1): ASoC: dt-bindings: audio-graph-card2: Drop incomplete example Seven Lee (1): ASoC: dt-bindings: nau8821: Convert to dtschema Shengjiu Wang (1): ASoC: wm8960: Add DAC filter characteristics selection Shuming Fan (2): ASoC: rt5645: implement set_jack callback ASoC: rt5645: add the system level suspend-resume callback Simon Trimmer (7): ASoC: cs35l56: Move shared data into a common data structure ASoC: cs35l56: Make cs35l56_system_reset() code more generic ASoC: cs35l56: Convert utility functions to use common data structure ASoC: cs35l56: Move utility functions to shared file ASoC: cs35l56: Make common function for control port wait ASoC: cs35l56: Make a common function to shutdown the DSP ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier Stephan Gerhold (5): ASoC: dt-bindings: pm8916-analog-codec: Fix misleading example ASoC: dt-bindings: pm8916-analog-codec: Drop pointless reg-names ASoC: dt-bindings: pm8916-analog-codec: Drop invalid mclk ASoC: codecs: msm8916-wcd-analog: Drop invalid mclk ASoC: codecs: msm8916-wcd-analog: Properly handle probe errors Syed Saba Kareem (10): ASoC: amd: acp: refactor the acp init and de-init sequence ASoC: amd: acp: add acp i2s master clock generation for rembrandt platform ASoC: amd: acp: remove the redundant acp enable/disable interrupts functions ASoC: amd: acp: store platform device reference created in pci probe call ASoC: amd: acp: add pm ops support for acp pci driver ASoC: amd: acp: store xfer_resolution of the stream ASoC: amd: acp: export config_acp_dma() and config_pte_for_stream() symbols ASoC: amd: acp: store the pdm stream channel mask ASoC: amd: acp: move pdm macros to common header file ASoC: amd: acp: add pm ops support for rembrandt platform Trevor Wu (3): ASoC: mediatek: mt8188: add memory-region support ASoC: dt-bindings: mediatek,mt8188-afe: add memory-region ASoC: mediatek: mt8188: DPCM used FE and BE merged parameters Uwe Kleine-König (2): ASoC: amd: ps-sdw-dma: Convert to platform remove callback returning void ASoC: starfive: jh7110_tdm: Convert to platform remove callback returning void V sujith kumar Reddy (3): ASoC: SOF: amd: Add Probe functionality support for amd platforms. ASoC: SOF: Add acp-probe id to sof probe client driver for registration. ASoC: SOF: amd: Add Probe register offset for renoir and rembrandt platform. Venkata Prasad Potturu (4): ASoC: amd: acp: Add machine driver support for nau8821 codec ASoC: amd: acp: Add machine driver support for max98388 codec ASoC: amd: Add acpi machine id's for vangogh platform ASoC: amd: Add new dmi entries to config entry Yang Li (2): ASoC: tas2781: No need to set device_driver owner ASoC: amd: acp: clean up some inconsistent indentings Yangtao Li (5): ASoC: bcm: bcm63xx-i2s-whistler: Convert to devm_platform_ioremap_resource() ASoC: ti: Convert to devm_platform_ioremap_resource_byname() ASoC: mediatek: mt8186: Convert to devm_platform_ioremap_resource() ASoC: pxa: Use devm_platform_get_and_ioremap_resource() ASoC: tegra: tegra20_ac97: Use devm_platform_get_and_ioremap_resource() Zhu Ning (1): ASoC: codecs: ES8326: Add es8326_mute function Documentation/core-api/kernel-api.rst | 7 +- .../devicetree/bindings/sound/audio-iio-aux.yaml | 64 ++ .../devicetree/bindings/sound/fsl,rpmsg.yaml | 1 + .../bindings/sound/mediatek,mt8188-afe.yaml | 7 + .../devicetree/bindings/sound/nau8821.txt | 55 -- .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 125 +++ .../devicetree/bindings/sound/nuvoton,nau8822.yaml | 12 + .../bindings/sound/qcom,msm8916-wcd-analog.txt | 101 --- .../sound/qcom,pm8916-wcd-analog-codec.yaml | 153 ++++ .../devicetree/bindings/sound/simple-card.yaml | 53 ++ .../devicetree/bindings/sound/wlf,wm8904.yaml | 74 ++ Documentation/devicetree/bindings/sound/wm8904.txt | 33 - Documentation/driver-api/media/dtv-common.rst | 9 - drivers/iio/inkern.c | 86 +- drivers/media/dvb-core/Makefile | 2 +- drivers/media/dvb-frontends/af9013_priv.h | 2 +- drivers/media/dvb-frontends/af9033_priv.h | 2 +- drivers/media/dvb-frontends/cxd2820r_priv.h | 2 +- drivers/media/dvb-frontends/cxd2841er.c | 2 +- .../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c | 2 +- .../cxd2880/cxd2880_tnrdmd_dvbt_mon.c | 2 +- drivers/media/dvb-frontends/cxd2880/cxd2880_top.c | 2 +- drivers/media/dvb-frontends/dib7000p.c | 2 +- drivers/media/dvb-frontends/dib8000.c | 2 +- drivers/media/dvb-frontends/dib9000.c | 2 +- drivers/media/dvb-frontends/drxk_hard.c | 2 +- drivers/media/dvb-frontends/lgdt3305.c | 2 +- drivers/media/dvb-frontends/lgdt3306a.c | 2 +- drivers/media/dvb-frontends/lgdt330x.c | 2 +- drivers/media/dvb-frontends/m88ds3103_priv.h | 2 +- drivers/media/dvb-frontends/mn88443x.c | 2 +- drivers/media/dvb-frontends/mn88472_priv.h | 2 +- drivers/media/dvb-frontends/mn88473_priv.h | 2 +- drivers/media/dvb-frontends/or51132.c | 2 +- drivers/media/dvb-frontends/or51211.c | 2 +- drivers/media/dvb-frontends/rtl2830_priv.h | 2 +- drivers/media/dvb-frontends/rtl2832_priv.h | 2 +- drivers/media/dvb-frontends/si2165.c | 2 +- drivers/media/dvb-frontends/stv0367.c | 2 +- drivers/media/dvb-frontends/tc90522.c | 2 +- drivers/media/dvb-frontends/tda10048.c | 2 +- include/linux/device.h | 26 + include/linux/iio/consumer.h | 37 +- include/{media/dvb_math.h => linux/int_log.h} | 18 +- include/linux/minmax.h | 64 ++ include/linux/platform_device.h | 28 + include/sound/cs35l56.h | 29 +- include/sound/simple_card_utils.h | 5 +- include/sound/soc-dai.h | 3 + include/sound/soc-dapm.h | 138 ++- include/sound/soc.h | 6 + lib/math/Makefile | 2 +- .../dvb-core/dvb_math.c => lib/math/int_log.c | 26 +- sound/Kconfig | 4 - sound/pci/hda/Kconfig | 31 + sound/pci/hda/Makefile | 6 + sound/pci/hda/cs35l56_hda.c | 995 +++++++++++++++++++++ sound/pci/hda/cs35l56_hda.h | 48 + sound/pci/hda/cs35l56_hda_i2c.c | 69 ++ sound/pci/hda/cs35l56_hda_spi.c | 68 ++ sound/pci/hda/hda_auto_parser.h | 2 + sound/pci/hda/hda_generic.h | 3 + sound/soc/Kconfig | 11 + sound/soc/amd/Kconfig | 5 +- sound/soc/amd/acp-config.c | 33 + sound/soc/amd/acp/Kconfig | 8 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/acp-i2s.c | 2 + sound/soc/amd/acp/acp-legacy-common.c | 347 +++++++ sound/soc/amd/acp/acp-mach-common.c | 267 ++++++ sound/soc/amd/acp/acp-mach.h | 2 + sound/soc/amd/acp/acp-pci.c | 57 +- sound/soc/amd/acp/acp-pdm.c | 13 +- sound/soc/amd/acp/acp-platform.c | 6 +- sound/soc/amd/acp/acp-rembrandt.c | 184 ++-- sound/soc/amd/acp/acp-renoir.c | 115 +-- sound/soc/amd/acp/acp-sof-mach.c | 16 + sound/soc/amd/acp/amd.h | 51 ++ sound/soc/amd/mach-config.h | 1 + sound/soc/amd/ps/ps-sdw-dma.c | 5 +- sound/soc/amd/vangogh/acp5x-mach.c | 149 ++- sound/soc/bcm/bcm63xx-i2s-whistler.c | 16 +- sound/soc/codecs/Kconfig | 13 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ad1836.c | 2 +- sound/soc/codecs/ad1980.c | 2 +- sound/soc/codecs/adau1372.c | 2 +- sound/soc/codecs/adau1373.c | 2 +- sound/soc/codecs/adau1701.c | 2 +- sound/soc/codecs/adau1761.c | 2 +- sound/soc/codecs/adau1781.c | 2 +- sound/soc/codecs/adau1977.c | 2 +- sound/soc/codecs/adau7118-i2c.c | 2 +- sound/soc/codecs/adav80x.c | 2 +- sound/soc/codecs/audio-iio-aux.c | 344 +++++++ sound/soc/codecs/cs35l36.c | 2 +- sound/soc/codecs/cs35l41-lib.c | 4 +- sound/soc/codecs/cs35l45-tables.c | 4 +- sound/soc/codecs/cs35l56-i2c.c | 14 +- sound/soc/codecs/cs35l56-sdw.c | 72 +- sound/soc/codecs/cs35l56-shared.c | 482 +++++++++- sound/soc/codecs/cs35l56-spi.c | 10 +- sound/soc/codecs/cs35l56.c | 651 +++----------- sound/soc/codecs/cs35l56.h | 15 +- sound/soc/codecs/cs4265.c | 2 +- sound/soc/codecs/cs4270.c | 2 +- sound/soc/codecs/cs42l51.c | 2 +- sound/soc/codecs/cs42l52.c | 2 +- sound/soc/codecs/cs42l56.c | 2 +- sound/soc/codecs/cs42xx8.c | 2 +- sound/soc/codecs/cs4349.c | 2 +- sound/soc/codecs/es8316.c | 5 +- sound/soc/codecs/es8326.c | 75 +- sound/soc/codecs/es8326.h | 9 +- sound/soc/codecs/lpass-rx-macro.c | 10 +- sound/soc/codecs/lpass-tx-macro.c | 10 +- sound/soc/codecs/lpass-va-macro.c | 6 +- sound/soc/codecs/lpass-wsa-macro.c | 10 +- sound/soc/codecs/msm8916-wcd-analog.c | 56 +- sound/soc/codecs/nau8825.c | 93 +- sound/soc/codecs/rt5645.c | 50 ++ sound/soc/codecs/rt5677.c | 117 +-- sound/soc/codecs/rt5677.h | 92 +- sound/soc/codecs/rt722-sdca-sdw.c | 2 +- sound/soc/codecs/rt722-sdca.c | 3 +- sound/soc/codecs/tas2781-i2c.c | 1 - sound/soc/codecs/wcd9335.c | 2 +- sound/soc/codecs/wcd938x-sdw.c | 2 +- sound/soc/codecs/wm2200.c | 2 +- sound/soc/codecs/wm5100.c | 2 +- sound/soc/codecs/wm8510.c | 2 +- sound/soc/codecs/wm8523.c | 2 +- sound/soc/codecs/wm8580.c | 2 +- sound/soc/codecs/wm8711.c | 2 +- sound/soc/codecs/wm8728.c | 2 +- sound/soc/codecs/wm8731.c | 2 +- sound/soc/codecs/wm8737.c | 2 +- sound/soc/codecs/wm8741.c | 2 +- sound/soc/codecs/wm8750.c | 2 +- sound/soc/codecs/wm8753.c | 2 +- sound/soc/codecs/wm8770.c | 2 +- sound/soc/codecs/wm8776.c | 2 +- sound/soc/codecs/wm8804.c | 2 +- sound/soc/codecs/wm8900.c | 2 +- sound/soc/codecs/wm8903.c | 2 +- sound/soc/codecs/wm8904.c | 2 +- sound/soc/codecs/wm8940.c | 2 +- sound/soc/codecs/wm8955.c | 2 +- sound/soc/codecs/wm8960.c | 12 +- sound/soc/codecs/wm8961.c | 2 +- sound/soc/codecs/wm8962.c | 2 +- sound/soc/codecs/wm8971.c | 2 +- sound/soc/codecs/wm8978.c | 2 +- sound/soc/codecs/wm8983.c | 2 +- sound/soc/codecs/wm8985.c | 2 +- sound/soc/codecs/wm8988.c | 2 +- sound/soc/codecs/wm8991.c | 2 +- sound/soc/codecs/wm8993.c | 2 +- sound/soc/codecs/wm8995.c | 2 +- sound/soc/codecs/wm8996.c | 2 +- sound/soc/codecs/wm9081.c | 2 +- sound/soc/codecs/wm9090.c | 2 +- sound/soc/codecs/wm9705.c | 2 +- sound/soc/codecs/wm9712.c | 2 +- sound/soc/codecs/wm9713.c | 2 +- sound/soc/codecs/wsa881x.c | 2 +- sound/soc/codecs/wsa883x.c | 2 +- sound/soc/dwc/dwc-i2s.c | 65 +- sound/soc/dwc/dwc-pcm.c | 8 +- sound/soc/dwc/local.h | 24 + sound/soc/fsl/fsl_rpmsg.c | 8 + sound/soc/fsl/fsl_spdif.c | 8 +- sound/soc/fsl/fsl_spdif.h | 6 +- sound/soc/fsl/imx-pcm-rpmsg.c | 12 +- sound/soc/generic/audio-graph-card.c | 2 +- sound/soc/generic/audio-graph-card2.c | 2 +- sound/soc/generic/simple-card-utils.c | 23 +- sound/soc/generic/simple-card.c | 66 +- sound/soc/intel/avs/board_selection.c | 16 + sound/soc/intel/avs/boards/Kconfig | 20 + sound/soc/intel/avs/boards/Makefile | 4 + sound/soc/intel/avs/boards/es8336.c | 315 +++++++ sound/soc/intel/avs/boards/rt5663.c | 254 ++++++ sound/soc/intel/avs/boards/rt5682.c | 67 +- sound/soc/intel/boards/Kconfig | 5 +- sound/soc/intel/boards/sof_rt5682.c | 80 +- sound/soc/intel/common/soc-acpi-intel-jsl-match.c | 12 + sound/soc/mediatek/mt8186/mt8186-afe-pcm.c | 4 +- sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 8 +- sound/soc/mediatek/mt8188/mt8188-mt6359.c | 15 + sound/soc/pxa/pxa2xx-i2s.c | 13 +- sound/soc/qcom/qdsp6/q6apm.c | 2 +- sound/soc/soc-core.c | 273 ++++-- sound/soc/sof/amd/Kconfig | 8 + sound/soc/sof/amd/Makefile | 1 + sound/soc/sof/amd/acp-common.c | 4 + sound/soc/sof/amd/acp-ipc.c | 26 + sound/soc/sof/amd/acp-probes.c | 147 +++ sound/soc/sof/amd/acp.c | 34 +- sound/soc/sof/amd/acp.h | 13 +- sound/soc/sof/amd/pci-rmb.c | 2 + sound/soc/sof/amd/pci-rn.c | 2 + sound/soc/sof/sof-client-probes.c | 1 + sound/soc/starfive/jh7110_tdm.c | 5 +- sound/soc/tegra/tegra20_ac97.c | 3 +- sound/soc/ti/omap-dmic.c | 4 +- sound/soc/ti/omap-mcbsp.c | 4 +- sound/soc/ti/omap-mcpdm.c | 3 +- tools/testing/kunit/configs/all_tests.config | 5 + 209 files changed, 5743 insertions(+), 1841 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/audio-iio-aux.yaml delete mode 100644 Documentation/devicetree/bindings/sound/nau8821.txt create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml delete mode 100644 Documentation/devicetree/bindings/sound/qcom,msm8916-wcd-analog.txt create mode 100644 Documentation/devicetree/bindings/sound/qcom,pm8916-wcd-analog-codec.yaml create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt rename include/{media/dvb_math.h => linux/int_log.h} (63%) rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%) create mode 100644 sound/pci/hda/cs35l56_hda.c create mode 100644 sound/pci/hda/cs35l56_hda.h create mode 100644 sound/pci/hda/cs35l56_hda_i2c.c create mode 100644 sound/pci/hda/cs35l56_hda_spi.c create mode 100644 sound/soc/amd/acp/acp-legacy-common.c create mode 100644 sound/soc/codecs/audio-iio-aux.c create mode 100644 sound/soc/intel/avs/boards/es8336.c create mode 100644 sound/soc/intel/avs/boards/rt5663.c create mode 100644 sound/soc/sof/amd/acp-probes.c

2 1

[PATCH] ALSA: hda/relatek: Enable Mute LED on HP 250 G8
by Luka Guzenko 25 Jul '23

25 Jul '23

This HP Notebook used ALC236 codec with COEF 0x07 idx 1 controlling the mute LED. Enable already existing quirk for this device. Signed-off-by: Luka Guzenko <l.guzenko(a)web.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 52ea7d757d6a..9a65dfb00cb2 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9541,6 +9541,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8811, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), SND_PCI_QUIRK(0x103c, 0x8812, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1), + SND_PCI_QUIRK(0x103c, 0x881d, "HP 250 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x884b, "HP EliteBook 840 Aero G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), -- 2.41.0

2 1

[PATCH] ASoC: SOF: ipc4-topology: fix application of sizeof to pointer
by sunran001＠208suo.com 25 Jul '23

25 Jul '23

The coccinelle check report: ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of sizeof to pointer Signed-off-by: Ran Sun <sunran001(a)208suo.com> --- sound/soc/sof/ipc4-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index a4e1a70b607d..2dbe87dbd239 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -218,7 +218,7 @@ static int sof_ipc4_get_audio_fmt(struct snd_soc_component *scomp, ret = sof_update_ipc_object(scomp, available_fmt, SOF_AUDIO_FMT_NUM_TOKENS, swidget->tuples, - swidget->num_tuples, sizeof(available_fmt), 1); + swidget->num_tuples, sizeof(*available_fmt), 1); if (ret) { dev_err(scomp->dev, "Failed to parse audio format token count\n"); return ret;

4 3

[PATCH v5 00/11] ALSA: hda: Adding support for CS35L56 on HDA systems
by Richard Fitzgerald 25 Jul '23

25 Jul '23

This set of patches adds support for using the CS35L56 boosted smart amplifier on HDA systems. In these systems the CS35L56 audio is routed through a HDA-to-I2S bridge codec. This doesn't include the changes to the Realtek driver to actually hook up the CS35L56 driver, because we don't yet have the QUIRK IDs to associate it with. But we want to publish the driver now so that it is available for bringing up hardware with the CS35L56. The first 9 patches are moving code out of the ASoC driver and into the shared library so that it can be shared with the HDA driver. Patch #10 fixes missing #includes in the HDA headers so that the CS35L56 driver doesn't have to #include headers that it doesn't use. CHANGES SINCE V5 The series has been rebased onto commit df4167d658d4 ("ASoC: cs35l56: Patch soft registers to defaults"), which removes cs35l56_reread_firmware_registers() and adds cs35l56_set_patch(). Changes are trivial so I have carried forward Mark's and Takashi's acks. Patch 01: - Also changes cs35l56_set_patch() argument to new struct cs35l56_base. Patch 11: - Remove call to cs35l56_reread_firmware_registers() - Add call to cs35l56_set_patch() in cs35l56_hda_common_probe() - Do not add mute_hook to struct hda_component. This was for use with CS8409 as an HDA bridge, but production systems will use Realtek, which has its own mute control. - Use strscpy() instead of strcpy() in cs35l56_hda_mixer_info() - Fix missing word in Kconfig option title Richard Fitzgerald (4): ASoC: cs35l56: Move runtime suspend/resume to shared library ASoC: cs35l56: Move cs_dsp init into shared library ASoC: cs35l56: Move part of cs35l56_init() to shared library ALSA: hda: Fix missing header dependencies Simon Trimmer (7): ASoC: cs35l56: Move shared data into a common data structure ASoC: cs35l56: Make cs35l56_system_reset() code more generic ASoC: cs35l56: Convert utility functions to use common data structure ASoC: cs35l56: Move utility functions to shared file ASoC: cs35l56: Make common function for control port wait ASoC: cs35l56: Make a common function to shutdown the DSP ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier include/sound/cs35l56.h | 29 +- sound/pci/hda/Kconfig | 31 + sound/pci/hda/Makefile | 6 + sound/pci/hda/cs35l56_hda.c | 995 ++++++++++++++++++++++++++++++ sound/pci/hda/cs35l56_hda.h | 48 ++ sound/pci/hda/cs35l56_hda_i2c.c | 69 +++ sound/pci/hda/cs35l56_hda_spi.c | 68 ++ sound/pci/hda/hda_auto_parser.h | 2 + sound/pci/hda/hda_generic.h | 3 + sound/soc/codecs/cs35l56-i2c.c | 14 +- sound/soc/codecs/cs35l56-sdw.c | 72 +-- sound/soc/codecs/cs35l56-shared.c | 458 +++++++++++++- sound/soc/codecs/cs35l56-spi.c | 10 +- sound/soc/codecs/cs35l56.c | 648 ++++--------------- sound/soc/codecs/cs35l56.h | 15 +- 15 files changed, 1877 insertions(+), 591 deletions(-) create mode 100644 sound/pci/hda/cs35l56_hda.c create mode 100644 sound/pci/hda/cs35l56_hda.h create mode 100644 sound/pci/hda/cs35l56_hda_i2c.c create mode 100644 sound/pci/hda/cs35l56_hda_spi.c -- 2.30.2

3 17

[PATCH] ALSA: usb-audio: Add quirk for Microsoft Modern Wireless Headset
by Takashi Iwai 25 Jul '23

25 Jul '23

Microsoft Modern Wireless Headset (appearing on the host as "Microsoft USB Link") has a playback and a capture mixer volume/switch, but they are fairly broken. The descriptor reports wrong dB ranges for playback, and the capture volume/switch don't influence on the actual recording at all. Moreover, there seem instabilities in the connection, and at best, we should disable the runtime PM. So this ended up with a quirk entry for: - Correct the playback dB range; I picked up some reasonable values but it's a guess work - Disable the capture mixer; it's completely useless and confuses PA/PW - Suppress get-sample-rate, apply the delay for message handling, and suppress the auto-suspend The behavior of the wheel control on the headset is somehow flaky, too, but it's an issue of HID. Link: https://bugzilla.suse.com/show_bug.cgi?id=1207129 Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/mixer_maps.c | 14 ++++++++++++++ sound/usb/quirks.c | 3 +++ 2 files changed, 17 insertions(+) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index f4bd1e8ae4b6..23260aa1919d 100644 --- a/sound/usb/mixer_maps.c +++ b/sound/usb/mixer_maps.c @@ -374,6 +374,15 @@ static const struct usbmix_name_map corsair_virtuoso_map[] = { { 0 } }; +/* Microsoft USB Link headset */ +/* a guess work: raw playback volume values are from 2 to 129 */ +static const struct usbmix_dB_map ms_usb_link_dB = { -3225, 0, true }; +static const struct usbmix_name_map ms_usb_link_map[] = { + { 9, NULL, .dB = &ms_usb_link_dB }, + { 10, NULL }, /* Headset Capture volume; seems non-working, disabled */ + { 0 } /* terminator */ +}; + /* ASUS ROG Zenith II with Realtek ALC1220-VB */ static const struct usbmix_name_map asus_zenith_ii_map[] = { { 19, NULL, 12 }, /* FU, Input Gain Pad - broken response, disabled */ @@ -668,6 +677,11 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { .id = USB_ID(0x1395, 0x0025), .map = sennheiser_pc8_map, }, + { + /* Microsoft USB Link headset */ + .id = USB_ID(0x045e, 0x083c), + .map = ms_usb_link_map, + }, { 0 } /* terminator */ }; diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 30bcb80b1cb8..f9e200309b9e 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -2013,6 +2013,9 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_IGNORE_CTL_ERROR), DEVICE_FLG(0x041e, 0x4080, /* Creative Live Cam VF0610 */ QUIRK_FLAG_GET_SAMPLE_RATE), + DEVICE_FLG(0x045e, 0x083c, /* MS USB Link headset */ + QUIRK_FLAG_GET_SAMPLE_RATE | QUIRK_FLAG_CTL_MSG_DELAY | + QUIRK_FLAG_DISABLE_AUTOSUSPEND), DEVICE_FLG(0x046d, 0x084c, /* Logitech ConferenceCam Connect */ QUIRK_FLAG_GET_SAMPLE_RATE | QUIRK_FLAG_CTL_MSG_DELAY_1M), DEVICE_FLG(0x046d, 0x0991, /* Logitech QuickCam Pro */ -- 2.35.3

1 0

alsa-utils-1.2.4's aplay play 11.025k wav file by digital Mi Headphone (S24_3LE) with abnormal electrical noise sound
by GitHub issues - opened 25 Jul '23

25 Jul '23

alsa-project/alsa-lib issue #338 was opened from raintiliang: Hi, we use aplay play 11.025k wav file by digital Mi Headphone (S24_3LE) with abnormal electrical noise sound, But aplay 8K, 16K, 32K,48K wav as normal except 11.025k, 22.05k, 44.1k. May i have any idea ? Issue URL : https://github.com/alsa-project/alsa-lib/issues/338 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v1 0/5] Add PWM-DAC audio support for StarFive JH7110 RISC-V SoC
by Hal Feng 25 Jul '23

25 Jul '23

This patchset adds PWM-DAC audio support for the StarFive JH7110 SoC. The PWM-DAC module does not require a hardware codec, so add a dummy codec driver for it. The fourth patch depends on the patch [1]. The fifth patch depends on the patchset [2], patch [3]. [1] https://lore.kernel.org/all/20230526145402.450-3-walker.chen@starfivetech.c… [2] https://lore.kernel.org/all/20230518101234.143748-1-xingyu.wu@starfivetech.… [3] https://lore.kernel.org/all/20230322094820.24738-5-walker.chen@starfivetech… Hal Feng (5): ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter ASoC: codecs: Add StarFive JH7110 dummy PWM-DAC transmitter driver ASoC: dt-bindings: Add StarFive JH7110 PWM-DAC controller ASoC: starfive: Add JH7110 PWM-DAC driver riscv: dts: starfive: Add JH7110 PWM-DAC support .../sound/starfive,jh7110-pwmdac-dit.yaml | 38 + .../sound/starfive,jh7110-pwmdac.yaml | 76 ++ MAINTAINERS | 8 + .../jh7110-starfive-visionfive-2.dtsi | 50 ++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 13 + sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/jh7110_pwmdac_transmitter.c | 74 ++ sound/soc/starfive/Kconfig | 9 + sound/soc/starfive/Makefile | 1 + sound/soc/starfive/jh7110_pwmdac.c | 787 ++++++++++++++++++ 11 files changed, 1062 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac-dit.yaml create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml create mode 100644 sound/soc/codecs/jh7110_pwmdac_transmitter.c create mode 100644 sound/soc/starfive/jh7110_pwmdac.c base-commit: 45a3e24f65e90a047bef86f927ebdc4c710edaa1 prerequisite-patch-id: 8c735dffc6d5388a35a76b16e914a2f9722ad979 prerequisite-patch-id: ffa1f5831e75722c9f41603f009f762c9fd525e2 prerequisite-patch-id: 36e69700dfc0375b950b0e23086ed3b722cb84a4 prerequisite-patch-id: 0b49b996d7a404ea548e1734c12933ec749e92b9 prerequisite-patch-id: 81f7c65712c4901a7a178ddcd98ffc55f3b473ff prerequisite-patch-id: f342fbf594014b072378528bea94c01fb2186e1a prerequisite-patch-id: 39e1be2a3d1593577ab997f55f59367cba665aa7 prerequisite-patch-id: 0159f09bb0a1ff711a00ae17ef5b12662c9c7d3d prerequisite-patch-id: 2ddada18ab6ea5cd1da14212aaf59632f5203d40 prerequisite-patch-id: d5abfba63fc07ff97b5023911513c260bb7a53e1 prerequisite-patch-id: b37ac15032973e1fcd918f157c82a0606775c9e9 prerequisite-patch-id: 6abf359fa445f4104432ddee27044dfbfb128417 prerequisite-patch-id: 2f7aca99e714a4c590a91baa015080ac0902814d prerequisite-patch-id: 32cabbc4e7a97ec14d5c28a477fa483784f86709 prerequisite-patch-id: d449b1957dd77c2537c38585daa75974c94c529a -- 2.38.1

3 20

[PATCH] ASoC: wm8904: Fill the cache for WM8904_ADC_TEST_0 register
by Mark Brown 24 Jul '23

24 Jul '23

The WM8904_ADC_TEST_0 register is modified as part of updating the OSR controls but does not have a cache default, leading to errors when we try to modify these controls in cache only mode with no prior read: wm8904 3-001a: ASoC: error at snd_soc_component_update_bits on wm8904.3-001a for register: [0x000000c6] -16 Add a read of the register to probe() to fill the cache and avoid both the error messages and the misconfiguration of the chip which will result. Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/wm8904.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index 068e610b1b4c..f2baee7c332e 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -2308,6 +2308,9 @@ static int wm8904_i2c_probe(struct i2c_client *i2c) regmap_update_bits(wm8904->regmap, WM8904_BIAS_CONTROL_0, WM8904_POBCTRL, 0); + /* Fill the cache for the ADC test register */ + regmap_read(wm8904->regmap, WM8904_ADC_TEST_0, &val); + /* Can leave the device powered off until we need it */ regcache_cache_only(wm8904->regmap, true); regulator_bulk_disable(ARRAY_SIZE(wm8904->supplies), wm8904->supplies); --- base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c change-id: 20230722-asoc-fix-wm8904-adc-test-read-5a0051264a0b Best regards, -- Mark Brown <broonie(a)kernel.org>

2 2

[PATCH 0/2] ASoC: da7219: Patches related to a spurious AAD IRQ issue
by Dmytro Maluka 24 Jul '23

24 Jul '23

This series includes 2 patches related to (but not fixing) the following I2C failure which occurs sometimes during system suspend or resume and indicates a problem with a spurious DA7219 interrupt: [ 355.876211] i2c_designware i2c_designware.3: Transfer while suspended [ 355.876245] WARNING: CPU: 2 PID: 3576 at drivers/i2c/busses/i2c-designware-master.c:570 i2c_dw_xfer+0x411/0x440 ... [ 355.876462] Call Trace: [ 355.876468] <TASK> [ 355.876475] ? update_load_avg+0x1b3/0x615 [ 355.876484] __i2c_transfer+0x101/0x1d8 [ 355.876494] i2c_transfer+0x74/0x10d [ 355.876504] regmap_i2c_read+0x6a/0x9c [ 355.876513] _regmap_raw_read+0x179/0x223 [ 355.876521] regmap_raw_read+0x1e1/0x28e [ 355.876527] regmap_bulk_read+0x17d/0x1ba [ 355.876532] ? __wake_up+0xed/0x1bb [ 355.876542] da7219_aad_irq_thread+0x54/0x2c9 [snd_soc_da7219 5fb8ebb2179cf2fea29af090f3145d68ed8e2184] [ 355.876556] irq_thread+0x13c/0x231 [ 355.876563] ? irq_forced_thread_fn+0x5f/0x5f [ 355.876570] ? irq_thread_fn+0x4d/0x4d [ 355.876576] kthread+0x13a/0x152 [ 355.876581] ? synchronize_irq+0xc3/0xc3 [ 355.876587] ? kthread_blkcg+0x31/0x31 [ 355.876592] ret_from_fork+0x1f/0x30 [ 355.876601] </TASK> This log shows that DA7219 AAD interrupt handler da7219_aad_irq_thread() is unexpectedly running when DA7219 is suspended and should not generate interrupts. As a result, the IRQ handler is trying to read AAD IRQ event status over I2C and is hitting the I2C driver "Transfer while suspended" failure. Patch #1 adds synchronize_irq() when suspending DA7219, to prevent the IRQ handler from running after suspending if there is a pending IRQ generated before suspending. With this patch the above failure is still reproducible, so this patch does not fix any real observed issue so far, but at least is useful for confirming that the above issue is not caused by a pending IRQ but rather looks like a DA7219 hardware issue with an unexpectedly generated IRQ. Patch #2 does not fix the above issue either, but it prevents its potentially harmful side effects. With the existing code, if the issue occurs and the IRQ handler fails to read the AAD IRQ events status over I2C, it does not check that and tries to use the garbage uninitialized value of the events status, potentially reporting bogus events. This patch fixes that by adding missing error checking. In fact I'm sending these patches not only to submit them for review but also to ask Renesas folks for any hints on a possible cause of the described DA7219 issue (AAD interrupts spuriously firing after jack detection is already disabled) or how to debug it further. Dmytro Maluka (2): ASoC: da7219: Flush pending AAD IRQ when suspending ASoC: da7219: Check for failure reading AAD IRQ events sound/soc/codecs/da7219-aad.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) base-commit: fdf0eaf11452d72945af31804e2a1048ee1b574c -- 2.41.0.255.g8b1d071c50-goog

2 3