October 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v6 0/5] ASoC: makes CPU/Codec channel connection map more generic
by Kuninori Morimoto 27 Oct '23

27 Oct '23

Hi Mark Cc Bard, Pierre-Louis, Jerome, DT-ML This is v6 patch-set. Current ASoC is supporting CPU/Codec = N:M (N < M) connection by using ch_map idea. This patch-set expands it that all connection uses this idea, and no longer N < M limit [1][2]. Link: https://lore.kernel.org/r/87fs6wuszr.wl-kuninori.morimoto.gx@renesas.com [1] Link: https://lore.kernel.org/r/878r7yqeo4.wl-kuninori.morimoto.gx@renesas.com [2] v5 have changed basic idea, and Intel might got some effect, but was Tested-by Pierre-Louis. Jerome's environment might got some effect, but it is less than Intel and similar environment was already tested by Audio-Graph-Card2 and its test dtsi. Thus, I added their Tested-by on v5 patch. v5 -> v6 - tidyup some warnings - rename "ch-map-idx" -> "channel-map-index" - Update "channel-map-index" description - add Tested-by from Pierre-Louis / Jerome v4 -> v5 - use cpu/codec index on ch_maps - separate card2 sample DT patch into prepare and new feature - ch-maps -> ch-map-idx on DT v3 -> v4 - add Jerome on To - add "description" on "ch-maps" v2 -> v3 - tidyup comment - use more clear connection image on DT - "ch_maps" -> "ch-maps" on DT - Add DT maintainer on "To:" for all patches v1 -> v2 - makes CPU/Codec connection relation clear on comment/sample - fixup type "connction" -> "connection" - makes error message clear Kuninori Morimoto (5): ASoC: makes CPU/Codec channel connection map more generic ASoC: audio-graph-card2: add CPU:Codec = N:M support ASoC: audio-graph-card2-custom-sample: tidyup comment / numbering ASoC: audio-graph-card2-custom-sample: add CPU/Codec = N:M sample dt-bindings: audio-graph-port: add channel-map-index property .../bindings/sound/audio-graph-port.yaml | 13 ++ include/sound/soc.h | 56 +++++++- .../audio-graph-card2-custom-sample.dtsi | 136 +++++++++++++++--- sound/soc/generic/audio-graph-card2.c | 49 +++++++ sound/soc/intel/boards/sof_sdw.c | 28 ++-- sound/soc/soc-core.c | 95 +++++++++++- sound/soc/soc-dapm.c | 45 ++---- sound/soc/soc-pcm.c | 44 ++---- 8 files changed, 366 insertions(+), 100 deletions(-) -- 2.25.1

3 8

[RFT PATCH 00/17] ASoC: fix widget name comparisons (consider DAI name prefix)
by Krzysztof Kozlowski 26 Oct '23

26 Oct '23

Hi, Some codec drivers compare widget names with strcmp, ignoring the component name prefix. If prefix is used, the comparisons start failing. Except Qualcomm lpass-rx-macro, none of the patches were tested on hardware. Best regards, Krzysztof Krzysztof Kozlowski (17): ASoC: codecs: 88pm860x: Handle component name prefix ASoC: codecs: adau1373: Handle component name prefix ASoC: codecs: adav80x: Handle component name prefix ASoC: codecs: lpass-rx-macro: Handle component name prefix ASoC: codecs: max9867: Handle component name prefix ASoC: codecs: rt5682s: Handle component name prefix ASoC: codecs: rtq9128: Handle component name prefix ASoC: codecs: wcd9335: Handle component name prefix ASoC: codecs: wm8962: Handle component name prefix ASoC: codecs: wm8994: Handle component name prefix ASoC: codecs: wm8995: Handle component name prefix ASoC: mediatek: mt8183: Handle component name prefix ASoC: mediatek: mt8186: Handle component name prefix ASoC: mediatek: mt8188: Handle component name prefix ASoC: mediatek: mt8192: Handle component name prefix ASoC: samsung: speyside: Handle component name prefix ASoC: tegra: machine: Handle component name prefix sound/soc/codecs/88pm860x-codec.c | 4 ++-- sound/soc/codecs/adau1373.c | 2 +- sound/soc/codecs/adav80x.c | 2 +- sound/soc/codecs/lpass-rx-macro.c | 6 +++--- sound/soc/codecs/max9867.c | 8 ++++---- sound/soc/codecs/rt5682s.c | 4 ++-- sound/soc/codecs/rtq9128.c | 6 +++--- sound/soc/codecs/wcd9335.c | 18 +++++++++--------- sound/soc/codecs/wm8962.c | 4 ++-- sound/soc/codecs/wm8994.c | 2 +- sound/soc/codecs/wm8995.c | 2 +- sound/soc/mediatek/mt8183/mt8183-dai-i2s.c | 4 ++-- sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 +- sound/soc/mediatek/mt8186/mt8186-dai-hw-gain.c | 2 +- sound/soc/mediatek/mt8186/mt8186-dai-i2s.c | 4 ++-- sound/soc/mediatek/mt8186/mt8186-dai-src.c | 4 ++-- sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 4 ++-- sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 4 ++-- sound/soc/mediatek/mt8192/mt8192-dai-i2s.c | 4 ++-- sound/soc/samsung/speyside.c | 4 ++-- sound/soc/tegra/tegra_asoc_machine.c | 12 ++++++++---- 21 files changed, 53 insertions(+), 49 deletions(-) -- 2.34.1

6 29

[PATCH 0/2] sc7180: Add qdsp baked soundcard
by Nikita Travkin 26 Oct '23

26 Oct '23

Some devices, such as Acer Aspire 1, can't use lpass dirrectly, but instead must use adsp core to play sound. Since otherwise the hardware is, usually, very similar across the devices on the same platform, it makes sense to reuse the same boardfile. This series refactors the sc7180.c slightly and adds the functions to control clocks via adsp instead of controlling the hardware directly. Existing google devices should experience no change. Signed-off-by: Nikita Travkin <nikita(a)trvn.ru> --- Nikita Travkin (2): ASoC: dt-bindings: qcom,sm8250: Add sc7180-qdsp6-sndcard ASoC: qcom: sc7180: Add support for qdsp6 baked sound .../devicetree/bindings/sound/qcom,sm8250.yaml | 1 + sound/soc/qcom/sc7180.c | 195 ++++++++++++++++++--- 2 files changed, 174 insertions(+), 22 deletions(-) --- base-commit: 2030579113a1b1b5bfd7ff24c0852847836d8fd1 change-id: 20231020-sc7180-qdsp-sndcard-e8067017eb4c Best regards, -- Nikita Travkin <nikita(a)trvn.ru>

5 7

[PATCH v2 0/4] ASoC: Intel: bytcr_wm5102: add various quirks
by Hans de Goede 26 Oct '23

26 Oct '23

Hi Mark, As requested here is a v2 of my series to add various quirks to the bytcr_wm5102 Intel board driver to make it more flexible. Changes in v2: - Dropped 2 already merged patches - Rebased on top of broonie/sound/for-6.7 Regards, Hans Hans de Goede (4): ASoC: Intel: bytcr_wm5102: Add BYT_WM5102_SSP2 quirk ASoC: Intel: bytcr_wm5102: Add BYT_WM5102_MCLK_19_2MHZ quirk ASoC: Intel: bytcr_wm5102: Add BYT_WM5102_OUT_MAP quirk ASoC: Intel: bytcr_wm5102: Add BYT_WM5102_IN_MAP quirk sound/soc/intel/boards/bytcr_wm5102.c | 229 +++++++++++++++++++++++--- 1 file changed, 202 insertions(+), 27 deletions(-) -- 2.41.0

2 5

[PATCH v1 0/8] System Suspend fixes and improvements for CS35L41 HDA
by Stefan Binding 26 Oct '23

26 Oct '23

There is a report of a single laptop which uses CS35L41 HDA having an issue with System Suspend. This particular laptop uses S3 (Deep) Sleep. The reported issue states that when the laptop resumes from a system suspend, audio no longer works. The root cause of this issue is due to the CS35L41 being returned to us in an unexpected state after a suspend/resume cycle. When the driver resumes, it expects the parts to have been reset, which leads to issues with audio and firmware loading. To prevent this issue, and the possibility of similar issues, patches 2-5 force the driver to reset during probe, system suspend, and system resume, which ensures that the part is always in the correct state. Patches 6-8 are improvements in the suspend and firmware loading code, which makes it easier to detect issues in the future, as well as simplifiying the suspend code. Patch 1 is a fix for an incorrect configuration for the HP Zbook Fury 17, which is the laptop which had the original issue. Stefan Binding (8): ALSA: hda: cs35l41: Use reset label to get GPIO for HP Zbook Fury 17 G9 ALSA: hda: cs35l41: Assert reset before system suspend ALSA: hda: cs35l41: Assert Reset prior to de-asserting in probe and system resume ALSA: hda: cs35l41: Run boot process during resume callbacks ALSA: hda: cs35l41: Force a software reset after hardware reset ALSA: hda: cs35l41: Do not unload firmware before reset in system suspend ALSA: hda: cs35l41: Check CSPL state after loading firmware ASoC: cs35l41: Detect CSPL errors when sending CSPL commands include/sound/cs35l41.h | 3 + sound/pci/hda/cs35l41_hda.c | 170 +++++++++++++++++---------- sound/pci/hda/cs35l41_hda_property.c | 11 +- sound/soc/codecs/cs35l41-lib.c | 6 + 4 files changed, 124 insertions(+), 66 deletions(-) -- 2.34.1

3 10

[PATCH] ASoC: qcom: q6apm-lpass-dais: pass max number of channels to Audioreach
by Krzysztof Kozlowski 26 Oct '23

26 Oct '23

Using the params_channels() helper when setting hw_params, results in passing to Audioreach minimum number of channels valid for given hardware. This is not valid for any hardware which sets minimum channels to two and maximum to something bigger, like four channels. Instead pass the maximum number of supported channels to allow playback of multi-channel formats. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c index 7ad604b80e25..c5e065a21e27 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -97,7 +97,7 @@ static int q6hdmi_hw_params(struct snd_pcm_substream *substream, { struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev); struct audioreach_module_config *cfg = &dai_data->module_config[dai->id]; - int channels = params_channels(params); + int channels = hw_param_interval_c(params, SNDRV_PCM_HW_PARAM_CHANNELS)->max; int ret; cfg->bit_width = params_width(params); @@ -130,7 +130,7 @@ static int q6dma_hw_params(struct snd_pcm_substream *substream, cfg->bit_width = params_width(params); cfg->sample_rate = params_rate(params); - cfg->num_channels = params_channels(params); + cfg->num_channels = hw_param_interval_c(params, SNDRV_PCM_HW_PARAM_CHANNELS)->max; return 0; } -- 2.34.1

2 3

[PATCH] ASoC: codecs: wcd938x: use defines for entries in snd_soc_dai_driver array
by Krzysztof Kozlowski 26 Oct '23

26 Oct '23

snd_soc_dai_driver array in wcd938x driver has two entries whose order must match order of wcd938x->sdw_priv array. The wcd938x_bind() and wcd938x_codec_set_sdw_stream() rely on this order. wcd938x->sdw_priv array is indexed by enum with AIF1_PB and AIF1_CAP, so use the same defines instead of raw numners for snd_soc_dai_driver array. No functional impact. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- sound/soc/codecs/wcd938x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index a3c680661377..a162bd46ba3e 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3392,7 +3392,7 @@ static const struct snd_soc_dai_ops wcd938x_sdw_dai_ops = { }; static struct snd_soc_dai_driver wcd938x_dais[] = { - [0] = { + [AIF1_PB] = { .name = "wcd938x-sdw-rx", .playback = { .stream_name = "WCD AIF1 Playback", @@ -3405,7 +3405,7 @@ static struct snd_soc_dai_driver wcd938x_dais[] = { }, .ops = &wcd938x_sdw_dai_ops, }, - [1] = { + [AIF1_CAP] = { .name = "wcd938x-sdw-tx", .capture = { .stream_name = "WCD AIF1 Capture", -- 2.34.1

2 1

[PATCH] ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger
by Su Hui 26 Oct '23

26 Oct '23

skl_decoupled_trigger() can return error code like -EPIPE if failed, add check for this. Signed-off-by: Su Hui <suhui(a)nfschina.com> --- sound/soc/intel/skylake/skl-pcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index ac3dc8c63c26..40308501f8bf 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -518,6 +518,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd, return ret; ret = skl_decoupled_trigger(substream, cmd); + if (ret < 0) + return ret; + if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) { /* save the dpib and lpib positions */ hstream->dpib = readl(bus->remap_addr + -- 2.30.2

2 1

[PATCH] ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails
by Amadeusz Sławiński 26 Oct '23

26 Oct '23

From: Cezary Rojewski <cezary.rojewski(a)intel.com> Error path in snd_skl_parse_uuids() shall free last allocated module if its instance_id allocation fails. Fixes: f8e066521192 ("ASoC: Intel: Skylake: Fix uuid_module memory leak in failure case") Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> --- sound/soc/intel/skylake/skl-sst-utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index 57ea815d3f04..b776c58dcf47 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -299,6 +299,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, module->instance_id = devm_kzalloc(ctx->dev, size, GFP_KERNEL); if (!module->instance_id) { ret = -ENOMEM; + kfree(module); goto free_uuid_list; } -- 2.34.1

2 1

Fwd: No sound from monitor speakers unless snd_hda_codec_realtek is inserted before snd_hda_intel
by Bagas Sanjaya 26 Oct '23

26 Oct '23

Hi, I notice a bug report on Bugzilla [1]. Quoting from it: > I have an Asus Pro B550M-C/CSM motherboard, which uses a Realtek ALC887-VD, and a monitor (with speakers) plugged in via DisplayPort. On booting normally, I get no sound from the monitor speakers (other sound outputs like USB or bluetooth headphones work fine). > > I have found two workarounds for getting the monitor sound working: > 1. rmmod snd_hda_intel && modprobe snd_hda_intel > 2. ensure that snd_hda_codec_realtek is inserted before snd_hda_intel (e.g. by adding `softdep snd_hda_intel pre: snd_hda_codec_realtek` in modprobe.d) > > Notably, timing does not seem to be an issue: even if snd_hda_intel is blacklisted from loading at boot, it will not work when it is loaded unless is is unloaded and loaded again or snd_hda_codec_realtek is loaded first. > > This is not a recent regression - it has been happening as long as I have had the hardware (since at least late 2021). > > Since it's not clear which is more useful, I am attaching two runs of alsa-info.sh - one is from a normal boot with sound not working, and the other is after running rmmod snd_hda_intel && modprobe snd_hda_intel with sound working. See Bugzilla for the full thread and alsa-input output on both working and buggy cases. AFAIK, it looks like module dependency issue. Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218027 -- An old man doll... just what I always wanted! - Clara

1 0