October 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: codecs: wcd938x: use defines for entries in snd_soc_dai_driver array
by Krzysztof Kozlowski 26 Oct '23

26 Oct '23

snd_soc_dai_driver array in wcd938x driver has two entries whose order must match order of wcd938x->sdw_priv array. The wcd938x_bind() and wcd938x_codec_set_sdw_stream() rely on this order. wcd938x->sdw_priv array is indexed by enum with AIF1_PB and AIF1_CAP, so use the same defines instead of raw numners for snd_soc_dai_driver array. No functional impact. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- sound/soc/codecs/wcd938x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index a3c680661377..a162bd46ba3e 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3392,7 +3392,7 @@ static const struct snd_soc_dai_ops wcd938x_sdw_dai_ops = { }; static struct snd_soc_dai_driver wcd938x_dais[] = { - [0] = { + [AIF1_PB] = { .name = "wcd938x-sdw-rx", .playback = { .stream_name = "WCD AIF1 Playback", @@ -3405,7 +3405,7 @@ static struct snd_soc_dai_driver wcd938x_dais[] = { }, .ops = &wcd938x_sdw_dai_ops, }, - [1] = { + [AIF1_CAP] = { .name = "wcd938x-sdw-tx", .capture = { .stream_name = "WCD AIF1 Capture", -- 2.34.1

2 1

[PATCH] ASoC: Intel: Skylake: add an error code check in skl_pcm_trigger
by Su Hui 26 Oct '23

26 Oct '23

skl_decoupled_trigger() can return error code like -EPIPE if failed, add check for this. Signed-off-by: Su Hui <suhui(a)nfschina.com> --- sound/soc/intel/skylake/skl-pcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index ac3dc8c63c26..40308501f8bf 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -518,6 +518,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd, return ret; ret = skl_decoupled_trigger(substream, cmd); + if (ret < 0) + return ret; + if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) { /* save the dpib and lpib positions */ hstream->dpib = readl(bus->remap_addr + -- 2.30.2

2 1

[PATCH] ASoC: Intel: Skylake: Fix mem leak when parsing UUIDs fails
by Amadeusz Sławiński 26 Oct '23

26 Oct '23

From: Cezary Rojewski <cezary.rojewski(a)intel.com> Error path in snd_skl_parse_uuids() shall free last allocated module if its instance_id allocation fails. Fixes: f8e066521192 ("ASoC: Intel: Skylake: Fix uuid_module memory leak in failure case") Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> --- sound/soc/intel/skylake/skl-sst-utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index 57ea815d3f04..b776c58dcf47 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -299,6 +299,7 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, module->instance_id = devm_kzalloc(ctx->dev, size, GFP_KERNEL); if (!module->instance_id) { ret = -ENOMEM; + kfree(module); goto free_uuid_list; } -- 2.34.1

2 1

Fwd: No sound from monitor speakers unless snd_hda_codec_realtek is inserted before snd_hda_intel
by Bagas Sanjaya 26 Oct '23

26 Oct '23

Hi, I notice a bug report on Bugzilla [1]. Quoting from it: > I have an Asus Pro B550M-C/CSM motherboard, which uses a Realtek ALC887-VD, and a monitor (with speakers) plugged in via DisplayPort. On booting normally, I get no sound from the monitor speakers (other sound outputs like USB or bluetooth headphones work fine). > > I have found two workarounds for getting the monitor sound working: > 1. rmmod snd_hda_intel && modprobe snd_hda_intel > 2. ensure that snd_hda_codec_realtek is inserted before snd_hda_intel (e.g. by adding `softdep snd_hda_intel pre: snd_hda_codec_realtek` in modprobe.d) > > Notably, timing does not seem to be an issue: even if snd_hda_intel is blacklisted from loading at boot, it will not work when it is loaded unless is is unloaded and loaded again or snd_hda_codec_realtek is loaded first. > > This is not a recent regression - it has been happening as long as I have had the hardware (since at least late 2021). > > Since it's not clear which is more useful, I am attaching two runs of alsa-info.sh - one is from a normal boot with sound not working, and the other is after running rmmod snd_hda_intel && modprobe snd_hda_intel with sound working. See Bugzilla for the full thread and alsa-input output on both working and buggy cases. AFAIK, it looks like module dependency issue. Thanks. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=218027 -- An old man doll... just what I always wanted! - Clara

1 0

[bug report] ASoC: cx20442: replace codec to component
by Dan Carpenter 26 Oct '23

26 Oct '23

[ I don't know why I am seeing warnings from 2018 today. Also this patch didn't really introduce the bug, it's just the variables were renamed. -dan ] Hello Kuninori Morimoto, This is a semi-automatic email about new static checker warnings. The patch d0fdfe34080c: "ASoC: cx20442: replace codec to component" from Jan 29, 2018, leads to the following Smatch complaint: sound/soc/ti/ams-delta.c:311 cx81801_close() warn: variable dereferenced before check 'component' (see line 304) sound/soc/ti/ams-delta.c 303 struct snd_soc_component *component = tty->disc_data; 304 struct snd_soc_dapm_context *dapm = &component->card->dapm; ^^^^^^^^^^^^^^^^^^ Dereference. 305 306 del_timer_sync(&cx81801_timer); 307 308 /* Prevent the hook switch from further changing the DAPM pins */ 309 INIT_LIST_HEAD(&ams_delta_hook_switch.pins); 310 311 if (!component) ^^^^^^^^^^ Check for NULL is too late. 312 return; 313 regards, dan carpenter

2 1

[bug report] ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization
by Dan Carpenter 26 Oct '23

26 Oct '23

Hello Sylwester Nawrocki, The patch c6bebefa2f06: "ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization" from Feb 19, 2019 (linux-next), leads to the following Smatch static checker warning: sound/soc/samsung/i2s.c:1381 i2s_create_secondary_device() info: return a literal instead of 'ret' sound/soc/samsung/i2s.c 1350 static int i2s_create_secondary_device(struct samsung_i2s_priv *priv) 1351 { 1352 struct platform_device *pdev_sec; 1353 const char *devname; 1354 int ret; 1355 1356 devname = devm_kasprintf(&priv->pdev->dev, GFP_KERNEL, "%s-sec", 1357 dev_name(&priv->pdev->dev)); 1358 if (!devname) 1359 return -ENOMEM; 1360 1361 pdev_sec = platform_device_alloc(devname, -1); 1362 if (!pdev_sec) 1363 return -ENOMEM; 1364 1365 pdev_sec->driver_override = kstrdup("samsung-i2s", GFP_KERNEL); 1366 if (!pdev_sec->driver_override) { 1367 platform_device_put(pdev_sec); 1368 return -ENOMEM; 1369 } 1370 1371 ret = platform_device_add(pdev_sec); 1372 if (ret < 0) { 1373 platform_device_put(pdev_sec); 1374 return ret; 1375 } 1376 1377 ret = device_attach(&pdev_sec->dev); 1378 if (ret <= 0) { Huh. I'm not sure how device_attach() is supposed to be handled. Here are the return values. * Returns 1 if the device was bound to a driver; * 0 if no matching driver was found; * -ENODEV if the device is not registered. 1379 platform_device_unregister(priv->pdev_sec); 1380 dev_info(&pdev_sec->dev, "device_attach() failed\n"); --> 1381 return ret; So in this case we printing that "device_attach() failed\n" but we're returning success to the caller. It might be correct, but if so then it should have a comment. 1382 } 1383 1384 priv->pdev_sec = pdev_sec; 1385 1386 return 0; 1387 } regards, dan carpenter

1 0

[PATCH 0/3] ARM: omap4: embt2ws: Add audio support
by Andreas Kemnade 25 Oct '23

25 Oct '23

Add audio support for Epson Moverio BT-200. In the vendor kernel, the MCBSP side is used as master, so do it here also that way. Andreas Kemnade (3): ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src ASoC: tlv320aic3x: use BCLK instead of MCLK if not in master mode ARM: dts: omap4: embt2ws: Add audio support arch/arm/boot/dts/omap4-epson-embt2ws.dts | 21 +++++++++++++++++++++ sound/soc/codecs/tlv320aic3x.c | 4 ++++ sound/soc/ti/omap-mcbsp.c | 4 ++-- 3 files changed, 27 insertions(+), 2 deletions(-) -- 2.39.2

4 28

[PATCH] MAINTAINERS: ALSA: change mailing list to linux-sound on vger
by Jaroslav Kysela 25 Oct '23

25 Oct '23

As discussed on alsa-devel mailing list [1], it is useful to have an open mailing list to avoid moderation delays for the kernel patch work. Use linux-sound mailing list for kernel driver related threads. In the first stage, change the list for the ALSA core, ASoC and tests. [1] https://lore.kernel.org/alsa-devel/20231019-posture-cache-fe060b@meerkat/ Cc: Takashi Iwai <tiwai(a)suse.com> Cc: Mark Brown <broonie(a)kernel.org> Cc: Ivan Orlov <ivan.orlov0322(a)gmail.com> Cc: Konstantin Ryabitsev <konstantin(a)linuxfoundation.org> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- MAINTAINERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7a7bd8bd80e9..007c0b204df7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20061,7 +20061,7 @@ F: include/linux/sony-laptop.h SOUND M: Jaroslav Kysela <perex(a)perex.cz> M: Takashi Iwai <tiwai(a)suse.com> -L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +L: linux-sound(a)vger.kernel.org S: Maintained W: http://www.alsa-project.org/ Q: http://patchwork.kernel.org/project/alsa-devel/list/ @@ -20074,7 +20074,7 @@ F: tools/testing/selftests/alsa SOUND - ALSA SELFTESTS M: Mark Brown <broonie(a)kernel.org> -L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +L: linux-sound(a)vger.kernel.org L: linux-kselftest(a)vger.kernel.org S: Supported F: tools/testing/selftests/alsa @@ -20100,7 +20100,7 @@ F: sound/soc/soc-generic-dmaengine-pcm.c SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEMENT (ASoC) M: Liam Girdwood <lgirdwood(a)gmail.com> M: Mark Brown <broonie(a)kernel.org> -L: alsa-devel(a)alsa-project.org (moderated for non-subscribers) +L: linux-sound(a)vger.kernel.org S: Supported W: http://alsa-project.org/main/index.php/ASoC T: git git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git @@ -22931,7 +22931,7 @@ F: fs/vboxsf/* VIRTUAL PCM TEST DRIVER M: Ivan Orlov <ivan.orlov0322(a)gmail.com> -L: alsa-devel(a)alsa-project.org +L: linux-sound(a)vger.kernel.org S: Maintained F: Documentation/sound/cards/pcmtest.rst F: sound/drivers/pcmtest.c -- 2.41.0

5 7

[PATCH V2 0/4] ASoC: codecs: Add aw88399 amplifier driver
by wangweidong.a＠awinic.com 25 Oct '23

25 Oct '23

From: Weidong Wang <wangweidong.a(a)awinic.com> Add the awinic,aw88399 property to the awinic,aw88395.yaml file. Add i2c and amplifier registration for aw88399 and their associated operation functions. v1 -> v2: Modify the reset mode Delete AW88399_DSP_I2C_WRITES macros and related debugging statements Change the value of max_register in aw88399 Change the value of max_register in aw88261 Delete the judgment of unnecessary pointers Modify the judgment of the ret return value Weidong Wang (4): ASoC: dt-bindings: Add schema for "awinic,aw88399" ASoC: codecs: Modify max_register usage error ASoC: codecs: Add code for bin parsing compatible with aw88399 ASoC: codecs: Add aw88399 amplifier driver .../bindings/sound/awinic,aw88395.yaml | 1 + sound/soc/codecs/Kconfig | 14 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/aw88261.c | 2 +- sound/soc/codecs/aw88395/aw88395_lib.c | 3 + sound/soc/codecs/aw88395/aw88395_reg.h | 1 + sound/soc/codecs/aw88399.c | 1911 +++++++++++++++++ sound/soc/codecs/aw88399.h | 599 ++++++ 8 files changed, 2532 insertions(+), 1 deletion(-) create mode 100644 sound/soc/codecs/aw88399.c create mode 100644 sound/soc/codecs/aw88399.h base-commit: ce55c22ec8b223a90ff3e084d842f73cfba35588 -- 2.41.0

2 16

[PATCH] sound: add quirk flag to enable native DSD for McIntosh devices
by McCarthy, Max 25 Oct '23

25 Oct '23

From: Max McCarthy <mmccarthy(a)mcintoshlabs.com> McIntosh devices supporting native DSD require the feature to be explicitly exposed. Add a flag that fixes an issue where DSD audio was defaulting to DSD over PCM instead of delivering raw DSD data. Signed-off-by: Max McCarthy <mmccarthy(a)mcintoshlabs.com> --- sound/usb/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 4e64842245e1..ab2b938502eb 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -2220,6 +2220,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_DSD_RAW), VENDOR_FLG(0x2ab6, /* T+A devices */ QUIRK_FLAG_DSD_RAW), + VENDOR_FLG(0x2afd, /* McIntosh Laboratory, Inc. */ + QUIRK_FLAG_DSD_RAW), VENDOR_FLG(0x2d87, /* Cayin device */ QUIRK_FLAG_DSD_RAW), VENDOR_FLG(0x3336, /* HEM devices */ ---

2 1