June 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH 00/23] add annotation to object properties
by GitHub pull_request - opened 20 Jun '22

20 Jun '22

alsa-project/alsa-gobject pull request #77 was opened from takaswie: The gi-docgen tool requires explicit annotation for object properties to generate pages. This patchset adds missing properties for the purpose. ``` Takashi Sakamoto (23): ctl: card: add annotation to object properties ctl: card-info: add annotation to object properties card: elem-value: add annotation to object properties rawmidi: stream-pair: add annotation to object properties rawmidi: substream-info: add annotation to object properties rawmidi: substream-params: add annotation to object properties rawmidi: substream-status: add annotation to object properties hwdep: device-info: add annotation to object properties timer: device-info: add annotation to object properties timer: device-params: add annotation to object properties timer: device-status: add annotation to object properties timer: instance-info: add annotation to object properties timer: instance-params: add annotation to object properties timer: instance-status: add annotation to object properties seq: fix description of object properties in which enumerations are available seq: client-info: add annotation to object properties seq: client-pool: add annotation to object properties seq: port-info: fix tag indentation seq: queue-info: add annotation to object properties seq: queue-status: add annotation to object properties seq: queue-tempo: add annotation to object properties seq: system-info: add annotation to object properties seq: user-client: add annotation to object properties src/ctl/card-info.c | 37 ++++++++++++++++++- src/ctl/card.c | 12 ++++++- src/ctl/elem-value.c | 5 +++ src/hwdep/device-info.c | 34 +++++++++++++++--- src/rawmidi/stream-pair.c | 7 +++- src/rawmidi/substream-info.c | 66 +++++++++++++++++++++++++++++----- src/rawmidi/substream-params.c | 22 +++++++++--- src/rawmidi/substream-status.c | 10 ++++++ src/seq/client-info.c | 59 ++++++++++++++++++++++++++---- src/seq/client-pool.c | 52 ++++++++++++++++++++------- src/seq/port-info.c | 2 +- src/seq/query.c | 4 +-- src/seq/queue-info.c | 28 ++++++++++++--- src/seq/queue-status.c | 19 ++++++++-- src/seq/queue-tempo.c | 19 ++++++++-- src/seq/queue-timer-common.c | 2 +- src/seq/remove-filter.c | 19 +++++----- src/seq/system-info.c | 30 ++++++++++++++++ src/seq/user-client.c | 19 ++++++---- src/timer/device-info.c | 46 ++++++++++++++++++++++-- src/timer/device-params.c | 10 ++++++ src/timer/device-status.c | 15 ++++++++ src/timer/instance-info.c | 27 +++++++++++++- src/timer/instance-params.c | 18 ++++++++-- src/timer/instance-status.c | 20 +++++++++++ 25 files changed, 506 insertions(+), 76 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/77 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/77.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH v3 0/4] Add MT8186 ADSP dt-binding
by Tinghan Shen 20 Jun '22

20 Jun '22

v2 -> v3: 1. Change mbox-names to rx/tx for both mt8186 and mt8195. 2. Update description of mbox-names 3. Use static string array instead of kasprintf 4. Align clock names in dsp driver with dt-bindings v1 -> v2: 1. Change mbox-names from mbox0/mbox1 to rep/req for both mt8186 and mt8195. 2. rename clock-names and remove unused headers Tinghan Shen (4): dt-bindings: dsp: mediatek: Use meaningful names for mbox firmware: mediatek: Use meaningful names for mbox dt-bindings: dsp: mediatek: Add mt8186 dsp document ASoC: SOF: mediatek: Align mt8186 clock names with dt-bindings .../bindings/dsp/mediatek,mt8186-dsp.yaml | 91 +++++++++++++++++++ .../bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +- drivers/firmware/mtk-adsp-ipc.c | 36 +++----- sound/soc/sof/mediatek/mt8186/mt8186-clk.c | 4 +- 4 files changed, 110 insertions(+), 31 deletions(-) create mode 100644 Documentation/devicetree/bindings/dsp/mediatek,mt8186-dsp.yaml -- 2.18.0

2 9

[PATCH v3 00/17] ASoC: Intel: haswell and broadwell boards update
by Cezary Rojewski 20 Jun '22

20 Jun '22

A number of patches improving overall quality and readability of haswell.c and broadwell.c source files found in sound/soc/intel/boards. Both files are first renamed and only then actual changes are being incrementally added. The respective names are: hsw_rt5640 and bdw_rt286 to match the pattern found in more recent boards. Most patches bring no functional change - the more impactful patches at are placed the end: Refactor of suspend/resume flow for the bdw_rt286 board by dropping dev->remove() in favour of card->remove() and adjust jack handling to reduce code size slightly by implementing card_set_jack(). The last patch is removing of FE DAI ops. Given the existence of platform FE DAI capabilities (either static declaration or through topology file), this code is redundant. Changes in v3: - Patch 16/17 refactoring suspend/resume has been renamed to "Refactor jack handling". Dropped the usage of card->remove() in favor of link->exit() in that very patch Changes in v2: - fixed wording error in patch 02/17 so it correctly mentions 'haswell_rt5640', not 'broadwell_rt286' - decided not to add kernel module names changes to this patchset so the review is not complicated unnecessarily. Will send them separately instead Cezary Rojewski (17): ASoC: Intel: Rename haswell source file to hsw_rt5640 ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members ASoC: Intel: hsw_rt5640: Reword driver name ASoC: Intel: hsw_rt5640: Update code indentation ASoC: Intel: hsw_rt5640: Update file comments ASoC: Intel: hsw_rt5640: Improve probe() function quality ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability ASoC: Intel: Rename broadwell source file to bdw_rt286 ASoC: Intel: bdw_rt286: Reword prefixes of all driver members ASoC: Intel: bdw_rt286: Reword driver name ASoC: Intel: bdw_rt286: Update code indentation ASoC: Intel: bdw_rt286: Update file comments ASoC: Intel: bdw_rt286: Improve probe() function quality ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability ASoC: Intel: bdw_rt286: Improve codec_init() quality ASoC: Intel: bdw_rt286: Refactor jack handling ASoC: Intel: bdw_rt286: Remove FE DAI ops sound/soc/intel/boards/Kconfig | 4 +- sound/soc/intel/boards/Makefile | 4 +- sound/soc/intel/boards/bdw_rt286.c | 256 +++++++++++++ sound/soc/intel/boards/broadwell.c | 336 ------------------ sound/soc/intel/boards/haswell.c | 202 ----------- sound/soc/intel/boards/hsw_rt5640.c | 176 +++++++++ .../common/soc-acpi-intel-hsw-bdw-match.c | 6 +- 7 files changed, 439 insertions(+), 545 deletions(-) create mode 100644 sound/soc/intel/boards/bdw_rt286.c delete mode 100644 sound/soc/intel/boards/broadwell.c delete mode 100644 sound/soc/intel/boards/haswell.c create mode 100644 sound/soc/intel/boards/hsw_rt5640.c -- 2.25.1

1 17

[PATCH] ALSA: memalloc: Drop x86-specific hack for WC allocations
by Takashi Iwai 20 Jun '22

20 Jun '22

The recent report for a crash on Haswell machines implied that the x86-specific (rather hackish) implementation for write-cache memory buffer allocation in ALSA core is buggy with the recent kernel in some corner cases. This patch drops the x86-specific implementation and uses the standard dma_alloc_wc() & co generically for avoiding the bug and also for simplification. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=216112 Cc: <stable(a)vger.kernel.org> # v5.18+ Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/memalloc.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c index 15dc7160ba34..8cfdaee77905 100644 --- a/sound/core/memalloc.c +++ b/sound/core/memalloc.c @@ -431,33 +431,17 @@ static const struct snd_malloc_ops snd_dma_iram_ops = { */ static void *snd_dma_dev_alloc(struct snd_dma_buffer *dmab, size_t size) { - void *p; - - p = dma_alloc_coherent(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); -#ifdef CONFIG_X86 - if (p && dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - set_memory_wc((unsigned long)p, PAGE_ALIGN(size) >> PAGE_SHIFT); -#endif - return p; + return dma_alloc_coherent(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); } static void snd_dma_dev_free(struct snd_dma_buffer *dmab) { -#ifdef CONFIG_X86 - if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - set_memory_wb((unsigned long)dmab->area, - PAGE_ALIGN(dmab->bytes) >> PAGE_SHIFT); -#endif dma_free_coherent(dmab->dev.dev, dmab->bytes, dmab->area, dmab->addr); } static int snd_dma_dev_mmap(struct snd_dma_buffer *dmab, struct vm_area_struct *area) { -#ifdef CONFIG_X86 - if (dmab->dev.type == SNDRV_DMA_TYPE_DEV_WC) - area->vm_page_prot = pgprot_writecombine(area->vm_page_prot); -#endif return dma_mmap_coherent(dmab->dev.dev, area, dmab->area, dmab->addr, dmab->bytes); } @@ -471,10 +455,6 @@ static const struct snd_malloc_ops snd_dma_dev_ops = { /* * Write-combined pages */ -#ifdef CONFIG_X86 -/* On x86, share the same ops as the standard dev ops */ -#define snd_dma_wc_ops snd_dma_dev_ops -#else /* CONFIG_X86 */ static void *snd_dma_wc_alloc(struct snd_dma_buffer *dmab, size_t size) { return dma_alloc_wc(dmab->dev.dev, size, &dmab->addr, DEFAULT_GFP); @@ -497,7 +477,6 @@ static const struct snd_malloc_ops snd_dma_wc_ops = { .free = snd_dma_wc_free, .mmap = snd_dma_wc_mmap, }; -#endif /* CONFIG_X86 */ #ifdef CONFIG_SND_DMA_SGBUF static void *snd_dma_sg_fallback_alloc(struct snd_dma_buffer *dmab, size_t size); -- 2.35.3

1 0

Enabling tstamp in proc status file externally
by Pavel Hofman 20 Jun '22

20 Jun '22

Hi, Please is there any way to enable the tstamp in stream status without modifying the client calling the alsa-lib API? I wanted to measure samplerate ratio between soundcards using data in their status proc files (comparing advancement of tstamp vs. hw_ptr). The method seems to work quite good, but some clients enable the stream status tstamp (e.g. pulseaudio) and some don't (e.g. sox, aplay), resulting in zeros in the status proc file. Thanks a lot for any help or hint. Best regards, Pavel.

2 3

alsa-utils 1.2.7 fails to build if rawmidi support is disabled in alsa-lib
by GitHub issues - opened 19 Jun '22

19 Jun '22

alsa-project/alsa-utils issue #154 was opened from Saur2000: If alsa-lib is configured using `--disable-rawmidi`, then alsa-utils fails to build: ``` alsactl/info.c:83:44: error: unknown type name 'snd_rawmidi_stream_t'; did you mean 'snd_pcm_stream_t'? 83 | static const char *snd_rawmidi_stream_name(snd_rawmidi_stream_t stream) | ^~~~~~~~~~~~~~~~~~~~ | snd_pcm_stream_t alsactl/info.c:92:48: error: unknown type name 'snd_rawmidi_stream_t'; did you mean 'snd_pcm_stream_t'? 92 | static int rawmidi_device_list(snd_ctl_t *ctl, snd_rawmidi_stream_t stream, bool *first) | ^~~~~~~~~~~~~~~~~~~~ | snd_pcm_stream_t ``` Issue URL : https://github.com/alsa-project/alsa-utils/issues/154 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Alsa-to-Jack bridge broken in alsa* 1.2.7.x
by GitHub issues - opened 19 Jun '22

19 Jun '22

alsa-project/alsa-lib issue #243 was opened from hlekin: I am using a setup according to https://alsa.opensrc.org/Jack_and_Loopback_device_as_Alsa-to-Jack_bridge Since the upgrade of alsa-lib, alsa-ucm-conf, and alsa-utils to version 1.2.7, my alsa-to-jack-bridge setup is broken: $ jack_connect system:capture_1 ploop:playback_1 ERROR ploop:playback_1 not a valid port A downgrade to versions 1.2.6 resolves the issue. Versions 1.2.7.1 result in the same error. The relevant output of qjackctl 0.9.7-2 > Messages is: Cannot write socket fd = 25 err = Broken pipe CheckRes error Could not write notification ClientNotify fails name = cloop notification = 0 val1 = 0 val2 = 0 NotifyAddClient old_client fails name = ploop Cannot write socket fd = 28 err = Broken pipe CheckRes error Could not write notification ClientNotify fails name = ploop notification = 1 val1 = 0 val2 = 0 ERROR ploop:playback_1 not a valid port ERROR ploop:playback_2 not a valid port ERROR cloop:capture_1 not a valid port ERROR cloop:capture_2 not a valid port Please find attached alsa-info.sh output for alsa-versions 1.2.7.1 and 1.2.6 [alsa-info.sh-output-220619.zip](https://github.com/alsa-project/alsa-lib/fi… . I am aware, that this is a very poor bug report. Please ask for any information you need! By the way, many thanks for all your programs and the effort you put in to them. Issue URL : https://github.com/alsa-project/alsa-lib/issues/243 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

pcm: Return unsigned int if error occurs by `read` or `write` system call
by GitHub pull_request - opened 19 Jun '22

19 Jun '22

alsa-project/alsa-lib pull request #242 was opened from Korilakkuma: `read` or `write` system call returns `-1` if error occurs. Request URL : https://github.com/alsa-project/alsa-lib/pull/242 Patch URL : https://github.com/alsa-project/alsa-lib/pull/242.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH] aplay: Support setting timestamp
by Pavel Hofman 18 Jun '22

18 Jun '22

To allow enabling timestamp and specify its type, a new option --tstamp-type=TYPE is added. Recognized values are none (default), gettimeofday, monotonic, monotonic-raw. Signed-off-by: Pavel Hofman <pavel.hofman(a)ivitera.com> --- aplay/aplay.1 | 4 ++++ aplay/aplay.c | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/aplay/aplay.1 b/aplay/aplay.1 index 3bba59d..d3b7dce 100644 --- a/aplay/aplay.1 +++ b/aplay/aplay.1 @@ -207,6 +207,10 @@ sampling rates, numbers of channels, period and buffer bytes/sizes/times. For raw device hw:X this option basically lists hardware capabilities of the soundcard. .TP +\fI\-\-tstamp\-type=TYPE\fP +Specifies timestamp type inside the software configuration container. +Types are: none (default), gettimeofday, monotonic, monotonic\-raw. +.TP \fI\-\-fatal\-errors\fP Disables recovery attempts when errors (e.g. xrun) are encountered; the aplay process instead aborts immediately. diff --git a/aplay/aplay.c b/aplay/aplay.c index 63a4e34..5d15a32 100644 --- a/aplay/aplay.c +++ b/aplay/aplay.c @@ -139,6 +139,8 @@ static int use_strftime = 0; volatile static int recycle_capture_file = 0; static long term_c_lflag = -1; static int dump_hw_params = 0; +static int enable_tstamp = 0; +static snd_pcm_tstamp_type_t tstamp_type = SND_PCM_TSTAMP_TYPE_GETTIMEOFDAY; static int fd = -1; static off64_t pbrec_count = LLONG_MAX, fdcount; @@ -244,6 +246,8 @@ _("Usage: %s [OPTION]... [FILE]...\n" " --process-id-file write the process ID here\n" " --use-strftime apply the strftime facility to the output file name\n" " --dump-hw-params dump hw_params of the device\n" +" --tstamp-type=TYPE set timestamp (TYPE: none (default), gettimeofday,\n" +" monotonic, monotonic-raw)\n" " --fatal-errors treat all errors as fatal\n" ) , command); @@ -430,6 +434,7 @@ enum { OPT_PROCESS_ID_FILE, OPT_USE_STRFTIME, OPT_DUMP_HWPARAMS, + OPT_TSTAMP_TYPE, OPT_FATAL_ERRORS, }; @@ -517,6 +522,7 @@ int main(int argc, char *argv[]) {"use-strftime", 0, 0, OPT_USE_STRFTIME}, {"interactive", 0, 0, 'i'}, {"dump-hw-params", 0, 0, OPT_DUMP_HWPARAMS}, + {"tstamp-type", 1, 0, OPT_TSTAMP_TYPE}, {"fatal-errors", 0, 0, OPT_FATAL_ERRORS}, #ifdef CONFIG_SUPPORT_CHMAP {"chmap", 1, 0, 'm'}, @@ -799,6 +805,23 @@ int main(int argc, char *argv[]) case OPT_DUMP_HWPARAMS: dump_hw_params = 1; break; + case OPT_TSTAMP_TYPE: + if (strcasecmp(optarg, "gettimeofday") == 0) { + enable_tstamp = 1; + tstamp_type = SND_PCM_TSTAMP_TYPE_GETTIMEOFDAY; + } else if (strcasecmp(optarg, "monotonic") == 0) { + enable_tstamp = 1; + tstamp_type = SND_PCM_TSTAMP_TYPE_MONOTONIC; + } else if (strcasecmp(optarg, "monotonic-raw") == 0) { + enable_tstamp = 1; + tstamp_type = SND_PCM_TSTAMP_TYPE_MONOTONIC_RAW; + } else if (strcasecmp(optarg, "none") == 0) + enable_tstamp = 0; + else { + error(_("unrecognized timestamp type %s"), optarg); + return 1; + } + break; case OPT_FATAL_ERRORS: fatal_errors = 1; break; @@ -1453,6 +1476,15 @@ static void set_params(void) stop_threshold = (double) rate * stop_delay / 1000000; err = snd_pcm_sw_params_set_stop_threshold(handle, swparams, stop_threshold); assert(err >= 0); + if (enable_tstamp) { + err = snd_pcm_sw_params_set_tstamp_mode(handle, swparams, SND_PCM_TSTAMP_ENABLE); + assert(err >= 0); + err = snd_pcm_sw_params_set_tstamp_type(handle, swparams, tstamp_type); + if (err < 0) { + error(_("Unable to set the requested timestamp type.")); + prg_exit(EXIT_FAILURE); + } + } if (snd_pcm_sw_params(handle, swparams) < 0) { error(_("unable to install sw params:")); -- 2.25.1

3 6

[PATCH v2 0/3] firewire: fix minor issues
by Takashi Sakamoto 18 Jun '22

18 Jun '22

This second version of patchset is revised version of previous one[1] to fix mistake of macro usage pointed out by reviewer[2]. As I note, they are not so urgent changes, thus I don't mind postponing until next merge window. [1] https://lore.kernel.org/alsa-devel/20220512111756.103008-1-o-takashi@sakamo… [2] https://lore.kernel.org/alsa-devel/87o7yvpf4t.wl-tiwai@suse.de/ Jiapeng Chong (1): firewire: convert sysfs sprintf/snprintf family to sysfs_emit Lv Ruyi (1): firewire: Fix using uninitialized value Minghao Chi (CGEL ZTE) (1): firewire: use struct_size over open coded arithmetic drivers/firewire/core-device.c | 6 ++---- drivers/firewire/core-transaction.c | 3 ++- 2 files changed, 4 insertions(+), 5 deletions(-) -- 2.34.1

2 7