February 2021 - Alsa-devel - mailman.alsa-project.org

Bass speaker is off on yoga slim 7i 15 (Yoga Slim 7-15ITL05)
by GitHub issues - edited 12 Feb '21

12 Feb '21

alsa-project/alsa-ucm-conf issue #83 was edited from juliusvonkohout: Alsainfo: http://alsa-project.org/db/?f=673e04313fa931831176ed3f50a9af1c9206395e I tested with fedora 33, 34 and Ubuntu 21.04. Only the high frequency speakers at the laptop bottom are working, while the speakers above the keyboard are off. Here is a link to the laptop https://www.lenovo.com/de/de/laptops/yoga/yoga-slim-series/Yoga-Slim-7-15II… In Microsoft Windows 10 everything is fine. In Ubuntu 21.04 i can at least change the bass speaker volume in alsamixer, but it is changing hardware master volume instead of hardware bass speaker volume. In Feodra 33 and 34 i can not even change the bass speaker volume in alsamixer ![audiobug](https://user-images.githubusercontent.com/45896133/107797084-d3090500-6d5a-11eb-86fb-229800b546b0.png) You can immiediatly hear, that the bass speaker above the keyboard is off [audio.zip](https://github.com/alsa-project/alsa-ucm-conf/files/5973232/audi… There are related bugs for ALC287 The same bug on other yoga laptops https://bugzilla.kernel.org/show_bug.cgi?id=205755 Patches for the issue on other yoga Laptops https://patchwork.kernel.org/project/alsa-devel/patch/20201205051130.8122-1… Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/83 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Bass speaker is off on yoga slim 7i 15 (7-15ITL)
by GitHub issues - opened 12 Feb '21

12 Feb '21

alsa-project/alsa-ucm-conf issue #83 was opened from juliusvonkohout: Alsainfo: http://alsa-project.org/db/?f=673e04313fa931831176ed3f50a9af1c9206395e I tested with fedora 33, 34 and Ubuntu 21.04. Only the high frequency speakers at the laptop bottom are working, while the speakers above the keyboard are off. Here is a link to the laptop https://www.lenovo.com/de/de/laptops/yoga/yoga-slim-series/Yoga-Slim-7-15II… In Microsoft Windows 10 everything is fine. In Ubuntu 21.04 i can at least change the bass speaker volume in alsamixer, but it is changing hardware master volume instead of hardware bass speaker volume. In Feodra 33 and 34 i can not even change the bass speaker volume in alsamixer ![audiobug](https://user-images.githubusercontent.com/45896133/107797084-d3090500-6d5a-11eb-86fb-229800b546b0.png) You can immiediatly hear, that the bass speaker above the keyboard is off [audio.zip](https://github.com/alsa-project/alsa-ucm-conf/files/5973232/audi… There are related bugs for ALC287 The same bug on other yoga laptops https://bugzilla.kernel.org/show_bug.cgi?id=205755 Patches for the issue on other yoga Laptops https://patchwork.kernel.org/project/alsa-devel/patch/20201205051130.8122-1… Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/83 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ALSA: hda: Add another CometLake-H PCI ID
by Kai Vehmanen 12 Feb '21

12 Feb '21

Add one more HD Audio PCI ID for CometLake-H PCH. Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/pci/hda/hda_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 801c5dd25707..7ba665e9272c 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2475,6 +2475,8 @@ static const struct pci_device_id azx_ids[] = { /* CometLake-H */ { PCI_DEVICE(0x8086, 0x06C8), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, + { PCI_DEVICE(0x8086, 0xf1c8), + .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, /* CometLake-S */ { PCI_DEVICE(0x8086, 0xa3f0), .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE}, base-commit: 03cc2c42871ecf90017cace94bfd1ca5ecaf6e48 -- 2.29.2

3 2

[PATCH] ASoC: SOF: relax ABI checks and avoid unnecessary warnings
by Kai Vehmanen 12 Feb '21

12 Feb '21

With recent SOF 1.7 pre-releases, kernel has been emitting following warnings at probe: [10006.645216] sof-audio-pci 0000:00:1f.3: warn: FW ABI is more recent than kernel [10006.652137] sof-audio-pci 0000:00:1f.3: warn: topology ABI is more recent than kernel The warnings are emitted due to increase of the patch-level in firmware mainline (to 3.17.1). But the patch level should not be considered even in the strict ABI check, so modify the kernel side logic that makes the check and only consider the major.minor components. BugLink: https://github.com/thesofproject/linux/issues/2647 Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- sound/soc/sof/ipc.c | 2 +- sound/soc/sof/topology.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sof/ipc.c b/sound/soc/sof/ipc.c index 1bc3d6282f16..c2d07b783f60 100644 --- a/sound/soc/sof/ipc.c +++ b/sound/soc/sof/ipc.c @@ -798,7 +798,7 @@ int snd_sof_ipc_valid(struct snd_sof_dev *sdev) return -EINVAL; } - if (v->abi_version > SOF_ABI_VERSION) { + if (SOF_ABI_VERSION_MINOR(v->abi_version) > SOF_ABI_MINOR) { if (!IS_ENABLED(CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS)) { dev_warn(sdev->dev, "warn: FW ABI is more recent than kernel\n"); } else { diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c index d6e1f33eb1e9..10f99620eb31 100644 --- a/sound/soc/sof/topology.c +++ b/sound/soc/sof/topology.c @@ -3658,7 +3658,7 @@ static int sof_manifest(struct snd_soc_component *scomp, int index, return -EINVAL; } - if (abi_version > SOF_ABI_VERSION) { + if (SOF_ABI_VERSION_MINOR(abi_version) > SOF_ABI_MINOR) { if (!IS_ENABLED(CONFIG_SND_SOC_SOF_STRICT_ABI_CHECKS)) { dev_warn(scomp->dev, "warn: topology ABI is more recent than kernel\n"); } else { base-commit: ec9d68508ff65df1dc24cf8100eb40ddd196c2fd -- 2.29.2

3 3

UCM profile for the Chromebook Yoga C630. Please add.
by GitHub issues - opened 12 Feb '21

12 Feb '21

alsa-project/alsa-ucm-conf issue #82 was opened from neil-vonholtum: SectionVerb { Value { OutputDspName "speaker_eq" FullySpecifiedUCM "1" } EnableSequence [ cdev "hw:kblda7219max" cset "name='codec1_out mo media0_in mi Switch' off" cset "name='codec0_out mo media0_in mi Switch' off" cset "name='Playback Digital Volume' 111" cset "name='Playback Digital Switch' 1" cset "name='Out DACL Mux' DAIL" cset "name='Out DACR Mux' DAIR" cset "name='Mixer Out FilterL DACL Switch' 1" cset "name='Mixer Out FilterR DACR Switch' 1" cset "name='ST Mixer Out FilterL Out FilterL Switch' 1" cset "name='ST Mixer Out FilterR Out FilterR Switch' 1" cset "name='Headphone Jack Switch' off" cset "name='Headset Mic Switch' off" cset "name='Mic Volume' 5" cset "name='Capture Digital Volume' 111" cset "name='Capture Digital Switch' 1" cset "name='Mixin Volume' 10" cset "name='Mixin Switch' 1" cset "name='Mixer In Mic Switch' 1" cset "name='Out DAIL Mux' ADC" cset "name='Out DAIR Mux' ADC" cset "name='media0_out mo codec0_in mi Switch' off" cset "name='media0_out mo dmic01_hifi_in mi Switch' off" cset "name='Pin5-Port0 Mux' 1" cset "name='Pin6-Port0 Mux' 2" cset "name='Pin7-Port0 Mux' 3" cset "name='Gain Ramp Rate' 1" ] DisableSequence [ ] } SectionDevice."Speaker".0 { Value { PlaybackPCM "hw:kblda7219max,0" } EnableSequence [ cdev "hw:kblda7219max" cset "name='codec0_out mo media0_in mi Switch' on" cset "name='Spk Switch' on" ] DisableSequence [ cdev "hw:kblda7219max" cset "name='codec0_out mo media0_in mi Switch' off" cset "name='Spk Switch' off" ] } SectionDevice."Headphone".0 { Value { PlaybackPCM "hw:kblda7219max,0" MixerName "Headphone" JackName "kblda7219max Headset Jack" JackType "gpio" JackSwitch "2" OutputDspName "" } EnableSequence [ cdev "hw:kblda7219max" cset "name='codec1_out mo media0_in mi Switch' on" cset "name='Headphone Jack Switch' on" cset "name='Headphone Switch' 1" ] DisableSequence [ cdev "hw:kblda7219max" cset "name='codec1_out mo media0_in mi Switch' off" cset "name='Headphone Jack Switch' off" cset "name='Headphone Switch' 0" ] } SectionDevice."Line Out".0 { Value { PlaybackPCM "hw:kblda7219max,0" MixerName "Headphone" JackName "kblda7219max Headset Jack" JackType "gpio" JackSwitch "6" OutputDspName "" } EnableSequence [ cdev "hw:kblda7219max" cset "name='codec1_out mo media0_in mi Switch' on" cset "name='Headphone Jack Switch' on" cset "name='Headphone Switch' 1" ] DisableSequence [ cdev "hw:kblda7219max" cset "name='codec1_out mo media0_in mi Switch' off" cset "name='Headphone Jack Switch' off" cset "name='Headphone Switch' 0" ] } SectionDevice."Internal Mic".0 { Value { CapturePCM "hw:kblda7219max,3" CaptureChannelMap "0 1 -1 -1 -1 -1 -1 -1 -1 -1 -1" MaxSoftwareGain "2000" } EnableSequence [ cdev "hw:kblda7219max" cset "name='media0_out mo dmic01_hifi_in mi Switch' on" ] DisableSequence [ cdev "hw:kblda7219max" cset "name='media0_out mo dmic01_hifi_in mi Switch' off" ] } SectionDevice."Mic".0 { Value { CapturePCM "hw:kblda7219max,1" MixerName "Headset Mic" JackName "kblda7219max Headset Jack" JackType "gpio" } EnableSequence [ cdev "hw:kblda7219max" cset "name='Headset Mic Switch' on" cset "name='media0_out mo codec0_in mi Switch' on" cset "name='Mic Switch' on" ] DisableSequence [ cdev "hw:kblda7219max" cset "name='Headset Mic Switch' off" cset "name='media0_out mo codec0_in mi Switch' off" cset "name='Mic Switch' off" ] } SectionDevice."HDMI1".0 { Value { PlaybackPCM "hw:kblda7219max,4" JackName "kblda7219max HDMI/DP, pcm=4 Jack" JackType "gpio" OutputDspName "" } EnableSequence [ ] DisableSequence [ ] } SectionDevice."HDMI2".0 { Value { PlaybackPCM "hw:kblda7219max,5" JackName "kblda7219max HDMI/DP, pcm=5 Jack" JackType "gpio" OutputDspName "" } EnableSequence [ ] DisableSequence [ ] } SectionDevice."HDMI3".0 { Value { PlaybackPCM "hw:kblda7219max,6" JackName "kblda7219max HDMI/DP, pcm=6 Jack" JackType "gpio" OutputDspName "" } EnableSequence [ ] DisableSequence [ ] } Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/82 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ucm2/conf.d: add symlinks for Qualcomm cards
by GitHub pull_request - opened 12 Feb '21

12 Feb '21

alsa-project/alsa-ucm-conf pull request #81 was opened from lumag: Add ucm2/conf.d symlinks for all defined Qualcomm sound cards. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/81 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/81.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH alsa-ucm-conf] codecs/rt5672: Remove Intel SST specific HeadsetMic workaround
by Hans de Goede 11 Feb '21

11 Feb '21

There used to be an issue with the HeadsetMic on BYT devices with a rt5672 codec only being recorded on the left channel, while the right channel recorded silence. The ucm2/codecs/rt5672/HeadsetMic.conf contains a workaround for this which changes the SST record-stream demuxer settings to use "slot 0" for both the left and right channels when recording from the HeadsetMic. There are 2 problems with this workaround: 1. It uses SST specific mixer settings causing things to break when using the SOF driver. 2. Files under uc2m/codecs should be architecture agnostic and should not depend on platform dependent mixer settings such as the SST driver mixer settings. The problem which the workaround used to work around has since been fixed in the kernel by switching the wire format from TDM/DSP A to I2S: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?… This fix has landed in 5.8 and has been backported to all recent stable kernel releases. Since this is fixed in the kernel now, we can drop the workaround, fixing the 2 problems mentioned above. This was tested on a ThinkPad 8 tablet, which is the same device as where the HeadsetMic problem was originally noticed. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- ucm2/codecs/rt5672/HeadsetMic.conf | 7 ------- 1 file changed, 7 deletions(-) diff --git a/ucm2/codecs/rt5672/HeadsetMic.conf b/ucm2/codecs/rt5672/HeadsetMic.conf index a764d82..fc061b0 100644 --- a/ucm2/codecs/rt5672/HeadsetMic.conf +++ b/ucm2/codecs/rt5672/HeadsetMic.conf @@ -12,11 +12,6 @@ SectionDevice."Headset" { cset "name='RECMIXR BST1 Switch' on" cset "name='Sto1 ADC MIXL ADC1 Switch' on" cset "name='Sto1 ADC MIXR ADC1 Switch' on" - # For unknown reasons the headset mic sound is only recorded - # on the left channel, we tweak the data-stream reception to - # use the left samples for both slots, so that we get a stereo - # stream with the mic sound on both channels - cset "name='codec_in rx deinterleaver codec_in0_1' 1" ] DisableSequence [ @@ -25,8 +20,6 @@ SectionDevice."Headset" { cset "name='RECMIXR BST1 Switch' off" cset "name='Sto1 ADC MIXL ADC1 Switch' off" cset "name='Sto1 ADC MIXR ADC1 Switch' off" - # Undo data-stream reception mono-mix workaround - cset "name='codec_in rx deinterleaver codec_in0_1' 2" ] Value { -- 2.30.0

2 1

[PATCH alsa-ucm-conf] bytcr-wm5102: Add new UCM profile for BYT boards with a WM5102 codec
by Hans de Goede 11 Feb '21

11 Feb '21

Add new UCM profile for BYT boards with a WM5102 codec. This has been tested with both the SST and the SOF driver on a Lenovo Yoga Tablet 2 1051L. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- ucm2/SOF/HiFi.conf | 9 +++++++++ ucm2/bytcr-wm5102/HiFi.conf | 27 +++++++++++++++++++++++++ ucm2/bytcr-wm5102/bytcr-wm5102.conf | 6 ++++++ ucm2/codecs/wm5102/EnableSeq.conf | 16 +++++++++++++++ ucm2/codecs/wm5102/HeadPhones.conf | 23 +++++++++++++++++++++ ucm2/codecs/wm5102/IN1-HeadsetMic.conf | 24 ++++++++++++++++++++++ ucm2/codecs/wm5102/IN3-InternalMic.conf | 23 +++++++++++++++++++++ ucm2/codecs/wm5102/Speaker.conf | 22 ++++++++++++++++++++ 8 files changed, 150 insertions(+) create mode 100644 ucm2/bytcr-wm5102/HiFi.conf create mode 100644 ucm2/bytcr-wm5102/bytcr-wm5102.conf create mode 100644 ucm2/codecs/wm5102/EnableSeq.conf create mode 100644 ucm2/codecs/wm5102/HeadPhones.conf create mode 100644 ucm2/codecs/wm5102/IN1-HeadsetMic.conf create mode 100644 ucm2/codecs/wm5102/IN3-InternalMic.conf create mode 100644 ucm2/codecs/wm5102/Speaker.conf diff --git a/ucm2/SOF/HiFi.conf b/ucm2/SOF/HiFi.conf index af0d8c9..adf8cc5 100644 --- a/ucm2/SOF/HiFi.conf +++ b/ucm2/SOF/HiFi.conf @@ -79,6 +79,15 @@ If.bytcht_max98090 { True.Include.main.File "/chtmax98090/HiFi.conf" } +If.bytcht_wm5102 { + Condition { + Type String + Haystack "${CardName}" + Needle "bytcht wm5102" + } + True.Include.main.File "/bytcr-wm5102/HiFi.conf" +} + If.bdw_rt286 { Condition { Type String diff --git a/ucm2/bytcr-wm5102/HiFi.conf b/ucm2/bytcr-wm5102/HiFi.conf new file mode 100644 index 0000000..1269868 --- /dev/null +++ b/ucm2/bytcr-wm5102/HiFi.conf @@ -0,0 +1,27 @@ +SectionVerb { + + Value { + TQ "HiFi" + } + + Include.e.File "/codecs/wm5102/EnableSeq.conf" + + If.Controls { + Condition { + Type ControlExists + Control "name='media0_in Gain 0 Switch'" + } + True { + Include.pe { + File "/platforms/bytcr/PlatformEnableSeq.conf" + Before.EnableSequence "0" + } + Include.pd.File "/platforms/bytcr/PlatformDisableSeq.conf" + } + } +} + +Include.spk.File "/codecs/wm5102/Speaker.conf" +Include.hp.File "/codecs/wm5102/HeadPhones.conf" +Include.mic.File "/codecs/wm5102/IN3-InternalMic.conf" +Include.headset.File "/codecs/wm5102/IN1-HeadsetMic.conf" diff --git a/ucm2/bytcr-wm5102/bytcr-wm5102.conf b/ucm2/bytcr-wm5102/bytcr-wm5102.conf new file mode 100644 index 0000000..af966ef --- /dev/null +++ b/ucm2/bytcr-wm5102/bytcr-wm5102.conf @@ -0,0 +1,6 @@ +Syntax 3 + +SectionUseCase."HiFi" { + File "HiFi.conf" + Comment "Play HiFi quality Music" +} diff --git a/ucm2/codecs/wm5102/EnableSeq.conf b/ucm2/codecs/wm5102/EnableSeq.conf new file mode 100644 index 0000000..6a857a2 --- /dev/null +++ b/ucm2/codecs/wm5102/EnableSeq.conf @@ -0,0 +1,16 @@ +EnableSequence [ + # Route AIF1 to the speakers and headphones + cset "name='SPKOUTL Input 1' AIF1RX1" + cset "name='SPKOUTR Input 1' AIF1RX2" + cset "name='HPOUT1L Input 1' AIF1RX1" + cset "name='HPOUT1R Input 1' AIF1RX2" + + # Both mics are quite soft by default, boost then + cset "name='IN1L Volume' 28" + cset "name='IN3L Volume' 28" + + cset "name='Headphone Switch' off" + cset "name='Headset Mic Switch' off" + cset "name='Internal Mic Switch' off" + cset "name='Speaker Switch' off" +] diff --git a/ucm2/codecs/wm5102/HeadPhones.conf b/ucm2/codecs/wm5102/HeadPhones.conf new file mode 100644 index 0000000..cb29347 --- /dev/null +++ b/ucm2/codecs/wm5102/HeadPhones.conf @@ -0,0 +1,23 @@ +SectionDevice."Headphones" { + Comment "Headphones" + + Value { + PlaybackPriority 200 + PlaybackPCM "hw:${CardId}" + JackControl "Headphone Jack" + } + + ConflictingDevice [ + "Speaker" + ] + + EnableSequence [ + cset "name='HPOUT1 Digital Switch' on" + cset "name='Headphone Switch' on" + ] + + DisableSequence [ + cset "name='HPOUT1 Digital Switch' off" + cset "name='Headphone Switch' off" + ] +} diff --git a/ucm2/codecs/wm5102/IN1-HeadsetMic.conf b/ucm2/codecs/wm5102/IN1-HeadsetMic.conf new file mode 100644 index 0000000..a607487 --- /dev/null +++ b/ucm2/codecs/wm5102/IN1-HeadsetMic.conf @@ -0,0 +1,24 @@ +SectionDevice."Headset" { + Comment "Headset Microphone" + + ConflictingDevice [ + "Mic" + ] + + EnableSequence [ + cset "name='AIF1TX1 Input 1' IN1L" + cset "name='AIF1TX2 Input 1' IN1L" + + cset "name='Headset Mic Switch' on" + ] + + DisableSequence [ + cset "name='Headset Mic Switch' off" + ] + + Value { + CapturePriority 200 + CapturePCM "hw:${CardId}" + JackControl "Headset Mic Jack" + } +} diff --git a/ucm2/codecs/wm5102/IN3-InternalMic.conf b/ucm2/codecs/wm5102/IN3-InternalMic.conf new file mode 100644 index 0000000..3a03ac3 --- /dev/null +++ b/ucm2/codecs/wm5102/IN3-InternalMic.conf @@ -0,0 +1,23 @@ +SectionDevice."Mic" { + Comment "Internal Microphone" + + ConflictingDevice [ + "Headset" + ] + + EnableSequence [ + cset "name='AIF1TX1 Input 1' IN3L" + cset "name='AIF1TX2 Input 1' IN3L" + + cset "name='Internal Mic Switch' on" + ] + + DisableSequence [ + cset "name='Internal Mic Switch' off" + ] + + Value { + CapturePriority 100 + CapturePCM "hw:${CardId}" + } +} diff --git a/ucm2/codecs/wm5102/Speaker.conf b/ucm2/codecs/wm5102/Speaker.conf new file mode 100644 index 0000000..9f631f5 --- /dev/null +++ b/ucm2/codecs/wm5102/Speaker.conf @@ -0,0 +1,22 @@ +SectionDevice."Speaker" { + Comment "Speakers" + + Value { + PlaybackPriority 100 + PlaybackPCM "hw:${CardId}" + } + + ConflictingDevice [ + "Headphones" + ] + + EnableSequence [ + cset "name='Speaker Digital Switch' on" + cset "name='Speaker Switch' on" + ] + + DisableSequence [ + cset "name='Speaker Digital Switch' off" + cset "name='Speaker Switch' off" + ] +} -- 2.30.0

2 3

[PATCH] ASoC: wm_adsp: Remove unused control callback structure
by Charles Keepax 11 Feb '21

11 Feb '21

This callback structure has never been used and it is not clear why it was added in the first place. Remove it to clear up the code a little. Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- sound/soc/codecs/wm_adsp.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 262c2db4f81ce..070ca7d8c6610 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -595,13 +595,6 @@ static const struct { [WM_ADSP_FW_MISC] = { .file = "misc" }, }; -struct wm_coeff_ctl_ops { - int (*xget)(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol); - int (*xput)(struct snd_kcontrol *kcontrol, - struct snd_ctl_elem_value *ucontrol); -}; - struct wm_coeff_ctl { const char *name; const char *fw_name; @@ -609,7 +602,6 @@ struct wm_coeff_ctl { const char *subname; unsigned int subname_len; struct wm_adsp_alg_region alg_region; - struct wm_coeff_ctl_ops ops; struct wm_adsp *dsp; unsigned int enabled:1; struct list_head list; @@ -1497,8 +1489,6 @@ static int wm_adsp_create_control(struct wm_adsp *dsp, } ctl->enabled = 1; ctl->set = 0; - ctl->ops.xget = wm_coeff_get; - ctl->ops.xput = wm_coeff_put; ctl->dsp = dsp; ctl->flags = flags; -- 2.11.0

2 1

[PATCH v5 0/7] ASoC: codecs: add support for LPASS Codec TX and RX macros
by Srinivas Kandagatla 11 Feb '21

11 Feb '21

This patchset adds support for two Codec Macro blocks(TX and RX) available in Qualcomm LPASS (Low Power Audio SubSystem). There are WSA, VA, TX and RX Macros on LPASS IP, each of the Macro block has specific connectivity like WSA Macros are intended to connect to WSA Smart speaker codecs via SoundWire. VA Macro is intended for DMICs, and TX/RX for Analog codecs via SoundWire like other WCD938x Codecs to provide headphone/ear/lineout/amic/dmic etc .. Most of the work is derived from downstream Qualcomm kernels. Credits to various Qualcomm authors from Patrick Lai's team who have contributed to this code. This patchset has been tested on support to SM8250 MTP Development Board. This board has 2 WSA881X smart speakers with onboard DMIC connected to internal LPASS codec via WSA and VA macros respectively and WCD938x TX and RX connected via Soundwire via TX and RX Macros reseptively. Thanks, srini Changes since v4: - One more ktest fix for unused-but-set-variable warning and a fix for W=2 warning and removed unused macros - added bindings ack from Rob Srinivas Kandagatla (7): ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec ASoC: codecs: lpass-rx-macro: add support for lpass rx macro ASoC: codecs: lpass-rx-macro: add dapm widgets and route ASoC: codecs: lpass-rx-macro: add iir widgets ASoC: qcom: dt-bindings: add bindings for lpass tx macro codec ASoC: codecs: lpass-tx-macro: add support for lpass tx macro ASoC: codecs: lpass-tx-macro: add dapm widgets and route .../bindings/sound/qcom,lpass-rx-macro.yaml | 62 + .../bindings/sound/qcom,lpass-tx-macro.yaml | 67 + sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 4 + sound/soc/codecs/lpass-rx-macro.c | 3599 +++++++++++++++++ sound/soc/codecs/lpass-tx-macro.c | 1862 +++++++++ 6 files changed, 5604 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml create mode 100644 sound/soc/codecs/lpass-rx-macro.c create mode 100644 sound/soc/codecs/lpass-tx-macro.c -- 2.21.0

2 8