December 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] sound:soc:remove unneeded variable
by cgel.zte＠gmail.com 24 Dec '21

24 Dec '21

From: chiminghao <chi.minghao(a)zte.com.cn> return value form directly instead of taking this in another redundant variable. Reported-by: Zeal Robot <zealci(a)zte.com.cm> Signed-off-by: chiminghao <chi.minghao(a)zte.com.cn> --- sound/soc/codecs/mt6660.c | 5 ++--- sound/soc/codecs/wcd938x.c | 6 ++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/mt6660.c b/sound/soc/codecs/mt6660.c index 358c500377df..3a881523c30f 100644 --- a/sound/soc/codecs/mt6660.c +++ b/sound/soc/codecs/mt6660.c @@ -47,13 +47,12 @@ static int mt6660_reg_write(void *context, unsigned int reg, unsigned int val) struct mt6660_chip *chip = context; int size = mt6660_get_reg_size(reg); u8 reg_data[4]; - int i, ret; + int i; for (i = 0; i < size; i++) reg_data[size - i - 1] = (val >> (8 * i)) & 0xff; - ret = i2c_smbus_write_i2c_block_data(chip->i2c, reg, size, reg_data); - return ret; + return i2c_smbus_write_i2c_block_data(chip->i2c, reg, size, reg_data); } static int mt6660_reg_read(void *context, unsigned int reg, unsigned int *val) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 52de7d14b139..0033d61d42e8 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -3083,7 +3083,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon int micb_num, bool req_en) { struct wcd938x_priv *wcd938x = snd_soc_component_get_drvdata(component); - int rc, micb_mv; + int micb_mv; if (micb_num != MIC_BIAS_2) return -EINVAL; @@ -3097,9 +3097,7 @@ static int wcd938x_mbhc_micb_ctrl_threshold_mic(struct snd_soc_component *compon micb_mv = req_en ? WCD_MBHC_THR_HS_MICB_MV : wcd938x->micb2_mv; - rc = wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); - - return rc; + return wcd938x_mbhc_micb_adjust_voltage(component, micb_mv, MIC_BIAS_2); } static inline void wcd938x_mbhc_get_result_params(struct wcd938x_priv *wcd938x, -- 2.25.1

2 2

"alsatplg -v 1 -o -" silently corrupts output
by GitHub issues - opened 24 Dec '21

24 Dec '21

alsa-project/alsa-utils issue #131 was opened from marc-hb: `alsatplg -v 1` works. `alsatplg -o -` works too. Using both produces silently a binary .tplg file prefixed with debug logs: ``` B0x003d3b/015675 - pcm 'DMIC': write 912 bytes B0x0040cb/016587 - pcm 'HDMI1': write 912 bytes B0x00445b/017499 - pcm 'HDMI2': write 912 bytes B0x0047eb/018411 - pcm 'HDMI3': write 912 bytes B0x004b7b/019323 - pcm 'DMIC16kHz': write 912 bytes B0x004f0b/020235 - block size for type be (11:10) is 0x2ad4/10964 B0x004f0b/020235 - header index 0CoSA^E^@^@^@^@^@^@^@^H^@^@^@$^@^@ ^@^@^@^@^@s^@^@^@^@^@^@^@^A^@^@^@p^@^@^@ ^@^@^@.^@^@^@ ^@^@^@^F^@^ @^@^F^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^ @^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^ @^@^@^@^@^@^@^@^@^... ``` I would have expected alsatplg -v to use stderr, this would have avoided this problem. Probably too late by now. I suggest simply failing with an error message when both options are used at the same time. Any other solution that does not silently produces corrupted output would be a huge improvement. Context: thesofproject/sof/pull/5132 Issue URL : https://github.com/alsa-project/alsa-utils/issues/131 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[RFC PATCH] ASoC: mediatek: mt8192-mt6359: fix device_node leak
by Tzung-Bi Shih 24 Dec '21

24 Dec '21

The of_parse_phandle() document: >>> Use of_node_put() on it when done. The driver didn't call of_node_put(). Fixes the leak. Signed-off-by: Tzung-Bi Shih <tzungbi(a)google.com> --- Hi maintainers, Need your comments. The patch is one of the partial fixes that I think it makes the most sense. Option 1. Machine driver makes sure the object is valid until registered This patch adopts the option. It needs snd_soc_register_card() to call of_node_get() somewhere to hold the reference count of of_node. However, I failed to find similar logic in soc-core.c. Option 2. Machine driver borrows the reference count This is what [1] adopts. Decreasing the reference count in device's remove() to make sure the object is valid for whole sound card's lifecycle. [1]: https://elixir.bootlin.com/linux/v5.16-rc5/source/sound/soc/mediatek/mt8195… In fact, in my test environment, CONFIG_OF_DYNAMIC is not set. The implementation is empty[2]. Per [3]: >>> Hardly any platforms need this [2]: https://elixir.bootlin.com/linux/v5.16-rc5/source/include/linux/of.h#L125 [3]: https://elixir.bootlin.com/linux/v5.16-rc5/source/drivers/of/Kconfig#L55 I am not sure if it is worthy to find somewhere to hold the reference count in soc-core.c but I think option 1 makes it more clear to drivers. sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c index a606133951b7..24a5d0adec1b 100644 --- a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c +++ b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c @@ -1172,7 +1172,11 @@ static int mt8192_mt6359_dev_probe(struct platform_device *pdev) return ret; } - return devm_snd_soc_register_card(&pdev->dev, card); + ret = devm_snd_soc_register_card(&pdev->dev, card); + + of_node_put(platform_node); + of_node_put(hdmi_codec); + return ret; } #ifdef CONFIG_OF -- 2.34.1.173.g76aa8bc2d0-goog

2 2

[PATCH 0/4] ASoC: qcom: Parse "pin-switches" and "widgets" from DT
by Stephan Gerhold 23 Dec '21

23 Dec '21

Some sound card setups might require extra pin switches to allow turning off certain audio components. simple-card supports this already using the "pin-switches" and "widgets" device tree property. This series makes it possible to use the same properties for the Qcom sound cards. To implement that, the function that parses the "pin-switches" property in simple-card-utils.c is first moved into the ASoC core. Then two simple function calls are added to the common Qcom sound card DT parser. Finally there is a small patch for the msm8916-wcd-analog codec to make it possible to model sound card setups used in some MSM8916 smartphones. (See PATCH 2/4 for an explanation of some real example use cases.) Using pin switches rather than patching codec drivers with switches was originally suggested by Mark Brown on a patch for the tfa989x codec: https://lore.kernel.org/alsa-devel/YXaMVHo9drCIuD3u@sirena.org.uk/ Stephan Gerhold (4): ASoC: core: Add snd_soc_of_parse_pin_switches() from simple-card-utils ASoC: dt-bindings: qcom: sm8250: Document "pin-switches" and "widgets" ASoC: qcom: common: Parse "pin-switches" and "widgets" from DT ASoC: msm8916-wcd-analog: Use separate outputs for HPH_L/HPH_R .../bindings/sound/qcom,sm8250.yaml | 16 ++++++ include/sound/soc.h | 1 + sound/soc/codecs/msm8916-wcd-analog.c | 7 +-- sound/soc/generic/simple-card-utils.c | 45 +---------------- sound/soc/qcom/common.c | 10 ++++ sound/soc/soc-core.c | 50 +++++++++++++++++++ 6 files changed, 82 insertions(+), 47 deletions(-) -- 2.34.1

3 6

[PATCH 00/20] ASoC: SOF: Re-visit firmware state and panic tracking/handling
by Peter Ujfalusi 23 Dec '21

23 Dec '21

Hi, this series will improve how we are tracking the firmware's state to be able to avoid communication with it when it is not going to answer due to a panic and we will attempt to force power cycle the DSP to recover at the next runtime suspend time. The state handling brings in other improvements on the way the kernel reports errors and DSP panics to reduce the printed lines for normal users, but at the same time allowing developers (or for bug reports) to have more precise information available to track down the issue. We can now place messages easily in the correct debug level and not bound to the static ERROR for some of the print chains, causing excess amount or partial information to be printed, confusing users and machines (CI). I would have prefered to split this series up, but it was developed together to achieve a single goal to reduce the noise, but also provide the details we need to be able to rootcause issues. Regards, Peter --- Peter Ujfalusi (20): ASoC: SOF: ops: Use dev_warn() if the panic offsets differ ASoC: SOF: Intel: hda-loader: Avoid re-defining the HDA_FW_BOOT_ATTEMPTS ASoC: SOF: core: Add simple wrapper to check flags in sof_core_debug ASoC: SOF: Use sof_debug_check_flag() instead of sof_core_debug directly ASoC: SOF: Add 'non_recoverable' parameter to snd_sof_dsp_panic() ASoC: SOF: Add a 'message' parameter to snd_sof_dsp_dbg_dump() ASoC: SOF: Introduce new firmware state: SOF_FW_CRASHED ASoC: SOF: Introduce new firmware state: SOF_FW_BOOT_READY_OK ASoC: SOF: Move the definition of enum snd_sof_fw_state to global header ASoC: SOF: Rename 'enum snd_sof_fw_state' to 'enum sof_fw_state' ASoC: SOF: ipc: Only allow sending of an IPC in SOF_FW_BOOT_COMPLETE state ASoC: SOF: Set SOF_FW_BOOT_FAILED in case we have failure during boot ASoC: SOF: pm: Force DSP off on suspend in BOOT_FAILED state also ASoc: SOF: core: Update the FW boot state transition diagram ASoC: SOF: ops: Always print DSP Panic message but use different message ASoC: SOF: dsp_arch_ops: add kernel log level parameter for oops and stack ASoC: SOF: Rename snd_sof_get_status() and add kernel log level parameter ASoC: SOF: Add clarifying comments for sof_core_debug and DSP dump flags ASoC: SOF: debug: Use DEBUG log level for optional prints ASoC: SOF: Intel: hda: Use DEBUG log level for optional prints include/sound/sof.h | 22 ++++++ sound/soc/sof/core.c | 119 +++++++++++++++++++------------ sound/soc/sof/debug.c | 35 +++++---- sound/soc/sof/imx/imx-common.c | 4 +- sound/soc/sof/imx/imx8.c | 2 +- sound/soc/sof/imx/imx8m.c | 2 +- sound/soc/sof/intel/atom.c | 8 +-- sound/soc/sof/intel/bdw.c | 8 +-- sound/soc/sof/intel/cnl.c | 21 +++++- sound/soc/sof/intel/hda-ipc.c | 19 ++++- sound/soc/sof/intel/hda-loader.c | 24 ++++--- sound/soc/sof/intel/hda.c | 20 +++--- sound/soc/sof/intel/hda.h | 2 +- sound/soc/sof/ipc.c | 4 +- sound/soc/sof/loader.c | 16 ++--- sound/soc/sof/ops.c | 47 ++++++++---- sound/soc/sof/ops.h | 4 +- sound/soc/sof/pm.c | 10 +++ sound/soc/sof/sof-priv.h | 44 +++++------- sound/soc/sof/topology.c | 12 ++-- sound/soc/sof/xtensa/core.c | 44 +++++++----- 21 files changed, 299 insertions(+), 168 deletions(-) -- 2.34.1

2 21

[PATCH -next] ASoC: codec: tlv320adc3xxx: Fix missing clk_disable_unprepare() on error in adc3xxx_i2c_probe()
by Yang Yingliang 23 Dec '21

23 Dec '21

Fix the missing clk_disable_unprepare() before return from adc3xxx_i2c_probe() in the error handling case. Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver") Reported-by: Hulk Robot <hulkci(a)huawei.com> Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/codecs/tlv320adc3xxx.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/tlv320adc3xxx.c b/sound/soc/codecs/tlv320adc3xxx.c index a683bda7eb36..4baf3d881633 100644 --- a/sound/soc/codecs/tlv320adc3xxx.c +++ b/sound/soc/codecs/tlv320adc3xxx.c @@ -1232,21 +1232,21 @@ static int adc3xxx_i2c_probe(struct i2c_client *i2c, ret = adc3xxx_parse_dt_gpio(adc3xxx, "ti,dmdin-gpio1", &adc3xxx->gpio_cfg[0]); if (ret < 0) - return ret; + goto err_unprepare_mclk; ret = adc3xxx_parse_dt_gpio(adc3xxx, "ti,dmclk-gpio2", &adc3xxx->gpio_cfg[1]); if (ret < 0) - return ret; + goto err_unprepare_mclk; ret = adc3xxx_parse_dt_micbias(adc3xxx, "ti,micbias1-vg", &adc3xxx->micbias_vg[0]); if (ret < 0) - return ret; + goto err_unprepare_mclk; ret = adc3xxx_parse_dt_micbias(adc3xxx, "ti,micbias2-vg", &adc3xxx->micbias_vg[1]); if (ret < 0) - return ret; + goto err_unprepare_mclk; adc3xxx->regmap = devm_regmap_init_i2c(i2c, &adc3xxx_regmap); if (IS_ERR(adc3xxx->regmap)) { ret = PTR_ERR(adc3xxx->regmap); - return ret; + goto err_unprepare_mclk; } i2c_set_clientdata(i2c, adc3xxx); @@ -1263,9 +1263,15 @@ static int adc3xxx_i2c_probe(struct i2c_client *i2c, ret = snd_soc_register_component(dev, &soc_component_dev_adc3xxx, &adc3xxx_dai, 1); - if (ret < 0) + if (ret < 0) { dev_err(dev, "Failed to register codec: %d\n", ret); + goto err_unprepare_mclk; + } + + return 0; +err_unprepare_mclk: + clk_disable_unprepare(adc3xxx->mclk); return ret; } -- 2.25.1

2 1

[PATCH 0/5] ASoC: Intel: machine driver updates for 5.16
by Pierre-Louis Bossart 23 Dec '21

23 Dec '21

One quirk for a Dell TigerLake/SoundWire device, and initial support for platforms based on the ES8336 codec (aka ES8316). For full functionality, an update of the codec driver will be needed. Pierre-Louis Bossart (5): ASoC: Intel: soc-acpi: apl/glk/tgl: add entry for devices based on ES8336 codec ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336 codec ASoC: Intel: add machine driver for SOF+ES8336 ASoC: Intel: soc-acpi: add missing quirk for TGL SDCA single amp ASoC: Intel: sof_sdw: add missing quirk for Dell SKU 0A45 sound/hda/intel-dsp-config.c | 22 +- sound/soc/intel/boards/Kconfig | 14 + sound/soc/intel/boards/Makefile | 2 + sound/soc/intel/boards/sof_es8336.c | 569 ++++++++++++++++++ sound/soc/intel/boards/sof_sdw.c | 10 + .../intel/common/soc-acpi-intel-bxt-match.c | 6 + .../intel/common/soc-acpi-intel-glk-match.c | 7 +- .../intel/common/soc-acpi-intel-tgl-match.c | 47 ++ 8 files changed, 674 insertions(+), 3 deletions(-) create mode 100644 sound/soc/intel/boards/sof_es8336.c -- 2.25.1

3 10

[PATCH v3 0/3] Fix Tegra194 HDA regression
by Sameer Pujar 23 Dec '21

23 Dec '21

HDA probe failure is observed on Tegra194 based platforms and this happens due to reset failure. This series fixes the problem by skipping the failing reset and DT bindings are updated accordingly. Changelog ========= v2 -> v3: --------- * Use reset bulk APIs in HDA driver as suggested by Dmitry. v1 -> v2: --------- * Updated HDA driver patch to skip the failing reset instead of skipping resets in general for BPMP devices as per comment from Dmitry. * Used a better strucure name for SoC data as per comment from Thierry. * Dropped 'Fixes' tag in binding doc patch as per comment from Dmitry. Sameer Pujar (3): ALSA: hda/tegra: Fix Tegra194 HDA reset failure dt-bindings: sound: tegra: Update HDA resets arm64: tegra: Remove non existent Tegra194 reset .../bindings/sound/nvidia,tegra30-hda.yaml | 13 +++++-- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 +-- sound/pci/hda/hda_tegra.c | 45 +++++++++++++++++----- 3 files changed, 47 insertions(+), 16 deletions(-) -- 2.7.4

4 8

[GIT PULL] ASoC fixes for v5.16-rc6
by Mark Brown 22 Dec '21

22 Dec '21

The following changes since commit 3fc27e9a1f619b50700f020e6cd270c1b74755f0: ASoC: codecs: wsa881x: fix return values from kcontrol put (2021-12-01 14:13:53 +0000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.16-rc6 for you to fetch changes up to ee907afb0c39a41ee74b862882cfe12820c74b98: ASoC: meson: aiu: Move AIU_I2S_MISC hold setting to aiu-fifo-i2s (2021-12-14 17:15:32 +0000) ---------------------------------------------------------------- ASoC: Fixes for v5.16 This is a relatively large set of driver specific changes so it may make sense to hold off to v5.17, though picking some over might be good. It's a combination of new device IDs and fixes for various driver specific things which are all small and of the usual "really bad if you're running into them" level, especially the Tegra ones. ---------------------------------------------------------------- Derek Fang (1): ASoC: rt5682: fix the wrong jack type detected Dmitry Osipenko (2): ASoC: tegra: Add DAPM switches for headphones and mic jack ASoC: tegra: Restore headphones jack name on Nyan Big Kai Vehmanen (2): ASoC: SOF: Intel: pci-tgl: add ADL-N support ASoC: SOF: Intel: pci-tgl: add new ADL-P variant Martin Blumenstingl (2): ASoC: meson: aiu: fifo: Add missing dma_coerce_mask_and_coherent() ASoC: meson: aiu: Move AIU_I2S_MISC hold setting to aiu-fifo-i2s Martin Povišer (1): ASoC: tas2770: Fix setting of high sample rates sound/soc/codecs/rt5682.c | 4 ++++ sound/soc/codecs/tas2770.c | 4 ++-- sound/soc/meson/aiu-encoder-i2s.c | 33 --------------------------------- sound/soc/meson/aiu-fifo-i2s.c | 19 +++++++++++++++++++ sound/soc/meson/aiu-fifo.c | 6 ++++++ sound/soc/sof/intel/pci-tgl.c | 4 ++++ sound/soc/tegra/tegra_asoc_machine.c | 11 ++++++++++- sound/soc/tegra/tegra_asoc_machine.h | 1 + 8 files changed, 46 insertions(+), 36 deletions(-)

2 1

[PATCH 0/2] ALSA: hda: intel-sdw-acpi: fix controller detection
by Pierre-Louis Bossart 22 Dec '21

22 Dec '21

The SoundWire-related information provided by platform firmware (DSDT) hasn't changed since 2016, but with a recent change of device hierarchy we need to change how the controller is detected. These patches were tested on existing devices and don't break anything, but are very much needed for newer devices (quirks already in Linus' branch for 5.16, see e.g. commit f55af7055cd4 ("ASoC: Intel: sof_sdw: Add support for SKU 0B12 product"). Unfortunately the BIOS changes happened *after* the initial patches were contributed. Libin Yang (2): ALSA: hda: intel-sdw-acpi: harden detection of controller ALSA: hda: intel-sdw-acpi: go through HDAS ACPI at max depth of 2 sound/hda/intel-sdw-acpi.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- 2.25.1

2 3