December 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH AUTOSEL 5.15 24/26] ALSA: hda: intel-sdw-acpi: harden detection of controller
by Sasha Levin 27 Dec '21

27 Dec '21

From: Libin Yang <libin.yang(a)intel.com> [ Upstream commit 385f287f9853da402d94278e59f594501c1d1dad ] The existing code currently sets a pointer to an ACPI handle before checking that it's actually a SoundWire controller. This can lead to issues where the graph walk continues and eventually fails, but the pointer was set already. This patch changes the logic so that the information provided to the caller is set when a controller is found. Reviewed-by: Péter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Signed-off-by: Libin Yang <libin.yang(a)intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> Link: https://lore.kernel.org/r/20211221010817.23636-2-yung-chuan.liao@linux.inte… Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/hda/intel-sdw-acpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/hda/intel-sdw-acpi.c b/sound/hda/intel-sdw-acpi.c index c0123bc31c0dd..ba8a872a29010 100644 --- a/sound/hda/intel-sdw-acpi.c +++ b/sound/hda/intel-sdw-acpi.c @@ -132,8 +132,6 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level, return AE_NOT_FOUND; } - info->handle = handle; - /* * On some Intel platforms, multiple children of the HDAS * device can be found, but only one of them is the SoundWire @@ -144,6 +142,9 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level, if (FIELD_GET(GENMASK(31, 28), adr) != SDW_LINK_TYPE) return AE_OK; /* keep going */ + /* found the correct SoundWire controller */ + info->handle = handle; + /* device found, stop namespace walk */ return AE_CTRL_TERMINATE; } -- 2.34.1

1 0

[PATCH AUTOSEL 5.15 10/26] ASoC: tas2770: Fix setting of high sample rates
by Sasha Levin 27 Dec '21

27 Dec '21

From: Martin Povišer <povik(a)protonmail.com> [ Upstream commit 80d5be1a057e05f01d66e986cfd34d71845e5190 ] Although the codec advertises support for 176.4 and 192 ksps, without this fix setting those sample rates fails with EINVAL at hw_params time. Signed-off-by: Martin Povišer <povik(a)protonmail.com> Link: https://lore.kernel.org/r/20211206224529.74656-1-povik@protonmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/tas2770.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index 172e79cbe0daf..6549e7fef3e32 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -291,11 +291,11 @@ static int tas2770_set_samplerate(struct tas2770_priv *tas2770, int samplerate) ramp_rate_val = TAS2770_TDM_CFG_REG0_SMP_44_1KHZ | TAS2770_TDM_CFG_REG0_31_88_2_96KHZ; break; - case 19200: + case 192000: ramp_rate_val = TAS2770_TDM_CFG_REG0_SMP_48KHZ | TAS2770_TDM_CFG_REG0_31_176_4_192KHZ; break; - case 17640: + case 176400: ramp_rate_val = TAS2770_TDM_CFG_REG0_SMP_44_1KHZ | TAS2770_TDM_CFG_REG0_31_176_4_192KHZ; break; -- 2.34.1

1 0

[PATCH AUTOSEL 5.15 09/26] ASoC: rt5682: fix the wrong jack type detected
by Sasha Levin 27 Dec '21

27 Dec '21

From: Derek Fang <derek.fang(a)realtek.com> [ Upstream commit 8deb34a90f06374fd26f722c2a79e15160f66be7 ] Some powers were changed during the jack insert detection and clk's enable/disable in CCF. If in parallel, the influence has a chance to detect the wrong jack type, so add a lock. Signed-off-by: Derek Fang <derek.fang(a)realtek.com> Link: https://lore.kernel.org/r/20211214105033.471-1-derek.fang@realtek.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/rt5682.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 5ac2b1444694d..757d1362b5f48 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -927,6 +927,8 @@ int rt5682_headset_detect(struct snd_soc_component *component, int jack_insert) unsigned int val, count; if (jack_insert) { + snd_soc_dapm_mutex_lock(dapm); + snd_soc_component_update_bits(component, RT5682_PWR_ANLG_1, RT5682_PWR_VREF2 | RT5682_PWR_MB, RT5682_PWR_VREF2 | RT5682_PWR_MB); @@ -973,6 +975,8 @@ int rt5682_headset_detect(struct snd_soc_component *component, int jack_insert) snd_soc_component_update_bits(component, RT5682_MICBIAS_2, RT5682_PWR_CLK25M_MASK | RT5682_PWR_CLK1M_MASK, RT5682_PWR_CLK25M_PU | RT5682_PWR_CLK1M_PU); + + snd_soc_dapm_mutex_unlock(dapm); } else { rt5682_enable_push_button_irq(component, false); snd_soc_component_update_bits(component, RT5682_CBJ_CTRL_1, -- 2.34.1

1 0

[PATCH AUTOSEL 5.15 05/26] ASoC: SOF: Intel: pci-tgl: add new ADL-P variant
by Sasha Levin 27 Dec '21

27 Dec '21

From: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> [ Upstream commit de7dd9092cd38384f774d345cccafe81b4b866b0 ] Add a PCI DID for a variant of Intel AlderLake-P. Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20211203171542.1021399-2-kai.vehmanen@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/pci-tgl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sof/intel/pci-tgl.c b/sound/soc/sof/intel/pci-tgl.c index 665add8a3029b..beb2fb3cd0141 100644 --- a/sound/soc/sof/intel/pci-tgl.c +++ b/sound/soc/sof/intel/pci-tgl.c @@ -117,6 +117,8 @@ static const struct pci_device_id sof_pci_ids[] = { .driver_data = (unsigned long)&adls_desc}, { PCI_DEVICE(0x8086, 0x51c8), /* ADL-P */ .driver_data = (unsigned long)&adl_desc}, + { PCI_DEVICE(0x8086, 0x51cd), /* ADL-P */ + .driver_data = (unsigned long)&adl_desc}, { PCI_DEVICE(0x8086, 0x51cc), /* ADL-M */ .driver_data = (unsigned long)&adl_desc}, { PCI_DEVICE(0x8086, 0x54c8), /* ADL-N */ -- 2.34.1

1 0

[PATCH AUTOSEL 5.15 04/26] ASoC: SOF: Intel: pci-tgl: add ADL-N support
by Sasha Levin 27 Dec '21

27 Dec '21

From: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> [ Upstream commit cd57eb3c403cb864e5558874ecd57dd954a5a7f7 ] Add PCI DID for Intel AlderLake-N. Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20211203171542.1021399-1-kai.vehmanen@linux.intel… Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/sof/intel/pci-tgl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sof/intel/pci-tgl.c b/sound/soc/sof/intel/pci-tgl.c index d04ce84fe7cc2..665add8a3029b 100644 --- a/sound/soc/sof/intel/pci-tgl.c +++ b/sound/soc/sof/intel/pci-tgl.c @@ -119,6 +119,8 @@ static const struct pci_device_id sof_pci_ids[] = { .driver_data = (unsigned long)&adl_desc}, { PCI_DEVICE(0x8086, 0x51cc), /* ADL-M */ .driver_data = (unsigned long)&adl_desc}, + { PCI_DEVICE(0x8086, 0x54c8), /* ADL-N */ + .driver_data = (unsigned long)&adl_desc}, { 0, } }; MODULE_DEVICE_TABLE(pci, sof_pci_ids); -- 2.34.1

1 0

[RFC 09/32] sound: Kconfig: add HAS_IOPORT dependencies
by Niklas Schnelle 27 Dec '21

27 Dec '21

In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann <arnd(a)kernel.org> Signed-off-by: Arnd Bergmann <arnd(a)kernel.org> Signed-off-by: Niklas Schnelle <schnelle(a)linux.ibm.com> --- sound/drivers/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig index ca4cdf666f82..4b5ba916d93e 100644 --- a/sound/drivers/Kconfig +++ b/sound/drivers/Kconfig @@ -128,6 +128,7 @@ config SND_VIRMIDI config SND_MTPAV tristate "MOTU MidiTimePiece AV multiport MIDI" + depends on HAS_IOPORT select SND_RAWMIDI help To use a MOTU MidiTimePiece AV multiport MIDI adapter @@ -152,6 +153,7 @@ config SND_MTS64 config SND_SERIAL_U16550 tristate "UART16550 serial MIDI driver" + depends on HAS_IOPORT select SND_RAWMIDI help To include support for MIDI serial port interfaces, say Y here @@ -167,6 +169,7 @@ config SND_SERIAL_U16550 config SND_MPU401 tristate "Generic MPU-401 UART driver" + depends on HAS_IOPORT select SND_MPU401_UART help Say Y here to include support for MIDI ports compatible with -- 2.32.0

1 0

a52: frozen pavumeter
by GitHub issues - edited 27 Dec '21

27 Dec '21

alsa-project/alsa-plugins issue #42 was edited from quequotion: I had been [thinking that pavumeter was just broken](https://github.com/nekohayo/pavumeter/issues/1), because this has been happening to me for a long time (well before the changes between 1.2.5 and 1.2.6), but now I realize that I hadn't tested against stereo mode in just as long. When using the a52 plugin, pavumeter is frozen as soon as it opens: if audio was playing, levels will show at exactly where they were at that moment and never change; if audio was not playing, levels will never appear because the interface is frozen before there were any. I am curious if this, #37 and #32 are not related. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/42 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

a52: frozen pavumeter
by GitHub issues - opened 27 Dec '21

27 Dec '21

alsa-project/alsa-plugins issue #42 was opened from quequotion: I had been thinking that pavumeter was just broken, because this has been happening to me for a long time (well before the changes between 1.2.5 and 1.2.6), but now I realize that I hadn't tested against stereo mode in just as long. When using the a52 plugin, pavumeter is frozen as soon as it opens: if audio was playing, levels will show at exactly where they were at that moment and never change; if audio was not playing, levels will never appear because the interface is frozen before there were any. I am curious if this, #37 and #32 are not related. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/42 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

After Update: No more sound. Downgrading solved it.
by GitHub issues - edited 27 Dec '21

27 Dec '21

alsa-project/alsa-ucm-conf issue #131 was edited from aljazzair: Hello. I am on Manjaro Linux, an Arch derivative. Recently, after a system update, sound was gone. After a couple of hours investigation, I narrowed it down to an update of alsa-ucm-conf. Basically after downgrading 1.2.6.3-0 => 1.2.5.1-1, my problem is gone. Symptom: With 1.2.6.3-0, there was no sound. Running aplay -l listed my hardware. Also I was able to hear sound from my monitor using the following command: > aplay -D plughw:0,7 /usr/share/sounds/alsa/Front_Right.wav But pactl list sinks came back empty. Pavucontrol showed no output devices either. Rebooting several times, editing various config files did not help. I looked at the list of recent upgrades and saw alsa-ucm-conf in the logs. Downgrading solved my issue. Distribution: > Linux homelab 5.13.19-2-MANJARO #1 SMP PREEMPT Sun Sep 19 21:31:53 UTC 2021 x86_64 GNU/Linux List of PLAYBACK Hardware Devices from aplay -l: > card 0: PCH [HDA Intel PCH], device 0: ALC1220 Analog [ALC1220 Analog] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 1: ALC1220 Digital [ALC1220 Digital] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 7: HDMI 1 [HDMI 1] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 8: HDMI 2 [HDMI 2] > Subdevices: 0/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 9: HDMI 3 [HDMI 3] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 10: HDMI 4 [HDMI 4] > Subdevices: 1/1 > Subdevice #0: subdevice #0 Sound managed with: > pipewire --version > pipewire > Compiled with libpipewire 0.3.40 > Linked with libpipewire 0.3.40 > I am posting this in order to document what happened in case someone has a similar issue, and searches google for hints. Also to inform the developer, maybe something can be done to avoid this. Thank you. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/131 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

After Update: No more sound. Downgrading solved it.
by GitHub issues - edited 27 Dec '21

27 Dec '21

alsa-project/alsa-ucm-conf issue #131 was edited from aljazzair: Hello. I am on Manjaro Linux, an Arch derivative. Recently, after a system update, sound was gone. After a couple of hours investigation, I narrowed it down to an update of alsa-ucm-conf. Basically after downgrading 1.2.6.3-0 => 1.2.5.1-1, my problem is gone. Symptom: With 1.2.6.3-0, there was no sound. Running aplay -l listed my hardware. Also I was able to hear sound from my monitor using the following command: > aplay -D plughw:0,7 /usr/share/sounds/alsa/Front_Right.wav But pactl list sinks came back empty. Pavucontrol showed no output devices either. Rebooting several times, editing various config files did not help. I looked at the list of recent upgrades and saw alsa-ucm-conf in the logs. Downgrading solved my issue. Distribution: > Linux homelab 5.13.19-2-MANJARO #1 SMP PREEMPT Sun Sep 19 21:31:53 UTC 2021 x86_64 GNU/Linux List of PLAYBACK Hardware Devices from aplay -l: > card 0: PCH [HDA Intel PCH], device 0: ALC1220 Analog [ALC1220 Analog] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 1: ALC1220 Digital [ALC1220 Digital] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 3: HDMI 0 [HDMI 0] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 7: HDMI 1 [HDMI 1] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 8: HDMI 2 [HDMI 2] > Subdevices: 0/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 9: HDMI 3 [HDMI 3] > Subdevices: 1/1 > Subdevice #0: subdevice #0 > card 0: PCH [HDA Intel PCH], device 10: HDMI 4 [HDMI 4] > Subdevices: 1/1 > Subdevice #0: subdevice #0 Sound managed with: > pipewire --version > pipewire > Compiled with libpipewire 0.3.40 > Linked with libpipewire 0.3.40 > I am posting this in order to document what happened in case someone has the same issue, and searches google for hints. Also to inform the developper, maybe something can be done to avoid this. Thank you. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/131 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0