April 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: brcm: fix dma_addr_t cast to pointer
by Arnd Bergmann 08 Apr '20

08 Apr '20

A dma_addr_t is not a pointer and a cast causes a warning when the sizes are different: sound/soc/bcm/bcm63xx-pcm-whistler.c: In function 'bcm63xx_pcm_pointer': sound/soc/bcm/bcm63xx-pcm-whistler.c:184:6: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 184 | if ((void *)prtd->dma_addr_next == NULL) Change the comparison to NULL to an equivalent if() check that does not warn. Fixes: 88eb404ccc3e ("ASoC: brcm: Add DSL/PON SoC audio driver") Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> --- sound/soc/bcm/bcm63xx-pcm-whistler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/bcm/bcm63xx-pcm-whistler.c b/sound/soc/bcm/bcm63xx-pcm-whistler.c index e46c390683e7..b7a1efc7406e 100644 --- a/sound/soc/bcm/bcm63xx-pcm-whistler.c +++ b/sound/soc/bcm/bcm63xx-pcm-whistler.c @@ -181,7 +181,7 @@ bcm63xx_pcm_pointer(struct snd_soc_component *component, snd_pcm_uframes_t x; struct bcm63xx_runtime_data *prtd = substream->runtime->private_data; - if ((void *)prtd->dma_addr_next == NULL) + if (!prtd->dma_addr_next) prtd->dma_addr_next = substream->runtime->dma_addr; x = bytes_to_frames(substream->runtime, -- 2.26.0

1 0

[GIT PULL] ASoC fixes for v5.7
by Mark Brown 08 Apr '20

08 Apr '20

The following changes since commit 3d2cdb854659851d991f5b8e97e847e3fd240625: Merge series "ASoC: Intel: add SoundWire machine driver" from Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com>: (2020-03-27 17:28:36 +0000) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.7 for you to fetch changes up to ccfc531695f3a4aada042f6bdb33ac6be24e1aec: ASoC: cs4270: pull reset GPIO low then high (2020-04-07 15:29:54 +0100) ---------------------------------------------------------------- ASoC: Fixes for v5.7 A collection of fixes that have been accumilated since the merge window, mainly relating to x86 platform support. ---------------------------------------------------------------- Akshu Agrawal (1): ASoC: AMD: Clear format bits before setting them Cezary Rojewski (4): ASoC: Intel: broadwell: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link Fabio Estevam (1): dt-bindings: sound: cs42l51: Remove unneeded I2C unit name Hans de Goede (6): ASoC: SOF: Turn "firmware boot complete" message into a dbg message ASoC: Intel: atom: Take the drv->lock mutex before calling sst_send_slot_map() ASoC: Intel: atom: Check drv->lock is locked in sst_fill_and_send_cmd_unlocked ASoC: Intel: atom: Fix uninitialized variable compiler warning ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet ASoC: rt5645: Add platform-data for Medion E1239T Julia Lawall (1): ASoC: stm32: sai: Add missing cleanup Mark Brown (1): Merge series "ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link" from Cezary Rojewski <cezary.rojewski(a)intel.com>: Mike Willard (1): ASoC: cs4270: pull reset GPIO low then high Pierre-Louis Bossart (1): ASoC: soc-dai: fix DAI startup/shutdown sequence Stephan Gerhold (1): ASoC: qcom: q6asm-dai: Add SNDRV_PCM_INFO_BATCH flag Takashi Iwai (1): ASoC: bcm: Fix pointer cast warning YueHaibing (1): ASoC: rt5682: Fix build error without CONFIG_I2C 이경택 (4): ASoC: fix regwmask ASoC: dapm: connect virtual mux with default value ASoC: dpcm: allow start or stop during pause for backend ASoC: topology: use name_prefix for new kcontrol .../devicetree/bindings/sound/cirrus,cs42l51.yaml | 2 +- include/sound/soc-dai.h | 2 +- sound/soc/amd/raven/acp3x-i2s.c | 1 + sound/soc/amd/raven/acp3x.h | 2 ++ sound/soc/bcm/bcm63xx-pcm-whistler.c | 2 +- sound/soc/codecs/cs4270.c | 40 +++++++++++++++++++--- sound/soc/codecs/rt5645.c | 8 +++++ sound/soc/codecs/rt5682.c | 5 ++- sound/soc/intel/atom/sst-atom-controls.c | 4 +++ sound/soc/intel/atom/sst/sst_pvt.c | 2 +- sound/soc/intel/boards/bdw-rt5650.c | 1 - sound/soc/intel/boards/bdw-rt5677.c | 1 - sound/soc/intel/boards/broadwell.c | 1 - sound/soc/intel/boards/bytcr_rt5640.c | 11 ++++++ sound/soc/intel/boards/haswell.c | 1 - sound/soc/qcom/qdsp6/q6asm-dai.c | 4 +-- sound/soc/soc-dai.c | 8 ++--- sound/soc/soc-dapm.c | 8 ++++- sound/soc/soc-ops.c | 4 +-- sound/soc/soc-pcm.c | 6 ++-- sound/soc/soc-topology.c | 2 +- sound/soc/sof/loader.c | 2 +- sound/soc/stm/stm32_sai_sub.c | 4 ++- 23 files changed, 93 insertions(+), 28 deletions(-)

2 1

[PATCH 1/2] ALSA: usb-audio: Add mixer workaround for TRX40 and co
by Takashi Iwai 08 Apr '20

08 Apr '20

Some recent boards (supposedly with a new AMD platform) contain the USB audio class 2 device that is often tied with HD-audio. The device exposes an Input Gain Pad control (id=19, control=12) but this node doesn't behave correctly, returning an error for each inquiry of GET_MIN and GET_MAX that should have been mandatory. As a workaround, simply ignore this node by adding a usbmix_name_map table entry. The currently known devices are: * 0414:a002 - Gigabyte TRX40 Aorus Pro WiFi * 0b05:1916 - ASUS ROG Zenith II * 0b05:1917 - ASUS ROG Strix * 0db0:0d64 - MSI TRX40 Creator * 0db0:543d - MSI TRX40 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206543 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/usb/mixer_maps.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 5ebca8013840..72b575c34860 100644 --- a/sound/usb/mixer_maps.c +++ b/sound/usb/mixer_maps.c @@ -359,6 +359,14 @@ static const struct usbmix_name_map corsair_virtuoso_map[] = { { 0 } }; +/* Some mobos shipped with a dummy HD-audio show the invalid GET_MIN/GET_MAX + * response for Input Gain Pad (id=19, control=12). Skip it. + */ +static const struct usbmix_name_map asus_rog_map[] = { + { 19, NULL, 12 }, /* FU, Input Gain Pad */ + {} +}; + /* * Control map entries */ @@ -488,6 +496,26 @@ static const struct usbmix_ctl_map usbmix_ctl_maps[] = { .id = USB_ID(0x1b1c, 0x0a42), .map = corsair_virtuoso_map, }, + { /* Gigabyte TRX40 Aorus Pro WiFi */ + .id = USB_ID(0x0414, 0xa002), + .map = asus_rog_map, + }, + { /* ASUS ROG Zenith II */ + .id = USB_ID(0x0b05, 0x1916), + .map = asus_rog_map, + }, + { /* ASUS ROG Strix */ + .id = USB_ID(0x0b05, 0x1917), + .map = asus_rog_map, + }, + { /* MSI TRX40 Creator */ + .id = USB_ID(0x0db0, 0x0d64), + .map = asus_rog_map, + }, + { /* MSI TRX40 */ + .id = USB_ID(0x0db0, 0x543d), + .map = asus_rog_map, + }, { 0 } /* terminator */ }; -- 2.25.0

1 1

[PATCH] ALSA: hda/realtek - Add quirk for MSI GL63
by Takashi Iwai 08 Apr '20

08 Apr '20

MSI GL63 laptop requires the similar quirk like other MSI models, ALC1220_FIXUP_CLEVO_P950. The board BIOS doesn't provide a PCI SSID for the device, hence we need to take the codec SSID (1462:1275) instead. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207157 Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 019239190f6d..de2826f90d34 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2455,6 +2455,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = { SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS), SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1462, 0x1275, "MSI-GL63", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1276, "MSI-GL73", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x1293, "MSI-GP65", ALC1220_FIXUP_CLEVO_P950), SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD), -- 2.25.0

1 0

Error compiling alsatplg
by GitHub issues - opened 08 Apr '20

08 Apr '20

alsa-project/alsa-utils issue #37 was opened from dbaluta: With latest alsa-lib and alsa-utils sources I cannot compile alsatplg utility. Steps followed: # Compile alsa-lib 1. ./gitcompile --prefix=$HOME/work/sof_dir/alsa-lib-bins/ 2. make install #custom instalation to be later used by alsa-utils. # Compile alsa-utils 1. /gitcompile --with-alsa-inc-prefix=$HOME/work/sof_dir/alsa-lib-bins/include/ --with-alsa-prefix=$HOME/work/sof_dir/alsa-lib-bins/lib 2. I get the following errors: ``` -ldl -lpthread topology.o: In function `load_topology': /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:135: undefined reference to `snd_tplg_create' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:141: undefined reference to `snd_tplg_load' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:145: undefined reference to `snd_tplg_free' topology.o: In function `version': /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:63: undefined reference to `snd_tplg_version' topology.o: In function `dump': /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:218: undefined reference to `snd_tplg_save' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:219: undefined reference to `snd_tplg_free' topology.o: In function `compile': /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:245: undefined reference to `snd_tplg_build_bin' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:246: undefined reference to `snd_tplg_free' topology.o: In function `decode': /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:268: undefined reference to `snd_tplg_create' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:273: undefined reference to `snd_tplg_decode' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:281: undefined reference to `snd_tplg_save' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:282: undefined reference to `snd_tplg_free' /home/nxf25322/work/sof_dir/alsa-utils/topology/topology.c:276: undefined reference to `snd_tplg_free' collect2: error: ld returned 1 exit status Makefile:433: recipe for target 'alsatplg' failed ``` Similar with https://github.com/alsa-project/alsa-utils/issues/33 Issue URL : https://github.com/alsa-project/alsa-utils/issues/37 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

M-Audio Fast Track Ultra S/PDIF clock source
by George Marques 07 Apr '20

07 Apr '20

Hello, I have my trusty old FTU audio interface and I've been super happy of how it works well on Linux with ALSA. Today I finally found some use for the S/PDIF input, which would allow me to free up two analog inputs in my setup. However, I found out it's not possible to change the clock source using ALSA, so I cannot use the S/PDIF input on Linux. This issue was raised by Felix Homann back in 2011: https://www.alsa-project.org/pipermail/alsa-devel/2011-June/040846.html but I couldn't find any new development, even though other issues were fixed. On Windows the proprietary driver naturally has an option for that, which allowed me to verify that the input is in fact working correctly. Changing on Windows and then rebooting into Linux does not work, so either this is not persisted or something on Linux is unknowingly changing it back. I actually want to help add this option to the driver, so I can use it myself but also make it available to others who still rely on this interface. My questions are: 1) Was there any progress in this regard? Most of work has been done around 2012 for what I could find, nothing newer, so can I assume no work was done after the concern was raised? 2) If I were to develop this option, where could I start? I can get myself around with C, but I have no idea how to debug and test my patches, nor how to find the exact control. I know it's an old card, but it works very well for me so I have no excuse to just replace it at this point. I hope someone can help me.

1 0

TRX40 Realtek ALC1220-VB USB Audio
by laurent Trinques 07 Apr '20

07 Apr '20

Hello, sudo dmesg -lerr -lcrit [ 0.386478] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.WT1A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386484] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386488] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.MT1A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386490] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386493] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.WT2A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386495] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386497] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.MT2A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386499] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386501] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.WT3A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386504] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386506] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.MT3A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386508] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386510] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.WT4A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386513] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386516] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.MT4A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386518] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386520] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CA.MT5A], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386523] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386526] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.WT1B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386529] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386531] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.MT1B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386534] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386536] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.WT2B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386538] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386541] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.MT2B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386543] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386546] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.WT3B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386548] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386550] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.MT3B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386553] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386555] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.WT4B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386557] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386560] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.MT4B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386562] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386565] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CB.MT5B], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386567] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386571] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.WT1C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386573] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386575] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.MT1C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386578] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386580] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.WT2C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386583] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386585] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.MT2C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386587] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386590] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.WT3C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386592] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386595] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.MT3C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386597] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386599] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.WT4C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386602] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386604] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.MT4C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386606] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386609] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CC.MT5C], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386611] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386615] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.WT1D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386617] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386620] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.MT1D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386622] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386624] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.WT2D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386627] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386629] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.MT2D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386632] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386634] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.WT3D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386636] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386639] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.MT3D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386641] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386644] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.WT4D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386646] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386648] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.MT4D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386651] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 0.386653] ACPI BIOS Error (bug): Failure creating named object [\_SB.I2CD.MT5D], AE_ALREADY_EXISTS (20191018/dswload2-323) [ 0.386656] ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20191018/psobject-220) [ 2.527434] sp5100-tco sp5100-tco: Watchdog hardware is disabled [ 2.545332] Error: Driver 'pcspkr' is already registered, aborting... [ 2.572542] snd_hda_intel 0000:23:00.4: no codecs found! [ 8.169209] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.169214] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 8.430796] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.430800] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 8.431164] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.483290] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.483294] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 8.483662] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.628066] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.628071] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 8.628557] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.849035] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 8.849039] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 8.849405] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.040530] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.040534] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 9.040903] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.233150] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.233154] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 9.233522] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.425023] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.425027] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 9.425389] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.617141] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.617145] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 9.617636] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.809016] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 9.809020] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 9.809385] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.000383] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.000387] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 10.000754] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.417141] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.417146] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 10.417641] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.467123] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 10.467127] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 10.467870] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.148540] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.148545] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.149030] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.211031] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.211035] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.211402] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.289284] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.289289] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.289654] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.480906] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.480911] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.481275] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.673023] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.673028] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.673392] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.864772] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 14.864777] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 14.865138] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.057144] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.057149] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 15.057639] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.248638] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.248643] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 15.249010] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.440883] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.440887] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 15.441251] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.633004] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 15.633009] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 15.633373] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 16.016995] usb 7-5: cannot get ctl value: req = 0x83, wValue = 0xc00, wIndex = 0x1300, type = 4 [ 16.017000] usb 7-5: 19:0: cannot get min/max values for control 12 (id 19) [ 16.017491] usb 7-5: cannot get ctl value: req = 0x81, wValue = 0xc00, wIndex = 0x1300, type = 4 Best regards, Laurent

2 4

[PATCH 0/2] ALSA: Fix for bad ctl access patterns
by Takashi Iwai 07 Apr '20

07 Apr '20

Hi, the recently introduced ctl access validator succeessfully caught some real issues. Here are some fixes. Takashi === Takashi Iwai (2): ALSA: hda: Fix potential access overflow in beep helper ALSA: ice1724: Fix invalid access for enumerated ctl items sound/pci/hda/hda_beep.c | 6 +++++- sound/pci/ice1712/prodigy_hifi.c | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- 2.25.0

2 3

[PATCH] ASoC: cs4270: pull reset GPIO low then high
by Mike Willard 07 Apr '20

07 Apr '20

Pull the RST line low then high when initializing the driver, in order to force a reset of the chip. Previously, the line was not pulled low, which could result in the chip registers not resetting to their default values on boot. Signed-off-by: Mike Willard <mwillard(a)izotope.com> --- sound/soc/codecs/cs4270.c | 40 ++++++++++++++++++++++++++++++++++----- 1 file changed, 35 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index 5f25b9f872bd..8a02791e44ad 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c @@ -137,6 +137,9 @@ struct cs4270_private { /* power domain regulators */ struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)]; + + /* reset gpio */ + struct gpio_desc *reset_gpio; }; static const struct snd_soc_dapm_widget cs4270_dapm_widgets[] = { @@ -648,6 +651,22 @@ static const struct regmap_config cs4270_regmap = { .volatile_reg = cs4270_reg_is_volatile, }; +/** + * cs4270_i2c_remove - deinitialize the I2C interface of the CS4270 + * @i2c_client: the I2C client object + * + * This function puts the chip into low power mode when the i2c device + * is removed. + */ +static int cs4270_i2c_remove(struct i2c_client *i2c_client) +{ + struct cs4270_private *cs4270 = i2c_get_clientdata(i2c_client); + + gpiod_set_value_cansleep(cs4270->reset_gpio, 0); + + return 0; +} + /** * cs4270_i2c_probe - initialize the I2C interface of the CS4270 * @i2c_client: the I2C client object @@ -660,7 +679,6 @@ static int cs4270_i2c_probe(struct i2c_client *i2c_client, const struct i2c_device_id *id) { struct cs4270_private *cs4270; - struct gpio_desc *reset_gpiod; unsigned int val; int ret, i; @@ -679,10 +697,21 @@ static int cs4270_i2c_probe(struct i2c_client *i2c_client, if (ret < 0) return ret; - reset_gpiod = devm_gpiod_get_optional(&i2c_client->dev, "reset", - GPIOD_OUT_HIGH); - if (PTR_ERR(reset_gpiod) == -EPROBE_DEFER) - return -EPROBE_DEFER; + /* reset the device */ + cs4270->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset", + GPIOD_OUT_LOW); + if (IS_ERR(cs4270->reset_gpio)) { + dev_dbg(&i2c_client->dev, "Error getting CS4270 reset GPIO\n"); + return PTR_ERR(cs4270->reset_gpio); + } + + if (cs4270->reset_gpio) { + dev_dbg(&i2c_client->dev, "Found reset GPIO\n"); + gpiod_set_value_cansleep(cs4270->reset_gpio, 1); + } + + /* Sleep 500ns before i2c communications */ + ndelay(500); cs4270->regmap = devm_regmap_init_i2c(i2c_client, &cs4270_regmap); if (IS_ERR(cs4270->regmap)) @@ -735,6 +764,7 @@ static struct i2c_driver cs4270_i2c_driver = { }, .id_table = cs4270_id, .probe = cs4270_i2c_probe, + .remove = cs4270_i2c_remove, }; module_i2c_driver(cs4270_i2c_driver); -- 2.17.1

2 1

[PATCH v2 00/12] [RESEND] ASoC: SOF DSP virtualisation
by Guennadi Liakhovetski 07 Apr '20

07 Apr '20

This patch series extends the SOF driver to add support for DSP virtualisation to ASoC. It is built on top of VirtIO, contains a guest driver and a vhost in-kernel guest driver. This version supports a single playback and a single capture interface on the guest. The specific guest audio topology is supplied by the host from a file, specified on the QEMU command line. This solution is designed to use advanced DSP functionality, available on the host. In case no DSP is available on the host, a fall-back should be provided in the future to the pure audio virtualisation standard, currently developed by OASIS. Extensive documentation is available at [1]. I'd like to have at least a tentative approval on this series to send vhost patches 3 and 9 to virtualisation lists / maintainers for review and eventual merging. v2: one patch merged, one patch resubmitted separately, otherwise no changes. [1] https://thesofproject.github.io/latest/developer_guides/virtualization/virt… Guennadi Liakhovetski (12): ASoC: add function parameters to enable forced path pruning ASoC: SOF: extract firmware-related operation into a function ASoC: SOF: VirtIO: make a function global vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl ASoC: SOF: support IPC with immediate response ASoC: SOF: add a power status IPC ASoC: SOF: add two helper lookup functions ASoC: SOF: add a VirtIO DSP driver ASoC: SOF: add a vhost driver: sound part vhost: add an SOF DSP driver ASoC: SOF: VirtIO: free guest pipelines upon termination ASoC: SOF: VirtIO: enable simultaneous playback and capture drivers/vhost/Kconfig | 7 + drivers/vhost/Makefile | 5 + drivers/vhost/dsp.c | 731 ++++++++++++++++++++++ include/sound/soc-dpcm.h | 28 +- include/sound/soc-topology.h | 3 + include/sound/sof.h | 4 + include/sound/sof/header.h | 3 + include/sound/sof/topology.h | 1 + include/sound/sof/virtio.h | 206 +++++++ include/uapi/linux/vhost.h | 9 +- include/uapi/linux/vhost_types.h | 7 + include/uapi/linux/virtio_ids.h | 1 + sound/soc/soc-compress.c | 2 +- sound/soc/soc-dapm.c | 8 +- sound/soc/soc-pcm.c | 98 ++- sound/soc/sof/Kconfig | 8 + sound/soc/sof/Makefile | 8 + sound/soc/sof/core.c | 114 ++-- sound/soc/sof/ipc.c | 39 +- sound/soc/sof/loader.c | 4 + sound/soc/sof/ops.h | 10 +- sound/soc/sof/pcm.c | 13 +- sound/soc/sof/pm.c | 4 + sound/soc/sof/sof-audio.c | 33 + sound/soc/sof/sof-audio.h | 21 + sound/soc/sof/sof-priv.h | 52 ++ sound/soc/sof/topology.c | 71 ++- sound/soc/sof/vhost-be.c | 1248 ++++++++++++++++++++++++++++++++++++++ sound/soc/sof/virtio-fe.c | 922 ++++++++++++++++++++++++++++ 29 files changed, 3552 insertions(+), 108 deletions(-) create mode 100644 drivers/vhost/dsp.c create mode 100644 include/sound/sof/virtio.h create mode 100644 sound/soc/sof/vhost-be.c create mode 100644 sound/soc/sof/virtio-fe.c -- 1.9.3

3 21