April 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: rt5645: Add platform-data for Medion E1239T
by Hans de Goede 06 Apr '20

06 Apr '20

The Medion E1239T uses the default jack-detect mode 3, but instead of using an analog microphone it is using a DMIC on dmic-data-pin 1, like other models following Intel's Brasswell's reference design. This commit adds a DMI quirk pointing to the intel_braswell_platform_data for this model. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/codecs/rt5645.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 92d67010aeed..6ba1849a77b0 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -3758,6 +3758,14 @@ static const struct dmi_system_id dmi_platform_data[] = { }, .driver_data = (void *)&kahlee_platform_data, }, + { + .ident = "Medion E1239T", + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MEDION"), + DMI_MATCH(DMI_PRODUCT_NAME, "E1239T MD60568"), + }, + .driver_data = (void *)&intel_braswell_platform_data, + }, { } }; -- 2.26.0

3 2

[PATCH] ASoC: stm32: sai: Add missing cleanup
by Julia Lawall 06 Apr '20

06 Apr '20

The commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue") converts some function calls to their non-devm equivalents. The appropriate cleanup code was added to the remove function, but not to the probe function. Add a call to snd_dmaengine_pcm_unregister to compensate for the call to snd_dmaengine_pcm_register in case of subsequent failure. Fixes: commit 0d6defc7e0e4 ("ASoC: stm32: sai: manage rebind issue") Signed-off-by: Julia Lawall <Julia.Lawall(a)inria.fr> --- Not tested. sound/soc/stm/stm32_sai_sub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 2bd280c..0d0c9af 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -1556,8 +1556,10 @@ static int stm32_sai_sub_probe(struct platform_device *pdev) ret = snd_soc_register_component(&pdev->dev, &stm32_component, &sai->cpu_dai_drv, 1); - if (ret) + if (ret) { + snd_dmaengine_pcm_unregister(&pdev->dev); return ret; + } if (STM_SAI_PROTOCOL_IS_SPDIF(sai)) conf = &stm32_sai_pcm_config_spdif;

3 2

[PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
by Hans de Goede 06 Apr '20

06 Apr '20

The MPMAN MPWIN895CL tablet almost fully works with out default settings. The only problem is that it has only 1 speaker so any sounds only playing on the right channel get lost. Add a quirk for this model using the default settings + MONO_SPEAKER. Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index 6bd9ae813be2..d14d5f7db168 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { BYT_RT5640_SSP0_AIF1 | BYT_RT5640_MCLK_EN), }, + { + /* MPMAN MPWIN895CL */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"), + }, + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS | + BYT_RT5640_MONO_SPEAKER | + BYT_RT5640_SSP0_AIF1 | + BYT_RT5640_MCLK_EN), + }, { /* MSI S100 tablet */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."), -- 2.26.0

3 4

[PATCH] ASoC: qcom: common: Silence EPROBE_DEFER messages
by Bjorn Andersson 06 Apr '20

06 Apr '20

The Qualcomm sound card typically depends on several other drivers, resulting in plenty of noise in the kernel log due to probe deferral. Silence these errors. Signed-off-by: Bjorn Andersson <bjorn.andersson(a)linaro.org> --- sound/soc/qcom/common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index 6c20bdd850f3..cb266d7ec03e 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -80,7 +80,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name); if (ret) { - dev_err(card->dev, "%s: error getting cpu dai name\n", link->name); + if (ret != -EPROBE_DEFER) + dev_err(card->dev, "%s: error getting cpu dai name", link->name); goto err; } @@ -96,7 +97,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); if (ret < 0) { - dev_err(card->dev, "%s: codec dai not found\n", link->name); + if (ret != -EPROBE_DEFER) + dev_err(card->dev, "%s: codec dai not found\n", link->name); goto err; } link->no_pcm = 1; -- 2.24.0

2 1

alsa-gobject: integrate ALSASeq to handle queue operations
by GitHub pull_request - opened 06 Apr '20

06 Apr '20

alsa-project/alsa-gobject pull request #14 was opened from takaswie: In ALSA Sequencer, queue is an important element to dispatch scheduled events. Without queue, any events are going to be dispatched immediately and this mode is already supported. This patchset is to support queue operations and complete development for ALSASeq. The information of queue is represented by ALSASeq.QueueInfo GObject-derived object. Several APIs are added to ALSASeq.UserClient to maintain lifetime of queue: - ALSASeq.UserClient.create_queue() - ALSASeq.UserClient.delete_queue() - ALSASeq.UserClient.update_queue() The maintenance of actual queue behaviour can be already done by scheduling events with ALSASeq.EventDataQueue with appropriate event type. The status and tempo of queue to dispatch scheduled events is repsented by ALSASeq.QueueStatus and ALSASeq.QueueTempo. Some APIs are added to ALSASeq.UserClient to retrieve them: - ALSASeq.UserClient.set_queue_tempo() - ALSASeq.UserClient.get_queue_tempo() - ALSASeq.UserClient.set_queue_timer() - ALSASeq.UserClient.get_queue_timer() The registered queues can be reserved. Some APIs are added to ALSASeq.UserClient for the reservation: - ALSASeq.UserClient.get_queue_usage() - ALSASeq.UserClient.set_queue_usage() The queue is assigned to an instance of ALSA Timer device, practically. In this case, global system timer device is used according to parameters of snd_seq kernel module as a default. This global system timer is based on Linux timer wheel. The assignment is represented by subclasses of ALSASeq.QueueTimer and ALSASeq.QueueTimerALSA is currently available. Two APIs are added to ALSASeq.UserClient for the assignment: - ALSASeq.UserClient.set_queue_timer() - ALSASeq.UserClient.get_queue_timer() Finally, the scheduled events can be removed from the queues. The batch of target events is represented by ALSASeq.RemoveFilter and ALSASeq.UserClient.remove_events() is available for the removal. Request URL : https://github.com/alsa-project/alsa-gobject/pull/14 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/14.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

alsa-gobject: misc fixes
by GitHub pull_request - opened 06 Apr '20

06 Apr '20

alsa-project/alsa-gobject pull request #13 was opened from takaswie: This patchset is misc fixes. Request URL : https://github.com/alsa-project/alsa-gobject/pull/13 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/13.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH 0/4] ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link
by Cezary Rojewski 06 Apr '20

06 Apr '20

As of commit: ASoC: soc-core: care .ignore_suspend for Component suspend function soc-core::snd_soc_suspend no longer ignores 'ignore_suspend' flag for dai links. While BE dai link for System Pin is supposed to follow standard suspend-resume flow, appended 'ignore_suspend' flag disturbs that flow and causes audio to break right after resume. Remove the flag to address this. Link to first message in conversation: https://lkml.org/lkml/2020/3/18/54 Cezary Rojewski (4): ASoC: Intel: broadwell: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link sound/soc/intel/boards/bdw-rt5650.c | 1 - sound/soc/intel/boards/bdw-rt5677.c | 1 - sound/soc/intel/boards/broadwell.c | 1 - sound/soc/intel/boards/haswell.c | 1 - 4 files changed, 4 deletions(-) -- 2.17.1

5 22

Re:
by Ruslan Bilovol 05 Apr '20

05 Apr '20

Hi, Please also add to CC related mailing lists (alsa-devel, linux-usb) rather then directly emailing - community may also help with the issue. Also it can be googled so if somebody else have same issue it can find answers faster. On Fri, Apr 3, 2020 at 10:56 AM Colin Williams <colin.williams.seattle(a)gmail.com> wrote: > > https://ubuntuforums.org/showthread.php?t=2439897 > > On Thu, Apr 2, 2020 at 4:50 PM Colin Williams <colin.williams.seattle(a)gmail.com> wrote: >> >> Hello, >> >> Is it possible that one of these commits or related broke support for the Blue Mic Yeti? >> >> https://github.com/torvalds/linux/blame/ac438771ccb4479528594c7e19f2c39cf18… Tha'ts workaround to ignore last altsetting which is the same as previous. During UAC3 implementation, I reimplemented that workaround carefully, but I didn't have (and still do not own) any Blue Mic USB device. I don't know whether it was tested after that by anyone. >> >> I am getting the following when I plug my mic in: Which kernel version is that? Have you tried latest Linux Kernel? >> >> [ 1283.848740] usb 1-1.2: new full-speed USB device number 82 using ehci-pci >> [ 1283.964802] usb 1-1.2: New USB device found, idVendor=b58e, idProduct=9e84, bcdDevice= 1.00 >> [ 1283.964808] usb 1-1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 >> [ 1283.964810] usb 1-1.2: Product: Yeti Stereo Microphone >> [ 1283.964812] usb 1-1.2: Manufacturer: Blue Microphones >> [ 1284.080671] usb 1-1.3: new low-speed USB device number 83 using ehci-pci >> [ 1284.784678] usb 1-1.3: device descriptor read/64, error -32 >> [ 1285.180674] usb 1-1.3: device descriptor read/64, error -32 >> [ 1285.992682] usb 1-1.3: new low-speed USB device number 84 using ehci-pci >> [ 1286.696672] usb 1-1.3: device descriptor read/64, error -32 >> [ 1287.092695] usb 1-1.3: device descriptor read/64, error -32 >> [ 1287.200804] usb 1-1-port3: attempt power cycle >> [ 1287.804662] usb 1-1.3: new low-speed USB device number 85 using ehci-pci >> [ 1288.220686] usb 1-1.3: device not accepting address 85, error -32 >> [ 1288.508685] usb 1-1.3: new low-speed USB device number 86 using ehci-pci >> [ 1288.924690] usb 1-1.3: device not accepting address 86, error -32 >> [ 1288.924916] usb 1-1-port3: unable to enumerate USB device >> [ 1288.925391] usb 1-1.2: USB disconnect, device number 82 >> [ 1289.308736] usb 1-1.3: new low-speed USB device number 87 using ehci-pci >> [ 1289.596727] usb 1-1.3: device descriptor read/64, error -32 >> [ 1289.992635] usb 1-1.3: device descriptor read/64, error -32 >> [ 1290.596683] usb 1-1.3: new low-speed USB device number 88 using ehci-pci >> [ 1290.888718] usb 1-1.3: device descriptor read/64, error -32 >> [ 1291.284673] usb 1-1.3: device descriptor read/64, error -32 >> [ 1291.392928] usb 1-1-port3: attempt power cycle Looking at this log, it seems the issue happens during enumeration, so mentioned workaround isn't executed yet at this moment. So it seems this is related to USB core, not to ALSA driver. Thanks, Ruslan >> >> Furthermore, there is some evidence this is happening to other users: >> >> https://askubuntu.com/questions/1027188/external-yeti-michrophone-not-detec… >> >> Best Regards, >> >> Colin Williams >> >>

2 1

[PATCH] ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Alpha S
by Emmanuel Pescosta 04 Apr '20

04 Apr '20

Similar to the Kingston HyperX AMP, the Kingston HyperX Cloud Alpha S (0951:16d8) uses two interfaces, but only the second interface contains the capture stream. This patch delays the registration until the second interface appears. Signed-off-by: Emmanuel Pescosta <emmanuelpescosta099(a)gmail.com> --- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 86f192a3043d..a8ece1701068 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1827,6 +1827,7 @@ struct registration_quirk { static const struct registration_quirk registration_quirks[] = { REG_QUIRK_ENTRY(0x0951, 0x16d8, 2), /* Kingston HyperX AMP */ + REG_QUIRK_ENTRY(0x0951, 0x16ed, 2), /* Kingston HyperX Cloud Alpha S */ { 0 } /* terminator */ }; -- 2.26.0

2 1

alsa-gobject: fix annotations for constructors
by GitHub pull_request - opened 04 Apr '20

04 Apr '20

alsa-project/alsa-gobject pull request #12 was opened from takaswie: Some constructor functions have redundant or invalid annotations. Request URL : https://github.com/alsa-project/alsa-gobject/pull/12 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/12.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0