April 2020 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: bdw-rt5650: incorrect rate of PCM data
by Brent Lu 13 Apr '20

13 Apr '20

Implement a constrain to exclude 3-channel capture since only 2 and 4 channel capture are supported on the platform. Signed-off-by: Brent Lu <brent.lu(a)intel.com> --- sound/soc/intel/boards/bdw-rt5650.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/sound/soc/intel/boards/bdw-rt5650.c b/sound/soc/intel/boards/bdw-rt5650.c index af2f502..eedbdad 100644 --- a/sound/soc/intel/boards/bdw-rt5650.c +++ b/sound/soc/intel/boards/bdw-rt5650.c @@ -83,6 +83,36 @@ static struct snd_soc_jack_pin mic_jack_pin = { .mask = SND_JACK_MICROPHONE, }; +static const unsigned int channels[] = { + 2, 4, +}; + +static const struct snd_pcm_hw_constraint_list constraints_channels = { + .count = ARRAY_SIZE(channels), + .list = channels, + .mask = 0, +}; + +static int bdw_fe_startup(struct snd_pcm_substream *substream) +{ + struct snd_pcm_runtime *runtime = substream->runtime; + + /* + * On this platform for PCM device we support, + * 2 or 4 channel capture + */ + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) + snd_pcm_hw_constraint_list(runtime, 0, + SNDRV_PCM_HW_PARAM_CHANNELS, + &constraints_channels); + + return 0; +} + +static const struct snd_soc_ops bdw_rt5650_fe_ops = { + .startup = bdw_fe_startup, +}; + static int broadwell_ssp0_fixup(struct snd_soc_pcm_runtime *rtd, struct snd_pcm_hw_params *params) { @@ -234,6 +264,7 @@ static struct snd_soc_dai_link bdw_rt5650_dais[] = { .name = "System PCM", .stream_name = "System Playback", .dynamic = 1, + .ops = &bdw_rt5650_fe_ops, #if !IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL) .init = bdw_rt5650_rtd_init, #endif -- 2.7.4

3 2

alsa-gobject: seq: tstamp: use wrapper structure instead of union
by GitHub pull_request - opened 13 Apr '20

13 Apr '20

alsa-project/alsa-gobject pull request #17 was opened from takaswie: In UAPI for ALSA Sequencer, snd_seq_timestamp is union with snd_seq_tick_time_t and struct snd_seq_real_time types. The libalsaseq has GLib Boxed object for the union, named as ALSASeqTstamp. ``` $ cat build/src/seq/ALSASeq-0.0.gir ... <union name="Tstamp" c:type="ALSASeqTstamp" glib:type-name="ALSASeqTstamp" glib:get-type="alsaseq_tstamp_get_type" c:symbol-prefix="tstamp"> <source-position filename="../src/seq/tstamp.h" line="14"/> ... </union> ... ``` Although this is valid in a view of GObject Introspection, it's not necessarily convenient to language bindings because some programming language doesn't support union type. In this case, the type is not available. This commit adds an alternative structure to wrap the union. As a result, ALSASeqTstamp is GLib Boxed object for the wrapper structure. ``` $ cat build/src/seq/ALSASeq-0.0.gir ... <record name="Tstamp" c:type="ALSASeqTstamp" glib:type-name="ALSASeqTstamp" glib:get-type="alsaseq_tstamp_get_type" c:symbol-prefix="tstamp"> <source-position filename="../src/seq/tstamp.h" line="18"/> <field name="tstamp" writable="1"> <type name="gpointer" c:type="snd_seq_timestamp"/> </field> ... </record> ... ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/17 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/17.patch Repository URL: https://github.com/alsa-project/alsa-gobject

1 0

[PATCH RFC] clumsy attempt at fixing rate plugin draining function
by sylvain.bertrand＠gmail.com 12 Apr '20

12 Apr '20

Hi, This is related to github issue #41. I don't know how to update last_commit_ptr properly. Neither if it is consistent with the rate state (boundary, app_ptr, etc). -- Sylvain --- a/src/pcm/pcm_rate.c +++ b/src/pcm/pcm_rate.c @@ -1051,6 +1051,7 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm) /* commit the remaining fraction (if any) */ snd_pcm_uframes_t size, ofs, saved_avail_min; snd_pcm_sw_params_t sw_params; + int commit_err; __snd_pcm_lock(pcm); /* temporarily set avail_min to one */ @@ -1064,7 +1065,7 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm) while (size > 0) { snd_pcm_uframes_t psize, spsize; int err; - + err = __snd_pcm_wait_in_lock(rate->gen.slave, -1); if (err < 0) break; @@ -1077,14 +1078,29 @@ static int snd_pcm_rate_drain(snd_pcm_t *pcm) if (! spsize) break; } - snd_pcm_rate_commit_area(pcm, rate, ofs, + commit_err = snd_pcm_rate_commit_area(pcm, rate, ofs, psize, spsize); + if (commit_err == 1) { + rate->last_commit_ptr += psize; + if (rate->last_commit_ptr >= pcm->boundary) + rate->last_commit_ptr = 0; + } else if (commit_err == 0) { + if (pcm->mode & SND_PCM_NONBLOCK != 0) { + commit_err = -EAGAIN; + break; + } + continue; + } else + break; + ofs = (ofs + psize) % pcm->buffer_size; size -= psize; } sw_params.avail_min = saved_avail_min; snd_pcm_sw_params(rate->gen.slave, &sw_params); __snd_pcm_unlock(pcm); + if (commit_err < 0) + return commit_err; } return snd_pcm_drain(rate->gen.slave); }

1 0

desperate to find a fix for ALC298
by n c 12 Apr '20

12 Apr '20

Kernel: linux5.6 (source here <https://github.com/torvalds/linux/releases/tag/v5.6>) Distro: Tried most for months since linux5.4 (currently on manjaro) Desktop: gnome Alsa-info: (pastebin here <https://pastebin.com/w35JGdGu>) Any configs: No just the defaults (no alsa/.asound, pulse/client.conf etc...) Cards: Single on-board Realtek ALC298 *Issue* On-board sound does not work at all. Neither on speakers or headphones, no matter which distro or kernel I tried (since 5.4+ of course). *Have I asked the community?* I have a SO question here <https://unix.stackexchange.com/questions/579486/alsa-pulseaudio-and-intel-h…> and a manjaro topic here <https://forum.manjaro.org/t/alsa-pulseaudio-and-intel-hda-pch-with-no-sound> . *Have I tried fixing it myself?* Yes, a lot. The threads above both have a lot of information in them. Highlight of my debugging so far is that the codec pin "0x1a" has an incorrect VREF assigned to it (HIZ). Found this by accident when using hda-analyzer. Changing it to VREF 50, 80 or 100 fixes the headphones. Have no idea how to persist it using init_verbs (don't know how to package the new value 0x05), so wrote a systemd file to hack it using hda-verb utility at startup. It stopped working eventually or sometimes had to stop/restart the service to reissue the change. I read somewhere that the incorrect VREF is a sign of UEFI/BIOS chip assigning incorrect speaker pins. Although I could not get the speakers working at all using any utilities mentioned above. Thank you for reading,

1 0

[PATCH 0/4] ALSA: usb-audio: More workarounds for TRX40-mobos
by Takashi Iwai 12 Apr '20

12 Apr '20

Hi, it turned out that the recent mobos shipped with Realtek codec need more workarounds. In the end, most of the fixes here are generic issues, hence marked for stable. The bugtracker is at: https://bugzilla.kernel.org/show_bug.cgi?id=206873 Takashi === Takashi Iwai (4): ALSA: usb-audio: Filter error from connector kctl ops, too ALSA: usb-audio: Don't override ignore_ctl_error value from the map ALSA: usb-audio: Don't create jack controls for PCM terminals ALSA: usb-audio: Check mapping at creating connector controls, too sound/usb/mixer.c | 31 +++++++++++++++++++------------ sound/usb/mixer_maps.c | 4 +++- 2 files changed, 22 insertions(+), 13 deletions(-) -- 2.16.4

1 4

snd_pcm_drain() infinite loop
by GitHub issues - edited 12 Apr '20

12 Apr '20

alsa-project/alsa-lib issue #41 was edited from sylware: In a non-blocking dmix-ed plugin pipeline (see below), playing audio from a 44100Hz source to a running 48000Hz hardware pcm, will go into an -EAGAIN infinite loop in snd_pcm_drain(). I did a bit of tracing and it seems snd_pcm_drain() will always return -EAGAIN because in pcm_dmix.c:snd_pcm_dmix_sync_ptr0, avail is never >= pcm->stop_threshold Issue URL : https://github.com/alsa-project/alsa-lib/issues/41 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH AUTOSEL 4.9 22/26] ASoC: Intel: Skylake: Enable codec wakeup during chip init
by Sasha Levin 12 Apr '20

12 Apr '20

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit e603f11d5df8997d104ab405ff27640b90baffaa ] Follow the recommendation set by hda_intel.c and enable HDMI/DP codec wakeup during bus initialization procedure. Disable wakeup once init completes. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20200305145314.32579-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/skylake/skl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 3e526fbd267e6..223958c49bf8d 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -102,9 +102,11 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) { int ret; + snd_hdac_set_codec_wakeup(bus, true); skl_enable_miscbdcge(bus->dev, false); ret = snd_hdac_bus_init_chip(bus, full_reset); skl_enable_miscbdcge(bus->dev, true); + snd_hdac_set_codec_wakeup(bus, false); return ret; } -- 2.20.1

1 0

[PATCH AUTOSEL 4.14 31/37] ASoC: Intel: Skylake: Enable codec wakeup during chip init
by Sasha Levin 12 Apr '20

12 Apr '20

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit e603f11d5df8997d104ab405ff27640b90baffaa ] Follow the recommendation set by hda_intel.c and enable HDMI/DP codec wakeup during bus initialization procedure. Disable wakeup once init completes. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20200305145314.32579-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/skylake/skl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index a0bef63b8fb11..7fb4df78ecb35 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -103,9 +103,11 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) { int ret; + snd_hdac_set_codec_wakeup(bus, true); skl_enable_miscbdcge(bus->dev, false); ret = snd_hdac_bus_init_chip(bus, full_reset); skl_enable_miscbdcge(bus->dev, true); + snd_hdac_set_codec_wakeup(bus, false); return ret; } -- 2.20.1

1 0

[PATCH AUTOSEL 4.19 53/66] ASoC: Intel: Skylake: Enable codec wakeup during chip init
by Sasha Levin 12 Apr '20

12 Apr '20

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit e603f11d5df8997d104ab405ff27640b90baffaa ] Follow the recommendation set by hda_intel.c and enable HDMI/DP codec wakeup during bus initialization procedure. Disable wakeup once init completes. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20200305145314.32579-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/skylake/skl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 50f16a0f6535f..463078c2346f9 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -128,6 +128,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) struct hdac_ext_link *hlink; int ret; + snd_hdac_set_codec_wakeup(bus, true); skl_enable_miscbdcge(bus->dev, false); ret = snd_hdac_bus_init_chip(bus, full_reset); @@ -136,6 +137,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) bus->io_ops->reg_writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV); skl_enable_miscbdcge(bus->dev, true); + snd_hdac_set_codec_wakeup(bus, false); return ret; } -- 2.20.1

1 0

[PATCH AUTOSEL 5.4 086/108] ASoC: Intel: Skylake: Enable codec wakeup during chip init
by Sasha Levin 12 Apr '20

12 Apr '20

From: Cezary Rojewski <cezary.rojewski(a)intel.com> [ Upstream commit e603f11d5df8997d104ab405ff27640b90baffaa ] Follow the recommendation set by hda_intel.c and enable HDMI/DP codec wakeup during bus initialization procedure. Disable wakeup once init completes. Signed-off-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Link: https://lore.kernel.org/r/20200305145314.32579-4-cezary.rojewski@intel.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/intel/skylake/skl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c index 141dbbf975acd..9ef9651c4dfe1 100644 --- a/sound/soc/intel/skylake/skl.c +++ b/sound/soc/intel/skylake/skl.c @@ -129,6 +129,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) struct hdac_ext_link *hlink; int ret; + snd_hdac_set_codec_wakeup(bus, true); skl_enable_miscbdcge(bus->dev, false); ret = snd_hdac_bus_init_chip(bus, full_reset); @@ -137,6 +138,7 @@ static int skl_init_chip(struct hdac_bus *bus, bool full_reset) writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV); skl_enable_miscbdcge(bus->dev, true); + snd_hdac_set_codec_wakeup(bus, false); return ret; } -- 2.20.1

1 0