December 2020 - Alsa-devel - mailman.alsa-project.org

pulse: handle reading pulse stream hole
by GitHub pull_request - opened 28 Dec '20

28 Dec '20

alsa-project/alsa-plugins pull request #17 was opened from i-garrison: If there is a hole in pulse stream, handle it by generating silence. This should fix #16 Request URL : https://github.com/alsa-project/alsa-plugins/pull/17 Patch URL : https://github.com/alsa-project/alsa-plugins/pull/17.patch Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

pulse plugin crash when stream has a hole
by GitHub issues - opened 28 Dec '20

28 Dec '20

alsa-project/alsa-plugins issue #16 was opened from i-garrison: Following up on this debian bug report https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824850 Looks like this crash is caused by missing stream hole handling in pulse plugin. Pulseaudio change was done just before `pulseaudio-v3.0` release and this issue should be reproducible with all current versions: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/dfd44036b54d6… quoting from there: ``` ... let the caller decide how the holes should be handled, so in case of holes, pa_stream_peek() will return NULL data pointer and the length of the hole in the nbytes argument ``` Here in pulse plugin, if there is a hole in stream `pa_stream_peek` would return NULL buffer pointer but non-zero `frag_length` and later memcpy is happily trying to copy from NULL source: https://github.com/alsa-project/alsa-plugins/blob/7028580da1db9a2362dd9b063… Instead, pulse plugin should detect there is a hole by checking if `src_buf` is still NULL while `frag_lenght` is not zero, and adjust transfer result accordingly. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/16 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH 0/9] scan-build fixes
by Alex Henrie 28 Dec '20

28 Dec '20

These defects were identified by scan-build <https://clang-analyzer.llvm.org/scan-build.html>. I hope that drawing attention to the problems helps even if you decide to fix some of them in different ways than I am proposing. Happy holidays! -Alex Alex Henrie (9): conf: fix use after free in _snd_config_load_with_include ucm: fix bad frees in get_list0 and get_list20 rawmidi: fix memory leak in snd_rawmidi_virtual_open confmisc: fix memory leak in snd_func_concat timer: fix sizeof operator mismatch in snd_timer_query_hw_open pcm: remove dead assignments from snd_pcm_rate_(commit_area|grab_next_period) pcm_multi: remove dead assignment from _snd_pcm_multi_open pcm: fix undefined bit shift in bad_pcm_state conf: remove dead code from get_hexachar include/pcm.h | 4 +++- src/conf.c | 13 ++++--------- src/confmisc.c | 2 +- src/pcm/pcm.c | 2 ++ src/pcm/pcm_local.h | 2 +- src/pcm/pcm_multi.c | 1 - src/pcm/pcm_rate.c | 2 -- src/rawmidi/rawmidi_virt.c | 3 ++- src/timer/timer_query_hw.c | 2 +- src/ucm/main.c | 4 ++-- 10 files changed, 16 insertions(+), 19 deletions(-) -- 2.29.2.368.ge46b91665e.dirty

3 23

[PATCH] ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad E14 Gen 2
by Jaroslav Kysela 27 Dec '20

27 Dec '20

The ThinkPad E14 Gen 2 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec. Use DMI to block the microphone PCM device for this platform. Reported-by: Eliot Blennerhassett <eliot(a)blennerhassett.gen.nz> Cc: <stable(a)kernel.org> Cc: Mark Brown <broonie(a)kernel.org> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/soc/amd/renoir/rn-pci-acp3x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index fa169bf09886..749e520eaca9 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -169,6 +169,11 @@ static const struct dmi_system_id rn_acp_quirk_table[] = { .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "LNVNB161216"), + }, + /* Lenovo ThinkPad E14 Gen 2 */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"), } }, {} -- 2.29.2

2 1

Re: [PATCH] docs: Fix reST markup when linking to sections
by Mauro Carvalho Chehab 27 Dec '20

27 Dec '20

Em Sat, 26 Dec 2020 13:18:58 +0000 Nícolas F. R. A. Prado <nfraprado(a)protonmail.com> escreveu: > During the process of converting the documentation to reST, some links > were converted using the following wrong syntax (and sometimes using %20 > instead of spaces): > The patch itself looks ok, although the description has an issue (IMHO). Also, some references can be cleaned. See below. > `Display text <#section-name-in-html>`__ > > This syntax can work in html, but isn't the one described in docutils, Well, docutils define two types of references at: https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#referenc… The first one are "simple reference names", defined as: ``Simple reference names are single words consisting of alphanumerics plus isolated (no two adjacent) internal hyphens, underscores, periods, colons and plus signs; no whitespace or other characters are allowed.`` On this type, "-_.,+" characters are allowed. "%" and "#" aren't. The second one is "phrase-references", defined as: ``Reference names using punctuation or whose names are phrases (two or more space-separated words) are called "phrase-references".`` Here, the spec doesn't specify the charset associated with "punctuation". As this kind of reference is auto-generated from the chapter titles, I would expect it to allow all ASCII punctuation characters (e. g. all non-alphanumeric symbols between 0x20-0x7f). So, a reference like those: #Summary #Forcing%20Quiescent%20States Violates the spec, as it would be a simple reference with invalid chars, but: #Forcing Quiescent States Should be valid, according with the spec (still, while doing such cleanup, I would remove "#"). I would add something like the above at the patch description. > and it also doesn't work on pdf. The following syntax should be used > instead: > > `Display text <Section Name_>`__ > > The usual toolchain doesn't mind this unusual syntax, but it causes > errors when trying to build using the not-yet-merged rst2pdf: > > ValueError: format not resolved, probably missing URL scheme or undefined destination target for 'Forcing%20Quiescent%20States' > > Fixes: ccc9971e2147 ("docs: rcu: convert some articles from html to ReST") > Fixes: c8cce10a62aa ("docs: Fix the reference labels in Locking.rst") > Fixes: e548cdeffcd8 ("docs-rst: convert kernel-locking to ReST") > Fixes: 7ddedebb03b7 ("ALSA: doc: ReSTize writing-an-alsa-driver document") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado(a)protonmail.com> ... > @@ -596,7 +596,7 @@ maintain ordering. For example, if the callback function wakes up a task > that runs on some other CPU, proper ordering must in place in both the > callback function and the task being awakened. To see why this is > important, consider the top half of the `grace-period > -cleanup <#Grace-Period%20Cleanup>`__ diagram. The callback might be > +cleanup <Grace-Period Cleanup_>`__ diagram. The callback might be > running on a CPU corresponding to the leftmost leaf ``rcu_node`` > structure, and awaken a task that is to run on a CPU corresponding to > the rightmost leaf ``rcu_node`` structure, and the grace-period kernel > diff --git a/Documentation/RCU/Design/Requirements/Requirements.rst b/Documentation/RCU/Design/Requirements/Requirements.rst > index 1ae79a10a8de..d4125caf394e 100644 > --- a/Documentation/RCU/Design/Requirements/Requirements.rst > +++ b/Documentation/RCU/Design/Requirements/Requirements.rst > @@ -45,7 +45,7 @@ requirements: > #. `Other RCU Flavors`_ > #. `Possible Future Changes`_ > > -This is followed by a `summary <#Summary>`__, however, the answers to > +This is followed by a `summary <Summary_>`__, however, the answers to Hmm... why are you ending "Summary" with a "_"? This should be equivalent to: `summary <summary>`__ In this specific case, however, you could use, instead[1]: summary_ as there's no need to use an indirect hyperlink target here. (the same applies to a few other similar cases on your patch) [1] https://docutils.sourceforge.io/docs/user/rst/quickref.html#hyperlink-targe… Thanks, Mauro

2 1

[PATCH] ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad X395
by Jaroslav Kysela 27 Dec '20

27 Dec '20

The ThinkPad X395 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec. Use DMI to block the microphone PCM device for this platform. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1892115 Cc: <stable(a)kernel.org> Cc: Mark Brown <broonie(a)kernel.org> Signed-off-by: Jaroslav Kysela <perex(a)perex.cz> --- sound/soc/amd/renoir/rn-pci-acp3x.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c b/sound/soc/amd/renoir/rn-pci-acp3x.c index 749e520eaca9..a2993696e600 100644 --- a/sound/soc/amd/renoir/rn-pci-acp3x.c +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c @@ -174,6 +174,11 @@ static const struct dmi_system_id rn_acp_quirk_table[] = { .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "20T6CTO1WW"), + }, + /* Lenovo ThinkPad X395 */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"), } }, {} -- 2.29.2

1 0

Re: [PATCH] docs: Fix reST markup when linking to sections
by Takashi Iwai 27 Dec '20

27 Dec '20

On Sat, 26 Dec 2020 14:18:58 +0100, Nícolas F. R. A. Prado wrote: > > During the process of converting the documentation to reST, some links > were converted using the following wrong syntax (and sometimes using %20 > instead of spaces): > > `Display text <#section-name-in-html>`__ > > This syntax can work in html, but isn't the one described in docutils, > and it also doesn't work on pdf. The following syntax should be used > instead: > > `Display text <Section Name_>`__ > > The usual toolchain doesn't mind this unusual syntax, but it causes > errors when trying to build using the not-yet-merged rst2pdf: > > ValueError: format not resolved, probably missing URL scheme or undefined destination target for 'Forcing%20Quiescent%20States' > > Fixes: ccc9971e2147 ("docs: rcu: convert some articles from html to ReST") > Fixes: c8cce10a62aa ("docs: Fix the reference labels in Locking.rst") > Fixes: e548cdeffcd8 ("docs-rst: convert kernel-locking to ReST") > Fixes: 7ddedebb03b7 ("ALSA: doc: ReSTize writing-an-alsa-driver document") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado(a)protonmail.com> For the sound part: Reviewed-by: Takashi Iwai <tiwai(a)suse.de> thanks, Takashi

1 0

No sound from speakers, only headphones working
by Слава Банщиков 25 Dec '20

25 Dec '20

Here is the output from alsa-info.sh http://alsa-project.org/db/?f=ba0e450b747066e59c76642aa3c9f15a9a9f8a0b

1 0

[PATCH 01/18] ALSA: core: Use DIV_ROUND_UP() instead of open-coding it
by Lars-Peter Clausen 25 Dec '20

25 Dec '20

Use DIV_ROUND_UP() instead of open-coding it. This documents intent and makes it more clear what is going on for the casual reviewer. Generated using the following the Coccinelle semantic patch. // <smpl> @@ expression x, y; @@ -(((x) + (y) - 1) / (y)) +DIV_ROUND_UP(x, y) // </smpl> Signed-off-by: Lars-Peter Clausen <lars(a)metafoo.de> --- sound/core/control.c | 4 ++-- sound/core/seq/seq_memory.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/core/control.c b/sound/core/control.c index 3b44378b9dec..1571c7f7c43b 100644 --- a/sound/core/control.c +++ b/sound/core/control.c @@ -836,7 +836,7 @@ static void fill_remaining_elem_value(struct snd_ctl_elem_value *control, { size_t offset = value_sizes[info->type] * info->count; - offset = (offset + sizeof(u32) - 1) / sizeof(u32); + offset = DIV_ROUND_UP(offset, sizeof(u32)); memset32((u32 *)control->value.bytes.data + offset, pattern, sizeof(control->value) / sizeof(u32) - offset); } @@ -928,7 +928,7 @@ static int sanity_check_elem_value(struct snd_card *card, /* check whether the remaining area kept untouched */ offset = value_sizes[info->type] * info->count; - offset = (offset + sizeof(u32) - 1) / sizeof(u32); + offset = DIV_ROUND_UP(offset, sizeof(u32)); p = (u32 *)control->value.bytes.data + offset; for (; offset < sizeof(control->value) / sizeof(u32); offset++, p++) { if (*p != pattern) { diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c index 65db1a7c77b7..e245bb6ba533 100644 --- a/sound/core/seq/seq_memory.c +++ b/sound/core/seq/seq_memory.c @@ -290,7 +290,7 @@ int snd_seq_event_dup(struct snd_seq_pool *pool, struct snd_seq_event *event, extlen = 0; if (snd_seq_ev_is_variable(event)) { extlen = event->data.ext.len & ~SNDRV_SEQ_EXT_MASK; - ncells = (extlen + sizeof(struct snd_seq_event) - 1) / sizeof(struct snd_seq_event); + ncells = DIV_ROUND_UP(extlen, sizeof(struct snd_seq_event)); } if (ncells >= pool->total_elements) return -ENOMEM; -- 2.20.1

2 18

[PATCH] ALSA: pcm: use bit field on snd_pcm
by Kuninori Morimoto 25 Dec '20

25 Dec '20

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> snd_pcm's internal, nonatomic, no_device_suspend are defined as bool. But we can reduce struct size if we use bit field for these. This patch converts these. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- include/sound/pcm.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/sound/pcm.h b/include/sound/pcm.h index 2336bf9243e1..e836741d2708 100644 --- a/include/sound/pcm.h +++ b/include/sound/pcm.h @@ -520,12 +520,13 @@ struct snd_pcm { wait_queue_head_t open_wait; void *private_data; void (*private_free) (struct snd_pcm *pcm); - bool internal; /* pcm is for internal use only */ - bool nonatomic; /* whole PCM operations are in non-atomic context */ - bool no_device_suspend; /* don't invoke device PM suspend */ #if IS_ENABLED(CONFIG_SND_PCM_OSS) struct snd_pcm_oss oss; #endif + /* bit field */ + unsigned int internal:1; /* pcm is for internal use only */ + unsigned int nonatomic:1; /* whole PCM operations are in non-atomic context */ + unsigned int no_device_suspend:1; /* don't invoke device PM suspend */ }; /* -- 2.25.1

2 1