October 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [asoc:for-4.20 333/487] sound/pci//hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?
by kbuild test robot 09 Oct '18

09 Oct '18

Hi Rakesh, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-4.20 head: 24ae67c5825004bcbce90e7c89fed63f25d96260 commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 [333/487] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 6bae5ea9498926440ffc883f3dbceb0adc65e492 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All errors (new ones prefixed by >>): sound/pci//hda/patch_ca0132.c: In function 'patch_ca0132': >> sound/pci//hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? [-Werror=implicit-function-declaration] spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); ^~~~~~~~~ pcim_iomap sound/pci//hda/patch_ca0132.c:7650:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); ^ cc1: some warnings being treated as errors vim +7650 sound/pci//hda/patch_ca0132.c d5c016b56 Gabriele Martino 2015-05-18 7581 95c6e9cb7 Ian Minett 2011-06-15 7582 static int patch_ca0132(struct hda_codec *codec) 95c6e9cb7 Ian Minett 2011-06-15 7583 { 95c6e9cb7 Ian Minett 2011-06-15 7584 struct ca0132_spec *spec; a73d511c4 Ian Minett 2012-12-20 7585 int err; d5c016b56 Gabriele Martino 2015-05-18 7586 const struct snd_pci_quirk *quirk; 95c6e9cb7 Ian Minett 2011-06-15 7587 4e76a8833 Takashi Iwai 2014-02-25 7588 codec_dbg(codec, "patch_ca0132\n"); 95c6e9cb7 Ian Minett 2011-06-15 7589 95c6e9cb7 Ian Minett 2011-06-15 7590 spec = kzalloc(sizeof(*spec), GFP_KERNEL); 95c6e9cb7 Ian Minett 2011-06-15 7591 if (!spec) 95c6e9cb7 Ian Minett 2011-06-15 7592 return -ENOMEM; 95c6e9cb7 Ian Minett 2011-06-15 7593 codec->spec = spec; 993884f6a Chih-Chung Chang 2013-03-25 7594 spec->codec = codec; 95c6e9cb7 Ian Minett 2011-06-15 7595 225068ab2 Takashi Iwai 2015-05-29 7596 codec->patch_ops = ca0132_patch_ops; 225068ab2 Takashi Iwai 2015-05-29 7597 codec->pcm_format_first = 1; 225068ab2 Takashi Iwai 2015-05-29 7598 codec->no_sticky_stream = 1; 225068ab2 Takashi Iwai 2015-05-29 7599 d5c016b56 Gabriele Martino 2015-05-18 7600 /* Detect codec quirk */ d5c016b56 Gabriele Martino 2015-05-18 7601 quirk = snd_pci_quirk_lookup(codec->bus->pci, ca0132_quirks); d5c016b56 Gabriele Martino 2015-05-18 7602 if (quirk) d5c016b56 Gabriele Martino 2015-05-18 7603 spec->quirk = quirk->value; d5c016b56 Gabriele Martino 2015-05-18 7604 else d5c016b56 Gabriele Martino 2015-05-18 7605 spec->quirk = QUIRK_NONE; d5c016b56 Gabriele Martino 2015-05-18 7606 e24aa0a4c Takashi Iwai 2014-08-10 7607 spec->dsp_state = DSP_DOWNLOAD_INIT; a7e76271b Ian Minett 2012-12-20 7608 spec->num_mixers = 1; 017310fbe Connor McAdams 2018-05-08 7609 017310fbe Connor McAdams 2018-05-08 7610 /* Set which mixers each quirk uses. */ 017310fbe Connor McAdams 2018-05-08 7611 switch (spec->quirk) { 017310fbe Connor McAdams 2018-05-08 7612 case QUIRK_SBZ: e25e34450 Connor McAdams 2018-08-08 7613 spec->mixers[0] = desktop_mixer; 017310fbe Connor McAdams 2018-05-08 7614 snd_hda_codec_set_name(codec, "Sound Blaster Z"); 017310fbe Connor McAdams 2018-05-08 7615 break; e25e34450 Connor McAdams 2018-08-08 7616 case QUIRK_R3D: e25e34450 Connor McAdams 2018-08-08 7617 spec->mixers[0] = desktop_mixer; e25e34450 Connor McAdams 2018-08-08 7618 snd_hda_codec_set_name(codec, "Recon3D"); e25e34450 Connor McAdams 2018-08-08 7619 break; 017310fbe Connor McAdams 2018-05-08 7620 case QUIRK_R3DI: 017310fbe Connor McAdams 2018-05-08 7621 spec->mixers[0] = r3di_mixer; 017310fbe Connor McAdams 2018-05-08 7622 snd_hda_codec_set_name(codec, "Recon3Di"); 017310fbe Connor McAdams 2018-05-08 7623 break; 017310fbe Connor McAdams 2018-05-08 7624 default: a7e76271b Ian Minett 2012-12-20 7625 spec->mixers[0] = ca0132_mixer; 017310fbe Connor McAdams 2018-05-08 7626 break; 017310fbe Connor McAdams 2018-05-08 7627 } a7e76271b Ian Minett 2012-12-20 7628 08eca6b1f Connor McAdams 2018-08-08 7629 /* Setup whether or not to use alt functions/controls/pci_mmio */ 009b8f979 Connor McAdams 2018-05-08 7630 switch (spec->quirk) { 009b8f979 Connor McAdams 2018-05-08 7631 case QUIRK_SBZ: e42c7c731 Connor McAdams 2018-08-08 7632 case QUIRK_R3D: 08eca6b1f Connor McAdams 2018-08-08 7633 spec->use_alt_controls = true; 08eca6b1f Connor McAdams 2018-08-08 7634 spec->use_alt_functions = true; 08eca6b1f Connor McAdams 2018-08-08 7635 spec->use_pci_mmio = true; 08eca6b1f Connor McAdams 2018-08-08 7636 break; 009b8f979 Connor McAdams 2018-05-08 7637 case QUIRK_R3DI: 47cdf76e4 Connor McAdams 2018-05-08 7638 spec->use_alt_controls = true; 009b8f979 Connor McAdams 2018-05-08 7639 spec->use_alt_functions = true; 08eca6b1f Connor McAdams 2018-08-08 7640 spec->use_pci_mmio = false; 009b8f979 Connor McAdams 2018-05-08 7641 break; 009b8f979 Connor McAdams 2018-05-08 7642 default: 47cdf76e4 Connor McAdams 2018-05-08 7643 spec->use_alt_controls = false; 009b8f979 Connor McAdams 2018-05-08 7644 spec->use_alt_functions = false; 08eca6b1f Connor McAdams 2018-08-08 7645 spec->use_pci_mmio = false; 009b8f979 Connor McAdams 2018-05-08 7646 break; 009b8f979 Connor McAdams 2018-05-08 7647 } 009b8f979 Connor McAdams 2018-05-08 7648 08eca6b1f Connor McAdams 2018-08-08 7649 if (spec->use_pci_mmio) { 08eca6b1f Connor McAdams 2018-08-08 @7650 spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); 08eca6b1f Connor McAdams 2018-08-08 7651 if (spec->mem_base == NULL) { 08eca6b1f Connor McAdams 2018-08-08 7652 codec_warn(codec, "pci_iomap failed! Setting quirk to QUIRK_NONE."); 08eca6b1f Connor McAdams 2018-08-08 7653 spec->quirk = QUIRK_NONE; 08eca6b1f Connor McAdams 2018-08-08 7654 } 08eca6b1f Connor McAdams 2018-08-08 7655 } 08eca6b1f Connor McAdams 2018-08-08 7656 5aaca44d8 Ian Minett 2012-12-20 7657 spec->base_init_verbs = ca0132_base_init_verbs; 5aaca44d8 Ian Minett 2012-12-20 7658 spec->base_exit_verbs = ca0132_base_exit_verbs; 5aaca44d8 Ian Minett 2012-12-20 7659 993884f6a Chih-Chung Chang 2013-03-25 7660 INIT_DELAYED_WORK(&spec->unsol_hp_work, ca0132_unsol_hp_delayed); 993884f6a Chih-Chung Chang 2013-03-25 7661 95c6e9cb7 Ian Minett 2011-06-15 7662 ca0132_init_chip(codec); 95c6e9cb7 Ian Minett 2011-06-15 7663 95c6e9cb7 Ian Minett 2011-06-15 7664 ca0132_config(codec); 95c6e9cb7 Ian Minett 2011-06-15 7665 d5c016b56 Gabriele Martino 2015-05-18 7666 err = ca0132_prepare_verbs(codec); d5c016b56 Gabriele Martino 2015-05-18 7667 if (err < 0) cc91ceaf3 Takashi Iwai 2017-09-04 7668 goto error; d5c016b56 Gabriele Martino 2015-05-18 7669 a73d511c4 Ian Minett 2012-12-20 7670 err = snd_hda_parse_pin_def_config(codec, &spec->autocfg, NULL); a73d511c4 Ian Minett 2012-12-20 7671 if (err < 0) cc91ceaf3 Takashi Iwai 2017-09-04 7672 goto error; a73d511c4 Ian Minett 2012-12-20 7673 95c6e9cb7 Ian Minett 2011-06-15 7674 return 0; cc91ceaf3 Takashi Iwai 2017-09-04 7675 cc91ceaf3 Takashi Iwai 2017-09-04 7676 error: cc91ceaf3 Takashi Iwai 2017-09-04 7677 ca0132_free(codec); cc91ceaf3 Takashi Iwai 2017-09-04 7678 return err; 95c6e9cb7 Ian Minett 2011-06-15 7679 } 95c6e9cb7 Ian Minett 2011-06-15 7680 :::::: The code at line 7650 was first introduced by commit :::::: 08eca6b1f1468a4021bac7b3929fd3eb491e2629 ALSA: hda/ca0132 - Add bool variable to enable/disable pci region2 mmio :::::: TO: Connor McAdams <conmanx360(a)gmail.com> :::::: CC: Takashi Iwai <tiwai(a)suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] [PATCH][RFC][alsa-utils 0/9] alsactl: monitor mode friendly for
by Takashi Sakamoto 09 Oct '18

09 Oct '18

Hi, A command of 'alsactl' has 'monitor' mode to print events emitted by observed control nodes. This mode is not friendly for plug-and-play devices. A bug is reported that the mode consumes 100% of CPU time when detecting disconnection of observed sound card[1]. A process of alsactl doesn't release ALSA control character device at disconnection. This is quite bad in a view of system. Furthermore, this mode cannot handle control nodes for newly-detected sound card. This patchset is my attempt to improve the mode to handle disconnection of observed sound card and new detection of sound card. A rough summary of this patchset: - maintains observed control nodes by link-list - uses epoll(7) instead of poll(2) to avoid following the list every time of poll loop, - control node for disconnected sound card is not observed anymore and dropped from the list. - the list is rescan and observation is updated when detecting new sound card. Linux-specific inotify(7) is used for this purpose. I'm happy if receiving test reports and indication of new bugs. [1] [alsa-devel] alsactl monitor spins at 100% cpu after unplugging USB headphones http://mailman.alsa-project.org/pipermail/alsa-devel/2018-September/140580.… Takashi Sakamoto (9): alsactl: install signal handler alsactl: split event loop code to a function alsactl: add an iterator of registered instances of sound card alsactl: use epoll(7) instead of poll(2) alsactl: use link list to maintain source of events alsactl: use a list of source for event dispatcher instead of an array of source alsactl: obsolete array for maintenance of handlers alsactl: handle disconnection of sound card alsactl: handle detection of new sound card alsactl/monitor.c | 403 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 356 insertions(+), 47 deletions(-) -- 2.19.0

3 15

[alsa-devel] Applied "ASoC: max98988: make it selectable" to the asoc tree
by Mark Brown 08 Oct '18

08 Oct '18

The patch ASoC: max98988: make it selectable has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 24ae67c5825004bcbce90e7c89fed63f25d96260 Mon Sep 17 00:00:00 2001 From: Marco Felsch <m.felsch(a)pengutronix.de> Date: Fri, 5 Oct 2018 09:58:12 +0200 Subject: [PATCH] ASoC: max98988: make it selectable Currently the driver will build only if SND_SOC_ALL_CODECS is set. Adding a Kconfig menu description to build the driver standalone. Signed-off-by: Marco Felsch <m.felsch(a)pengutronix.de> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 9989d35e0fc6..3c6bd6019b92 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -640,7 +640,7 @@ config SND_SOC_LM49453 tristate config SND_SOC_MAX98088 - tristate + tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec" config SND_SOC_MAX98090 tristate -- 2.19.0

1 0

[alsa-devel] [PATCH 00/11] Add ZxR support + bugfixes
by Connor McAdams 08 Oct '18

08 Oct '18

This patch series adds support for the Sound Blaster ZxR, as well as a few bug fixes. This should be the last ca0132 based Creative card that needed support to be added. Also, I did check to make sure each patch compiles properly this time, but you can check yourself just to be sure. :) Connor McAdams (11): ALSA: hda/ca0132 - Fix AE-5 control type ALSA: hda/ca0132 - Fix surround sound with output effects ALSA: hda/ca0132 - Add ZxR quirks + new quirk check function ALSA: hda/ca0132 - Add ZxR pincfg ALSA: hda/ca0132 - Add DBpro hda_codec_ops ALSA: hda/ca0132 - Add ZxR init commands ALSA: hda/ca0132 - Add ZxR DSP post-download commands ALSA: hda/ca0132 - Add ZxR input/output select commands ALSA: hda/ca0132 - Remove input select enum for ZxR ALSA: hda/ca0132 - Add ZxR 600 ohm gain control ALSA: hda/ca0132 - Add ZxR exit commands sound/pci/hda/patch_ca0132.c | 369 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 345 insertions(+), 24 deletions(-) -- 2.7.4

3 17

[alsa-devel] [PATCH 1/2] ASoC: Add device tree documentation file for wm8782 stereo DAC
by Daniel Mack 08 Oct '18

08 Oct '18

Add a device tree documentation file for the wm8782 stereo DAC to describe the regulator handles. Signed-off-by: Daniel Mack <daniel(a)zonque.org> --- .../devicetree/bindings/sound/wm8782.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/wm8782.txt diff --git a/Documentation/devicetree/bindings/sound/wm8782.txt b/Documentation/devicetree/bindings/sound/wm8782.txt new file mode 100644 index 000000000000..256cdec6ec4d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/wm8782.txt @@ -0,0 +1,17 @@ +WM8782 stereo ADC + +This device does not have any control interface or reset pins. + +Required properties: + + - compatible : "wlf,wm8782" + - Vdda-supply : phandle to a regulator for the analog power supply (2.7V - 5.5V) + - Vdd-supply : phandle to a regulator for the digital power supply (2.7V - 3.6V) + +Example: + +wm8782: stereo-adc { + compatible = "wlf,wm8782"; + Vdda-supply = <&vdda_supply>; + Vdd-supply = <&vdd_supply>; +}; -- 2.17.1

3 6

Re: [alsa-devel] Microphone detected, but no output for all ASUS G751xx with ALC668 chipset
by Connor McAdams 08 Oct '18

08 Oct '18

I might not get around to writing the fix myself, but, here's the COEF's from within Windows. I've marked the ones missing inside the main init function. So, if anyone else wants to add these in, feel free. On Wed, Sep 12, 2018 at 1:16 PM, Håvard <hovardslill(a)gmail.com> wrote: > That was without running the program (sorry) > > This is output when running program: > > Before there was no "Current verb...." > They came when I opened up windows microphone settings. (something I didn't > do before) > > -Håvard > > Den ons. 12. sep. 2018 kl. 19:11 skrev Håvard <hovardslill(a)gmail.com>: >> >> I think this is right! >> >> I first booted up, then tested speakers (That I could not hear) and then >> tested microphone (Which worked perfectly) in windows settings. >> >> (My first email was dissaproved as it was too large) >> >> Den ons. 12. sep. 2018 kl. 19:05 skrev Håvard <hovardslill(a)gmail.com>: >>> >>> I think this is right! >>> >>> I first booted up, then tested speakers (That I could not hear) and then >>> tested microphone (Which worked perfectly) in windows settings. >>> >>> -Håvard >>> >>> Den ons. 12. sep. 2018 kl. 18:49 skrev Connor McAdams >>> <conmanx360(a)gmail.com>: >>>> >>>> Also, sorry to keep sending more replies, make sure the only trace you >>>> have on is vfio_region_write, and not the read one. The read spams up >>>> the console. >>>> >>>> On Wed, Sep 12, 2018 at 12:43 PM, Connor McAdams <conmanx360(a)gmail.com> >>>> wrote: >>>> > Reason being, it may not have identified the CORB buffer properly or >>>> > something. That's very odd to have no data. Never seen that before. >>>> > >>>> > On Wed, Sep 12, 2018 at 12:42 PM, Connor McAdams >>>> > <conmanx360(a)gmail.com> wrote: >>>> >> Could you try again and make a copy of your terminal output? >>>> >> >>>> >> On Wed, Sep 12, 2018 at 12:41 PM, Håvard <hovardslill(a)gmail.com> >>>> >> wrote: >>>> >>> Hi again. >>>> >>> Sorry for not noticing all files were empty, did it not run for long >>>> >>> enough? >>>> >>> >>>> >>> -Håvard >>>> >>> >>>> >>> Den ons. 12. sep. 2018 kl. 18:39 skrev Håvard >>>> >>> <hovardslill(a)gmail.com>: >>>> >>>> >>>> >>>> Sorry my bad again it was working perfectly, just missed a step. >>>> >>>> >>>> >>>> I'll add the dumps as an attatchment. I had both external headset >>>> >>>> and >>>> >>>> microphone plugged in and let the VM run in the background for >>>> >>>> ~30min while >>>> >>>> doing other stuff. I did not play music or test my microphone in >>>> >>>> the VM >>>> >>>> either, If i did anything wrong, please tell me! >>>> >>>> >>>> >>>> It stopped at 0x104f4 >>>> >>>> >>>> >>>> -Håvard >>>> >>>> >>>> >>>> Den ons. 12. sep. 2018 kl. 00:31 skrev Connor McAdams >>>> >>>> <conmanx360(a)gmail.com>: >>>> >>>>> >>>> >>>>> Hm.... that's odd. They should show up in the folder you ran the >>>> >>>>> command from. Does your console show any "DumpMem entered..." or >>>> >>>>> something like that? You may have a permissions error. I've had >>>> >>>>> some >>>> >>>>> people report that as an issue before. >>>> >>>>> >>>> >>>>> On Tue, Sep 11, 2018 at 5:08 PM, Håvard <hovardslill(a)gmail.com> >>>> >>>>> wrote: >>>> >>>>> > Hi! >>>> >>>>> > >>>> >>>>> > Took a while, but I think I got it working. Did not see any >>>> >>>>> > "frame[xx]" >>>> >>>>> > files though. What dumps do you want? >>>> >>>>> > >>>> >>>>> > -Håvard >>>> >>>>> > >>>> >>>>> > Den tir. 11. sep. 2018 kl. 21:27 skrev Håvard >>>> >>>>> > <hovardslill(a)gmail.com>: >>>> >>>>> >> >>>> >>>>> >> Sorry about that, I forgot to enable a kernel config... >>>> >>>>> >> >>>> >>>>> >> -Håvard >>>> >>>>> >> >>>> >>>>> >> Den tir. 11. sep. 2018 kl. 21:20 skrev Connor McAdams >>>> >>>>> >> <conmanx360(a)gmail.com>: >>>> >>>>> >>> >>>> >>>>> >>> When it's bound as a stub, it shouldn't show up in alsamixer >>>> >>>>> >>> controls. >>>> >>>>> >>> You can check what module is loaded by doing lspci -v . It >>>> >>>>> >>> should say >>>> >>>>> >>> kernel driver in use: pci-stub. Also, did you run the >>>> >>>>> >>> vfio-bind >>>> >>>>> >>> script >>>> >>>>> >>> before trying it? >>>> >>>>> >>> >>>> >>>>> >>> On Tue, Sep 11, 2018 at 3:18 PM, Håvard >>>> >>>>> >>> <hovardslill(a)gmail.com> >>>> >>>>> >>> wrote: >>>> >>>>> >>> > Thank you for the offer! >>>> >>>>> >>> > >>>> >>>>> >>> > I run gentoo, but your github guide is very useful. I can't >>>> >>>>> >>> > seem to >>>> >>>>> >>> > bind my >>>> >>>>> >>> > audio driver to a pci-stud. Is the Sound card still supposed >>>> >>>>> >>> > to >>>> >>>>> >>> > function as >>>> >>>>> >>> > normal when I (think I) have bound it to a stud. >>>> >>>>> >>> > >>>> >>>>> >>> > -Håvard >>>> >>>>> >>> > >>>> >>>>> >>> > Den tir. 11. sep. 2018 kl. 20:26 skrev Connor McAdams >>>> >>>>> >>> > <conmanx360(a)gmail.com>: >>>> >>>>> >>> >> >>>> >>>>> >>> >> One thing you could try, is using the program I used to >>>> >>>>> >>> >> reverse >>>> >>>>> >>> >> engineer the Sound Blaster Z series of cards, QemuHDADump. >>>> >>>>> >>> >> If your >>>> >>>>> >>> >> processor supports pci-passthrough with a virtual machine, >>>> >>>>> >>> >> you >>>> >>>>> >>> >> could >>>> >>>>> >>> >> run a Windows virtual machine with the sound card in it and >>>> >>>>> >>> >> capture >>>> >>>>> >>> >> the commands. I'd be willing to look through the dumps to >>>> >>>>> >>> >> see if >>>> >>>>> >>> >> there >>>> >>>>> >>> >> are any special verbs or anything. >>>> >>>>> >>> >> >>>> >>>>> >>> >> You can find the program here: >>>> >>>>> >>> >> https://github.com/Conmanx360/QemuHDADump >>>> >>>>> >>> >> >>>> >>>>> >>> >> Let me know. >>>> >>>>> >>> >> >>>> >>>>> >>> >> On Tue, Sep 11, 2018 at 2:15 PM, Håvard >>>> >>>>> >>> >> <hovardslill(a)gmail.com> >>>> >>>>> >>> >> wrote: >>>> >>>>> >>> >> > Sorry, my gmail didn't update so I wrote my response >>>> >>>>> >>> >> > before I >>>> >>>>> >>> >> > read >>>> >>>>> >>> >> > your >>>> >>>>> >>> >> > last one. >>>> >>>>> >>> >> > >>>> >>>>> >>> >> > It is a separate mic port as the G751JT doesn't have any >>>> >>>>> >>> >> > headset >>>> >>>>> >>> >> > multijacks. >>>> >>>>> >>> >> > >>>> >>>>> >>> >> > I'll try and dig around in the kernel! Thanks for the >>>> >>>>> >>> >> > tip! >>>> >>>>> >>> >> > >>>> >>>>> >>> >> > -Håvard >>>> >>>>> >>> >> > >>>> >>>>> >>> >> > Den tir. 11. sep. 2018 kl. 20:09 skrev Håvard >>>> >>>>> >>> >> > <hovardslill(a)gmail.com>: >>>> >>>>> >>> >> > >>>> >>>>> >>> >> >> Thank you for taking your time and trying to help! :) >>>> >>>>> >>> >> >> >>>> >>>>> >>> >> >> Do you know where I can ask around for more help on the >>>> >>>>> >>> >> >> issue? >>>> >>>>> >>> >> >> I >>>> >>>>> >>> >> >> don't >>>> >>>>> >>> >> >> want to give up yet. >>>> >>>>> >>> >> >> >>>> >>>>> >>> >> >> -Håvard >>>> >>>>> >>> >> >> >>>> >>>>> >>> >> >> Den tir. 11. sep. 2018 kl. 20:02 skrev Takashi Iwai >>>> >>>>> >>> >> >> <tiwai(a)suse.de>: >>>> >>>>> >>> >> >> >>>> >>>>> >>> >> >>> On Tue, 11 Sep 2018 19:14:37 +0200, >>>> >>>>> >>> >> >>> Håvard wrote: >>>> >>>>> >>> >> >>> > >>>> >>>>> >>> >> >>> > Yes, microphone gets detected instantly and it >>>> >>>>> >>> >> >>> > automatically >>>> >>>>> >>> >> >>> > changes >>>> >>>>> >>> >> >>> > to >>>> >>>>> >>> >> >>> it >>>> >>>>> >>> >> >>> > in pavucontrol. >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> Then it likely requires some additional initialization >>>> >>>>> >>> >> >>> outside >>>> >>>>> >>> >> >>> HD-audio. It's hard to know, as it's pretty much >>>> >>>>> >>> >> >>> vendor-specific. >>>> >>>>> >>> >> >>> You can dig down the Windows, but I have no idea about >>>> >>>>> >>> >> >>> Windows >>>> >>>>> >>> >> >>> implementation, so can't give any hints, unfortunately. >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> Takashi >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> > >>>> >>>>> >>> >> >>> > Den tir. 11. sep. 2018 kl. 18:52 skrev Takashi Iwai >>>> >>>>> >>> >> >>> > <tiwai(a)suse.de>: >>>> >>>>> >>> >> >>> > >>>> >>>>> >>> >> >>> > > On Tue, 11 Sep 2018 18:40:23 +0200, >>>> >>>>> >>> >> >>> > > Håvard wrote: >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > Thank you for replying! >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > Enabling loopback in alsamixer: >>>> >>>>> >>> >> >>> > > > http://i.imgur.com/lNo6e7T.png >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > And unmuting more and more things in "Mic >>>> >>>>> >>> >> >>> > > > Playback >>>> >>>>> >>> >> >>> > > > Volume" >>>> >>>>> >>> >> >>> > > > in >>>> >>>>> >>> >> >>> > > hdaanalyzer: >>>> >>>>> >>> >> >>> > > > http://i.imgur.com/H0HiOhy.png >>>> >>>>> >>> >> >>> > > > made white noise come from the headset. However >>>> >>>>> >>> >> >>> > > > it did >>>> >>>>> >>> >> >>> > > > not >>>> >>>>> >>> >> >>> > > > change or >>>> >>>>> >>> >> >>> > > react >>>> >>>>> >>> >> >>> > > > at all when I talked or even muted the microphone >>>> >>>>> >>> >> >>> > > > physically. >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > I couldn't find "Mic Playback Switch" anywhere in >>>> >>>>> >>> >> >>> > > > either >>>> >>>>> >>> >> >>> > > > alsamixer >>>> >>>>> >>> >> >>> or >>>> >>>>> >>> >> >>> > > > hdaanalyzer. >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > It's a mixer mute switch. >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > > The microphone works perfectly fine under >>>> >>>>> >>> >> >>> > > > Windows, so I >>>> >>>>> >>> >> >>> > > > don't >>>> >>>>> >>> >> >>> > > > think >>>> >>>>> >>> >> >>> it is >>>> >>>>> >>> >> >>> > > > the mic pin. >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > But the fact above indicates the possibility of the >>>> >>>>> >>> >> >>> > > wrong >>>> >>>>> >>> >> >>> > > pin, >>>> >>>>> >>> >> >>> > > too. >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > Does the jack detection of the ext mic pin work? >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > Takashi >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > -Håvard >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > Den man. 10. sep. 2018 kl. 22:39 skrev Takashi >>>> >>>>> >>> >> >>> > > > Iwai >>>> >>>>> >>> >> >>> > > > <tiwai(a)suse.de >>>> >>>>> >>> >> >>> >: >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > > > On Thu, 06 Sep 2018 20:44:30 +0200, >>>> >>>>> >>> >> >>> > > > > Håvard wrote: >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > Additional relevant info: >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > A similar issue was also discussed three >>>> >>>>> >>> >> >>> > > > > > years ago >>>> >>>>> >>> >> >>> > > > > > on >>>> >>>>> >>> >> >>> > > > > > Sun >>>> >>>>> >>> >> >>> > > > > > Jun >>>> >>>>> >>> >> >>> > > 17:15:54 >>>> >>>>> >>> >> >>> > > > > CEST >>>> >>>>> >>> >> >>> > > > > > 2015 and was about his surround sound setup, >>>> >>>>> >>> >> >>> > > > > > but did >>>> >>>>> >>> >> >>> > > > > > not >>>> >>>>> >>> >> >>> > > > > > touch >>>> >>>>> >>> >> >>> on the >>>> >>>>> >>> >> >>> > > > > > external microphone problem: >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-June/093317.html >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > alsa-info.sh: >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >>> http://www.alsa-project.org/db/?f=1d8616ba5977308e03db6c3a86e36e9e9b38d6f0 >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > Graph of ALC668 chipset from hdaanalyzer: >>>> >>>>> >>> >> >>> > > > > > http://i.imgur.com/c08DNJW.png >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > setting alsa-mode[1-8] does nothing to help >>>> >>>>> >>> >> >>> > > > > > the >>>> >>>>> >>> >> >>> > > > > > issue. >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > There are several of similar bug reports >>>> >>>>> >>> >> >>> > > > > > around the >>>> >>>>> >>> >> >>> > > > > > web >>>> >>>>> >>> >> >>> experiencing >>>> >>>>> >>> >> >>> > > > > > similar issues, and on different distros. >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > Microphone works perfectly in windows >>>> >>>>> >>> >> >>> > > > > > >>>> >>>>> >>> >> >>> > > > > > I have a ASUS ROG G751JT, but this problem >>>> >>>>> >>> >> >>> > > > > > seems to >>>> >>>>> >>> >> >>> > > > > > happen >>>> >>>>> >>> >> >>> > > > > > with >>>> >>>>> >>> >> >>> all >>>> >>>>> >>> >> >>> > > > > laptops >>>> >>>>> >>> >> >>> > > > > > under the G751 name. >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > > > When you enable the loopback volume and switch, >>>> >>>>> >>> >> >>> > > > > and >>>> >>>>> >>> >> >>> > > > > unmute/adjust >>>> >>>>> >>> >> >>> "Mic >>>> >>>>> >>> >> >>> > > > > Playback Volume", and "Mic Playback Switch", do >>>> >>>>> >>> >> >>> > > > > you >>>> >>>>> >>> >> >>> > > > > hear >>>> >>>>> >>> >> >>> > > > > the >>>> >>>>> >>> >> >>> > > > > input >>>> >>>>> >>> >> >>> > > > > from the ext mic? It's a route directly from >>>> >>>>> >>> >> >>> > > > > NID 0x18 >>>> >>>>> >>> >> >>> > > > > to >>>> >>>>> >>> >> >>> > > > > the >>>> >>>>> >>> >> >>> mixer >>>> >>>>> >>> >> >>> > > > > NID 0x0b, then output mixer NID 0x0c, then >>>> >>>>> >>> >> >>> > > > > outputs. >>>> >>>>> >>> >> >>> > > > > So >>>> >>>>> >>> >> >>> > > > > this >>>> >>>>> >>> >> >>> > > > > can >>>> >>>>> >>> >> >>> be >>>> >>>>> >>> >> >>> > > > > used to verify the hardware routing. >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > > > If you don't hear via this route, it means that >>>> >>>>> >>> >> >>> > > > > the >>>> >>>>> >>> >> >>> > > > > input >>>> >>>>> >>> >> >>> > > > > from >>>> >>>>> >>> >> >>> the ext >>>> >>>>> >>> >> >>> > > > > mic pin itself is broken, and it implies that >>>> >>>>> >>> >> >>> > > > > something >>>> >>>>> >>> >> >>> > > > > outside >>>> >>>>> >>> >> >>> > > > > HD-audio codec. >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > > > Takashi >>>> >>>>> >>> >> >>> > > > > >>>> >>>>> >>> >> >>> > > > [2 <text/html; UTF-8 (quoted-printable)>] >>>> >>>>> >>> >> >>> > > > >>>> >>>>> >>> >> >>> > > >>>> >>>>> >>> >> >>> > [2 <text/html; UTF-8 (quoted-printable)>] >>>> >>>>> >>> >> >>> > >>>> >>>>> >>> >> >>> >>>> >>>>> >>> >> >> >>>> >>>>> >>> >> > _______________________________________________ >>>> >>>>> >>> >> > Alsa-devel mailing list >>>> >>>>> >>> >> > Alsa-devel(a)alsa-project.org >>>> >>>>> >>> >> > >>>> >>>>> >>> >> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

3 26

[alsa-devel] [PATCH 1/2] ALSA: hda - Add quirk for ASUS G751 laptop
by Takashi Iwai 07 Oct '18

07 Oct '18

ASUS G751 requires the extra COEF initialization to make it microphone working properly. Reported-and-tested-by: Håvard <hovardslill(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 69283633ae91..389e8e996589 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7738,6 +7738,7 @@ enum { ALC662_FIXUP_ASUS_Nx50, ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE, ALC668_FIXUP_ASUS_Nx51, + ALC668_FIXUP_ASUS_G751, ALC891_FIXUP_HEADSET_MODE, ALC891_FIXUP_DELL_MIC_NO_PRESENCE, ALC662_FIXUP_ACER_VERITON, @@ -8007,6 +8008,14 @@ static const struct hda_fixup alc662_fixups[] = { .chained = true, .chain_id = ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE, }, + [ALC668_FIXUP_ASUS_G751] = { + .type = HDA_FIXUP_VERBS, + .v.verbs = (const struct hda_verb[]) { + { 0x20, AC_VERB_SET_COEF_INDEX, 0xc3 }, + { 0x20, AC_VERB_SET_PROC_COEF, 0x4000 }, + {} + }, + }, [ALC891_FIXUP_HEADSET_MODE] = { .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_headset_mode, @@ -8080,6 +8089,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A), SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50), + SND_PCI_QUIRK(0x1043, 0x12ff, "ASUS G751", ALC668_FIXUP_ASUS_G751), SND_PCI_QUIRK(0x1043, 0x1477, "ASUS N56VZ", ALC662_FIXUP_BASS_MODE4_CHMAP), SND_PCI_QUIRK(0x1043, 0x15a7, "ASUS UX51VZH", ALC662_FIXUP_BASS_16), SND_PCI_QUIRK(0x1043, 0x177d, "ASUS N551", ALC668_FIXUP_ASUS_Nx51), -- 2.18.0

1 1

Re: [alsa-devel] WARNING in port_delete
by syzbot 06 Oct '18

06 Oct '18

syzbot has found a reproducer for the following crash on: HEAD commit: 091a1eaa0e30 Merge branch 'akpm' git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16623e59400000 kernel config: https://syzkaller.appspot.com/x/.config?x=c0af03fe452b65fb dashboard link: https://syzkaller.appspot.com/bug?extid=e4c8abb920efa77bace9 compiler: gcc (GCC) 8.0.1 20180413 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=102e2c91400000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+e4c8abb920efa77bace9(a)syzkaller.appspotmail.com WARNING: CPU: 1 PID: 23693 at sound/core/seq/seq_ports.c:275 port_delete+0x177/0x1b0 sound/core/seq/seq_ports.c:275 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 23693 Comm: syz-executor0 Not tainted 4.19.0-rc6+ #47 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1c4/0x2b4 lib/dump_stack.c:113 panic+0x238/0x4e7 kernel/panic.c:184 __warn.cold.8+0x163/0x1ba kernel/panic.c:536 report_bug+0x254/0x2d0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:178 [inline] do_error_trap+0x1fc/0x4d0 arch/x86/kernel/traps.c:296 kobject: 'loop1' (00000000baf940ef): kobject_uevent_env kobject: 'loop1' (00000000baf940ef): fill_kobj_path: path = '/devices/virtual/block/loop1' do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:993 RIP: 0010:port_delete+0x177/0x1b0 sound/core/seq/seq_ports.c:275 Code: e7 99 fb 45 85 e4 75 14 e8 66 e6 99 fb 48 89 df e8 ee 29 dd fb 31 c0 5b 41 5c 5d c3 e8 52 e6 99 fb 0f 0b eb e3 e8 49 e6 99 fb <0f> 0b eb 9b e8 a0 55 dd fb eb bd e8 99 55 dd fb e9 77 ff ff ff e8 RSP: 0018:ffff8801a7477890 EFLAGS: 00010293 RAX: ffff8801a84e05c0 RBX: ffff8801cf0be4c0 RCX: ffffffff85e4eee1 RDX: 0000000000000000 RSI: ffffffff85e4ef47 RDI: 0000000000000005 RBP: ffff8801a74778a0 R08: ffff8801a84e05c0 R09: 00000000deede79a R10: 00000000da8ba726 R11: 0000000000000000 R12: 0000000000000001 R13: ffff8801cf0be510 R14: 1ffff10034e8ef20 R15: ffff8801cb447b00 snd_seq_delete_port+0x3cb/0x4a0 sound/core/seq/seq_ports.c:303 snd_seq_ioctl_delete_port+0xba/0x190 sound/core/seq/seq_clientmgr.c:1324 snd_seq_kernel_client_ctl+0x15a/0x190 sound/core/seq/seq_clientmgr.c:2353 snd_seq_event_port_detach+0xfc/0x170 sound/core/seq/seq_ports.c:705 delete_port+0x7d/0xc0 sound/core/seq/oss/seq_oss_init.c:354 snd_seq_oss_release+0xf2/0x130 sound/core/seq/oss/seq_oss_init.c:433 odev_release+0x52/0x70 sound/core/seq/oss/seq_oss.c:153 __fput+0x385/0xa30 fs/file_table.c:278 ____fput+0x15/0x20 fs/file_table.c:309 task_work_run+0x1e8/0x2a0 kernel/task_work.c:113 tracehook_notify_resume include/linux/tracehook.h:193 [inline] exit_to_usermode_loop+0x318/0x380 arch/x86/entry/common.c:166 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline] syscall_return_slowpath arch/x86/entry/common.c:268 [inline] do_syscall_64+0x6be/0x820 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x457579 Code: 1d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f85fa204c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000457579 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000006 RBP: 000000000072bfa0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007f85fa2056d4 R13: 00000000004ef912 R14: 00000000004cc460 R15: 00000000ffffffff Kernel Offset: disabled Rebooting in 86400 seconds..

1 0

[alsa-devel] [PATCH] ALSA: hda/sigmatel - Disable automute for Elo VuPoint
by Michael Pobega 05 Oct '18

05 Oct '18

The Elo VuPoint 15MX has two headphone jacks of which neither work by default. Disabling automute allows ALSA to work normally with the speakers & left headphone jack. Future pin configuration changes may be required in the future to get the right headphone jack working in tandem. Signed-off-by: Michael Pobega <mpobega(a)neverware.com> --- sound/pci/hda/patch_sigmatel.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 046705b4691a..d8168aa2cef3 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -77,6 +77,7 @@ enum { STAC_DELL_M6_BOTH, STAC_DELL_EQ, STAC_ALIENWARE_M17X, + STAC_ELO_VUPOINT_15MX, STAC_92HD89XX_HP_FRONT_JACK, STAC_92HD89XX_HP_Z1_G2_RIGHT_MIC_JACK, STAC_92HD73XX_ASUS_MOBO, @@ -1879,6 +1880,18 @@ static void stac92hd73xx_fixup_no_jd(struct hda_codec *codec, codec->no_jack_detect = 1; } + +static void stac92hd73xx_disable_automute(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct sigmatel_spec *spec = codec->spec; + + if (action != HDA_FIXUP_ACT_PRE_PROBE) + return; + + spec->gen.suppress_auto_mute = 1; +} + static const struct hda_fixup stac92hd73xx_fixups[] = { [STAC_92HD73XX_REF] = { .type = HDA_FIXUP_FUNC, @@ -1904,6 +1917,10 @@ static const struct hda_fixup stac92hd73xx_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = stac92hd73xx_fixup_alienware_m17x, }, + [STAC_ELO_VUPOINT_15MX] = { + .type = HDA_FIXUP_FUNC, + .v.func = stac92hd73xx_disable_automute, + }, [STAC_92HD73XX_INTEL] = { .type = HDA_FIXUP_PINS, .v.pins = intel_dg45id_pin_configs, @@ -1942,6 +1959,7 @@ static const struct hda_model_fixup stac92hd73xx_models[] = { { .id = STAC_DELL_M6_BOTH, .name = "dell-m6" }, { .id = STAC_DELL_EQ, .name = "dell-eq" }, { .id = STAC_ALIENWARE_M17X, .name = "alienware" }, + { .id = STAC_ELO_VUPOINT_15MX, .name = "elo-vupoint-15mx" }, { .id = STAC_92HD73XX_ASUS_MOBO, .name = "asus-mobo" }, {} }; @@ -1991,6 +2009,8 @@ static const struct snd_pci_quirk stac92hd73xx_fixup_tbl[] = { "Alienware M17x", STAC_ALIENWARE_M17X), SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0490, "Alienware M17x R3", STAC_DELL_EQ), + SND_PCI_QUIRK(0x1059, 0x1011, + "ELO VuPoint 15MX", STAC_ELO_VUPOINT_15MX), SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x1927, "HP Z1 G2", STAC_92HD89XX_HP_Z1_G2_RIGHT_MIC_JACK), SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x2b17, -- 2.17.1

2 2

[alsa-devel] Applied "ASoC: adau1761: Use the standard fall-through annotation" to the asoc tree
by Mark Brown 05 Oct '18

05 Oct '18

The patch ASoC: adau1761: Use the standard fall-through annotation has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 7e29317928bd79a03a9c35816afa709988b5d31b Mon Sep 17 00:00:00 2001 From: Takashi Iwai <tiwai(a)suse.de> Date: Thu, 4 Oct 2018 20:30:02 +0200 Subject: [PATCH] ASoC: adau1761: Use the standard fall-through annotation As a preparatory patch for the upcoming -Wimplicit-fallthrough compiler checks, replace with the standard "fall through" annotation at the right place. It has to be put right before the next label. Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/adau1761.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/adau1761.c b/sound/soc/codecs/adau1761.c index be136e981653..bef3e9e74c26 100644 --- a/sound/soc/codecs/adau1761.c +++ b/sound/soc/codecs/adau1761.c @@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component) ARRAY_SIZE(adau1761_jack_detect_controls)); if (ret) return ret; - case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */ + /* fall through */ + case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes, ARRAY_SIZE(adau1761_no_dmic_routes)); if (ret) -- 2.19.0.rc2

1 0