October 2018 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: firewire-motu: add missing entries to Kconfig
by Takashi Sakamoto 12 Oct '18

12 Oct '18

MOTU Traveler and Audio Express are supported as well. Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/firewire/Kconfig b/sound/firewire/Kconfig index 529d9f405fa9..8a146b039276 100644 --- a/sound/firewire/Kconfig +++ b/sound/firewire/Kconfig @@ -147,7 +147,9 @@ config SND_FIREWIRE_MOTU help Say Y here to enable support for FireWire devices which MOTU produced: * 828mk2 + * Traveler * 828mk3 + * Audio Express To compile this driver as a module, choose M here: the module will be called snd-firewire-motu. -- 2.19.1

2 3

[alsa-devel] [PATCH] ALSA: isight: fix leak of reference to firewire unit in error path of .probe callback
by Takashi Sakamoto 12 Oct '18

12 Oct '18

In some error paths, reference count of firewire unit is not decreased. This commit fixes the bug. Fixes: 5b14ec25a79b('ALSA: firewire: release reference count of firewire unit in .remove callback of bus driver') Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/isight.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c index de4decfb74d5..9ebe510ea26b 100644 --- a/sound/firewire/isight.c +++ b/sound/firewire/isight.c @@ -638,7 +638,7 @@ static int isight_probe(struct fw_unit *unit, if (!isight->audio_base) { dev_err(&unit->device, "audio unit base not found\n"); err = -ENXIO; - goto err_unit; + goto error; } fw_iso_resources_init(&isight->resources, unit); @@ -667,12 +667,12 @@ static int isight_probe(struct fw_unit *unit, dev_set_drvdata(&unit->device, isight); return 0; - -err_unit: - fw_unit_put(isight->unit); - mutex_destroy(&isight->mutex); error: snd_card_free(card); + + mutex_destroy(&isight->mutex); + fw_unit_put(isight->unit); + return err; } -- 2.19.1

2 1

[alsa-devel] [PATCH] ALSA: hda - Add mic quirk for the Lenovo G50-30 (17aa:3905)
by Jeremy Cline 12 Oct '18

12 Oct '18

The Lenovo G50-30, like other G50 models, has a Conexant codec that requires a quirk for its inverted stereo dmic. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1249364 Reported-by: Alexander Ploumistos <alex.ploumistos(a)gmail.com> Tested-by: Alexander Ploumistos <alex.ploumistos(a)gmail.com> Cc: stable(a)vger.kernel.org Signed-off-by: Jeremy Cline <jcline(a)redhat.com> --- sound/pci/hda/patch_conexant.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c index 5592557fe50e..950e02e71766 100644 --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -943,6 +943,7 @@ static const struct snd_pci_quirk cxt5066_fixups[] = { SND_PCI_QUIRK(0x17aa, 0x21da, "Lenovo X220", CXT_PINCFG_LENOVO_TP410), SND_PCI_QUIRK(0x17aa, 0x21db, "Lenovo X220-tablet", CXT_PINCFG_LENOVO_TP410), SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo IdeaPad Z560", CXT_FIXUP_MUTE_LED_EAPD), + SND_PCI_QUIRK(0x17aa, 0x3905, "Lenovo G50-30", CXT_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x17aa, 0x390b, "Lenovo G50-80", CXT_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x17aa, 0x3975, "Lenovo U300s", CXT_FIXUP_STEREO_DMIC), SND_PCI_QUIRK(0x17aa, 0x3977, "Lenovo IdeaPad U310", CXT_FIXUP_STEREO_DMIC), -- 2.19.1

2 1

[alsa-devel] [PATCH linux-next v3 1/1] ASoC: rsnd: ssi: Request dedicated dma channels for busif0 to 7
by jiada_wang＠mentor.com 12 Oct '18

12 Oct '18

From: Jiada Wang <jiada_wang(a)mentor.com> Currently ssi driver only requests dma channel for SSI_0, with naming of 'rxu/txu', which is used to transfer data to/from busif0. But for GEN2/GEN3, there are also busif1 ~ busif7, which need to be used when SSI works in TDM Split/Ex-Split mode. This patch adds support to firstly try to request busif indexed dma channel with naming "rxu[busif]/txu[busif]", if these dma channel don't exist, then try to request 'rxu/txu' dma channel to keep compatibility with platform hasn't had device-tree updated. Signed-off-by: Jiada Wang <jiada_wang(a)mentor.com> --- v3: - Drop device-tree changes - Drop automatic busif selection v2: - Instead of configure BUSIF by kctl interface "SSI Out/In BUSIF", use rsnd_ssi_select_busif() to automatically select BUSIF. - Keep 'rxu/txu' dma request, to keep compatibility with GEN2 series - Re-order patch-set to satisfy git bisect v1: initial version --- sound/soc/sh/rcar/ssi.c | 37 ++++++++++++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 3adcc4f778f7..7e21b29249d7 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -76,6 +76,8 @@ #define SSI_NAME "ssi" +#define SSI_DMA_NAME_SIZE 10 + struct rsnd_ssi { struct rsnd_mod mod; @@ -938,12 +940,37 @@ static struct dma_chan *rsnd_ssi_dma_req(struct rsnd_dai_stream *io, { struct rsnd_priv *priv = rsnd_mod_to_priv(mod); int is_play = rsnd_io_is_play(io); - char *name; + char name[SSI_DMA_NAME_SIZE]; - if (rsnd_ssi_use_busif(io)) - name = is_play ? "rxu" : "txu"; - else - name = is_play ? "rx" : "tx"; + if (rsnd_ssi_use_busif(io)) { + int busif = rsnd_ssi_get_busif(io); + struct dma_chan *chan = NULL; + + /* try to request rxu/txu channel with busif index first */ + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rxu%d", busif); + else + snprintf(name, SSI_DMA_NAME_SIZE, "txu%d", busif); + + chan = rsnd_dma_request_channel(rsnd_ssi_of_node(priv), + mod, name); + if (!IS_ERR(chan)) + return chan; + + /* + * If dma channel with busif index doesn't exist + * request rxu/txu dma channel + */ + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rxu"); + else + snprintf(name, SSI_DMA_NAME_SIZE, "txu"); + } else { + if (is_play) + snprintf(name, SSI_DMA_NAME_SIZE, "rx"); + else + snprintf(name, SSI_DMA_NAME_SIZE, "tx"); + } return rsnd_dma_request_channel(rsnd_ssi_of_node(priv), mod, name); -- 2.17.0

2 1

[alsa-devel] [PATCH] ALSA: cs4236: fix return check from call to pnp_port_start
by Colin King 11 Oct '18

11 Oct '18

From: Colin Ian King <colin.king(a)canonical.com> Currently the return from pnp_port_start is being checked for validity by checking if it is greater or equal to zero, however, the return is unsigned and hence this check is always true. An 0 return from pnp_port_start is actually an error, so fix the check by checking for validity when it is non-zero. Detected by CoverityScan, CID#1468334 ("Unsigned compared to 0") Fixes: a9824c868a2c ("[ALSA] Add CS4232 PnP BIOS support") Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- sound/isa/cs423x/cs4236.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/isa/cs423x/cs4236.c b/sound/isa/cs423x/cs4236.c index 70559e59d18f..2211c39d2c18 100644 --- a/sound/isa/cs423x/cs4236.c +++ b/sound/isa/cs423x/cs4236.c @@ -292,7 +292,7 @@ static int snd_cs423x_pnp_init_mpu(int dev, struct pnp_dev *pdev) mpu_irq[dev] = SNDRV_AUTO_IRQ; } else { mpu_port[dev] = pnp_port_start(pdev, 0); - if (mpu_irq[dev] >= 0 && + if (!mpu_irq[dev] && pnp_irq_valid(pdev, 0) && pnp_irq(pdev, 0) >= 0) { mpu_irq[dev] = pnp_irq(pdev, 0); } else { -- 2.17.1

3 2

[alsa-devel] [PATCH 1/4] ASoC: max98373: Sort Digital Volume in reverse order
by Ryan Lee 11 Oct '18

11 Oct '18

Signed-off-by: Ryan Lee <ryans.lee(a)maximintegrated.com> --- Changes : Sort 'max98373_digital_tlv' in reverse order. Fixed wrong use case of 'TLV_DB_SCALE_ITEM' - TLV_DB_SCALE_ITEM(min, step, mute) Max value was set in min field and negative value was set in step field before. sound/soc/codecs/max98373.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c index 1093f76..bb5ef52 100644 --- a/sound/soc/codecs/max98373.c +++ b/sound/soc/codecs/max98373.c @@ -454,7 +454,7 @@ SND_SOC_DAPM_SIGGEN("IMON"), SND_SOC_DAPM_SIGGEN("FBMON"), }; -static DECLARE_TLV_DB_SCALE(max98373_digital_tlv, 0, -50, 0); +static DECLARE_TLV_DB_SCALE(max98373_digital_tlv, -6350, 50, 1); static const DECLARE_TLV_DB_RANGE(max98373_spk_tlv, 0, 8, TLV_DB_SCALE_ITEM(0, 50, 0), 9, 10, TLV_DB_SCALE_ITEM(500, 100, 0), @@ -604,7 +604,7 @@ SOC_SINGLE("Dither Switch", MAX98373_R203F_AMP_DSP_CFG, SOC_SINGLE("DC Blocker Switch", MAX98373_R203F_AMP_DSP_CFG, MAX98373_AMP_DSP_CFG_DCBLK_SHIFT, 1, 0), SOC_SINGLE_TLV("Digital Volume", MAX98373_R203D_AMP_DIG_VOL_CTRL, - 0, 0x7F, 0, max98373_digital_tlv), + 0, 0x7F, 1, max98373_digital_tlv), SOC_SINGLE_TLV("Speaker Volume", MAX98373_R203E_AMP_PATH_GAIN, MAX98373_SPK_DIGI_GAIN_SHIFT, 10, 0, max98373_spk_tlv), SOC_SINGLE_TLV("FS Max Volume", MAX98373_R203E_AMP_PATH_GAIN, -- 2.7.4

2 7

[alsa-devel] Oops when unloading SOF driver modules
by Guennadi Liakhovetski 11 Oct '18

11 Oct '18

Hi, I'm tracking down a kernel Oops, occurring when unloading driver modules. A complete Oops is below. It triggers because cpu_dai->driver is NULL after remove_dai() in soc-topology.c freed it. On my Debian system this only happens when I unload modules directly after loading. If some time passes after loading the drivers, pulseaudio completes its probing and releases the hardware, then remove_dai() isn't called before snd_pcm_do_stop() but after, then everything is running correctly. I'm not sure what the best way to fix this would be. Any ideas? Thanks Guennadi Oct 1 10:23:32 UP-APL01 kernel: [ 142.978059] BUG: unable to handle kernel NULL pointer dereference at 0000000000000088 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978066] PGD 0 P4D 0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978075] Oops: 0000 [#1] SMP NOPTI Oct 1 10:23:32 UP-APL01 kernel: [ 142.978083] CPU: 3 PID: 1240 Comm: alsa-sink-Port0 Tainted: G W E 4.18.0-upboard+ #1 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978087] Hardware name: AAEON UP-APL01/UP-APL01, BIOS UPA1AM36 04/10/2018 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978114] RIP: 0010:soc_pcm_trigger+0x16d/0x1d0 [snd_soc_core] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978117] Code: 31 c0 48 85 c9 74 07 4c 8b 81 88 00 00 00 ba 6c 04 00 00 48 c7 c6 20 14 84 c0 48 c7 c7 72 34 84 c0 e8 55 a3 4a df 49 8b 45 18 <48> 8b 80 88 00 00 00 48 8b 80 88 00 00 00 48 85 c0 74 16 4c 89 ea Oct 1 10:23:32 UP-APL01 kernel: [ 142.978204] RSP: 0018:ffffb6b781243da8 EFLAGS: 00010286 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978207] RAX: 0000000000000000 RBX: ffff9146ae2a0800 RCX: 0000000000000000 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978210] RDX: 0000000000000000 RSI: ffff9146bfd96738 RDI: ffff9146bfd96738 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978212] RBP: ffff9146afdbbc00 R08: 00000000000006fd R09: 0000000000000004 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978215] R10: 00000000000001c3 R11: 0000000000000001 R12: 0000000000000000 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978217] R13: ffff9146b1b92f80 R14: ffff9146ae2a0eb0 R15: ffff9146ae2a0ea8 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978220] FS: 00007f3db6b24700(0000) GS:ffff9146bfd80000(0000) knlGS:0000000000000000 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978223] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978225] CR2: 0000000000000088 CR3: 0000000177ce6000 CR4: 00000000003406e0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978228] Call Trace: Oct 1 10:23:32 UP-APL01 kernel: [ 142.978247] dpcm_fe_dai_do_trigger+0xee/0x220 [snd_soc_core] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978258] snd_pcm_do_stop+0x65/0x80 [snd_pcm] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978267] snd_pcm_action_single+0x36/0x80 [snd_pcm] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978275] snd_pcm_drop+0x6f/0xa0 [snd_pcm] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978283] snd_pcm_release_substream+0x39/0xd0 [snd_pcm] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978291] snd_pcm_release+0x5d/0xb0 [snd_pcm] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978298] __fput+0xd0/0x1e0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978305] task_work_run+0x8a/0xb0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978311] exit_to_usermode_loop+0xe6/0xf0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978315] do_syscall_64+0xf3/0x110 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978321] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978325] RIP: 0033:0x7f3dc0988ab7 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978327] Code: 10 e9 67 ff ff ff 0f 1f 44 00 00 48 8b 15 c9 f3 2c 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff e9 6b ff ff ff b8 0b 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a1 f3 2c 00 f7 d8 64 89 01 48 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978374] RSP: 002b:00007f3db6b23c38 EFLAGS: 00000202 ORIG_RAX: 000000000000000b Oct 1 10:23:32 UP-APL01 kernel: [ 142.978377] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007f3dc0988ab7 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978380] RDX: 0000000000000010 RSI: 0000000000001000 RDI: 00007f3dc284a000 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978382] RBP: 000056431cb73ac0 R08: 00007f3db763a578 R09: 00007f3db6b23b50 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978384] R10: 00000000fffffff8 R11: 0000000000000202 R12: 000056431cb73ac0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978387] R13: 000056431cb73ac0 R14: 0000000000000000 R15: 000056431caad4b0 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978390] Modules linked in: sof_pci_dev(E-) snd_sof_intel_hda_common(E) sof_acpi_dev(E) snd_sof_intel_bdw(E) snd_sof_intel_byt(E) snd_sof_nocodec(E) snd_sof_intel_hsw(E) snd_sof(E) snd_sof_xtensa_dsp(E) snd_soc_acpi_intel_match(E) snd_soc_acpi(E) snd_soc_da7213(E) snd_soc_rt5640(E) snd_soc_rt5651(E) snd_soc_rt5645(E) snd_soc_rt5670(E) snd_soc_rl6231(E) nls_ascii(E) nls_cp437(E) vfat(E) fat(E) squashfs(E) loop(E) spi_pxa2xx_platform(E) intel_rapl(E) i2c_designware_platform(E) i2c_designware_core(E) x86_pkg_temp_thermal(E) coretemp(E) kvm_intel(E) kvm(E) irqbypass(E) crct10dif_pclmul(E) crc32_pclmul(E) ghash_clmulni_intel(E) snd_hda_core(E) efi_pstore(E) pcbc(E) snd_soc_core(E) snd_compress(E) snd_pcm(E) snd_seq_midi(E) snd_seq_midi_event(E) snd_rawmidi(E) aesni_intel(E) aes_x86_64(E) crypto_simd(E) Oct 1 10:23:32 UP-APL01 kernel: [ 142.978445] cryptd(E) glue_helper(E) intel_cstate(E) intel_rapl_perf(E) pwm_lpss_pci(E) efivars(E) lpc_ich(E) pwm_lpss(E) snd_seq(E) idma64(E) virt_dma(E) intel_lpss_pci(E) intel_lpss(E) mfd_core(E) snd_seq_device(E) snd_timer(E) tpm_crb(E) snd(E) tpm_tis(E) tpm_tis_core(E) tpm(E) evdev(E) rng_core(E) mei_me(E) mei(E) soundcore(E) pcc_cpufreq(E) sch_fq_codel(E) parport_pc(E) ppdev(E) lp(E) parport(E) efivarfs(E) ip_tables(E) x_tables(E) autofs4(E) ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E) fscrypto(E) hid_generic(E) usbhid(E) hid(E) mmc_block(E) dwc3(E) sdhci_pci(E) xhci_pci(E) cqhci(E) sdhci(E) crc32c_intel(E) i915(E) mmc_core(E) ahci(E) i2c_algo_bit(E) xhci_hcd(E) libahci(E) drm_kms_helper(E) dwc3_pci(E) usbcore(E) libata(E) r8169(E) mii(E) drm(E) scsi_mod(E) video(E) button(E) [last unloaded: snd_sof] Oct 1 10:23:32 UP-APL01 kernel: [ 142.978528] CR2: 0000000000000088 Oct 1 10:23:32 UP-APL01 kernel: [ 142.978532] ---[ end trace f60338bc9477e8ed ]---

1 0

[alsa-devel] Trying to write control utility for YAMAHA Cavit DP-U50/AP-U70/RP-U200.
by Tahiro Hashizume 11 Oct '18

11 Oct '18

Hi The devices of my interest is in fact 18yrs old, but just can't stop using them for being too useful. (I own DP-U50 and RP-U200). For these devices: A.)Source selecting as well as alteration of the labels (for each input) to be displayed on the VDF are possible. B.)Internal DSP is highly configurable c.)Tuner presets are editable (RP-U200 only) through the Win32 utility (DP-U50.exe/AP-U70.exe/RP-U200.exe). Most of sound-related details should be at http://www.alsa-project.org/db/?f=9aad4f38c69efd1c6ae90de239063efeb5a61dce. Basically I am stuck with almost no experience in this, but am trying to write some code to implement the Linux-alternative of these utilities to at least enable the source selecting from Linux via USB (mostly intended to be used with shairplay-sync). Thought examples of device-specific utilities as found in alsa-tools may help but I just don't see connections between USB-dump and control signals that may be accepted by those listed in amixer. Side-notes(Findings so far): The device appears as a composite with several Audio interfaces and a HID-Class interface. Knowing this from early days, I first decided to see hexdump outputs on "/dev/hidraw0" and it indicated what looked like the representation of current status of the device while turning knobs and switching inputs. My guess is, the device takes special commands via the control and echos the current status via HID which is visible as "/dev/hidraw0". ("/dev/input/event0" is also present but doesn't really spit anything.) At this point, thought this was a bi-directional communication via HID-Class (by which I was wrong, as I found out later). Thinking collecting several packet captures under controlled conditions would help understand the mechanism, moved onto capturing WindowMessages (of RP-U200.exe) with Spy++ from which I was able to implement the automated operation of RP-U200.exe via Python. See: https://www.youtube.com/watch?v=-Il9vKtnr1A Figured out 1.)messages of "WM_USER + 1" are from "hid_io.dll" to RP-U200.exe 2.)messages of "WM_USER + 201" are the actual inputs to RP-U200.exe About files attached: a.)RP-U200.hexdump.txt shows outputs observed on "/dev/hidraw0" as I turned the volume knob from min to max and down to min. b.)"util_launch.pcapng.json" shows the interactions between host (Win10 x64) and RP-U200 as RP-U200.exe was being launched (Power:Off->Off). c.)"util_power_on.pcapng.json" shows the interactions between host (Win10 x64) and RP-U200 starting shortly before I pressed the Power button on RP-U200.exe, ending with the output relays closed for speaker outputs (Power:Off->On). Any comments should keep me encouraged. Thanks in advance. Tahiro.H

1 0

[alsa-devel] [asoc:for-4.20 333/490] sound/pci//hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?
by kbuild test robot 11 Oct '18

11 Oct '18

Hi Rakesh, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-4.20 head: 8036dbc490d16dc3d998246e14c9507ec8272ae2 commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 [333/490] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 6bae5ea9498926440ffc883f3dbceb0adc65e492 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=sh All errors (new ones prefixed by >>): sound/pci//hda/patch_ca0132.c: In function 'patch_ca0132': >> sound/pci//hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'? [-Werror=implicit-function-declaration] spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); ^~~~~~~~~ pcim_iomap sound/pci//hda/patch_ca0132.c:7650:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); ^ cc1: some warnings being treated as errors vim +7650 sound/pci//hda/patch_ca0132.c d5c016b56 Gabriele Martino 2015-05-18 7581 95c6e9cb7 Ian Minett 2011-06-15 7582 static int patch_ca0132(struct hda_codec *codec) 95c6e9cb7 Ian Minett 2011-06-15 7583 { 95c6e9cb7 Ian Minett 2011-06-15 7584 struct ca0132_spec *spec; a73d511c4 Ian Minett 2012-12-20 7585 int err; d5c016b56 Gabriele Martino 2015-05-18 7586 const struct snd_pci_quirk *quirk; 95c6e9cb7 Ian Minett 2011-06-15 7587 4e76a8833 Takashi Iwai 2014-02-25 7588 codec_dbg(codec, "patch_ca0132\n"); 95c6e9cb7 Ian Minett 2011-06-15 7589 95c6e9cb7 Ian Minett 2011-06-15 7590 spec = kzalloc(sizeof(*spec), GFP_KERNEL); 95c6e9cb7 Ian Minett 2011-06-15 7591 if (!spec) 95c6e9cb7 Ian Minett 2011-06-15 7592 return -ENOMEM; 95c6e9cb7 Ian Minett 2011-06-15 7593 codec->spec = spec; 993884f6a Chih-Chung Chang 2013-03-25 7594 spec->codec = codec; 95c6e9cb7 Ian Minett 2011-06-15 7595 225068ab2 Takashi Iwai 2015-05-29 7596 codec->patch_ops = ca0132_patch_ops; 225068ab2 Takashi Iwai 2015-05-29 7597 codec->pcm_format_first = 1; 225068ab2 Takashi Iwai 2015-05-29 7598 codec->no_sticky_stream = 1; 225068ab2 Takashi Iwai 2015-05-29 7599 d5c016b56 Gabriele Martino 2015-05-18 7600 /* Detect codec quirk */ d5c016b56 Gabriele Martino 2015-05-18 7601 quirk = snd_pci_quirk_lookup(codec->bus->pci, ca0132_quirks); d5c016b56 Gabriele Martino 2015-05-18 7602 if (quirk) d5c016b56 Gabriele Martino 2015-05-18 7603 spec->quirk = quirk->value; d5c016b56 Gabriele Martino 2015-05-18 7604 else d5c016b56 Gabriele Martino 2015-05-18 7605 spec->quirk = QUIRK_NONE; d5c016b56 Gabriele Martino 2015-05-18 7606 e24aa0a4c Takashi Iwai 2014-08-10 7607 spec->dsp_state = DSP_DOWNLOAD_INIT; a7e76271b Ian Minett 2012-12-20 7608 spec->num_mixers = 1; 017310fbe Connor McAdams 2018-05-08 7609 017310fbe Connor McAdams 2018-05-08 7610 /* Set which mixers each quirk uses. */ 017310fbe Connor McAdams 2018-05-08 7611 switch (spec->quirk) { 017310fbe Connor McAdams 2018-05-08 7612 case QUIRK_SBZ: e25e34450 Connor McAdams 2018-08-08 7613 spec->mixers[0] = desktop_mixer; 017310fbe Connor McAdams 2018-05-08 7614 snd_hda_codec_set_name(codec, "Sound Blaster Z"); 017310fbe Connor McAdams 2018-05-08 7615 break; e25e34450 Connor McAdams 2018-08-08 7616 case QUIRK_R3D: e25e34450 Connor McAdams 2018-08-08 7617 spec->mixers[0] = desktop_mixer; e25e34450 Connor McAdams 2018-08-08 7618 snd_hda_codec_set_name(codec, "Recon3D"); e25e34450 Connor McAdams 2018-08-08 7619 break; 017310fbe Connor McAdams 2018-05-08 7620 case QUIRK_R3DI: 017310fbe Connor McAdams 2018-05-08 7621 spec->mixers[0] = r3di_mixer; 017310fbe Connor McAdams 2018-05-08 7622 snd_hda_codec_set_name(codec, "Recon3Di"); 017310fbe Connor McAdams 2018-05-08 7623 break; 017310fbe Connor McAdams 2018-05-08 7624 default: a7e76271b Ian Minett 2012-12-20 7625 spec->mixers[0] = ca0132_mixer; 017310fbe Connor McAdams 2018-05-08 7626 break; 017310fbe Connor McAdams 2018-05-08 7627 } a7e76271b Ian Minett 2012-12-20 7628 08eca6b1f Connor McAdams 2018-08-08 7629 /* Setup whether or not to use alt functions/controls/pci_mmio */ 009b8f979 Connor McAdams 2018-05-08 7630 switch (spec->quirk) { 009b8f979 Connor McAdams 2018-05-08 7631 case QUIRK_SBZ: e42c7c731 Connor McAdams 2018-08-08 7632 case QUIRK_R3D: 08eca6b1f Connor McAdams 2018-08-08 7633 spec->use_alt_controls = true; 08eca6b1f Connor McAdams 2018-08-08 7634 spec->use_alt_functions = true; 08eca6b1f Connor McAdams 2018-08-08 7635 spec->use_pci_mmio = true; 08eca6b1f Connor McAdams 2018-08-08 7636 break; 009b8f979 Connor McAdams 2018-05-08 7637 case QUIRK_R3DI: 47cdf76e4 Connor McAdams 2018-05-08 7638 spec->use_alt_controls = true; 009b8f979 Connor McAdams 2018-05-08 7639 spec->use_alt_functions = true; 08eca6b1f Connor McAdams 2018-08-08 7640 spec->use_pci_mmio = false; 009b8f979 Connor McAdams 2018-05-08 7641 break; 009b8f979 Connor McAdams 2018-05-08 7642 default: 47cdf76e4 Connor McAdams 2018-05-08 7643 spec->use_alt_controls = false; 009b8f979 Connor McAdams 2018-05-08 7644 spec->use_alt_functions = false; 08eca6b1f Connor McAdams 2018-08-08 7645 spec->use_pci_mmio = false; 009b8f979 Connor McAdams 2018-05-08 7646 break; 009b8f979 Connor McAdams 2018-05-08 7647 } 009b8f979 Connor McAdams 2018-05-08 7648 08eca6b1f Connor McAdams 2018-08-08 7649 if (spec->use_pci_mmio) { 08eca6b1f Connor McAdams 2018-08-08 @7650 spec->mem_base = pci_iomap(codec->bus->pci, 2, 0xC20); 08eca6b1f Connor McAdams 2018-08-08 7651 if (spec->mem_base == NULL) { 08eca6b1f Connor McAdams 2018-08-08 7652 codec_warn(codec, "pci_iomap failed! Setting quirk to QUIRK_NONE."); 08eca6b1f Connor McAdams 2018-08-08 7653 spec->quirk = QUIRK_NONE; 08eca6b1f Connor McAdams 2018-08-08 7654 } 08eca6b1f Connor McAdams 2018-08-08 7655 } 08eca6b1f Connor McAdams 2018-08-08 7656 5aaca44d8 Ian Minett 2012-12-20 7657 spec->base_init_verbs = ca0132_base_init_verbs; 5aaca44d8 Ian Minett 2012-12-20 7658 spec->base_exit_verbs = ca0132_base_exit_verbs; 5aaca44d8 Ian Minett 2012-12-20 7659 993884f6a Chih-Chung Chang 2013-03-25 7660 INIT_DELAYED_WORK(&spec->unsol_hp_work, ca0132_unsol_hp_delayed); 993884f6a Chih-Chung Chang 2013-03-25 7661 95c6e9cb7 Ian Minett 2011-06-15 7662 ca0132_init_chip(codec); 95c6e9cb7 Ian Minett 2011-06-15 7663 95c6e9cb7 Ian Minett 2011-06-15 7664 ca0132_config(codec); 95c6e9cb7 Ian Minett 2011-06-15 7665 d5c016b56 Gabriele Martino 2015-05-18 7666 err = ca0132_prepare_verbs(codec); d5c016b56 Gabriele Martino 2015-05-18 7667 if (err < 0) cc91ceaf3 Takashi Iwai 2017-09-04 7668 goto error; d5c016b56 Gabriele Martino 2015-05-18 7669 a73d511c4 Ian Minett 2012-12-20 7670 err = snd_hda_parse_pin_def_config(codec, &spec->autocfg, NULL); a73d511c4 Ian Minett 2012-12-20 7671 if (err < 0) cc91ceaf3 Takashi Iwai 2017-09-04 7672 goto error; a73d511c4 Ian Minett 2012-12-20 7673 95c6e9cb7 Ian Minett 2011-06-15 7674 return 0; cc91ceaf3 Takashi Iwai 2017-09-04 7675 cc91ceaf3 Takashi Iwai 2017-09-04 7676 error: cc91ceaf3 Takashi Iwai 2017-09-04 7677 ca0132_free(codec); cc91ceaf3 Takashi Iwai 2017-09-04 7678 return err; 95c6e9cb7 Ian Minett 2011-06-15 7679 } 95c6e9cb7 Ian Minett 2011-06-15 7680 :::::: The code at line 7650 was first introduced by commit :::::: 08eca6b1f1468a4021bac7b3929fd3eb491e2629 ALSA: hda/ca0132 - Add bool variable to enable/disable pci region2 mmio :::::: TO: Connor McAdams <conmanx360(a)gmail.com> :::::: CC: Takashi Iwai <tiwai(a)suse.de> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

1 0

[alsa-devel] Fixing EAPD for STAC9202 on an embedded platform.
by Andy Davison 11 Oct '18

11 Oct '18

Hi everyone, I’m hoping that somebody here might be able to spot where I’m going wrong; I'm working with a picture-frame-like device manufactured by the late OpenPeak Inc. known as the OpenFrame (or O2 Joggler in the UK). It has an internal speaker and a 3.5mm line out socket; none of the other connections to its STAC9202 codec chip are exposed to the end user. I've been porting Ubuntu Bionic to the device and everything is done, except for the audio driver. Back in kernel 3.18 it was possible to use the following kernel patch and userland ALSA patch to have these two outputs work correctly, with the insertion of a plug into the line out properly muting the internal speaker. https://github.com/andydvsn/OpenFrame-Kernel/blob/master/patches/03-stac920… https://github.com/andydvsn/OpenFrame-Ubuntu/blob/master/overlay-trusty/lib… In kernel 4.14 the same trick no longer works, so I've rewritten the patch to more properly add support for this variant of STAC9202 to ALSA. It now looks like this: https://gist.github.com/andydvsn/7bffa8de0ed691b14508485d75501ffc This seems to line up the pin configurations appropriately, but when a plug is inserted to the line out, although the audio to the internal speaker is muted, the speaker emits a crackling sound whenever the device is processing. It seems that it is not being properly powered down and is amplifying general circuit noise. Disconnecting the plug returns sound to the internal speaker and the crackling ceases. This is reliable across multiple devices. Here is the alsa-info output from both the crackling kernel 4.14 and the working-just-fine kernel 3.18. https://gist.github.com/andydvsn/ccf55e6f7961dd405fc39d41a6ce9ef6 I don't have sufficient knowledge of ALSA drivers and patches and have been working purely from the configurations used by others over the years, so I would really appreciate somebody looking at the alsa-info output and the new patch to determine where I should go from here. I believe this is all to do with EAPD control, but what options I have for controlling that aren't known to me right now. Ideally, I want to end up with the audio muting and switching correctly when the jack is inserted. A bonus would be to lose the unused (or at least inaccessible) audio input and output options in alsamixer and gain individual control of the internal speaker and line out levels (which appear to be paired together at the moment). All the best, A. -- Andrew Davison

2 11