August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] conf/ucm: DB410c-HiFi: add CIC selection
by srinivas.kandagatla＠linaro.org 10 Aug '17

10 Aug '17

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> This patch adds CIC selection controls which have been added recently to the kernel to select mic source. Without this patch user has to manually select the control to record from DMIC or AMIC. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> --- src/conf/ucm/DB410c/HiFi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/conf/ucm/DB410c/HiFi b/src/conf/ucm/DB410c/HiFi index f9cbcf0..dcb7ac9 100644 --- a/src/conf/ucm/DB410c/HiFi +++ b/src/conf/ucm/DB410c/HiFi @@ -108,6 +108,7 @@ SectionDevice."Handset" { EnableSequence [ cdev "hw:0" cset "name='DEC1 MUX' ADC2" + cset "name='CIC1 MUX' AMIC" cset "name='ADC2 Volume' 8" cset "name='ADC2 MUX' INP2" ] @@ -130,6 +131,7 @@ SectionDevice."Primarymic" { EnableSequence [ cdev "hw:0" cset "name='DEC1 MUX' ADC1" + cset "name='CIC1 MUX' AMIC" cset "name='ADC1 Volume' 8" ] @@ -150,6 +152,7 @@ SectionDevice."Secondarymic" { EnableSequence [ cdev "hw:0" cset "name='DEC1 MUX' ADC2" + cset "name='CIC1 MUX' AMIC" cset "name='ADC2 Volume' 8" cset "name='ADC2 MUX' INP2" ] @@ -172,6 +175,7 @@ SectionDevice."DMIC" { EnableSequence [ cdev "hw:0" cset "name='DEC1 MUX' DMIC1" + cset "name='CIC1 MUX' DMIC" ] DisableSequence [ -- 2.9.3

2 1

[alsa-devel] [PATCH 0/7] constify pci snd_pcm_ops structures
by Arvind Yadav 10 Aug '17

10 Aug '17

snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by <sound/pcm.h> work with const snd_pcm_ops. So mark the non-const structs as const. Arvind Yadav (7): [PATCH 1/7] ALSA: ali5451: constify snd_pcm_ops structures [PATCH 2/7] ALSA: au88x0: constify snd_pcm_ops structures [PATCH 3/7] ALSA: echoaudio: constify snd_pcm_ops structures [PATCH 4/7] ALSA: intel8x0: constify snd_pcm_ops structures [PATCH 5/7] ALSA: intel8x0m: constify snd_pcm_ops structures [PATCH 6/7] ALSA: sis7019: constify snd_pcm_ops structures [PATCH 7/7] ALSA: trident: constify snd_pcm_ops structures sound/pci/ali5451/ali5451.c | 12 ++++++------ sound/pci/au88x0/au88x0_pcm.c | 2 +- sound/pci/echoaudio/echoaudio.c | 8 ++++---- sound/pci/intel8x0.c | 24 ++++++++++++------------ sound/pci/intel8x0m.c | 8 ++++---- sound/pci/sis7019.c | 4 ++-- sound/pci/trident/trident_main.c | 4 ++-- 7 files changed, 31 insertions(+), 31 deletions(-) -- 1.9.1

2 8

[alsa-devel] [PATCH 0/4] ALSA: emux: Adjustments for four function implementations
by SF Markus Elfring 10 Aug '17

10 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Wed, 9 Aug 2017 09:50:05 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Adjust one function call together with a variable assignment Improve a size determination in two functions Adjust four checks for null pointers Delete two error messages for a failed memory allocation in snd_emux_create_port() sound/synth/emux/emux_seq.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 2.13.4

2 5

[alsa-devel] [PATCH] ASoC: spear: Remove redundant message
by dspmihai 10 Aug '17

10 Aug '17

This was reported by checkpatch.pl Signed-off-by: Despotovici Mihai <despotovici.mihai(a)gmail.com> --- sound/soc/spear/spdif_in.c | 4 +--- sound/soc/spear/spdif_out.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c index 977a078..0f3b1a8 100644 --- a/sound/soc/spear/spdif_in.c +++ b/sound/soc/spear/spdif_in.c @@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev) return -EINVAL; host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!host) return -ENOMEM; - } host->io_base = io_base; host->irq = platform_get_irq(pdev, 0); diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c index 0a72d52..58d5843 100644 --- a/sound/soc/spear/spdif_out.c +++ b/sound/soc/spear/spdif_out.c @@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev) int ret; host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!host) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->io_base = devm_ioremap_resource(&pdev->dev, res); -- 2.7.4

3 2

[alsa-devel] [PATCH 0/3] ASoC: rsnd: request_irq/free_irq
by Kuninori Morimoto 10 Aug '17

10 Aug '17

Hi Mark Renesas sound driver supports many features, thus, it has many data path. I noticed request_irq/free_irq balance are not correct when MIXer case, and PIO mode case. These patches solve these issue. Kuninori Morimoto (3): ASoC: rsnd: call free_irq() both DMA/PIO mode ASoC: rsnd: add rsnd_ssi_flags_has/add() macro ASoC: rsnd: call request_irq/free_irq once in MIX case sound/soc/sh/rcar/ssi.c | 81 ++++++++++++++++++++++++++++++------------------- 1 file changed, 50 insertions(+), 31 deletions(-) -- 1.9.1

2 6

[alsa-devel] [PATCH 0/2] ASoC: make snd_soc_codec_driver structures const
by Bhumika Goyal 10 Aug '17

10 Aug '17

2 7

[alsa-devel] [PATCH] ASoC: compress: Delete error messages for a failed memory allocation in snd_soc_new_compress()
by SF Markus Elfring 10 Aug '17

10 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Thu, 10 Aug 2017 16:21:34 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_… Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/soc/soc-compress.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index 206f36bf43e8..6c867d50e036 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -764,15 +764,12 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) direction = SND_COMPRESS_CAPTURE; compr = kzalloc(sizeof(*compr), GFP_KERNEL); - if (compr == NULL) { - snd_printk(KERN_ERR "Cannot allocate compr\n"); + if (!compr) return -ENOMEM; - } compr->ops = devm_kzalloc(rtd->card->dev, sizeof(soc_compr_ops), GFP_KERNEL); - if (compr->ops == NULL) { - dev_err(rtd->card->dev, "Cannot allocate compressed ops\n"); + if (!compr->ops) { ret = -ENOMEM; goto compr_err; } -- 2.14.0

2 1

[alsa-devel] [PATCH v1 0/6] ASoC: codecs: msm8916-wcd-analog: Add support to MBHC
by srinivas.kandagatla＠linaro.org 10 Aug '17

10 Aug '17

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> This patchset adds support to MBHC(Multibutton headset control) block in PM8916 analog block. MBHC support comes from2 blocks first mechanical headset detection and second headset type, 5 button detection. This patchset adds support to: 1> Support to NC and NO type of headset Jacks. 2> Mechanical insertion and detection of headset jack. 3> Detect a 3 pole Headphone and a 4 pole Headset. 4> Detect 5 buttons. First patch fixes error code returned by snd_soc_codec_set_jack() to be more precise for users. Second patch is patch from Damien, followed by few fixes to codec driver w.r.t mbhc and final patch to add mbhc support. Damien sent a similar patchset to add support to mechanical detection, but that patch has issues and will not work on most usecases (for example after a playback/capture session, multicodec case). So I only picked up the BIT mask patch from that series. Tested it on DB410c with Audio Mezz board with 4 pole and 3 pole and during playback and recording use cases. root@linaro-alip:~# evtest No device specified, trying to scan all of /dev/input/event* Available devices: /dev/input/event0: pm8941_pwrkey /dev/input/event1: DB410c Headset Jack /dev/input/event2: gpio_keys Select the device event number [0-2]: 1 Input driver version is 1.0.1 Input device ID: bus 0x0 vendor 0x0 product 0x0 version 0x0 Input device name: "DB410c Headset Jack" Supported events: Event type 0 (EV_SYN) Event type 1 (EV_KEY) Event code 114 (KEY_VOLUMEDOWN) Event code 115 (KEY_VOLUMEUP) Event code 226 (KEY_MEDIA) Event code 260 (BTN_4) Event code 582 (KEY_VOICECOMMAND) Event type 5 (EV_SW) Event code 2 (SW_HEADPHONE_INSERT) state 1 Event code 4 (SW_MICROPHONE_INSERT) state 1 Properties: Testing ... (interrupt to exit) Event: time 1501001112.059684, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 1 Event: time 1501001112.059684, type 5 (EV_SW), code 2 (SW_HEADPHONE_INSERT), value 0 Event: time 1501001112.059684, type 5 (EV_SW), code 4 (SW_MICROPHONE_INSERT), value 0 Event: time 1501001112.059684, -------------- SYN_REPORT ------------ Event: time 1501001112.254116, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 0 Event: time 1501001112.254116, -------------- SYN_REPORT ------------ Event: time 1501001113.154184, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1 Event: time 1501001113.154184, -------------- SYN_REPORT ------------ Event: time 1501001113.319658, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0 Event: time 1501001113.319658, -------------- SYN_REPORT ------------ Event: time 1501001113.781084, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 1 Event: time 1501001113.781084, -------------- SYN_REPORT ------------ Event: time 1501001114.024930, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 0 Event: time 1501001114.024930, -------------- SYN_REPORT ------------ Event: time 1501001114.419082, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1 Event: time 1501001114.419082, -------------- SYN_REPORT ------------ Event: time 1501001114.576011, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0 Event: time 1501001114.576011, -------------- SYN_REPORT ------------ Event: time 1501001114.795281, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1 Event: time 1501001114.795281, -------------- SYN_REPORT ------------ Event: time 1501001114.863333, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0 Event: time 1501001114.863333, -------------- SYN_REPORT ------------ Event: time 1501001116.603372, type 1 (EV_KEY), code 226 (KEY_MEDIA), value 1 Event: time 1501001116.603372, -------------- SYN_REPORT ------------ Damien Riegel (1): ASoC: codecs: msm8916-analog: fix DIG_CLK_CTL_RXD3_CLK_EN define Srinivas Kandagatla (5): ASoC: jack: fix snd_soc_codec_set_jack return error ASoC: codecs: msm8916-wcd-analog: move codec reset to probe ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8 ASoC: codecs: msm8916-wcd-analog: add MBHC support ASoC: qcom: apq8016-sbc: Add support to Headset JACK .../bindings/sound/qcom,msm8916-wcd-analog.txt | 9 + sound/soc/codecs/msm8916-wcd-analog.c | 359 +++++++++++++++++++-- sound/soc/codecs/msm8916-wcd.h | 12 + sound/soc/qcom/apq8016_sbc.c | 52 +++ sound/soc/soc-jack.c | 2 +- 5 files changed, 410 insertions(+), 24 deletions(-) create mode 100644 sound/soc/codecs/msm8916-wcd.h -- 2.9.3

3 19

[alsa-devel] [PATCH] ASoC: rsnd: Delete an error message for a failed memory allocation in three functions
by SF Markus Elfring 10 Aug '17

10 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Thu, 10 Aug 2017 17:13:19 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_… Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/soc/sh/rcar/adg.c | 4 +--- sound/soc/sh/rcar/core.c | 4 +--- sound/soc/sh/rcar/gen.c | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/sh/rcar/adg.c b/sound/soc/sh/rcar/adg.c index 5b5389e5b92b..938baff86ef2 100644 --- a/sound/soc/sh/rcar/adg.c +++ b/sound/soc/sh/rcar/adg.c @@ -586,10 +586,8 @@ int rsnd_adg_probe(struct rsnd_priv *priv) int ret; adg = devm_kzalloc(dev, sizeof(*adg), GFP_KERNEL); - if (!adg) { - dev_err(dev, "ADG allocate failed\n"); + if (!adg) return -ENOMEM; - } ret = rsnd_mod_init(priv, &adg->mod, &adg_ops, NULL, NULL, 0, 0); diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index c34562388cfa..9e331a474a21 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -1402,10 +1402,8 @@ static int rsnd_probe(struct platform_device *pdev) * init priv data */ priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(dev, "priv allocate failed\n"); + if (!priv) return -ENODEV; - } priv->pdev = pdev; priv->flags = (unsigned long)of_device_get_match_data(dev); diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c index ee00e3516911..f04c4100043a 100644 --- a/sound/soc/sh/rcar/gen.c +++ b/sound/soc/sh/rcar/gen.c @@ -406,10 +406,8 @@ int rsnd_gen_probe(struct rsnd_priv *priv) int ret; gen = devm_kzalloc(dev, sizeof(*gen), GFP_KERNEL); - if (!gen) { - dev_err(dev, "GEN allocate failed\n"); + if (!gen) return -ENOMEM; - } priv->gen = gen; -- 2.14.0

2 1

[alsa-devel] [PATCH 0/3 v2][resend] ASoC: Component level pcm_new/pcm_free v2
by Kuninori Morimoto 10 Aug '17

10 Aug '17

Hi Mark I posted this patch-set 2weeks ago, and no response, no objection from community. Thus, I re-post these again. These are Component level pcm_new/free v2. v1 pcm_new/free had breaked some platform, because it called "card" connected component callback. It should call "rtd" connected one's. Special thanks to Arnaud who tested this v2 patch on his environment. These patch-set adds rtd connected component list (= rtdcom) and replace current platform level pcm_new/free into component level pcm_new/free I don't know this naming (= rtdcom) sense is nice or not ;P I can replace it to more nicer naming if someone have nice sense. Kuninori Morimoto (3): ASoC: soc-core: add snd_soc_rtdcom_xxx() ASoC: use snd_soc_rtdcom_add() and convert to consistent operation ASoC: add Component level pcm_new/pcm_free v2 include/sound/soc.h | 21 ++++++- sound/soc/soc-core.c | 153 +++++++++++++++++++++++++++++++++++++++------------ sound/soc/soc-pcm.c | 68 +++++++++++++++-------- 3 files changed, 183 insertions(+), 59 deletions(-) -- 1.9.1

2 6