August 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: opl3: Delete an error message for a failed memory allocation in snd_opl3_new()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 19:54:20 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/drivers/opl3/opl3_lib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c index d5e5b4657b4b..588963d6be28 100644 --- a/sound/drivers/opl3/opl3_lib.c +++ b/sound/drivers/opl3/opl3_lib.c @@ -355,10 +355,8 @@ int snd_opl3_new(struct snd_card *card, *ropl3 = NULL; opl3 = kzalloc(sizeof(*opl3), GFP_KERNEL); - if (opl3 == NULL) { - snd_printk(KERN_ERR "opl3: cannot allocate\n"); + if (!opl3) return -ENOMEM; - } opl3->card = card; opl3->hardware = hardware; -- 2.14.0

2 1

[alsa-devel] [PATCH] ALSA: ca0106: Delete an error message for a failed memory allocation in snd_ca0106_pcm_open_capture_channel()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 19:09:23 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/pci/ca0106/ca0106_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c index 6165a57a94ae..b7783137af04 100644 --- a/sound/pci/ca0106/ca0106_main.c +++ b/sound/pci/ca0106/ca0106_main.c @@ -660,11 +660,9 @@ static int snd_ca0106_pcm_open_capture_channel(struct snd_pcm_substream *substre int err; epcm = kzalloc(sizeof(*epcm), GFP_KERNEL); - if (epcm == NULL) { - dev_err(chip->card->dev, - "open_capture_channel: failed epcm alloc\n"); + if (!epcm) return -ENOMEM; - } + epcm->emu = chip; epcm->substream = substream; epcm->channel_id=channel_id; -- 2.14.0

2 1

[alsa-devel] [PATCH] ALSA: mixart: Delete an error message for a failed memory allocation in snd_mixart_create()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 18:45:42 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/pci/mixart/mixart.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c index 6d7fbf30618b..84f6b2651bf3 100644 --- a/sound/pci/mixart/mixart.c +++ b/sound/pci/mixart/mixart.c @@ -1052,10 +1052,8 @@ static int snd_mixart_create(struct mixart_mgr *mgr, struct snd_card *card, int }; chip = kzalloc(sizeof(*chip), GFP_KERNEL); - if (! chip) { - dev_err(card->dev, "cannot allocate chip\n"); + if (!chip) return -ENOMEM; - } chip->card = card; chip->chip_idx = idx; -- 2.14.0

2 1

[alsa-devel] [PATCH] ALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 18:14:54 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/pci/pcxhr/pcxhr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c index fa919f52e225..376fd76caec2 100644 --- a/sound/pci/pcxhr/pcxhr.c +++ b/sound/pci/pcxhr/pcxhr.c @@ -1215,10 +1215,8 @@ static int pcxhr_create(struct pcxhr_mgr *mgr, }; chip = kzalloc(sizeof(*chip), GFP_KERNEL); - if (! chip) { - dev_err(card->dev, "cannot allocate chip\n"); + if (!chip) return -ENOMEM; - } chip->card = card; chip->chip_idx = idx; -- 2.14.0

2 1

[alsa-devel] [PATCH 00/16] ALSA: PCI: constify snd_pcm_hardware const
by Bhumika Goyal 12 Aug '17

12 Aug '17

Declare snd_pcm_hardware const. Done using Coccinelle. Bhumika Goyal (16): ALSA: aw2: make snd_pcm_hardware const ALSA: ca0106: make snd_pcm_hardware const ALSA: cs46xx: make snd_pcm_hardware const ALSA: korg1212: make snd_pcm_hardware const ALSA: cs5535audio: make snd_pcm_hardware const ALSA: emu10k1: make snd_pcm_hardware const ALSA: lola: make snd_pcm_hardware const ALSA: lx6464es: make snd_pcm_hardware const ALSA: mixart: make snd_pcm_hardware const ALSA: ctxfi: make snd_pcm_hardware const ALSA: pcxhr: make snd_pcm_hardware const ALSA: riptide: make snd_pcm_hardware const ALSA: rme9652: make snd_pcm_hardware const ALSA: trident: make snd_pcm_hardware const ALSA: ymfpci: make snd_pcm_hardware const ALSA: pci: make snd_pcm_hardware const sound/pci/ad1889.c | 4 ++-- sound/pci/als300.c | 4 ++-- sound/pci/als4000.c | 4 ++-- sound/pci/atiixp.c | 2 +- sound/pci/atiixp_modem.c | 2 +- sound/pci/aw2/aw2-alsa.c | 4 ++-- sound/pci/bt87x.c | 4 ++-- sound/pci/ca0106/ca0106_main.c | 4 ++-- sound/pci/cmipci.c | 12 ++++++------ sound/pci/cs4281.c | 4 ++-- sound/pci/cs46xx/cs46xx_lib.c | 4 ++-- sound/pci/cs5535audio/cs5535audio_pcm.c | 4 ++-- sound/pci/ctxfi/ctpcm.c | 6 +++--- sound/pci/emu10k1/emu10k1x.c | 4 ++-- sound/pci/emu10k1/emupcm.c | 10 +++++----- sound/pci/emu10k1/p16v.c | 4 ++-- sound/pci/ens1370.c | 6 +++--- sound/pci/es1938.c | 4 ++-- sound/pci/es1968.c | 4 ++-- sound/pci/fm801.c | 4 ++-- sound/pci/intel8x0.c | 2 +- sound/pci/intel8x0m.c | 2 +- sound/pci/korg1212/korg1212.c | 4 ++-- sound/pci/lola/lola_pcm.c | 2 +- sound/pci/lx6464es/lx6464es.c | 2 +- sound/pci/maestro3.c | 4 ++-- sound/pci/mixart/mixart.c | 4 ++-- sound/pci/pcxhr/pcxhr.c | 2 +- sound/pci/riptide/riptide.c | 4 ++-- sound/pci/rme32.c | 8 ++++---- sound/pci/rme96.c | 8 ++++---- sound/pci/rme9652/hdsp.c | 4 ++-- sound/pci/rme9652/rme9652.c | 4 ++-- sound/pci/sis7019.c | 4 ++-- sound/pci/sonicvibes.c | 4 ++-- sound/pci/trident/trident_main.c | 10 +++++----- sound/pci/via82xx.c | 2 +- sound/pci/via82xx_modem.c | 2 +- sound/pci/ymfpci/ymfpci_main.c | 4 ++-- 39 files changed, 85 insertions(+), 85 deletions(-) -- 1.9.1

2 17

[alsa-devel] [PATCH 0/3] ALSA: rme9652: Adjustments for six function implementations
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 17:17:23 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in snd_hdspm_create() Improve eight size determinations Adjust seven checks for null pointers sound/pci/rme9652/hdspm.c | 42 ++++++++++++++++++------------------------ 1 file changed, 18 insertions(+), 24 deletions(-) -- 2.14.0

2 4

[alsa-devel] [PATCH 0/3] ALSA: rme96: Adjustments for six function implementations
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 15:36:54 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete two error messages for a failed memory allocation in snd_rme96_probe() Use common error handling code in snd_rme96_probe() Adjust five checks for null pointers sound/pci/rme96.c | 43 ++++++++++++++++++++----------------------- 1 file changed, 20 insertions(+), 23 deletions(-) -- 2.14.0

2 4

[alsa-devel] [PATCH] ALSA: trident: Delete an error message for a failed memory allocation in snd_trident_tlb_alloc()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Sat, 12 Aug 2017 13:20:16 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/pci/trident/trident_main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c index 64d3b8eba4bb..0eca3c370990 100644 --- a/sound/pci/trident/trident_main.c +++ b/sound/pci/trident/trident_main.c @@ -3363,11 +3363,9 @@ static int snd_trident_tlb_alloc(struct snd_trident *trident) trident->tlb.entries_dmaaddr = ALIGN(trident->tlb.buffer.addr, SNDRV_TRIDENT_MAX_PAGES * 4); /* allocate shadow TLB page table (virtual addresses) */ trident->tlb.shadow_entries = vmalloc(SNDRV_TRIDENT_MAX_PAGES*sizeof(unsigned long)); - if (trident->tlb.shadow_entries == NULL) { - dev_err(trident->card->dev, - "unable to allocate shadow TLB entries\n"); + if (!trident->tlb.shadow_entries) return -ENOMEM; - } + /* allocate and setup silent page and initialise TLB entries */ if (snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, snd_dma_pci_data(trident->pci), SNDRV_TRIDENT_PAGE_SIZE, &trident->tlb.silent_page) < 0) { -- 2.14.0

2 1

[alsa-devel] [PATCH] ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation in alloc_urbs()
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Fri, 11 Aug 2017 19:39:06 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/usb/caiaq/audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/usb/caiaq/audio.c b/sound/usb/caiaq/audio.c index 8f66ba730d69..1f306155e76a 100644 --- a/sound/usb/caiaq/audio.c +++ b/sound/usb/caiaq/audio.c @@ -731,7 +731,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL); if (!urbs) { - dev_err(dev, "unable to kmalloc() urbs, OOM!?\n"); *ret = -ENOMEM; return NULL; } @@ -746,7 +745,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret) urbs[i]->transfer_buffer = kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL); if (!urbs[i]->transfer_buffer) { - dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n"); *ret = -ENOMEM; return urbs; } -- 2.14.0

3 2

[alsa-devel] [PATCH] ALSA: usb: Delete an error message for a failed memory allocation in two functions
by SF Markus Elfring 12 Aug '17

12 Aug '17

From: Markus Elfring <elfring(a)users.sourceforge.net> Date: Fri, 11 Aug 2017 18:38:25 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_… Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net> --- sound/usb/quirks.c | 5 ++--- sound/usb/stream.c | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index d7b0b0a3a2db..9db40d58b4e2 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -146,10 +146,9 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip, unsigned *rate_table = NULL; fp = kmemdup(quirk->data, sizeof(*fp), GFP_KERNEL); - if (!fp) { - usb_audio_err(chip, "cannot memdup\n"); + if (!fp) return -ENOMEM; - } + INIT_LIST_HEAD(&fp->list); if (fp->nr_rates > MAX_NR_RATES) { kfree(fp); diff --git a/sound/usb/stream.c b/sound/usb/stream.c index 8e9548bc1f1a..d1776e5517ff 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -658,10 +658,8 @@ int snd_usb_parse_audio_interface(struct snd_usb_audio *chip, int iface_no) continue; fp = kzalloc(sizeof(*fp), GFP_KERNEL); - if (! fp) { - dev_err(&dev->dev, "cannot malloc\n"); + if (!fp) return -ENOMEM; - } fp->iface = iface_no; fp->altsetting = altno; -- 2.14.0

2 1