March 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ALSA: x86: Remove CONFIG_SND_X86 as unnecessary
by Ian W MORRISON 21 Mar '17

21 Mar '17

Create a specific menu for the CONFIG_HDMI_LPE_AUDIO setting. Add additional narrative to further explain the function of the CONFIG_HDMI_LPE_AUDIO setting. Remove subsequently unnecessary CONFIG_SND_X86 setting. Signed-off-by: Ian W Morrison <linuxium(a)linuxium.com.au> --- sound/x86/Kconfig | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig index 84c8f8fc..a89d769 100644 --- a/sound/x86/Kconfig +++ b/sound/x86/Kconfig @@ -1,10 +1,5 @@ -menuconfig SND_X86 - tristate "X86 sound devices" - depends on X86 - ---help--- - X86 sound devices that don't fall under SoC or PCI categories - -if SND_X86 +menu "HDMI LPE for SoC audio support" + comment "Required for HDMI audio support on Intel Baytrail and Cherrytrail" config HDMI_LPE_AUDIO tristate "HDMI audio without HDaudio on Intel Atom platforms" @@ -13,4 +8,4 @@ config HDMI_LPE_AUDIO help Choose this option to support HDMI LPE Audio mode -endif # SND_X86 +endmenu -- 1.9.1

2 3

Re: [alsa-devel] [PATCH v2] ALSA: x86: Select CONFIG_HDMI_LPE_AUDIO as default
by Ian W MORRISON 21 Mar '17

21 Mar '17

On 21 March 2017 at 09:02, Ian W MORRISON <ianwmorrison(a)gmail.com> wrote: > > > On 21 March 2017 at 04:57, Takashi Iwai <tiwai(a)suse.de> wrote: > >> On Mon, 20 Mar 2017 16:12:01 +0100, >> Ian W MORRISON wrote: >> > >> > On 20 March 2017 at 21:04, Takashi Iwai <tiwai(a)suse.de> wrote: >> > >> > > On Mon, 20 Mar 2017 10:41:07 +0100, >> > > Ian W MORRISON wrote: >> > > > >> > > > On 20 March 2017 at 19:41, Takashi Iwai <tiwai(a)suse.de> wrote: >> > > > >> > > > > On Mon, 20 Mar 2017 09:17:30 +0100, >> > > > > Ian W MORRISON wrote: >> > > > > > >> > > > > > Oops ... forgot to copy alsa-devel and Pierre-Louis. >> > > > > > >> > > > > > On 20 March 2017 at 18:59, Takashi Iwai <tiwai(a)suse.de> wrote: >> > > > > > >> > > > > > > On Mon, 20 Mar 2017 08:42:32 +0100, >> > > > > > > Ian W MORRISON wrote: >> > > > > > > > >> > > > > > > > The upstream kernel builds for distributions such as Ubuntu >> > > which now >> > > > > > > > includes binary packages for v4.11 mainline kernel release >> > > > > candidates are >> > > > > > > > promoted as a way of testing upstream kernels to to confirm >> that >> > > > > upstream >> > > > > > > > has fixed a specific issue (see https://wiki.ubuntu.com/ >> > > > > > > > Kernel/MainlineBuilds). >> > > > > > > > >> > > > > > > > Unfortunately the long awaited patch for providing HDMI >> audio >> > > > > support for >> > > > > > > > Bay Trail and Cherry Trail devices does not include this >> support >> > > > > through >> > > > > > > a >> > > > > > > > module built by default. >> > > > > > > > >> > > > > > > > Through including by default of the two associated CONFIG >> > > settings >> > > > > > > (SND_X86 >> > > > > > > > and HDMI_LPE_AUDIO), upstream kernel builds would >> automatically >> > > > > provide >> > > > > > > the >> > > > > > > > much desired HDMI audio support by default. >> > > > > > > > >> > > > > > > > This patch uses a Kconfig 'default' statement to include the >> > > driver >> > > > > as >> > > > > > > > default. >> > > > > > > > >> > > > > > > > Changes in version 2: CONFIG_SND_X86 now a bool and changed >> > > default >> > > > > m to >> > > > > > > > default y >> > > > > > > > >> > > > > > > > Signed-off-by: Ian W Morrison <linuxium(a)linuxium.com.au> >> > > > > > > > --- >> > > > > > > > sound/x86/Kconfig | 4 +++- >> > > > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) >> > > > > > > > >> > > > > > > > diff --git a/sound/x86/Kconfig b/sound/x86/Kconfig >> > > > > > > > index 84c8f8fc..cac2270 100644 >> > > > > > > > --- a/sound/x86/Kconfig >> > > > > > > > +++ b/sound/x86/Kconfig >> > > > > > > > @@ -1,6 +1,7 @@ >> > > > > > > > menuconfig SND_X86 >> > > > > > > > - tristate "X86 sound devices" >> > > > > > > > + bool "X86 sound devices" >> > > > > > > > depends on X86 >> > > > > > > > + default y >> > > > > > > >> > > > > > > This one is OK, but ... >> > > > > > > >> > > > > > > > ---help--- >> > > > > > > > X86 sound devices that don't fall under SoC or PCI >> > > > > categories >> > > > > > > > >> > > > > > > > @@ -9,6 +10,7 @@ if SND_X86 >> > > > > > > > config HDMI_LPE_AUDIO >> > > > > > > > tristate "HDMI audio without HDaudio on Intel Atom >> > > platforms" >> > > > > > > > depends on DRM_I915 >> > > > > > > > + default y >> > > > > > > >> > > > > > > ... this is wrong. Each driver config itself should be left >> > > > > > > unspecified. >> > > > > > > >> > > > > > > It's distributor's job to choose the right config here. >> > > > > > > >> > > > > > > Actually this goes back to one of my earlier points: A >> distributor >> > > > > doesn't >> > > > > > have to set 'HDMI' as HDMI audio is automatically provided. >> > > > > >> > > > > Provided by who...? >> > > > > >> > > > >> > > > >> > > > I suppose it is provided as a result of the architecture one runs >> the >> > > > primary Makefile on. With 'uname -m' returning 'x86_64' running >> 'make >> > > > defconfig' results in 'CONFIG_HDMI=y' being set so >> > > 'drivers/video/Makefile' >> > > > automatically makes 'drivers/video/hdmi.c' and as >> > > > 'arch/x86/configs/x86_64_defconfig' includes 'CONFIG_DRM=y' and >> > > > 'CONFIG_DRM_I915=y' and 'drivers/gpu/drm/i915/Makefile' makes >> > > > 'intel_audio.c'. >> > > >> > > The defconfig stuff supports only the limited device sets that are >> > > supposed to be very common. Is HDMI_LPE_AUDIO classified really as >> > > such a thing? I don't know... >> > > >> > > >> > In this instance I'd suggest that HDMI_LPE_AUDIO is common as without it >> > you do not get HDMI audio on all x86_64 devices. However see my comment >> > below. >> > >> > >> > > >> > > > > > This is just an >> > > > > > extension because by setting 'HDMI_LPE_AUDIO' the missing audio >> > > support >> > > > > for >> > > > > > BYT and CHT SoCs is then provided. Therefore, in this albeit >> unusual >> > > > > > instance, I reason is it appropriate to set HDMI_LPE_AUDIO so >> that >> > > audio >> > > > > is >> > > > > > automatically provided regardless of distribution. If a >> distributor >> > > > > didn't >> > > > > > want to allow audio for BYT and CHT SoC based devices running >> their >> > > > > distro >> > > > > > then they could always remove it from their distro specific >> config. >> > > > > >> > > > > It's a wrong approach. What we're discussing about is just a >> > > > > configuration for a new individual driver, and the same rule >> should be >> > > > > applied to it like others. >> > > > > >> > > > > Check other drivers. See whether default=y (or =m) is set to >> > > > > CONFIG_E1000E, as a random example. With your argument, it >> should be >> > > > > set to y or m as default, since the Ethernet functionality is >> already >> > > > > provided by the network core. >> > > > > >> > > > > In general, we don't set the default values to the driver configs >> > > > > unless there is a VERY specific reason to do so. >> > > > > >> > > > > >> > > > I'm trying to get HDMI audio by default for BYT & CHT SoC but >> currently >> > > > this requires 'CONFIG_HDMI_LPE_AUDIO' set with a value of 'm'. I >> don't >> > > want >> > > > to argue a 'special case' or promote a 'wrong approach' but just >> get HDMI >> > > > audio working so is there another way to achieve this? >> > > >> > > What's wrong with manually setting CONFIG_HDMI_LPE_AUDIO=m or =y? >> > > IOW, do all features on your CHT/BYT machines work without adjusting >> > > manually after defconfig? If you have to do it in anyway, what makes >> > > it special for HDMI_LPD_AUDIO? >> > > >> > > >> > I've just tested various scenarios using a variety of devices with >> > v4.11-rc3. Having CONFIG_HDMI_LPE_AUDIO set by default is sufficient to >> get >> > audio on BYT/CHT devices over HDMI. >> > >> > For example installing Ubuntu 16.04.2 on a BYT/CHT device, then >> upgrading >> > the kernel to v4.11-rc3 using the deb-binary from >> http://kernel.ubuntu.com/~ >> > kernel-ppa/mainline/v4.11-rc3/ (an example of a current distro which is >> > compiling without setting CONFIG_HDMI_LPE_AUDIO) and there is no audio >> over >> > HDMI. Alternatively downloading v4.11-rc3 source, making defconfig, >> > manually setting CONFIG_HDMI_LPE_AUDIO, compiling and installing the >> > kernel on the BYT/CHT device will give you audio over HDMI. >> > >> > If the BYT/CHT device has other sound cards (e.g accessed via a >> headphone >> > jack) then audio without setting CONFIG_HDMI_LPE_AUDIO may be possible >> > depending on the codec used and whether it is provided by default in the >> > kernel. So for example a Tronsmart Ara (CHT) device has audio over >> > headphones using the pre-compiled deb-binary above but no audio over >> HDMI. >> > Whereas with a (1st gen) Intel Compute Stick (BYT) device no audio is >> > possible using the pre-compiled deb-binary as the device only has an >> HDMI >> > port. To get sound you must therefore currently use a self-compiled >> kernel >> > with CONFIG_HDMI_LPE_AUDIO set. >> > >> > Whilst Canonical may set CONFIG_HDMI_LPE_AUDIO to provide audio on >> BYT/CHT >> > devices by when is unknown and there is no guarantee they actually will. >> > >> > This will be similar for all other distros with the worst case scenario >> > that no distributor adds CONFIG_HDMI_LPE_AUDIO to their configs >> resulting >> > in (arguably) little point including HDMI LPE audio support in the >> kernel. >> > >> > I've laboured the point about 'BYT/CHT devices audio over HDMI' but to >> > answer your question completely there are other BYT/CHT devices >> (typically >> > tablets) that need a whole other bunch of patches to fix this and that. >> > They may need specialist kernel configs with specific settings but that >> is >> > a separate issue to the basic functional need of having audio over HDMI. >> > >> > Does the above explanation justify my current approach or is there an >> > alternative that can be considered? >> >> Sorry, no, you've explained how much you love the HDMI audio, but it >> doesn't answer my question clearly. >> > > Whatever love there was is diminishing rapidly! > > Let me set the context: the range of BYT/CHT devices sold as HDMI sticks > or HDMI boxes which are designed to connect to an HDMI output device (TV or > monitor) and typically have Windows installed as the OS and are used > primarily as media PCs, HTPCs or as 'mini' PCs. They become essentially > useless for their designated purpose when installed with a mainstream Linux > based OS such as Ubuntu at the moment because there is no audio over HDMI. > > >> >> My question is simple: are *all* features the upstream kernel supports >> for your device now (e.g. input, network or whatever) enabled by the >> pure arch/x86/configs/x86_64_defconfig *without* manually setting the >> configs to y or m? I bet you likely have to set some configs there >> manually to m or y. >> >> > No. CONFIG_HDMI_LPE_AUDIO is the only config that needs to be manually set > to get *all* features from the upstream kernel. > > >> Then, if the manual selection for such missing configs is acceptable, >> what makes the HDMI audio so special and it must be set to y/m as >> default, while other devices aren't set like that...? That's the >> question. >> >> >> > The requested patch sets CONFIG_HDMI_LPE_AUDIO so mainstream Linux distro > kernels would automatically provide the new kernel feature of HDMI LPE > audio support. > Further analysis of Canonical's v4.11-rcN build compared with other available distro builds of v4.11-rcN leads me to conclude that given CONFIG_HDMI_LPE_AUDIO is not set by default then Canonical's config is at fault. Consequently I have raised a bug report ( https://bugs.launchpad.net/ubuntu/+bug/1674523) in order to (hopefully) address the issue. I will additionally submit a further patch that (arguably) improves the current Kconfig file for the CONFIG_HDMI_LPE_AUDIO setting by creating a specific menu for the CONFIG_HDMI_LPE_AUDIO setting, adding additional narrative to further explain the function of the CONFIG_HDMI_LPE_AUDIO setting and removing the subsequently unnecessary CONFIG_SND_X86 setting. As a result, this patch ([PATCH v2] ALSA: x86: Select CONFIG_HDMI_LPE_AUDIO as default) is withdrawn. > > >> thanks, >> >> Takashi >> > >

1 0

[alsa-devel] [PATCH v5 0/9] ASoC: add OF-graph base simple-card
by Kuninori Morimoto 21 Mar '17

21 Mar '17

Hi Rob, Mark These are v5 of OF-graph base audio card patch-set. It fixed small things which was pointed by Rob. 1) - 3) : new OF-graph helper functions 4) - 5) : expand "label", "dai-format" 6) - 9) : OF-graph base simple-card Kuninori Morimoto (9): of_graph: add of_graph_get_remote_endpoint() of_graph: add of_graph_get_port_parent() of_graph: add of_graph_get_endpoint_count() ASoC: simple-card-utils: enable "label" on asoc_simple_card_parse_card_name ASoC: soc-core: enable "dai-name" on snd_soc_of_parse_daifmt() ASoC: add snd_soc_get_dai_id() ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai() ASoC: add audio-graph-card document ASoC: add audio-graph-card support .../devicetree/bindings/sound/audio-graph-card.txt | 124 +++++++++ drivers/of/base.c | 60 +++- include/linux/of_graph.h | 21 ++ include/sound/simple_card_utils.h | 10 + include/sound/soc.h | 1 + sound/soc/generic/Kconfig | 8 + sound/soc/generic/Makefile | 2 + sound/soc/generic/audio-graph-card.c | 308 +++++++++++++++++++++ sound/soc/generic/simple-card-utils.c | 54 +++- sound/soc/soc-core.c | 32 ++- 10 files changed, 604 insertions(+), 16 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/audio-graph-card.txt create mode 100644 sound/soc/generic/audio-graph-card.c -- 1.9.1

1 0

[alsa-devel] [PATCH v1 0/2] conf/ucm: Remove intel UCM conf files from alsa-lib repo
by fuweix.tang＠intel.com 21 Mar '17

21 Mar '17

From: Fuwei Tang <fuweix.tang(a)intel.com> Remove the intel UCM configs from alsa-lib repo, and move them to a dedicated UCM and topology file repo. Another series will add them to a dedicated UCM conf repo. License can be changed to BSD for intel files, and left as "unknown" for other conf files when they are moved from alsa-lib to the new repo. Fuwei Tang (2): conf/ucm: Remove conf files of broxton-rt298 platform conf/ucm: Remove conf files of skylake-rt286 platform configure.ac | 2 - src/conf/ucm/Makefile.am | 2 +- src/conf/ucm/broxton-rt298/Hdmi1 | 22 ----- src/conf/ucm/broxton-rt298/Hdmi2 | 14 --- src/conf/ucm/broxton-rt298/HiFi | 129 -------------------------- src/conf/ucm/broxton-rt298/Makefile.am | 4 - src/conf/ucm/broxton-rt298/broxton-rt298.conf | 58 ------------ src/conf/ucm/skylake-rt286/Hdmi1 | 20 ---- src/conf/ucm/skylake-rt286/Hdmi2 | 20 ---- src/conf/ucm/skylake-rt286/HiFi | 129 -------------------------- src/conf/ucm/skylake-rt286/Makefile.am | 4 - src/conf/ucm/skylake-rt286/skylake-rt286.conf | 60 ------------ 12 files changed, 1 insertion(+), 463 deletions(-) delete mode 100644 src/conf/ucm/broxton-rt298/Hdmi1 delete mode 100644 src/conf/ucm/broxton-rt298/Hdmi2 delete mode 100644 src/conf/ucm/broxton-rt298/HiFi delete mode 100644 src/conf/ucm/broxton-rt298/Makefile.am delete mode 100644 src/conf/ucm/broxton-rt298/broxton-rt298.conf delete mode 100644 src/conf/ucm/skylake-rt286/Hdmi1 delete mode 100644 src/conf/ucm/skylake-rt286/Hdmi2 delete mode 100644 src/conf/ucm/skylake-rt286/HiFi delete mode 100644 src/conf/ucm/skylake-rt286/Makefile.am delete mode 100644 src/conf/ucm/skylake-rt286/skylake-rt286.conf -- 2.7.4

1 2

[alsa-devel] [PATCH v1 0/3] ucm-conf: Add intel UCM conf files to alsa-ucm-conf repo
by fuweix.tang＠intel.com 21 Mar '17

21 Mar '17

From: Fuwei Tang <fuweix.tang(a)intel.com> Add the intel UCM configs to a dedicated UCM conf repo.License can be changed to BSD for intel files,and left as "unknown" for other conf files when they are moved from alsa-lib to the new repo.The alsa-lib LGPL license does not cover runtime configuration files. The configs are moved from alsa-lib repo.The original authorship and commit message of all config files will be reserved. I write the setup code from scratch instead of copying it from Takashi in this version. Fuwei Tang (1): ucm-conf: Set up for installation Vinod Koul (2): ucm-conf: broxton: add broxton-rt298 conf files ucm-conf: skylake: add skylake-rt286 conf files .gitignore | 13 ++++ ChangeLog | 1 + INSTALL | 1 + Makefile.am | 1 + broxton-rt298/Hdmi1 | 22 +++++++ broxton-rt298/Hdmi2 | 14 +++++ broxton-rt298/HiFi | 129 +++++++++++++++++++++++++++++++++++++++ broxton-rt298/Makefile.am | 4 ++ broxton-rt298/broxton-rt298.conf | 58 ++++++++++++++++++ configure.ac | 24 ++++++++ gitcompile | 5 ++ skylake-rt286/Hdmi1 | 20 ++++++ skylake-rt286/Hdmi2 | 20 ++++++ skylake-rt286/HiFi | 129 +++++++++++++++++++++++++++++++++++++++ skylake-rt286/Makefile.am | 4 ++ skylake-rt286/skylake-rt286.conf | 60 ++++++++++++++++++ 16 files changed, 505 insertions(+) create mode 100644 .gitignore create mode 100644 ChangeLog create mode 120000 INSTALL create mode 100644 Makefile.am create mode 100644 broxton-rt298/Hdmi1 create mode 100644 broxton-rt298/Hdmi2 create mode 100644 broxton-rt298/HiFi create mode 100644 broxton-rt298/Makefile.am create mode 100644 broxton-rt298/broxton-rt298.conf create mode 100644 configure.ac create mode 100755 gitcompile create mode 100644 skylake-rt286/Hdmi1 create mode 100644 skylake-rt286/Hdmi2 create mode 100644 skylake-rt286/HiFi create mode 100644 skylake-rt286/Makefile.am create mode 100644 skylake-rt286/skylake-rt286.conf -- 2.7.4

3 5

[alsa-devel] snd_hda_intel: probe of 0000:00:01.1 failed with error -2
by Jorge Fernandez Monteagudo 20 Mar '17

20 Mar '17

Hi all! I've a system with a custom distribution and a 3.16.7 linux kernel. Sometimes when the sound system is initialized I get this error and the sound is not working. I see in dmesg [ 36.104413] snd_hda_intel 0000:00:01.1: irq 80 for MSI/MSI-X [ 36.111812] sound hdaudioC1D0: autoconfig: line_outs=1 (0xa/0x0/0x0/0x0/0x0) type:line [ 36.111815] sound hdaudioC1D0: speaker_outs=1 (0xb/0x0/0x0/0x0/0x0) [ 36.111817] sound hdaudioC1D0: hp_outs=1 (0x9/0x0/0x0/0x0/0x0) [ 36.111819] sound hdaudioC1D0: mono: mono_out=0x0 [ 36.111820] sound hdaudioC1D0: dig-out=0x10/0x15 [ 36.111821] sound hdaudioC1D0: inputs: [ 36.111823] sound hdaudioC1D0: Mic=0xd [ 36.111824] sound hdaudioC1D0: Line=0xc [ 36.111826] sound hdaudioC1D0: dig-in=0x12 [ 36.115940] sound hdaudioC0D0: ignore pin 0x7, too many assigned pins [ 36.115942] sound hdaudioC0D0: autoconfig: line_outs=0 (0x0/0x0/0x0/0x0/0x0) type:line [ 36.115944] sound hdaudioC0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 36.115945] sound hdaudioC0D0: hp_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 36.115946] sound hdaudioC0D0: mono: mono_out=0x0 [ 36.115947] sound hdaudioC0D0: dig-out=0x3/0x5 [ 36.115948] sound hdaudioC0D0: inputs: [ 37.119900] snd_hda_intel: probe of 0000:00:01.1 failed with error -2 [ 37.127608] sound hdaudioC0D0: autoconfig: line_outs=1 (0xa/0x0/0x0/0x0/0x0) type:line [ 37.127613] sound hdaudioC0D0: speaker_outs=1 (0xb/0x0/0x0/0x0/0x0) [ 37.127615] sound hdaudioC0D0: hp_outs=1 (0x9/0x0/0x0/0x0/0x0) [ 37.127617] sound hdaudioC0D0: mono: mono_out=0x0 [ 37.127618] sound hdaudioC0D0: dig-out=0x10/0x15 [ 37.127620] sound hdaudioC0D0: inputs: [ 37.127622] sound hdaudioC0D0: Mic=0xd [ 37.127624] sound hdaudioC0D0: Line=0xc [ 37.127625] sound hdaudioC0D0: dig-in=0x12 and # cat /proc/asound/cards 0 [Generic ]: HDA-Intel - HD-Audio Generic HD-Audio Generic at 0xff760000 irq 39 What's the meaning of this error? Regards, Jorge

1 0

[alsa-devel] [RFC PATCH 0/2] ASoC: wm8994: master clock issues
by olivier moysan 20 Mar '17

20 Mar '17

Hello, I face two issues using wm8994 codec driver. Below is a description of the use cases rising the problem. I added the patches which allow to fix these issues. These minimalist patches can be seen as a starting point for a discussion on the best way to handle the use cases exposed. - ASoC: wm8994: default master clock selection Use case: CPU DAI and codec are managed through simple card. Wolson codec wm8994 is set as slave of CPU DAI and CPU DAI feeds codec with master clock. Master clock is derived from mclk-fs property and provided to CPU DAI and codec through snd_soc_dai_set_sysclk API. Analysis: The simple card assumes id 0 for master clock. However wm8994 codec exposes master clock ids from 1 to 4. (MCLK1, MCLK2 ..) The proposal in this patch is to define a default selection regarding master clock when id 0 is provided. - ASoC: wm8994: delay aifxclk activation Use case: Wolson codec wm8994 is set as slave of CPU DAI and CPU DAI feeds codec with master clock. CPU DAI generates master clock when enabled in trigger callback. So master clock is available only at runtime. Master clock is not available when configuring codec through alsa controls. Analysis: When we configure aifx clock while master clock is not active, related registers are not updated in wm8894 codec. A way to go around this problem, is to delay aifxclk activation until SND_SOC_DAPM_POST_PMU DAPM stage. The purpose of patch here is to illustrate this workaround. What I cannot clearly figure out, is how this may impact other uses of wm8894 codec. I try to know if it's worth investigating further in this direction or if it will not be applicable. If not applicable, what maybe the other options ? regards olivier olivier moysan (2): ASoC: wm8994: default master clock selection ASoC: wm8994: delay aifxclk activation sound/soc/codecs/wm8994.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.9.1

3 5

[alsa-devel] [PATCH 0/2] conf/ucm: Remove intel UCM conf files from alsa-lib repo
by fuweix.tang＠intel.com 20 Mar '17

20 Mar '17

From: Fuwei Tang <fuweix.tang(a)intel.com> Remove the intel UCM configs from alsa-lib repo. Another series will add them to a dedicated UCM conf repo.License can be changed to BSD for intel files,and left as "unknown" for other conf files when they are moved from alsa-lib to the new repo.The alsa-lib LGPL license does not cover runtime configuration files. Fuwei Tang (2): conf/ucm: Remove conf files of broxton-rt298 platform conf/ucm: Remove conf files of skylake-rt286 platfrom configure.ac | 2 - src/conf/ucm/Makefile.am | 2 +- src/conf/ucm/broxton-rt298/Hdmi1 | 22 ----- src/conf/ucm/broxton-rt298/Hdmi2 | 14 --- src/conf/ucm/broxton-rt298/HiFi | 129 -------------------------- src/conf/ucm/broxton-rt298/Makefile.am | 4 - src/conf/ucm/broxton-rt298/broxton-rt298.conf | 58 ------------ src/conf/ucm/skylake-rt286/Hdmi1 | 20 ---- src/conf/ucm/skylake-rt286/Hdmi2 | 20 ---- src/conf/ucm/skylake-rt286/HiFi | 129 -------------------------- src/conf/ucm/skylake-rt286/Makefile.am | 4 - src/conf/ucm/skylake-rt286/skylake-rt286.conf | 60 ------------ 12 files changed, 1 insertion(+), 463 deletions(-) delete mode 100644 src/conf/ucm/broxton-rt298/Hdmi1 delete mode 100644 src/conf/ucm/broxton-rt298/Hdmi2 delete mode 100644 src/conf/ucm/broxton-rt298/HiFi delete mode 100644 src/conf/ucm/broxton-rt298/Makefile.am delete mode 100644 src/conf/ucm/broxton-rt298/broxton-rt298.conf delete mode 100644 src/conf/ucm/skylake-rt286/Hdmi1 delete mode 100644 src/conf/ucm/skylake-rt286/Hdmi2 delete mode 100644 src/conf/ucm/skylake-rt286/HiFi delete mode 100644 src/conf/ucm/skylake-rt286/Makefile.am delete mode 100644 src/conf/ucm/skylake-rt286/skylake-rt286.conf -- 2.7.4

3 4

[alsa-devel] [BUG] src/conf/alsa.conf: Hard-coded path `/etc/asound.conf`, needs `@func sysconfdir`.
by Alain Kalker 20 Mar '17

20 Mar '17

The file `src/conf/alsa.conf` contains the hard-coded path `/etc/asound.conf`, which in some use cases may not be correct. One particular use case: Termux[1], a "Linux subsystem for Android", plans to use ALSA plugins to communicate with the OpenSL ES implementation in Android. In doing so, it needs to not conflict with any vendor provided ALSA implentation, which could conceivably use an `/etc/asound.conf` of its own. At any rate, the system `/etc` directory is normally not writable by non-root users of Android. I would suggest adding a `snd_func_sysconfdir` in `src/confmisc.c (analogous to `snd_func_datadir`) so packagers and users can place a global `asound.conf` file in a directory to which they have write access and which doesn't conflict with the systems ALSA. The desired path can already be specified at build time by using `./configure --sysconfdir=<dir>`, which conveniently defaults to PREFIX/etc in any case. It is available as configure variable: `sysconfdir='${prefix}/etc'`, and only needs to be substituted to be available to `src/confmisc.c`. Kind regards, Alain Kalker [1]: https://termux.com/

2 1

Re: [alsa-devel] [PATCH] ALSA: hda/ca0132: Remove double parentheses
by Takashi Iwai 20 Mar '17

20 Mar '17

On Wed, 15 Mar 2017 23:41:23 +0100, Matthias Kaehlcke wrote: > > The extra pairs of parantheses are not needed and causes clang to > generate warnings like this: > > sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] > if ((buffer == NULL)) > ~~~~~~~^~~~~~~ > sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning > if ((buffer == NULL)) > ~ ^ ~ > sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment > if ((buffer == NULL)) > > Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> Applied, thanks. Takashi

1 0