March 2017 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH] ASoC: blackfin: constify snd_soc_ops structures
by Bhumika Goyal 24 Mar '17

24 Mar '17

Declare snd_soc_ops structures as const as they are only stored in the ops field of a snd_soc_dai_link structure. This field is of type const, so snd_soc_ops structures having this property can be made const too. Cross compiled the .o files for blackfin architecture. Signed-off-by: Bhumika Goyal <bhumirks(a)gmail.com> --- sound/soc/blackfin/bfin-eval-adau1373.c | 2 +- sound/soc/blackfin/bfin-eval-adav80x.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/blackfin/bfin-eval-adau1373.c b/sound/soc/blackfin/bfin-eval-adau1373.c index 72ac789..64b88fd 100644 --- a/sound/soc/blackfin/bfin-eval-adau1373.c +++ b/sound/soc/blackfin/bfin-eval-adau1373.c @@ -119,7 +119,7 @@ static int bfin_eval_adau1373_codec_init(struct snd_soc_pcm_runtime *rtd) return ret; } -static struct snd_soc_ops bfin_eval_adau1373_ops = { +static const struct snd_soc_ops bfin_eval_adau1373_ops = { .hw_params = bfin_eval_adau1373_hw_params, }; diff --git a/sound/soc/blackfin/bfin-eval-adav80x.c b/sound/soc/blackfin/bfin-eval-adav80x.c index 1037477..99e5eca 100644 --- a/sound/soc/blackfin/bfin-eval-adav80x.c +++ b/sound/soc/blackfin/bfin-eval-adav80x.c @@ -64,7 +64,7 @@ static int bfin_eval_adav80x_codec_init(struct snd_soc_pcm_runtime *rtd) return 0; } -static struct snd_soc_ops bfin_eval_adav80x_ops = { +static const struct snd_soc_ops bfin_eval_adav80x_ops = { .hw_params = bfin_eval_adav80x_hw_params, }; -- 2.7.4

2 1

[alsa-devel] [PATCH] ASoC: rcar: enable PCM RATE untile 192000
by Kuninori Morimoto 24 Mar '17

24 Mar '17

From: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> R-Car sound can handle untile 192000 rate. Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- sound/soc/sh/rcar/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index e0b2e9a..5f6e84f 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -96,7 +96,7 @@ #include <linux/pm_runtime.h> #include "rsnd.h" -#define RSND_RATES SNDRV_PCM_RATE_8000_96000 +#define RSND_RATES SNDRV_PCM_RATE_8000_192000 #define RSND_FMTS (SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE) static const struct of_device_id rsnd_of_match[] = { -- 1.9.1

2 1

[alsa-devel] [PATCH] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT
by Kuninori Morimoto 24 Mar '17

24 Mar '17

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> R-Car Datasheet is indicating "SSICR.CKDV = 000 is invalid when SSIWSR.WS_MODE = 1 or SSIWSR.CONT = 1". Current driver will set CONT, thus, we shouldn't use CKDV = 000. This patch fixup it. Reported-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx(a)renesas.com> --- sound/soc/sh/rcar/ssi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 9594d44..d0602c1 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -245,6 +245,15 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) { /* + * It will set SSIWSR.CONT here, but SSICR.CKDV = 000 + * with it is not allowed. (SSIWSR.WS_MODE with + * SSICR.CKDV = 000 is not allowed either). + * Skip it. See SSICR.CKDV + */ + if (j == 0) + continue; + + /* * this driver is assuming that * system word is 32bit x chan * see rsnd_ssi_init() -- 1.9.1

4 5

[alsa-devel] [PATCH v2 0/2] wm8960: Relax bit clock computation
by Daniel Baluta 24 Mar '17

24 Mar '17

This patch series allows playing S20_3LE .wav samples with wm8960 codec. First patch does a small refactoring of sysclk frequency search because wm8960_configure_sysclk was getting pretty convoluted. The second patch allows relaxing bitclock computation in the way that if an exact bitclk couldn't be derived from sysclk it chooses the smalles available bitclk greater than the desired bitclk. Changes since v1: * dropped the RFC tag * comments in each individual patch Daniel Baluta (2): ASoC: codec: wm8960: Refactor sysclk freq search ASoC: codec: wm8960: Relax bit clock computation sound/soc/codecs/wm8960.c | 119 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 97 insertions(+), 22 deletions(-) -- 2.7.4

4 9

[alsa-devel] [PATCH v3 0/2] wm8960: Relax bit clock computation
by Daniel Baluta 24 Mar '17

24 Mar '17

This patch series allows playing S20_3LE .wav samples with wm8960 codec. First patch does a small refactoring of sysclk frequency search because wm8960_configure_sysclk was getting pretty convoluted. The second patch allows relaxing bitclock computation in the way that if an exact bitclk couldn't be derived from sysclk it chooses the smalles available bitclk greater than the desired bitclk. Changes since v2: * do not differentiate between relaxed and exact match Changes since v1: * dropped the RFC tag * comments in each individual patch Daniel Baluta (2): ASoC: codec: wm8960: Refactor sysclk freq search ASoC: codec: wm8960: Relax bit clock computation sound/soc/codecs/wm8960.c | 90 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 71 insertions(+), 19 deletions(-) -- 2.7.4

3 4

[alsa-devel] [PATCH 1/6] regulator: helpers: Add regmap set_soft_start helper
by Charles Keepax 24 Mar '17

24 Mar '17

Add a helper function regulator_set_soft_start_regmap to allow regmap based regulators to easily enable soft start. Signed-off-by: Charles Keepax <ckeepax(a)opensource.wolfsonmicro.com> --- drivers/regulator/helpers.c | 18 ++++++++++++++++++ include/linux/regulator/driver.h | 4 ++++ 2 files changed, 22 insertions(+) diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index 379cdac..a75e7da 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -446,6 +446,24 @@ int regulator_set_bypass_regmap(struct regulator_dev *rdev, bool enable) EXPORT_SYMBOL_GPL(regulator_set_bypass_regmap); /** + * regulator_set_soft_start_regmap - Default set_soft_start() using regmap + * + * @rdev: device to operate on. + */ +int regulator_set_soft_start_regmap(struct regulator_dev *rdev) +{ + unsigned int val; + + val = rdev->desc->soft_start_val_on; + if (!val) + val = rdev->desc->soft_start_mask; + + return regmap_update_bits(rdev->regmap, rdev->desc->soft_start_reg, + rdev->desc->soft_start_mask, val); +} +EXPORT_SYMBOL_GPL(regulator_set_soft_start_regmap); + +/** * regulator_get_bypass_regmap - Default get_bypass() using regmap * * @rdev: device to operate on. diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h index dac8e7b1..7e2e70d 100644 --- a/include/linux/regulator/driver.h +++ b/include/linux/regulator/driver.h @@ -345,6 +345,9 @@ struct regulator_desc { unsigned int active_discharge_off; unsigned int active_discharge_mask; unsigned int active_discharge_reg; + unsigned int soft_start_reg; + unsigned int soft_start_mask; + unsigned int soft_start_val_on; unsigned int enable_time; @@ -476,6 +479,7 @@ int regulator_set_voltage_time_sel(struct regulator_dev *rdev, unsigned int new_selector); int regulator_set_bypass_regmap(struct regulator_dev *rdev, bool enable); int regulator_get_bypass_regmap(struct regulator_dev *rdev, bool *enable); +int regulator_set_soft_start_regmap(struct regulator_dev *rdev); int regulator_set_active_discharge_regmap(struct regulator_dev *rdev, bool enable); -- 2.1.4

4 10

[alsa-devel] [PATCH v2] ASoC: imx-wm8960: Let codec driver enable/disable its MCLK
by Daniel Baluta 24 Mar '17

24 Mar '17

From: Daniel Baluta <daniel.baluta(a)nxp.com> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine driver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Daniel Baluta <daniel.baluta(a)nxp.com> --- Changes since v1: * s/wm8960/imx-wm890/ in subject prefix * s/dirver/driver in commit message * took ownership over the patch from Nicolin Chen as per his agreement. sound/soc/fsl/imx-wm8962.c | 40 ++++++++-------------------------------- 1 file changed, 8 insertions(+), 32 deletions(-) diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c index 1b60958..3d894d9 100644 --- a/sound/soc/fsl/imx-wm8962.c +++ b/sound/soc/fsl/imx-wm8962.c @@ -33,7 +33,6 @@ struct imx_wm8962_data { struct snd_soc_card card; char codec_dai_name[DAI_NAME_SIZE]; char platform_name[DAI_NAME_SIZE]; - struct clk *codec_clk; unsigned int clk_frequency; }; @@ -163,6 +162,7 @@ static int imx_wm8962_probe(struct platform_device *pdev) struct imx_priv *priv = &card_priv; struct i2c_client *codec_dev; struct imx_wm8962_data *data; + struct clk *codec_clk; int int_port, ext_port; int ret; @@ -231,19 +231,14 @@ static int imx_wm8962_probe(struct platform_device *pdev) goto fail; } - data->codec_clk = devm_clk_get(&codec_dev->dev, NULL); - if (IS_ERR(data->codec_clk)) { - ret = PTR_ERR(data->codec_clk); + codec_clk = devm_clk_get(&codec_dev->dev, NULL); + if (IS_ERR(codec_clk)) { + ret = PTR_ERR(codec_clk); dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret); goto fail; } - data->clk_frequency = clk_get_rate(data->codec_clk); - ret = clk_prepare_enable(data->codec_clk); - if (ret) { - dev_err(&codec_dev->dev, "failed to enable codec clk: %d\n", ret); - goto fail; - } + data->clk_frequency = clk_get_rate(codec_clk); data->dai.name = "HiFi"; data->dai.stream_name = "HiFi"; @@ -258,10 +253,10 @@ static int imx_wm8962_probe(struct platform_device *pdev) data->card.dev = &pdev->dev; ret = snd_soc_of_parse_card_name(&data->card, "model"); if (ret) - goto clk_fail; + goto fail; ret = snd_soc_of_parse_audio_routing(&data->card, "audio-routing"); if (ret) - goto clk_fail; + goto fail; data->card.num_links = 1; data->card.owner = THIS_MODULE; data->card.dai_link = &data->dai; @@ -277,16 +272,9 @@ static int imx_wm8962_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, &data->card); if (ret) { dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); - goto clk_fail; + goto fail; } - of_node_put(ssi_np); - of_node_put(codec_np); - - return 0; - -clk_fail: - clk_disable_unprepare(data->codec_clk); fail: of_node_put(ssi_np); of_node_put(codec_np); @@ -294,17 +282,6 @@ static int imx_wm8962_probe(struct platform_device *pdev) return ret; } -static int imx_wm8962_remove(struct platform_device *pdev) -{ - struct snd_soc_card *card = platform_get_drvdata(pdev); - struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card); - - if (!IS_ERR(data->codec_clk)) - clk_disable_unprepare(data->codec_clk); - - return 0; -} - static const struct of_device_id imx_wm8962_dt_ids[] = { { .compatible = "fsl,imx-audio-wm8962", }, { /* sentinel */ } @@ -318,7 +295,6 @@ static struct platform_driver imx_wm8962_driver = { .of_match_table = imx_wm8962_dt_ids, }, .probe = imx_wm8962_probe, - .remove = imx_wm8962_remove, }; module_platform_driver(imx_wm8962_driver); -- 2.7.4

2 1

[alsa-devel] [GIT PULL] Broxton audio fw update
by Vinod Koul 24 Mar '17

24 Mar '17

Hi, Please pull to receive updated audio firmware for broxton platform. The following changes since commit e39f0e3e6897ad865b3704f61218ae83f98a85da: Merge git://git.marvell.com/mwifiex-firmware (2017-03-14 08:58:33 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/firmware.git apl for you to fetch changes up to a4dde74b504522d239e8521617b53b03f393ed6a: linux-firmware: intel: Update Broxton audio firmware (2017-03-22 21:53:18 +0530) ---------------------------------------------------------------- Subhransu S. Prusty (1): linux-firmware: intel: Update Broxton audio firmware WHENCE | 4 +++- intel/dsp_fw_bxtn.bin | 2 +- intel/dsp_fw_bxtn_v2219.bin | Bin 0 -> 505608 bytes 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 intel/dsp_fw_bxtn_v2219.bin -- ~Vinod

2 1

[alsa-devel] sound: use-after-free in snd_seq_cell_alloc
by Dmitry Vyukov 24 Mar '17

24 Mar '17

Hello, I've got the following report while running syzkaller fuzzer on 093b995e3b55a0ae0670226ddfcb05bfbf0099ae. Unfortunately this is not reproducible so far. ================================================================== BUG: KASAN: use-after-free in __lock_acquire+0x39df/0x3a80 kernel/locking/lockdep.c:3230 at addr ffff8800495fb6a0 Read of size 8 by task syz-executor7/17253 CPU: 2 PID: 17253 Comm: syz-executor7 Not tainted 4.11.0-rc3+ #364 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 Call Trace: __asan_report_load8_noabort+0x29/0x30 mm/kasan/report.c:337 __lock_acquire+0x39df/0x3a80 kernel/locking/lockdep.c:3230 lock_acquire+0x1ee/0x590 kernel/locking/lockdep.c:3762 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9f/0xd0 kernel/locking/spinlock.c:159 snd_seq_cell_alloc.isra.1+0x17d/0x6a0 sound/core/seq/seq_memory.c:238 snd_seq_event_dup+0x15d/0xa00 sound/core/seq/seq_memory.c:309 snd_seq_fifo_event_in+0xe3/0x420 sound/core/seq/seq_fifo.c:128 snd_seq_deliver_single_event.constprop.12+0x814/0x980 sound/core/seq/seq_clientmgr.c:615 snd_seq_deliver_event+0x12c/0x720 sound/core/seq/seq_clientmgr.c:818 snd_seq_kernel_client_dispatch+0x131/0x160 sound/core/seq/seq_clientmgr.c:2319 snd_seq_system_notify+0x11b/0x160 sound/core/seq/seq_system.c:112 snd_seq_client_notify_subscription+0x16f/0x210 sound/core/seq/seq_clientmgr.c:1414 subscribe_port sound/core/seq/seq_ports.c:434 [inline] check_and_subscribe_port+0x725/0x950 sound/core/seq/seq_ports.c:510 snd_seq_port_connect+0x3e5/0x700 sound/core/seq/seq_ports.c:579 snd_seq_ioctl_subscribe_port+0x24b/0x300 sound/core/seq/seq_clientmgr.c:1443 snd_seq_kernel_client_ctl+0x122/0x160 sound/core/seq/seq_clientmgr.c:2350 snd_seq_oss_midi_open+0x640/0x850 sound/core/seq/oss/seq_oss_midi.c:375 snd_seq_oss_synth_setup_midi+0x109/0x4d0 sound/core/seq/oss/seq_oss_synth.c:281 snd_seq_oss_open+0x70f/0x8b0 sound/core/seq/oss/seq_oss_init.c:274 odev_open+0x6a/0x90 sound/core/seq/oss/seq_oss.c:138 soundcore_open+0x321/0x630 sound/sound_core.c:639 chrdev_open+0x257/0x730 fs/char_dev.c:392 do_dentry_open+0x710/0xc80 fs/open.c:751 vfs_open+0x105/0x220 fs/open.c:864 do_last fs/namei.c:3349 [inline] path_openat+0x1151/0x35b0 fs/namei.c:3490 do_filp_open+0x249/0x370 fs/namei.c:3525 do_sys_open+0x502/0x6d0 fs/open.c:1051 SYSC_openat fs/open.c:1078 [inline] SyS_openat+0x30/0x40 fs/open.c:1072 entry_SYSCALL_64_fastpath+0x1f/0xc2 RIP: 0033:0x445b79 RSP: 002b:00007f02452a6858 EFLAGS: 00000292 ORIG_RAX: 0000000000000101 RAX: ffffffffffffffda RBX: 0000000000708000 RCX: 0000000000445b79 RDX: 0000000000000000 RSI: 0000000020063ff0 RDI: ffffffffffffff9c RBP: 0000000000000086 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000292 R12: 00000000006e0fe0 R13: 0000000000001000 R14: 0000000000000003 R15: 0000000020000000 Object at ffff8800495fb600, in cache kmalloc-192 size: 192 Allocated: PID = 17260 kmalloc include/linux/slab.h:490 [inline] kzalloc include/linux/slab.h:663 [inline] snd_seq_pool_new+0x93/0x2f0 sound/core/seq/seq_memory.c:470 snd_seq_fifo_new+0xc3/0x360 sound/core/seq/seq_fifo.c:41 snd_seq_open+0x404/0x520 sound/core/seq/seq_clientmgr.c:333 snd_open+0x1fa/0x3f0 sound/core/sound.c:177 chrdev_open+0x257/0x730 fs/char_dev.c:392 do_dentry_open+0x710/0xc80 fs/open.c:751 vfs_open+0x105/0x220 fs/open.c:864 do_last fs/namei.c:3349 [inline] path_openat+0x1151/0x35b0 fs/namei.c:3490 do_filp_open+0x249/0x370 fs/namei.c:3525 do_sys_open+0x502/0x6d0 fs/open.c:1051 SYSC_open fs/open.c:1069 [inline] SyS_open+0x2d/0x40 fs/open.c:1064 entry_SYSCALL_64_fastpath+0x1f/0xc2 Freed: PID = 17280 kfree+0xd7/0x250 mm/slab.c:3831 snd_seq_pool_delete+0x52/0x70 sound/core/seq/seq_memory.c:498 snd_seq_fifo_resize+0x263/0x3e0 sound/core/seq/seq_fifo.c:275 snd_seq_ioctl_set_client_pool+0x481/0x600 sound/core/seq/seq_clientmgr.c:1849 snd_seq_ioctl+0x204/0x470 sound/core/seq/seq_clientmgr.c:2131 vfs_ioctl fs/ioctl.c:45 [inline] do_vfs_ioctl+0x1af/0x16d0 fs/ioctl.c:685 SYSC_ioctl fs/ioctl.c:700 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:691 entry_SYSCALL_64_fastpath+0x1f/0xc2 Memory state around the buggy address: ffff8800495fb580: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ffff8800495fb600: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >ffff8800495fb680: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ^ ffff8800495fb700: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb ffff8800495fb780: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc ==================================================================

2 1

[alsa-devel] Regressions on x86(_64) and >128 mixer controls
by Mark Hills 24 Mar '17

24 Mar '17

I have an echo3g (Layla) PCI soundcard on x86_64. alsamixer and alsactl fail with the following: alsactl: control.c:2976: snd_ctl_elem_value_get_integer: Assertion `idx < ARRAY_SIZE(obj->value.integer.value)' failed. In question is idx=128, and this "value" array in alsa-lib: struct snd_ctl_elem_value { struct snd_ctl_elem_id id; /* W: element ID */ unsigned int indirect: 1; /* W: indirect access - obsoleted */ union { union { long value[128]; long *value_ptr; /* obsoleted */ } integer; At first it appears just to be hitting the fixed limit of 128. However, this used to work -- and at the time I was using 32-bit kernel and userland on an otherwise similar system (not they are both 64-bit) Increasing the array size cascades to a new problem which suggests these controls don't actually exist: ./alsactl/alsactl: get_control:258: Cannot read control '2,0,0,PCM Playback Volume,0': Inappropriate ioctl for device So I investigated the origin of this 256, which is here in linux/sound/pci/echoaudio/echoaudio.c: static int snd_echo_mixer_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo) { struct echoaudio *chip; chip = snd_kcontrol_chip(kcontrol); uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER; uinfo->value.integer.min = ECHOGAIN_MINOUT; uinfo->value.integer.max = ECHOGAIN_MAXOUT; uinfo->dimen.d[0] = num_busses_out(chip); /* = 16 */ uinfo->dimen.d[1] = num_busses_in(chip); /* = 16 */ uinfo->count = uinfo->dimen.d[0] * uinfo->dimen.d[1]; /* = 256 */ return 0; } These values are derived from constants in the source code for this Layla3G device; I can find nothing on this path that would cause variation between a 32-bit and 64-bit kernel -- the code suggests like this value has always been 256 in the kernel, so I can't come up with a reason that it could vary. I don't have enough knowledge of the hardware to know if 256 /is/ the correct value here. Something which may be related happened for a period when I was using 32-bit userland with 64-bit kernel. This broke a number of tools (incl. echomixer) Compare alsa-lib/include/alsa/asound.h: struct snd_ctl_elem_info { struct snd_ctl_elem_id id; /* W: element ID */ snd_ctl_elem_type_t type; /* R: value type - SNDRV_CTL_ELEM_TYPE_* */ unsigned int access; /* R: value access (bitmask) - SNDRV_CTL_ELEM_ACCESS_* */ unsigned int count; /* count of values */ __kernel_pid_t owner; /* owner's PID of this control */ union { struct { long min; /* R: minimum value */ long max; /* R: maximum value */ long step; /* R: step (0 variable) */ } integer; and notice the use of 'long' in this struct. It has a shadow/equivalent/identical in linux/uapi/sound/asound.h, copied to userland, using: if (ioctl(hw->fd, SNDRV_CTL_IOCTL_ELEM_INFO, info) < 0) return -errno; The kernel and userland can have different interpretations of 'long'; do these really not need to be the 'int' type? Though maybe I am missing something -- surely I am not the only person to have used a 32-bit userland on a 64-bit kernel? -- Mark

1 0