June 2015 - Alsa-devel - mailman.alsa-project.org

[alsa-devel] [PATCH v3 1/3] ASoC: wm_adsp: Add code_probe and codec_remove stubs
by Richard Fitzgerald 10 Jun '15

10 Jun '15

Currently the only init function in wm_adsp is called by the codec driver early in its probe before the codec has been registered with SOC. This patch adds stubs for the codec_probe and codec_remove stages and calls them from WM5102 and WM5110 codec drivers. This allows us to hang anything that needs setup during the codec probe stage off these functions without further modification of the codec drivers. Signed-off-by: Richard Fitzgerald <rf(a)opensource.wolfsonmicro.com> --- sound/soc/codecs/wm5102.c | 6 ++++++ sound/soc/codecs/wm5110.c | 12 +++++++++++- sound/soc/codecs/wm_adsp.c | 12 ++++++++++++ sound/soc/codecs/wm_adsp.h | 2 ++ 4 files changed, 31 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm5102.c b/sound/soc/codecs/wm5102.c index 11eba0e..341d96e 100644 --- a/sound/soc/codecs/wm5102.c +++ b/sound/soc/codecs/wm5102.c @@ -1875,6 +1875,10 @@ static int wm5102_codec_probe(struct snd_soc_codec *codec) struct wm5102_priv *priv = snd_soc_codec_get_drvdata(codec); int ret; + ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec); + if (ret) + return ret; + ret = snd_soc_add_codec_controls(codec, wm_adsp2_fw_controls, 2); if (ret != 0) return ret; @@ -1893,6 +1897,8 @@ static int wm5102_codec_remove(struct snd_soc_codec *codec) { struct wm5102_priv *priv = snd_soc_codec_get_drvdata(codec); + wm_adsp2_codec_remove(&priv->core.adsp[0], codec); + priv->core.arizona->dapm = NULL; return 0; diff --git a/sound/soc/codecs/wm5110.c b/sound/soc/codecs/wm5110.c index d65364e..6e15d9c 100644 --- a/sound/soc/codecs/wm5110.c +++ b/sound/soc/codecs/wm5110.c @@ -1599,7 +1599,7 @@ static struct snd_soc_dai_driver wm5110_dai[] = { static int wm5110_codec_probe(struct snd_soc_codec *codec) { struct wm5110_priv *priv = snd_soc_codec_get_drvdata(codec); - int ret; + int i, ret; priv->core.arizona->dapm = &codec->dapm; @@ -1607,6 +1607,12 @@ static int wm5110_codec_probe(struct snd_soc_codec *codec) arizona_init_gpio(codec); arizona_init_mono(codec); + for (i = 0; i < WM5110_NUM_ADSP; ++i) { + ret = wm_adsp2_codec_probe(&priv->core.adsp[i], codec); + if (ret) + return ret; + } + ret = snd_soc_add_codec_controls(codec, wm_adsp2_fw_controls, 8); if (ret != 0) return ret; @@ -1621,6 +1627,10 @@ static int wm5110_codec_probe(struct snd_soc_codec *codec) static int wm5110_codec_remove(struct snd_soc_codec *codec) { struct wm5110_priv *priv = snd_soc_codec_get_drvdata(codec); + int i; + + for (i = 0; i < WM5110_NUM_ADSP; ++i) + wm_adsp2_codec_remove(&priv->core.adsp[i], codec); priv->core.arizona->dapm = NULL; diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 6e358b5..490edb3 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -1906,6 +1906,18 @@ err: } EXPORT_SYMBOL_GPL(wm_adsp2_event); +int wm_adsp2_codec_probe(struct wm_adsp *dsp, struct snd_soc_codec *codec) +{ + return 0; +} +EXPORT_SYMBOL_GPL(wm_adsp2_codec_probe); + +int wm_adsp2_codec_remove(struct wm_adsp *dsp, struct snd_soc_codec *codec) +{ + return 0; +} +EXPORT_SYMBOL_GPL(wm_adsp2_codec_remove); + int wm_adsp2_init(struct wm_adsp *dsp) { int ret; diff --git a/sound/soc/codecs/wm_adsp.h b/sound/soc/codecs/wm_adsp.h index 0e5f07c..5584e34 100644 --- a/sound/soc/codecs/wm_adsp.h +++ b/sound/soc/codecs/wm_adsp.h @@ -79,6 +79,8 @@ extern const struct snd_kcontrol_new wm_adsp2_fw_controls[]; int wm_adsp1_init(struct wm_adsp *dsp); int wm_adsp2_init(struct wm_adsp *dsp); +int wm_adsp2_codec_probe(struct wm_adsp *dsp, struct snd_soc_codec *codec); +int wm_adsp2_codec_remove(struct wm_adsp *dsp, struct snd_soc_codec *codec); int wm_adsp1_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event); int wm_adsp2_early_event(struct snd_soc_dapm_widget *w, -- 1.7.2.5

2 3

[alsa-devel] [PATCH 1/3 RESEND] ASoC: rt5645: make RT5650_TDM_CTRL_4 readable
by Oder Chiou 10 Jun '15

10 Jun '15

Register RT5650_TDM_CTRL_4(0x7A) is readable and used for mixer setting. It should be added in rt5645_readable_register function. Signed-off-by: Bard Liao <bardliao(a)realtek.com> Signed-off-by: Oder Chiou <oder_chiou(a)realtek.com> --- sound/soc/codecs/rt5645.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index d5f0f56..b86474a 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -349,6 +349,7 @@ static bool rt5645_readable_register(struct device *dev, unsigned int reg) case RT5645_TDM_CTRL_1: case RT5645_TDM_CTRL_2: case RT5645_TDM_CTRL_3: + case RT5650_TDM_CTRL_4: case RT5645_GLB_CLK: case RT5645_PLL_CTRL1: case RT5645_PLL_CTRL2: -- 1.8.1.1.439.g50a6b54

2 1

[alsa-devel] [PATCH] ASoC: rt5645: Lock mutex in rt5645_enable_push_button_irq
by Nicolas Boichat 10 Jun '15

10 Jun '15

rt5645_enable_push_button_irq uses snd_soc_dapm_*_unlocked functions, so it needs to lock the required dapm mutex. Signed-off-by: Nicolas Boichat <drinkcat(a)chromium.org> --- sound/soc/codecs/rt5645.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index d5f0f56..025cf14 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -2761,6 +2761,7 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, struct rt5645_priv *rt5645 = snd_soc_codec_get_drvdata(codec); if (enable) { + snd_soc_dapm_mutex_lock(&codec->dapm); snd_soc_dapm_force_enable_pin_unlocked(&codec->dapm, "ADC L power"); snd_soc_dapm_force_enable_pin_unlocked(&codec->dapm, @@ -2770,6 +2771,8 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, snd_soc_dapm_force_enable_pin_unlocked(&codec->dapm, "Mic Det Power"); snd_soc_dapm_sync_unlocked(&codec->dapm); + snd_soc_dapm_mutex_unlock(&codec->dapm); + snd_soc_update_bits(codec, RT5645_INT_IRQ_ST, 0x8, 0x8); snd_soc_update_bits(codec, @@ -2780,6 +2783,8 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, } else { snd_soc_update_bits(codec, RT5650_4BTN_IL_CMD2, 0x8000, 0x0); snd_soc_update_bits(codec, RT5645_INT_IRQ_ST, 0x8, 0x0); + + snd_soc_dapm_mutex_lock(&codec->dapm); snd_soc_dapm_disable_pin_unlocked(&codec->dapm, "ADC L power"); snd_soc_dapm_disable_pin_unlocked(&codec->dapm, @@ -2790,6 +2795,7 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec, snd_soc_dapm_disable_pin_unlocked(&codec->dapm, "Mic Det Power"); snd_soc_dapm_sync_unlocked(&codec->dapm); + snd_soc_dapm_mutex_unlock(&codec->dapm); } } -- 2.2.0.rc0.207.ga3a616c

2 1

[alsa-devel] [PATCH v6 0/2] ASoC: qcom: add support to apq8016 sbc machine driver
by Srinivas Kandagatla 10 Jun '15

10 Jun '15

This patchset adds sound card support to APQ8016 SBC board aka DB410c. APQ8016 has 4 MI2S( Primary, Secondary, Tertiary, Quaternary) which can be routed to internal wcd codec or external codecs. This routing and various board specifics are controlled by 2 mux registers. All these patches are tested for HDMI audio via adv7533 bridge and Analog audio on APQ8016-SBC, msm8916-mtp boards. Changes since v5: - converted if-else to switch case as suggested by Mark. - moved usage of startup() to dai link init() as suggested by Mark. - replaced "external" boolean property with "link-name" property as suggested by Mark. Changes since v4 (https://lkml.org/lkml/2015/5/22/628) - moved all the dt parsing to single function, spotted by Mark. - removed unnecessary setting of card->dev = NULL spotted by Mark. - renamed the dai links to the correct codec names. - removed the special case for EPROBE_DEFER in probe, spotted by Mark. - Dropped all the Changes since comments as most of the patches in last series are merged to topic/qcom branch. --srini Srinivas Kandagatla (2): ASoC: qcom: document apq8016 sbc machine driver bindings ASoC: qcom: add apq8016 sound card support .../devicetree/bindings/sound/qcom,apq8016-sbc.txt | 60 +++++++ sound/soc/qcom/Kconfig | 9 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/apq8016_sbc.c | 198 +++++++++++++++++++++ 4 files changed, 269 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,apq8016-sbc.txt create mode 100644 sound/soc/qcom/apq8016_sbc.c -- 1.9.1

2 3

[alsa-devel] [PATCH - alsa-lib 1/1] Introduce snd_seq_client_info_get_card_number, for getting the card number of a seq client on recent kernels
by Adam Goode 10 Jun '15

10 Jun '15

Signed-off-by: Adam Goode <agoode(a)google.com> diff --git a/configure.ac b/configure.ac index 9621d4e..01bb0fb 100644 --- a/configure.ac +++ b/configure.ac @@ -14,7 +14,7 @@ dnl remove API = c+1:0:0 dnl ************************************************* AC_CANONICAL_HOST AM_INIT_AUTOMAKE -eval LIBTOOL_VERSION_INFO="2:0:0" +eval LIBTOOL_VERSION_INFO="3:0:1" dnl ************************************************* AM_CONDITIONAL([INSTALL_M4], [test -n "${ACLOCAL}"]) diff --git a/include/seq.h b/include/seq.h index 9576822..e0f9b78 100644 --- a/include/seq.h +++ b/include/seq.h @@ -146,6 +146,7 @@ int snd_seq_client_info_get_error_bounce(const snd_seq_client_info_t *info); const unsigned char *snd_seq_client_info_get_event_filter(const snd_seq_client_info_t *info); int snd_seq_client_info_get_num_ports(const snd_seq_client_info_t *info); int snd_seq_client_info_get_event_lost(const snd_seq_client_info_t *info); +int snd_seq_client_info_get_card_number(const snd_seq_client_info_t *info); void snd_seq_client_info_set_client(snd_seq_client_info_t *info, int client); void snd_seq_client_info_set_name(snd_seq_client_info_t *info, const char *name); diff --git a/include/sound/asequencer.h b/include/sound/asequencer.h index 09c8a00..c2a659b 100644 --- a/include/sound/asequencer.h +++ b/include/sound/asequencer.h @@ -22,9 +22,10 @@ #ifndef _UAPI__SOUND_ASEQUENCER_H #define _UAPI__SOUND_ASEQUENCER_H +#include <sound/asound.h> /** version of the sequencer */ -#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 1) +#define SNDRV_SEQ_VERSION SNDRV_PROTOCOL_VERSION (1, 0, 2) /** * definition of sequencer event types @@ -356,7 +357,8 @@ struct snd_seq_client_info { unsigned char event_filter[32]; /* event filter bitmap */ int num_ports; /* RO: number of ports */ int event_lost; /* number of lost events */ - char reserved[64]; /* for future use */ + int card_number; /* RO: card number, or -1 if no card. Added in protocol version 1.0.2 */ + char reserved[60]; /* for future use */ }; diff --git a/src/seq/seq.c b/src/seq/seq.c index 620ca3f..bc39046 100644 --- a/src/seq/seq.c +++ b/src/seq/seq.c @@ -1651,6 +1651,18 @@ int snd_seq_client_info_get_event_lost(const snd_seq_client_info_t *info) } /** + * \brief Get the card number of a client_info container + * \param info client_info container + * \return the card number, -1 if no card associated with this client, or -ENOSYS if the + * kernel does not support reporting this field + */ +int snd_seq_client_info_get_card_number(const snd_seq_client_info_t *info) +{ + assert(info); + return info->card_number; +} + +/** * \brief Set the client id of a client_info container * \param info client_info container * \param client client id diff --git a/src/seq/seq_hw.c b/src/seq/seq_hw.c index d033367..8502d63 100644 --- a/src/seq/seq_hw.c +++ b/src/seq/seq_hw.c @@ -32,10 +32,11 @@ const char *_snd_module_seq_hw = ""; #ifndef DOC_HIDDEN #define SNDRV_FILE_SEQ ALSA_DEVICE_DIRECTORY "seq" #define SNDRV_FILE_ALOADSEQ ALOAD_DEVICE_DIRECTORY "aloadSEQ" -#define SNDRV_SEQ_VERSION_MAX SNDRV_PROTOCOL_VERSION(1, 0, 1) +#define SNDRV_SEQ_VERSION_MAX SNDRV_PROTOCOL_VERSION(1, 0, 2) typedef struct { int fd; + int version; } snd_seq_hw_t; #endif /* DOC_HIDDEN */ @@ -100,6 +101,10 @@ static int snd_seq_hw_get_client_info(snd_seq_t *seq, snd_seq_client_info_t * in /*SYSERR("SNDRV_SEQ_IOCTL_GET_CLIENT_INFO failed");*/ return -errno; } + /* The card_number field was added in protocol 1.0.2, so set to -ENOSYS if older. */ + if (hw->version < SNDRV_PROTOCOL_VERSION(1, 0, 2)) { + info->card_number = -ENOSYS; + } return 0; } @@ -368,6 +373,10 @@ static int snd_seq_hw_query_next_client(snd_seq_t *seq, snd_seq_client_info_t *i /*SYSERR("SNDRV_SEQ_IOCTL_QUERY_NEXT_CLIENT failed");*/ return -errno; } + /* The card_number field was added in protocol 1.0.2, so set to -ENOSYS if older. */ + if (hw->version < SNDRV_PROTOCOL_VERSION(1, 0, 2)) { + info->card_number = -ENOSYS; + } return 0; } @@ -480,6 +489,7 @@ int snd_seq_hw_open(snd_seq_t **handle, const char *name, int streams, int mode) return -ENOMEM; } hw->fd = fd; + hw->version = ver; if (streams & SND_SEQ_OPEN_OUTPUT) { seq->obuf = (char *) malloc(seq->obufsize = SND_SEQ_OBUF_SIZE); if (!seq->obuf) { diff --git a/test/seq.c b/test/seq.c index 34b000f..a4e5f1f 100644 --- a/test/seq.c +++ b/test/seq.c @@ -111,7 +111,7 @@ void show_port_info(snd_seq_t *handle, int client, int port) void show_client_info(snd_seq_t *handle, int client) { - int err, idx, min, max; + int err, idx, min, max, card_number; snd_seq_client_info_t *info; snd_seq_client_info_alloca(&info); @@ -124,11 +124,14 @@ void show_client_info(snd_seq_t *handle, int client) fprintf(stderr, "Client %i info error: %s\n", idx, snd_strerror(err)); exit(0); } + card_number = snd_seq_client_info_get_card_number(info); printf("Client %i info\n", idx); if (verbose) printf(" Client : %i\n", snd_seq_client_info_get_client(info)); printf(" Type : %s\n", snd_seq_client_info_get_type(info) == SND_SEQ_KERNEL_CLIENT ? "kernel" : "user"); printf(" Name : %s\n", snd_seq_client_info_get_name(info)); + if (card_number != -ENOSYS) + printf(" Card Number : %i\n", card_number); } } -- 2.2.0.rc0.207.ga3a616c

3 3

[alsa-devel] [PATCH v3 0/2] Update ALSA driver to use media controller API
by Shuah Khan 10 Jun '15

10 Jun '15

This patch series updates ALSA driver to use media controller API to share tuner with DVB and V4L2 drivers that control AU0828 media device. Two new interfaces are added to media controller API to enable creating media device as a device resource. This allows creating media device as a device resource on the main struct device that is common to all drivers that control a single media hardware and share resources on it. Drivers then can find the common media device to register entities and manage links, and pipelines. Tested with and without CONFIG_MEDIA_CONTROLLER enabled. Tested tuner entity doesn't exist case as au0828 v4l2 driver is the one that will create the tuner when it gets updated to use media controller API. Please note that au0828 updates media controller are necessary before the resource sharing can work across ALSA and au0828 dvb and v4l2 drivers. This work is in progress and another developer is working on it. Changes since v1: - Moved media specific code into new header and source file - Created a new structure for media controller specific fields - Added a new define USE_MEDIA_CONTROLLER to add media specific code. This new define is defined only when Media Controller support is enabled. New media specific code is active only when this define is defined. - Moved media_deviced_delete() check under !was_shutdown block - Removed return check for media_device_init() - Changed new Media Controller interface names for clarity. Now they are named media_device_get_devres() and media_device_find_devres(). - Calling media_entity_pipeline_stop() on a pipe that isn't active appears to be safe. This needs further testing once AU0828 media controller patches are ready. Changes since v2: - Moved checks to define USE_MEDIA_CONTROLLER to Makefile - Moved stubs for media controller specific functions to header file. - Added new register_notify operation to media_entity_operations structure. This new hook is called when a new entity is registered to allow other entities associated with the media device to create link as needed. - Added a new field to struct media_entity for entity owners to save their private data. - Is it safe for ALSA to call media_entity_remove_links()? Laurent Pinchart, please comment. - Do start/stop pipeline functions have to be concered about V4l2? Are they safe the way they are? Hans, please comment. Shuah Khan (2): media: media controller entity framework enhancements for ALSA sound/usb: Update ALSA driver to use media controller API drivers/media/media-device.c | 7 ++ include/media/media-entity.h | 4 + sound/usb/Makefile | 15 +++- sound/usb/card.c | 5 ++ sound/usb/card.h | 1 + sound/usb/media.c | 185 +++++++++++++++++++++++++++++++++++++++++++ sound/usb/media.h | 47 +++++++++++ sound/usb/pcm.c | 10 ++- sound/usb/quirks-table.h | 1 + sound/usb/quirks.c | 9 ++- sound/usb/stream.c | 3 + sound/usb/usbaudio.h | 1 + 12 files changed, 285 insertions(+), 3 deletions(-) create mode 100644 sound/usb/media.c create mode 100644 sound/usb/media.h -- 2.1.4

1 2

Re: [alsa-devel] [PATCH v7 0/3] HDA: add extended HDA
by Vinod Koul 10 Jun '15

10 Jun '15

On Wed, Jun 10, 2015 at 04:56:28PM +0530, Subhransu S. Prusty wrote: > There is an error in this series. Vinod will resend shortly. > Yes some dead code crept in and checkpatch wasnt too happy with few lines, so I have updated this and resent the fixed series. Sorry about the noise -- ~Vinod > On Wed, Jun 10, 2015 at 05:03:33PM +0530, Vinod Koul wrote: > > New HDA controllers from Intel have extended HDA capabilities like multilink, > > pipe processing, SPIB, GTS etc In order to use them we create an extended > > HDA bus, controller and stream which uses the extended configuration > > > > Changes in v7: > > - Feedback from Takashi > > - removed the macros for register read/writes > > - add new macros for reg update > > - fix bus pointer macro > > - header cleanup on c/h files > > - new device name ehdaudioiDn > > - removed flags for ext caps, use pointer only > > - moved module info to patch 1 > > - sparse check on series > > - remove codec name in link > > > > Jeeja KP (3): > > ALSA: hdac_ext: add extended HDA bus > > ALSA: hdac_ext: add hdac extended controller > > ALSA: hdac_ext: add extended stream capabilities > > > > include/sound/hdaudio_ext.h | 129 ++++++++++++ > > sound/hda/Kconfig | 4 + > > sound/hda/Makefile | 3 + > > sound/hda/ext/Makefile | 3 + > > sound/hda/ext/hdac_ext_bus.c | 116 +++++++++++ > > sound/hda/ext/hdac_ext_controller.c | 297 ++++++++++++++++++++++++++ > > sound/hda/ext/hdac_ext_stream.c | 402 ++++++++++++++++++++++++++++++++++++ > > 7 files changed, 954 insertions(+) > > create mode 100644 include/sound/hdaudio_ext.h > > create mode 100644 sound/hda/ext/Makefile > > create mode 100644 sound/hda/ext/hdac_ext_bus.c > > create mode 100644 sound/hda/ext/hdac_ext_controller.c > > create mode 100644 sound/hda/ext/hdac_ext_stream.c > > > > -- > > 1.9.1 > > > > -- --

1 0

[alsa-devel] [PATCH v7 0/3] HDA: add extended HDA
by Vinod Koul 10 Jun '15

10 Jun '15

New HDA controllers from Intel have extended HDA capabilities like multilink, pipe processing, SPIB, GTS etc In order to use them we create an extended HDA bus, controller and stream which uses the extended configuration Changes in v7: - Feedback from Takashi - removed the macros for register read/writes - add new macros for reg update - fix bus pointer macro - header cleanup on c/h files - new device name ehdaudioiDn - removed flags for ext caps, use pointer only - moved module info to patch 1 - sparse check on series - remove codec name in link Jeeja KP (3): ALSA: hdac_ext: add extended HDA bus ALSA: hdac_ext: add hdac extended controller ALSA: hdac_ext: add extended stream capabilities include/sound/hdaudio_ext.h | 129 ++++++++++++ sound/hda/Kconfig | 4 + sound/hda/Makefile | 3 + sound/hda/ext/Makefile | 3 + sound/hda/ext/hdac_ext_bus.c | 116 +++++++++++ sound/hda/ext/hdac_ext_controller.c | 297 ++++++++++++++++++++++++++ sound/hda/ext/hdac_ext_stream.c | 402 ++++++++++++++++++++++++++++++++++++ 7 files changed, 954 insertions(+) create mode 100644 include/sound/hdaudio_ext.h create mode 100644 sound/hda/ext/Makefile create mode 100644 sound/hda/ext/hdac_ext_bus.c create mode 100644 sound/hda/ext/hdac_ext_controller.c create mode 100644 sound/hda/ext/hdac_ext_stream.c -- 1.9.1

2 4

[alsa-devel] [PATCH] ALSA: hda - PCH HDA controller not controlled by i915 power
by libin.yang＠intel.com 10 Jun '15

10 Jun '15

From: Libin Yang <libin.yang(a)intel.com> On some Intel platforms, the HDMI codec is connected to PCH HDA controller. In this case, AZX_DCAPS_I915_POWERWELL is set and the i915 power well failure should not block the hda controller initialization. Signed-off-by: Libin Yang <libin.yang(a)intel.com> --- sound/hda/hdac_i915.c | 6 +++--- sound/pci/hda/hda_intel.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index cb78c25..4f4036a 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -27,7 +27,7 @@ int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable) { struct i915_audio_component *acomp = bus->audio_component; - if (!acomp->ops) + if (!acomp || !acomp->ops) return -ENODEV; if (!acomp->ops->codec_wake_override) { @@ -49,7 +49,7 @@ int snd_hdac_display_power(struct hdac_bus *bus, bool enable) { struct i915_audio_component *acomp = bus->audio_component; - if (!acomp->ops) + if (!acomp || !acomp->ops) return -ENODEV; dev_dbg(bus->dev, "display power %s\n", @@ -72,7 +72,7 @@ int snd_hdac_get_display_clk(struct hdac_bus *bus) { struct i915_audio_component *acomp = bus->audio_component; - if (!acomp->ops) + if (!acomp || !acomp->ops) return -ENODEV; return acomp->ops->get_cdclk_freq(acomp->dev); diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 7933fb0..775e020 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -1986,14 +1986,21 @@ static int azx_probe_continue(struct azx *chip) hda->need_i915_power = 1; err = snd_hdac_i915_init(bus); + /* if controller is located in powerwell, + * the initialization should be stopped. + * if only codec is located in powerwell, + * the hd audio is still ok for analog audio + */ if (err < 0) - goto i915_power_fail; + if (hda->need_i915_power) + goto i915_power_fail; err = snd_hdac_display_power(bus, true); if (err < 0) { dev_err(chip->card->dev, "Cannot turn on display power on i915\n"); - goto i915_power_fail; + if (hda->need_i915_power) + goto i915_power_fail; } } -- 1.9.1

4 9

[alsa-devel] [PATCH] control: Allow cset'ing specific values in the multi-value case
by arun＠accosted.net 10 Jun '15

10 Jun '15

From: Arun Raghavan <git(a)arunraghavan.net> This works with syntax like ... amixer cset 'IIR1 Band1' ,,200 ... to set the third value of the control to 200. --- src/control/ctlparse.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/control/ctlparse.c b/src/control/ctlparse.c index 8d6c385..64c6480 100644 --- a/src/control/ctlparse.c +++ b/src/control/ctlparse.c @@ -48,9 +48,9 @@ static inline long int convert_prange1(long val, long min, long max) #define check_range(val, min, max) \ ((val < min) ? (min) : ((val > max) ? (max) : (val))) -static long get_integer(const char **ptr, long min, long max) +static long get_integer(const char **ptr, long def, long min, long max) { - long val = min; + long val = def; char *p = (char *)*ptr, *s; if (*p == ':') @@ -351,6 +351,8 @@ int snd_ctl_ascii_value_parse(snd_ctl_t *handle, break; case SND_CTL_ELEM_TYPE_INTEGER: tmp = get_integer(&ptr, + snd_ctl_elem_value_get_integer(dst, + idx), snd_ctl_elem_info_get_min(info), snd_ctl_elem_info_get_max(info)); snd_ctl_elem_value_set_integer(dst, idx, tmp); @@ -364,12 +366,12 @@ int snd_ctl_ascii_value_parse(snd_ctl_t *handle, case SND_CTL_ELEM_TYPE_ENUMERATED: tmp = get_ctl_enum_item_index(handle, info, &ptr); if (tmp < 0) - tmp = get_integer(&ptr, 0, + tmp = get_integer(&ptr, 0, 0, snd_ctl_elem_info_get_items(info) - 1); snd_ctl_elem_value_set_enumerated(dst, idx, tmp); break; case SND_CTL_ELEM_TYPE_BYTES: - tmp = get_integer(&ptr, 0, 255); + tmp = get_integer(&ptr, 0, 0, 255); snd_ctl_elem_value_set_byte(dst, idx, tmp); break; default: -- 2.4.2

3 3