- Alsa-devel - mailman.alsa-project.org

[PATCH 0/2] ASoC: Intel: avs: Refactor IRQ handling
by Cezary Rojewski 20 Apr '24

20 Apr '24

The existing code can be both improved and simplified. To make this change easier to manage, first add new implementation and then remove deadcode in a separate patch. Simplification achieved with: - reduce the amount of resources requested by the driver i.e.: IPC and CLDMA request_irq() merged into one - reduce the number of DSP ops from 2 to 1: irq_handler/thread() vs dsp_interrupt() - drop ambiguity around CLDMA interrupt, let skl.c handle that explicitly as it is the only user With that done, switch to the new implementation and remove unused members. While the change is non-trivial, from functional perspective status quo is achieved. Cezary Rojewski (2): ASoC: Intel: avs: New IRQ handling implementation ASoC: Intel: avs: Remove unused IRQ-related code sound/soc/intel/avs/apl.c | 20 +++++++- sound/soc/intel/avs/avs.h | 8 ++-- sound/soc/intel/avs/cldma.c | 42 ++++------------- sound/soc/intel/avs/cldma.h | 1 + sound/soc/intel/avs/cnl.c | 91 ++++++++++++++++++++++++------------- sound/soc/intel/avs/core.c | 85 ++++++++++++++++------------------ sound/soc/intel/avs/icl.c | 3 +- sound/soc/intel/avs/ipc.c | 48 ------------------- sound/soc/intel/avs/skl.c | 73 +++++++++++++++++++++-------- sound/soc/intel/avs/tgl.c | 3 +- 10 files changed, 186 insertions(+), 188 deletions(-) -- 2.25.1

2 3

[PATCH 0/4] ASoC: qcom: display port changes
by srinivas.kandagatla＠linaro.org 19 Apr '24

19 Apr '24

From: Srinivas Kandagatla <srinivas.kandagatla(a)linaro.org> This patchset adds support for. 1. parse Display Port module tokens from ASoC topology 2. add support to DP/HDMI Jack events. 3. fixes a typo in function name in sm8250 Verified these patches on X13s along with changes to tplg in https://git.codelinaro.org/linaro/qcomlt/audioreach-topology/-/tree/topic/x… and ucm chagnes from https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/topic/x13s-dp Thanks, Srini Srinivas Kandagatla (4): ASoC: qcom: q6dsp: parse Display port tokens ASoC: qcom: common: add Display port Jack function ASoC: qcom: sc8280xp: add Display port Jack ASoC: qcom: sm8250: fix a typo in function name sound/soc/qcom/common.c | 30 ++++++++++++++++++++++++++++++ sound/soc/qcom/common.h | 3 +++ sound/soc/qcom/qdsp6/topology.c | 26 ++++++++++++++++++++++++++ sound/soc/qcom/sc8280xp.c | 13 +++++++++++++ sound/soc/qcom/sm8250.c | 4 ++-- 5 files changed, 74 insertions(+), 2 deletions(-) -- 2.43.0

2 6

RE: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD
by Niclas Söderlund 19 Apr '24

19 Apr '24

Hi, amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work. Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working? I do apologise in advance, Mvh, Niclas

1 0

[PATCH v2] spi: cs42l43: Correct name of ACPI property
by Maciej Strozek 19 Apr '24

19 Apr '24

Fixes: 439fbc97502a ("spi: cs42l43: Add bridged cs35l56 amplifiers") Signed-off-by: Maciej Strozek <mstrozek(a)opensource.cirrus.com> --- v2: Corrected the Fixes tag to point to right commit drivers/spi/spi-cs42l43.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index cdc61cd089ad..9d747ea69926 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -267,7 +267,7 @@ static bool cs42l43_has_sidecar(struct fwnode_handle *fwnode) continue; ret = fwnode_property_read_u32(ext_fwnode, - "01fa-cirrus-sidecar-instances", + "01fa-sidecar-instances", &val); fwnode_handle_put(ext_fwnode); -- 2.34.1

3 2

[PATCH] ASoC: ti: davinci-mcasp: Fix race condition during probe
by Joao Paulo Goncalves 19 Apr '24

19 Apr '24

From: Joao Paulo Goncalves <joao.goncalves(a)toradex.com> When using davinci-mcasp as CPU DAI with simple-card, there are some conditions that cause simple-card to finish registering a sound card before davinci-mcasp finishes registering all sound components. This creates a non-working sound card from userspace with no problem indication apart from not being able to play/record audio on a PCM stream. The issue arises during simultaneous probe execution of both drivers. Specifically, the simple-card driver, awaiting a CPU DAI, proceeds as soon as davinci-mcasp registers its DAI. However, this process can lead to the client mutex lock (client_mutex in soc-core.c) being held or davinci-mcasp being preempted before PCM DMA registration on davinci-mcasp finishes. This situation occurs when the probes of both drivers run concurrently. Below is the code path for this condition. To solve the issue, defer davinci-mcasp CPU DAI registration to the last step in the audio part of it. This way, simple-card CPU DAI parsing will be deferred until all audio components are registered. Fail Code Path: simple-card.c: probe starts simple-card.c: simple_dai_link_of: simple_parse_node(..,cpu,..) returns EPROBE_DEFER, no CPU DAI yet davinci-mcasp.c: probe starts davinci-mcasp.c: devm_snd_soc_register_component() register CPU DAI simple-card.c: probes again, finish CPU DAI parsing and call devm_snd_soc_register_card() simple-card.c: finish probe davinci-mcasp.c: *dma_pcm_platform_register() register PCM DMA davinci-mcasp.c: probe finish Cc: stable(a)vger.kernel.org Fixes: 9fbd58cf4ab0 ("ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller") Signed-off-by: Joao Paulo Goncalves <joao.goncalves(a)toradex.com> --- sound/soc/ti/davinci-mcasp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index b892d66f78470..1e760c3155213 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -2417,12 +2417,6 @@ static int davinci_mcasp_probe(struct platform_device *pdev) mcasp_reparent_fck(pdev); - ret = devm_snd_soc_register_component(&pdev->dev, &davinci_mcasp_component, - &davinci_mcasp_dai[mcasp->op_mode], 1); - - if (ret != 0) - goto err; - ret = davinci_mcasp_get_dma_type(mcasp); switch (ret) { case PCM_EDMA: @@ -2449,6 +2443,12 @@ static int davinci_mcasp_probe(struct platform_device *pdev) goto err; } + ret = devm_snd_soc_register_component(&pdev->dev, &davinci_mcasp_component, + &davinci_mcasp_dai[mcasp->op_mode], 1); + + if (ret != 0) + goto err; + no_audio: ret = davinci_mcasp_init_gpiochip(mcasp); if (ret) { -- 2.34.1

4 3

Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD
by Niclas Söderlund 19 Apr '24

19 Apr '24

Hi, amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work. Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working? I do apologise in advance but it would be a huge loss if this laptop is not appended as being one of the models being fixed. Mvh, Niclas Söderlund

1 0

Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD
by Niclas Söderlund 19 Apr '24

19 Apr '24

Hi, amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work. Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working? I do apologise in advance, Mvh, Niclas

1 0

[PATCH v1 0/1] soundwire: qcom: disable stop clock on 1.3.0 and below
by Anton Bambura 19 Apr '24

19 Apr '24

This patch fixes audio on sdm845 + wcd9340 with soundwire. The affected devices are AYN Odin and Lenovo Yoga C630. If this gets applied it should also be backported to stable and 6.6.x LTS. Anton Bambura (1): soundwire: qcom: disable stop clock on 1.3.0 and below drivers/soundwire/qcom.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.43.0

3 4

Question: layout of a patchset dependent on another tree
by Cezary Rojewski 18 Apr '24

18 Apr '24

Hello Mark, I'd like to send changes which do modify the avs-driver but are dependent on ACPI/NHLT changes I've recently upstream [1] to Rafael's linux-acpi tree. Thanks to Rafael, there's an immutable branch [2] that has all relevant commits on the top. Should I send both the NHLT+avs changes and have broonie/for-next as a base for that or provide only the avs changes and state the dependency within the cover-letter? The latter will fail to compile without its dependency obviously. [1]: https://lore.kernel.org/linux-acpi/20240319083018.3159716-1-cezary.rojewski… [2]: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=… Kind regards, Czarek

2 1

FIXES: alsamixer lowering volume control widget past 0 causes hostile volume spike to 100
by GitHub pull_request - opened 18 Apr '24

18 Apr '24

alsa-project/alsa-utils pull request #266 was opened from genbtc: bug: lowering volume below 0 causes volume to overflow and spike to 100% volume hurting my ears. to reproduce: when holding down z,x,c to lower the volume, the volume spikes to 100% and then down to 0% over and over background: when volume is already 0 and direction is -1 (lowering volume) - but lower than 0 is impossible the function `set_normalized_volume` @ volume-mapping.c is eventually still called anyway `value = lrint_dir(6000.0 * log10(volume), dir) + max;` and volume is 0, so log10(0) resolves to negative infinity, so value overflows past infinity. 9223372036854775802 ![alsamixer-alsa-utils-volumemap-bug3_2024-04-18_13-27-23](https://github.com/alsa-project/alsa-utils/assets/3683744/d382c59b-0e71-420f-8495-4d5d863f3734) my fix: this function `change_volume_relative` function will now skip execution of the set_normalized_playback_volume function when volume is 0 and the dir is -1 TLDR: (stop trying to set a lower volume than 0) Request URL : https://github.com/alsa-project/alsa-utils/pull/266 Patch URL : https://github.com/alsa-project/alsa-utils/pull/266.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0