- Alsa-devel - mailman.alsa-project.org

[PATCH v4] ALSA: hda/tas2781: Fix the order of TAS2781 calibrated-data
by Shenghao Ding 08 Sep '25

08 Sep '25

A bug reported by one of my customers that the order of TAS2781 calibrated-data is incorrect, the correct way is to move R0_Low and insert it between R0 and InvR0. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v4: - Add missing base into cali_cnv(). v3: - Take Tiwai's advice on cali_cnv() to make it more simpler. v2: - Submit to the sound branch maintained by Tiwai instead of linux-next branch - Drop other fix --- sound/hda/codecs/side-codecs/tas2781_hda.c | 25 +++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/sound/hda/codecs/side-codecs/tas2781_hda.c b/sound/hda/codecs/side-codecs/tas2781_hda.c index f46d2e06c64f..536940c78f00 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda.c @@ -33,6 +33,23 @@ const efi_guid_t tasdev_fct_efi_guid[] = { }; EXPORT_SYMBOL_NS_GPL(tasdev_fct_efi_guid, "SND_HDA_SCODEC_TAS2781"); +/* + * The order of calibrated-data writing function is a bit different from the + * order in UEFI. Here is the conversion to match the order of calibrated-data + * writing function. + */ +static void cali_cnv(unsigned char *data, unsigned int base, int offset) +{ + struct cali_reg reg_data; + + memcpy(&reg_data, &data[base], sizeof(reg_data)); + /* the data order has to be swapped between r0_low_reg and inv0_reg */ + swap(reg_data.r0_low_reg, reg_data.invr0_reg); + + cpu_to_be32_array((__force __be32 *)(data + offset + 1), + (u32 *)&reg_data, TASDEV_CALIB_N); +} + static void tas2781_apply_calib(struct tasdevice_priv *p) { struct calidata *cali_data = &p->cali_data; @@ -103,8 +120,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) data[l] = k; oft++; - for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i + 1] = data[4 * oft + i]; + cali_cnv(data, 4 * oft, l); k++; } } @@ -130,9 +146,8 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) for (j = p->ndev - 1; j >= 0; j--) { l = j * (cali_data->cali_dat_sz_per_dev + 1); - for (i = TASDEV_CALIB_N * 4; i > 0 ; i--) - data[l + i] = data[p->index * 5 + i]; - data[l+i] = j; + cali_cnv(data, cali_data->cali_dat_sz_per_dev * j, l); + data[l] = j; } } -- 2.43.0

2 1

Feature Request: conf.d for USB-Audio
by GitHub issues - edited 08 Sep '25

08 Sep '25

alsa-project/alsa-ucm-conf issue #609 was edited from FrostyCoolSlug: The release cadence of `alsa-ucm-conf` tends to be a little on the slow side (generally around 6 months between releases), but the problem I'm hitting currently is the requirement for users to manually edit `USB-Audio.conf` in order to get earlier support for their devices (and depending on distribution, support could be delayed upwards of two years). I think a method where a package could be created to drop files into a conf.d style directory would allow for a users device to be configured, without the need for manually editing `USB-Audio.conf` to add support. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/609 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Feature Request: conf.d for USB-Audio
by GitHub issues - opened 08 Sep '25

08 Sep '25

alsa-project/alsa-ucm-conf issue #609 was opened from FrostyCoolSlug: The release cadence of `alsa-ucm-conf` tends to be a little on the slow side (generally around 6 months between releases), but the problem I'm hitting currently is the requirement for users to manually edit `USB-Audio.conf` in order to get support for their devices (and depending on distribution, support could be delayed upwards of two years). I think a method where a package could be created to drop files into a conf.d style directory would allow for a users device to be configured, without the need for manually editing `USB-Audio.conf` to add support. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/609 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Mic from audio jack not work on Dell Precision M4800. Please add mic drivers
by GitHub issues - edited 07 Sep '25

07 Sep '25

alsa-project/alsa-lib issue #476 was edited from Slavomir9: Hello, on my Dell Precision M4800 not work mic on headset Koss CS100 audio jack (non USB) version. Please add mic drivers. [Dell Precision M4800 ](https://www.google.com/search?q=%0D%0ADell+Precision+M4800%0D%0A&sca_esv=e618e5e4341fb9f4&) [Headset Koss CS100](https://www.kaufland.sk/product/5373091/) I use dual boot. On Windows 11 work mic only after install drivers from Dell website. On Dell website are drivers for Linux for extremely old version of Ubuntu: Ubuntu® 12.04 More information about bug here https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/2122269 Please add mic drivers. Thanks Issue URL : https://github.com/alsa-project/alsa-lib/issues/476 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Mic from audio jack not work on Dell Precision M4800. Please add mic drivers
by GitHub issues - edited 07 Sep '25

07 Sep '25

alsa-project/alsa-lib issue #476 was edited from Slavomir9: Hello, on my Dell Precision M4800 not work mic on headset Koss CS100 audio jack (non USB) version. Please add mic drivers. [Dell Precision M4800 ](https://www.google.com/search?q=%0D%0ADell+Precision+M4800%0D%0A&sca_esv=e618e5e4341fb9f4&) [Headset Koss CS100](https://www.kaufland.sk/product/5373091/) I use dual boot. On Windows 11 work mic only after install drivers from Dell website. More information about bug here https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/2122269 Please add mic drivers. Thanks Issue URL : https://github.com/alsa-project/alsa-lib/issues/476 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Mic from audio jack not work on Dell Precision M4800. Please add mic drivers
by GitHub issues - edited 07 Sep '25

07 Sep '25

alsa-project/alsa-lib issue #476 was edited from Slavomir9: Hello, on my Dell Precision M4800 not work mic on headset Koss CS100 audio jack (non USB) version. Please add mic drivers. [Dell Precision M4800 ](https://www.google.com/search?q=%0D%0ADell+Precision+M4800%0D%0A&sca_esv=e618e5e4341fb9f4&) [Headset Koss CS100](https://www.kaufland.sk/product/5373091/) I use dual boot. On Windows 11 work mic only after install drivers from Dell website. Please add mic drivers. Thanks Issue URL : https://github.com/alsa-project/alsa-lib/issues/476 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Mic from audio jack not work on Dell Precision M4800
by GitHub issues - edited 07 Sep '25

07 Sep '25

alsa-project/alsa-lib issue #476 was edited from Slavomir9: Hello, on my Dell Precision M4800 not work mic on headset Koss CS100 audio jack (non USB) version. Please add mic drivers. [Dell Precision M4800 ](https://www.google.com/search?q=%0D%0ADell+Precision+M4800%0D%0A&sca_esv=e618e5e4341fb9f4&) [Headset Koss CS100](https://www.kaufland.sk/product/5373091/) I use dual boot. On Windows 11 work mic only after install drivers from Dell website. Please add mic drivers. Thanks Issue URL : https://github.com/alsa-project/alsa-lib/issues/476 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Mic from audio jack not work on Dell Precision M4800
by GitHub issues - opened 07 Sep '25

07 Sep '25

alsa-project/alsa-lib issue #476 was opened from Slavomir9: Hello, on my Dell Precision M4800 not work mic on headset Koss CS100 audio jack (non USB) version. [Dell Precision M4800 ](https://www.google.com/search?q=%0D%0ADell+Precision+M4800%0D%0A&sca_esv=e618e5e4341fb9f4&) [Headset Koss CS100](https://www.kaufland.sk/product/5373091/) I use dual boot. On Windows 11 work mic only after install drivers from Dell website Issue URL : https://github.com/alsa-project/alsa-lib/issues/476 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v3] ALSA: hda/tas2781: Fix the order of TAS2781 calibrated-data
by Shenghao Ding 07 Sep '25

07 Sep '25

A bug reported by one of my customers that the order of TAS2781 calibrated-data is incorrect, the correct way is to move R0_Low and insert it between R0 and InvR0. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- v3: - Take Tiwai's advice on cali_cnv() to make it more simpler. v2: - Submit to sound branch maintianed by Tiwai instead of linux-next branch - Drop other fix --- sound/hda/codecs/side-codecs/tas2781_hda.c | 25 +++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/sound/hda/codecs/side-codecs/tas2781_hda.c b/sound/hda/codecs/side-codecs/tas2781_hda.c index f46d2e06c64f..f4a44c6b0234 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda.c @@ -33,6 +33,23 @@ const efi_guid_t tasdev_fct_efi_guid[] = { }; EXPORT_SYMBOL_NS_GPL(tasdev_fct_efi_guid, "SND_HDA_SCODEC_TAS2781"); +/* + * The order of calibrated-data writing function is a bit different from the + * order in UEFI. Here is the conversion to match the order of calibrated-data + * writing function. + */ +static void cali_cnv(unsigned char *data, unsigned int base, int offset) +{ + struct cali_reg reg_data; + + memcpy(&reg_data, data, sizeof(reg_data)); + /* the data order has to be swapped between r0_low_reg and inv0_reg */ + swap(reg_data.r0_low_reg, reg_data.invr0_reg); + + cpu_to_be32_array((__force __be32 *)(data + offset + 1), + (u32 *)&reg_data, TASDEV_CALIB_N); +} + static void tas2781_apply_calib(struct tasdevice_priv *p) { struct calidata *cali_data = &p->cali_data; @@ -103,8 +120,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) data[l] = k; oft++; - for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i + 1] = data[4 * oft + i]; + cali_cnv(data, 4 * oft, l); k++; } } @@ -130,9 +146,8 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) for (j = p->ndev - 1; j >= 0; j--) { l = j * (cali_data->cali_dat_sz_per_dev + 1); - for (i = TASDEV_CALIB_N * 4; i > 0 ; i--) - data[l + i] = data[p->index * 5 + i]; - data[l+i] = j; + cali_cnv(data, cali_data->cali_dat_sz_per_dev * j, l); + data[l] = j; } } -- 2.43.0

3 2

No sound, only dummy output since updating alsa-lib to 1.2.14
by GitHub issues - opened 06 Sep '25

06 Sep '25

alsa-project/alsa-lib issue #475 was opened from aaaaadrien: Hello, Since an update on Fedora Linux 42, Audio card not detected, GNOME only shows "Dummy Output". No sound over speakers or HDMI. I downgraded the package alsa-lib (from alsa-lib-0:1.2.14-3.fc42.x86_64 to alsa-lib-0:1.2.13-4.fc42.x86_64) and now i have sound again. Tested with OpenSuse Tumbleweed Live ISO GNOME, with libasound2-1.2.14, i reproduce the issue. So i think it's not a distro issue but an ALSA Issue. That's why i open a bug here. Laptop model : Dell Latitude 3510 Audio Device : Intel Comet Lake PCH-LP cAVS driver: sof-audio-pci-intel-cnl API: ALSA version: k6.16.4-200.fc42.x86_64 status: kernel-api Reproducible: Always Steps to Reproduce: 1. Update alsa-lib to 1.2.14-3.fc42.x86_64 2. Reboot 3. See you only have dummy output Actual Results: No sound Expected Results: Sound always here ! Additional Information: Laptop model : Dell Latitude 3510 Audio Device : Intel Comet Lake PCH-LP cAVS driver: sof-audio-pci-intel-cnl API: ALSA version: k6.16.4-200.fc42.x86_64 status: kernel-api I opened a bug on Red Hat bugzilla yesterday but i enclose the link if you want to see the commands and checks i tested : https://bugzilla.redhat.com/show_bug.cgi?id=2393552 Issue URL : https://github.com/alsa-project/alsa-lib/issues/475 Repository URL: https://github.com/alsa-project/alsa-lib

1 0