- Alsa-devel - mailman.alsa-project.org

[PATCH v3 0/2] ASoC: dt-bindings: renesas,rsnd.yaml: add R-Car Gen4 support
by Kuninori Morimoto 17 Mar '23

17 Mar '23

Hi Mark These are v3 of R-Car Gen4 support for Renesas sound driver. I have posted these patches as [RFC], because the schemas doesn't work correctly for me under certain conditions. "required: dmas/dma-names" always hits to "if-then" and never hits to "else" for some reasons. I'm still not sure why... But to be very strict, actually, this schemas is not mandatory, because SSI has PIO transfer mode which doesn't need to have DMA settings. This patch-set drops "dmas/dma-names" from SSI for now, and ignore the issue, but it is *not* a wrong schemas. v2 -> v2 - keep clock-name description on top - tidyup git-log v1 -> v2 - tidyup Subject - separate patches (drop "dmas/dma-names", add Gen4 support) - minItems -> maxItems - more git-logs. Link: https://lore.kernel.org/all/87zg9vk0ex.wl-kuninori.morimoto.gx@renesas.com/… Link: https://lore.kernel.org/all/87r0v2uvm7.wl-kuninori.morimoto.gx@renesas.com/… Link: https://lore.kernel.org/all/87r0v1t02h.wl-kuninori.morimoto.gx@renesas.com/… Link: https://lore.kernel.org/all/87y1p7bpma.wl-kuninori.morimoto.gx@renesas.com/… -- 2.25.1

5 17

Re: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus Logic CS35L56
by kernel test robot 17 Mar '23

17 Mar '23

Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on broonie-sound/for-next] [also build test ERROR on linus/master v6.3-rc2 next-20230316] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Richard-Fitzgerald-via-Alsa-… base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/167872265923.26.336497278776737619%40mailman-core… patch subject: [PATCH v2 8/8] ASoC: cs35l56: Add driver for Cirrus Logic CS35L56 config: x86_64-buildonly-randconfig-r004-20230313 (https://download.01.org/0day-ci/archive/20230317/202303171105.3mGHjK8s-lkp@…) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/5856c94d659f9c9963f5c37762cf2… git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Richard-Fitzgerald-via-Alsa-devel/ASoC-wm_adsp-Use-no_core_startstop-to-prevent-creating-preload-control/20230313-235605 git checkout 5856c94d659f9c9963f5c37762cf201e1f1765e9 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303171105.3mGHjK8s-lkp@intel.com/ All error/warnings (new ones prefixed by >>): drivers/platform/x86/serial-multi-instantiate.c: In function 'smi_spi_probe': >> drivers/platform/x86/serial-multi-instantiate.c:98:15: error: implicit declaration of function 'acpi_spi_count_resources'; did you mean 'acpi_set_current_resources'? [-Werror=implicit-function-declaration] 98 | ret = acpi_spi_count_resources(adev); | ^~~~~~~~~~~~~~~~~~~~~~~~ | acpi_set_current_resources >> drivers/platform/x86/serial-multi-instantiate.c:112:27: error: implicit declaration of function 'acpi_spi_device_alloc' [-Werror=implicit-function-declaration] 112 | spi_dev = acpi_spi_device_alloc(NULL, adev, i); | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/platform/x86/serial-multi-instantiate.c:112:25: warning: assignment to 'struct spi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 112 | spi_dev = acpi_spi_device_alloc(NULL, adev, i); | ^ >> drivers/platform/x86/serial-multi-instantiate.c:115:59: error: invalid use of undefined type 'struct acpi_device' 115 | dev_name(&adev->dev)); | ^~ drivers/platform/x86/serial-multi-instantiate.c:137:53: error: invalid use of undefined type 'struct acpi_device' 137 | dev_name(&adev->dev)); | ^~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SERIAL_MULTI_INSTANTIATE Depends on [n]: X86_PLATFORM_DEVICES [=n] && I2C [=y] && SPI [=y] && ACPI [=n] Selected by [y]: - SND_SOC_CS35L56_I2C [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] - SND_SOC_CS35L56_SPI [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SPI_MASTER [=y] vim +112 drivers/platform/x86/serial-multi-instantiate.c 68f201f9061c000 Stefan Binding 2022-01-21 79 68f201f9061c000 Stefan Binding 2022-01-21 80 /** 68f201f9061c000 Stefan Binding 2022-01-21 81 * smi_spi_probe - Instantiate multiple SPI devices from inst array 68f201f9061c000 Stefan Binding 2022-01-21 82 * @pdev: Platform device 68f201f9061c000 Stefan Binding 2022-01-21 83 * @smi: Internal struct for Serial multi instantiate driver 68f201f9061c000 Stefan Binding 2022-01-21 84 * @inst_array: Array of instances to probe 68f201f9061c000 Stefan Binding 2022-01-21 85 * 68f201f9061c000 Stefan Binding 2022-01-21 86 * Returns the number of SPI devices instantiate, Zero if none is found or a negative error code. 68f201f9061c000 Stefan Binding 2022-01-21 87 */ 8b50c48d59a9cd0 Andy Shevchenko 2022-07-10 88 static int smi_spi_probe(struct platform_device *pdev, struct smi *smi, 68f201f9061c000 Stefan Binding 2022-01-21 89 const struct smi_instance *inst_array) 68f201f9061c000 Stefan Binding 2022-01-21 90 { 68f201f9061c000 Stefan Binding 2022-01-21 91 struct device *dev = &pdev->dev; 8b50c48d59a9cd0 Andy Shevchenko 2022-07-10 92 struct acpi_device *adev = ACPI_COMPANION(dev); 68f201f9061c000 Stefan Binding 2022-01-21 93 struct spi_controller *ctlr; 68f201f9061c000 Stefan Binding 2022-01-21 94 struct spi_device *spi_dev; 68f201f9061c000 Stefan Binding 2022-01-21 95 char name[50]; 68f201f9061c000 Stefan Binding 2022-01-21 96 int i, ret, count; 68f201f9061c000 Stefan Binding 2022-01-21 97 68f201f9061c000 Stefan Binding 2022-01-21 @98 ret = acpi_spi_count_resources(adev); 68f201f9061c000 Stefan Binding 2022-01-21 99 if (ret < 0) 68f201f9061c000 Stefan Binding 2022-01-21 100 return ret; f3e13bbc6f5a84f Andy Shevchenko 2022-07-10 101 if (!ret) 2b5b27826a48eea Andy Shevchenko 2022-07-10 102 return -ENOENT; 68f201f9061c000 Stefan Binding 2022-01-21 103 68f201f9061c000 Stefan Binding 2022-01-21 104 count = ret; 68f201f9061c000 Stefan Binding 2022-01-21 105 68f201f9061c000 Stefan Binding 2022-01-21 106 smi->spi_devs = devm_kcalloc(dev, count, sizeof(*smi->spi_devs), GFP_KERNEL); 68f201f9061c000 Stefan Binding 2022-01-21 107 if (!smi->spi_devs) 68f201f9061c000 Stefan Binding 2022-01-21 108 return -ENOMEM; 68f201f9061c000 Stefan Binding 2022-01-21 109 68f201f9061c000 Stefan Binding 2022-01-21 110 for (i = 0; i < count && inst_array[i].type; i++) { 68f201f9061c000 Stefan Binding 2022-01-21 111 68f201f9061c000 Stefan Binding 2022-01-21 @112 spi_dev = acpi_spi_device_alloc(NULL, adev, i); 68f201f9061c000 Stefan Binding 2022-01-21 113 if (IS_ERR(spi_dev)) { 14a9aa99aca6c28 Andy Shevchenko 2022-07-10 114 ret = dev_err_probe(dev, PTR_ERR(spi_dev), "failed to allocate SPI device %s from ACPI\n", 14a9aa99aca6c28 Andy Shevchenko 2022-07-10 @115 dev_name(&adev->dev)); 68f201f9061c000 Stefan Binding 2022-01-21 116 goto error; 68f201f9061c000 Stefan Binding 2022-01-21 117 } 68f201f9061c000 Stefan Binding 2022-01-21 118 68f201f9061c000 Stefan Binding 2022-01-21 119 ctlr = spi_dev->controller; 68f201f9061c000 Stefan Binding 2022-01-21 120 68f201f9061c000 Stefan Binding 2022-01-21 121 strscpy(spi_dev->modalias, inst_array[i].type, sizeof(spi_dev->modalias)); 68f201f9061c000 Stefan Binding 2022-01-21 122 68f201f9061c000 Stefan Binding 2022-01-21 123 ret = smi_get_irq(pdev, adev, &inst_array[i]); 68f201f9061c000 Stefan Binding 2022-01-21 124 if (ret < 0) { 68f201f9061c000 Stefan Binding 2022-01-21 125 spi_dev_put(spi_dev); 68f201f9061c000 Stefan Binding 2022-01-21 126 goto error; 68f201f9061c000 Stefan Binding 2022-01-21 127 } 68f201f9061c000 Stefan Binding 2022-01-21 128 spi_dev->irq = ret; 68f201f9061c000 Stefan Binding 2022-01-21 129 68f201f9061c000 Stefan Binding 2022-01-21 130 snprintf(name, sizeof(name), "%s-%s-%s.%d", dev_name(&ctlr->dev), dev_name(dev), 68f201f9061c000 Stefan Binding 2022-01-21 131 inst_array[i].type, i); 68f201f9061c000 Stefan Binding 2022-01-21 132 spi_dev->dev.init_name = name; 68f201f9061c000 Stefan Binding 2022-01-21 133 68f201f9061c000 Stefan Binding 2022-01-21 134 ret = spi_add_device(spi_dev); 68f201f9061c000 Stefan Binding 2022-01-21 135 if (ret) { 14a9aa99aca6c28 Andy Shevchenko 2022-07-10 136 dev_err_probe(&ctlr->dev, ret, "failed to add SPI device %s from ACPI\n", 14a9aa99aca6c28 Andy Shevchenko 2022-07-10 137 dev_name(&adev->dev)); 68f201f9061c000 Stefan Binding 2022-01-21 138 spi_dev_put(spi_dev); 68f201f9061c000 Stefan Binding 2022-01-21 139 goto error; 68f201f9061c000 Stefan Binding 2022-01-21 140 } 68f201f9061c000 Stefan Binding 2022-01-21 141 68f201f9061c000 Stefan Binding 2022-01-21 142 dev_dbg(dev, "SPI device %s using chip select %u", name, spi_dev->chip_select); 68f201f9061c000 Stefan Binding 2022-01-21 143 68f201f9061c000 Stefan Binding 2022-01-21 144 smi->spi_devs[i] = spi_dev; 68f201f9061c000 Stefan Binding 2022-01-21 145 smi->spi_num++; 68f201f9061c000 Stefan Binding 2022-01-21 146 } 68f201f9061c000 Stefan Binding 2022-01-21 147 68f201f9061c000 Stefan Binding 2022-01-21 148 if (smi->spi_num < count) { 68f201f9061c000 Stefan Binding 2022-01-21 149 dev_dbg(dev, "Error finding driver, idx %d\n", i); 68f201f9061c000 Stefan Binding 2022-01-21 150 ret = -ENODEV; 68f201f9061c000 Stefan Binding 2022-01-21 151 goto error; 68f201f9061c000 Stefan Binding 2022-01-21 152 } 68f201f9061c000 Stefan Binding 2022-01-21 153 68f201f9061c000 Stefan Binding 2022-01-21 154 dev_info(dev, "Instantiated %d SPI devices.\n", smi->spi_num); 68f201f9061c000 Stefan Binding 2022-01-21 155 68f201f9061c000 Stefan Binding 2022-01-21 156 return 0; 68f201f9061c000 Stefan Binding 2022-01-21 157 error: 68f201f9061c000 Stefan Binding 2022-01-21 158 smi_devs_unregister(smi); 68f201f9061c000 Stefan Binding 2022-01-21 159 68f201f9061c000 Stefan Binding 2022-01-21 160 return ret; 35a36cbb7b1ce75 Lucas Tanure 2022-01-21 161 } 35a36cbb7b1ce75 Lucas Tanure 2022-01-21 162 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests

1 0

[PATCH] ASoC: dt-bindings: qcom,lpass-rx-macro: correct minItems for clocks
by Krzysztof Kozlowski 17 Mar '23

17 Mar '23

The RX macro codec comes on some platforms in two variants - ADSP and ADSP bypassed - thus the clock-names varies from 3 to 5. The clocks must vary as well: sc7280-idp.dtb: codec@3200000: clocks: [[202, 8], [202, 7], [203]] is too short Fixes: 852fda58d99a ("ASoC: qcom: dt-bindings: Update bindings for clocks in lpass digital codes") Cc: <stable(a)vger.kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml index 79c6f8da1319..b0b95689d78b 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml @@ -30,6 +30,7 @@ properties: const: 0 clocks: + minItems: 3 maxItems: 5 clock-names: -- 2.34.1

2 1

[PATCH AUTOSEL 6.1 1/6] ASoC: amd: yp: Add OMEN by HP Gaming Laptop 16z-n000 to quirks
by Sasha Levin 16 Mar '23

16 Mar '23

From: Joseph Hunkeler <jhunkeler(a)gmail.com> [ Upstream commit 22ce6843abec19270bf69b176d7ee0a4ef781da5 ] Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop Signed-off-by: Joseph Hunkeler <jhunkeler(a)gmail.com> Link: https://lore.kernel.org/r/20230216155007.26143-1-jhunkeler@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 36314753923b8..4e681e9c08fe5 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -255,6 +255,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "15NBC1011"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), + } + }, {} }; -- 2.39.2

1 1

[PATCH AUTOSEL 6.2 1/7] ASoC: amd: yp: Add OMEN by HP Gaming Laptop 16z-n000 to quirks
by Sasha Levin 16 Mar '23

16 Mar '23

From: Joseph Hunkeler <jhunkeler(a)gmail.com> [ Upstream commit 22ce6843abec19270bf69b176d7ee0a4ef781da5 ] Enables display microphone on the HP OMEN 16z-n000 (8A42) laptop Signed-off-by: Joseph Hunkeler <jhunkeler(a)gmail.com> Link: https://lore.kernel.org/r/20230216155007.26143-1-jhunkeler@gmail.com Signed-off-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 36314753923b8..4e681e9c08fe5 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -255,6 +255,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "15NBC1011"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), + } + }, {} }; -- 2.39.2

1 2

[PATCH] ASoC: codecs:rx-macro: Fixing uninitialized variables.
by Ravulapati Vishnu Vardhan Rao 16 Mar '23

16 Mar '23

Initializing the uninitialized variables to avoid any unexpected garbage value to be propagated further. Signed-off-by: Ravulapati Vishnu Vardhan Rao <quic_visr(a)quicinc.com> --- sound/soc/codecs/lpass-rx-macro.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c index a73a7d7a1c0a..0c8b79ff2fc5 100644 --- a/sound/soc/codecs/lpass-rx-macro.c +++ b/sound/soc/codecs/lpass-rx-macro.c @@ -2219,6 +2219,8 @@ static void rx_macro_hd2_control(struct snd_soc_component *component, u16 interp_idx, int event) { u16 hd2_scale_reg, hd2_enable_reg; + hd2_scale_reg = 0; + hd2_enable_reg = 0; switch (interp_idx) { case INTERP_HPHL: -- 2.17.1

2 1

Maybe a bug: libasound_module_pcm_pulse.la uses snd_pcm_sw_params_get_start_threshold but not linked against -lasound?
by GitHub issues - edited 16 Mar '23

16 Mar '23

alsa-project/alsa-plugins issue #52 was edited from MIvanchev: I see pcm_pulse.c uses snd_pcm_sw_params_get_start_threshold from -lasound but AFAIK that is a bug, because libasound is loading the plugins and not the other way around. Can someone explain what's going on, I'm getting undefined references.. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/52 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Maybe a bug: libasound_module_pcm_pulse.la uses snd_pcm_sw_params_get_start_threshold but not linked against -lasound?
by GitHub issues - edited 16 Mar '23

16 Mar '23

alsa-project/alsa-plugins issue #52 was edited from MIvanchev: I see pcm_pulse.c uses snd_pcm_sw_params_get_start_threshold from -lasound but AFAIK that is a bug, because libasound is loading the plugins and not the other way around. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/52 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Maybe a bug: libasound_module_ctl_pulse.la uses snd_pcm_sw_params_get_start_threshold but not linked against -lasound?
by GitHub issues - opened 16 Mar '23

16 Mar '23

alsa-project/alsa-plugins issue #52 was opened from MIvanchev: I see pcm_pulse.c uses snd_pcm_sw_params_get_start_threshold from -lasound but AFAIK that is a bug, because libasound is loading the plugins and not the other way around. Issue URL : https://github.com/alsa-project/alsa-plugins/issues/52 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[PATCH] ASoC: dt-bindings: maxim,max9759: Convert to DT schema.
by Otabek Nazrullaev 16 Mar '23

16 Mar '23

Convert Maxim MAX9759 Speaker Amplifier bindings to DT schema. Add missing gpio header file into examples section Signed-off-by: Otabek Nazrullaev <otabeknazrullaev1998(a)gmail.com> Cc: Daniel Baluta <daniel.baluta(a)nxp.com> --- .../bindings/sound/maxim,max9759.txt | 18 -------- .../bindings/sound/maxim,max9759.yaml | 45 +++++++++++++++++++ 2 files changed, 45 insertions(+), 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/maxim,max9759.txt create mode 100644 Documentation/devicetree/bindings/sound/maxim,max9759.yaml diff --git a/Documentation/devicetree/bindings/sound/maxim,max9759.txt b/Documentation/devicetree/bindings/sound/maxim,max9759.txt deleted file mode 100644 index 737a996374d3..000000000000 --- a/Documentation/devicetree/bindings/sound/maxim,max9759.txt +++ /dev/null @@ -1,18 +0,0 @@ -Maxim MAX9759 Speaker Amplifier -=============================== - -Required properties: -- compatible : "maxim,max9759" -- shutdown-gpios : the gpio connected to the shutdown pin -- mute-gpios : the gpio connected to the mute pin -- gain-gpios : the 2 gpios connected to the g1 and g2 pins - -Example: - -max9759: analog-amplifier { - compatible = "maxim,max9759"; - shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>; - mute-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; - gain-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>, - <&gpio3 25 GPIO_ACTIVE_LOW>; -}; diff --git a/Documentation/devicetree/bindings/sound/maxim,max9759.yaml b/Documentation/devicetree/bindings/sound/maxim,max9759.yaml new file mode 100644 index 000000000000..a76ee6a635af --- /dev/null +++ b/Documentation/devicetree/bindings/sound/maxim,max9759.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/maxim,max9759.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX9759 Speaker Amplifier + +maintainers: + - Otabek Nazrullaev <otabeknazrullaev1998(a)gmail.com> + +properties: + compatible: + const: maxim,max9759 + + shutdown-gpios: + maxItems: 1 + description: the gpio connected to the shutdown pin + + mute-gpios: + maxItems: 1 + description: the gpio connected to the mute pin + + gain-gpios: + maxItems: 2 + description: the 2 gpios connected to the g1 and g2 pins + +required: + - compatible + - shutdown-gpios + - mute-gpios + - gain-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + amplifier { + compatible = "maxim,max9759"; + shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>; + mute-gpios = <&gpio3 19 GPIO_ACTIVE_LOW>; + gain-gpios = <&gpio3 23 GPIO_ACTIVE_LOW>, + <&gpio3 25 GPIO_ACTIVE_LOW>; + }; -- 2.34.1

3 2