- Alsa-devel - mailman.alsa-project.org

Re: [PATCH] ASoC: qcom: apq8016_sbc: Fix second argument of apq8016_dai_init()
by Stephan Gerhold 22 Nov '24

22 Nov '24

Hi, On Mon, Nov 18, 2024 at 12:20:58AM +0100, Bert Karwatzki wrote: > Since commit a78a42fb48b8 the second argument of apq8016_dai_init() has > to be an lpass id returned by qdsp6_dai_get_lpass_id(). > > Fixes: a78a42fb48b8 ("ASoC: qcom: apq8016_sbc: Allow routing audio through QDSP6") > > Signed-off-by: Bert Karwatzki <spasswolf(a)web.de> > --- > sound/soc/qcom/apq8016_sbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c > index 3023cf180a75..ddfcd4616895 100644 > --- a/sound/soc/qcom/apq8016_sbc.c > +++ b/sound/soc/qcom/apq8016_sbc.c > @@ -150,7 +150,7 @@ static int apq8016_sbc_dai_init(struct snd_soc_pcm_runtime *rtd) > { > struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0); > > - return apq8016_dai_init(rtd, cpu_dai->id); > + return apq8016_dai_init(rtd, qdsp6_dai_get_lpass_id(cpu_dai)); > } > Hm no, the code is correct the way it is. There are two cases handled by this driver: - ADSP bypass (lpass-* drivers, qcom,apq8016-sbc-sndcard): This one uses the LPASS IDs as DAI IDs, so cpu_dai->id already contains the correct value. - ADSP (qdsp6 drivers, qcom,msm8916-qdsp6-sndcard): This one uses the QDSP6 IDs (e.g. PRIMARY_MI2S_RX/TX instead of MI2S_PRIMARY), so qdsp6_dai_get_lpass_id() is used to translate that to the LPASS IDs. The code you are changing here handles the first case (ADSP bypass), the DAI IDs do not need any translation there. Thanks, Stephan

2 1

Set pcbeep to default value
by Kailang 22 Nov '24

22 Nov '24

Hi Takashi, Attach patch will set pcbeep to default value for ALC274. BR, Kailang

2 1

Re: [PATCH] ASoC: qcom: apq8016_sbc: Fix second argument of apq8016_dai_init()
by Mark Brown 21 Nov '24

21 Nov '24

On Mon, Nov 18, 2024 at 12:20:58AM +0100, Bert Karwatzki wrote: > Since commit a78a42fb48b8 the second argument of apq8016_dai_init() has > to be an lpass id returned by qdsp6_dai_get_lpass_id(). This breaks the build: /build/stage/linux/sound/soc/qcom/apq8016_sbc.c: In function ‘apq8016_sbc_dai_in it’: /build/stage/linux/sound/soc/qcom/apq8016_sbc.c:153:38: error: implicit declarat ion of function ‘qdsp6_dai_get_lpass_id’ [-Werror=implicit-function-declaration] 153 | return apq8016_dai_init(rtd, qdsp6_dai_get_lpass_id(cpu_dai)); | ^~~~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/qcom/apq8016_sbc.c: At top level: /build/stage/linux/sound/soc/qcom/apq8016_sbc.c:165:12: error: static declaratio n of ‘qdsp6_dai_get_lpass_id’ follows non-static declaration 165 | static int qdsp6_dai_get_lpass_id(struct snd_soc_dai *cpu_dai) | ^~~~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/qcom/apq8016_sbc.c:153:38: note: previous implicit declaration of ‘qdsp6_dai_get_lpass_id’ with type ‘int()’ 153 | return apq8016_dai_init(rtd, qdsp6_dai_get_lpass_id(cpu_dai)); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors

1 0

Tiny sound on ASUS Zenbook UM5606 out of the box
by GitHub issues - opened 20 Nov '24

20 Nov '24

alsa-project/alsa-ucm-conf issue #467 was opened from IShashkin: ASUS Zenbook UM5606 doesn't use subwoofers out of the box. So sound is tiny on the laptop. There is a workaround described here https://wiki.archlinux.org/title/ASUS_Zenbook_UM5606#Audio but it's broken in the last alsa release. alsa-info.sh --no-upload [alsa-info.txt.zip](https://github.com/user-attachments/files/17834654/alsa-… Let me know if you need more info. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/467 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

sof-soundwire: cs42l43: Correct CapturePCM and routing
by GitHub pull_request - opened 20 Nov '24

20 Nov '24

alsa-project/alsa-ucm-conf pull request #466 was opened from charleskeepax: For headset microphone capture the correct PCM device to use is "hw:${CardId},1", "hw:${CardId},4" is for built in microphone capture. Adjust the routing as well since :0,1 is connected to data port 2 on the codec. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/466 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/466.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

ALC225 ALC256 update depop procedure
by Kailang 20 Nov '24

20 Nov '24

Hi Takashi, ALC225 ALC256 update depop procedure. Many Thanks. BR, Kailang

2 1

alsactl: 90-alsa-restore.rules - fix AMD acp-pdm-mach link name acp-dmic-codec
by GitHub pull_request - edited 20 Nov '24

20 Nov '24

alsa-project/alsa-utils pull request #281 was edited from pma1: The link name of AMD ACP digital microphones driver acp-pdm-mach is acp-dmic-codec. fix it to make UCM initialize it again. Fixes: 8116639 ("alsactl: 90-alsa-restore.rules - add support for AMD ACP digital microphone") ``` # arecord -l **** List of CAPTURE Hardware Devices **** card 1: Generic_1 [HD-Audio Generic], device 0: ALC257 Analog [ALC257 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: acppdmmach [acp-pdm-mach], device 0: (null) dmic-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 # ls -la /sys/class/sound/controlC2/device/ total 0 drwxr-xr-x 5 root root 0 Nov 20 15:50 . drwxr-xr-x 3 root root 0 Nov 20 15:50 .. drwxr-xr-x 3 root root 0 Nov 20 15:47 controlC2 lrwxrwxrwx 1 root root 0 Nov 20 15:47 device -> ../../../acp-pdm-mach -rw-r--r-- 1 root root 4096 Nov 20 15:50 id -r--r--r-- 1 root root 4096 Nov 20 15:47 number drwxr-xr-x 3 root root 0 Nov 20 15:47 pcmC2D0c drwxr-xr-x 2 root root 0 Nov 20 15:50 power lrwxrwxrwx 1 root root 0 Nov 20 15:47 subsystem -> ../../../../../../../../class/sound -rw-r--r-- 1 root root 4096 Nov 20 15:47 uevent # ls -la /sys/class/sound/controlC2/device/device/ total 0 drwxr-xr-x 5 root root 0 Nov 20 15:50 . drwxr-xr-x 4 root root 0 Nov 20 15:50 .. drwxr-xr-x 3 root root 0 Nov 20 15:50 acp-dmic-codec lrwxrwxrwx 1 root root 0 Nov 20 15:47 driver -> ../../../../../../bus/platform/drivers/acp_mach -rw-r--r-- 1 root root 4096 Nov 20 15:50 driver_override -r--r--r-- 1 root root 4096 Nov 20 15:50 modalias drwxr-xr-x 2 root root 0 Nov 20 15:50 power drwxr-xr-x 3 root root 0 Nov 20 15:50 sound lrwxrwxrwx 1 root root 0 Nov 20 15:47 subsystem -> ../../../../../../bus/platform -rw-r--r-- 1 root root 4096 Nov 20 15:50 uevent ``` After the change of link name acp-dmic-codec, the micmute led can work on ThinkPad T14s Gen 6. Request URL : https://github.com/alsa-project/alsa-utils/pull/281 Patch URL : https://github.com/alsa-project/alsa-utils/pull/281.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

alsactl: 90-alsa-restore.rules - fix AMD acp-pdm-mach link name acp-dmic-codec
by GitHub pull_request - opened 20 Nov '24

20 Nov '24

alsa-project/alsa-utils pull request #281 was opened from pma1: The link name of AMD ACP digital microphones driver acp-pdm-mach is acp-dmic-codec. fix it to make UCM initialize it again. Fixes: 8116639 ("alsactl: 90-alsa-restore.rules - add support for AMD ACP digital microphone") # arecord -l **** List of CAPTURE Hardware Devices **** card 1: Generic_1 [HD-Audio Generic], device 0: ALC257 Analog [ALC257 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 card 2: acppdmmach [acp-pdm-mach], device 0: (null) dmic-hifi-0 [] Subdevices: 1/1 Subdevice #0: subdevice #0 # ls -la /sys/class/sound/controlC2/device/ total 0 drwxr-xr-x 5 root root 0 Nov 20 15:50 . drwxr-xr-x 3 root root 0 Nov 20 15:50 .. drwxr-xr-x 3 root root 0 Nov 20 15:47 controlC2 lrwxrwxrwx 1 root root 0 Nov 20 15:47 device -> ../../../acp-pdm-mach -rw-r--r-- 1 root root 4096 Nov 20 15:50 id -r--r--r-- 1 root root 4096 Nov 20 15:47 number drwxr-xr-x 3 root root 0 Nov 20 15:47 pcmC2D0c drwxr-xr-x 2 root root 0 Nov 20 15:50 power lrwxrwxrwx 1 root root 0 Nov 20 15:47 subsystem -> ../../../../../../../../class/sound -rw-r--r-- 1 root root 4096 Nov 20 15:47 uevent # ls -la /sys/class/sound/controlC2/device/device/ total 0 drwxr-xr-x 5 root root 0 Nov 20 15:50 . drwxr-xr-x 4 root root 0 Nov 20 15:50 .. drwxr-xr-x 3 root root 0 Nov 20 15:50 acp-dmic-codec lrwxrwxrwx 1 root root 0 Nov 20 15:47 driver -> ../../../../../../bus/platform/drivers/acp_mach -rw-r--r-- 1 root root 4096 Nov 20 15:50 driver_override -r--r--r-- 1 root root 4096 Nov 20 15:50 modalias drwxr-xr-x 2 root root 0 Nov 20 15:50 power drwxr-xr-x 3 root root 0 Nov 20 15:50 sound lrwxrwxrwx 1 root root 0 Nov 20 15:47 subsystem -> ../../../../../../bus/platform -rw-r--r-- 1 root root 4096 Nov 20 15:50 uevent After the change of link name acp-dmic-codec, the micmute led can work on ThinkPad T14s Gen 6. Request URL : https://github.com/alsa-project/alsa-utils/pull/281 Patch URL : https://github.com/alsa-project/alsa-utils/pull/281.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[alsa-devel] Error patching file pcm_native.c
by Delusion's Master 20 Nov '24

20 Nov '24

Hi, first of all I apologize in case you receive multiple copies of this message, but I forgot to specify a subject in the original mail. I have a problem compiling the latest alsa driver snapshots. Specifically, it's a problem when patching pcm_native.c: [..] copying file alsa-kernel/core/info.c patching file info.c copying file alsa-kernel/core/pcm.c patching file pcm.c Hunk #3 succeeded at 739 (offset 2 lines). Hunk #5 succeeded at 954 (offset 2 lines). Hunk #7 succeeded at 1045 (offset 2 lines). copying file alsa-kernel/core/pcm_native.c patching file pcm_native.c Hunk #4 succeeded at 1544 (offset -25 lines). Hunk #5 succeeded at 2827 (offset 12 lines). Hunk #6 succeeded at 2878 (offset 10 lines). Hunk #7 FAILED at 2906. Hunk #8 FAILED at 2922. Hunk #9 succeeded at 2915 (offset -23 lines). Hunk #10 succeeded at 3036 (offset 10 lines). Hunk #11 succeeded at 3027 (offset -23 lines). Hunk #12 succeeded at 3074 (offset 10 lines). Hunk #13 succeeded at 3098 (offset -23 lines). Hunk #14 succeeded at 3143 (offset 10 lines). Hunk #15 succeeded at 3124 (offset -23 lines). Hunk #16 succeeded at 3214 (offset 10 lines). Hunk #17 succeeded at 3208 (offset -23 lines). Hunk #18 succeeded at 3271 (offset 10 lines). Hunk #19 succeeded at 3304 (offset -23 lines). Hunk #20 succeeded at 3386 (offset 10 lines). Hunk #21 succeeded at 3411 (offset -23 lines). Hunk #22 succeeded at 3456 (offset 10 lines). Hunk #23 succeeded at 3450 (offset -23 lines). Hunk #24 succeeded at 3525 (offset 10 lines). Hunk #25 succeeded at 3644 (offset -23 lines). 2 out of 25 hunks FAILED -- saving rejects to file pcm_native.c.rej make[2]: *** [pcm_native.c] Error 1 It's some days I get this, but I waited to report this since I thought it could be a temporary problem. My OS is Fedora 11 x86_64. Previous snapshots didn't give me this problem, but I can't say which one broke the compilation, since I usually try updated snapshots only at kernel updates. I searched for this error and the only relevant report I could find is this one: http://mailman.alsa-project.org/pipermail/alsa-devel/2009-April/016420.html a report from last April. What could the problem be? Thanks _________________________________________________________________ Invite your mail contacts to join your friends list with Windows Live Spaces. It's easy! http://spaces.live.com/spacesapi.aspx?wx_action=create&wx_url=/friends.aspx…

3 10

sof-soundwire: cs42l43-spk: Correct PlaybackPCM and routing
by GitHub pull_request - opened 19 Nov '24

19 Nov '24

alsa-project/alsa-ucm-conf pull request #465 was opened from ujfalusi: For speaker the correct PCM device to use is "hw:${CardId},2", the "hw:${CardId},0" is for headset playback. Adjust the routing as well since with :0,2 the DP6RX1/2 needs to be selected for the speaker. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/465 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/465.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0