- Alsa-devel - mailman.alsa-project.org

[PATCH v2] ALSA: hda/tas2781: Fix calibration data parser issue
by Baojun Xu 07 Jul '25

07 Jul '25

We will copy calibration data from position behind to front. We has created a variable (tmp_val) point on top of calibration data buffer, and tmp_val[1] is max of node number in original calibration data structure, it will be overwritten after first data copy, so can't be used as max node number check in for loop. So we create a new variable to save max of node number (tmp_val[1]), used to check if max node number was reached in for loop. And a point need to be increased to point at calibration data in node. Data saved position also need to be increased one byte. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- Change in v2: - Add more description about this fix. --- sound/pci/hda/tas2781_hda.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda.c b/sound/pci/hda/tas2781_hda.c index 5f1d4b3e9688..34217ce9f28e 100644 --- a/sound/pci/hda/tas2781_hda.c +++ b/sound/pci/hda/tas2781_hda.c @@ -44,7 +44,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) TASDEVICE_REG(0, 0x13, 0x70), TASDEVICE_REG(0, 0x18, 0x7c), }; - unsigned int crc, oft; + unsigned int crc, oft, node_num; unsigned char *buf; int i, j, k, l; @@ -80,8 +80,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) dev_err(p->dev, "%s: CRC error\n", __func__); return; } + node_num = tmp_val[1]; - for (j = 0, k = 0; j < tmp_val[1]; j++) { + for (j = 0, k = 0; j < node_num; j++) { oft = j * 6 + 3; if (tmp_val[oft] == TASDEV_UEFI_CALI_REG_ADDR_FLG) { for (i = 0; i < TASDEV_CALIB_N; i++) { @@ -99,8 +100,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) } data[l] = k; + oft++; for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i] = data[4 * oft + i]; + data[l + i + 1] = data[4 * oft + i]; k++; } } -- 2.43.0

1 0

[PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
by Baojun Xu 06 Jul '25

06 Jul '25

Device name start from bus name, as we use strstarts() to do compare, need add it for TXNW2781 device. Fixes: b2904df0a347 ("ALSA: hda/tas2781: Add compatible for hardware id TIAS2781 and TXNW2781") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- sound/pci/hda/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index b9cdbca951e4..530c2266ab3b 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; } else if (strstarts(dev_name(&clt->dev), - "TXNW2781:00-tas2781-hda.0")) { + "i2c-TXNW2781:00-tas2781-hda.0")) { device_name = "TXNW2781"; hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; -- 2.43.0

1 1

[PATCH v1] ALSA: hda/tas2781: Fix calibration data parser issue
by Baojun Xu 06 Jul '25

06 Jul '25

Calibration data was overwritten during parser, it cause issue. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- sound/pci/hda/tas2781_hda.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/pci/hda/tas2781_hda.c b/sound/pci/hda/tas2781_hda.c index 5f1d4b3e9688..34217ce9f28e 100644 --- a/sound/pci/hda/tas2781_hda.c +++ b/sound/pci/hda/tas2781_hda.c @@ -44,7 +44,7 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) TASDEVICE_REG(0, 0x13, 0x70), TASDEVICE_REG(0, 0x18, 0x7c), }; - unsigned int crc, oft; + unsigned int crc, oft, node_num; unsigned char *buf; int i, j, k, l; @@ -80,8 +80,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) dev_err(p->dev, "%s: CRC error\n", __func__); return; } + node_num = tmp_val[1]; - for (j = 0, k = 0; j < tmp_val[1]; j++) { + for (j = 0, k = 0; j < node_num; j++) { oft = j * 6 + 3; if (tmp_val[oft] == TASDEV_UEFI_CALI_REG_ADDR_FLG) { for (i = 0; i < TASDEV_CALIB_N; i++) { @@ -99,8 +100,9 @@ static void tas2781_apply_calib(struct tasdevice_priv *p) } data[l] = k; + oft++; for (i = 0; i < TASDEV_CALIB_N * 4; i++) - data[l + i] = data[4 * oft + i]; + data[l + i + 1] = data[4 * oft + i]; k++; } } -- 2.43.0

1 0

test: update midifile library to ANSI C
by GitHub pull_request - opened 06 Jul '25

06 Jul '25

alsa-project/alsa-lib pull request #463 was opened from atsampson: The `midifile` library used by the `playmidi1` program dates from 1989, and used pre-ANSI function definitions and prototypes. GCC 15 now defaults to C23 where `()` means the same as `(void)` in prototypes, which causes type mismatch errors. Update the code to use ANSI function definitions and prototypes, so it'll compile happily as anything from ANSI C to C23. This revealed that `playmidi1`'s `do_tempo` had the wrong argument type, so correct that as well. Fixes #452. Request URL : https://github.com/alsa-project/alsa-lib/pull/463 Patch URL : https://github.com/alsa-project/alsa-lib/pull/463.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[tiwai-sound:test/hda-reorg 41/53] sound/hda/codecs/cirrus/cs421x.c:561:35: warning: 'cs421x_codec_ops' defined but not used
by kernel test robot 05 Jul '25

05 Jul '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/hda-reorg head: 6119728edf86cefcbf7b20e000414c85916e900d commit: 484072d3f99c402030fcee94e28ab3ea76d04247 [41/53] ALSA: hda/cirrus: Split to cs420x and cs421x drivers config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250705/202507051737.DMAkxayN-lkp@…) compiler: sh4-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051737.DMAkxayN-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507051737.DMAkxayN-lkp@intel.com/ All warnings (new ones prefixed by >>): >> sound/hda/codecs/cirrus/cs421x.c:561:35: warning: 'cs421x_codec_ops' defined but not used [-Wunused-const-variable=] 561 | static const struct hda_codec_ops cs421x_codec_ops = { | ^~~~~~~~~~~~~~~~ vim +/cs421x_codec_ops +561 sound/hda/codecs/cirrus/cs421x.c 560 > 561 static const struct hda_codec_ops cs421x_codec_ops = { 562 .probe = cs421x_probe, 563 .remove = snd_hda_gen_remove, 564 .build_controls = snd_hda_gen_build_controls, 565 .build_pcms = snd_hda_gen_build_pcms, 566 .init = cs421x_init, 567 .unsol_event = snd_hda_jack_unsol_event, 568 .suspend = cs421x_suspend, 569 .stream_pm = snd_hda_gen_stream_pm, 570 }; 571 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:test/hda-reorg 29/53] sound/hda/common/hwdep.c:26:6: warning: label followed by a declaration is a C23 extension
by kernel test robot 05 Jul '25

05 Jul '25

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/hda-reorg head: 6119728edf86cefcbf7b20e000414c85916e900d commit: 5b965be899c8e3286f5111b7e90207afe5124b67 [29/53] ALSA: hda: Move common codec driver into sound/hda/common directory config: riscv-randconfig-001-20250705 (https://download.01.org/0day-ci/archive/20250705/202507051454.VintnWOF-lkp@…) compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 61529d9e36fa86782a2458e6bdeedf7f376ef4b5) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250705/202507051454.VintnWOF-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507051454.VintnWOF-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from sound/hda/common/hwdep.c:10: In file included from include/linux/compat.h:17: include/linux/fs.h:3979:15: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 3979 | if (unlikely(get_user(c, path))) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ >> sound/hda/common/hwdep.c:26:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 26 | if (get_user(verb, &arg->verb)) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ sound/hda/common/hwdep.c:40:6: warning: label followed by a declaration is a C23 extension [-Wc23-extensions] 40 | if (get_user(verb, &arg->verb)) | ^ arch/riscv/include/asm/uaccess.h:274:3: note: expanded from macro 'get_user' 274 | __get_user((x), __p) : \ | ^ arch/riscv/include/asm/uaccess.h:244:2: note: expanded from macro '__get_user' 244 | __get_user_error(__gu_val, __gu_ptr, __gu_err); \ | ^ arch/riscv/include/asm/uaccess.h:207:2: note: expanded from macro '__get_user_error' 207 | __get_user_nocheck(x, ptr, __gu_failed); \ | ^ arch/riscv/include/asm/uaccess.h:196:3: note: expanded from macro '__get_user_nocheck' 196 | __get_user_8((x), __gu_ptr, label); \ | ^ arch/riscv/include/asm/uaccess.h:130:2: note: expanded from macro '__get_user_8' 130 | u32 __user *__ptr = (u32 __user *)(ptr); \ | ^ 3 warnings generated. vim +26 sound/hda/common/hwdep.c 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 17 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 18 /* 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 19 * write/read an out-of-bound verb 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 20 */ 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 21 static int verb_write_ioctl(struct hda_codec *codec, 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 22 struct hda_verb_ioctl __user *arg) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 23 { 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 24 u32 verb, res; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 25 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 @26 if (get_user(verb, &arg->verb)) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 27 return -EFAULT; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 28 res = snd_hda_codec_read(codec, verb >> 24, 0, 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 29 (verb >> 8) & 0xffff, verb & 0xff); 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 30 if (put_user(res, &arg->res)) 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 31 return -EFAULT; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 32 return 0; 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 33 } 2807314d467e7d sound/pci/hda/hda_hwdep.c Takashi Iwai 2007-07-27 34 :::::: The code at line 26 was first introduced by commit :::::: 2807314d467e7dd929c42050031aabbd28e78f0b [ALSA] hda-intel - Add hwdep interface :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)perex.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[GIT PULL] ASoC fixes for v6.16-rc4
by Mark Brown 04 Jul '25

04 Jul '25

The following changes since commit d0b3b7b22dfa1f4b515fd3a295b3fd958f9e81af: Linux 6.16-rc4 (2025-06-29 13:09:04 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.16-rc4 for you to fetch changes up to 3b3312f28ee2d9c386602f8521e419cfc69f4823: ASoC: cs35l56: probe() should fail if the device ID is not recognized (2025-07-03 12:22:27 +0100) ---------------------------------------------------------------- ASoC: Fixes for v6.16 An update for the MAINTAINERS file, plus a number of small driver specific fixes and device quirks. ---------------------------------------------------------------- Arun Raghavan (1): ASoC: fsl_sai: Force a software reset when starting in consumer mode Bard Liao (1): ASoC: Intel: SND_SOC_INTEL_SOF_BOARD_HELPERS select SND_SOC_ACPI_INTEL_MATCH Charles Keepax (1): ASoC: Intel: soc-acpi: arl: Correct order of cs42l43 matches Richard Fitzgerald (1): ASoC: cs35l56: probe() should fail if the device ID is not recognized Shengjiu Wang (1): ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode Simon Trimmer (1): ASoC: Intel: sof_sdw: Add quirks for Lenovo P1 and P16 Srinivas Kandagatla (1): MAINTAINERS: update Qualcomm audio codec drivers list MAINTAINERS | 16 +++++----------- sound/soc/codecs/cs35l56-shared.c | 2 +- sound/soc/fsl/fsl_asrc.c | 3 ++- sound/soc/fsl/fsl_sai.c | 14 ++++++++------ sound/soc/intel/boards/Kconfig | 1 + sound/soc/intel/boards/sof_sdw.c | 3 +++ sound/soc/intel/common/soc-acpi-intel-arl-match.c | 12 ++++++------ 7 files changed, 26 insertions(+), 25 deletions(-)

2 1

[BUG] Mackie DLZ Creator XS – USB Audio: write error -77 after accepted hw_params
by Brian Knutsson 04 Jul '25

04 Jul '25

Hi ALSA devs, I'm reporting an issue with the Mackie DLZ Creator XS USB audio device on Linux (tested on Ubuntu 24.04 and 25.05 with kernel 6.8+). The device is detected correctly via ALSA (card 2: XS), but as soon as playback is initiated – whether via `aplay` or `speaker-test` – it disconnects with `write error: -77, File descriptor in bad state`. Relevant kernel logs show: usb 3-7: Product: DLZ Creator XS usb 3-7: Manufacturer: LOUD Audio, LLC usb 3-7: USB disconnect, device number X This occurs with and without PipeWire/udev running. I’ve created a full ALSA log with `alsa-info` and opened a Kernel Bugzilla entry: <https://bugzilla.kernel.org/show_bug.cgi?id=220143> Is there any known quirk or patch needed for this hardware? Or a way to assist debugging further (usbmon trace etc.)? Thanks in advance, Brian Knutsson

2 1

[PATCH v1] ALSA: hda/tas2781: Add bus name in device name check
by Baojun Xu 03 Jul '25

03 Jul '25

Device name start from bus name, as we use strstarts() to do compare, need add it for TXNW2781 device. Signed-off-by: Baojun Xu <baojun.xu(a)ti.com> --- sound/pci/hda/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index b9cdbca95..530c2266a 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -588,7 +588,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; } else if (strstarts(dev_name(&clt->dev), - "TXNW2781:00-tas2781-hda.0")) { + "i2c-TXNW2781:00-tas2781-hda.0")) { device_name = "TXNW2781"; hda_priv->save_calibration = tas2781_save_calibration; tas_hda->priv->global_addr = TAS2781_GLOBAL_ADDR; -- 2.43.0

1 0

[PATCH 0/3] Add legacy driver support for ACP7.2 based
by Venkata Prasad Potturu 02 Jul '25

02 Jul '25

This patch series is to add I2S and PDM support for ACP7.2 based platforms. Venkata Prasad Potturu (3): ASoC: amd: acp: Add legacy driver support acp7.2 based platforms ASoC: amd: acp: Enable I2S support for acp7.2 based platforms ASoC: amd: acp: Enable acp7.2 platform based DMIC support in machine driver sound/soc/amd/acp/acp-i2s.c | 3 +++ sound/soc/amd/acp/acp-legacy-common.c | 2 ++ sound/soc/amd/acp/acp-mach-common.c | 1 + sound/soc/amd/acp/acp-pci.c | 1 + sound/soc/amd/acp/acp-platform.c | 2 ++ sound/soc/amd/acp/acp70.c | 1 + sound/soc/amd/acp/acp_common.h | 1 + 7 files changed, 11 insertions(+) -- 2.43.0

2 4