- Alsa-devel - mailman.alsa-project.org

Re: [v3?] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 07 Oct '24

07 Oct '24

… > --- > v2: Fix "From" tag. > v3: Format tags to Fixes/Cc/Signed-off-by. > --- … * How do you think about to reconsider the version numbers a bit more? * Would you like to mention the repeated adjustment of the patch subject? * Can a duplicate marker line be replaced by a blank line? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc… Is the email address “linux-kernel(a)vger.kernel.xn--org-9o0a still relevant here? Regards, Markus

1 0

Re: [PATCH v3] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 07 Oct '24

07 Oct '24

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could call? > possibly return NULL pointer. NULL Pointer Dereference may be Can the term “null pointer dereference” be applied for the final commit message (including the summary phrase)? > triggerred without addtional check. triggered? additional? Regards, Markus

1 0

Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Markus Elfring 07 Oct '24

07 Oct '24

> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could call? > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. … * How do you think about to use the term “null pointer dereference” for the final commit message (including the summary phrase)? * Would you like to avoid any typos here? … > --- > sound/soc/qcom/lpass-cpu.c | 2 ++ Did you overlook to add a version description behind the marker line? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Doc… Regards, Markus

2 5

[PATCH 0/3] Fixes and improvements related to amd soundwire machine
by Vijendar Mukunda 07 Oct '24

07 Oct '24

This patch series consists of smatch error fixes and code improvements related to amd soundwire generic machine driver. Vijendar Mukunda (3): ASoC: amd: acp: fix for inconsistent indenting ASoC: amd: acp: fix for cpu dai index logic ASoC: amd: acp: refactor sof_card_dai_links_create() function sound/soc/amd/acp/acp-sdw-sof-mach.c | 47 +++++++++++----------------- 1 file changed, 18 insertions(+), 29 deletions(-) -- 2.34.1

1 3

[PATCH treewide 00/11] ASoC: Clean up {hp,mic}-det-gpio handling
by Geert Uytterhoeven 07 Oct '24

07 Oct '24

Hi all, The "gpio" suffix for GPIO consumers was deprecated a while ago, in favor of the "gpios" suffix. However, there are still several users of the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings, drivers, and DT source files. Drivers that use gpiolib handle both the deprecated and new properties transparently, but that is not the case when using of_property_*() calls directly. - The first patch fixes a bug, as the Freescale Generic ASoC Sound driver handles only the deprecated properties, while there is already a user of the new variants, - The second patch updates the Audio Graph and Simple Audio Card DT bindings, - Patches 3-9 converts various DTS files to use the new properties, - The last 2 patches convert Freescale sound device nodes to use the new properties. All patches can be applied independently, except for the last two, which depend on the first patch to avoid regressions. This series was compile-tested only. Thanks for your comments! Geert Uytterhoeven (11): ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio ARM: dts: marvell: mmp2-olpc-xo-1-75: Switch to {hp,mic}-det-gpios arm64: dts: freescale: imx: Switch to simple-audio-card,hp-det-gpios arm64: dts: renesas: beacon-renesom: Switch to mic-det-gpios arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios arm64: dts: rockchip: Switch to hp-det-gpios arm64: dts: uniphier: Switch to hp-det-gpios mips: dts: ingenic: Switch to simple-audio-card,hp-det-gpios ARM: dts: nxp: imx: Switch to {hp,mic}-det-gpios arm64: dts: freescale: imx: Switch to hp-det-gpios .../devicetree/bindings/sound/audio-graph.yaml | 6 ++++++ .../devicetree/bindings/sound/simple-card.yaml | 12 ++++++++++++ arch/arm/boot/dts/marvell/mmp2-olpc-xo-1-75.dts | 4 ++-- arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi | 4 ++-- arch/arm/boot/dts/nxp/imx/imx6sl-evk.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6sll-evk.dts | 2 +- arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx6ul-14x14-evk.dtsi | 2 +- arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 2 +- .../boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +- arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +- arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 2 +- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +- arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 2 +- .../boot/dts/renesas/beacon-renesom-baseboard.dtsi | 2 +- .../boot/dts/rockchip/rk3326-anbernic-rg351m.dtsi | 2 +- .../arm64/boot/dts/rockchip/rk3326-gameforce-chi.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts | 2 +- .../boot/dts/rockchip/rk3399-rock-pi-4a-plus.dts | 2 +- .../boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts | 2 +- .../boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg-arc.dtsi | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353ps.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg353vs.dts | 2 +- .../boot/dts/rockchip/rk3566-anbernic-rg503.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3566-powkiddy-x55.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts | 2 +- .../dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 2 +- arch/arm64/boot/dts/rockchip/rk3588-ok3588-c.dts | 2 +- .../boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +- .../boot/dts/rockchip/rk3588s-gameforce-ace.dts | 2 +- .../boot/dts/socionext/uniphier-ld11-global.dts | 2 +- .../boot/dts/socionext/uniphier-ld20-global.dts | 2 +- arch/mips/boot/dts/ingenic/gcw0.dts | 2 +- arch/mips/boot/dts/ingenic/rs90.dts | 2 +- sound/soc/fsl/fsl-asoc-card.c | 8 +++++--- 50 files changed, 72 insertions(+), 52 deletions(-) -- 2.34.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds

6 27

Re: [PATCH v2 7/7] arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support
by Dmitry Baryshkov 06 Oct '24

06 Oct '24

On Wed, Oct 02, 2024 at 03:20:15AM GMT, Alexey Klimov wrote: > Add sound node and dsp-related piece to enable HDMI audio > playback support on Qualcomm QRB4210 RB2 board. That is the > only sound output supported for now. > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 55 ++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > [...] > @@ -318,6 +365,14 @@ &pon_resin { > status = "okay"; > }; > > +/* SECONDARY I2S Uses 1 I2S SD Lines for audio on LT9611 HDMI Bridge */ Nit: LT9611UXC Nevertheless, Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> > +&q6afedai { > + dai@20 { > + reg = <SECONDARY_MI2S_RX>; > + qcom,sd-lines = <0>; > + }; > +}; > + > &qupv3_id_0 { > status = "okay"; > }; > -- > 2.45.2 > -- With best wishes Dmitry

1 0

Re: [PATCH v2 5/7] arm64: dts: qcom: sm4250: add LPASS LPI pin controller
by Dmitry Baryshkov 06 Oct '24

06 Oct '24

On Wed, Oct 02, 2024 at 03:20:13AM GMT, Alexey Klimov wrote: > Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) > pin controller device node required for audio subsystem on > Qualcomm QRB4210 RB2. > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > arch/arm64/boot/dts/qcom/sm4250.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm4250.dtsi b/arch/arm64/boot/dts/qcom/sm4250.dtsi > index c5add8f44fc0..37c0e963e739 100644 > --- a/arch/arm64/boot/dts/qcom/sm4250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm4250.dtsi > @@ -3,6 +3,7 @@ > * Copyright (c) 2021, Iskren Chernev <iskren.chernev(a)gmail.com> > */ > > +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h> > #include "sm6115.dtsi" > > &CPU0 { > @@ -36,3 +37,18 @@ &CPU6 { > &CPU7 { > compatible = "qcom,kryo240"; > }; > + > +&soc { > + lpass_tlmm: pinctrl@a7c0000 { Please add the node to sm6115.dtsi and override the compat string here. > + compatible = "qcom,sm4250-lpass-lpi-pinctrl"; > + reg = <0x0 0xa7c0000 0x0 0x20000>, > + <0x0 0xa950000 0x0 0x10000>; Please pad address to 8 hex digits: reg = <0x0 0x0a7c0000 0x0 0x20000> > + > + clocks = <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > + clock-names = "audio"; > + > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpass_tlmm 0 0 26>; > + }; > +}; > -- > 2.45.2 > -- With best wishes Dmitry

1 0

Re: [PATCH v2 3/7] ASoC: qcom: sm8250: add handling of secondary MI2S clock
by Dmitry Baryshkov 06 Oct '24

06 Oct '24

On Wed, Oct 02, 2024 at 03:20:11AM GMT, Alexey Klimov wrote: > Add handling of clock related to secondary MI2S_RX in > sm8250_snd_startup(). > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > sound/soc/qcom/sm8250.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> -- With best wishes Dmitry

1 0

Re: [PATCH v2 2/7] ASoC: qcom: sm8250: add qrb4210-rb2-sndcard compatible string
by Dmitry Baryshkov 06 Oct '24

06 Oct '24

On Wed, Oct 02, 2024 at 03:20:10AM GMT, Alexey Klimov wrote: > Add "qcom,qrb4210-rb2-sndcard" to the list of recognizable > devices. > > Signed-off-by: Alexey Klimov <alexey.klimov(a)linaro.org> > --- > sound/soc/qcom/sm8250.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> -- With best wishes Dmitry

1 0

Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe()
by Dmitry Baryshkov 06 Oct '24

06 Oct '24

On Thu, Oct 03, 2024 at 10:27:39AM GMT, Gax-c wrote: > From: Zichen Xie <zichenxie0106(a)gmail.com> > > A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could > possibly return NULL pointer. NULL Pointer Dereference may be > triggerred without addtional check. > Add a NULL check for the returned pointer. > > Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers") > Signed-off-by: Zichen Xie <zichenxie0106(a)gmail.com> > Cc: stable(a)vger.kernel.org I think Fixes / Cc / Signed-off-by is more logical. > --- > sound/soc/qcom/lpass-cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > This is version two of your patch (even though the patch contents didn't change). Please tag your patches accordingly, provide a changelog and don't send next iteration as a reply to the existing thread (it might get lost or mishandled). Please send a proper v3 of your patch. -- With best wishes Dmitry

1 0