- Alsa-devel - mailman.alsa-project.org

snd_tlv_convert_to_dB: Fix mute handling for MINMAX_MUTE type
by GitHub pull_request - opened 15 Sep '25

15 Sep '25

alsa-project/alsa-lib pull request #478 was opened from qaqland: Ensure the SND_CTL_TLV_DB_GAIN_MUTE value is returned when the calculated gain equals the minimum dB value for the SNDRV_CTL_TLVT_DB_MINMAX_MUTE type. The previous check based solely on the volume value could miss cases where the linear calculation resulted in the minimum gain. The db range of some devices is very small <img width="619" height="106" alt="17574693041385" src="https://github.com/user-attachments/assets/3461c643-284d-4ef0-8315-8fc68268…" /> Request URL : https://github.com/alsa-project/alsa-lib/pull/478 Patch URL : https://github.com/alsa-project/alsa-lib/pull/478.patch Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Re: [PATCH 2/2] ALSA: hda/realtek: Support Lenovo Thinkbook 13x Gen 5
by Takashi Iwai 14 Sep '25

14 Sep '25

On Sun, 14 Sep 2025 00:38:25 +0200, Bou-Saan Che wrote: > > The laptop does not contain valid _DSD for these amps, so requires > entries into the CS35L41 configuration table to function correctly. > > Signed-off-by: Bou-Saan Che <yungmeat(a)inboxia.org> As requested in your another patch, could you try to rebase to the latest 6.17-rc, verify the patch still working and resubmit? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 2627e2f49316..36dc0389c9bd 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -11368,6 +11368,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x3913, "Lenovo 145", ALC236_FIXUP_LENOVO_INV_DMIC), > SND_PCI_QUIRK(0x17aa, 0x391f, "Yoga S990-16 pro Quad YC Quad", ALC287_FIXUP_TAS2781_I2C), > SND_PCI_QUIRK(0x17aa, 0x3920, "Yoga S990-16 pro Quad VECO Quad", ALC287_FIXUP_TAS2781_I2C), > + SND_PCI_QUIRK(0x17aa, 0x3929, "Thinkbook 13x Gen 5", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), > + SND_PCI_QUIRK(0x17aa, 0x392b, "Thinkbook 13x Gen 5", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), > SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI), > SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K), > -- > 2.51.0 > >

1 0

Re: [PATCH] ALSA: hda/realtek: Fix volume adjustment issue on Lenovo Thinkbook 13x Gen 4
by Takashi Iwai 14 Sep '25

14 Sep '25

On Sun, 14 Sep 2025 00:53:44 +0200, Bou-Saan Che wrote: > > This patch fixes the volume adjustment issue on this laptop by applying > the necessary quirk configuration for the Realtek ALC287 codec. > > The issue was caused by incorrect configuration in the driver, > which prevented proper volume control on certain systems. > > Signed-off-by: Bou-Saan Che <yungmeat(a)inboxia.org> The HD-audio driver code was largely refactored since 6.17. e.g. the driver code is now found in sound/hda/codecs/realtek/alc269.c. Could you rebase to the latest 6.17-rc kernel, verify that it's still working and resubmit? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 2627e2f49316..1981e3374b3e 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -11346,8 +11346,8 @@ static const struct hda_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x17aa, 0x38be, "Yoga S980-14.5 proX YC Dual", ALC287_FIXUP_TAS2781_I2C), > SND_PCI_QUIRK(0x17aa, 0x38bf, "Yoga S980-14.5 proX LX Dual", ALC287_FIXUP_TAS2781_I2C), > SND_PCI_QUIRK(0x17aa, 0x38c3, "Y980 DUAL", ALC287_FIXUP_TAS2781_I2C), > - SND_PCI_QUIRK(0x17aa, 0x38c7, "Thinkbook 13x Gen 4", ALC287_FIXUP_CS35L41_I2C_4), > - SND_PCI_QUIRK(0x17aa, 0x38c8, "Thinkbook 13x Gen 4", ALC287_FIXUP_CS35L41_I2C_4), > + SND_PCI_QUIRK(0x17aa, 0x38c7, "Thinkbook 13x Gen 4", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), > + SND_PCI_QUIRK(0x17aa, 0x38c8, "Thinkbook 13x Gen 4", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD), > SND_PCI_QUIRK(0x17aa, 0x38cb, "Y790 YG DUAL", ALC287_FIXUP_TAS2781_I2C), > SND_PCI_QUIRK(0x17aa, 0x38cd, "Y790 VECO DUAL", ALC287_FIXUP_TAS2781_I2C), > SND_PCI_QUIRK(0x17aa, 0x38d2, "Lenovo Yoga 9 14IMH9", ALC287_FIXUP_YOGA9_14IMH9_BASS_SPK_PIN), > -- > 2.51.0 > >

1 0

Internal microphone (Conexant SN6140) nonfunctional on Lenovo IdeaPad Slim 5 16AKP10 83HY after alsa-ucm-conf 1.2.14+
by GitHub issues - edited 12 Sep '25

12 Sep '25

alsa-project/alsa-ucm-conf issue #612 was edited from JayJaber: The internal microphone on a Lenovo IdeaPad Slim 5 16AKP10 83HY with Conexant SN6140 codec behaves as follows: On alsa-ucm-conf 1.2.14 and newer: - Family 17h/19h/1ah HD Audio Controller Digital Microphone appears as a recording device but does not record. Only a small bit of static is audible at the start and end of recordings. - Family 17h/19h/1ah HD Audio Controller Stereo Microphone appears as inactive/unplugged. When headphones are plugged in, it becomes active and the headphone microphone works under that device. After downgrading to alsa-ucm-conf 1.2.13-2: - Both Family 17h/19h/1ah HD Audio Controller Internal Stereo Microphone and Family 17h/19h/1ah HD Audio Controller Digital Microphone appear as active recording devices without headphones plugged in. - Digital Microphone still does not record usable audio, only a small bit of static at the beginning and end. - Internal Stereo Microphone works correctly for the built-in mic when headphones are not plugged in. Plugging in headphones causes the headphone microphone to be used under the Internal Stereo Microphone device. Summary: The Digital Microphone is detected but never records usable audio. On 1.2.13-2, the Internal Stereo Microphone routes audio correctly from the built-in mic, so recording works, but the Digital Microphone itself remains nonfunctional. On 1.2.14+: - Digital Microphone appears but remains completely nonfunctional. - Stereo Microphone shows as inactive/unplugged until headphones are connected, making the internal microphone unusable. - Headphone microphone routing works correctly. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/612 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Internal microphone (Conexant SN6140) detected but shows inactive/unplugged on Lenovo IdeaPad Slim 5 16AKP10 83HY after alsa-ucm-conf 1.2.14
by GitHub issues - edited 12 Sep '25

12 Sep '25

alsa-project/alsa-ucm-conf issue #612 was edited from JayJaber: The internal microphone on a Lenovo IdeaPad Slim 5 16AKP10 83HY with Conexant SN6140 codec behaves as follows: On alsa-ucm-conf 1.2.14 and newer: - Family 17h/19h/1ah HD Audio Controller Digital Microphone appears as a recording device but does not record. Only a small bit of static is audible at the start and end of recordings. - Family 17h/19h/1ah HD Audio Controller Stereo Microphone appears as inactive/unplugged. When headphones are plugged in, it becomes active and the headphone microphone works under that device. After downgrading to alsa-ucm-conf 1.2.13-2: - Both Family 17h/19h/1ah HD Audio Controller Internal Stereo Microphone and Family 17h/19h/1ah HD Audio Controller Digital Microphone appear as active recording devices without headphones plugged in. - Digital Microphone still does not record usable audio, only a small bit of static at the beginning and end. - Internal Stereo Microphone works correctly for the built-in mic when headphones are not plugged in. Plugging in headphones causes the headphone microphone to be used under the Internal Stereo Microphone device. Summary: The Digital Microphone is detected but never records usable audio. On 1.2.13-2, the Internal Stereo Microphone routes audio correctly from the built-in mic, so recording works, but the Digital Microphone itself remains nonfunctional. On 1.2.14+: - Digital Microphone appears but remains completely nonfunctional. - Stereo Microphone shows as inactive/unplugged until headphones are connected, making the internal microphone unusable. - Headphone microphone routing works correctly. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/612 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: [EXTERNAL] Re: [PATCH v4 2/6] ASoC: ops: add snd_soc_get_volsw_clamped
by Mark Brown 11 Sep '25

11 Sep '25

On Thu, Sep 11, 2025 at 05:21:14PM +0000, Holalu Yogendra, Niranjan wrote: > > From: Mark Brown <broonie(a)kernel.org> > > Why is this a separate API, what is the situation where we would want to > > report an invalid value from a control? I was thinking of just adding > > this to the existing operations rather than adding separate ones that > > need to be explicitly set. > Since few of the drivers as still using the original API, and was not sure if > everyone wanted to clamp the register value, did not want to disturb the > original API snd_soc_get_volsw. Per my analysis, if register read fails due to In what situation would anything want to report an invalid value? > some issue (like IO) and, for some reason if register value was modified > to have the value greater than mc->max value, the volume is report erroneously. > Are you thinking that this patch could be dropped and clamp the value to max in > 'soc_get_volsw' (as in 1st patch) and use the same API ? Please suggest. Yes, everything should report valid values. I/O errors should be propagated as errors.

1 0

[PATCH v1] ALSA: hda/tas2781: Fix a potential race condition that causes a NULL pointer in case no efi.get_variable exsits
by Shenghao Ding 11 Sep '25

11 Sep '25

A a potential race condition reported by one of my customers that leads to a NULL pointer dereference, where the call to efi.get_variable should be guarded with efi_rt_services_supported() to ensure that function exists. Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib") Signed-off-by: Shenghao Ding <shenghao-ding(a)ti.com> --- sound/hda/codecs/side-codecs/tas2781_hda.c | 5 +++++ sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/sound/hda/codecs/side-codecs/tas2781_hda.c b/sound/hda/codecs/side-codecs/tas2781_hda.c index 536940c78f00..96e6d82dc69e 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda.c @@ -193,6 +193,11 @@ int tas2781_save_calibration(struct tas2781_hda *hda) efi_status_t status; int i; + if (!efi_rt_services_supported(EFI_RT_SUPPORTED_GET_VARIABLE)) { + dev_err(p->dev, "%s: NO EFI FOUND!\n", __func__); + return -EINVAL; + } + if (hda->catlog_id < LENOVO) efi_guid = tasdev_fct_efi_guid[hda->catlog_id]; diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c index 008dbe1490a7..4dea442d8c30 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c @@ -317,6 +317,11 @@ static int tas2563_save_calibration(struct tas2781_hda *h) unsigned int attr; int ret, i, j, k; + if (!efi_rt_services_supported(EFI_RT_SUPPORTED_GET_VARIABLE)) { + dev_err(p->dev, "%s: NO EFI FOUND!\n", __func__); + return -EINVAL; + } + cd->cali_dat_sz_per_dev = TAS2563_CAL_DATA_SIZE * TASDEV_CALIB_N; /* extra byte for each device is the device number */ -- 2.43.0

2 1

Re: [PATCH v4 2/6] ASoC: ops: add snd_soc_get_volsw_clamped
by Mark Brown 11 Sep '25

11 Sep '25

On Thu, Sep 11, 2025 at 09:26:59PM +0530, Niranjan H Y wrote: > Add API snd_soc_get_volsw_clamped to read > the volume from device. This similar to > existing API snd_soc_get_volsw. But has > additional step to clamp the value to max value > if the register value is larger than max value. Why is this a separate API, what is the situation where we would want to report an invalid value from a control? I was thinking of just adding this to the existing operations rather than adding separate ones that need to be explicitly set.

1 0

[PATCH v2] ASoC: amd: acp: Fix incorrect retrival of acp_chip_info
by Venkata Prasad Potturu 11 Sep '25

11 Sep '25

Use dev_get_drvdata(dev->parent) instead of dev_get_platdata(dev) to correctly obtain acp_chip_info members in the acp I2S driver. Previously, some members were not updated properly due to incorrect data access, which could potentially lead to null pointer dereferences. This issue was missed in the earlier commit ("ASoC: amd: acp: Fix NULL pointer deref in acp_i2s_set_tdm_slot"), which only addressed set_tdm_slot(). This change ensures that all relevant functions correctly retrieve acp_chip_info, preventing further null pointer dereference issues. Fixes: e3933683b25e ("ASoC: amd: acp: Remove redundant acp_dev_data structure") Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu(a)amd.com> --- Changes since v1: - Update the commit description. sound/soc/amd/acp/acp-i2s.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c index 617690362ad7..4ba0a66981ea 100644 --- a/sound/soc/amd/acp/acp-i2s.c +++ b/sound/soc/amd/acp/acp-i2s.c @@ -73,7 +73,7 @@ static int acp_i2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt) { struct device *dev = cpu_dai->component->dev; - struct acp_chip_info *chip = dev_get_platdata(dev); + struct acp_chip_info *chip = dev_get_drvdata(dev->parent); int mode; mode = fmt & SND_SOC_DAIFMT_FORMAT_MASK; @@ -199,7 +199,7 @@ static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_ u32 reg_val, fmt_reg, tdm_fmt; u32 lrclk_div_val, bclk_div_val; - chip = dev_get_platdata(dev); + chip = dev_get_drvdata(dev->parent); rsrc = chip->rsrc; /* These values are as per Hardware Spec */ @@ -386,7 +386,7 @@ static int acp_i2s_trigger(struct snd_pcm_substream *substream, int cmd, struct { struct acp_stream *stream = substream->runtime->private_data; struct device *dev = dai->component->dev; - struct acp_chip_info *chip = dev_get_platdata(dev); + struct acp_chip_info *chip = dev_get_drvdata(dev->parent); struct acp_resource *rsrc = chip->rsrc; u32 val, period_bytes, reg_val, ier_val, water_val, buf_size, buf_reg; @@ -516,14 +516,13 @@ static int acp_i2s_trigger(struct snd_pcm_substream *substream, int cmd, struct static int acp_i2s_prepare(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { struct device *dev = dai->component->dev; - struct acp_chip_info *chip = dev_get_platdata(dev); + struct acp_chip_info *chip = dev_get_drvdata(dev->parent); struct acp_resource *rsrc = chip->rsrc; struct acp_stream *stream = substream->runtime->private_data; u32 reg_dma_size = 0, reg_fifo_size = 0, reg_fifo_addr = 0; u32 phy_addr = 0, acp_fifo_addr = 0, ext_int_ctrl; unsigned int dir = substream->stream; - chip = dev_get_platdata(dev); switch (dai->driver->id) { case I2S_SP_INSTANCE: if (dir == SNDRV_PCM_STREAM_PLAYBACK) { @@ -632,7 +631,7 @@ static int acp_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_d { struct acp_stream *stream = substream->runtime->private_data; struct device *dev = dai->component->dev; - struct acp_chip_info *chip = dev_get_platdata(dev); + struct acp_chip_info *chip = dev_get_drvdata(dev->parent); struct acp_resource *rsrc = chip->rsrc; unsigned int dir = substream->stream; unsigned int irq_bit = 0; -- 2.43.0

2 1

Internal microphone (Conexant SN6140) detected but shows inactive/unplugged on Lenovo IdeaPad Slim 5 16AKP10 83HY after alsa-ucm-conf 1.2.14
by GitHub issues - edited 11 Sep '25

11 Sep '25

alsa-project/alsa-ucm-conf issue #612 was edited from JayJaber: On a Lenovo IdeaPad Slim 5 16AKP10 83HY with Conexant SN6140 codec, the internal microphone works correctly with alsa-ucm-conf 1.2.13-2, but with 1.2.14 and newer it is detected but shows up as inactive/unplugged. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/612 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0