January 2024 - Alsa-devel - mailman.alsa-project.org

[tiwai-sound:topic/pm-ops 9/31] sound/pci/ens1370.c:1988:2: error: call to undeclared function 'snd_ak4531_suspend'; ISO C99 and later do not support implicit function declarations
by kernel test robot 26 Jan '24

26 Jan '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/pm-ops head: 623b2f6110ff118b84628595d53e4947f2883329 commit: e2a78f52bd0f02f34a84d1f4437dadf3cefdca79 [9/31] ALSA: ens137x: Replace with DEFINE_SIMPLE_DEV_PM_OPS() config: i386-randconfig-012-20240125 (https://download.01.org/0day-ci/archive/20240126/202401261439.SV1NYR8a-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261439.SV1NYR8a-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261439.SV1NYR8a-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/pci/ens1370.c:1988:2: error: call to undeclared function 'snd_ak4531_suspend'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 1988 | snd_ak4531_suspend(ensoniq->u.es1370.ak4531); | ^ sound/pci/ens1370.c:1988:2: note: did you mean 'snd_ak4531_mixer'? include/sound/ak4531_codec.h:62:5: note: 'snd_ak4531_mixer' declared here 62 | int snd_ak4531_mixer(struct snd_card *card, struct snd_ak4531 *_ak4531, | ^ >> sound/pci/ens1370.c:2003:2: error: call to undeclared function 'snd_ak4531_resume'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 2003 | snd_ak4531_resume(ensoniq->u.es1370.ak4531); | ^ 2 errors generated. vim +/snd_ak4531_suspend +1988 sound/pci/ens1370.c f31a31b9024f21 Kurt J. Bosch 2005-11-16 1970 68cb2b55927885 Takashi Iwai 2012-07-02 1971 static int snd_ensoniq_suspend(struct device *dev) f31a31b9024f21 Kurt J. Bosch 2005-11-16 1972 { 68cb2b55927885 Takashi Iwai 2012-07-02 1973 struct snd_card *card = dev_get_drvdata(dev); fe8be10786c040 Takashi Iwai 2005-11-17 1974 struct ensoniq *ensoniq = card->private_data; fe8be10786c040 Takashi Iwai 2005-11-17 1975 fe8be10786c040 Takashi Iwai 2005-11-17 1976 snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1977 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1978 #ifdef CHIP1371 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1979 snd_ac97_suspend(ensoniq->u.es1371.ac97); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1980 #else 15f500a6994e55 Takashi Iwai 2006-01-12 1981 /* try to reset AK4531 */ 15f500a6994e55 Takashi Iwai 2006-01-12 1982 outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x02), ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1983 inw(ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1984 udelay(100); 15f500a6994e55 Takashi Iwai 2006-01-12 1985 outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x03), ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1986 inw(ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1987 udelay(100); fe8be10786c040 Takashi Iwai 2005-11-17 @1988 snd_ak4531_suspend(ensoniq->u.es1370.ak4531); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1989 #endif f31a31b9024f21 Kurt J. Bosch 2005-11-16 1990 return 0; f31a31b9024f21 Kurt J. Bosch 2005-11-16 1991 } f31a31b9024f21 Kurt J. Bosch 2005-11-16 1992 68cb2b55927885 Takashi Iwai 2012-07-02 1993 static int snd_ensoniq_resume(struct device *dev) f31a31b9024f21 Kurt J. Bosch 2005-11-16 1994 { 68cb2b55927885 Takashi Iwai 2012-07-02 1995 struct snd_card *card = dev_get_drvdata(dev); fe8be10786c040 Takashi Iwai 2005-11-17 1996 struct ensoniq *ensoniq = card->private_data; f31a31b9024f21 Kurt J. Bosch 2005-11-16 1997 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1998 snd_ensoniq_chip_init(ensoniq); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1999 f31a31b9024f21 Kurt J. Bosch 2005-11-16 2000 #ifdef CHIP1371 f31a31b9024f21 Kurt J. Bosch 2005-11-16 2001 snd_ac97_resume(ensoniq->u.es1371.ac97); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2002 #else fe8be10786c040 Takashi Iwai 2005-11-17 @2003 snd_ak4531_resume(ensoniq->u.es1370.ak4531); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2004 #endif fe8be10786c040 Takashi Iwai 2005-11-17 2005 snd_power_change_state(card, SNDRV_CTL_POWER_D0); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2006 return 0; f31a31b9024f21 Kurt J. Bosch 2005-11-16 2007 } f31a31b9024f21 Kurt J. Bosch 2005-11-16 2008 :::::: The code at line 1988 was first introduced by commit :::::: fe8be10786c040bce53c18048d75b1b23aec64ae [ALSA] ens137x - Fix and ADD PM support :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)suse.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:topic/pm-ops 7/31] sound/pci/als4000.c:947:2: error: call to undeclared function 'snd_sbmixer_suspend'; ISO C99 and later do not support implicit function declarations
by kernel test robot 26 Jan '24

26 Jan '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/pm-ops head: 623b2f6110ff118b84628595d53e4947f2883329 commit: 6dae83b64fac25af472e718bf086b43a1f209674 [7/31] ALSA: als4000: Replace with DEFINE_SIMPLE_DEV_PM_OPS() config: i386-randconfig-012-20240125 (https://download.01.org/0day-ci/archive/20240126/202401260641.blzmb4QO-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401260641.blzmb4QO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401260641.blzmb4QO-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/pci/als4000.c:947:2: error: call to undeclared function 'snd_sbmixer_suspend'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 947 | snd_sbmixer_suspend(chip); | ^ sound/pci/als4000.c:947:2: note: did you mean 'snd_sbmixer_read'? include/sound/sb.h:288:15: note: 'snd_sbmixer_read' declared here 288 | unsigned char snd_sbmixer_read(struct snd_sb *chip, unsigned char reg); | ^ >> sound/pci/als4000.c:959:2: error: call to undeclared function 'snd_sbmixer_resume'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 959 | snd_sbmixer_resume(chip); | ^ sound/pci/als4000.c:959:2: note: did you mean 'snd_sbmixer_read'? include/sound/sb.h:288:15: note: 'snd_sbmixer_read' declared here 288 | unsigned char snd_sbmixer_read(struct snd_sb *chip, unsigned char reg); | ^ 2 errors generated. vim +/snd_sbmixer_suspend +947 sound/pci/als4000.c d616a0246da88d Takashi Iwai 2022-04-12 938 68cb2b55927885 Takashi Iwai 2012-07-02 939 static int snd_als4000_suspend(struct device *dev) 703529140cfb77 Takashi Iwai 2005-11-17 940 { 68cb2b55927885 Takashi Iwai 2012-07-02 941 struct snd_card *card = dev_get_drvdata(dev); 703529140cfb77 Takashi Iwai 2005-11-17 942 struct snd_card_als4000 *acard = card->private_data; 703529140cfb77 Takashi Iwai 2005-11-17 943 struct snd_sb *chip = acard->chip; 703529140cfb77 Takashi Iwai 2005-11-17 944 703529140cfb77 Takashi Iwai 2005-11-17 945 snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); 703529140cfb77 Takashi Iwai 2005-11-17 946 703529140cfb77 Takashi Iwai 2005-11-17 @947 snd_sbmixer_suspend(chip); 703529140cfb77 Takashi Iwai 2005-11-17 948 return 0; 703529140cfb77 Takashi Iwai 2005-11-17 949 } 703529140cfb77 Takashi Iwai 2005-11-17 950 68cb2b55927885 Takashi Iwai 2012-07-02 951 static int snd_als4000_resume(struct device *dev) 703529140cfb77 Takashi Iwai 2005-11-17 952 { 68cb2b55927885 Takashi Iwai 2012-07-02 953 struct snd_card *card = dev_get_drvdata(dev); 703529140cfb77 Takashi Iwai 2005-11-17 954 struct snd_card_als4000 *acard = card->private_data; 703529140cfb77 Takashi Iwai 2005-11-17 955 struct snd_sb *chip = acard->chip; 703529140cfb77 Takashi Iwai 2005-11-17 956 703529140cfb77 Takashi Iwai 2005-11-17 957 snd_als4000_configure(chip); 703529140cfb77 Takashi Iwai 2005-11-17 958 snd_sbdsp_reset(chip); 703529140cfb77 Takashi Iwai 2005-11-17 @959 snd_sbmixer_resume(chip); 703529140cfb77 Takashi Iwai 2005-11-17 960 :::::: The code at line 947 was first introduced by commit :::::: 703529140cfb774366b839f38f027f283cb948b4 [ALSA] als4000 - Add PM support :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)suse.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH] ALSA: hda/realtek: Add quirks for HP G11 Laptops using CS35L56
by Richard Fitzgerald 25 Jan '24

25 Jan '24

From: Simon Trimmer <simont(a)opensource.cirrus.com> Add quirks for two HP G11 laptops that use a Realtek HDA codec combined with four CS35L56 amplifiers using SPI. The CS35L56 driver uses the component binding interface, so uses the same setup code as the CS35L41 quirks. Signed-off-by: Simon Trimmer <simont(a)opensource.cirrus.com> Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/pci/hda/patch_realtek.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 42ee37af24bc..b2b289626323 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6819,6 +6819,11 @@ static void alc287_fixup_legion_16ithg6_speakers(struct hda_codec *cdc, const st comp_generic_fixup(cdc, action, "i2c", "CLSA0101", "-%s:00-cs35l41-hda.%d", 2); } +static void cs35l56_fixup_spi_four(struct hda_codec *cdc, const struct hda_fixup *fix, int action) +{ + comp_generic_fixup(cdc, action, "spi", "CSC3556", "-%s:00-cs35l56-hda.%d", 4); +} + static void tas2781_fixup_i2c(struct hda_codec *cdc, const struct hda_fixup *fix, int action) { @@ -7310,6 +7315,7 @@ enum { ALC2XX_FIXUP_HEADSET_MIC, ALC289_FIXUP_DELL_CS35L41_SPI_2, ALC294_FIXUP_CS35L41_I2C_2, + ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED, }; /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9461,6 +9467,12 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = cs35l41_fixup_i2c_two, }, + [ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = cs35l56_fixup_spi_four, + .chained = true, + .chain_id = ALC285_FIXUP_HP_GPIO_LED, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -9789,6 +9801,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c48, "HP EliteBook 860 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c49, "HP Elite x360 830 2-in-1 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8c52, "HP EliteBook 1040 G11", ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8c53, "HP Elite x360 1040 2-in-1 G11", ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), -- 2.30.2

2 1

[PATCH 0/1] ASoC: codecs: Adding new volume kcontrols
by Zhu Ning 25 Jan '24

25 Jan '24

Hi , a patch here for the es8326 driver... We add a new volume control.We compiled the new version patch in for-next branch. We did test with the new driver in machine. The test result met our expectations. Thanks, Michael. Zhu Ning (1): ASoC: codecs: ES8326: Adding new volume kcontrols sound/soc/codecs/es8326.c | 92 ++++++++++++++++++++++++++++++++++++++- sound/soc/codecs/es8326.h | 5 ++- 2 files changed, 95 insertions(+), 2 deletions(-) -- 2.17.1

2 2

[PATCH 1/7] ASoC: cs42l43: Tidy up header includes
by Charles Keepax 25 Jan '24

25 Jan '24

Use more forward declarations, move header guards to cover other includes, and rely less on including headers through other headers. Suggested-by: Andy Shevchenko <andy.shevchenko(a)gmail.com> Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- sound/soc/codecs/cs42l43-jack.c | 5 +++++ sound/soc/codecs/cs42l43-sdw.c | 1 + sound/soc/codecs/cs42l43.c | 8 ++++++++ sound/soc/codecs/cs42l43.h | 19 ++++++++++--------- 4 files changed, 24 insertions(+), 9 deletions(-) diff --git a/sound/soc/codecs/cs42l43-jack.c b/sound/soc/codecs/cs42l43-jack.c index 24a598f2ed9a3..1d8d7bf0a6b0d 100644 --- a/sound/soc/codecs/cs42l43-jack.c +++ b/sound/soc/codecs/cs42l43-jack.c @@ -6,19 +6,24 @@ // Cirrus Logic International Semiconductor Ltd. #include <linux/build_bug.h> +#include <linux/completion.h> #include <linux/delay.h> #include <linux/errno.h> #include <linux/irq.h> #include <linux/jiffies.h> #include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mutex.h> #include <linux/pm_runtime.h> #include <linux/property.h> +#include <linux/regmap.h> +#include <linux/workqueue.h> #include <sound/control.h> #include <sound/jack.h> #include <sound/pcm.h> #include <sound/pcm_params.h> #include <sound/soc-component.h> +#include <sound/soc-jack.h> #include <sound/soc.h> #include "cs42l43.h" diff --git a/sound/soc/codecs/cs42l43-sdw.c b/sound/soc/codecs/cs42l43-sdw.c index 388f95853b699..60c00c05da055 100644 --- a/sound/soc/codecs/cs42l43-sdw.c +++ b/sound/soc/codecs/cs42l43-sdw.c @@ -9,6 +9,7 @@ #include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> #include <linux/module.h> +#include <linux/soundwire/sdw.h> #include <sound/pcm.h> #include <sound/sdw.h> #include <sound/soc-component.h> diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 6a64681767de8..f2332f90f8337 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -6,17 +6,25 @@ // Cirrus Logic International Semiconductor Ltd. #include <linux/bitops.h> +#include <linux/clk.h> +#include <linux/device.h> #include <linux/err.h> #include <linux/errno.h> #include <linux/gcd.h> #include <linux/irq.h> +#include <linux/irqdomain.h> #include <linux/jiffies.h> #include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/platform_device.h> #include <linux/pm_runtime.h> +#include <linux/regmap.h> #include <linux/string.h> +#include <linux/workqueue.h> #include <sound/control.h> +#include <sound/cs42l43.h> #include <sound/pcm.h> #include <sound/pcm_params.h> #include <sound/soc-component.h> diff --git a/sound/soc/codecs/cs42l43.h b/sound/soc/codecs/cs42l43.h index 125e36861d5d5..a491e9254568e 100644 --- a/sound/soc/codecs/cs42l43.h +++ b/sound/soc/codecs/cs42l43.h @@ -6,19 +6,14 @@ * Cirrus Logic International Semiconductor Ltd. */ -#include <linux/clk.h> +#ifndef CS42L43_ASOC_INT_H +#define CS42L43_ASOC_INT_H + #include <linux/completion.h> -#include <linux/device.h> #include <linux/mutex.h> -#include <linux/regmap.h> -#include <linux/soundwire/sdw.h> #include <linux/types.h> -#include <sound/cs42l43.h> +#include <linux/workqueue.h> #include <sound/pcm.h> -#include <sound/soc-jack.h> - -#ifndef CS42L43_ASOC_INT_H -#define CS42L43_ASOC_INT_H #define CS42L43_INTERNAL_SYSCLK 24576000 #define CS42L43_DEFAULT_SLOTS 0x3F @@ -37,6 +32,12 @@ #define CS42L43_N_BUTTONS 6 +struct device; +struct cs42l43; +struct snd_soc_component; +struct snd_soc_jack; +struct clk; + struct cs42l43_codec { struct device *dev; struct cs42l43 *core; -- 2.30.2

2 14

[PATCH 0/2] ALSA: hda: Move component binding support into separate library
by Richard Fitzgerald 25 Jan '24

25 Jan '24

The Cirrus Logic amplifiers are currently paired with Realtek HDA codecs. But they could be used with other codecs. To prepare for this, these two patches move the manager side of the component binding out of the Realtek driver into a library module. The first patch tweaks the CS35L41 code so that it is not hardcoded to CS35L41, and changes the TAS2781 handling so that it re-uses that code instead of having a near-identical copy of it. Can someone please test that these two patches don't break TAS2781? I have checked that they should work in theory but I don't have hardware to test on. Richard Fitzgerald (2): ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps ALSA: hda: realtek: Move hda_component implementation to module MAINTAINERS | 1 + sound/pci/hda/Kconfig | 4 + sound/pci/hda/Makefile | 2 + sound/pci/hda/hda_component.c | 169 ++++++++++++++++++++++++++ sound/pci/hda/hda_component.h | 59 +++++++++ sound/pci/hda/patch_realtek.c | 217 ++++------------------------------ 6 files changed, 261 insertions(+), 191 deletions(-) create mode 100644 sound/pci/hda/hda_component.c -- 2.30.2

3 5

ucm: MediaTek: mt8395-evk: Add HDMIRX config
by GitHub pull_request - opened 25 Jan '24

25 Jan '24

alsa-project/alsa-ucm-conf pull request #389 was opened from zoran055: Add HDMI RX config and modify the priority value of the capture devices. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/389 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/389.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH v2 1/6] spi: cs42l43: Tidy up header includes
by Charles Keepax 24 Jan '24

24 Jan '24

Including some missing headers. Suggested-by: Andy Shevchenko <andy.shevchenko(a)gmail.com> Acked-by: Mark Brown <broonie(a)kernel.org> Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- Changes since v1: - Moved to start of the series The changes to the MFD headers necessitate the inclusion of of.h here to keep things building, hence my including this SPI change in the this MFD series. The rest of the SPI fixups will be sent separately, as they are also not dependent on this change. Thanks, Charles drivers/spi/spi-cs42l43.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c index d239fc5a49ccc..fb62807fc991c 100644 --- a/drivers/spi/spi-cs42l43.c +++ b/drivers/spi/spi-cs42l43.c @@ -11,7 +11,9 @@ #include <linux/errno.h> #include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> -- 2.30.2

2 9

[PATCH 1/6] mfd: cs42l43: Tidy up header includes
by Charles Keepax 24 Jan '24

24 Jan '24

Use more forward declarations, move header guards to cover other includes, and rely less on including headers through other headers. Suggested-by: Andy Shevchenko <andy.shevchenko(a)gmail.com> Signed-off-by: Charles Keepax <ckeepax(a)opensource.cirrus.com> --- drivers/mfd/cs42l43-i2c.c | 6 +++++- drivers/mfd/cs42l43-sdw.c | 6 +++++- drivers/mfd/cs42l43.c | 8 +++++++- drivers/mfd/cs42l43.h | 9 +++++---- include/linux/mfd/cs42l43.h | 13 +++++++------ 5 files changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/mfd/cs42l43-i2c.c b/drivers/mfd/cs42l43-i2c.c index 4922211680c96..7162274a0b551 100644 --- a/drivers/mfd/cs42l43-i2c.c +++ b/drivers/mfd/cs42l43-i2c.c @@ -6,11 +6,15 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include <linux/array_size.h> #include <linux/err.h> -#include <linux/errno.h> #include <linux/i2c.h> +#include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/pm.h> +#include <linux/regmap.h> #include "cs42l43.h" diff --git a/drivers/mfd/cs42l43-sdw.c b/drivers/mfd/cs42l43-sdw.c index 1d85bbf8cdd5d..d6962a5a35f65 100644 --- a/drivers/mfd/cs42l43-sdw.c +++ b/drivers/mfd/cs42l43-sdw.c @@ -6,11 +6,15 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include <linux/array_size.h> #include <linux/device.h> #include <linux/err.h> -#include <linux/errno.h> +#include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> +#include <linux/pm.h> +#include <linux/regmap.h> #include <linux/soundwire/sdw.h> #include <linux/soundwire/sdw_registers.h> #include <linux/soundwire/sdw_type.h> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 7b6d07cbe6fc6..4e2bc5ad244a5 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -6,18 +6,24 @@ * Cirrus Logic International Semiconductor Ltd. */ +#include <linux/array_size.h> #include <linux/bitops.h> #include <linux/build_bug.h> #include <linux/delay.h> +#include <linux/device.h> #include <linux/err.h> -#include <linux/errno.h> #include <linux/firmware.h> +#include <linux/gpio/consumer.h> #include <linux/jiffies.h> #include <linux/mfd/core.h> +#include <linux/mfd/cs42l43.h> #include <linux/mfd/cs42l43-regs.h> #include <linux/module.h> +#include <linux/pm.h> #include <linux/pm_runtime.h> +#include <linux/regmap.h> #include <linux/soundwire/sdw.h> +#include <linux/types.h> #include "cs42l43.h" diff --git a/drivers/mfd/cs42l43.h b/drivers/mfd/cs42l43.h index eb4caf3938332..70129db9f916e 100644 --- a/drivers/mfd/cs42l43.h +++ b/drivers/mfd/cs42l43.h @@ -6,15 +6,16 @@ * Cirrus Logic International Semiconductor Ltd. */ -#include <linux/mfd/cs42l43.h> -#include <linux/pm.h> -#include <linux/regmap.h> - #ifndef CS42L43_CORE_INT_H #define CS42L43_CORE_INT_H #define CS42L43_N_DEFAULTS 176 +struct cs42l43; +struct dev_pm_ops; +struct device; +struct reg_default; + extern const struct dev_pm_ops cs42l43_pm_ops; extern const struct reg_default cs42l43_reg_default[CS42L43_N_DEFAULTS]; diff --git a/include/linux/mfd/cs42l43.h b/include/linux/mfd/cs42l43.h index cf8263aab41bd..2239d8585e785 100644 --- a/include/linux/mfd/cs42l43.h +++ b/include/linux/mfd/cs42l43.h @@ -6,20 +6,21 @@ * Cirrus Logic International Semiconductor Ltd. */ +#ifndef CS42L43_CORE_EXT_H +#define CS42L43_CORE_EXT_H + #include <linux/completion.h> -#include <linux/device.h> -#include <linux/gpio/consumer.h> #include <linux/mutex.h> #include <linux/regmap.h> #include <linux/regulator/consumer.h> -#include <linux/soundwire/sdw.h> #include <linux/workqueue.h> -#ifndef CS42L43_CORE_EXT_H -#define CS42L43_CORE_EXT_H - #define CS42L43_N_SUPPLIES 3 +struct device; +struct gpio_desc; +struct sdw_slave; + enum cs42l43_irq_numbers { CS42L43_PLL_LOST_LOCK, CS42L43_PLL_READY, -- 2.30.2

3 9

[PATCH 0/1] Add support for the framer codec
by Herve Codina 24 Jan '24

24 Jan '24

Hi, This patch introduces the framer codec support. The patch was previously sent as part of a full feature series and was previously reviewed in that context: "Add support for QMC HDLC, framer infrastructure and PEF2256 framer" [1] In order to ease the merge, the full feature series has been split and needed parts were merged in v6.8-rc1: - "Prepare the PowerQUICC QMC and TSA for the HDLC QMC driver" [2] - "Add support for framer infrastructure and PEF2256 framer" [3] The part related to QMC HDLC was sent upstream recently and is under review [4]. This patch is the last one of the full feature series that was not merged nor re-sent recently. Best regards, Hervé [1]: https://lore.kernel.org/linux-kernel/20231115144007.478111-1-herve.codina@b… [2]: https://lore.kernel.org/linux-kernel/20231205152116.122512-1-herve.codina@b… [3]: https://lore.kernel.org/linux-kernel/20231128132534.258459-1-herve.codina@b… [4]: https://lore.kernel.org/linux-kernel/20240123164912.249540-1-herve.codina@b… Patch extracted: - Patch 1 : full feature series patch 26 Herve Codina (1): ASoC: codecs: Add support for the framer codec sound/soc/codecs/Kconfig | 15 ++ sound/soc/codecs/Makefile | 2 + sound/soc/codecs/framer-codec.c | 413 ++++++++++++++++++++++++++++++++ 3 files changed, 430 insertions(+) create mode 100644 sound/soc/codecs/framer-codec.c -- 2.43.0

2 3