January 2024 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: usb-audio: Support read-only clock selector control
by Alexander Tsoy 26 Jan '24

26 Jan '24

Clock selector control might be read-only. Add corresponding checks to prevent sending control requests that would fail. Signed-off-by: Alexander Tsoy <alexander(a)tsoy.me> --- sound/usb/clock.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/sound/usb/clock.c b/sound/usb/clock.c index 94e4aaeafe58..7b259641adb5 100644 --- a/sound/usb/clock.c +++ b/sound/usb/clock.c @@ -261,6 +261,8 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, int ret, i, cur, err, pins, clock_id; const u8 *sources; int proto = fmt->protocol; + bool readable, writeable; + u32 bmControls; entity_id &= 0xff; @@ -292,11 +294,27 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, sources = GET_VAL(selector, proto, baCSourceID); cur = 0; + if (proto == UAC_VERSION_3) + bmControls = le32_to_cpu(*(__le32 *)(&selector->v3.baCSourceID[0] + pins)); + else + bmControls = *(__u8 *)(&selector->v2.baCSourceID[0] + pins); + + readable = uac_v2v3_control_is_readable(bmControls, + UAC2_CX_CLOCK_SELECTOR); + writeable = uac_v2v3_control_is_writeable(bmControls, + UAC2_CX_CLOCK_SELECTOR); + if (pins == 1) { ret = 1; goto find_source; } + /* for now just warn about buggy device */ + if (!readable) + usb_audio_warn(chip, + "%s(): clock selector control is not readable, id %d\n", + __func__, clock_id); + /* the entity ID we are looking at is a selector. * find out what it currently selects */ ret = uac_clock_selector_get_val(chip, clock_id); @@ -326,7 +344,7 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, if (ret > 0) { /* Skip setting clock selector again for some devices */ if (chip->quirk_flags & QUIRK_FLAG_SKIP_CLOCK_SELECTOR || - pins == 1) + pins == 1 || !writeable) return ret; err = uac_clock_selector_set_val(chip, entity_id, cur); if (err < 0) @@ -337,6 +355,9 @@ static int __uac_clock_find_source(struct snd_usb_audio *chip, return ret; find_others: + if (!writeable) + return -ENXIO; + /* The current clock source is invalid, try others. */ for (i = 1; i <= pins; i++) { if (i == cur) -- 2.43.0

2 1

[PATCH v2 0/2] ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+
by Krzysztof Kozlowski 26 Jan '24

26 Jan '24

Hi, Changelog in individual patches. v1: https://lore.kernel.org/all/20230717140138.201745-1-krzysztof.kozlowski@lin… Best regards, Krzysztof Krzysztof Kozlowski (2): ASoC: codecs: tx-macro: split widgets per different LPASS versions ASoC: codecs: tx-macro: correct TX SMIC MUXn widgets on SM8350+ sound/soc/codecs/lpass-macro-common.h | 7 + sound/soc/codecs/lpass-tx-macro.c | 666 +++++++++++++++++++------- 2 files changed, 501 insertions(+), 172 deletions(-) -- 2.34.1

2 6

[PATCH] ASoC: codecs: ES8326: Adding new kcontrols about Headphone resistance
by Zhang Yi 26 Jan '24

26 Jan '24

We get headphone detect issue.And we fix it with the new kcontrols Signed-off-by: Zhang Yi <zhangyi(a)everest-semi.com> --- sound/soc/codecs/es8326.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/sound/soc/codecs/es8326.c b/sound/soc/codecs/es8326.c index 608862aebd71..aa5044eef0ca 100755 --- a/sound/soc/codecs/es8326.c +++ b/sound/soc/codecs/es8326.c @@ -226,6 +226,29 @@ static const char *const hp_spkvol_switch[] = { "HPVOL: HPL+HPR, SPKVOL: SPKL+SPKR", }; +static const char *const hp_det_resistance[] = { + "10K", + "5K", +}; + +static const char *const micbias_resistance[] = { + "5.5K", + "4.5K", + "3.6K", + "2.8K", + "2.1K", + "1.5K", + "1.0K", + "0.6K", +}; + +static const char *const button_resistance[] = { + "100 percent", + "90 percent", + "80 percent", + "70 percent", +}; + static const struct soc_enum dacpol = SOC_ENUM_SINGLE(ES8326_DAC_DSM, 4, 4, dacpol_txt); static const struct soc_enum alc_winsize = @@ -234,6 +257,12 @@ static const struct soc_enum drc_winsize = SOC_ENUM_SINGLE(ES8326_DRC_WINSIZE, 4, 16, winsize); static const struct soc_enum hpvol_spkvol_switch = SOC_ENUM_SINGLE(ES8326_HP_MISC, 6, 4, hp_spkvol_switch); +static const struct soc_enum hp_det = + SOC_ENUM_SINGLE(ES8326_ANA_MICBIAS, 7, 2, hp_det_resistance); +static const struct soc_enum micbias_res = + SOC_ENUM_SINGLE(ES8326_ANA_MICBIAS, 4, 8, micbias_resistance); +static const struct soc_enum button_res = + SOC_ENUM_SINGLE(ES8326_ANA_MICBIAS, 0, 4, button_resistance); static const struct snd_kcontrol_new es8326_snd_controls[] = { SOC_SINGLE_TLV("DAC Playback Volume", ES8326_DACL_VOL, 0, 0xbf, 0, dac_vol_tlv), @@ -270,6 +299,9 @@ static const struct snd_kcontrol_new es8326_snd_controls[] = { SOC_SINGLE_TLV("SPKR Playback Volume", ES8326_SPKR_VOL, 0, 0xbf, 0, dac_vol_tlv), SOC_ENUM("HPVol SPKVol Switch", hpvol_spkvol_switch), + SOC_ENUM("Hpdet Resistance", hp_det), + SOC_ENUM("Micbias Resistance", micbias_res), + SOC_ENUM("Button Resistance", button_res), }; static const struct snd_soc_dapm_widget es8326_dapm_widgets[] = { -- 2.17.1

1 0

Add UCM2 Configs for Qualcomm sm8650 platforms
by GitHub pull_request - opened 26 Jan '24

26 Jan '24

alsa-project/alsa-ucm-conf pull request #390 was opened from superna9999: This adds the UCM2 Configs for Qualcomm SM8650 MTP & QRD platforms. Tested with PulseAudio 16.1. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/390 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/390.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

SteamOS 3.5 - Client 128: 'Munt MT-32' Misssing
by GitHub issues - edited 26 Jan '24

26 Jan '24

alsa-project/alsa-lib issue #380 was edited from kingjoma: Hi All I am a linux noob. After purchasing a SteamDeck and in an attempt to achieve outcomes from first principles I am trying to get MUNT to work with Dosbox 0.74-3 from the flathub repo (??). I successfully grabbed the DosBox flatpak from the Discover Store and successfully downloaded, compiled and installed MUNT using terminal commands. I know that there are Dosbox versions with built in MT-32 support, which I have installed (eg. Dosbox Staging) but in order to understand Linux a bit better am challenging myself to code from first principles. After running the mt32emu-qt command from the terminal and then running: `aconnect -o` I am expecting to see `client 128: 'Munt MT-32' [type=user] 0 'Standard'` The issue is the line regarding client 128 is blank. MUNT launches, I have the ROMs installed and have tested midi files through MUNT and get sound, but when trying to point `midiconfig=128:0` in the dosbox config file, it is not working. Here are the steps I took to install MUNT, there were dependencies I needed to install and initialise features on SteamOS that are normally not used in vanilla SteamOS builds: `sudo steamos-readonly disable` `sudo pacman-key --init` `sudo pacman-key --populate archlinux` `sudo pacman-key --populate holo` `sudo pacman -Syu` `sudo pacman -S qt5-multimedia` `sudo pacman -S qt6-multimedia` `git clone http://www.github.com/munt/munt` `sudo pacman -S install build-essential` `sudo pacman -S libgl` `cmake -DCMAKE_BUILD_TYPE:STRING=Release` `make` `sudo make install` `mt32emu-qt` I then added the '/usr/local/lib' path to /etc/ld.so.conf.d to ensure MUNT picked up the local library and then ran `sudo ldconfig` Please assist in trying to understand why the MUNT client is not showing up? Thanks _Originally posted by @kingjoma in https://github.com/munt/munt/issues/116_ Please can I ask you to review this issue posted on the Munt Repo to see if you can advise on how to resolve the issue. The progress on troubleshooting is indicated by the discussion on the Munt issue channel. Thanks. Issue URL : https://github.com/alsa-project/alsa-lib/issues/380 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Hi All
by GitHub issues - opened 26 Jan '24

26 Jan '24

alsa-project/alsa-lib issue #380 was opened from kingjoma: Hi All I am a linux noob. After purchasing a SteamDeck and in an attempt to achieve outcomes from first principles I am trying to get MUNT to work with Dosbox 0.74-3 from the flathub repo (??). I successfully grabbed the DosBox flatpak from the Discover Store and successfully downloaded, compiled and installed MUNT using terminal commands. I know that there are Dosbox versions with built in MT-32 support, which I have installed (eg. Dosbox Staging) but in order to understand Linux a bit better am challenging myself to code from first principles. After running the mt32emu-qt command from the terminal and then running: `aconnect -o` I am expecting to see `client 128: 'Munt MT-32' [type=user] 0 'Standard'` The issue is the line regarding client 128 is blank. MUNT launches, I have the ROMs installed and have tested midi files through MUNT and get sound, but when trying to point `midiconfig=128:0` in the dosbox config file, it is not working. Here are the steps I took to install MUNT, there were dependencies I needed to install and initialise features on SteamOS that are normally not used in vanilla SteamOS builds: `sudo steamos-readonly disable` `sudo pacman-key --init` `sudo pacman-key --populate archlinux` `sudo pacman-key --populate holo` `sudo pacman -Syu` `sudo pacman -S qt5-multimedia` `sudo pacman -S qt6-multimedia` `git clone http://www.github.com/munt/munt` `sudo pacman -S install build-essential` `sudo pacman -S libgl` `cmake -DCMAKE_BUILD_TYPE:STRING=Release` `make` `sudo make install` `mt32emu-qt` I then added the '/usr/local/lib' path to /etc/ld.so.conf.d to ensure MUNT picked up the local library and then ran `sudo ldconfig` Please assist in trying to understand why the MUNT client is not showing up? Thanks _Originally posted by @kingjoma in https://github.com/munt/munt/issues/116_ Please can I ask you to review this issue posted on the Munt Repo to see if you can advise on how to resolve the issue. The progress on troubleshooting is indicated by the discussion on the Munt issue channel. Thanks. Issue URL : https://github.com/alsa-project/alsa-lib/issues/380 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[tiwai-sound:topic/pm-ops 9/31] sound/pci/ens1370.c:1988:2: error: call to undeclared function 'snd_ak4531_suspend'; ISO C99 and later do not support implicit function declarations
by kernel test robot 26 Jan '24

26 Jan '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/pm-ops head: 623b2f6110ff118b84628595d53e4947f2883329 commit: e2a78f52bd0f02f34a84d1f4437dadf3cefdca79 [9/31] ALSA: ens137x: Replace with DEFINE_SIMPLE_DEV_PM_OPS() config: i386-randconfig-012-20240125 (https://download.01.org/0day-ci/archive/20240126/202401261439.SV1NYR8a-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401261439.SV1NYR8a-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401261439.SV1NYR8a-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/pci/ens1370.c:1988:2: error: call to undeclared function 'snd_ak4531_suspend'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 1988 | snd_ak4531_suspend(ensoniq->u.es1370.ak4531); | ^ sound/pci/ens1370.c:1988:2: note: did you mean 'snd_ak4531_mixer'? include/sound/ak4531_codec.h:62:5: note: 'snd_ak4531_mixer' declared here 62 | int snd_ak4531_mixer(struct snd_card *card, struct snd_ak4531 *_ak4531, | ^ >> sound/pci/ens1370.c:2003:2: error: call to undeclared function 'snd_ak4531_resume'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 2003 | snd_ak4531_resume(ensoniq->u.es1370.ak4531); | ^ 2 errors generated. vim +/snd_ak4531_suspend +1988 sound/pci/ens1370.c f31a31b9024f21 Kurt J. Bosch 2005-11-16 1970 68cb2b55927885 Takashi Iwai 2012-07-02 1971 static int snd_ensoniq_suspend(struct device *dev) f31a31b9024f21 Kurt J. Bosch 2005-11-16 1972 { 68cb2b55927885 Takashi Iwai 2012-07-02 1973 struct snd_card *card = dev_get_drvdata(dev); fe8be10786c040 Takashi Iwai 2005-11-17 1974 struct ensoniq *ensoniq = card->private_data; fe8be10786c040 Takashi Iwai 2005-11-17 1975 fe8be10786c040 Takashi Iwai 2005-11-17 1976 snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1977 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1978 #ifdef CHIP1371 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1979 snd_ac97_suspend(ensoniq->u.es1371.ac97); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1980 #else 15f500a6994e55 Takashi Iwai 2006-01-12 1981 /* try to reset AK4531 */ 15f500a6994e55 Takashi Iwai 2006-01-12 1982 outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x02), ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1983 inw(ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1984 udelay(100); 15f500a6994e55 Takashi Iwai 2006-01-12 1985 outw(ES_1370_CODEC_WRITE(AK4531_RESET, 0x03), ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1986 inw(ES_REG(ensoniq, 1370_CODEC)); 15f500a6994e55 Takashi Iwai 2006-01-12 1987 udelay(100); fe8be10786c040 Takashi Iwai 2005-11-17 @1988 snd_ak4531_suspend(ensoniq->u.es1370.ak4531); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1989 #endif f31a31b9024f21 Kurt J. Bosch 2005-11-16 1990 return 0; f31a31b9024f21 Kurt J. Bosch 2005-11-16 1991 } f31a31b9024f21 Kurt J. Bosch 2005-11-16 1992 68cb2b55927885 Takashi Iwai 2012-07-02 1993 static int snd_ensoniq_resume(struct device *dev) f31a31b9024f21 Kurt J. Bosch 2005-11-16 1994 { 68cb2b55927885 Takashi Iwai 2012-07-02 1995 struct snd_card *card = dev_get_drvdata(dev); fe8be10786c040 Takashi Iwai 2005-11-17 1996 struct ensoniq *ensoniq = card->private_data; f31a31b9024f21 Kurt J. Bosch 2005-11-16 1997 f31a31b9024f21 Kurt J. Bosch 2005-11-16 1998 snd_ensoniq_chip_init(ensoniq); f31a31b9024f21 Kurt J. Bosch 2005-11-16 1999 f31a31b9024f21 Kurt J. Bosch 2005-11-16 2000 #ifdef CHIP1371 f31a31b9024f21 Kurt J. Bosch 2005-11-16 2001 snd_ac97_resume(ensoniq->u.es1371.ac97); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2002 #else fe8be10786c040 Takashi Iwai 2005-11-17 @2003 snd_ak4531_resume(ensoniq->u.es1370.ak4531); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2004 #endif fe8be10786c040 Takashi Iwai 2005-11-17 2005 snd_power_change_state(card, SNDRV_CTL_POWER_D0); f31a31b9024f21 Kurt J. Bosch 2005-11-16 2006 return 0; f31a31b9024f21 Kurt J. Bosch 2005-11-16 2007 } f31a31b9024f21 Kurt J. Bosch 2005-11-16 2008 :::::: The code at line 1988 was first introduced by commit :::::: fe8be10786c040bce53c18048d75b1b23aec64ae [ALSA] ens137x - Fix and ADD PM support :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)suse.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:topic/pm-ops 7/31] sound/pci/als4000.c:947:2: error: call to undeclared function 'snd_sbmixer_suspend'; ISO C99 and later do not support implicit function declarations
by kernel test robot 25 Jan '24

25 Jan '24

Hi Takashi, FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/pm-ops head: 623b2f6110ff118b84628595d53e4947f2883329 commit: 6dae83b64fac25af472e718bf086b43a1f209674 [7/31] ALSA: als4000: Replace with DEFINE_SIMPLE_DEV_PM_OPS() config: i386-randconfig-012-20240125 (https://download.01.org/0day-ci/archive/20240126/202401260641.blzmb4QO-lkp@…) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240126/202401260641.blzmb4QO-lkp@…) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401260641.blzmb4QO-lkp@intel.com/ All errors (new ones prefixed by >>): >> sound/pci/als4000.c:947:2: error: call to undeclared function 'snd_sbmixer_suspend'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 947 | snd_sbmixer_suspend(chip); | ^ sound/pci/als4000.c:947:2: note: did you mean 'snd_sbmixer_read'? include/sound/sb.h:288:15: note: 'snd_sbmixer_read' declared here 288 | unsigned char snd_sbmixer_read(struct snd_sb *chip, unsigned char reg); | ^ >> sound/pci/als4000.c:959:2: error: call to undeclared function 'snd_sbmixer_resume'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 959 | snd_sbmixer_resume(chip); | ^ sound/pci/als4000.c:959:2: note: did you mean 'snd_sbmixer_read'? include/sound/sb.h:288:15: note: 'snd_sbmixer_read' declared here 288 | unsigned char snd_sbmixer_read(struct snd_sb *chip, unsigned char reg); | ^ 2 errors generated. vim +/snd_sbmixer_suspend +947 sound/pci/als4000.c d616a0246da88d Takashi Iwai 2022-04-12 938 68cb2b55927885 Takashi Iwai 2012-07-02 939 static int snd_als4000_suspend(struct device *dev) 703529140cfb77 Takashi Iwai 2005-11-17 940 { 68cb2b55927885 Takashi Iwai 2012-07-02 941 struct snd_card *card = dev_get_drvdata(dev); 703529140cfb77 Takashi Iwai 2005-11-17 942 struct snd_card_als4000 *acard = card->private_data; 703529140cfb77 Takashi Iwai 2005-11-17 943 struct snd_sb *chip = acard->chip; 703529140cfb77 Takashi Iwai 2005-11-17 944 703529140cfb77 Takashi Iwai 2005-11-17 945 snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); 703529140cfb77 Takashi Iwai 2005-11-17 946 703529140cfb77 Takashi Iwai 2005-11-17 @947 snd_sbmixer_suspend(chip); 703529140cfb77 Takashi Iwai 2005-11-17 948 return 0; 703529140cfb77 Takashi Iwai 2005-11-17 949 } 703529140cfb77 Takashi Iwai 2005-11-17 950 68cb2b55927885 Takashi Iwai 2012-07-02 951 static int snd_als4000_resume(struct device *dev) 703529140cfb77 Takashi Iwai 2005-11-17 952 { 68cb2b55927885 Takashi Iwai 2012-07-02 953 struct snd_card *card = dev_get_drvdata(dev); 703529140cfb77 Takashi Iwai 2005-11-17 954 struct snd_card_als4000 *acard = card->private_data; 703529140cfb77 Takashi Iwai 2005-11-17 955 struct snd_sb *chip = acard->chip; 703529140cfb77 Takashi Iwai 2005-11-17 956 703529140cfb77 Takashi Iwai 2005-11-17 957 snd_als4000_configure(chip); 703529140cfb77 Takashi Iwai 2005-11-17 958 snd_sbdsp_reset(chip); 703529140cfb77 Takashi Iwai 2005-11-17 @959 snd_sbmixer_resume(chip); 703529140cfb77 Takashi Iwai 2005-11-17 960 :::::: The code at line 947 was first introduced by commit :::::: 703529140cfb774366b839f38f027f283cb948b4 [ALSA] als4000 - Add PM support :::::: TO: Takashi Iwai <tiwai(a)suse.de> :::::: CC: Jaroslav Kysela <perex(a)suse.cz> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH] ALSA: hda/realtek: Add quirks for HP G11 Laptops using CS35L56
by Richard Fitzgerald 25 Jan '24

25 Jan '24

From: Simon Trimmer <simont(a)opensource.cirrus.com> Add quirks for two HP G11 laptops that use a Realtek HDA codec combined with four CS35L56 amplifiers using SPI. The CS35L56 driver uses the component binding interface, so uses the same setup code as the CS35L41 quirks. Signed-off-by: Simon Trimmer <simont(a)opensource.cirrus.com> Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/pci/hda/patch_realtek.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 42ee37af24bc..b2b289626323 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6819,6 +6819,11 @@ static void alc287_fixup_legion_16ithg6_speakers(struct hda_codec *cdc, const st comp_generic_fixup(cdc, action, "i2c", "CLSA0101", "-%s:00-cs35l41-hda.%d", 2); } +static void cs35l56_fixup_spi_four(struct hda_codec *cdc, const struct hda_fixup *fix, int action) +{ + comp_generic_fixup(cdc, action, "spi", "CSC3556", "-%s:00-cs35l56-hda.%d", 4); +} + static void tas2781_fixup_i2c(struct hda_codec *cdc, const struct hda_fixup *fix, int action) { @@ -7310,6 +7315,7 @@ enum { ALC2XX_FIXUP_HEADSET_MIC, ALC289_FIXUP_DELL_CS35L41_SPI_2, ALC294_FIXUP_CS35L41_I2C_2, + ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED, }; /* A special fixup for Lenovo C940 and Yoga Duet 7; @@ -9461,6 +9467,12 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = cs35l41_fixup_i2c_two, }, + [ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED] = { + .type = HDA_FIXUP_FUNC, + .v.func = cs35l56_fixup_spi_four, + .chained = true, + .chain_id = ALC285_FIXUP_HP_GPIO_LED, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -9789,6 +9801,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8c47, "HP EliteBook 840 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c48, "HP EliteBook 860 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c49, "HP Elite x360 830 2-in-1 G11", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8c52, "HP EliteBook 1040 G11", ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED), + SND_PCI_QUIRK(0x103c, 0x8c53, "HP Elite x360 1040 2-in-1 G11", ALC245_FIXUP_CS35L56_SPI_4_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c70, "HP EliteBook 835 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c71, "HP EliteBook 845 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8c72, "HP EliteBook 865 G11", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED), -- 2.30.2

2 1

[PATCH 0/1] ASoC: codecs: Adding new volume kcontrols
by Zhu Ning 25 Jan '24

25 Jan '24

Hi , a patch here for the es8326 driver... We add a new volume control.We compiled the new version patch in for-next branch. We did test with the new driver in machine. The test result met our expectations. Thanks, Michael. Zhu Ning (1): ASoC: codecs: ES8326: Adding new volume kcontrols sound/soc/codecs/es8326.c | 92 ++++++++++++++++++++++++++++++++++++++- sound/soc/codecs/es8326.h | 5 ++- 2 files changed, 95 insertions(+), 2 deletions(-) -- 2.17.1

2 2