September 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH 6.4, 6.5] ASoC: cs35l56: Disable low-power hibernation mode
by Richard Fitzgerald 28 Sep '23

28 Sep '23

commit 18789be8e0d9fbb78b2290dcf93f500726ed19f0 upstream. Please apply to 6.4 and 6.5. Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI and SoundWire. Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake. Backport note: This is the same change as upstream commit, to delete one line, but the upstream commit would not apply cleanly on older branches because of minor differences to the surrounding code. Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> Link: https://lore.kernel.org/r/20230912133841.3480466-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie(a)kernel.org> --- sound/soc/codecs/cs35l56-i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-i2c.c b/sound/soc/codecs/cs35l56-i2c.c index c613a2554fa3..494adabd4f43 100644 --- a/sound/soc/codecs/cs35l56-i2c.c +++ b/sound/soc/codecs/cs35l56-i2c.c @@ -27,7 +27,6 @@ static int cs35l56_i2c_probe(struct i2c_client *client) return -ENOMEM; cs35l56->dev = dev; - cs35l56->can_hibernate = true; i2c_set_clientdata(client, cs35l56); cs35l56->regmap = devm_regmap_init_i2c(client, regmap_config); -- 2.30.2

2 1

Gapless support
by GitHub pull_request - opened 28 Sep '23

28 Sep '23

alsa-project/tinycompress pull request #24 was opened from mohsRafi: Gapless playback support with codec profile switching Request URL : https://github.com/alsa-project/tinycompress/pull/24 Patch URL : https://github.com/alsa-project/tinycompress/pull/24.patch Repository URL: https://github.com/alsa-project/tinycompress

1 0

[PATCH] sh: boards: Fix Sound Simple-Card struct name
by Kuninori Morimoto 28 Sep '23

28 Sep '23

"asoc_simple_card_info" was renamed to "simple_util_info" by commit ad484cc98f2 ("ASoC: remove asoc_xxx() compatible macro"). This patch fixup it For SH7724 boards. Fixes: ad484cc98f2 ("ASoC: remove asoc_xxx() compatible macro") Reported-by: kernel test robot <lkp(a)intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202309280417.rOLRdrdM-lkp@intel.com/ Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- Mark, John This patch is for latest asoc for-next branch arch/sh/boards/mach-ecovec24/setup.c | 2 +- arch/sh/boards/mach-se/7724/setup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c index 3be293335de5..0f279360838a 100644 --- a/arch/sh/boards/mach-ecovec24/setup.c +++ b/arch/sh/boards/mach-ecovec24/setup.c @@ -881,7 +881,7 @@ static struct platform_device fsi_device = { .resource = fsi_resources, }; -static struct asoc_simple_card_info fsi_da7210_info = { +static struct simple_util_info fsi_da7210_info = { .name = "DA7210", .card = "FSIB-DA7210", .codec = "da7210.0-001a", diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c index 6495f9354065..787ddd3c627a 100644 --- a/arch/sh/boards/mach-se/7724/setup.c +++ b/arch/sh/boards/mach-se/7724/setup.c @@ -300,7 +300,7 @@ static struct platform_device fsi_device = { .resource = fsi_resources, }; -static struct asoc_simple_card_info fsi_ak4642_info = { +static struct simple_util_info fsi_ak4642_info = { .name = "AK4642", .card = "FSIA-AK4642", .codec = "ak4642-codec.0-0012", -- 2.25.1

2 1

[PATCH] ASoC: SOF: amd: fix for firmware reload failure after playback
by Vijendar Mukunda 28 Sep '23

28 Sep '23

Setting ACP ACLK as clock source when ACP enters D0 state causing firmware load failure as mentioned in below scenario. - Load snd_sof_amd_rembrandt - Play or Record audio - Stop audio - Unload snd_sof_amd_rembrandt - Reload snd_sof_amd_rembrandt If acp_clkmux_sel register field is set, then clock source will be set to ACP ACLK when ACP enters D0 state. During stream stop, if there is no active stream is running then acp firmware will set the ACP ACLK value to zero. When driver is reloaded and clock source is selected as ACP ACLK, as ACP ACLK is programmed to zero, firmware loading will fail. For RMB platform, remove the clock mux selection field so that ACP will use internal clock source when ACP enters D0 state. Fixes: 41cb85bc4b52 ("ASoC: SOF: amd: Add support for Rembrandt plaform.") Reported-by: coolstar <coolstarorganization(a)gmail.com> Closes: https://github.com/thesofproject/sof/issues/8137 Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda(a)amd.com> --- sound/soc/sof/amd/pci-rmb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/sof/amd/pci-rmb.c b/sound/soc/sof/amd/pci-rmb.c index 72e211b5f7a4..2f288545c426 100644 --- a/sound/soc/sof/amd/pci-rmb.c +++ b/sound/soc/sof/amd/pci-rmb.c @@ -35,7 +35,6 @@ static const struct sof_amd_acp_desc rembrandt_chip_info = { .dsp_intr_base = ACP6X_DSP_SW_INTR_BASE, .sram_pte_offset = ACP6X_SRAM_PTE_OFFSET, .hw_semaphore_offset = ACP6X_AXI2DAGB_SEM_0, - .acp_clkmux_sel = ACP6X_CLKMUX_SEL, .fusion_dsp_offset = ACP6X_DSP_FUSION_RUNSTALL, .probe_reg_offset = ACP6X_FUTURE_REG_ACLK_0, }; -- 2.34.1

2 1

[PATCH V5 0/8] ASoC: codecs: Add aw87390 amplifier driver
by wangweidong.a＠awinic.com 28 Sep '23

28 Sep '23

From: Weidong Wang <wangweidong.a(a)awinic.com> The awinic aw87390 is a new high efficiency, low noise, constant large volume, 6th Smart K audio amplifier. Add a DT schema for describing awinic aw87390 audio amplifiers. They are controlled using I2C. v4 -> v5: Adjust the order and context of the patch Weidong Wang (8): ASoC: dt-bindings: awinic,aw88395: Add properties for multiple PA support ASoC: dt-bindings: Add schema for "awinic,aw87390" ASoC: codecs: Modify the code related to the property ASoC: codecs: Modify the transmission method of parameters ASoC: codecs: Add code for bin parsing compatible with aw87390 ASoC: codecs: Modify the code related to the property ASoC: codecs: Modify the transmission mode of function parameters ASoC: codecs: Add aw87390 amplifier driver .../bindings/sound/awinic,aw87390.yaml | 58 +++ .../bindings/sound/awinic,aw88395.yaml | 16 + sound/soc/codecs/Kconfig | 15 +- sound/soc/codecs/Makefile | 2 + sound/soc/codecs/aw87390.c | 462 ++++++++++++++++++ sound/soc/codecs/aw87390.h | 85 ++++ sound/soc/codecs/aw88261.c | 27 +- sound/soc/codecs/aw88261.h | 4 +- sound/soc/codecs/aw88395/aw88395.c | 9 +- sound/soc/codecs/aw88395/aw88395.h | 2 +- sound/soc/codecs/aw88395/aw88395_device.c | 47 +- sound/soc/codecs/aw88395/aw88395_device.h | 6 +- sound/soc/codecs/aw88395/aw88395_lib.c | 25 +- sound/soc/codecs/aw88395/aw88395_reg.h | 1 + 14 files changed, 685 insertions(+), 74 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw87390.yaml create mode 100644 sound/soc/codecs/aw87390.c create mode 100644 sound/soc/codecs/aw87390.h base-commit: 0e945134b680040b8613e962f586d91b6d40292d -- 2.41.0

3 14

[PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
by cy_huang＠richtek.com 28 Sep '23

28 Sep '23

From: ChiYuan Huang <cy_huang(a)richtek.com> Since rtq9128 can support 4 channel I2S mode audio data, there are two dedicated data input pins for CH12 and CH34. But in TDM mode, input source was already drived on one data pin for multiple data slots. In this case, only one input source is needed for TDM mode. This patch is to add the data source pin selection for CH12 and CH34. Signed-off-by: ChiYuan Huang <cy_huang(a)richtek.com> --- sound/soc/codecs/rtq9128.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/rtq9128.c b/sound/soc/codecs/rtq9128.c index 926b79ed8078..3cf613c6900e 100644 --- a/sound/soc/codecs/rtq9128.c +++ b/sound/soc/codecs/rtq9128.c @@ -225,6 +225,7 @@ static const char * const phase_select_text[] = { "180 degree", "225 degree", "270 degree", "315 degree", }; static const char * const dvdduv_select_text[] = { "1P4V", "1P5V", "2P1V", "2P3V" }; +static const char * const tdm_data_select_text[] = { "DATA1", "DATA2" }; static const struct soc_enum rtq9128_ch1_si_enum = SOC_ENUM_SINGLE(RTQ9128_REG_SDI_SEL, 6, ARRAY_SIZE(source_select_text), source_select_text); @@ -246,6 +247,12 @@ static const struct soc_enum rtq9128_out3_phase_enum = static const struct soc_enum rtq9128_out4_phase_enum = SOC_ENUM_SINGLE(RTQ9128_REG_PLLTRI_GEN2, 0, ARRAY_SIZE(phase_select_text), phase_select_text); +static const struct soc_enum rtq9128_ch12_tdm_data_select_enum = + SOC_ENUM_SINGLE(RTQ9128_REG_SDO_SEL, 5, ARRAY_SIZE(tdm_data_select_text), + tdm_data_select_text); +static const struct soc_enum rtq9128_ch34_tdm_data_select_enum = + SOC_ENUM_SINGLE(RTQ9128_REG_SDO_SEL, 4, ARRAY_SIZE(tdm_data_select_text), + tdm_data_select_text); /* * In general usage, DVDD could be 1P8V, 3P0V or 3P3V. @@ -277,6 +284,8 @@ static const struct snd_kcontrol_new rtq9128_snd_ctrls[] = { SOC_ENUM("OUT3 Phase Select", rtq9128_out3_phase_enum), SOC_ENUM("OUT4 Phase Select", rtq9128_out4_phase_enum), SOC_ENUM("DVDD UV Threshold Select", rtq9128_dvdduv_select_enum), + SOC_ENUM("CH12 TDM Data Select", rtq9128_ch12_tdm_data_select_enum), + SOC_ENUM("CH34 TDM Data Select", rtq9128_ch34_tdm_data_select_enum), }; static int rtq9128_dac_power_event(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, base-commit: c351835058419c1eb8791941a057c3f3e6068cb6 -- 2.34.1

3 6

[PATCH v3] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
by Sven Frotscher 28 Sep '23

28 Sep '23

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f414d ("ASoC: amd: yc: Fix non-functional mic on Lenovo 82QF and 82UG"). Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ") Cc: stable(a)vger.kernel.org Signed-off-by: Sven Frotscher <sven.frotscher(a)gmail.com> --- v2->v3 changes: * add message title of referenced commit to commit message * make whitespace consistent with surrounding code * use a patch-friendly e-mail client --- v1->v2 changes: * add Fixes and Cc tags to commit message * remove redundant LKML link from commit message * fix mangled diff --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 94e9eb8e73f2..15a864dcd7bd 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -241,6 +241,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "82V2"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "82YM"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.42.0

1 0

[PATCH v2] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
by Sven Frotscher 27 Sep '23

27 Sep '23

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f414d. Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ") Cc: stable(a)vger.kernel.org Signed-off-by: Sven Frotscher <sven.frotscher(a)gmail.com> --- v1->v2 changes: * add Fixes and Cc tags to commit message * remove redundant LKML link from commit message * fix mangled diff sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 3d8a51351e29..e3d2b9d01552 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -241,6 +241,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "82V2"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "82YM"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.42.0

2 1

Bug Report: Audio issues with CentOS7
by Terry Hummel 27 Sep '23

27 Sep '23

Hello. I hope I reached the right place for my audio issue. The OS that I'm referencing is CentOS7. It is close to EOL so I don't know if there is any support at this point, but thought I put the request out there and see what happens. Let me know if I need to provide any additional infomration. Thanks. Terry Hummel Catalina Marketing Corporation 813-597-8775 Description of problem: The PC speaker fails to make a sound on the HP RP 5810 PC running CentOS7. Research: I Installed the beep package beep-1.4.12-7.el7.x86_64.rpm on CentOS7 and it is working fine on the HP RP 5800 PC. I have a bank of five 5800 PCs and all of them make a beep sound on the PC speaker. I then installed the CentOS7 image on a bank of HP RP 5810 PCs and I failed to get any of the systems speakers to make a sound. I verified the speaker is enabled in BIOS and I have confirmed the 5810 speaker works fine when Windows is installed on the system. How to reproduce: Try to get sound to come from the HP RP 5810 speaker using: printf '\a' printf '\007' echo -e '\a' echo -e '\007' beep -f330 -l137 -n -f330 -l275 -n -f330 -l137 -n…etc (I have a beep tune in a shell script) // when beep is run, it appears to run with no errors. Actual results: The above commands run without any complaints of missing audio device. But no sound coming from the 5810 PC internal Speakers Note: The 5810 PCs are basically just stand-alone systems that run our proprietary software 24/7. 5810 System Information: Version: CentOS Linux release 7.9.2009 (Core) hardware: x86_64 Kernel: 3.10.0-1160.90.1.el7.x86_64 Name : kernel Arch : x86_64 Version : 3.10.0 Release : 1160.90.1.el7 Size : 66 M Repo : installed From repo : storepc_centos7_x86_64 Summary : The Linux kernel URL : http://www.kernel.org/ License : GPLv2 5810 PC Information: Manufacturer: Hewlett-Packard Product Name: HP RP5 Retail System Model 5810 Version: Not Specified Artifacts: The attached .zip file contains complete artifact files. Note: I did try to run alsa-info_alsa-info.sh but the CentOS7 image that we use has multiple missing dependencies for it to run. dmesg_HP-5810.log - the log does not show any errors, warnings or oops messages. The audio driver appears to load without issue: [ 8.386508] input: PC Speaker as /devices/platform/pcspkr/input/input3 [ 8.540596] input: HP WMI hotkeys as /devices/virtual/input/input4 [ 8.559224] cryptd: max_cpu_qlen set to 1000 [ 8.957472] AVX2 version of gcm_enc/dec engaged. [ 8.957475] AES CTR mode by8 optimization enabled [ 8.961877] alg: No test for __gcm-aes-aesni (__driver-gcm-aes-aesni) [ 8.961906] alg: No test for __generic-gcm-aes-aesni (__driver-generic-gcm-aes-aesni) [ 8.963261] snd_hda_intel 0000:00:03.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) [ 8.963290] snd_hda_intel 0000:00:03.0: irq 34 for MSI/MSI-X [ 8.963381] snd_hda_intel 0000:00:1b.0: irq 35 for MSI/MSI-X [ 8.980785] input: HDA Intel HDMI HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:03.0/sound/card0/input5 [ 8.980857] input: HDA Intel HDMI HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:03.0/sound/card0/input6 [ 8.980922] input: HDA Intel HDMI HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:03.0/sound/card0/input7 [ 8.980977] input: HDA Intel HDMI HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:03.0/sound/card0/input8 [ 8.991101] snd_hda_codec_realtek hdaudioC1D0: autoconfig for ALC221: line_outs=1 (0x17/0x0/0x0/0x0/0x0) type:speaker [ 8.991105] snd_hda_codec_realtek hdaudioC1D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 8.991107] snd_hda_codec_realtek hdaudioC1D0: hp_outs=1 (0x21/0x0/0x0/0x0/0x0) [ 8.991108] snd_hda_codec_realtek hdaudioC1D0: mono: mono_out=0x0 [ 8.991109] snd_hda_codec_realtek hdaudioC1D0: inputs: [ 8.991111] snd_hda_codec_realtek hdaudioC1D0: Line=0x1b lspci_HP-5810.log - looks like there are two audio devices on the HP5810: 00:03.0 Audio device: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor HD Audio Controller (rev 06) 00:1b.0 Audio device: Intel Corporation 8 Series/C220 Series Chipset High Definition Audio Controller (rev 04) [TerryH@us-09-048-0331 ~]$ cat /proc/asound/cards 0 [HDMI ]: HDA-Intel - HDA Intel HDMI HDA Intel HDMI at 0xf7e34000 irq 34 1 [PCH ]: HDA-Intel - HDA Intel PCH HDA Intel PCH at 0xf7e30000 irq 35 Note: There is no HDMI monitor hooked up to any of the HP 5810 systems. lsmod_HP-5810.log snd_hda_codec_realtek 116449 1 ghash_clmulni_intel 13273 0 snd_hda_codec_hdmi 52340 1 snd_hda_codec_generic 74631 1 snd_hda_codec_realtek snd_hda_intel 44486 0 aesni_intel 189456 0 snd_hda_codec 136355 4 snd_hda_codec_realtek,snd_hda_codec_hdmi,snd_hda_codec_generic,snd_hda_intel snd_hda_core 91007 5 snd_hda_codec_realtek,snd_hda_codec_hdmi,snd_hda_codec_generic,snd_hda_codec,snd_hda_intel snd_hwdep 17704 1 snd_hda_codec snd_seq 62774 0 lshw_HP-5810.log: [TerryH@us-09-048-0331 ~]$ sudo lshw | grep -A11 multimedia *-multimedia:0 description: Audio device product: Xeon E3-1200 v3/4th Gen Core Processor HD Audio Controller vendor: Intel Corporation physical id:3 bus info: pci@0000:00:03.0 version: 06 width: 64 bits clock: 33MHz capabilities: pm msi pciexpress bus_master cap_list configuration: driver=snd_hda_intel latency=0 resources: irq:34 memory:f7e34000-f7e37fff -- *-multimedia:1 description: Audio device product: 8 Series/C220 Series Chipset High Definition Audio Controller vendor: Intel Corporation physical id: 1b bus info: pci@0000:00:1b.0 version: 04 width: 64 bits clock: 33MHz capabilities: pm msi pciexpress bus_master cap_list configuration: driver=snd_hda_intel latency=0 resources: irq:35 memory:f7e30000-f7e33fff Note: The HP 5800 is only showing one audio controller: 00:1b.0 Audio device: Intel Corporation 6 Series/C200 Series Chipset Family High Definition Audio Controller (rev 04)

2 6

[PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
by Sven Frotscher 27 Sep '23

27 Sep '23

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f, see https://lore.kernel.org/r/20230911213409.6106-1-git@augustwikerfors.se. Signed-off-by: Sven Frotscher <sven.frotscher(a)gmail.com> --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 3d8a51351e29..e3d2b9d01552 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -241,6 +241,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { >..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82V2"), >..>...} >..}, +>..{ +>..>....driver_data = &acp6x_card, +>..>....matches = { +>..>...>...DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), +>..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82YM"), +>..>...} +>..}, >..{ >..>....driver_data = &acp6x_card, >..>....matches = { -- 2.42.0

2 3