September 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v2] ASoC: hdmi-codec: Fix broken channel map reporting
by Matthias Reichl 02 Oct '23

02 Oct '23

Commit 4e0871333661 ("ASoC: hdmi-codec: fix channel info for compressed formats") accidentally changed hcp->chmap_idx from ca_id, the CEA channel allocation ID, to idx, the index to the table of channel mappings ordered by preference. This resulted in wrong channel maps being reported to userspace, eg for 5.1 "FL,FR,LFE,FC" was reported instead of the expected "FL,FR,LFE,FC,RL,RR": ~ # speaker-test -c 6 -t sine ... 0 - Front Left 3 - Front Center 1 - Front Right 2 - LFE 4 - Unknown 5 - Unknown ~ # amixer cget iface=PCM,name='Playback Channel Map' | grep ': values' : values=3,4,8,7,0,0,0,0 Switch this back to ca_id in case of PCM audio so the correct channel map is reported again and set it to HDMI_CODEC_CHMAP_IDX_UNKNOWN in case of non-PCM audio so the PCM channel map control returns "Unknown" channels (value 0). Fixes: 4e0871333661 ("ASoC: hdmi-codec: fix channel info for compressed formats") Cc: stable(a)vger.kernel.org Signed-off-by: Matthias Reichl <hias(a)horus.com> --- Changes in v2: - Report unknown channel in case of non-pcm audio sound/soc/codecs/hdmi-codec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index 13689e718d36f..09eef6042aad6 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -531,7 +531,10 @@ static int hdmi_codec_fill_codec_params(struct snd_soc_dai *dai, hp->sample_rate = sample_rate; hp->channels = channels; - hcp->chmap_idx = idx; + if (pcm_audio) + hcp->chmap_idx = ca_id; + else + hcp->chmap_idx = HDMI_CODEC_CHMAP_IDX_UNKNOWN; return 0; } -- 2.39.2

2 1

[PATCH] ASoC: rt5682: Fix regulator enable/disable sequence
by Zhang Shurong 02 Oct '23

02 Oct '23

This will attempt to disable the regulators if the initial enable fails which is a bug. Fix this bug by modifying the code to the correct sequence. Signed-off-by: Zhang Shurong <zhang_shurong(a)foxmail.com> --- sound/soc/codecs/rt5682-i2c.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c index b05b4f73d8aa..fbad1ed06626 100644 --- a/sound/soc/codecs/rt5682-i2c.c +++ b/sound/soc/codecs/rt5682-i2c.c @@ -157,11 +157,6 @@ static int rt5682_i2c_probe(struct i2c_client *i2c) return ret; } - ret = devm_add_action_or_reset(&i2c->dev, rt5682_i2c_disable_regulators, - rt5682); - if (ret) - return ret; - ret = regulator_bulk_enable(ARRAY_SIZE(rt5682->supplies), rt5682->supplies); if (ret) { @@ -169,6 +164,11 @@ static int rt5682_i2c_probe(struct i2c_client *i2c) return ret; } + ret = devm_add_action_or_reset(&i2c->dev, rt5682_i2c_disable_regulators, + rt5682); + if (ret) + return ret; + ret = rt5682_get_ldo1(rt5682, &i2c->dev); if (ret) return ret; -- 2.30.2

1 0

[PATCH v4] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM
by Sven Frotscher 02 Oct '23

02 Oct '23

Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8) requires an entry in the quirk list to enable the internal microphone. The latter two received similar fixes in commit 1263cc0f414d ("ASoC: amd: yc: Fix non-functional mic on Lenovo 82QF and 82UG"). Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ") Cc: stable(a)vger.kernel.org Signed-off-by: Sven Frotscher <sven.frotscher(a)gmail.com> --- v3->v4 changes: * re-add blank line between commit message title and body --- v2->v3 changes: * add message title of referenced commit to commit message * make whitespace consistent with surrounding code * use a patch-friendly e-mail client --- v1->v2 changes: * add Fixes and Cc tags to commit message * remove redundant LKML link from commit message * fix mangled diff --- sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 94e9eb8e73f2..15a864dcd7bd 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -241,6 +241,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "82V2"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "82YM"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.42.0

4 14

[PATCH] ASoC: fsl-asoc-card: dummy codec compatibility integration for use with S/PDIF controller
by elinor.montmasson＠savoirfairelinux.com 02 Oct '23

02 Oct '23

Hello, Following some work to reduce the impact of audio resampling in Linux, we would like to use the ASRC of the i.MX8 SoCs with the S/PDIF controller. With that aim, this series of patch for the machine driver fsl-asoc-card proposes to add compatibility with the dummy codec driver. This is a first step in using the S/PDIF controller with the ASRC, as the imx-spdif machine driver uses the dummy codec with the fsl_spdif DAI driver. The five first patches add compatibility with the dummy codec through a new compatible, fsl,imx-audio-dummy-codec. Codec parameters are set with default values. The remaining patches add configuration options through device tree for the codec parameters that can also impact the CPU DAI. These are usually hard-coded in fsl-asoc-card for each audio codec. Because this dummy codec could be use with other CPU DAI than the S/PDIF controller, these could need specific configuration. This series of patch was successfully built for arm64 and x86 on top of the latest for-next branch of the ASoC git tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/ on the 28/08. These modifications have also been tested on an i.MX8MN evaluation board, with a linux kernel RT v6.1.26-rt8. Regards, Elinor Montmasson

3 12

Re: Ryzen 9 7950x sound module does not not build
by Bagas Sanjaya 02 Oct '23

02 Oct '23

[also Cc'ing alsa ML and related maintainers] On Tue, Sep 26, 2023 at 01:23:13PM +0100, Sid Boyce wrote: > I've since rebooted and did a modprobe. No idea why it isn't automatically > loaded. > > #modinfo snd-rpl-pci-acp6x > filename: /usr/lib/modules/6.6.0-rc3-vanilla/kernel/sound/soc/amd/rpl/snd-rpl-pci-acp6x.ko.gz > license: GPL v2 > description: AMD ACP RPL PCI driver > srcversion: 0F909BC61165681426ECEEB > alias: pci:v00001022d000015E2sv*sd*bc04sc80i00* > depends: > retpoline: Y > intree: Y > name: snd_rpl_pci_acp6x > vermagic: 6.6.0-rc3-vanilla SMP preempt mod_unload modversions > > # modprobe snd-rpl-pci-acp6x > > #lsmod|grep snd > snd_rpl_pci_acp6x 16384 0 > snd_seq_dummy 12288 0 > snd_hrtimer 12288 1 > snd_seq 131072 7 snd_seq_dummy > snd_hda_codec_realtek 192512 1 > snd_hda_codec_hdmi 94208 1 > snd_hda_codec_generic 110592 1 snd_hda_codec_realtek > snd_hda_intel 65536 2 > snd_usb_audio 458752 2 > snd_intel_dspcfg 40960 1 snd_hda_intel > snd_intel_sdw_acpi 16384 1 snd_intel_dspcfg > snd_hda_codec 233472 4 > snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec_realtek > > snd_usbmidi_lib 49152 1 snd_usb_audio > snd_hda_core 147456 5 snd_hda_codec_generic,snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec,snd_hda_codec_realtek > > snd_ump 36864 1 snd_usb_audio > snd_rawmidi 57344 2 snd_usbmidi_lib,snd_ump > snd_seq_device 16384 3 snd_seq,snd_ump,snd_rawmidi > mc 94208 1 snd_usb_audio > snd_hwdep 20480 2 snd_usb_audio,snd_hda_codec > snd_pcm 225280 6 > snd_hda_codec_hdmi,snd_hda_intel,snd_usb_audio,snd_hda_codec,snd_hda_core > snd_timer 53248 3 snd_seq,snd_hrtimer,snd_pcm > ledtrig_audio 12288 2 snd_hda_codec_generic,asus_wmi > snd 163840 23 snd_hda_codec_generic,snd_seq,snd_seq_device,snd_hda_codec_hdmi,snd_hwdep,snd_hda_intel,snd_usb_audio,snd_usbmidi_lib,snd_hda_codec,snd_hda_codec_realtek,snd_timer,snd_ump,snd_pcm,snd_rawmidi > > soundcore 16384 1 snd > usbcore 446464 6 > xhci_hcd,snd_usb_audio,usbhid,snd_usbmidi_lib,btusb,xhci_pci > Any errors on dmesg when loading snd-rpl-pci-acp6x module? -- An old man doll... just what I always wanted! - Clara

4 10

[v3 0/2] ASoC: mediatek: mt8188-mt6359: add rt5682s support
by xiazhengqiao 02 Oct '23

02 Oct '23

To use RT5682S as the codec and MAX98390 as the amp, add a new sound card named mt8188_rt5682s. Changes in v3: - PATCH 2/2: modify mt8186_rt5682s_i2s_hw_params to mt8188_rt5682s_i2s_hw_params - Link to v2: https://lore.kernel.org/all/20230926040901.20338-3-xiazhengqiao@huaqin.corp… https://lore.kernel.org/all/20230926040901.20338-2-xiazhengqiao@huaqin.corp… Changes in v2: - PATCH 1/2: Modify mt8188_rt5682 to mt8188_rt5682s - PATCH 2/2: Modify all string "rt5682" to "rt5682s" and merge code in mt8188_fixup_controls - Link to v1: https://lore.kernel.org/all/20230925083847.1496-3-xiazhengqiao@huaqin.corp-… https://lore.kernel.org/all/20230925083847.1496-2-xiazhengqiao@huaqin.corp-… xiazhengqiao (2): ASoC: dt-bindings: mediatek,mt8188-mt6359: add RT5682S support ASoC: mediatek: mt8188-mt6359: add rt5682s support .../sound/mediatek,mt8188-mt6359.yaml | 1 + sound/soc/mediatek/Kconfig | 1 + sound/soc/mediatek/mt8188/mt8188-mt6359.c | 141 +++++++++++++++++- 3 files changed, 141 insertions(+), 2 deletions(-) -- 2.17.1

2 3

[PATCH 1/2] ASoC: core: Print component name when printing log
by Amadeusz Sławiński 01 Oct '23

01 Oct '23

When printing log related to component it is useful to know, to which component it applies to. Reviewed-by: Cezary Rojewski <cezary.rojewski(a)intel.com> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski(a)linux.intel.com> --- sound/soc/soc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index c305e94762c3..2b8d522eb106 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1445,8 +1445,8 @@ static int soc_probe_component(struct snd_soc_card *card, if (component->card) { if (component->card != card) { dev_err(component->dev, - "Trying to bind component to card \"%s\" but is already bound to card \"%s\"\n", - card->name, component->card->name); + "Trying to bind component \"%s\" to card \"%s\" but is already bound to card \"%s\"\n", + component->name, card->name, component->card->name); return -ENODEV; } return 0; -- 2.34.1

2 2

[PATCH v1 1/1] device property: Replace custom implementation of COUNT_ARGS()
by Andy Shevchenko 30 Sep '23

30 Sep '23

Replace custom and non-portable implementation of COUNT_ARGS(). Fixes: e64b674bc9d7 ("software node: implement reference properties") Reported-by: Nick Desaulniers <ndesaulniers(a)google.com> Closes: https://lore.kernel.org/r/ZQoILN6QCjzosCOs@google.com Signed-off-by: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com> --- include/linux/property.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/property.h b/include/linux/property.h index 1684fca930f7..55c2692ffa8c 100644 --- a/include/linux/property.h +++ b/include/linux/property.h @@ -10,6 +10,7 @@ #ifndef _LINUX_PROPERTY_H_ #define _LINUX_PROPERTY_H_ +#include <linux/args.h> #include <linux/bits.h> #include <linux/fwnode.h> #include <linux/stddef.h> @@ -314,7 +315,7 @@ struct software_node_ref_args { #define SOFTWARE_NODE_REFERENCE(_ref_, ...) \ (const struct software_node_ref_args) { \ .node = _ref_, \ - .nargs = ARRAY_SIZE(((u64[]){ 0, ##__VA_ARGS__ })) - 1, \ + .nargs = COUNT_ARGS(__VA_ARGS__), \ .args = { __VA_ARGS__ }, \ } -- 2.40.0.1.gaa8946217a0b

4 5

[PATCH] ALSA: hda: cirrus_scodec: fix an error code
by Dan Carpenter 30 Sep '23

30 Sep '23

The "ret" variable is zero but we should return -EINVAL. Fixes: 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test") Signed-off-by: Dan Carpenter <dan.carpenter(a)linaro.org> --- sound/pci/hda/cirrus_scodec_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/cirrus_scodec_test.c b/sound/pci/hda/cirrus_scodec_test.c index 5eb590cd4fe2..8ae373676bd1 100644 --- a/sound/pci/hda/cirrus_scodec_test.c +++ b/sound/pci/hda/cirrus_scodec_test.c @@ -137,8 +137,8 @@ static int cirrus_scodec_test_create_gpio(struct kunit *test) priv->gpio_priv = dev_get_drvdata(&priv->gpio_pdev->dev); if (!priv->gpio_priv) { platform_device_put(priv->gpio_pdev); - KUNIT_FAIL(test, "Failed to get gpio private data: %d\n", ret); - return ret; + KUNIT_FAIL(test, "Failed to get gpio private data\n"); + return -EINVAL; } return 0; -- 2.39.2

1 0

[GIT PULL] ASoC fixes for v6.6-rc4
by Mark Brown 30 Sep '23

30 Sep '23

The following changes since commit 31bb7bd9ffee50d09ec931998b823a86132ab807: ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful (2023-09-15 17:14:22 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v6.6-rc4 for you to fetch changes up to 7e1fe5d9e7eae67e218f878195d1d348d01f9af7: ASoC: SOF: amd: fix for firmware reload failure after playback (2023-09-27 11:08:05 +0200) ---------------------------------------------------------------- ASoC: Fixes for v6.6 There's quite a lot of changes here, but a lot of them are simple quirks or device IDs rather than actual fixes. The fixes that are here are all quite device specific and relatively minor. ---------------------------------------------------------------- Alex Bee (1): dt-bindings: ASoC: rockchip: Add compatible for RK3128 spdif Balamurugan C (2): ASoC: Intel: soc-acpi: Add entry for sof_es8336 in MTL match table. ASoC: Intel: soc-acpi: Add entry for HDMI_In capture support in MTL match table Kuninori Morimoto (2): ASoC: simple-card-utils: fixup simple_util_startup() error handling ASoC: simple-card: fixup asoc_simple_probe() error handling Mark Brown (1): ASoC: Intel: soc-acpi: Adding Es83x6 codec entry and Miquel Raynal (1): ASoC: soc-generic-dmaengine-pcm: Fix function name in comment Pierre-Louis Bossart (2): ASoC: Intel: soc-acpi: fix Dell SKU 0B34 ASoC: Intel: sof_sdw: add support for SKU 0B14 Shengjiu Wang (2): ASoC: fsl_sai: Don't disable bitclock for i.MX8MP ASoC: fsl-asoc-card: use integer type for fll_id and pll_id Vijendar Mukunda (1): ASoC: SOF: amd: fix for firmware reload failure after playback .../devicetree/bindings/sound/rockchip-spdif.yaml | 1 + sound/soc/fsl/fsl-asoc-card.c | 12 +++++++---- sound/soc/fsl/fsl_sai.c | 9 ++++++-- sound/soc/generic/simple-card-utils.c | 3 ++- sound/soc/generic/simple-card.c | 6 ++++-- sound/soc/intel/boards/sof_es8336.c | 10 +++++++++ sound/soc/intel/boards/sof_sdw.c | 10 +++++++++ sound/soc/intel/common/soc-acpi-intel-adl-match.c | 12 +++++------ sound/soc/intel/common/soc-acpi-intel-mtl-match.c | 25 ++++++++++++++++++++++ sound/soc/soc-generic-dmaengine-pcm.c | 4 ++-- sound/soc/sof/amd/pci-rmb.c | 1 - 11 files changed, 75 insertions(+), 18 deletions(-)

2 1