May 2023 - Alsa-devel - mailman.alsa-project.org

Failed to import use case configuration
by GitHub issues - opened 26 May '23

26 May '23

alsa-project/alsa-utils issue #217 was opened from jesusjimsa: Hello, I have stored the configuration for my sound card in an asound.state file and `alsactl` is reading it fine, but during boot and whenever I try running the command manually, this message appears in the log: ``` alsa-lib ../../../git/src/ucm/main.c:1412:(snd_use_case_mgr_open) error: failed to import hw:0 use case configuration -2 ``` I don't understand what is going wrong and I haven't found much online. Any ideas for how I could fix this error or what might be the origin of it? This is what I get if I run `aplay -l`: ``` ~# aplay -l **** List of PLAYBACK Hardware Devices **** card 0: mycard [mycard], device 0: 44004000.audio-controller-tlv320aic31xx-hifi tlv320aic31xx-hifi [44004000.audio-controller-tlv320aic31xx-hifi tlv320aic31xx-hifi] Subdevices: 1/1 Subdevice #0: subdevice #0 ``` Thank you. Issue URL : https://github.com/alsa-project/alsa-utils/issues/217 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v6 0/8] Add SC7280 audioreach device tree nodes
by Mohammad Rafi Shaik 26 May '23

26 May '23

Add SC7280 audioreach device tree nodes and extract audio specific dtsi nodes and add them in new file. This patch series depends on: -- https://patchwork.kernel.org/project/linux-clk/list/?series=717985 Corresponding dt-bindings not mainlined yet. -- https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/commit… Changes Since v5: -- Re-arrange the patch list, driver changes should come after binding. -- Remove incorrect dai cells property in "Add sound node for crd-rev3 board" patch. -- Remove newlines in "Add LPASS PIL node" patch. -- Update the commit message in "Update VA/RX/TX macro clock nodes" patch. -- Update the commit message in "Update lpass_tlmm node" patch. Changes Since v4: -- Modify lpasscc clock controller node name. -- Disable lpass_core node. -- Modify Model name in sound node in "Add sound node for crd-rev3 board" patch. -- Remove protection domain property in "Add LPASS PIL node". Changes Since v3: -- Remove deleting digital codecs in crd-rev3 board specific dtsi and upadate them using phandle. -- Update commit message in "Update lpass_tlmm node" patch. -- Change the position of status property in LPASS PIL node. -- Update commit message in "Add sound node" patch. Changes Since v2: -- Remove Patch related to Add CGCR reset property. -- Remove Patch related to Disable legacy path clock nodes. -- Add dt-bindings for missing properties. -- Change the order of nodes. -- Move digictal codec macro nodes to root node from soc node. -- Add adsp-pil-mode property in required clock nodes. Changes Since v1: -- Move remoteproc node to soc dtsi file. -- Add qcom, adsp-pil-mode reg property in lpasscc node. -- Fix typo errors. -- Remove redundant status properties. Srinivasa Rao Mandadapu (8): arm64: dts: qcom: sc7280: Modify lpasscc node name dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add missing properties arm64: dts: qcom: sc7280: Extract audio nodes from common idp dtsi file arm64: dts: qcom: sc7280: Add sound node for crd-rev3 board arm64: dts: qcom: sc7280: Add LPASS PIL node arm64: dts: qcom: sc7280: Modify VA/RX/TX macro clock nodes for audioreach solution arm64: dts: qcom: sc7280: Modify LPASS_MCC reg region size in the lpass_tlmm node arm64: dts: qcom: sc7280: Add qcom,adsp-pil-mode property in clock nodes .../remoteproc/qcom,sc7280-adsp-pil.yaml | 30 ++- .../arm64/boot/dts/qcom/sc7280-audio-idp.dtsi | 131 +++++++++ arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 1 + .../sc7280-herobrine-audioreach-wcd9385.dtsi | 253 ++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 122 --------- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 +- 6 files changed, 413 insertions(+), 128 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi -- 2.25.1

1 8

[tiwai-sound:topic/midi20 25/40] sound/core/seq/seq_clientmgr.c:482 snd_seq_read() error: copy_to_user() '&cell->event' too small (28 vs 32)
by Dan Carpenter 26 May '23

26 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: 46397622a3fa8372b8fda0f04b33d16923b03b1b [25/40] ALSA: seq: Add UMP support config: i386-randconfig-m021-20230525 (https://download.01.org/0day-ci/archive/20230526/202305261415.NY0vapZK-lkp@…) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Reported-by: Dan Carpenter <error27(a)gmail.com> | Closes: https://lore.kernel.org/r/202305261415.NY0vapZK-lkp@intel.com/ smatch warnings: sound/core/seq/seq_clientmgr.c:482 snd_seq_read() error: copy_to_user() '&cell->event' too small (28 vs 32) vim +482 sound/core/seq/seq_clientmgr.c c7e0b5bf9fff1b Takashi Iwai 2005-11-17 407 static ssize_t snd_seq_read(struct file *file, char __user *buf, size_t count, c7e0b5bf9fff1b Takashi Iwai 2005-11-17 408 loff_t *offset) ^1da177e4c3f41 Linus Torvalds 2005-04-16 409 { c7e0b5bf9fff1b Takashi Iwai 2005-11-17 410 struct snd_seq_client *client = file->private_data; c7e0b5bf9fff1b Takashi Iwai 2005-11-17 411 struct snd_seq_fifo *fifo; 46397622a3fa83 Takashi Iwai 2023-05-23 412 size_t aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 413 int err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 414 long result = 0; c7e0b5bf9fff1b Takashi Iwai 2005-11-17 415 struct snd_seq_event_cell *cell; ^1da177e4c3f41 Linus Torvalds 2005-04-16 416 ^1da177e4c3f41 Linus Torvalds 2005-04-16 417 if (!(snd_seq_file_flags(file) & SNDRV_SEQ_LFLG_INPUT)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 418 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 419 96d4f267e40f95 Linus Torvalds 2019-01-03 420 if (!access_ok(buf, count)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 421 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 422 ^1da177e4c3f41 Linus Torvalds 2005-04-16 423 /* check client structures are in place */ 7eaa943c8ed8e9 Takashi Iwai 2008-08-08 424 if (snd_BUG_ON(!client)) 7eaa943c8ed8e9 Takashi Iwai 2008-08-08 425 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 426 f9a6bb841f7370 Takashi Iwai 2021-06-08 427 if (!client->accept_input) f9a6bb841f7370 Takashi Iwai 2021-06-08 428 return -ENXIO; f9a6bb841f7370 Takashi Iwai 2021-06-08 429 fifo = client->data.user.fifo; f9a6bb841f7370 Takashi Iwai 2021-06-08 430 if (!fifo) ^1da177e4c3f41 Linus Torvalds 2005-04-16 431 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 432 ^1da177e4c3f41 Linus Torvalds 2005-04-16 433 if (atomic_read(&fifo->overflow) > 0) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 434 /* buffer overflow is detected */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 435 snd_seq_fifo_clear(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 436 /* return error code */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 437 return -ENOSPC; ^1da177e4c3f41 Linus Torvalds 2005-04-16 438 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 439 ^1da177e4c3f41 Linus Torvalds 2005-04-16 440 cell = NULL; ^1da177e4c3f41 Linus Torvalds 2005-04-16 441 err = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 442 snd_seq_fifo_lock(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 443 46397622a3fa83 Takashi Iwai 2023-05-23 444 if (client->midi_version > 0) 46397622a3fa83 Takashi Iwai 2023-05-23 445 aligned_size = sizeof(struct snd_seq_ump_event); 46397622a3fa83 Takashi Iwai 2023-05-23 446 else 46397622a3fa83 Takashi Iwai 2023-05-23 447 aligned_size = sizeof(struct snd_seq_event); 46397622a3fa83 Takashi Iwai 2023-05-23 448 ^1da177e4c3f41 Linus Torvalds 2005-04-16 449 /* while data available in queue */ 46397622a3fa83 Takashi Iwai 2023-05-23 450 while (count >= aligned_size) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 451 int nonblock; ^1da177e4c3f41 Linus Torvalds 2005-04-16 452 ^1da177e4c3f41 Linus Torvalds 2005-04-16 453 nonblock = (file->f_flags & O_NONBLOCK) || result > 0; f9a6bb841f7370 Takashi Iwai 2021-06-08 454 err = snd_seq_fifo_cell_out(fifo, &cell, nonblock); f9a6bb841f7370 Takashi Iwai 2021-06-08 455 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 456 break; 46397622a3fa83 Takashi Iwai 2023-05-23 457 if (!event_is_compatible(client, &cell->event)) { 46397622a3fa83 Takashi Iwai 2023-05-23 458 snd_seq_cell_free(cell); 46397622a3fa83 Takashi Iwai 2023-05-23 459 cell = NULL; 46397622a3fa83 Takashi Iwai 2023-05-23 460 continue; 46397622a3fa83 Takashi Iwai 2023-05-23 461 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 462 if (snd_seq_ev_is_variable(&cell->event)) { Smatch isn't clever enough to know that if snd_seq_ev_is_variable() is false that means client->midi_version is zero. 46397622a3fa83 Takashi Iwai 2023-05-23 463 struct snd_seq_ump_event tmpev; 46397622a3fa83 Takashi Iwai 2023-05-23 464 46397622a3fa83 Takashi Iwai 2023-05-23 465 memcpy(&tmpev, &cell->event, aligned_size); ^1da177e4c3f41 Linus Torvalds 2005-04-16 466 tmpev.data.ext.len &= ~SNDRV_SEQ_EXT_MASK; 46397622a3fa83 Takashi Iwai 2023-05-23 467 if (copy_to_user(buf, &tmpev, aligned_size)) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 468 err = -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 469 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 470 } 46397622a3fa83 Takashi Iwai 2023-05-23 471 count -= aligned_size; 46397622a3fa83 Takashi Iwai 2023-05-23 472 buf += aligned_size; 4d23359b7ec8b0 Clemens Ladisch 2005-09-05 473 err = snd_seq_expand_var_event(&cell->event, count, 4d23359b7ec8b0 Clemens Ladisch 2005-09-05 474 (char __force *)buf, 0, 46397622a3fa83 Takashi Iwai 2023-05-23 475 aligned_size); ^1da177e4c3f41 Linus Torvalds 2005-04-16 476 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 477 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 478 result += err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 479 count -= err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 480 buf += err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 481 } else { 46397622a3fa83 Takashi Iwai 2023-05-23 @482 if (copy_to_user(buf, &cell->event, aligned_size)) { So smatch complains that this might be a read overflow. ^1da177e4c3f41 Linus Torvalds 2005-04-16 483 err = -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 484 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 485 } 46397622a3fa83 Takashi Iwai 2023-05-23 486 count -= aligned_size; 46397622a3fa83 Takashi Iwai 2023-05-23 487 buf += aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 488 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 489 snd_seq_cell_free(cell); ^1da177e4c3f41 Linus Torvalds 2005-04-16 490 cell = NULL; /* to be sure */ 46397622a3fa83 Takashi Iwai 2023-05-23 491 result += aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 492 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 493 ^1da177e4c3f41 Linus Torvalds 2005-04-16 494 if (err < 0) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 495 if (cell) ^1da177e4c3f41 Linus Torvalds 2005-04-16 496 snd_seq_fifo_cell_putback(fifo, cell); ^1da177e4c3f41 Linus Torvalds 2005-04-16 497 if (err == -EAGAIN && result > 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 498 err = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 499 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 500 snd_seq_fifo_unlock(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 501 ^1da177e4c3f41 Linus Torvalds 2005-04-16 502 return (err < 0) ? err : result; ^1da177e4c3f41 Linus Torvalds 2005-04-16 503 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:topic/midi20 9/40] sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16
by kernel test robot 26 May '23

26 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: ff49d1df79aef7580fe3ac99d17c3f886655d080 [9/40] ALSA: usb-audio: USB MIDI 2.0 UMP support config: openrisc-randconfig-s051-20230525 compiler: or1k-linux-gcc (GCC) 12.1.0 reproduce: mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add tiwai-sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags tiwai-sound topic/midi20 git checkout ff49d1df79aef7580fe3ac99d17c3f886655d080 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash sound/usb/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305260528.wcqjXso8-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 vim +548 sound/usb/midi2.c 530 531 /* get the full group terminal block descriptors and return the size */ 532 static int get_group_terminal_block_descs(struct snd_usb_midi2_interface *umidi) 533 { 534 struct usb_host_interface *hostif = umidi->hostif; 535 struct usb_device *dev = umidi->chip->dev; 536 struct usb_ms20_gr_trm_block_header_descriptor header = { 0 }; 537 unsigned char *data; 538 int err, size; 539 540 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 541 USB_REQ_GET_DESCRIPTOR, 542 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 543 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 544 hostif->desc.bInterfaceNumber, 545 &header, sizeof(header)); 546 if (err < 0) 547 return err; > 548 size = __le16_to_cpu(header.wTotalLength); 549 if (!size) { 550 dev_err(&dev->dev, "Failed to get GTB descriptors for %d:%d\n", 551 hostif->desc.bInterfaceNumber, hostif->desc.bAlternateSetting); 552 return -EINVAL; 553 } 554 555 data = kzalloc(size, GFP_KERNEL); 556 if (!data) 557 return -ENOMEM; 558 559 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 560 USB_REQ_GET_DESCRIPTOR, 561 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 562 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 563 hostif->desc.bInterfaceNumber, data, size); 564 if (err < 0) { 565 kfree(data); 566 return err; 567 } 568 569 umidi->blk_descs = data; 570 umidi->blk_desc_size = size; 571 return 0; 572 } 573 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[PATCH AUTOSEL 4.14 01/20] ASoC: dwc: limit the number of overrun messages
by Sasha Levin 25 May '23

25 May '23

From: Maxim Kochetkov <fido_max(a)inbox.ru> [ Upstream commit ab6ecfbf40fccf74b6ec2ba7ed6dd2fc024c3af2 ] On slow CPU (FPGA/QEMU emulated) printing overrun messages from interrupt handler to uart console may leads to more overrun errors. So use dev_err_ratelimited to limit the number of error messages. Signed-off-by: Maxim Kochetkov <fido_max(a)inbox.ru Link: https://lore.kernel.org/r/20230505062820.21840-1-fido_max@inbox.ru Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/dwc/dwc-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index e27e21f8569a0..e6a0ec3c0e764 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -132,13 +132,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id) /* Error Handling: TX */ if (isr[i] & ISR_TXFO) { - dev_err(dev->dev, "TX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "TX overrun (ch_id=%d)\n", i); irq_valid = true; } /* Error Handling: TX */ if (isr[i] & ISR_RXFO) { - dev_err(dev->dev, "RX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i); irq_valid = true; } } -- 2.39.2

1 2

[PATCH AUTOSEL 4.19 01/27] ASoC: dwc: limit the number of overrun messages
by Sasha Levin 25 May '23

25 May '23

From: Maxim Kochetkov <fido_max(a)inbox.ru> [ Upstream commit ab6ecfbf40fccf74b6ec2ba7ed6dd2fc024c3af2 ] On slow CPU (FPGA/QEMU emulated) printing overrun messages from interrupt handler to uart console may leads to more overrun errors. So use dev_err_ratelimited to limit the number of error messages. Signed-off-by: Maxim Kochetkov <fido_max(a)inbox.ru Link: https://lore.kernel.org/r/20230505062820.21840-1-fido_max@inbox.ru Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/dwc/dwc-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index 65112b9d8588a..90b8814d7506a 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -132,13 +132,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id) /* Error Handling: TX */ if (isr[i] & ISR_TXFO) { - dev_err(dev->dev, "TX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "TX overrun (ch_id=%d)\n", i); irq_valid = true; } /* Error Handling: TX */ if (isr[i] & ISR_RXFO) { - dev_err(dev->dev, "RX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i); irq_valid = true; } } -- 2.39.2

1 2

[PATCH AUTOSEL 5.4 01/27] ASoC: dwc: limit the number of overrun messages
by Sasha Levin 25 May '23

25 May '23

From: Maxim Kochetkov <fido_max(a)inbox.ru> [ Upstream commit ab6ecfbf40fccf74b6ec2ba7ed6dd2fc024c3af2 ] On slow CPU (FPGA/QEMU emulated) printing overrun messages from interrupt handler to uart console may leads to more overrun errors. So use dev_err_ratelimited to limit the number of error messages. Signed-off-by: Maxim Kochetkov <fido_max(a)inbox.ru Link: https://lore.kernel.org/r/20230505062820.21840-1-fido_max@inbox.ru Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/dwc/dwc-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index 65112b9d8588a..90b8814d7506a 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -132,13 +132,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id) /* Error Handling: TX */ if (isr[i] & ISR_TXFO) { - dev_err(dev->dev, "TX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "TX overrun (ch_id=%d)\n", i); irq_valid = true; } /* Error Handling: TX */ if (isr[i] & ISR_RXFO) { - dev_err(dev->dev, "RX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i); irq_valid = true; } } -- 2.39.2

1 2

[PATCH AUTOSEL 5.10 01/31] ASoC: dwc: limit the number of overrun messages
by Sasha Levin 25 May '23

25 May '23

From: Maxim Kochetkov <fido_max(a)inbox.ru> [ Upstream commit ab6ecfbf40fccf74b6ec2ba7ed6dd2fc024c3af2 ] On slow CPU (FPGA/QEMU emulated) printing overrun messages from interrupt handler to uart console may leads to more overrun errors. So use dev_err_ratelimited to limit the number of error messages. Signed-off-by: Maxim Kochetkov <fido_max(a)inbox.ru Link: https://lore.kernel.org/r/20230505062820.21840-1-fido_max@inbox.ru Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/dwc/dwc-i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c index 36da0f01571a1..5469399abcb44 100644 --- a/sound/soc/dwc/dwc-i2s.c +++ b/sound/soc/dwc/dwc-i2s.c @@ -132,13 +132,13 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id) /* Error Handling: TX */ if (isr[i] & ISR_TXFO) { - dev_err(dev->dev, "TX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "TX overrun (ch_id=%d)\n", i); irq_valid = true; } /* Error Handling: TX */ if (isr[i] & ISR_RXFO) { - dev_err(dev->dev, "RX overrun (ch_id=%d)\n", i); + dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i); irq_valid = true; } } -- 2.39.2

1 3

[PATCH AUTOSEL 5.15 38/43] ALSA: oss: avoid missing-prototype warnings
by Sasha Levin 25 May '23

25 May '23

From: Arnd Bergmann <arnd(a)arndb.de> [ Upstream commit 040b5a046a9e18098580d3ccd029e2318fca7859 ] Two functions are defined and used in pcm_oss.c but also optionally used from io.c, with an optional prototype. If CONFIG_SND_PCM_OSS_PLUGINS is disabled, this causes a warning as the functions are not static and have no prototype: sound/core/oss/pcm_oss.c:1235:19: error: no previous prototype for 'snd_pcm_oss_write3' [-Werror=missing-prototypes] sound/core/oss/pcm_oss.c:1266:19: error: no previous prototype for 'snd_pcm_oss_read3' [-Werror=missing-prototypes] Avoid this by making the prototypes unconditional. Signed-off-by: Arnd Bergmann <arnd(a)arndb.de> Link: https://lore.kernel.org/r/20230516195046.550584-2-arnd@kernel.org Signed-off-by: Takashi Iwai <tiwai(a)suse.de> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/core/oss/pcm_plugin.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/core/oss/pcm_plugin.h b/sound/core/oss/pcm_plugin.h index 46e273bd4a786..50a6b50f5db4c 100644 --- a/sound/core/oss/pcm_plugin.h +++ b/sound/core/oss/pcm_plugin.h @@ -141,6 +141,14 @@ int snd_pcm_area_copy(const struct snd_pcm_channel_area *src_channel, void *snd_pcm_plug_buf_alloc(struct snd_pcm_substream *plug, snd_pcm_uframes_t size); void snd_pcm_plug_buf_unlock(struct snd_pcm_substream *plug, void *ptr); +#else + +static inline snd_pcm_sframes_t snd_pcm_plug_client_size(struct snd_pcm_substream *handle, snd_pcm_uframes_t drv_size) { return drv_size; } +static inline snd_pcm_sframes_t snd_pcm_plug_slave_size(struct snd_pcm_substream *handle, snd_pcm_uframes_t clt_size) { return clt_size; } +static inline int snd_pcm_plug_slave_format(int format, const struct snd_mask *format_mask) { return format; } + +#endif + snd_pcm_sframes_t snd_pcm_oss_write3(struct snd_pcm_substream *substream, const char *ptr, snd_pcm_uframes_t size, int in_kernel); @@ -151,14 +159,6 @@ snd_pcm_sframes_t snd_pcm_oss_writev3(struct snd_pcm_substream *substream, snd_pcm_sframes_t snd_pcm_oss_readv3(struct snd_pcm_substream *substream, void **bufs, snd_pcm_uframes_t frames); -#else - -static inline snd_pcm_sframes_t snd_pcm_plug_client_size(struct snd_pcm_substream *handle, snd_pcm_uframes_t drv_size) { return drv_size; } -static inline snd_pcm_sframes_t snd_pcm_plug_slave_size(struct snd_pcm_substream *handle, snd_pcm_uframes_t clt_size) { return clt_size; } -static inline int snd_pcm_plug_slave_format(int format, const struct snd_mask *format_mask) { return format; } - -#endif - #ifdef PLUGIN_DEBUG #define pdprintf(fmt, args...) printk(KERN_DEBUG "plugin: " fmt, ##args) #else -- 2.39.2

1 0

[PATCH AUTOSEL 5.15 08/43] ASoC: ssm2602: Add workaround for playback distortions
by Sasha Levin 25 May '23

25 May '23

From: Paweł Anikiel <pan(a)semihalf.com> [ Upstream commit f63550e2b165208a2f382afcaf5551df9569e1d4 ] Apply a workaround for what appears to be a hardware quirk. The problem seems to happen when enabling "whole chip power" (bit D7 register R6) for the very first time after the chip receives power. If either "output" (D4) or "DAC" (D3) aren't powered on at that time, playback becomes very distorted later on. This happens on the Google Chameleon v3, as well as on a ZYBO Z7-10: https://ez.analog.com/audio/f/q-a/543726/solved-ssm2603-right-output-offset… I suspect this happens only when using an external MCLK signal (which is the case for both of these boards). Here are some experiments run on a Google Chameleon v3. These were run in userspace using a wrapper around the i2cset utility: ssmset() { i2cset -y 0 0x1a $(($1*2)) $2 } For each of the following sequences, we apply power to the ssm2603 chip, set the configuration registers R0-R5 and R7-R8, run the selected sequence, and check for distortions on playback. ssmset 0x09 0x01 # core ssmset 0x06 0x07 # chip, out, dac OK ssmset 0x09 0x01 # core ssmset 0x06 0x87 # out, dac ssmset 0x06 0x07 # chip OK (disable MCLK) ssmset 0x09 0x01 # core ssmset 0x06 0x1f # chip ssmset 0x06 0x07 # out, dac (enable MCLK) OK ssmset 0x09 0x01 # core ssmset 0x06 0x1f # chip ssmset 0x06 0x07 # out, dac NOT OK ssmset 0x06 0x1f # chip ssmset 0x09 0x01 # core ssmset 0x06 0x07 # out, dac NOT OK ssmset 0x09 0x01 # core ssmset 0x06 0x0f # chip, out ssmset 0x06 0x07 # dac NOT OK ssmset 0x09 0x01 # core ssmset 0x06 0x17 # chip, dac ssmset 0x06 0x07 # out NOT OK For each of the following sequences, we apply power to the ssm2603 chip, run the selected sequence, issue a reset with R15, configure R0-R5 and R7-R8, run one of the NOT OK sequences from above, and check for distortions. ssmset 0x09 0x01 # core ssmset 0x06 0x07 # chip, out, dac OK (disable MCLK) ssmset 0x09 0x01 # core ssmset 0x06 0x07 # chip, out, dac (enable MCLK after reset) NOT OK ssmset 0x09 0x01 # core ssmset 0x06 0x17 # chip, dac NOT OK ssmset 0x09 0x01 # core ssmset 0x06 0x0f # chip, out NOT OK ssmset 0x06 0x07 # chip, out, dac NOT OK Signed-off-by: Paweł Anikiel <pan(a)semihalf.com Link: https://lore.kernel.org/r/20230508113037.137627-8-pan@semihalf.com Signed-off-by: Mark Brown <broonie(a)kernel.org Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- sound/soc/codecs/ssm2602.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 7964e922b07f6..0a3540c5cdb5c 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -53,6 +53,18 @@ static const struct reg_default ssm2602_reg[SSM2602_CACHEREGNUM] = { { .reg = 0x09, .def = 0x0000 } }; +/* + * ssm2602 register patch + * Workaround for playback distortions after power up: activates digital + * core, and then powers on output, DAC, and whole chip at the same time + */ + +static const struct reg_sequence ssm2602_patch[] = { + { SSM2602_ACTIVE, 0x01 }, + { SSM2602_PWR, 0x07 }, + { SSM2602_RESET, 0x00 }, +}; + /*Appending several "None"s just for OSS mixer use*/ static const char *ssm2602_input_select[] = { @@ -589,6 +601,9 @@ static int ssm260x_component_probe(struct snd_soc_component *component) return ret; } + regmap_register_patch(ssm2602->regmap, ssm2602_patch, + ARRAY_SIZE(ssm2602_patch)); + /* set the update bits */ regmap_update_bits(ssm2602->regmap, SSM2602_LINVOL, LINVOL_LRIN_BOTH, LINVOL_LRIN_BOTH); -- 2.39.2

1 0