May 2023 - Alsa-devel - mailman.alsa-project.org

Asus ROG Zephyrus GX701L sound problem
by Kernel.org Bugbot 27 May '23

27 May '23

rakic.iwan writes via Kernel.org Bugzilla: Hello, I must mention right at the beginning that I tried all the solutions I found on the forums, but without success. The problem exists only with the speakers on the laptop, the microphone works, as do the headphones. I extracted the audio dump from windows and compared it with the dump from Linux and thus created this pinfcg below. Please, can someone add a kernel fix for ROG Zephyrus S17 GX701LWS_GX701LWS, Subsystem Id: 0x10431f01? ``` [codec] 0x10ec0294 0x10431f01 0 [pincfg] 0x19 0x03A11050 0x1a 0x03A11C30 ``` This is what a quirk should look like: +SND_PCI_QUIRK(0x1043, 0x1f01, “ASUS GX701L”, ALC294_FIXUP_ASUS_SPK) [ 2.396344] snd_hda_codec_realtek hdaudioC0D0: autoconfig for ALC294: line_outs=1 (0x17/0x0/0x0/0x0/0x0) type:speaker [ 2.396348] snd_hda_codec_realtek hdaudioC0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) [ 2.396349] snd_hda_codec_realtek hdaudioC0D0: hp_outs=1 (0x21/0x0/0x0/0x0/0x0) [ 2.396350] snd_hda_codec_realtek hdaudioC0D0: mono: mono_out=0x0 [ 2.396351] snd_hda_codec_realtek hdaudioC0D0: inputs: [ 2.396352] snd_hda_codec_realtek hdaudioC0D0: Headset Mic=0x19 [ 2.396353] snd_hda_codec_realtek hdaudioC0D0: Internal Mic=0x12 hwinfo --sound  :heavy_check_mark: 22: PCI 1f.3: 0403 Audio device [Created at pci.386] Unique ID: nS1_.Qb7ky1jjQRD SysFS ID: /devices/pci0000:00/0000:00:1f.3 SysFS BusID: 0000:00:1f.3 Hardware Class: sound Model: “Intel Comet Lake PCH cAVS” Vendor: pci 0x8086 “Intel Corporation” Device: pci 0x06c8 “Comet Lake PCH cAVS” SubVendor: pci 0x1043 “ASUSTeK Computer Inc.” SubDevice: pci 0x1f01 Driver: “snd_hda_intel” Driver Modules: “snd_hda_intel” Memory Range: 0x94300000-0x94303fff (rw,non-prefetchable) Memory Range: 0x94100000-0x941fffff (rw,non-prefetchable) IRQ: 157 (817 events) Module Alias: “pci:v00008086d000006C8sv00001043sd00001F01bc04sc03i80” Driver Info #0: Driver Status: snd_hda_intel is active Driver Activation Cmd: “modprobe snd_hda_intel” Driver Info #1: Driver Status: snd_soc_skl is active Driver Activation Cmd: “modprobe snd_soc_skl” Driver Info #2: Driver Status: snd_sof_pci_intel_cnl is active Driver Activation Cmd: “modprobe snd_sof_pci_intel_cnl” Config Status: cfg=new, avail=yes, need=no, active=unknown 29: PCI 100.1: 0403 Audio device [Created at pci.386] Unique ID: NXNs.SkelvpPm387 Parent ID: vSkL.ZFPYIgTFUyC SysFS ID: /devices/pci0000:00/0000:00:01.0/0000:01:00.1 SysFS BusID: 0000:01:00.1 Hardware Class: sound Model: “nVidia TU104 HD Audio Controller” Vendor: pci 0x10de “nVidia Corporation” Device: pci 0x10f8 “TU104 HD Audio Controller” SubVendor: pci 0x1043 “ASUSTeK Computer Inc.” SubDevice: pci 0x186f Revision: 0xa1 Driver: “snd_hda_intel” Driver Modules: “snd_hda_intel” Memory Range: 0x94080000-0x94083fff (rw,non-prefetchable) IRQ: 17 (1698 events) Module Alias: “pci:v000010DEd000010F8sv00001043sd0000186Fbc04sc03i00” Driver Info #0: Driver Status: snd_hda_intel is active Driver Activation Cmd: “modprobe snd_hda_intel” Config Status: cfg=new, avail=yes, need=no, active=unknown Attached to: #13 (PCI bridge) If you need any more data, or smth just say so. View: https://bugzilla.kernel.org/show_bug.cgi?id=216392#c0 You can reply to this message to join the discussion. -- Deet-doot-dot, I am a bot. Kernel.org Bugzilla (peebz 0.1)

1 2

Matebook 11 Intel 2021; always need to manually set config in amixer
by GitHub issues - edited 27 May '23

27 May '23

alsa-project/alsa-ucm-conf issue #319 was edited from TigerbyteDev: Hey, the drivers in sof got fixed but I still need to manually set the alsa config. My microphone also isn't working, not sure why. This got investigated a bit in the other issue too. Config: ```bash amixer -c 0 cset name='Headphone Switch' on amixer -c 0 cset name='Headphone Playback Volume' 3,3 amixer -c 0 cset name='Right Headphone Mixer Right DAC Switch' on amixer -c 0 cset name='Left Headphone Mixer Left DAC Switch' on amixer -c 0 cset name='DAC Playback Volume' 999,999 amixer -c 0 cset name='Headphone Mixer Volume' 999,999 amixer -c 0 cset name='Differential Mux' lin1-rin1 amixer -c 0 cset name='Differential Mux' lin2-rin2 amixer -c 0 cset name='DAC Soft Ramp Switch' off ``` Issue in SOF: https://github.com/thesofproject/sof-bin/issues/121 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/319 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Matebook 11 Intel 2021; always need to manually set config in amixer
by GitHub issues - opened 27 May '23

27 May '23

alsa-project/alsa-ucm-conf issue #319 was opened from TigerbyteDev: Hey, the drivers in sof got fixed but I still need to manually set the alsa config. My microphone also isn't working, not sure why. This got investigated a bit in the other issue too. Config: ```bash amixer -c 0 cset name='Headphone Switch' on amixer -c 0 cset name='Headphone Playback Volume' 3,3 amixer -c 0 cset name='Right Headphone Mixer Right DAC Switch' on amixer -c 0 cset name='Left Headphone Mixer Left DAC Switch' on amixer -c 0 cset name='DAC Playback Volume' 999,999 amixer -c 0 cset name='Headphone Mixer Volume' 999,999 amixer -c 0 cset name='Differential Mux' lin1-rin1 amixer -c 0 cset name='Differential Mux' lin2-rin2 amixer -c 0 cset name='DAC Soft Ramp Switch' off ``` Issue in SOF: https://github.com/thesofproject/sof-bin/issues/121 Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/319 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] soundwire: qcom: add proper error paths in qcom_swrm_startup()
by Krzysztof Kozlowski 27 May '23

27 May '23

Reverse actions in qcom_swrm_startup() error paths to avoid leaking stream memory and keeping runtime PM unbalanced. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/soundwire/qcom.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index f442280af9d3..baaa75320ae3 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1208,8 +1208,10 @@ static int qcom_swrm_startup(struct snd_pcm_substream *substream, } sruntime = sdw_alloc_stream(dai->name); - if (!sruntime) - return -ENOMEM; + if (!sruntime) { + ret = -ENOMEM; + goto err_alloc; + } ctrl->sruntime[dai->id] = sruntime; @@ -1219,12 +1221,19 @@ static int qcom_swrm_startup(struct snd_pcm_substream *substream, if (ret < 0 && ret != -ENOTSUPP) { dev_err(dai->dev, "Failed to set sdw stream on %s\n", codec_dai->name); - sdw_release_stream(sruntime); - return ret; + goto err_set_stream; } } return 0; + +err_set_stream: + sdw_release_stream(sruntime); +err_alloc: + pm_runtime_mark_last_busy(ctrl->dev); + pm_runtime_put_autosuspend(ctrl->dev); + + return ret; } static void qcom_swrm_shutdown(struct snd_pcm_substream *substream, -- 2.34.1

3 2

[RESEND PATCH] soundwire: qcom: drop unused struct qcom_swrm_ctrl members
by Krzysztof Kozlowski 27 May '23

27 May '23

Drop unused members from the driver state container: struct qcom_swrm_ctrl. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/soundwire/qcom.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index aad5942e5980..ab1098ec56e6 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -187,12 +187,9 @@ struct qcom_swrm_ctrl { #endif struct completion broadcast; struct completion enumeration; - struct work_struct slave_work; /* Port alloc/free lock */ struct mutex port_lock; struct clk *hclk; - u8 wr_cmd_id; - u8 rd_cmd_id; int irq; unsigned int version; int wake_irq; -- 2.34.1

3 2

[PATCH] soundwire: intel: read AC timing control register before updating it
by Bard Liao 27 May '23

27 May '23

From: Chao Song <chao.song(a)linux.intel.com> Start from ACE1.x, DOAISE is added to AC timing control register bit 5, it combines with DOAIS to get effective timing, and has the default value 1. The current code fills DOAIS, DACTQE and DODS bits to a variable initialized to zero, and updates the variable to AC timing control register. With this operation, We change DOAISE to 0, and force a much more aggressive timing. The timing is even unable to form a working waveform on SDA pin on Meteorlake. This patch uses read-modify-write operation for the AC timing control register access, thus makes sure those bits not supposed and intended to change are not touched. Signed-off-by: Chao Song <chao.song(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/soundwire/intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 238acf5c97a9..8cd2c73ac66f 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -260,7 +260,7 @@ static void intel_shim_init(struct sdw_intel *sdw) { void __iomem *shim = sdw->link_res->shim; unsigned int link_id = sdw->instance; - u16 ioctl = 0, act = 0; + u16 ioctl = 0, act; /* Initialize Shim */ ioctl |= SDW_SHIM_IOCTL_BKE; @@ -281,6 +281,7 @@ static void intel_shim_init(struct sdw_intel *sdw) intel_shim_glue_to_master_ip(sdw); + act = intel_readw(shim, SDW_SHIM_CTMCTL(link_id)); u16p_replace_bits(&act, 0x1, SDW_SHIM_CTMCTL_DOAIS); act |= SDW_SHIM_CTMCTL_DACTQE; act |= SDW_SHIM_CTMCTL_DODS; -- 2.25.1

2 1

[PATCH] soundwire: dmi-quirks: add new mapping for HP Spectre x360
by Bard Liao 27 May '23

27 May '23

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> A BIOS/DMI update seems to have broken some devices, let's add a new mapping. Link: https://github.com/thesofproject/linux/issues/4323 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/soundwire/dmi-quirks.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c index 58ea013fa918..2a1096dab63d 100644 --- a/drivers/soundwire/dmi-quirks.c +++ b/drivers/soundwire/dmi-quirks.c @@ -99,6 +99,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = { }, .driver_data = (void *)intel_tgl_bios, }, + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_BOARD_NAME, "8709"), + }, + .driver_data = (void *)intel_tgl_bios, + }, { /* quirk used for NUC15 'Bishop County' LAPBC510 and LAPBC710 skews */ .matches = { -- 2.25.1

2 1

[tiwai-sound:topic/midi20 9/40] sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16
by kernel test robot 27 May '23

27 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: ff49d1df79aef7580fe3ac99d17c3f886655d080 [9/40] ALSA: usb-audio: USB MIDI 2.0 UMP support config: microblaze-randconfig-s032-20230526 (https://download.01.org/0day-ci/archive/20230527/202305270534.odwHL9F0-lkp@…) compiler: microblaze-linux-gcc (GCC) 12.1.0 reproduce: mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add tiwai-sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags tiwai-sound topic/midi20 git checkout ff49d1df79aef7580fe3ac99d17c3f886655d080 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze SHELL=/bin/bash sound/usb/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305270534.odwHL9F0-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 vim +548 sound/usb/midi2.c 530 531 /* get the full group terminal block descriptors and return the size */ 532 static int get_group_terminal_block_descs(struct snd_usb_midi2_interface *umidi) 533 { 534 struct usb_host_interface *hostif = umidi->hostif; 535 struct usb_device *dev = umidi->chip->dev; 536 struct usb_ms20_gr_trm_block_header_descriptor header = { 0 }; 537 unsigned char *data; 538 int err, size; 539 540 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 541 USB_REQ_GET_DESCRIPTOR, 542 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 543 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 544 hostif->desc.bInterfaceNumber, 545 &header, sizeof(header)); 546 if (err < 0) 547 return err; > 548 size = __le16_to_cpu(header.wTotalLength); 549 if (!size) { 550 dev_err(&dev->dev, "Failed to get GTB descriptors for %d:%d\n", 551 hostif->desc.bInterfaceNumber, hostif->desc.bAlternateSetting); 552 return -EINVAL; 553 } 554 555 data = kzalloc(size, GFP_KERNEL); 556 if (!data) 557 return -ENOMEM; 558 559 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 560 USB_REQ_GET_DESCRIPTOR, 561 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 562 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 563 hostif->desc.bInterfaceNumber, data, size); 564 if (err < 0) { 565 kfree(data); 566 return err; 567 } 568 569 umidi->blk_descs = data; 570 umidi->blk_desc_size = size; 571 return 0; 572 } 573 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

alsa-lib fails test with clang-16
by GitHub issues - opened 27 May '23

27 May '23

alsa-project/alsa-lib issue #323 was opened from fsvm88: Hello, While building is fine, testing alsa-lib on Gentoo fails since clang-16, due to clang-16 defaulting to c99. The problem is at `alsa-lib-1.2.8/test/oldapi.c`, in the typedef declaration, which leads to the following error: ``` alsa-lib-1.2.8/test/oldapi.c:40:6: error: incompatible function pointer types assigning to 'myfcn *' (aka 'void (*)(void *)') from 'int (*)(const snd_pcm_hw_params_t *)' (aka 'int (*)(const struct _snd_pcm_hw_params *)') [-Werror,-Wincompatible-func fcn = &snd_pcm_hw_params_get_access; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` [This is the Gentoo bug with all the information](https://bugs.gentoo.org/885551) [I have created a patch based on the compiler's suggestion](https://885551.bugs.gentoo.org/attachment.cgi?id=861055), but I'm not sure if it's the right way to solve this. Issue URL : https://github.com/alsa-project/alsa-lib/issues/323 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 00/13] ALSA: hda: Adding support for CS35L56 on HDA systems
by Richard Fitzgerald 26 May '23

26 May '23

This set of patches adds support for using the CS35L56 boosted smart amplifier on HDA systems. In these systems the CS35L56 audio is routed through a HDA-to-I2S bridge codec. This doesn't include the changes to the Realtek driver to actually hook up the CS35L56 driver, because we don't yet have the QUIRK IDs to associate it with. But we want to publish the driver now so that it is available for bringing up hardware with the CS35L56. The first 10 patches are moving code out of the ASoC driver and into the shared library so that it can be shared with the HDA driver. Patch #11 fixes missing #includes in the HDA headers so that the CS35L56 driver doesn't have to #include headers that it doesn't use. Finally, #12 and #13 actually add the support for CS35L56 on HDA. Richard Fitzgerald (5): ASoC: cs35l56: Move runtime suspend/resume to shared library ASoC: cs35l56: Move cs_dsp init into shared library ASoC: cs35l56: Move part of cs35l56_init() to shared library ASoC: cs35l56: Pass correct pointer to cs35l56_irq() ALSA: hda: Fix missing header dependencies Simon Trimmer (8): ASoC: cs35l56: Move shared data into a common data structure ASoC: cs35l56: Make cs35l56_system_reset() code more generic ASoC: cs35l56: Convert utility functions to use common data structure ASoC: cs35l56: Move utility functions to shared file ASoC: cs35l56: Make common function for control port wait ASoC: cs35l56: Make a common function to shutdown the DSP ALSA: hda: Add mute_hook to hda_component ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier include/sound/cs35l56.h | 29 +- sound/pci/hda/Kconfig | 31 + sound/pci/hda/Makefile | 6 + sound/pci/hda/cs35l56_hda.c | 995 ++++++++++++++++++++++++++++++ sound/pci/hda/cs35l56_hda.h | 48 ++ sound/pci/hda/cs35l56_hda_i2c.c | 69 +++ sound/pci/hda/cs35l56_hda_spi.c | 68 ++ sound/pci/hda/hda_auto_parser.h | 2 + sound/pci/hda/hda_component.h | 1 + sound/pci/hda/hda_generic.h | 3 + sound/soc/codecs/cs35l56-i2c.c | 14 +- sound/soc/codecs/cs35l56-sdw.c | 72 +-- sound/soc/codecs/cs35l56-shared.c | 459 +++++++++++++- sound/soc/codecs/cs35l56-spi.c | 10 +- sound/soc/codecs/cs35l56.c | 648 ++++--------------- sound/soc/codecs/cs35l56.h | 15 +- 16 files changed, 1878 insertions(+), 592 deletions(-) create mode 100644 sound/pci/hda/cs35l56_hda.c create mode 100644 sound/pci/hda/cs35l56_hda.h create mode 100644 sound/pci/hda/cs35l56_hda_i2c.c create mode 100644 sound/pci/hda/cs35l56_hda_spi.c -- 2.30.2

3 19