May 2023 - Alsa-devel - mailman.alsa-project.org

[RESEND PATCH] soundwire: qcom: drop unused struct qcom_swrm_ctrl members
by Krzysztof Kozlowski 27 May '23

27 May '23

Drop unused members from the driver state container: struct qcom_swrm_ctrl. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski(a)linaro.org> --- drivers/soundwire/qcom.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index aad5942e5980..ab1098ec56e6 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -187,12 +187,9 @@ struct qcom_swrm_ctrl { #endif struct completion broadcast; struct completion enumeration; - struct work_struct slave_work; /* Port alloc/free lock */ struct mutex port_lock; struct clk *hclk; - u8 wr_cmd_id; - u8 rd_cmd_id; int irq; unsigned int version; int wake_irq; -- 2.34.1

3 2

[PATCH] soundwire: intel: read AC timing control register before updating it
by Bard Liao 27 May '23

27 May '23

From: Chao Song <chao.song(a)linux.intel.com> Start from ACE1.x, DOAISE is added to AC timing control register bit 5, it combines with DOAIS to get effective timing, and has the default value 1. The current code fills DOAIS, DACTQE and DODS bits to a variable initialized to zero, and updates the variable to AC timing control register. With this operation, We change DOAISE to 0, and force a much more aggressive timing. The timing is even unable to form a working waveform on SDA pin on Meteorlake. This patch uses read-modify-write operation for the AC timing control register access, thus makes sure those bits not supposed and intended to change are not touched. Signed-off-by: Chao Song <chao.song(a)linux.intel.com> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/soundwire/intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 238acf5c97a9..8cd2c73ac66f 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -260,7 +260,7 @@ static void intel_shim_init(struct sdw_intel *sdw) { void __iomem *shim = sdw->link_res->shim; unsigned int link_id = sdw->instance; - u16 ioctl = 0, act = 0; + u16 ioctl = 0, act; /* Initialize Shim */ ioctl |= SDW_SHIM_IOCTL_BKE; @@ -281,6 +281,7 @@ static void intel_shim_init(struct sdw_intel *sdw) intel_shim_glue_to_master_ip(sdw); + act = intel_readw(shim, SDW_SHIM_CTMCTL(link_id)); u16p_replace_bits(&act, 0x1, SDW_SHIM_CTMCTL_DOAIS); act |= SDW_SHIM_CTMCTL_DACTQE; act |= SDW_SHIM_CTMCTL_DODS; -- 2.25.1

2 1

[PATCH] soundwire: dmi-quirks: add new mapping for HP Spectre x360
by Bard Liao 27 May '23

27 May '23

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> A BIOS/DMI update seems to have broken some devices, let's add a new mapping. Link: https://github.com/thesofproject/linux/issues/4323 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/soundwire/dmi-quirks.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c index 58ea013fa918..2a1096dab63d 100644 --- a/drivers/soundwire/dmi-quirks.c +++ b/drivers/soundwire/dmi-quirks.c @@ -99,6 +99,13 @@ static const struct dmi_system_id adr_remap_quirk_table[] = { }, .driver_data = (void *)intel_tgl_bios, }, + { + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_BOARD_NAME, "8709"), + }, + .driver_data = (void *)intel_tgl_bios, + }, { /* quirk used for NUC15 'Bishop County' LAPBC510 and LAPBC710 skews */ .matches = { -- 2.25.1

2 1

[tiwai-sound:topic/midi20 9/40] sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16
by kernel test robot 27 May '23

27 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: ff49d1df79aef7580fe3ac99d17c3f886655d080 [9/40] ALSA: usb-audio: USB MIDI 2.0 UMP support config: microblaze-randconfig-s032-20230526 (https://download.01.org/0day-ci/archive/20230527/202305270534.odwHL9F0-lkp@…) compiler: microblaze-linux-gcc (GCC) 12.1.0 reproduce: mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add tiwai-sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags tiwai-sound topic/midi20 git checkout ff49d1df79aef7580fe3ac99d17c3f886655d080 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=microblaze SHELL=/bin/bash sound/usb/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305270534.odwHL9F0-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 vim +548 sound/usb/midi2.c 530 531 /* get the full group terminal block descriptors and return the size */ 532 static int get_group_terminal_block_descs(struct snd_usb_midi2_interface *umidi) 533 { 534 struct usb_host_interface *hostif = umidi->hostif; 535 struct usb_device *dev = umidi->chip->dev; 536 struct usb_ms20_gr_trm_block_header_descriptor header = { 0 }; 537 unsigned char *data; 538 int err, size; 539 540 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 541 USB_REQ_GET_DESCRIPTOR, 542 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 543 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 544 hostif->desc.bInterfaceNumber, 545 &header, sizeof(header)); 546 if (err < 0) 547 return err; > 548 size = __le16_to_cpu(header.wTotalLength); 549 if (!size) { 550 dev_err(&dev->dev, "Failed to get GTB descriptors for %d:%d\n", 551 hostif->desc.bInterfaceNumber, hostif->desc.bAlternateSetting); 552 return -EINVAL; 553 } 554 555 data = kzalloc(size, GFP_KERNEL); 556 if (!data) 557 return -ENOMEM; 558 559 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 560 USB_REQ_GET_DESCRIPTOR, 561 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 562 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 563 hostif->desc.bInterfaceNumber, data, size); 564 if (err < 0) { 565 kfree(data); 566 return err; 567 } 568 569 umidi->blk_descs = data; 570 umidi->blk_desc_size = size; 571 return 0; 572 } 573 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

alsa-lib fails test with clang-16
by GitHub issues - opened 26 May '23

26 May '23

alsa-project/alsa-lib issue #323 was opened from fsvm88: Hello, While building is fine, testing alsa-lib on Gentoo fails since clang-16, due to clang-16 defaulting to c99. The problem is at `alsa-lib-1.2.8/test/oldapi.c`, in the typedef declaration, which leads to the following error: ``` alsa-lib-1.2.8/test/oldapi.c:40:6: error: incompatible function pointer types assigning to 'myfcn *' (aka 'void (*)(void *)') from 'int (*)(const snd_pcm_hw_params_t *)' (aka 'int (*)(const struct _snd_pcm_hw_params *)') [-Werror,-Wincompatible-func fcn = &snd_pcm_hw_params_get_access; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` [This is the Gentoo bug with all the information](https://bugs.gentoo.org/885551) [I have created a patch based on the compiler's suggestion](https://885551.bugs.gentoo.org/attachment.cgi?id=861055), but I'm not sure if it's the right way to solve this. Issue URL : https://github.com/alsa-project/alsa-lib/issues/323 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 00/13] ALSA: hda: Adding support for CS35L56 on HDA systems
by Richard Fitzgerald 26 May '23

26 May '23

This set of patches adds support for using the CS35L56 boosted smart amplifier on HDA systems. In these systems the CS35L56 audio is routed through a HDA-to-I2S bridge codec. This doesn't include the changes to the Realtek driver to actually hook up the CS35L56 driver, because we don't yet have the QUIRK IDs to associate it with. But we want to publish the driver now so that it is available for bringing up hardware with the CS35L56. The first 10 patches are moving code out of the ASoC driver and into the shared library so that it can be shared with the HDA driver. Patch #11 fixes missing #includes in the HDA headers so that the CS35L56 driver doesn't have to #include headers that it doesn't use. Finally, #12 and #13 actually add the support for CS35L56 on HDA. Richard Fitzgerald (5): ASoC: cs35l56: Move runtime suspend/resume to shared library ASoC: cs35l56: Move cs_dsp init into shared library ASoC: cs35l56: Move part of cs35l56_init() to shared library ASoC: cs35l56: Pass correct pointer to cs35l56_irq() ALSA: hda: Fix missing header dependencies Simon Trimmer (8): ASoC: cs35l56: Move shared data into a common data structure ASoC: cs35l56: Make cs35l56_system_reset() code more generic ASoC: cs35l56: Convert utility functions to use common data structure ASoC: cs35l56: Move utility functions to shared file ASoC: cs35l56: Make common function for control port wait ASoC: cs35l56: Make a common function to shutdown the DSP ALSA: hda: Add mute_hook to hda_component ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier include/sound/cs35l56.h | 29 +- sound/pci/hda/Kconfig | 31 + sound/pci/hda/Makefile | 6 + sound/pci/hda/cs35l56_hda.c | 995 ++++++++++++++++++++++++++++++ sound/pci/hda/cs35l56_hda.h | 48 ++ sound/pci/hda/cs35l56_hda_i2c.c | 69 +++ sound/pci/hda/cs35l56_hda_spi.c | 68 ++ sound/pci/hda/hda_auto_parser.h | 2 + sound/pci/hda/hda_component.h | 1 + sound/pci/hda/hda_generic.h | 3 + sound/soc/codecs/cs35l56-i2c.c | 14 +- sound/soc/codecs/cs35l56-sdw.c | 72 +-- sound/soc/codecs/cs35l56-shared.c | 459 +++++++++++++- sound/soc/codecs/cs35l56-spi.c | 10 +- sound/soc/codecs/cs35l56.c | 648 ++++--------------- sound/soc/codecs/cs35l56.h | 15 +- 16 files changed, 1878 insertions(+), 592 deletions(-) create mode 100644 sound/pci/hda/cs35l56_hda.c create mode 100644 sound/pci/hda/cs35l56_hda.h create mode 100644 sound/pci/hda/cs35l56_hda_i2c.c create mode 100644 sound/pci/hda/cs35l56_hda_spi.c -- 2.30.2

3 19

Failed to import use case configuration
by GitHub issues - opened 26 May '23

26 May '23

alsa-project/alsa-utils issue #217 was opened from jesusjimsa: Hello, I have stored the configuration for my sound card in an asound.state file and `alsactl` is reading it fine, but during boot and whenever I try running the command manually, this message appears in the log: ``` alsa-lib ../../../git/src/ucm/main.c:1412:(snd_use_case_mgr_open) error: failed to import hw:0 use case configuration -2 ``` I don't understand what is going wrong and I haven't found much online. Any ideas for how I could fix this error or what might be the origin of it? This is what I get if I run `aplay -l`: ``` ~# aplay -l **** List of PLAYBACK Hardware Devices **** card 0: mycard [mycard], device 0: 44004000.audio-controller-tlv320aic31xx-hifi tlv320aic31xx-hifi [44004000.audio-controller-tlv320aic31xx-hifi tlv320aic31xx-hifi] Subdevices: 1/1 Subdevice #0: subdevice #0 ``` Thank you. Issue URL : https://github.com/alsa-project/alsa-utils/issues/217 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH v6 0/8] Add SC7280 audioreach device tree nodes
by Mohammad Rafi Shaik 26 May '23

26 May '23

Add SC7280 audioreach device tree nodes and extract audio specific dtsi nodes and add them in new file. This patch series depends on: -- https://patchwork.kernel.org/project/linux-clk/list/?series=717985 Corresponding dt-bindings not mainlined yet. -- https://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux.git/commit… Changes Since v5: -- Re-arrange the patch list, driver changes should come after binding. -- Remove incorrect dai cells property in "Add sound node for crd-rev3 board" patch. -- Remove newlines in "Add LPASS PIL node" patch. -- Update the commit message in "Update VA/RX/TX macro clock nodes" patch. -- Update the commit message in "Update lpass_tlmm node" patch. Changes Since v4: -- Modify lpasscc clock controller node name. -- Disable lpass_core node. -- Modify Model name in sound node in "Add sound node for crd-rev3 board" patch. -- Remove protection domain property in "Add LPASS PIL node". Changes Since v3: -- Remove deleting digital codecs in crd-rev3 board specific dtsi and upadate them using phandle. -- Update commit message in "Update lpass_tlmm node" patch. -- Change the position of status property in LPASS PIL node. -- Update commit message in "Add sound node" patch. Changes Since v2: -- Remove Patch related to Add CGCR reset property. -- Remove Patch related to Disable legacy path clock nodes. -- Add dt-bindings for missing properties. -- Change the order of nodes. -- Move digictal codec macro nodes to root node from soc node. -- Add adsp-pil-mode property in required clock nodes. Changes Since v1: -- Move remoteproc node to soc dtsi file. -- Add qcom, adsp-pil-mode reg property in lpasscc node. -- Fix typo errors. -- Remove redundant status properties. Srinivasa Rao Mandadapu (8): arm64: dts: qcom: sc7280: Modify lpasscc node name dt-bindings: remoteproc: qcom: sc7280-adsp-pil: Add missing properties arm64: dts: qcom: sc7280: Extract audio nodes from common idp dtsi file arm64: dts: qcom: sc7280: Add sound node for crd-rev3 board arm64: dts: qcom: sc7280: Add LPASS PIL node arm64: dts: qcom: sc7280: Modify VA/RX/TX macro clock nodes for audioreach solution arm64: dts: qcom: sc7280: Modify LPASS_MCC reg region size in the lpass_tlmm node arm64: dts: qcom: sc7280: Add qcom,adsp-pil-mode property in clock nodes .../remoteproc/qcom,sc7280-adsp-pil.yaml | 30 ++- .../arm64/boot/dts/qcom/sc7280-audio-idp.dtsi | 131 +++++++++ arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 1 + .../sc7280-herobrine-audioreach-wcd9385.dtsi | 253 ++++++++++++++++++ arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 122 --------- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 +- 6 files changed, 413 insertions(+), 128 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-audio-idp.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi -- 2.25.1

1 8

[tiwai-sound:topic/midi20 25/40] sound/core/seq/seq_clientmgr.c:482 snd_seq_read() error: copy_to_user() '&cell->event' too small (28 vs 32)
by Dan Carpenter 26 May '23

26 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: 46397622a3fa8372b8fda0f04b33d16923b03b1b [25/40] ALSA: seq: Add UMP support config: i386-randconfig-m021-20230525 (https://download.01.org/0day-ci/archive/20230526/202305261415.NY0vapZK-lkp@…) compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Reported-by: Dan Carpenter <error27(a)gmail.com> | Closes: https://lore.kernel.org/r/202305261415.NY0vapZK-lkp@intel.com/ smatch warnings: sound/core/seq/seq_clientmgr.c:482 snd_seq_read() error: copy_to_user() '&cell->event' too small (28 vs 32) vim +482 sound/core/seq/seq_clientmgr.c c7e0b5bf9fff1b Takashi Iwai 2005-11-17 407 static ssize_t snd_seq_read(struct file *file, char __user *buf, size_t count, c7e0b5bf9fff1b Takashi Iwai 2005-11-17 408 loff_t *offset) ^1da177e4c3f41 Linus Torvalds 2005-04-16 409 { c7e0b5bf9fff1b Takashi Iwai 2005-11-17 410 struct snd_seq_client *client = file->private_data; c7e0b5bf9fff1b Takashi Iwai 2005-11-17 411 struct snd_seq_fifo *fifo; 46397622a3fa83 Takashi Iwai 2023-05-23 412 size_t aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 413 int err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 414 long result = 0; c7e0b5bf9fff1b Takashi Iwai 2005-11-17 415 struct snd_seq_event_cell *cell; ^1da177e4c3f41 Linus Torvalds 2005-04-16 416 ^1da177e4c3f41 Linus Torvalds 2005-04-16 417 if (!(snd_seq_file_flags(file) & SNDRV_SEQ_LFLG_INPUT)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 418 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 419 96d4f267e40f95 Linus Torvalds 2019-01-03 420 if (!access_ok(buf, count)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 421 return -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 422 ^1da177e4c3f41 Linus Torvalds 2005-04-16 423 /* check client structures are in place */ 7eaa943c8ed8e9 Takashi Iwai 2008-08-08 424 if (snd_BUG_ON(!client)) 7eaa943c8ed8e9 Takashi Iwai 2008-08-08 425 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 426 f9a6bb841f7370 Takashi Iwai 2021-06-08 427 if (!client->accept_input) f9a6bb841f7370 Takashi Iwai 2021-06-08 428 return -ENXIO; f9a6bb841f7370 Takashi Iwai 2021-06-08 429 fifo = client->data.user.fifo; f9a6bb841f7370 Takashi Iwai 2021-06-08 430 if (!fifo) ^1da177e4c3f41 Linus Torvalds 2005-04-16 431 return -ENXIO; ^1da177e4c3f41 Linus Torvalds 2005-04-16 432 ^1da177e4c3f41 Linus Torvalds 2005-04-16 433 if (atomic_read(&fifo->overflow) > 0) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 434 /* buffer overflow is detected */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 435 snd_seq_fifo_clear(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 436 /* return error code */ ^1da177e4c3f41 Linus Torvalds 2005-04-16 437 return -ENOSPC; ^1da177e4c3f41 Linus Torvalds 2005-04-16 438 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 439 ^1da177e4c3f41 Linus Torvalds 2005-04-16 440 cell = NULL; ^1da177e4c3f41 Linus Torvalds 2005-04-16 441 err = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 442 snd_seq_fifo_lock(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 443 46397622a3fa83 Takashi Iwai 2023-05-23 444 if (client->midi_version > 0) 46397622a3fa83 Takashi Iwai 2023-05-23 445 aligned_size = sizeof(struct snd_seq_ump_event); 46397622a3fa83 Takashi Iwai 2023-05-23 446 else 46397622a3fa83 Takashi Iwai 2023-05-23 447 aligned_size = sizeof(struct snd_seq_event); 46397622a3fa83 Takashi Iwai 2023-05-23 448 ^1da177e4c3f41 Linus Torvalds 2005-04-16 449 /* while data available in queue */ 46397622a3fa83 Takashi Iwai 2023-05-23 450 while (count >= aligned_size) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 451 int nonblock; ^1da177e4c3f41 Linus Torvalds 2005-04-16 452 ^1da177e4c3f41 Linus Torvalds 2005-04-16 453 nonblock = (file->f_flags & O_NONBLOCK) || result > 0; f9a6bb841f7370 Takashi Iwai 2021-06-08 454 err = snd_seq_fifo_cell_out(fifo, &cell, nonblock); f9a6bb841f7370 Takashi Iwai 2021-06-08 455 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 456 break; 46397622a3fa83 Takashi Iwai 2023-05-23 457 if (!event_is_compatible(client, &cell->event)) { 46397622a3fa83 Takashi Iwai 2023-05-23 458 snd_seq_cell_free(cell); 46397622a3fa83 Takashi Iwai 2023-05-23 459 cell = NULL; 46397622a3fa83 Takashi Iwai 2023-05-23 460 continue; 46397622a3fa83 Takashi Iwai 2023-05-23 461 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 462 if (snd_seq_ev_is_variable(&cell->event)) { Smatch isn't clever enough to know that if snd_seq_ev_is_variable() is false that means client->midi_version is zero. 46397622a3fa83 Takashi Iwai 2023-05-23 463 struct snd_seq_ump_event tmpev; 46397622a3fa83 Takashi Iwai 2023-05-23 464 46397622a3fa83 Takashi Iwai 2023-05-23 465 memcpy(&tmpev, &cell->event, aligned_size); ^1da177e4c3f41 Linus Torvalds 2005-04-16 466 tmpev.data.ext.len &= ~SNDRV_SEQ_EXT_MASK; 46397622a3fa83 Takashi Iwai 2023-05-23 467 if (copy_to_user(buf, &tmpev, aligned_size)) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 468 err = -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 469 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 470 } 46397622a3fa83 Takashi Iwai 2023-05-23 471 count -= aligned_size; 46397622a3fa83 Takashi Iwai 2023-05-23 472 buf += aligned_size; 4d23359b7ec8b0 Clemens Ladisch 2005-09-05 473 err = snd_seq_expand_var_event(&cell->event, count, 4d23359b7ec8b0 Clemens Ladisch 2005-09-05 474 (char __force *)buf, 0, 46397622a3fa83 Takashi Iwai 2023-05-23 475 aligned_size); ^1da177e4c3f41 Linus Torvalds 2005-04-16 476 if (err < 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 477 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 478 result += err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 479 count -= err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 480 buf += err; ^1da177e4c3f41 Linus Torvalds 2005-04-16 481 } else { 46397622a3fa83 Takashi Iwai 2023-05-23 @482 if (copy_to_user(buf, &cell->event, aligned_size)) { So smatch complains that this might be a read overflow. ^1da177e4c3f41 Linus Torvalds 2005-04-16 483 err = -EFAULT; ^1da177e4c3f41 Linus Torvalds 2005-04-16 484 break; ^1da177e4c3f41 Linus Torvalds 2005-04-16 485 } 46397622a3fa83 Takashi Iwai 2023-05-23 486 count -= aligned_size; 46397622a3fa83 Takashi Iwai 2023-05-23 487 buf += aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 488 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 489 snd_seq_cell_free(cell); ^1da177e4c3f41 Linus Torvalds 2005-04-16 490 cell = NULL; /* to be sure */ 46397622a3fa83 Takashi Iwai 2023-05-23 491 result += aligned_size; ^1da177e4c3f41 Linus Torvalds 2005-04-16 492 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 493 ^1da177e4c3f41 Linus Torvalds 2005-04-16 494 if (err < 0) { ^1da177e4c3f41 Linus Torvalds 2005-04-16 495 if (cell) ^1da177e4c3f41 Linus Torvalds 2005-04-16 496 snd_seq_fifo_cell_putback(fifo, cell); ^1da177e4c3f41 Linus Torvalds 2005-04-16 497 if (err == -EAGAIN && result > 0) ^1da177e4c3f41 Linus Torvalds 2005-04-16 498 err = 0; ^1da177e4c3f41 Linus Torvalds 2005-04-16 499 } ^1da177e4c3f41 Linus Torvalds 2005-04-16 500 snd_seq_fifo_unlock(fifo); ^1da177e4c3f41 Linus Torvalds 2005-04-16 501 ^1da177e4c3f41 Linus Torvalds 2005-04-16 502 return (err < 0) ? err : result; ^1da177e4c3f41 Linus Torvalds 2005-04-16 503 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0

[tiwai-sound:topic/midi20 9/40] sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16
by kernel test robot 25 May '23

25 May '23

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/midi20 head: 77700b81bd0e47d89d50eb4b3f2f323492f79998 commit: ff49d1df79aef7580fe3ac99d17c3f886655d080 [9/40] ALSA: usb-audio: USB MIDI 2.0 UMP support config: openrisc-randconfig-s051-20230525 compiler: or1k-linux-gcc (GCC) 12.1.0 reproduce: mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add tiwai-sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags tiwai-sound topic/midi20 git checkout ff49d1df79aef7580fe3ac99d17c3f886655d080 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 ~/bin/make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=openrisc SHELL=/bin/bash sound/usb/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp(a)intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202305260528.wcqjXso8-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 >> sound/usb/midi2.c:548:16: sparse: sparse: cast to restricted __le16 vim +548 sound/usb/midi2.c 530 531 /* get the full group terminal block descriptors and return the size */ 532 static int get_group_terminal_block_descs(struct snd_usb_midi2_interface *umidi) 533 { 534 struct usb_host_interface *hostif = umidi->hostif; 535 struct usb_device *dev = umidi->chip->dev; 536 struct usb_ms20_gr_trm_block_header_descriptor header = { 0 }; 537 unsigned char *data; 538 int err, size; 539 540 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 541 USB_REQ_GET_DESCRIPTOR, 542 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 543 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 544 hostif->desc.bInterfaceNumber, 545 &header, sizeof(header)); 546 if (err < 0) 547 return err; > 548 size = __le16_to_cpu(header.wTotalLength); 549 if (!size) { 550 dev_err(&dev->dev, "Failed to get GTB descriptors for %d:%d\n", 551 hostif->desc.bInterfaceNumber, hostif->desc.bAlternateSetting); 552 return -EINVAL; 553 } 554 555 data = kzalloc(size, GFP_KERNEL); 556 if (!data) 557 return -ENOMEM; 558 559 err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), 560 USB_REQ_GET_DESCRIPTOR, 561 USB_RECIP_INTERFACE | USB_TYPE_STANDARD | USB_DIR_IN, 562 USB_DT_CS_GR_TRM_BLOCK << 8 | hostif->desc.bAlternateSetting, 563 hostif->desc.bInterfaceNumber, data, size); 564 if (err < 0) { 565 kfree(data); 566 return err; 567 } 568 569 umidi->blk_descs = data; 570 umidi->blk_desc_size = size; 571 return 0; 572 } 573 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

1 0