April 2023 - Alsa-devel - mailman.alsa-project.org

[PATCH v2] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
by Randy Dunlap 29 Apr '23

29 Apr '23

Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Grant Likely <grant.likely(a)secretlab.ca> Cc: Mark Brown <broonie(a)kernel.org> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Shengjiu Wang <shengjiu.wang(a)gmail.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> --- v2: use correct email address for Mark Brown. sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help

1 0

[PATCH] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
by Randy Dunlap 29 Apr '23

29 Apr '23

Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> Cc: Grant Likely <grant.likely(a)secretlab.ca> Cc: Mark Brown <broonie(a)opensource.wolfsonmicro.com> Cc: Liam Girdwood <lgirdwood(a)gmail.com> Cc: Shengjiu Wang <shengjiu.wang(a)gmail.com> Cc: Xiubo Li <Xiubo.Lee(a)gmail.com> Cc: alsa-devel(a)alsa-project.org Cc: linuxppc-dev(a)lists.ozlabs.org Cc: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com> --- sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help

1 0

Updated single and double quotes throughout
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #208 was opened from wileyhy: Added double quotes to common expansions; removed quotes from strings; changed REQUIRES to an indexed array and changed the corresponding for loop; added curly braces where feasibly necessary; removed a few unnecessary trailing semi-colons; and put URL's in single quotes to prevent any possible expansions, except for within the sed command. Some logic structures depend on word splitting, so I left those as-is for this commit. Double exclamation marks in double quotes allow history expansion which is usually disabled in non-interactive shells, so I left those as-is also. Request URL : https://github.com/alsa-project/alsa-utils/pull/208 Patch URL : https://github.com/alsa-project/alsa-utils/pull/208.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

reduce execs by four, and eliminate a logic bug
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #207 was opened from wileyhy: Per `info uname`, uname always prints its data in the same order. Also, from [SC2015](https://www.shellcheck.net/wiki/SC2015), > "Note that A && B || C is not if-then-else. C may run when A is true." `set -x; read -r KERNEL_VERSION < <(uname -v); smp=x; [[ "$KERNEL_VERSION" = SMP ]] && { smp=y; readonly smp; false;} || smp=n; set -` Request URL : https://github.com/alsa-project/alsa-utils/pull/207 Patch URL : https://github.com/alsa-project/alsa-utils/pull/207.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Update `test` '-a' and '-o' to '&&' and '||'
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #206 was opened from wileyhy: lines 50, 103: in two compound ['s, replace '-a' with '] && [' SC2166 – Prefer `[ p ] && [ q ]` as `[ p -a q ]` is not well defined. SC2107 – Instead of `[ a && b ]`, use `[ a ] && [ b ]`. line 45: in a compound test command, change '-o' to '|| test' SC1139 – Use `||` instead of `-o` between test commands. SC2109 – Instead of `[ a || b ]`, use `[ a ] || [ b ]`. https://www.shellcheck.net/wiki/SC[0-9]{4} Request URL : https://github.com/alsa-project/alsa-utils/pull/206 Patch URL : https://github.com/alsa-project/alsa-utils/pull/206.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

reduce `exec`s by four, and eliminate logic bug
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #205 was opened from wileyhy: Per `info uname,` `uname` always prints its data in the same order. Also, "note that A && B || C is not if-then-else. C may run when A is true." https://www.shellcheck.net/wiki/SC2015 set -x; read -r KERNEL_VERSION < <(uname -v); smp=x; [[ "$KERNEL_VERSION" = *SMP* ]] && { smp=y; readonly smp; false;} || smp=n; set - Request URL : https://github.com/alsa-project/alsa-utils/pull/205 Patch URL : https://github.com/alsa-project/alsa-utils/pull/205.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

change '-o' in a `test` command to `|| test`
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #204 was opened from wileyhy: this syntax functions locally Request URL : https://github.com/alsa-project/alsa-utils/pull/204 Patch URL : https://github.com/alsa-project/alsa-utils/pull/204.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

Updated single and double quotes throughout
by GitHub pull_request - opened 29 Apr '23

29 Apr '23

alsa-project/alsa-utils pull request #203 was opened from wileyhy: Added double quotes to common expansions; removed quotes from strings; changed REQUIRES to an indexed array and changed the corresponding `for` loop; added curly braces where feasibly necessary; removed a few unnecessary trailing semi-colons; and put URL's in single quotes to prevent any possible expansions, except for within the `sed` command. Some logic structures depend on word splitting, so I left those as-is for this commit. Double exclamation marks in double quotes allow history expansion which is usually disabled in non-interactive shells, so I left those as-is also. Request URL : https://github.com/alsa-project/alsa-utils/pull/203 Patch URL : https://github.com/alsa-project/alsa-utils/pull/203.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

in a compound `test` command, change '-o' to '||'
by GitHub pull_request - opened 28 Apr '23

28 Apr '23

alsa-project/alsa-utils pull request #202 was opened from wileyhy: Per a shellcheck warning https://www.shellcheck.net/wiki/SC1139 Request URL : https://github.com/alsa-project/alsa-utils/pull/202 Patch URL : https://github.com/alsa-project/alsa-utils/pull/202.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

in two compound `[`'s, replace '-a' with '] && ['
by GitHub pull_request - opened 28 Apr '23

28 Apr '23

alsa-project/alsa-utils pull request #201 was opened from wileyhy: Per shellcheck warnings. https://www.shellcheck.net/wiki/SC2166 Request URL : https://github.com/alsa-project/alsa-utils/pull/201 Patch URL : https://github.com/alsa-project/alsa-utils/pull/201.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0