July 2022 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH] sound: qcom: Fix missing of_node_put() in asoc_qcom_lpass_cpu_platform_probe()
by Mark Brown 04 Jul '22

04 Jul '22

On Sat, Jul 02, 2022 at 10:01:09AM +0800, Liang He wrote: > We should call of_node_put() for the reference 'dsp_of_node' returned by > of_parse_phandle() which will increase the refcount. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

2 1

Re: [PATCH 1/2] ALSA: usb-audio: Add quirk for Fiero SC-01
by Takashi Iwai 04 Jul '22

04 Jul '22

On Mon, 27 Jun 2022 12:00:34 +0200, Egor Vorontsov wrote: > > Fiero SC-01 is a USB sound card with two mono inputs and a single > stereo output. The inputs are composed into a single stereo stream. > > The device uses a vendor-provided driver on Windows and does not work > at all without it. The driver mostly provides ASIO functionality, but > also alters the way the sound card is queried for sample rates and > clocks. > > ALSA queries those failing with an EPIPE (same as Windows 10 does). > Presumably, the vendor-provided driver does not query it at all, simply > matching by VID:PID. Thus, I consider this a buggy firmware and adhere > to a set of fixed endpoint quirks instead. > > The soundcard has an internal clock. Implicit feedback mode is required > for the playback. > > I have updated my device to v1.1.0 from a Windows 10 VM using a vendor- > provided binary prior to the development, hoping for it to just begin > working. The device provides no obvious way to downgrade the firmware, > and regardless, there's no binary available for v1.0.0 anyway. > > Thus, I will be getting another unit to extend the patch with support > for that. Expected to be a simple copy-paste of the existing one, > though. > > There were no previous reports of that device in context of Linux > anywhere. Other issues have been reported though, but that's out of the > scope. > > Signed-off-by: Egor Vorontsov <sdoregor(a)sdore.me> Thanks, now applied both patches. Takashi

1 0

[PATCH v2] ALSA: hda/realtek: Add quirk for Clevo L140PU
by Tim Crawford 04 Jul '22

04 Jul '22

Fixes headset detection on Clevo L140PU. Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index cee69fa7e246..007dd8b5e1f2 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9212,6 +9212,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1558, 0x70f4, "Clevo NH77EPY", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x70f6, "Clevo NH77DPQ-Y", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x7716, "Clevo NS50PU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x7718, "Clevo L140PU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x8228, "Clevo NR40BU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x8520, "Clevo NH50D[CD]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1558, 0x8521, "Clevo NH77D[CD]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), -- 2.35.3

2 1

[PATCH] ALSA: usb-audio: Add quirks for MacroSilicon MS2100/MS2106 devices
by John Veness 04 Jul '22

04 Jul '22

Treat the claimed 96kHz 1ch in the descriptors as 48kHz 2ch, so that the audio stream doesn't sound mono. Also fix initial stream alignment, so that left and right channels are in the correct order. Signed-off-by: John Veness <john-linux(a)pelago.org.uk> --- sound/usb/quirks-table.h | 48 ++++++++++++++++++++++++++++++++++++++++ sound/usb/quirks.c | 3 +++ 2 files changed, 51 insertions(+) diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index 4f56e1784932..853da162fd18 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h @@ -3802,6 +3802,54 @@ YAMAHA_DEVICE(0x7010, "UB99"), } }, +/* + * MacroSilicon MS2100/MS2106 based AV capture cards + * + * These claim 96kHz 1ch in the descriptors, but are actually 48kHz 2ch. + * They also need QUIRK_FLAG_ALIGN_TRANSFER, which makes one wonder if + * they pretend to be 96kHz mono as a workaround for stereo being broken + * by that... + * + * They also have an issue with initial stream alignment that causes the + * channels to be swapped and out of phase, which is dealt with in quirks.c. + */ +{ + USB_AUDIO_DEVICE(0x534d, 0x0021), + .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { + .vendor_name = "MacroSilicon", + .product_name = "MS210x", + .ifnum = QUIRK_ANY_INTERFACE, + .type = QUIRK_COMPOSITE, + .data = &(const struct snd_usb_audio_quirk[]) { + { + .ifnum = 2, + .type = QUIRK_AUDIO_STANDARD_MIXER, + }, + { + .ifnum = 3, + .type = QUIRK_AUDIO_FIXED_ENDPOINT, + .data = &(const struct audioformat) { + .formats = SNDRV_PCM_FMTBIT_S16_LE, + .channels = 2, + .iface = 3, + .altsetting = 1, + .altset_idx = 1, + .attributes = 0, + .endpoint = 0x82, + .ep_attr = USB_ENDPOINT_XFER_ISOC | + USB_ENDPOINT_SYNC_ASYNC, + .rates = SNDRV_PCM_RATE_CONTINUOUS, + .rate_min = 48000, + .rate_max = 48000, + } + }, + { + .ifnum = -1 + } + } + } +}, + /* * MacroSilicon MS2109 based HDMI capture cards * diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index e8468f9b007d..a72874bc0936 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1478,6 +1478,7 @@ void snd_usb_set_format_quirk(struct snd_usb_substream *subs, case USB_ID(0x041e, 0x3f19): /* E-Mu 0204 USB */ set_format_emu_quirk(subs, fmt); break; + case USB_ID(0x534d, 0x0021): /* MacroSilicon MS2100/MS2106 */ case USB_ID(0x534d, 0x2109): /* MacroSilicon MS2109 */ subs->stream_offset_adj = 2; break; @@ -1904,6 +1905,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { QUIRK_FLAG_IGNORE_CTL_ERROR), DEVICE_FLG(0x413c, 0xa506, /* Dell AE515 sound bar */ QUIRK_FLAG_GET_SAMPLE_RATE), + DEVICE_FLG(0x534d, 0x0021, /* MacroSilicon MS2100/MS2106 */ + QUIRK_FLAG_ALIGN_TRANSFER), DEVICE_FLG(0x534d, 0x2109, /* MacroSilicon MS2109 */ QUIRK_FLAG_ALIGN_TRANSFER), DEVICE_FLG(0x1224, 0x2a25, /* Jieli Technology USB PHY 2.0 */ -- 2.34.1

2 1

[PATCH] ALSA: hda: add CSC3551 support for UM5302TA
by xhe 04 Jul '22

04 Jul '22

From: He Wang <xw897002528(a)gmail.com> ASUS UM5302TA are using csc3551, or cs35l41, which is connected to the laptop by I2C bus. This patch adds quirk for the sound card, and avoid ACPI DSD things for i2c-multi-instantiate cases like CLSA0100. Patch is made by XiaoYan Li. It is tested by us on ASUS UM5302TA. Signed-off-by: He Wang <xw897002528(a)gmail.com> Signed-off-by: Xiaoyan Li <lxy.lixiaoyan(a)gmail.com> --- sound/pci/hda/cs35l41_hda.c | 2 +- sound/pci/hda/patch_realtek.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index cce27a86267f..7374565ecf15 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -420,7 +420,7 @@ static int cs35l41_hda_read_acpi(struct cs35l41_hda *cs35l41, const char *hid, i * And devm functions expect that the device requesting the resource has the correct * fwnode. */ - if (strncmp(hid, "CLSA0100", 8) != 0) + if (strncmp(hid, "CLSA0100", 8) != 0 && strncmp(hid, "CSC3551", 7) != 0) return -EINVAL; /* check I2C address to assign the index */ diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index cee69fa7e246..49c27d948582 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9138,6 +9138,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), + SND_PCI_QUIRK(0x1043, 0x1f12, "ASUS UM5302TA", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2), SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC), -- 2.33.0

2 1

failed to import acp5x use case configuration -2
by GitHub issues - opened 04 Jul '22

04 Jul '22

alsa-project/alsa-ucm-conf issue #184 was opened from DocMAX: docmax@steamdeck: ~ $ ALSA_CONFIG_UCM=/usr/share/alsa/ucm2/ alsaucm -c acp5x set _verb HiFi ALSA lib main.c:1541:(snd_use_case_mgr_open) error: failed to import acp5x use case configuration -2 alsaucm: error failed to open sound card acp5x: No such file or directory Why does it fail? I have the following directory set up: /usr/share/alsa/ucm2/conf.d/acp5x/HiFi.conf /usr/share/alsa/ucm2/conf.d/acp5x/acp5x.conf Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/184 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Re: [syzbot] KASAN: use-after-free Read in snd_rawmidi_transmit
by syzbot 04 Jul '22

04 Jul '22

syzbot suspects this issue was fixed by commit: commit 0125de38122f0f66bf61336158d12a1aabfe6425 Author: Takashi Iwai <tiwai(a)suse.de> Date: Wed May 25 13:12:03 2022 +0000 ALSA: usb-audio: Cancel pending work at closing a MIDI substream bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1180b25c080000 start commit: 2a5699b0de4e Merge tag 'leds-5.19-rc1' of git://git.kernel.. git tree: upstream kernel config: https://syzkaller.appspot.com/x/.config?x=f915857c44e13980 dashboard link: https://syzkaller.appspot.com/bug?extid=39e3268af9968f153591 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=119d1fcbf00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17716bedf00000 If the result looks correct, please mark the issue as fixed by replying with: #syz fix: ALSA: usb-audio: Cancel pending work at closing a MIDI substream For information about bisection process see: https://goo.gl/tpsmEJ#bisection

2 1

[PATCH] soundwire: bus_type: fix remove and shutdown support
by Bard Liao 04 Jul '22

04 Jul '22

From: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> The bus sdw_drv_remove() and sdw_drv_shutdown() helpers are used conditionally, if the driver provides these routines. These helpers already test if the driver provides a .remove or .shutdown callback, so there's no harm in invoking the sdw_drv_remove() and sdw_drv_shutdown() unconditionally. In addition, the current code is imbalanced with dev_pm_domain_attach() called from sdw_drv_probe(), but dev_pm_domain_detach() called from sdw_drv_remove() only if the driver provides a .remove callback. Fixes: 9251345dca24b ("soundwire: Add SoundWire bus type") Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> Reviewed-by: Rander Wang <rander.wang(a)intel.com> Signed-off-by: Bard Liao <yung-chuan.liao(a)linux.intel.com> --- drivers/soundwire/bus_type.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c index 893296f3fe39..b81e04dd3a9f 100644 --- a/drivers/soundwire/bus_type.c +++ b/drivers/soundwire/bus_type.c @@ -193,12 +193,8 @@ int __sdw_register_driver(struct sdw_driver *drv, struct module *owner) drv->driver.owner = owner; drv->driver.probe = sdw_drv_probe; - - if (drv->remove) - drv->driver.remove = sdw_drv_remove; - - if (drv->shutdown) - drv->driver.shutdown = sdw_drv_shutdown; + drv->driver.remove = sdw_drv_remove; + drv->driver.shutdown = sdw_drv_shutdown; return driver_register(&drv->driver); } -- 2.17.1

3 4

[RESEND v5 0/2] Add software clock gating requirement check
by Srinivasa Rao Mandadapu 04 Jul '22

04 Jul '22

This patch set is to add software clock gating requirement check Changes Since V4: -- Fix error check, after a reset control get api return -- Fix typo in commit message Changes Since V3: -- Remove redundant check before reset control call -- Reorganiaze patches. -- Fix typos. Changes Since V2: -- Fix if check before reset control call Changes Since V1: -- Use boolean flag for bool variable initialization instead of hard coding. Srinivasa Rao Mandadapu (2): soundwire: qcom: Add flag for software clock gating check ASoC: qcom: soundwire: Enable software clock gating requirement flag drivers/soundwire/qcom.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) -- 2.7.4

2 4

direct.conf fails to work if DirectCardName is not specified
by GitHub issues - opened 03 Jul '22

03 Jul '22

alsa-project/alsa-ucm-conf issue #183 was opened from brndd: The following error is produced when a card uses direct.conf but DirectCardName is not specified (with e.g. `Define { DirectCardName "UMC204HD" }` ``` $ spa-acp-tool -c 1 -vvvv info variable '${var:DirectCardName}' is not defined in this context! ``` Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/183 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0