Re: [PATCH] sound: qcom: Fix missing of_node_put() in asoc_qcom_lpass_cpu_platform_probe()
On Sat, Jul 02, 2022 at 10:01:09AM +0800, Liang He wrote:
We should call of_node_put() for the reference 'dsp_of_node' returned by of_parse_phandle() which will increase the refcount.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
At 2022-07-04 19:21:33, "Mark Brown" broonie@kernel.org wrote:
On Sat, Jul 02, 2022 at 10:01:09AM +0800, Liang He wrote:
We should call of_node_put() for the reference 'dsp_of_node' returned by of_parse_phandle() which will increase the refcount.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Thanks for your advice, I will follow this rule in future patch work.
Liang
participants (2)
-
Liang He -
Mark Brown