March 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/2] xen/grant-table: do some cleanup
by Juergen Gross 11 Mar '22

11 Mar '22

Cleanup grant table code by removing unused functionality. Juergen Gross (2): xen/grant-table: remove gnttab_*transfer*() functions xen/grant-table: remove readonly parameter from functions drivers/block/xen-blkfront.c | 8 +- drivers/char/tpm/xen-tpmfront.c | 2 +- drivers/gpu/drm/xen/xen_drm_front_evtchnl.c | 2 +- drivers/input/misc/xen-kbdfront.c | 4 +- drivers/net/xen-netfront.c | 13 +- drivers/pci/xen-pcifront.c | 2 +- drivers/scsi/xen-scsifront.c | 4 +- drivers/usb/host/xen-hcd.c | 4 +- drivers/xen/gntalloc.c | 2 +- drivers/xen/gntdev-dmabuf.c | 2 +- drivers/xen/grant-table.c | 151 +++----------------- drivers/xen/pvcalls-front.c | 6 +- drivers/xen/xen-front-pgdir-shbuf.c | 3 +- include/xen/grant_table.h | 13 +- net/9p/trans_xen.c | 8 +- sound/xen/xen_snd_front_evtchnl.c | 2 +- 16 files changed, 50 insertions(+), 176 deletions(-) -- 2.34.1

3 3

Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
by huangwenhui 11 Mar '22

11 Mar '22

Hi  Takashi, if adjusting the mixer element or replugging the headset, the headphone would be unmuted. But most users hope that the default state is unmuted. Should this unconditional unmute be required? Thanks. ------------------ Original ------------------ From:  "Takashi Iwai"<tiwai(a)suse.de>; Date:  Thu, Mar 10, 2022 10:03 PM To:  "黄文辉"<huangwenhuia(a)uniontech.com>; Cc:  "perex"<perex(a)perex.cz>; "tiwai"<tiwai(a)suse.com>; "jeremy.szu"<jeremy.szu(a)canonical.com>; "hui.wang"<hui.wang(a)canonical.com>; "wse"<wse(a)tuxedocomputers.com>; "cam"<cam(a)neo-zeon.de>; "kailang"<kailang(a)realtek.com>; "tanureal"<tanureal(a)opensource.cirrus.com>; "sami"<sami(a)loone.fi>; "alsa-devel"<alsa-devel(a)alsa-project.org>; "linux-kernel"<linux-kernel(a)vger.kernel.org>; Subject:  Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671   On Thu, 10 Mar 2022 14:58:36 +0100, huangwenhui wrote: > > Hi  Takashi, > > Thank you for your reply. > > When booting with plugged headset, the headphone will be muted. The muted state is the default behavior.  Wouldn't it be unmuted if you adjust the corresponding mixer element? Takashi > > Thanks. >  > ------------------ Original ------------------ > From:  "Takashi Iwai"<tiwai(a)suse.de>; > Date:  Thu, Mar 10, 2022 09:29 PM > To:  "huangwenhui"<huangwenhuia(a)uniontech.com>; > Cc:  "perex"<perex(a)perex.cz>; "tiwai"<tiwai(a)suse.com>; "jeremy.szu" > <jeremy.szu(a)canonical.com>; "hui.wang"<hui.wang(a)canonical.com>; "wse" > <wse(a)tuxedocomputers.com>; "cam"<cam(a)neo-zeon.de>; "kailang" > <kailang(a)realtek.com>; "tanureal"<tanureal(a)opensource.cirrus.com>; "sami" > <sami(a)loone.fi>; "alsa-devel"<alsa-devel(a)alsa-project.org>; "linux-kernel" > <linux-kernel(a)vger.kernel.org>; > Subject:  Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP > machine with alc671 >  > On Thu, 10 Mar 2022 14:03:01 +0100, > huangwenhui wrote: > > > > On a HP 288 Pro G8, the front Mic could not be detected. > > > > Signed-off-by: huangwenhui <huangwenhuia(a)uniontech.com> > > Thanks for the patch.  Most of the changes look OK, but one thing I > still don't get: > > > + case HDA_FIXUP_ACT_INIT: > > + alc_write_coef_idx(codec, 0x19, 0xa054); > > + msleep(80); > > + snd_hda_codec_write(codec, hp_pin, 0, > > +     AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); > > Why this unconditional unmute is required for fixing the mic problem? > > Takashi > >

2 2

[PATCH] ASoC: max98390: Add reset gpio control
by Steve Lee 11 Mar '22

11 Mar '22

Add reset gpio control to support RESET PIN connected to gpio. Signed-off-by: Steve Lee <steve.lee.analog(a)gmail.com> --- sound/soc/codecs/max98390.c | 18 ++++++++++++++++++ sound/soc/codecs/max98390.h | 1 + 2 files changed, 19 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index b392567c2b3e..574d8d5f1119 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc/codecs/max98390.c @@ -1073,6 +1073,24 @@ static int max98390_i2c_probe(struct i2c_client *i2c, return ret; } + max98390->reset_gpio = of_get_named_gpio(i2c->dev.of_node, + "maxim,reset-gpios", 0); + + /* Power on device */ + if (gpio_is_valid(max98390->reset_gpio)) { + ret = devm_gpio_request(&i2c->dev, max98390->reset_gpio, + "MAX98390_RESET"); + if (ret) { + dev_err(&i2c->dev, "%s: Failed to request gpio %d\n", + __func__, max98390->reset_gpio); + return -EINVAL; + } + gpio_direction_output(max98390->reset_gpio, 0); + usleep_range(1000, 2000); + gpio_direction_output(max98390->reset_gpio, 1); + usleep_range(1000, 2000); + } + /* Check Revision ID */ ret = regmap_read(max98390->regmap, MAX98390_R24FF_REV_ID, &reg); diff --git a/sound/soc/codecs/max98390.h b/sound/soc/codecs/max98390.h index c250740f73a2..5518f2340247 100644 --- a/sound/soc/codecs/max98390.h +++ b/sound/soc/codecs/max98390.h @@ -655,6 +655,7 @@ struct max98390_priv { struct regmap *regmap; + int reset_gpio; unsigned int sysclk; unsigned int master; unsigned int tdm_mode; -- 2.17.1

4 4

Presence of "default" device name crashes unity3d games
by GitHub issues - opened 11 Mar '22

11 Mar '22

alsa-project/alsa-lib issue #214 was opened from the3dfxdude: In a recent Slackware 15.0 distro release, the alsa-lib version is now 1.2.5.1. This causes a crash in Kerbal Space Program similar to issue #27. A change was made to close issue #27 in alsa-lib 1.2.3. That change did not correct the crash however in 1.2.3 or 1.2.5.1 in my case. This is the noted difference for "aplay -L" between 1.2.3 and 1.2.1: --- dump_1_2_1 2022-03-10 12:38:16.991433004 -0700 +++ dump_1_2_3 2022-03-10 12:37:53.467443226 -0700 @@ -1,5 +1,9 @@ null Discard all samples (playback) or generate zero samples (capture) +default + Default Audio Device +sysdefault + Default Audio Device default:CARD=IXP ATI IXP, ATI IXP AC97 Default Audio Device Removing this "default" device entry fixes the issue on this system. You may remove the default device name by editing src/conf/pcm/default.conf and adding under the hint section "omit_noargs true". Unity must be parsing the device name, and with certain device names, if there is no ':' doing something bad, as there is a pattern here on what it trips on. I have no idea how to get them to correct this, so opening the issue here at least for the record if anyone else has an issue with this. Also, I am not sure what triggers "default" to show. I did a survey and 3 out of 5 of my slackware 15.0 systems have it. And 2 do not. Does this have something to do with parsing the system alsa config and the available sound devices in the system? I don't define any asound.conf for any of these, so these are almost 100% stock slackware systems, there should otherwise be no difference. Issue URL : https://github.com/alsa-project/alsa-lib/issues/214 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[v2 0/2] ASoC: mediatek: mt8192: support rt1015p_rt5682s
by Jiaxin Yu 11 Mar '22

11 Mar '22

The series reuses mt8192-mt6359-rt10150rt5682.c for supporting machine driver with rt1015p speaker amplifier and rt5682s headset codec. Changes from v1: - uses the snd_soc_of_get_dai_link_codecs to complete the configuration of dai_link's codecs - uses definitions to simplifies card name and compatible name Jiaxin Yu (2): ASoC: dt-bindings: mt8192-mt6359: add new compatible for using rt1015p and rt5682 ASoC: mediatek: mt8192: support rt1015p_rt5682s .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 1 + sound/soc/mediatek/Kconfig | 1 + .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 204 +++++++++++------- 3 files changed, 129 insertions(+), 77 deletions(-) -- 2.18.0

3 5

[PATCH v3 00/16] Support external boost at CS35l41 ASoC driver
by Lucas Tanure 10 Mar '22

10 Mar '22

Move the support for CS35L41 external boost to its shared library for ASoC use. This move resulted in cs35l41_hda_reg_sequence being removed, and its steps were broken down into regmap writes or functions from the library. And hardware configuration struct was unified for its use in the shared lib. While at it, some minor bugs were found and fixed it. v3 changelog: - Remove patches already accepted - Improved logic in documentation patch - Documentation patch goes before its code - Fixed missing Signed-off-by - Fixed subject for HDA patches v2 changelog: - Instead of removing the log, playback actions will log the last regmap access. - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the provided example. Previous versions: v1: https://lkml.org/lkml/2022/3/3/759 v2: https://lkml.org/lkml/2022/3/4/743 David Rhodes (1): ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost Lucas Tanure (15): sound: cs35l41: Unify hardware configuration sound: cs35l41: Check hw_config before using it sound: cs35l41: Move cs35l41_gpio_config to shared lib ALSA: hda: cs35l41: Fix I2S params comments ALSA: hda: cs35l41: Always configure the DAI ALSA: hda: cs35l41: Add Boost type flag hda: cs35l41: Put the device into safe mode for external boost hda: cs35l41: Mute the device before shutdown sound: cs35l41: Enable Internal Boost in shared lib ALSA: hda: cs35l41: Move boost config to initialization code ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct ALSA: hda: cs35l41: Reorganize log for playback actions ALSA: hda: cs35l41: Handle all external boost setups the same way ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use ASoC: cs35l41: Support external boost .../bindings/sound/cirrus,cs35l41.yaml | 44 ++- include/sound/cs35l41.h | 53 +++- sound/pci/hda/cs35l41_hda.c | 295 ++++++------------ sound/pci/hda/cs35l41_hda.h | 27 +- sound/soc/codecs/cs35l41-i2c.c | 4 +- sound/soc/codecs/cs35l41-lib.c | 190 ++++++++++- sound/soc/codecs/cs35l41-spi.c | 4 +- sound/soc/codecs/cs35l41.c | 166 +++++----- sound/soc/codecs/cs35l41.h | 5 +- 9 files changed, 437 insertions(+), 351 deletions(-) -- 2.35.1

5 25

[bug report] ASoC: atmel: mchp-pdmc: add PDMC driver
by Dan Carpenter 10 Mar '22

10 Mar '22

Hello Codrin Ciubotariu, The patch 50291652af52: "ASoC: atmel: mchp-pdmc: add PDMC driver" from Mar 7, 2022, leads to the following Smatch static checker warning: sound/soc/atmel/mchp-pdmc.c:186 mchp_pdmc_af_put() warn: this array is probably non-NULL. 'uvalue->value.integer.value' sound/soc/atmel/mchp-pdmc.c 181 static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol, 182 struct snd_ctl_elem_value *uvalue) 183 { 184 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); 185 struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component); --> 186 bool af = uvalue->value.integer.value ? true : false; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ value is an array, not a pointer. It's always going to be non-NULL. 187 188 if (dd->audio_filter_en == af) 189 return 0; 190 191 dd->audio_filter_en = af; 192 193 return 1; 194 } regards, dan carpenter

2 1

[PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
by huangwenhui 10 Mar '22

10 Mar '22

On a HP 288 Pro G8, the front Mic could not be detected. Signed-off-by: huangwenhui <huangwenhuia(a)uniontech.com> --- sound/pci/hda/patch_realtek.c | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3a42457984e9..bcd56cdc07af 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -10519,6 +10519,37 @@ static void alc671_fixup_hp_headset_mic2(struct hda_codec *codec, } } +static void alc671_fixup_hp288_headset_mic2(struct hda_codec *codec, + const struct hda_fixup *fix, int action) +{ + struct alc_spec *spec = codec->spec; + hda_nid_t hp_pin = alc_get_hp_pin(spec); + + static const struct hda_pintbl pincfgs[] = { + { 0x19, 0x02a11040 }, /* use as headset mic, with its own jack detect */ + { 0x1b, 0x0181304f }, + { } + }; + + if (!hp_pin) + hp_pin = 0x21; + + switch (action) { + case HDA_FIXUP_ACT_PRE_PROBE: + spec->gen.mixer_nid = 0; + spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; + snd_hda_apply_pincfgs(codec, pincfgs); + break; + case HDA_FIXUP_ACT_INIT: + alc_write_coef_idx(codec, 0x19, 0xa054); + msleep(80); + snd_hda_codec_write(codec, hp_pin, 0, + AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE); + msleep(100); + break; + } +} + static void alc897_hp_automute_hook(struct hda_codec *codec, struct hda_jack_callback *jack) { @@ -10615,6 +10646,7 @@ enum { ALC669_FIXUP_ACER_ASPIRE_ETHOS, ALC669_FIXUP_ACER_ASPIRE_ETHOS_HEADSET, ALC671_FIXUP_HP_HEADSET_MIC2, + ALC671_FIXUP_HP288_HEADSET_MIC2, ALC662_FIXUP_ACER_X2660G_HEADSET_MODE, ALC662_FIXUP_ACER_NITRO_HEADSET_MODE, ALC668_FIXUP_ASUS_NO_HEADSET_MIC, @@ -10986,6 +11018,10 @@ static const struct hda_fixup alc662_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc671_fixup_hp_headset_mic2, }, + [ALC671_FIXUP_HP288_HEADSET_MIC2] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc671_fixup_hp288_headset_mic2, + }, [ALC662_FIXUP_ACER_X2660G_HEADSET_MODE] = { .type = HDA_FIXUP_PINS, .v.pins = (const struct hda_pintbl[]) { @@ -11067,6 +11103,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800), SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2), + SND_PCI_QUIRK(0x103c, 0x885f, "HP 288 Pro G8", ALC671_FIXUP_HP288_HEADSET_MIC2), SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE), SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50), SND_PCI_QUIRK(0x1043, 0x129d, "Asus N750", ALC662_FIXUP_ASUS_Nx50), -- 2.20.1

3 3

[PATCH] ASoC: meson: aiu: fix duplicate debugfs directory error
by Heiner Kallweit 10 Mar '22

10 Mar '22

On a S905W-based system I get the following error: debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present! Turned out that multiple components having the same name triggers this error in soc_init_component_debugfs(). With the patch the error is gone and that's the debugfs entries. /sys/kernel/debug/asoc/P230-Q200/aiu_acodec:c1105400.audio-controller /sys/kernel/debug/asoc/P230-Q200/aiu_hdmi:c1105400.audio-controller /sys/kernel/debug/asoc/P230-Q200/aiu_cpu:c1105400.audio-controller Because debugfs is affected only, this may not be something for stable. Signed-off-by: Heiner Kallweit <hkallweit1(a)gmail.com> --- sound/soc/meson/aiu.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/meson/aiu.c b/sound/soc/meson/aiu.c index d299a70db..c1a2aea5f 100644 --- a/sound/soc/meson/aiu.c +++ b/sound/soc/meson/aiu.c @@ -68,6 +68,20 @@ int aiu_of_xlate_dai_name(struct snd_soc_component *component, *dai_name = dai->driver->name; + switch (component_id) { + case AIU_CPU: + component->debugfs_prefix = "aiu_cpu"; + break; + case AIU_HDMI: + component->debugfs_prefix = "aiu_hdmi"; + break; + case AIU_ACODEC: + component->debugfs_prefix = "aiu_acodec"; + break; + default: + break; + } + return 0; } -- 2.35.1

4 4

[PATCH v3] ALSA: hda/i915 - avoid hung task timeout in i915 wait
by Kai Vehmanen 10 Mar '22

10 Mar '22

If kernel is built with hung task detection enabled and CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set to less than 60 seconds, snd_hdac_i915_init() will trigger the hung task timeout in case i915 is not available and taint the kernel. Use wait_for_completion_killable_timeout() for the wait to avoid this problem. Co-developed-by: Ramalingam C <ramalingam.c(a)intel.com> Signed-off-by: Ramalingam C <ramalingam.c(a)intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/hda/hdac_i915.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changes V2->V3: - drop the loop and just use wait_for_completion_killable_timeout() (feedback from Tvrtko Ursulin) - new approach, so dropped the previous reviewed-by tags diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c index 454474ac5716..efe810af28c5 100644 --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -160,8 +160,8 @@ int snd_hdac_i915_init(struct hdac_bus *bus) if (!IS_ENABLED(CONFIG_MODULES) || !request_module("i915")) { /* 60s timeout */ - wait_for_completion_timeout(&acomp->master_bind_complete, - msecs_to_jiffies(60 * 1000)); + wait_for_completion_killable_timeout(&acomp->master_bind_complete, + msecs_to_jiffies(60 * 1000)); } } if (!acomp->ops) { base-commit: 3a0099a1909dea6022690b0ae496938dd2e5771c -- 2.35.1

3 2