March 2022 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/5] ASoC: mediatek: Add support for MT8195 sound card with max98390 and rt5682
by Trevor Wu 14 Mar '22

14 Mar '22

This series of patches adds support for mt8195 board with mt6359, max98390 and rt5682. Reset controller is included because mt8195 etdm is used to play sound via max98390 before kernel boot. In addition, the common part of machine driver is extracted for simplification. Patches are based on broonie tree "for-next" branch. Trevor Wu (5): ASoC: mediatek: mt8195: add reset controller dt-bindings: mediatek: mt8195: add reset property ASoC: mediatek: mt8195: common code for mt8195 machine driver ASoC: mediatek: mt8195: add machine driver with mt6359, max98390 and rt5682 dt-bindings: mediatek: mt8195: add mt8195-mt6359-max98390-rt5682 document .../bindings/sound/mt8195-afe-pcm.yaml | 10 + .../sound/mt8195-mt6359-max98390-rt5682.yaml | 61 + sound/soc/mediatek/Kconfig | 16 + sound/soc/mediatek/mt8195/Makefile | 17 +- sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 16 + .../mediatek/mt8195/mt8195-mt6359-common.c | 398 +++++++ .../mediatek/mt8195/mt8195-mt6359-common.h | 30 + .../mt8195/mt8195-mt6359-max98390-rt5682.c | 1058 +++++++++++++++++ .../mt8195/mt8195-mt6359-rt1011-rt5682.c | 406 +------ .../mt8195/mt8195-mt6359-rt1019-rt5682.c | 409 +------ 10 files changed, 1618 insertions(+), 803 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/mt8195-mt6359-max98390-rt5682.yaml create mode 100644 sound/soc/mediatek/mt8195/mt8195-mt6359-common.c create mode 100644 sound/soc/mediatek/mt8195/mt8195-mt6359-common.h create mode 100644 sound/soc/mediatek/mt8195/mt8195-mt6359-max98390-rt5682.c -- 2.18.0

4 15

[PATCH] ASoC: dt-bindings: Fix patternProperties with fixed strings
by Rob Herring 14 Mar '22

14 Mar '22

The simple-audio-card and renesas,rsnd bindings used 'patternProperties' with fixed strings to work-around a dtschema meta-schema limitation. This is now fixed and the schemas can be fixed to use 'properties' instead. Signed-off-by: Rob Herring <robh(a)kernel.org> --- .../bindings/sound/renesas,rsnd.yaml | 16 ++++--- .../bindings/sound/simple-card.yaml | 42 +++++++++---------- 2 files changed, 28 insertions(+), 30 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml index c2930d65728e..e17c0245f77a 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml @@ -123,9 +123,7 @@ properties: $ref: audio-graph-port.yaml# unevaluatedProperties: false -# use patternProperties to avoid naming "xxx,yyy" issue -patternProperties: - "^rcar_sound,dvc$": + rcar_sound,dvc: description: DVC subnode. type: object patternProperties: @@ -141,7 +139,7 @@ patternProperties: - dma-names additionalProperties: false - "^rcar_sound,mix$": + rcar_sound,mix: description: MIX subnode. type: object patternProperties: @@ -150,7 +148,7 @@ patternProperties: # no properties additionalProperties: false - "^rcar_sound,ctu$": + rcar_sound,ctu: description: CTU subnode. type: object patternProperties: @@ -159,7 +157,7 @@ patternProperties: # no properties additionalProperties: false - "^rcar_sound,src$": + rcar_sound,src: description: SRC subnode. type: object patternProperties: @@ -182,7 +180,7 @@ patternProperties: - dma-names additionalProperties: false - "^rcar_sound,ssiu$": + rcar_sound,ssiu: description: SSIU subnode. type: object patternProperties: @@ -202,7 +200,7 @@ patternProperties: - dma-names additionalProperties: false - "^rcar_sound,ssi$": + rcar_sound,ssi: description: SSI subnode. type: object patternProperties: @@ -239,7 +237,7 @@ patternProperties: additionalProperties: false # For DAI base - "^rcar_sound,dai$": + rcar_sound,dai: description: DAI subnode. type: object patternProperties: diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml index 45fd9fd9eb54..103044bd32eb 100644 --- a/Documentation/devicetree/bindings/sound/simple-card.yaml +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml @@ -156,45 +156,45 @@ properties: description: User specified audio sound card name. $ref: /schemas/types.yaml#/definitions/string -# use patternProperties to avoid naming "xxx,yyy" issue -patternProperties: - "^simple-audio-card,widgets$": + simple-audio-card,widgets: $ref: "#/definitions/widgets" - "^simple-audio-card,routing$": + simple-audio-card,routing: $ref: "#/definitions/routing" - "^simple-audio-card,cpu(@[0-9a-f]+)?": - $ref: "#/definitions/dai" - "^simple-audio-card,codec(@[0-9a-f]+)?": - $ref: "#/definitions/dai" # common properties - "^simple-audio-card,frame-master$": + simple-audio-card,frame-master: $ref: "#/definitions/frame-master" - "^simple-audio-card,bitclock-master$": + simple-audio-card,bitclock-master: $ref: "#/definitions/bitclock-master" - "^simple-audio-card,frame-inversion$": + simple-audio-card,frame-inversion: $ref: "#/definitions/frame-inversion" - "^simple-audio-card,bitclock-inversion$": + simple-audio-card,bitclock-inversion: $ref: "#/definitions/bitclock-inversion" - "^simple-audio-card,format$": + simple-audio-card,format: $ref: "#/definitions/format" - "^simple-audio-card,mclk-fs$": + simple-audio-card,mclk-fs: $ref: "#/definitions/mclk-fs" - "^simple-audio-card,aux-devs$": + simple-audio-card,aux-devs: $ref: "#/definitions/aux-devs" - "^simple-audio-card,convert-rate$": + simple-audio-card,convert-rate: $ref: "#/definitions/convert-rate" - "^simple-audio-card,convert-channels$": + simple-audio-card,convert-channels: $ref: "#/definitions/convert-channels" - "^simple-audio-card,prefix$": + simple-audio-card,prefix: $ref: "#/definitions/prefix" - "^simple-audio-card,pin-switches$": + simple-audio-card,pin-switches: $ref: "#/definitions/pin-switches" - "^simple-audio-card,hp-det-gpio$": + simple-audio-card,hp-det-gpio: maxItems: 1 - "^simple-audio-card,mic-det-gpio$": + simple-audio-card,mic-det-gpio: maxItems: 1 +patternProperties: + "^simple-audio-card,cpu(@[0-9a-f]+)?$": + $ref: "#/definitions/dai" + "^simple-audio-card,codec(@[0-9a-f]+)?$": + $ref: "#/definitions/dai" + "^simple-audio-card,dai-link(@[0-9a-f]+)?$": description: | Container for dai-link level properties and the CPU and CODEC sub-nodes. -- 2.32.0

3 2

[PATCH] ASoC: soc-compress: Change the check for codec_dai
by Jiasheng Jiang 14 Mar '22

14 Mar '22

It should be better to reverse the check on codec_dai and returned early in order to be easier to understand. Fixes: de2c6f98817f ("ASoC: soc-compress: prevent the potentially use of null pointer") Reported-by: kernel test robot <lkp(a)intel.com> Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Signed-off-by: Jiasheng Jiang <jiasheng(a)iscas.ac.cn> --- sound/soc/soc-compress.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index f4b376a71be8..e9dd25894dc0 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -567,16 +567,19 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num) return -EINVAL; } - /* check client and interface hw capabilities */ - if (codec_dai) { - if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK) && - snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) - playback = 1; - if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_CAPTURE) && - snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_CAPTURE)) - capture = 1; + if (!codec_dai) { + dev_err(rtd->card->dev, "Missing codec\n"); + return -EINVAL; } + /* check client and interface hw capabilities */ + if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK) && + snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_PLAYBACK)) + playback = 1; + if (snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_CAPTURE) && + snd_soc_dai_stream_valid(cpu_dai, SNDRV_PCM_STREAM_CAPTURE)) + capture = 1; + /* * Compress devices are unidirectional so only one of the directions * should be set, check for that (xor) -- 2.25.1

3 2

[PATCH] ALSA: cmipci: Restore aux vol on suspend/resume
by Jonathan Teh 14 Mar '22

14 Mar '22

Save and restore CM_REG_AUX_VOL instead of register 0x24 twice on suspend/resume. Tested on CMI8738LX. Fixes: cb60e5f5b2b1 ("[ALSA] cmipci - Add PM support") Signed-off-by: Jonathan Teh <jonathan.teh(a)outlook.com> --- sound/pci/cmipci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c index 9a678b5cf285..dab801d9d3b4 100644 --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -298,7 +298,6 @@ MODULE_PARM_DESC(joystick_port, "Joystick port address."); #define CM_MICGAINZ 0x01 /* mic boost */ #define CM_MICGAINZ_SHIFT 0 -#define CM_REG_MIXER3 0x24 #define CM_REG_AUX_VOL 0x26 #define CM_VAUXL_MASK 0xf0 #define CM_VAUXR_MASK 0x0f @@ -3265,7 +3264,7 @@ static int snd_cmipci_probe(struct pci_dev *pci, */ static const unsigned char saved_regs[] = { CM_REG_FUNCTRL1, CM_REG_CHFORMAT, CM_REG_LEGACY_CTRL, CM_REG_MISC_CTRL, - CM_REG_MIXER0, CM_REG_MIXER1, CM_REG_MIXER2, CM_REG_MIXER3, CM_REG_PLL, + CM_REG_MIXER0, CM_REG_MIXER1, CM_REG_MIXER2, CM_REG_AUX_VOL, CM_REG_PLL, CM_REG_CH0_FRAME1, CM_REG_CH0_FRAME2, CM_REG_CH1_FRAME1, CM_REG_CH1_FRAME2, CM_REG_EXT_MISC, CM_REG_INT_STATUS, CM_REG_INT_HLDCLR, CM_REG_FUNCTRL0, -- 2.35.1

2 1

[PATCH] ALSA: hda/realtek: Add quirk for ASUS GA402
by Jason Zheng 14 Mar '22

14 Mar '22

ASUS GA402 requires a workaround to manage the routing of its 4 speakers like the other ASUS models. Add a corresponding quirk entry to fix it. Signed-off-by: Jason Zheng <jasonzheng2004(a)gmail.com> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3a42457984e9..ec67b5ba6005 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9020,6 +9020,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1043, 0x1e51, "ASUS Zephyrus M15", ALC294_FIXUP_ASUS_GU502_PINS), SND_PCI_QUIRK(0x1043, 0x1e8e, "ASUS Zephyrus G15", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x1f11, "ASUS Zephyrus G14", ALC289_FIXUP_ASUS_GA401), + SND_PCI_QUIRK(0x1043, 0x1d42, "ASUS Zephyrus G14 2022", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), SND_PCI_QUIRK(0x1043, 0x3030, "ASUS ZN270IE", ALC256_FIXUP_ASUS_AIO_GPIO2), SND_PCI_QUIRK(0x1043, 0x831a, "ASUS P901", ALC269_FIXUP_STEREO_DMIC), -- 2.35.1

2 1

[PATCH] ALSA: seq: oss: fix typo
by Julia Lawall 14 Mar '22

14 Mar '22

Fix typo in "announcement". Reported-by: Joe Perches <joe(a)perches.com> Signed-off-by: Julia Lawall <Julia.Lawall(a)inria.fr> --- This applies on top of: From: Julia Lawall <Julia.Lawall(a)inria.fr> To: Jaroslav Kysela <perex(a)perex.cz> Cc: Takashi Iwai <tiwai(a)suse.com>,alsa-devel@alsa-project.org,linux-kernel@vger.kernel.org Subject: [PATCH 3/6] ALSA: seq: oss: use kzalloc sound/core/seq/oss/seq_oss_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/seq/oss/seq_oss_init.c b/sound/core/seq/oss/seq_oss_init.c index 04a3376a6e66..42d4e7535a82 100644 --- a/sound/core/seq/oss/seq_oss_init.c +++ b/sound/core/seq/oss/seq_oss_init.c @@ -80,7 +80,7 @@ snd_seq_oss_create_client(void) system_client = rc; - /* create annoucement receiver port */ + /* create announcement receiver port */ strcpy(port->name, "Receiver"); port->addr.client = system_client; port->capability = SNDRV_SEQ_PORT_CAP_WRITE; /* receive only */

2 1

RE: TAS27xx driver upstream to Kernel
by Xu, Yang 14 Mar '22

14 Mar '22

Hi Takashi Iwai, Any suggestion?Thanks. Regards Raphael From: Xu, Yang Sent: Friday, March 11, 2022 4:01 PM To: 'tiwai(a)suse.com' <tiwai(a)suse.com> Cc: Ding, Shenghao <shenghao-ding(a)ti.com>; Navada Kanyana, Mukund <navada(a)ti.com> Subject: TAS27xx driver upstream to Kernel Hi Takashi Iwai, This is Raphael Xu who is from Low Power Audio team,Texas Instrument. Could you help to review the attached patch and upstream them to the kernel? Thanks and expect your response. Change log: Path: /sound/soc/codecs 1. This patch to support either TAS2764 or TAS2780 device from TI 2. Fixed "no audio" issue on some platforms. Regards Raphael

1 0

[v4 0/2] ASoC: mediatek: mt8192: support rt1015p_rt5682s
by Jiaxin Yu 14 Mar '22

14 Mar '22

The series reuses mt8192-mt6359-rt10150rt5682.c for supporting machine driver with rt1015p speaker amplifier and rt5682s headset codec. Changes from v3: - fix build error: too many arguments for format [-Werror-format-extra-args] Changes from v2: - fix build warnings such as "data argument not used by format string" Changes from v1: - uses the snd_soc_of_get_dai_link_codecs to complete the configuration of dai_link's codecs - uses definitions to simplifies card name and compatible name Jiaxin Yu (2): ASoC: dt-bindings: mt8192-mt6359: add new compatible for using rt1015p and rt5682 ASoC: mediatek: mt8192: support rt1015p_rt5682s .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 1 + sound/soc/mediatek/Kconfig | 1 + .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 204 +++++++++++------- 3 files changed, 129 insertions(+), 77 deletions(-) -- 2.18.0

2 3

USB audio not detected with kernels 5.15.02 and 5.16.0; snd_usb_audio and snd_usbmidi_lib not loaded.
by GitHub issues - opened 14 Mar '22

14 Mar '22

alsa-project/alsa-lib issue #216 was opened from stevesr0: System running antiX linux Sid version (based on antiX-19). Using Pipewire on top of ALSA, both internal card and usb headset detected and play with kernel 5.10.88 (antiX nosystemd kernel). With Debian 5.15.5 and 5.16.0 kernels, the usb card is not noted in aplay -l or with /proc/asound/cards. Comparison of loaded modules for working kernel and non working kernel: --Working kernel has both snd_usb_audio and snd_usbmidi_lib loaded. --Non working kernel has NEITHER of these. Instead usbcore and usb_common are loaded. I am seeking advice about fixing the nonworking kernels. Not sure if this is a bug in the kernels, but both nonworking kernels have identical outputs in /proc/asound/cards and pactl list cards. Thanks. Happy to provide files as suggested; not sure what data would be useful. Steve Rinsler Issue URL : https://github.com/alsa-project/alsa-lib/issues/216 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Sound automatically switch from USB Speaker to HeadSet
by GitHub issues - opened 13 Mar '22

13 Mar '22

alsa-project/alsa-lib issue #215 was opened from modulusmath: Ubuntu 21.10 / Codename: impish Running LXDE if it matters I watch youtube listening on my external usb speakers and sounds plays just fine. All of a sudden they go silent and sound is played on the plugged in headset (Plantronics, Inc. DA40 Adapter) without my intervention...Even if I unplug the headset it will switch over to the 'default usb audio analog stereo'. I do see some logs via journalctl near the time of the switch: Mar 01 10:04:57 wilddog pulseaudio[1678]: ALSA woke us up to write new data to the device, but there was actually nothing to write. Mar 01 10:04:57 wilddog pulseaudio[1678]: Most likely this is a bug in the ALSA driver 'snd_usb_audio'. Please report this issue to the ALSA developers. Mar 01 10:04:57 wilddog pulseaudio[1678]: We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail. This is a pretty fresh install. How can I keep it stable on the external speakers? Here's my also info: http://alsa-project.org/db/?f=3589356420b912e19608eaee1960f19b3f0a4e22 Issue URL : https://github.com/alsa-project/alsa-lib/issues/215 Repository URL: https://github.com/alsa-project/alsa-lib

1 0