September 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ASoC: max98373: Mark cache dirty before entering sleep
by Ryan Lee 01 Oct '21

01 Oct '21

Amp lose its register values in case amp power loss or 'ForceReset' over Soundwire SCP_ctrl register(0x0044) or HW_RESET pin control during the audio suspend and resume. Mark cache dirty before audio suspension to restore existing values when audio resume. Signed-off-by: Ryan Lee <ryans.lee(a)maximintegrated.com> --- sound/soc/codecs/max98373-sdw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c index dc520effc61c..a7e4a6e880b0 100644 --- a/sound/soc/codecs/max98373-sdw.c +++ b/sound/soc/codecs/max98373-sdw.c @@ -259,6 +259,7 @@ static __maybe_unused int max98373_suspend(struct device *dev) regmap_read(max98373->regmap, max98373->cache[i].reg, &max98373->cache[i].val); regcache_cache_only(max98373->regmap, true); + regcache_mark_dirty(max98373->regmap); return 0; } -- 2.17.1

3 16

[PATCH regression fix] ASoC: nau8824: Fix headphone vs headset, button-press detection no longer working
by Hans de Goede 30 Sep '21

30 Sep '21

Commit 1d25684e2251 ("ASoC: nau8824: Fix open coded prefix handling") replaced the nau8824_dapm_enable_pin() helper with direct calls to snd_soc_dapm_enable_pin(), but the helper was using snd_soc_dapm_force_enable_pin() and not forcing the MICBIAS + SAR supplies on breaks headphone vs headset and button-press detection. Replace the snd_soc_dapm_enable_pin() calls with snd_soc_dapm_force_enable_pin() to fix this. Cc: stable(a)vger.kernel.org Fixes: 1d25684e2251 ("ASoC: nau8824: Fix open coded prefix handling") Signed-off-by: Hans de Goede <hdegoede(a)redhat.com> --- sound/soc/codecs/nau8824.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index cea1d43e0cb8..77f647529354 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -874,8 +874,8 @@ static void nau8824_jdet_work(struct work_struct *work) struct regmap *regmap = nau8824->regmap; int adc_value, event = 0, event_mask = 0; - snd_soc_dapm_enable_pin(dapm, "MICBIAS"); - snd_soc_dapm_enable_pin(dapm, "SAR"); + snd_soc_dapm_force_enable_pin(dapm, "MICBIAS"); + snd_soc_dapm_force_enable_pin(dapm, "SAR"); snd_soc_dapm_sync(dapm); msleep(100); -- 2.31.1

2 1

[PATCH 1/3] ASoC: rt5682s: Remove the volatile SW reset register from reg_default
by derek.fang＠realtek.com 30 Sep '21

30 Sep '21

From: Derek Fang <derek.fang(a)realtek.com> This reg is for SW reset. It shouldn't have default value, so remove. Signed-off-by: Derek Fang <derek.fang(a)realtek.com> --- sound/soc/codecs/rt5682s.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index d3e965b2e707..2b229c074a31 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -72,7 +72,6 @@ static void rt5682s_apply_patch_list(struct rt5682s_priv *rt5682s, } const struct reg_default rt5682s_reg[] = { - {0x0000, 0x0001}, {0x0002, 0x8080}, {0x0003, 0x0001}, {0x0005, 0x0000}, -- 2.17.1

2 3

[PATCH] ASoC: dt-bindings: rt5682s: fix the device-tree schema errors
by derek.fang＠realtek.com 30 Sep '21

30 Sep '21

From: Derek Fang <derek.fang(a)realtek.com> Fix the device-tree schema errors that be reported by using 'make dt_binding_check'. Signed-off-by: Derek Fang <derek.fang(a)realtek.com> --- .../devicetree/bindings/sound/realtek,rt5682s.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml index 7a5f1d0fd3e2..2b8b7b51fe55 100644 --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml @@ -29,6 +29,8 @@ properties: - 0 # dmic1 data is not used - 1 # using GPIO2 pin as dmic1 data pin - 2 # using GPIO5 pin as dmic1 data pin + description: | + Specify which GPIO pin be used as DMIC1 data pin. realtek,dmic1-clk-pin: $ref: /schemas/types.yaml#/definitions/uint32 @@ -36,12 +38,16 @@ properties: - 0 # dmic1 clk is not used - 1 # using GPIO1 pin as dmic1 clock pin - 2 # using GPIO3 pin as dmic1 clock pin + description: | + Specify which GPIO pin be used as DMIC1 clk pin. realtek,jd-src: $ref: /schemas/types.yaml#/definitions/uint32 enum: - 0 # No JD is used - 1 # using JD1 as JD source + description: | + Specify which JD source be used. realtek,ldo1-en-gpios: description: | @@ -72,9 +78,9 @@ properties: const: 1 clock-output-names: - items: - - description: Name given for DAI word clock output. - - description: Name given for DAI bit clock output. + minItems: 2 + maxItems: 2 + description: Name given for DAI word clock and bit clock outputs. additionalProperties: false -- 2.17.1

2 1

[PATCH] ASoC: fsl_rpmsg: Add rpmsg audio support for i.MX8ULP
by Shengjiu Wang 30 Sep '21

30 Sep '21

On i.MX8ULP the audio interface and codec are controlled by Cortex-M domain, Cortex-M core provides audio service over rpmsg. The rpmsg audio function is almost same as i.MX7ULP platform, so share same configuration. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- sound/soc/fsl/fsl_rpmsg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_rpmsg.c b/sound/soc/fsl/fsl_rpmsg.c index 07abad7fe372..8508bc7f239d 100644 --- a/sound/soc/fsl/fsl_rpmsg.c +++ b/sound/soc/fsl/fsl_rpmsg.c @@ -174,6 +174,7 @@ static const struct of_device_id fsl_rpmsg_ids[] = { { .compatible = "fsl,imx8mm-rpmsg-audio", .data = &imx8mm_data}, { .compatible = "fsl,imx8mn-rpmsg-audio", .data = &imx8mn_data}, { .compatible = "fsl,imx8mp-rpmsg-audio", .data = &imx8mp_data}, + { .compatible = "fsl,imx8ulp-rpmsg-audio", .data = &imx7ulp_data}, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, fsl_rpmsg_ids); -- 2.17.1

2 1

[PATCH] ASoC: SOF: Change SND_SOC_SOF_TOPLEVEL from config to menuconfig
by Peter Ujfalusi 30 Sep '21

30 Sep '21

We have growing number of options under SND_SOC_SOF_TOPLEVEL as SOF adaptation is growing (Intel, NXP, AMD and Mediatek) and new features are added. It will make the menuconfig user experience much cleaner if we move the SOF options under a separate page. Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Reviewed-by: Bard Liao <bard.liao(a)intel.com> Reviewed-by: Daniel Baluta <daniel.baluta(a)gmail.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)linux.intel.com> --- Hi, screen shots of before and after of menuconfig is attached to the PR for sof-dev: https://github.com/thesofproject/linux/pull/3148 Regards, Peter sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index cd659493b5df..94d1a859fedc 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only -config SND_SOC_SOF_TOPLEVEL +menuconfig SND_SOC_SOF_TOPLEVEL bool "Sound Open Firmware Support" help This adds support for Sound Open Firmware (SOF). SOF is free and -- 2.33.0

2 1

[PATCH] ASoC: wm_adsp: remove a repeated including
by Guo Zhengkui 30 Sep '21

30 Sep '21

Remove a repeated "#include <linux/firmware.h>" in line 32. Signed-off-by: Guo Zhengkui <guozhengkui(a)vivo.com> --- sound/soc/codecs/wm_adsp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 6c5d55b3b311..b9fb4f547d5e 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -29,7 +29,6 @@ #include <sound/jack.h> #include <sound/initval.h> #include <sound/tlv.h> -#include <linux/firmware.h> #include "wm_adsp.h" -- 2.20.1

3 2

[PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell Precision 5560 laptop
by Takashi Iwai 30 Sep '21

30 Sep '21

From: John Liu <johnliu55tw(a)gmail.com> The Dell Precision 5560 laptop appears to use the 4-speakers-on-ALC289 audio just like its sibling product XPS 9510, so it requires the same quirk to enable woofer output. Tested on my Dell Precision 5560. Signed-off-by: John Liu <johnliu55tw(a)gmail.com> Cc: <stable(a)vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4407f7da57c4..f17bfc6007d3 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8452,6 +8452,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x1028, 0x0a30, "Dell", ALC236_FIXUP_DELL_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0a58, "Dell", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0a61, "Dell XPS 15 9510", ALC289_FIXUP_DUAL_SPK), + SND_PCI_QUIRK(0x1028, 0x0a62, "Dell Precision 5560", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), -- 2.26.2

1 0

[PATCH v2 0/2] ALSA: hda: Reduce CPU hog with SKL+ position reporting
by Takashi Iwai 30 Sep '21

30 Sep '21

Hi, this is a v2 patch set for reducing the CPU hog with the HD-audio PCM position reporting. The first patch is almost same, while the second patch is added to take back to the position buffer as suggested by Pierre. Takashi v1: https://lore.kernel.org/r/20210910141002.32749-1-tiwai@suse.de === Takashi Iwai (2): ALSA: hda: Reduce udelay() at SKL+ position reporting ALSA: hda: Use position buffer for SKL+ again sound/pci/hda/hda_intel.c | 49 ++++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 26 deletions(-) -- 2.26.2

2 7

[PATCH][next] ALSA: virtio: Replace zero-length array with flexible-array member
by Gustavo A. R. Silva 30 Sep '21

30 Sep '21

There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Also, make use of the struct_size() helper in kzalloc(). [1] https://en.wikipedia.org/wiki/Flexible_array_member [2] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-a… Link: https://github.com/KSPP/linux/issues/78 Signed-off-by: Gustavo A. R. Silva <gustavoars(a)kernel.org> --- sound/virtio/virtio_pcm_msg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/virtio/virtio_pcm_msg.c b/sound/virtio/virtio_pcm_msg.c index f88c8f29cbd8..aca2dc1989ba 100644 --- a/sound/virtio/virtio_pcm_msg.c +++ b/sound/virtio/virtio_pcm_msg.c @@ -20,7 +20,7 @@ struct virtio_pcm_msg { struct virtio_snd_pcm_xfer xfer; struct virtio_snd_pcm_status status; size_t length; - struct scatterlist sgs[0]; + struct scatterlist sgs[]; }; /** @@ -146,8 +146,7 @@ int virtsnd_pcm_msg_alloc(struct virtio_pcm_substream *vss, int sg_num = virtsnd_pcm_sg_num(data, period_bytes); struct virtio_pcm_msg *msg; - msg = kzalloc(sizeof(*msg) + sizeof(*msg->sgs) * (sg_num + 2), - GFP_KERNEL); + msg = kzalloc(struct_size(msg, sgs, sg_num + 2), GFP_KERNEL); if (!msg) return -ENOMEM; -- 2.27.0

2 1