July 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: usb-audio: Add registration quirk for JBL Quantum headsets
by Alexander Tsoy 22 Jul '21

22 Jul '21

These devices has two interfaces, but only the second interface contains the capture endpoint, thus quirk is required to delay the registration until the second interface appears. Tested-by: Jakub Fišer <jakub(a)ufiseru.cz> Signed-off-by: Alexander Tsoy <alexander(a)tsoy.me> --- sound/usb/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 8b8bee3c3dd6..e7accd87e063 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -1897,6 +1897,9 @@ static const struct registration_quirk registration_quirks[] = { REG_QUIRK_ENTRY(0x0951, 0x16d8, 2), /* Kingston HyperX AMP */ REG_QUIRK_ENTRY(0x0951, 0x16ed, 2), /* Kingston HyperX Cloud Alpha S */ REG_QUIRK_ENTRY(0x0951, 0x16ea, 2), /* Kingston HyperX Cloud Flight S */ + REG_QUIRK_ENTRY(0x0ecb, 0x1f46, 2), /* JBL Quantum 600 */ + REG_QUIRK_ENTRY(0x0ecb, 0x2039, 2), /* JBL Quantum 400 */ + REG_QUIRK_ENTRY(0x0ecb, 0x203e, 2), /* JBL Quantum 800 */ { 0 } /* terminator */ }; -- 2.31.1

2 1

mic not working on JBL Quantum series USB headsets
by Jakub Fišer 22 Jul '21

22 Jul '21

Hello Alsa people, hope this is the right place to post. My Quantum 800's microphone doesn't work and I found other reports suggesting this issue affects the whole Quantum product line. It's a wireless headset with USB dongle. I *think* the issue is with Alsa because the Capture device is "detected" but not populated under /sys: arecord list of devices: ``` % arecord -l **** List of CAPTURE Hardware Devices **** (...) card 1: Q800 [Quantum 800], device 0: USB Audio [USB Audio] Subdevices: 1/1 Subdevice #0: subdevice #0 ``` amixer knobs: ``` % amixer -c1 Simple mixer control 'PCM',0 Capabilities: pswitch pswitch-joined Playback channels: Mono Mono: Playback [on] Simple mixer control 'PCM',1 Capabilities: pswitch pswitch-joined Playback channels: Mono Mono: Playback [on] Simple mixer control 'Headset',0 Capabilities: cvolume cvolume-joined cswitch cswitch-joined Capture channels: Mono Limits: Capture 0 - 64 Mono: Capture 64 [100%] [0.00dB] [on] ``` arecord trying to use the capture device: ``` % arecord -Dhw:1,0 /tmp/out.wav arecord: main:831: audio open error: No such file or directory ``` /sys pcm "endpoints" (missing capture endpoint): ``` % ls -1d /sys/class/sound/pcm* /sys/class/sound/pcmC1D0p /sys/class/sound/pcmC1D1p ``` nothing suspicious in dmesg: ``` usb 3-1.3: new full-speed USB device number 12 using xhci_hcd usb 3-1.3: New USB device found, idVendor=0ecb, idProduct=203e, bcdDevice= 1.00 usb 3-1.3: New USB device strings: Mfr=4, Product=5, SerialNumber=0 usb 3-1.3: Product: Quantum 800 usb 3-1.3: Manufacturer: JBL usb 3-1.3: Found post-registration device assignment: 0ecb203e:02 input: JBL Quantum 800 Consumer Control as /devices/pci0000:00/0000:00:1d.4/0000:05:00.0/0000:06:01.0/0000:08:00.0/0000:09:02.0/0000:0a:00.0/us 3/3-1/3-1.3/3-1.3:1.5/0003:0ECB:203E.0024/input/input51 input: JBL Quantum 800 as /devices/pci0000:00/0000:00:1d.4/0000:05:00.0/0000:06:01.0/0000:08:00.0/0000:09:02.0/0000:0a:00.0/us 3/3-1/3-1.3/3-1.3:1.5/0003:0ECB:203E.0024/input/input52 hid-generic 0003:0ECB:203E.0024: input,hiddev96,hidraw0: USB HID v1.11 Device [JBL Quantum 800] on usb-0000:0a:00.0-1.3/input5 ``` Nothing at all in either Pulse or Pipewire logs. alsa-info: http://alsa-project.org/db/?f=d9e7a91d97b2f64a0b2d00a05dfc9f9dace3a6f6 Linux 5.12.14-lqx2 Other reports: https://bbs.archlinux.org/viewtopic.php?pid=1983686 https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/998 The headset also works for me on Windows 10 out of the box (and according to the Internet, it works on Mac, too). Note that I updated the headset and dongle to the latest firmware (v3.1.5.0) with no effect. The 800 model also has Bluetooth with both A2DP and HSP profile. Not sure if this is relevant but for clarity: - with Pulse A2DP profile works only as output device (SBC and AAC), other profiles, such as HSP, are listed but "unavailable" - with Pipewire only HSP profiles are listed and available (mSBC, CVSD and "plain"), microphone *works* I'd like to help with debugging, just tell me how (or if) I can. thanks, -jakub.

2 3

Re: mic not working on JBL Quantum series USB headsets
by Alexander Tsoy 22 Jul '21

22 Jul '21

В Ср, 21/07/2021 в 22:34 +0000, Jakub Fišer пишет: > July 21, 2021 10:17 PM, "Alexander Tsoy" <alexander(a)tsoy.me> wrote: > > > В Вт, 20/07/2021 в 18:00 +0000, Jakub Fišer пишет: > > > > > My Quantum 800's microphone doesn't work and I found other reports > > > suggesting > > > this issue affects the whole Quantum product line. > > > > This device consists of two interfaces. The first interface contains > > a > > single playback endpoint and the second interface contains playback > > and > > capture endpoints. So JBL Quantum probably needs a registration quirk > > similar to Kingston HyperX devices. Please try the patch below: > > The patch works! Thanks. Two new profiles appeared in Pulseaudio (via > Pipewire) with "Mono input" and the profile "Pro Audio" gained the > mono input as well. Both analog and digital profiles work for playback > but only the "Pro Audio" profile exposes the second output as well. > This > profile is only available when using Pipewire (not in "plain" Pulse) > but > I guess this is not an Alsa-related issue. > > The microphone works in all three profiles as expected, everything > is there out-of-the-box with the patched kernel. What's the process to > get this patch to mainline? Should I be involved in it somehow? Thanks for testing. I'll submit this patch. > > > Just FYI, the headset also claims to have support for DTS Surround and > a 7.1 ultimate-something, the latter being explicitly a proprietary > thing. > > I guess DTS support is proprietary, too, but I couldn't find anything > about > it except that "it is there". In Windows both modes are only available > via > the proprietary application. According to lsusb output [1] this device works in UAC 1.0 mode and doesn't expose any of these capabilities. Presumably Windows driver is switching the device into some proprietary vendor specific mode or it is processing surround sound entirely in software. [1] https://github.com/linuxhw/LsUSB/blob/master/Desktop/Gigabyte%20Technology/…

2 1

out of memory issue
by Alex Roberts 21 Jul '21

21 Jul '21

Hello, I am developing a dummy codec to interface with an 8-channel, 24-bit ADC. I've got it working on an NXP imx8m through the fsl_sai driver on kernel 5.4.85. I can capture all 8 channels at varying sample rates using arecord, and I've verified correct data capture via opening the resulting .wav file in Audacity. The problem I am having is that occasionally, upon starting arecord - after a fresh power cycle - I get an out of memory error. Other times I get an out of memory after a non-deterministic period of capture. Starting capture again also reports out of memory, but if I wait several minutes and start capture it will start recording again. A power cycle usually helps, but as stated earlier, not 100% of the time. I'm trying to track down where the oom error is coming from, but haven't had much luck. My colleague tried running arecord with valgrind to check for memory leaks and nothing of note was observed. My suspicion is there's something going on with allocated memory for DMA, like fragmentation starts to happen and it can't get a contiguous region for operation. Reserving a large pool - either via device tree or boot cmd arguments in the bootoader - did not seem to help. Another thought is that it's a boundary/alignment issue due to the 24-bit data, and the error is the result of trying to allocate a chunk of memory for DMA that doesn't align. I'm very new to ALSA dev with some exposure to kernel dev in general, so please correct me if I'm wrong or completely mis-understanding something. Any suggestions on where I should / how I can debug this memory error? Thanks, Alex.

1 0

[GIT PULL] ASoC fixes for v5.14-rc2
by Mark Brown 21 Jul '21

21 Jul '21

The following changes since commit 6a7f5bd6185e1c86256d5e52c3bb7a4d390d6e19: ASoC: qcom: lpass-cpu: mark IRQ_CLEAR register as volatile and readable (2021-06-24 19:29:53 +0100) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git tags/asoc-fix-v5.14-rc2 for you to fetch changes up to 82d28b67f780910f816fe1cfb0f676fc38c4cbb3: ASoC: ti: j721e-evm: Check for not initialized parent_clk_id (2021-07-19 12:58:42 +0100) ---------------------------------------------------------------- ASoC: Fixes for v5.14 A collection of fixes for ASoC that have come in since the merge window, all driver specific. There is a new core feature added for reversing the order of operations when shutting down, this is needed to fix a bug with the AMD Stonyridge platform, and we also tweak the Kconfig to make the SSM2518 driver user selectable so it can be used with generic cards but that requires no actual code changes. ---------------------------------------------------------------- Charles Keepax (2): ASoC: wm_adsp: Correct wm_coeff_tlv_get handling ASoC: wm_adsp: Add CCM_CORE_RESET to Halo start core Kyle Russell (1): ASoC: tlv320aic31xx: fix reversed bclk/wclk master bits Lucas Stach (1): ASoC: codecs: allow SSM2518 to be selected by the user Marek Vasut (1): ASoC: tlv320aic32x4: Fix TAS2505 volume controls Mark Brown (3): Merge series "ASoC: Intel: machine driver corrections" from Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com>: ASoC: tlv320aic31xx: Make regmap cache only on probe() Merge series "arm64: tegra: Enable audio IOMMU support on Tegra194" from Thierry Reding <thierry.reding(a)gmail.com> Thierry Reding <treding(a)nvidia.com>: Maxim Schwalm (1): ASoC: rt5631: Fix regcache sync errors on resume Oder Chiou (1): ASoC: rt5682: Fix the issue of garbled recording after powerd_dbus_suspend Peter Robinson (1): ASoC: remove zte zx dangling kconfig Peter Ujfalusi (2): ASoC: ti: j721e-evm: Fix unbalanced domain activity tracking during startup ASoC: ti: j721e-evm: Check for not initialized parent_clk_id Rander Wang (1): ASoC: Intel: boards: fix xrun issue on platform with max98373 Rob Herring (1): ASoC: dt-bindings: renesas: rsnd: Fix incorrect 'port' regex schema Sathya Prakash M R (1): ASoC: SOF: Intel: Update ADL descriptor to use ACPI power states Srinivas Kandagatla (2): ASoC: codecs: wcd938x: make sdw dependency explicit in Kconfig ASoC: codecs: wcd938x: setup irq during component bind Thierry Reding (1): ASoC: tegra: Use ADMAIF component for DMA allocations Vijendar Mukunda (2): ASoC: soc-pcm: add a flag to reverse the stop sequence ASoC: amd: reverse stop sequence for stoneyridge platform .../devicetree/bindings/sound/renesas,rsnd.yaml | 2 +- include/sound/soc.h | 6 ++ sound/soc/amd/acp-da7219-max98357a.c | 5 ++ sound/soc/codecs/Kconfig | 8 +-- sound/soc/codecs/rt5631.c | 2 + sound/soc/codecs/rt5682.c | 8 ++- sound/soc/codecs/tlv320aic31xx.c | 2 + sound/soc/codecs/tlv320aic31xx.h | 4 +- sound/soc/codecs/tlv320aic32x4.c | 27 ++++---- sound/soc/codecs/wcd938x.c | 18 ++--- sound/soc/codecs/wm_adsp.c | 6 +- sound/soc/intel/boards/sof_sdw_max98373.c | 81 ++++++++++++++-------- sound/soc/soc-pcm.c | 22 ++++-- sound/soc/sof/intel/pci-tgl.c | 1 + sound/soc/tegra/tegra_pcm.c | 30 ++++---- sound/soc/ti/j721e-evm.c | 18 +++-- 16 files changed, 152 insertions(+), 88 deletions(-)

2 1

[PATCH 0/3] Read firmware, tplg and machine driver name from dts node
by Daniel Baluta 21 Jul '21

21 Jul '21

From: Daniel Baluta <daniel.baluta(a)nxp.com> This patchseries adds support for reading the firmware name, topology name and machine driver name from dsp dts node. Intel side uses ACPI to read this info. We should use DT for i.MX. First patches should go via sof-dev tree. Also last one could go via the same tree after we get an Ack from Rob. Daniel Baluta (3): ASoC: SOF: Parse fw/tplg filename from DT ASoC: SOF: Introduce machine driver name dt-bindings: dsp: fsl: Document newly introduced fsl,properties .../devicetree/bindings/dsp/fsl,dsp.yaml | 20 +++++++++++ include/sound/sof.h | 1 + sound/soc/sof/pcm.c | 5 ++- sound/soc/sof/sof-audio.c | 2 +- sound/soc/sof/sof-of-dev.c | 34 +++++++++++++++++++ 5 files changed, 60 insertions(+), 2 deletions(-) -- 2.27.0

6 13

[PATCH] ASoC: amd: Don't show messages about deferred probing by default
by Mario Limonciello 21 Jul '21

21 Jul '21

Nearly every boot with a Lenovo P14s is showing acp_pdm_mach acp_pdm_mach.0: snd_soc_register_card(acp) failed: -517 This isn't useful to a user, especially as probing will run again. Downgrade the message to debug, and only show errors. CC: markpearson(a)lenovo.com Signed-off-by: Mario Limonciello <mario.limonciello(a)amd.com> --- sound/soc/amd/renoir/acp3x-rn.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/renoir/acp3x-rn.c b/sound/soc/amd/renoir/acp3x-rn.c index 306134b89a82..e785994de614 100644 --- a/sound/soc/amd/renoir/acp3x-rn.c +++ b/sound/soc/amd/renoir/acp3x-rn.c @@ -54,9 +54,14 @@ static int acp_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, machine); ret = devm_snd_soc_register_card(&pdev->dev, card); if (ret) { - dev_err(&pdev->dev, - "snd_soc_register_card(%s) failed: %d\n", - acp_card.name, ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card(%s) failed: %d\n", + card->name, ret); + else + dev_dbg(&pdev->dev, + "snd_soc_register_card(%s) probe deferred: %d\n", + card->name, ret); return ret; } return 0; -- 2.25.1

2 1

[PATCH] ALSA: korg1212: Fix crash in snd_korg1212_create()
by Dan Carpenter 21 Jul '21

21 Jul '21

The "dsp_code" is not initialized until the next line so we can't dereference it. Fixes: b5cde369b618 ("ALSA: korg1212: Allocate resources with device-managed APIs") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/pci/korg1212/korg1212.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 7872abbd4587..3b2df5d06839 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2256,17 +2256,17 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci) korg1212->AdatTimeCodePhy = korg1212->sharedBufferPhy + offsetof(struct KorgSharedBuffer, AdatTimeCode); - korg1212->dma_dsp = snd_devm_alloc_pages(&pci->dev, SNDRV_DMA_TYPE_DEV, - dsp_code->size); - if (!korg1212->dma_dsp) - return -ENOMEM; - err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { snd_printk(KERN_ERR "firmware not available\n"); return err; } + korg1212->dma_dsp = snd_devm_alloc_pages(&pci->dev, SNDRV_DMA_TYPE_DEV, + dsp_code->size); + if (!korg1212->dma_dsp) + return -ENOMEM; + K1212_DEBUG_PRINTK("K1212_DEBUG: DSP Code area = 0x%p (0x%08x) %d bytes [%s]\n", korg1212->dma_dsp->area, korg1212->dma_dsp->addr, dsp_code->size, stateName[korg1212->cardState]); -- 2.20.1

2 1

[bug report] ALSA: als300: Allocate resources with device-managed APIs
by Dan Carpenter 21 Jul '21

21 Jul '21

Hello Takashi Iwai, The patch 21a9314cf93b: "ALSA: als300: Allocate resources with device-managed APIs" from Jul 15, 2021, leads to the following static checker warning: sound/pci/als300.c:713 snd_als300_probe() error: potentially dereferencing uninitialized 'chip'. sound/pci/als300.c 686 static int snd_als300_probe(struct pci_dev *pci, 687 const struct pci_device_id *pci_id) 688 { 689 static int dev; 690 struct snd_card *card; 691 struct snd_als300 *chip; 692 int err, chip_type; 693 694 if (dev >= SNDRV_CARDS) 695 return -ENODEV; 696 if (!enable[dev]) { 697 dev++; 698 return -ENOENT; 699 } 700 701 err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, 702 sizeof(*chip), &card); 703 if (err < 0) 704 return err; 705 706 chip_type = pci_id->driver_data; 707 708 err = snd_als300_create(card, pci, chip_type); 709 if (err < 0) 710 return err; 711 712 strcpy(card->driver, "ALS300"); --> 713 if (chip->chip_type == DEVICE_ALS300_PLUS) ^^^^^^^^^^^^^^^ chip isn't initialized now. 714 /* don't know much about ALS300+ yet 715 * print revision number for now */ 716 sprintf(card->shortname, "ALS300+ (Rev. %d)", chip->revision); 717 else 718 sprintf(card->shortname, "ALS300 (Rev. %c)", 'A' + 719 chip->revision - 1); 720 sprintf(card->longname, "%s at 0x%lx irq %i", 721 card->shortname, chip->port, chip->irq); 722 723 err = snd_card_register(card); 724 if (err < 0) 725 return err; 726 727 pci_set_drvdata(pci, card); 728 dev++; 729 return 0; 730 } regards, dan carpenter

2 1

[PATCH v4 00/12] Add Vangogh ACP ASoC driver
by Vijendar Mukunda 21 Jul '21

21 Jul '21

This adds an ASoC driver for the ACP (Audio CoProcessor) block on AMD Vangogh APU. Changes since v3: - Fixed typo errors - Fixed platform devices unregister logic - Updated acp resources count with macro value - updated ACP5x_I2S_MODE macro value to avoid unregistering platform devices for other ACP audio configurations in driver remove callback - Fixed error handling - Fixed indentation issues in irq handler - Add __maybe_unused for PM functions Changes since v2: - remove extra stuff from Make file Changes since v1: - add comment for acp_readl() & acp_writel() API's in common header file. - add amd: tag in commit message - modify condition check in acp5x_power_on() - removed acp_power_gating flag related code - drop acp5x_audio_remove() API - use single flag for handling irq status - fixed indetation issue and used dev_err instead of pr_err - drop acp5x_dai_remove() API - use SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK - use PM related Macros in ACP PCI driver - use PM related Macros in ACP DMA driver - remove extra line in Make file Vijendar Mukunda (12): ASoC: amd: add Vangogh ACP5x IP register header ASoC: amd: add Vangogh ACP PCI driver ASoc: amd: add acp5x init/de-init functions ASoC: amd: create acp5x platform devices ASoC: amd: add ACP5x PCM platform driver ASoC: amd: irq handler changes for ACP5x PCM dma driver ASoC: amd: add ACP5x pcm dma driver ops ASoC: amd: add vangogh i2s controller driver ASoC: amd: add vangogh i2s dai driver ops ASoC: amd: add vangogh pci driver pm ops ASoC: amd: add vangogh i2s dma driver pm ops ASoC: amd: enable vangogh acp5x driver build sound/soc/amd/Kconfig | 9 + sound/soc/amd/Makefile | 1 + sound/soc/amd/vangogh/Makefile | 9 + sound/soc/amd/vangogh/acp5x-i2s.c | 427 ++++++++++++++++ sound/soc/amd/vangogh/acp5x-pcm-dma.c | 524 ++++++++++++++++++++ sound/soc/amd/vangogh/acp5x.h | 193 +++++++ sound/soc/amd/vangogh/pci-acp5x.c | 326 ++++++++++++ sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++ 8 files changed, 1826 insertions(+) create mode 100644 sound/soc/amd/vangogh/Makefile create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c create mode 100644 sound/soc/amd/vangogh/acp5x.h create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h -- 2.17.1

3 21