June 2021 - Alsa-devel - mailman.alsa-project.org

Re: [PATCH] ASoC:fsl_spdif:Remove superfluous error message around platform_get_irq()
by Shengjiu Wang 11 Jun '21

11 Jun '21

On Thu, Jun 10, 2021 at 12:02 PM Zhongjun Tan <hbut_tan(a)163.com> wrote: > > From: Tan Zhongjun <tanzhongjun(a)yulong.com> > > The platform_get_irq() prints error message telling that interrupt is > missing, hence there is no need to duplicated that message. > > Signed-off-by: Tan Zhongjun <tanzhongjun(a)yulong.com> Acked-by: Shengjiu Wang <shengjiu.wang(a)gmail.com> > --- > sound/soc/fsl/fsl_spdif.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c > index 2a76714eb8e6..29cefd459241 100644 > --- a/sound/soc/fsl/fsl_spdif.c > +++ b/sound/soc/fsl/fsl_spdif.c > @@ -1368,10 +1368,8 @@ static int fsl_spdif_probe(struct platform_device *pdev) > > for (i = 0; i < spdif_priv->soc->interrupts; i++) { > irq = platform_get_irq(pdev, i); > - if (irq < 0) { > - dev_err(&pdev->dev, "no irq for node %s\n", pdev->name); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(&pdev->dev, irq, spdif_isr, 0, > dev_name(&pdev->dev), spdif_priv); > -- > 2.17.1 >

1 0

Re: [PATCH] ASoC:fsl_easrc:Remove superfluous error message around platform_get_irq()
by Shengjiu Wang 11 Jun '21

11 Jun '21

On Thu, Jun 10, 2021 at 8:52 PM Zhongjun Tan <hbut_tan(a)163.com> wrote: > > From: Tan Zhongjun <tanzhongjun(a)yulong.com> > > Clean up the check for irq.dev_err is superfluous as platform_get_irq() > already prints an error.Remove curly braces to confirm to styling > requirements. > > Signed-off-by: Tan Zhongjun <tanzhongjun(a)yulong.com> Acked-by: Shengjiu Wang <shengjiu.wang(a)gmail.com> > --- > sound/soc/fsl/fsl_easrc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c > index b1765c7d3bcd..25747433916e 100644 > --- a/sound/soc/fsl/fsl_easrc.c > +++ b/sound/soc/fsl/fsl_easrc.c > @@ -1901,10 +1901,8 @@ static int fsl_easrc_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq for node %pOF\n", np); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(&pdev->dev, irq, fsl_easrc_isr, 0, > dev_name(dev), easrc); > -- > 2.17.1 > >

1 0

[PATCH] ALSA: seq: Fix race of snd_seq_timer_open()
by Takashi Iwai 10 Jun '21

10 Jun '21

The timer instance per queue is exclusive, and snd_seq_timer_open() should have managed the concurrent accesses. It looks as if it's checking the already existing timer instance at the beginning, but it's not right, because there is no protection, hence any later concurrent call of snd_seq_timer_open() may override the timer instance easily. This may result in UAF, as the leftover timer instance can keep running while the queue itself gets closed, as spotted by syzkaller recently. For avoiding the race, add a proper check at the assignment of tmr->timeri again, and return -EBUSY if it's been already registered. Reported-by: syzbot+ddc1260a83ed1cbf6fb5(a)syzkaller.appspotmail.com Cc: <stable(a)vger.kernel.org> Link: https://lore.kernel.org/r/000000000000dce34f05c42f110c@google.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- sound/core/seq/seq_timer.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sound/core/seq/seq_timer.c b/sound/core/seq/seq_timer.c index 1645e4142e30..9863be6fd43e 100644 --- a/sound/core/seq/seq_timer.c +++ b/sound/core/seq/seq_timer.c @@ -297,8 +297,16 @@ int snd_seq_timer_open(struct snd_seq_queue *q) return err; } spin_lock_irq(&tmr->lock); - tmr->timeri = t; + if (tmr->timeri) + err = -EBUSY; + else + tmr->timeri = t; spin_unlock_irq(&tmr->lock); + if (err < 0) { + snd_timer_close(t); + snd_timer_instance_free(t); + return err; + } return 0; } -- 2.26.2

1 0

pulseaudio can't load configuration for snd_hda_intel
by GitHub issues - edited 10 Jun '21

10 Jun '21

alsa-project/alsa-ucm-conf issue #99 was edited from hzhuang1: In v1.2.2, the content of HDA-Intel.conf is in below. v1.2.2 is widely used, such as in ubuntu 20.04. ``` Syntax 3 Define.Use "" # a non-empty string to use UCM configuration for HDA devices Define.AcpCardId "$${CardIdByName:acp}" ``` With this content, pulseaudio can't load configuration from UCM. Then I tried to edit the content. Change it to ``` Define.Use "2" ``` or ``` Define.Use "3" ``` Pulseaudio worked with "options snd-hda-intel probe_mask=1" on DELL laptop. My question is what's the real meaning of **Define.Use** at here. Why the default value of **Define.Use** is empty string? Even in latest code, the **Define.Use** is also an empty string. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/99 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

pulseaudio can't load configuration for snd_hda_intel
by GitHub issues - opened 10 Jun '21

10 Jun '21

alsa-project/alsa-ucm-conf issue #99 was opened from hzhuang1: In v1.2.2, the content of HDA-Intel.conf is in below. v1.2.2 is widely used, such as in ubuntu 20.04. ``` Syntax 3 Define.Use "" # a non-empty string to use UCM configuration for HDA devices Define.AcpCardId "$${CardIdByName:acp}" ``` With this content, pulseaudio can't load configuration from UCM. Then I tried to edit the content. Change it to ``` Define.Use "2" ``` or ``` Define.Use "3" ``` Pulseaudio worked with "options snd-hda-intel probe_mask=1" on DELL laptop. My question is what's the real meaning of **Define.Use** at here. Why the default value of **Define.Use** is empty string? Even in v1.2.4, the **Define.Use** is also an empty string. Issue URL : https://github.com/alsa-project/alsa-ucm-conf/issues/99 Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Logitech C922x microphone intermittently working
by GitHub issues - opened 10 Jun '21

10 Jun '21

alsa-project/alsa-lib issue #152 was opened from sambo57u: I have a Logitech C922X (detected as C922) USB webcam. Running latest updates on Fedora 34. The microphone of this device only works about 1 out of 5 reboots. When not working if I install another microphone, activate that one, the unplug and plug C922 back and switch to it, it starts to work. Some kind of a timing issue that is very annoying. Don't have this problem with Logitech C270. The camera always works fine. Issue URL : https://github.com/alsa-project/alsa-lib/issues/152 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

Undeclarated constant
by GitHub issues - opened 10 Jun '21

10 Jun '21

alsa-project/alsa-plugins issue #24 was opened from unknown2045: Hi, I am trying to install the alsa-plugins, when I do the make command I get the following errors: ![Captura de pantalla de 2021-06-10 13-52-37](https://user-images.githubusercontent.com/85682900/121520376-229e… How can I solve it? Thanks in advance! Issue URL : https://github.com/alsa-project/alsa-plugins/issues/24 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

[sound:for-next 164/168] include/sound/memalloc.h:63:17: error: use of undeclared identifier 'PAGE_SIZE'
by kernel test robot 10 Jun '21

10 Jun '21

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 83fbcaed24d797528de00c024674fd58e8f1634f commit: 37af81c5998f4b0f23fb452cffa4b8a1c00ce95b [164/168] ALSA: core: Abstract memory alloc helpers config: riscv-randconfig-r002-20210610 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d2012d965d60c3258b3a69d024491698f8aec386) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound for-next git checkout 37af81c5998f4b0f23fb452cffa4b8a1c00ce95b # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): In file included from sound/core/pcm_iec958.c:8: In file included from include/sound/pcm.h:12: >> include/sound/memalloc.h:63:17: error: use of undeclared identifier 'PAGE_SIZE' return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^ >> include/sound/memalloc.h:63:35: error: use of undeclared identifier 'PAGE_SHIFT' return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^ 2 errors generated. vim +/PAGE_SIZE +63 include/sound/memalloc.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 57 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 58 /* 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 59 * return the pages matching with the given byte size 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 60 */ 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 61 static inline unsigned int snd_sgbuf_aligned_pages(size_t size) 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 62 { 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 @63 return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 64 } 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 65 :::::: The code at line 63 was first introduced by commit :::::: 4cae99d9b5305ab8cccc839fccceb81ec9e5abda ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally :::::: TO: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH] ALSA: core: Fix build error due to missing PAGE_SIZE
by Takashi Iwai 10 Jun '21

10 Jun '21

The recent refactoring of memalloc stuff removed the inclusion of asm/page.h for simplicity, but it turned out this caused a compile error due the lack of PAGE_SIZE definition on some architectures. Do a partial revert for recovering from that. Fixes: 37af81c5998f ("ALSA: core: Abstract memory alloc helpers") Reported-by: kernel test robot <lkp(a)intel.com> Link: https://lore.kernel.org/r/202106101858.PfXMMuAa-lkp@intel.com Signed-off-by: Takashi Iwai <tiwai(a)suse.de> --- include/sound/memalloc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/sound/memalloc.h b/include/sound/memalloc.h index 1918c60f1f35..44d87775b352 100644 --- a/include/sound/memalloc.h +++ b/include/sound/memalloc.h @@ -9,8 +9,9 @@ #ifndef __SOUND_MEMALLOC_H #define __SOUND_MEMALLOC_H +#include <asm/page.h> + struct device; -struct page; struct vm_area_struct; /* -- 2.26.2

1 0

[sound:for-next 164/167] include/sound/memalloc.h:63:17: error: 'PAGE_SIZE' undeclared
by kernel test robot 10 Jun '21

10 Jun '21

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next head: 7fdabab8f56239466275adea5d2f0a6fff27527b commit: 37af81c5998f4b0f23fb452cffa4b8a1c00ce95b [164/167] ALSA: core: Abstract memory alloc helpers config: h8300-randconfig-r006-20210610 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound for-next git checkout 37af81c5998f4b0f23fb452cffa4b8a1c00ce95b # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All errors (new ones prefixed by >>): In file included from include/sound/pcm.h:12, from sound/core/pcm_iec958.c:8: include/sound/memalloc.h: In function 'snd_sgbuf_aligned_pages': >> include/sound/memalloc.h:63:17: error: 'PAGE_SIZE' undeclared (first use in this function) 63 | return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; | ^~~~~~~~~ include/sound/memalloc.h:63:17: note: each undeclared identifier is reported only once for each function it appears in >> include/sound/memalloc.h:63:35: error: 'PAGE_SHIFT' undeclared (first use in this function) 63 | return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; | ^~~~~~~~~~ vim +/PAGE_SIZE +63 include/sound/memalloc.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 57 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 58 /* 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 59 * return the pages matching with the given byte size 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 60 */ 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 61 static inline unsigned int snd_sgbuf_aligned_pages(size_t size) 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 62 { 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 @63 return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 64 } 4cae99d9b5305a Pierre-Louis Bossart 2018-07-25 65 :::::: The code at line 63 was first introduced by commit :::::: 4cae99d9b5305ab8cccc839fccceb81ec9e5abda ALSA: memalloc: declare snd_sgbuf_aligned_pages() unconditionally :::::: TO: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> :::::: CC: Mark Brown <broonie(a)kernel.org> --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0