June 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH -next] ALSA: n64: check return value after calling platform_get_resource()
by Yang Yingliang 12 Jun '21

12 Jun '21

It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/mips/snd-n64.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/mips/snd-n64.c b/sound/mips/snd-n64.c index e35e93157755..463a6fe589eb 100644 --- a/sound/mips/snd-n64.c +++ b/sound/mips/snd-n64.c @@ -338,6 +338,10 @@ static int __init n64audio_probe(struct platform_device *pdev) strcpy(card->longname, "N64 Audio"); res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + if (!res) { + err = -EINVAL; + goto fail_dma_alloc; + } if (devm_request_irq(&pdev->dev, res->start, n64audio_isr, IRQF_SHARED, "N64 Audio", priv)) { err = -EBUSY; -- 2.25.1

2 1

[PATCH -next] ALSA: hda/tegra: Use devm_platform_get_and_ioremap_resource()
by Yang Yingliang 12 Jun '21

12 Jun '21

Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/pci/hda/hda_tegra.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c index 6f2b743b9d75..5aeef6123781 100644 --- a/sound/pci/hda/hda_tegra.c +++ b/sound/pci/hda/hda_tegra.c @@ -235,11 +235,9 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev) { struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); struct hdac_bus *bus = azx_bus(chip); - struct device *dev = hda->dev; struct resource *res; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - hda->regs = devm_ioremap_resource(dev, res); + hda->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hda->regs)) return PTR_ERR(hda->regs); -- 2.25.1

2 1

[PATCH -next] ALSA: trident: Fix build error
by YueHaibing 12 Jun '21

12 Jun '21

sound/pci/trident/trident_memory.c: In function ‘set_tlb_bus’: sound/pci/trident/trident_memory.c:85:35: error: ‘pagetr’ undeclared (first use in this function); did you mean ‘page’? for (i = 0; i < UNIT_PAGES; i++, pagetr++) { ^~~~~~ page Fixes: 74fb98311c4e ("ALSA: trident: Drop shadow TLB pointer table") Signed-off-by: YueHaibing <yuehaibing(a)huawei.com> --- sound/pci/trident/trident_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/trident/trident_memory.c b/sound/pci/trident/trident_memory.c index f831ec02702f..4ad3855101c9 100644 --- a/sound/pci/trident/trident_memory.c +++ b/sound/pci/trident/trident_memory.c @@ -82,7 +82,7 @@ static inline void set_tlb_bus(struct snd_trident *trident, int page, { int i; page *= UNIT_PAGES; - for (i = 0; i < UNIT_PAGES; i++, pagetr++) { + for (i = 0; i < UNIT_PAGES; i++, page++) { __set_tlb_bus(trident, page, addr); addr += SNDRV_TRIDENT_PAGE_SIZE; } -- 2.17.1

2 1

Question about upmix plugin
by GitHub issues - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-plugins issue #25 was opened from krumpfwylg: Hi, I've noticed the [latest commits](https://github.com/alsa-project/alsa-plugins/pull/2) done to the upmix plugin, but there's something I don't understand. Line 24 of pcm_upmix.c is _#define UPMIX_PCM_FORMAT SND_PCM_FORMAT_S16_ Does that mean the upmix plugin is still only capable of using S16_LE format ? Or does the UPMIX_PCM_FORMAT value can get changed to S32_LE by tweaking it in asoundrc file ? Issue URL : https://github.com/alsa-project/alsa-plugins/issues/25 Repository URL: https://github.com/alsa-project/alsa-plugins

1 0

Config parsing of pcm_rate broken since 1.1.7 (at least for a52 pcm plugin)
by GitHub issues - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #154 was opened from quequotion: As noted [in the mailing list](https://mailman.alsa-project.org/pipermail/alsa-devel/2019-December/1… back in 2019, config parsing (for alsa-plugins a52 pcm at least) has been broken since alsa-lib 1.1.7. As far as I know this was never bisected to a single commit in either alsa-lib or alsa-plugins. Looking at the mailing list discussion, it occurs to me that it may have given the impression that the config parser was broken when using [a patch that ports alsa-plugins to libswresample](https://git.harting.dev/anonfunc/alsa-plugins/commit/9cdbbb9874757b6f8fda7fb4ac2e3fc59da65946). Config parsing is broken *regardless* of that patch. @IdleGandalf worked around this by applying a patch to alsa-lib, in [src/pcm/pcm_rate.c](https://git.harting.dev/anonfunc/alsa-lib/commit/646bc80a63b0220300678a38e0c26a9a13af6fc0), but never got a response if this was an appropriate method to resolve the issue. Should this be fixed in alsa-lib or in alsa-plugins? Note: above links are to mirrors of the original patches, also in a repository owned by @IdleGandalf as far as I can tell. The links in the mailing list discussion are now 404. Issue URL : https://github.com/alsa-project/alsa-lib/issues/154 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

SNDRV_PCM_IOCTL_READI_FRAMES returns EIO
by Muni Sekhar 11 Jun '21

11 Jun '21

Hi all, I am using a USB sound card(snd-usb-audio), and it fails while doing the audio recording "arecord: pcm_read:2032: read error: Input/output error". I noticed recording(arecord) audio data on a USB sound card fails at SNDRV_PCM_IOCTL_READI_FRAMES is giving EIO. Can someone please clarify when the kernel returns EIO for Ioctl SNDRV_PCM_IOCTL_READI_FRAMES? and is there a workaround for this? Output of the alsamixer is attached. -- Thanks, Sekhar

2 5

[PATCH 0/3] ALSA: bebob: remove workarounds for suppressed quirks
by Takashi Sakamoto 11 Jun '21

11 Jun '21

Hi, As a result to apply the commit 1bd1b3be8655 ("ALSA: bebob: perform sequence replay for media clock recovery"), some quirks seem to be suppressed. This patchset removes workarounds for the suppressed quirks and includes code cleanup. Takashi Sakamoto (3): ALSA: bebob: dismiss sleep after breaking connections ALSA: bebob: delete workaround for protocol version 3 ALSA: bebob: code refactoring for model-dependent quirks sound/firewire/bebob/bebob.c | 41 ++++++++++++++++++++--------- sound/firewire/bebob/bebob.h | 10 ++++--- sound/firewire/bebob/bebob_stream.c | 32 ++++++---------------- 3 files changed, 42 insertions(+), 41 deletions(-) -- 2.27.0

2 4

Add support for automatic attributes in Topology2.0
by GitHub pull_request - opened 11 Jun '21

11 Jun '21

alsa-project/alsa-utils pull request #97 was opened from ranj063: Add support for automatic attributes in Topology2.0 and also add support for processing objects that are simply used to update the parent object's private data. Request URL : https://github.com/alsa-project/alsa-utils/pull/97 Patch URL : https://github.com/alsa-project/alsa-utils/pull/97.patch Repository URL: https://github.com/alsa-project/alsa-utils

1 0

ALSA lib pcm_dmix.c:1063:(snd_pcm_dmix_open) unable to create IPC semaphore
by GitHub issues - edited 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #153 was edited from Cean1024: alsa info: alsa-config-1.0 alsa-lib-1.1.5 alsa-plugins-1.1.5 alsa-utils-1.1.5 asound.conf: ``` pcm.dmixer { type dmix ipc_key 1024 slave { pcm "hw:0,0" period_time 0 period_size 1024 buffer_size 4096 rate 48000 format "S32_LE" channels 2 } bindings { 0 0 1 1 } } ``` test cmd: ``` arecord -f dat | aplay -f dat -D plug:dmixer ``` Issue URL : https://github.com/alsa-project/alsa-lib/issues/153 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

ALSA lib pcm_dmix.c:1063:(snd_pcm_dmix_open) unable to create IPC semaphore
by GitHub issues - edited 11 Jun '21

11 Jun '21

alsa-project/alsa-lib issue #153 was edited from Cean1024: alsa info: alsa-config-1.0 alsa-lib-1.1.5 alsa-plugins-1.1.5 alsa-utils-1.1.5 asound.conf: pcm.dmixer { type dmix ipc_key 1024 slave { pcm "hw:0,0" period_time 0 period_size 1024 buffer_size 4096 rate 48000 format "S32_LE" channels 2 } bindings { 0 0 1 1 } } test cmd: arecord -f dat | aplay -f dat -D plug:dmixer Issue URL : https://github.com/alsa-project/alsa-lib/issues/153 Repository URL: https://github.com/alsa-project/alsa-lib

1 0