June 2021 - Alsa-devel - mailman.alsa-project.org

ALSA: usb-audio: fix rate on Ozone Z90 USB headset
by Daehwan Jung 17 Jun '21

17 Jun '21

It mislabels its 96 kHz altsetting and that's why it causes some noise Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Daehwan Jung <dh10.jung(a)samsung.com> --- sound/usb/format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/format.c b/sound/usb/format.c index 2287f8c..eb216fe 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c @@ -223,9 +223,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof continue; /* C-Media CM6501 mislabels its 96 kHz altsetting */ /* Terratec Aureon 7.1 USB C-Media 6206, too */ + /* Ozone Z90 USB C-Media, too */ if (rate == 48000 && nr_rates == 1 && (chip->usb_id == USB_ID(0x0d8c, 0x0201) || chip->usb_id == USB_ID(0x0d8c, 0x0102) || + chip->usb_id == USB_ID(0x0d8c, 0x0078) || chip->usb_id == USB_ID(0x0ccd, 0x00b1)) && fp->altsetting == 5 && fp->maxpacksize == 392) rate = 96000; -- 2.7.4

3 2

HDA-Intel: add Boost volume control for Headset Mic
by GitHub pull_request - opened 17 Jun '21

17 Jun '21

alsa-project/alsa-ucm-conf pull request #101 was opened from jason77-wang: Ubuntu Linux users complain even they set the input volume to maximum, they still can't record sound with a pretty satisfied volume, they need to run commandline commands to adjust "Mic Boost/Headset Mic Boost/Headphone Mic boost" value to increase the input volume. That is because the current ucm only defines "Capture Volume" to control the input volume. Here we add Boost control, then users could adjust both "Capture Volume" and "Boost Volume" through Pulseaudio and Gnome. BugLink: https://bugs.launchpad.net/bugs/1930188 Signed-off-by: Hui Wang <hui.wang(a)canonical.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/101 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/101.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: max98357a: set channels_max to 4
by Judy Hsiao 16 Jun '21

16 Jun '21

Sets channels_max to 4 to support QUAD channel. Signed-off-by: Judy Hsiao <judyhsiao(a)chromium.org> --- sound/soc/codecs/max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 918812763884..c3cf1743caad 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -117,7 +117,7 @@ static struct snd_soc_dai_driver max98357a_dai_driver = { .rate_min = 8000, .rate_max = 96000, .channels_min = 1, - .channels_max = 2, + .channels_max = 4, }, .ops = &max98357a_dai_ops, }; -- 2.31.0

5 6

[PATCH -next 1/3] ASoC: rockchip: i2s: Use devm_platform_get_and_ioremap_resource()
by Yang Yingliang 16 Jun '21

16 Jun '21

Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/rockchip/rockchip_i2s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 0740764e7f71..c7dc3509bceb 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -618,8 +618,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) return PTR_ERR(i2s->mclk); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - regs = devm_ioremap_resource(&pdev->dev, res); + regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(regs)) return PTR_ERR(regs); -- 2.25.1

2 3

[PATCH -next] SoC: codecs: wcd938x: fix boolreturn.cocci warning
by Yang Li 16 Jun '21

16 Jun '21

Return statements in functions returning bool should use true/false instead of 1/0. Fix the following coccicheck warning: ./sound/soc/codecs/wcd938x.c:1190:9-10: WARNING: return of 0/1 in function 'wcd938x_volatile_register' with return type bool. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Yang Li <yang.lee(a)linux.alibaba.com> --- sound/soc/codecs/wcd938x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 2cf6145..cfe00536 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -1187,7 +1187,7 @@ static bool wcd938x_writeable_register(struct device *dev, unsigned int reg) static bool wcd938x_volatile_register(struct device *dev, unsigned int reg) { if (reg <= WCD938X_BASE_ADDRESS) - return 0; + return false; if (reg == WCD938X_DIGITAL_SWR_TX_CLK_RATE) return true; -- 1.8.3.1

2 1

[PATCH] ASoC: codecs: Fix duplicate included sound/soc.h
by Jiapeng Chong 16 Jun '21

16 Jun '21

Clean up the following includecheck warnings: ./sound/soc/codecs/wcd938x.c: sound/soc.h is included more than once. ./sound/soc/codecs/wcd938x-sdw.c: sound/soc.h is included more than once. No functional change. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- sound/soc/codecs/wcd938x-sdw.c | 1 - sound/soc/codecs/wcd938x.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x-sdw.c b/sound/soc/codecs/wcd938x-sdw.c index d82c40e..88334d3 100644 --- a/sound/soc/codecs/wcd938x-sdw.c +++ b/sound/soc/codecs/wcd938x-sdw.c @@ -7,7 +7,6 @@ #include <linux/device.h> #include <linux/kernel.h> #include <linux/component.h> -#include <sound/soc.h> #include <linux/pm_runtime.h> #include <linux/irqdomain.h> #include <linux/of.h> diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 2cf6145..c0d7452 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -9,7 +9,6 @@ #include <linux/kernel.h> #include <linux/pm_runtime.h> #include <linux/component.h> -#include <sound/soc.h> #include <sound/tlv.h> #include <linux/of_gpio.h> #include <linux/of.h> -- 1.8.3.1

2 1

[PATCH] ASoC: hdmi-codec: make hdmi_codec_controls static
by Jiapeng Chong 16 Jun '21

16 Jun '21

This symbol is not used outside of hdmi-codec.c, so marks it static. Fix the following sparse warning: sound/soc/codecs/hdmi-codec.c:750:25: warning: symbol 'hdmi_codec_controls' was not declared. Should it be static? Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- sound/soc/codecs/hdmi-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index e0460a9..b61f980 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -747,7 +747,7 @@ static int hdmi_codec_mute(struct snd_soc_dai *dai, int mute, int direction) SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S32_BE |\ SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE) -struct snd_kcontrol_new hdmi_codec_controls[] = { +static struct snd_kcontrol_new hdmi_codec_controls[] = { { .access = SNDRV_CTL_ELEM_ACCESS_READ, .iface = SNDRV_CTL_ELEM_IFACE_PCM, -- 1.8.3.1

2 1

[PATCH] ASoC: cs42l42: Correct definition of CS42L42_ADC_PDN_MASK
by Richard Fitzgerald 16 Jun '21

16 Jun '21

The definition of CS42L42_ADC_PDN_MASK was incorrectly defined as the HP_PDN bit. Fixes: 2c394ca79604 ("ASoC: Add support for CS42L42 codec") Signed-off-by: Richard Fitzgerald <rf(a)opensource.cirrus.com> --- sound/soc/codecs/cs42l42.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 7bf05ff05f74..206b3c81d3e0 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -79,7 +79,7 @@ #define CS42L42_HP_PDN_SHIFT 3 #define CS42L42_HP_PDN_MASK (1 << CS42L42_HP_PDN_SHIFT) #define CS42L42_ADC_PDN_SHIFT 2 -#define CS42L42_ADC_PDN_MASK (1 << CS42L42_HP_PDN_SHIFT) +#define CS42L42_ADC_PDN_MASK (1 << CS42L42_ADC_PDN_SHIFT) #define CS42L42_PDN_ALL_SHIFT 0 #define CS42L42_PDN_ALL_MASK (1 << CS42L42_PDN_ALL_SHIFT) -- 2.20.1

2 1

[PATCH v2] media: Fix Media Controller API config checks
by Shuah Khan 16 Jun '21

16 Jun '21

Smatch static checker warns that "mdev" can be null: sound/usb/media.c:287 snd_media_device_create() warn: 'mdev' can also be NULL If CONFIG_MEDIA_CONTROLLER is disabled, this file should not be included in the build. The below conditions in the sound/usb/Makefile are in place to ensure that media.c isn't included in the build. sound/usb/Makefile: snd-usb-audio-$(CONFIG_SND_USB_AUDIO_USE_MEDIA_CONTROLLER) += media.o select SND_USB_AUDIO_USE_MEDIA_CONTROLLER if MEDIA_CONTROLLER && (MEDIA_SUPPORT=y || MEDIA_SUPPORT=SND_USB_AUDIO) The following config check in include/media/media-dev-allocator.h is in place to enable the API only when CONFIG_MEDIA_CONTROLLER and CONFIG_USB are enabled. #if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) This check doesn't work as intended when CONFIG_USB=m. When CONFIG_USB=m, CONFIG_USB_MODULE is defined and CONFIG_USB is not. The above config check doesn't catch that CONFIG_USB is defined as a module and disables the API. This results in sound/usb enabling Media Controller specific ALSA driver code, while Media disables the Media Controller API. Fix the problem requires two changes: 1. Change the check to use IS_ENABLED to detect when CONFIG_USB is enabled as a module or static. Since CONFIG_MEDIA_CONTROLLER is a bool, leave the check unchanged to be consistent with drivers/media/Makefile. 2. Change the drivers/media/mc/Makefile to include mc-dev-allocator.o in mc-objs when CONFIG_USB is enabled. Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Link: https://lore.kernel.org/alsa-devel/YLeAvT+R22FQ%2FEyw@mwanda/ Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> --- Changes since v1: - Fixed the drivers/media/mc/Makefile incorrect logic to check CONFIG_USB value. Test with CONFIG_USB_SUPPORT enabled/disabled CONFIG_USB y/m and disabled. drivers/media/mc/Makefile | 2 +- include/media/media-dev-allocator.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/mc/Makefile b/drivers/media/mc/Makefile index 119037f0e686..2b7af42ba59c 100644 --- a/drivers/media/mc/Makefile +++ b/drivers/media/mc/Makefile @@ -3,7 +3,7 @@ mc-objs := mc-device.o mc-devnode.o mc-entity.o \ mc-request.o -ifeq ($(CONFIG_USB),y) +ifneq ($(CONFIG_USB),) mc-objs += mc-dev-allocator.o endif diff --git a/include/media/media-dev-allocator.h b/include/media/media-dev-allocator.h index b35ea6062596..2ab54d426c64 100644 --- a/include/media/media-dev-allocator.h +++ b/include/media/media-dev-allocator.h @@ -19,7 +19,7 @@ struct usb_device; -#if defined(CONFIG_MEDIA_CONTROLLER) && defined(CONFIG_USB) +#if defined(CONFIG_MEDIA_CONTROLLER) && IS_ENABLED(CONFIG_USB) /** * media_device_usb_allocate() - Allocate and return struct &media device * -- 2.30.2

1 0

HDSPconf don't recognize RME RayDat
by GitHub issues - opened 16 Jun '21

16 Jun '21

alsa-project/alsa-tools issue #6 was opened from profejuanca: Hi, I'm using a RME Raydat (PCI express) many years ago, but HDSPconf don't recognize my card never, hdspmixer and the rest of jack/alsa tools see my card without problems, but hdspconf in various distros never sees my card. The output is: `HDSPConf 1.4 - Copyright (C) 2003 Thomas Charbonnel <thomas(a)undata.org> This program comes WITH ABSOLUTELY NO WARRANTY HDSPConf is free software, see the file copying for details Looking for HDSP cards : Card 0 : RME RayDAT S/N 0x3250cb at 0xfe300000, irq 57 Card 1 : HDA ATI SB at 0xfe800000 irq 16 Card 2 : HDA NVidia at 0xfe080000 irq 60 No Hammerfall DSP card found. ` Card 0 es my RME card... I suposse that raydat is not in the list of the tool. Issue URL : https://github.com/alsa-project/alsa-tools/issues/6 Repository URL: https://github.com/alsa-project/alsa-tools

1 0