June 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH] ALSA: firewire-motu: fix stream format for MOTU 8pre FireWire
by Takashi Sakamoto 17 Jun '21

17 Jun '21

My previous refactoring for ALSA firewire-motu driver brought regression to handle MOTU 8pre FireWire. The packet format is not operated correctly. Cc: <stable(a)vger.kernel.org> Fixes: dfbaa4dc11eb ("ALSA: firewire-motu: add model-specific table of chunk count") Signed-off-by: Takashi Sakamoto <o-takashi(a)sakamocchi.jp> --- sound/firewire/motu/motu-protocol-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/firewire/motu/motu-protocol-v2.c b/sound/firewire/motu/motu-protocol-v2.c index e59e69ab1538..784073aa1026 100644 --- a/sound/firewire/motu/motu-protocol-v2.c +++ b/sound/firewire/motu/motu-protocol-v2.c @@ -353,6 +353,7 @@ const struct snd_motu_spec snd_motu_spec_8pre = { .protocol_version = SND_MOTU_PROTOCOL_V2, .flags = SND_MOTU_SPEC_RX_MIDI_2ND_Q | SND_MOTU_SPEC_TX_MIDI_2ND_Q, - .tx_fixed_pcm_chunks = {10, 6, 0}, - .rx_fixed_pcm_chunks = {10, 6, 0}, + // Two dummy chunks always in the end of data block. + .tx_fixed_pcm_chunks = {10, 10, 0}, + .rx_fixed_pcm_chunks = {6, 6, 0}, }; -- 2.30.2

2 1

[PATCH alsa-plugins 0/2] Support multiple formats
by Takashi Iwai 17 Jun '21

17 Jun '21

Hi, this is a patch set to add the multi-format support for the existing rate plugins. Takashi === Takashi Iwai (2): rate-lav: Support multiple formats samplerate: Support multiple formats rate-lav/rate_lavrate.c | 115 ++++++++++++++++++++++++++++++++++------ rate/rate_samplerate.c | 99 ++++++++++++++++++++++++++++------ 2 files changed, 183 insertions(+), 31 deletions(-) -- 2.26.2

1 2

[PATCH 0/2] ALSA: firewire-motu: add support for MOTU 828 and 896
by Takashi Sakamoto 17 Jun '21

17 Jun '21

Hi, This patchset is to add support for Mark of the unicorn (MOTU) 828 and 896, which were shipped two decades ago (2001) and already discontinued. (yes, it's 2021). It's reasonable to count them as first generation of MOTU FireWire series since they are based on QuickLogic QuickRAM FPGA apart from Altera or Xilinx FPGA in the latter generation. Unlike the latter generation, they doesn't allow software to configure internal multiplexer. I note that the sequence replay for media clock recovery[1] allows to support them. The device doesn't generate better sound with nominal (ideal) sequence of packets, thus the patches should be applied to development tree for v5.14 kernel. [1] [PATCH 0/3] ALSA: firewire-motu: media clock recovery for sph-aware devices https://lore.kernel.org/alsa-devel/20210602013406.26442-1-o-takashi@sakamoc… Takashi Sakamoto (2): ALSA: firewire-motu: add support for MOTU 828 ALSA: firewire-motu: add support for MOTU 896 sound/firewire/Kconfig | 2 + sound/firewire/motu/Makefile | 3 +- sound/firewire/motu/motu-protocol-v1.c | 440 +++++++++++++++++++++++++ sound/firewire/motu/motu.c | 2 + sound/firewire/motu/motu.h | 24 ++ 5 files changed, 470 insertions(+), 1 deletion(-) create mode 100644 sound/firewire/motu/motu-protocol-v1.c -- 2.30.2

2 4

[PATCH alsa-lib 0/2] Allow multiple formats for PCM rate plugin
by Takashi Iwai 17 Jun '21

17 Jun '21

Hi, this is a patch set for alsa-lib to extend the PCM rate plugin for allowing multiple formats for its converter plugins. This optimizes and improves the quality (skips the unnecessary buffer and conversion) when the converter supports the source and/or the target format natively. The patches for libswresample and libsamplerate will follow. Takashi === Takashi Iwai (2): pcm: rate: Refactoring temporary buffer allocations pcm: rate: Improve the support multiple formats include/pcm_rate.h | 36 +++- src/pcm/pcm_rate.c | 424 +++++++++++++++++++++++++++------------------ 2 files changed, 293 insertions(+), 167 deletions(-) -- 2.26.2

1 2

ALSA: usb-audio: fix rate on Ozone Z90 USB headset
by Daehwan Jung 17 Jun '21

17 Jun '21

It mislabels its 96 kHz altsetting and that's why it causes some noise Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Signed-off-by: Daehwan Jung <dh10.jung(a)samsung.com> --- sound/usb/format.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/usb/format.c b/sound/usb/format.c index 2287f8c..eb216fe 100644 --- a/sound/usb/format.c +++ b/sound/usb/format.c @@ -223,9 +223,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof continue; /* C-Media CM6501 mislabels its 96 kHz altsetting */ /* Terratec Aureon 7.1 USB C-Media 6206, too */ + /* Ozone Z90 USB C-Media, too */ if (rate == 48000 && nr_rates == 1 && (chip->usb_id == USB_ID(0x0d8c, 0x0201) || chip->usb_id == USB_ID(0x0d8c, 0x0102) || + chip->usb_id == USB_ID(0x0d8c, 0x0078) || chip->usb_id == USB_ID(0x0ccd, 0x00b1)) && fp->altsetting == 5 && fp->maxpacksize == 392) rate = 96000; -- 2.7.4

3 2

HDA-Intel: add Boost volume control for Headset Mic
by GitHub pull_request - opened 17 Jun '21

17 Jun '21

alsa-project/alsa-ucm-conf pull request #101 was opened from jason77-wang: Ubuntu Linux users complain even they set the input volume to maximum, they still can't record sound with a pretty satisfied volume, they need to run commandline commands to adjust "Mic Boost/Headset Mic Boost/Headphone Mic boost" value to increase the input volume. That is because the current ucm only defines "Capture Volume" to control the input volume. Here we add Boost control, then users could adjust both "Capture Volume" and "Boost Volume" through Pulseaudio and Gnome. BugLink: https://bugs.launchpad.net/bugs/1930188 Signed-off-by: Hui Wang <hui.wang(a)canonical.com> Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/101 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/101.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

[PATCH] ASoC: max98357a: set channels_max to 4
by Judy Hsiao 16 Jun '21

16 Jun '21

Sets channels_max to 4 to support QUAD channel. Signed-off-by: Judy Hsiao <judyhsiao(a)chromium.org> --- sound/soc/codecs/max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98357a.c b/sound/soc/codecs/max98357a.c index 918812763884..c3cf1743caad 100644 --- a/sound/soc/codecs/max98357a.c +++ b/sound/soc/codecs/max98357a.c @@ -117,7 +117,7 @@ static struct snd_soc_dai_driver max98357a_dai_driver = { .rate_min = 8000, .rate_max = 96000, .channels_min = 1, - .channels_max = 2, + .channels_max = 4, }, .ops = &max98357a_dai_ops, }; -- 2.31.0

5 6

[PATCH -next 1/3] ASoC: rockchip: i2s: Use devm_platform_get_and_ioremap_resource()
by Yang Yingliang 16 Jun '21

16 Jun '21

Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <yangyingliang(a)huawei.com> --- sound/soc/rockchip/rockchip_i2s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 0740764e7f71..c7dc3509bceb 100644 --- a/sound/soc/rockchip/rockchip_i2s.c +++ b/sound/soc/rockchip/rockchip_i2s.c @@ -618,8 +618,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev) return PTR_ERR(i2s->mclk); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - regs = devm_ioremap_resource(&pdev->dev, res); + regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(regs)) return PTR_ERR(regs); -- 2.25.1

2 3

[PATCH -next] SoC: codecs: wcd938x: fix boolreturn.cocci warning
by Yang Li 16 Jun '21

16 Jun '21

Return statements in functions returning bool should use true/false instead of 1/0. Fix the following coccicheck warning: ./sound/soc/codecs/wcd938x.c:1190:9-10: WARNING: return of 0/1 in function 'wcd938x_volatile_register' with return type bool. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Yang Li <yang.lee(a)linux.alibaba.com> --- sound/soc/codecs/wcd938x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 2cf6145..cfe00536 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -1187,7 +1187,7 @@ static bool wcd938x_writeable_register(struct device *dev, unsigned int reg) static bool wcd938x_volatile_register(struct device *dev, unsigned int reg) { if (reg <= WCD938X_BASE_ADDRESS) - return 0; + return false; if (reg == WCD938X_DIGITAL_SWR_TX_CLK_RATE) return true; -- 1.8.3.1

2 1

[PATCH] ASoC: codecs: Fix duplicate included sound/soc.h
by Jiapeng Chong 16 Jun '21

16 Jun '21

Clean up the following includecheck warnings: ./sound/soc/codecs/wcd938x.c: sound/soc.h is included more than once. ./sound/soc/codecs/wcd938x-sdw.c: sound/soc.h is included more than once. No functional change. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- sound/soc/codecs/wcd938x-sdw.c | 1 - sound/soc/codecs/wcd938x.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sound/soc/codecs/wcd938x-sdw.c b/sound/soc/codecs/wcd938x-sdw.c index d82c40e..88334d3 100644 --- a/sound/soc/codecs/wcd938x-sdw.c +++ b/sound/soc/codecs/wcd938x-sdw.c @@ -7,7 +7,6 @@ #include <linux/device.h> #include <linux/kernel.h> #include <linux/component.h> -#include <sound/soc.h> #include <linux/pm_runtime.h> #include <linux/irqdomain.h> #include <linux/of.h> diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 2cf6145..c0d7452 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -9,7 +9,6 @@ #include <linux/kernel.h> #include <linux/pm_runtime.h> #include <linux/component.h> -#include <sound/soc.h> #include <sound/tlv.h> #include <linux/of_gpio.h> #include <linux/of.h> -- 1.8.3.1

2 1