May 2021 - Alsa-devel - mailman.alsa-project.org

[bug report] ALSA: usb-audio: Handle error for the current selector gracefully
by Dan Carpenter 21 May '21

21 May '21

Hello Takashi Iwai, The patch 481f17c41803: "ALSA: usb-audio: Handle error for the current selector gracefully" from May 18, 2021, leads to the following static checker warning: sound/usb/clock.c:338 __uac_clock_find_source() error: uninitialized symbol 'cur'. sound/usb/clock.c 254 static int __uac_clock_find_source(struct snd_usb_audio *chip, 255 const struct audioformat *fmt, int entity_id, 256 unsigned long *visited, bool validate) 257 { 258 union uac23_clock_source_desc *source; 259 union uac23_clock_selector_desc *selector; 260 union uac23_clock_multiplier_desc *multiplier; 261 int ret, i, cur, err, pins, clock_id; ^^^ 262 const u8 *sources; 263 int proto = fmt->protocol; 264 265 entity_id &= 0xff; 266 267 if (test_and_set_bit(entity_id, visited)) { 268 usb_audio_warn(chip, 269 "%s(): recursive clock topology detected, id %d.\n", 270 __func__, entity_id); 271 return -EINVAL; 272 } 273 274 /* first, see if the ID we're looking for is a clock source already */ 275 source = snd_usb_find_clock_source(chip, entity_id, proto); 276 if (source) { 277 entity_id = GET_VAL(source, proto, bClockID); 278 if (validate && !uac_clock_source_is_valid(chip, fmt, 279 entity_id)) { 280 usb_audio_err(chip, 281 "clock source %d is not valid, cannot use\n", 282 entity_id); 283 return -ENXIO; 284 } 285 return entity_id; 286 } 287 288 selector = snd_usb_find_clock_selector(chip, entity_id, proto); 289 if (selector) { 290 pins = GET_VAL(selector, proto, bNrInPins); 291 clock_id = GET_VAL(selector, proto, bClockID); 292 sources = GET_VAL(selector, proto, baCSourceID); 293 294 if (pins == 1) { 295 ret = 1; 296 goto find_source; 297 } 298 299 /* the entity ID we are looking for is a selector. 300 * find out what it currently selects */ 301 ret = uac_clock_selector_get_val(chip, clock_id); 302 if (ret < 0) { 303 if (!chip->autoclock) 304 return ret; 305 goto find_others; ^^^^^^^^^^^^^^^^^ Assume we hit one of these gotos 306 } 307 308 /* Selector values are one-based */ 309 310 if (ret > pins || ret < 1) { 311 usb_audio_err(chip, 312 "%s(): selector reported illegal value, id %d, ret %d\n", 313 __func__, clock_id, ret); 314 315 if (!chip->autoclock) 316 return -EINVAL; 317 ret = 0; 318 goto find_others; ^^^^^^^^^^^^^^^^^ 319 } 320 321 find_source: 322 cur = ret; 323 ret = __uac_clock_find_source(chip, fmt, 324 sources[ret - 1], 325 visited, validate); 326 if (ret > 0) { 327 err = uac_clock_selector_set_val(chip, entity_id, cur); 328 if (err < 0) 329 return err; 330 } 331 332 if (!validate || ret > 0 || !chip->autoclock) 333 return ret; 334 335 find_others: 336 /* The current clock source is invalid, try others. */ 337 for (i = 1; i <= pins; i++) { 338 if (i == cur) ^^^^^^^^ 339 continue; 340 341 ret = __uac_clock_find_source(chip, fmt, 342 sources[i - 1], 343 regards, dan carpenter

2 1

Broken out-of-tree build
by GitHub issues - opened 20 May '21

20 May '21

alsa-project/alsa-lib issue #136 was opened from concatime: Hi. Due to missing headers, I cannot build alsa-lib if the build directory is outside of the source tree. ``` make[2]: Entering directory '/home/iemaghni/Code/tmp/build/src/ucm' CC utils.lo In file included from ../../../alsa-lib/src/ucm/ucm_local.h:41, from ../../../alsa-lib/src/ucm/utils.c:33: ../../../alsa-lib/include/use-case.h:45:10: fatal error: alsa/asoundlib.h: No such file or directory 45 | #include <alsa/asoundlib.h> | ^~~~~~~~~~~~~~~~~~ ``` Step to reproduce: ```sh git clone https://github.com/alsa-project/alsa-lib.git mkdir build cd alsa-lib libtoolize --force --copy --automake aclocal autoheader automake --foreign --copy --add-missing autoconf cd ../build ../alsa-lib/configure make ``` Thank you! Issue URL : https://github.com/alsa-project/alsa-lib/issues/136 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH v3 1/2] ASoC: dt-bindings: imx-card: Add binding doc for imx sound card
by Shengjiu Wang 20 May '21

20 May '21

Imx-card is a new added machine driver for supporting ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. But these DAC/ADCs are not only supported codecs. This machine driver is designed to be a more common machine driver for i.MX platform, it can support widely cpu dai interface and codec dai interface. Signed-off-by: Shengjiu Wang <shengjiu.wang(a)nxp.com> --- changes in v3: - use a generic compatible string as Rob's comments. - change the file name changes in v2: - update doc accoring to Rob's comment, use the common porperties. .../bindings/sound/imx-audio-card.yaml | 122 ++++++++++++++++++ 1 file changed, 122 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-card.yaml diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml new file mode 100644 index 000000000000..d1816dd061cf --- /dev/null +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml @@ -0,0 +1,122 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/imx-audio-card.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX audio sound card. + +maintainers: + - Shengjiu Wang <shengjiu.wang(a)nxp.com> + +properties: + compatible: + enum: + - fsl,imx-audio-card + + model: + $ref: /schemas/types.yaml#/definitions/string + description: User specified audio sound card name + + audio-routing: + $ref: /schemas/types.yaml#/definitions/non-unique-string-array + description: + A list of the connections between audio components. Each entry is a + pair of strings, the first being the connection's sink, the second + being the connection's source. Valid names could be power supplies, + MicBias of codec and the jacks on the board. + +patternProperties: + ".*-dai-link$": + description: + Each subnode represents a dai link. Subnodes of each dai links would be + cpu/codec dais. + + type: object + + properties: + link-name: + description: Indicates dai-link name and PCM stream name. + $ref: /schemas/types.yaml#/definitions/string + maxItems: 1 + + format: + description: audio format. + items: + enum: + - i2s + - dsp_b + + dai-tdm-slot-num: + description: see tdm-slot.txt. + $ref: /schemas/types.yaml#/definitions/uint32 + + dai-tdm-slot-width: + description: see tdm-slot.txt. + $ref: /schemas/types.yaml#/definitions/uint32 + + cpu: + description: Holds subnode which indicates cpu dai. + type: object + properties: + sound-dai: true + + codec: + description: Holds subnode which indicates codec dai. + type: object + properties: + sound-dai: true + + fsl,mclk-equal-bclk: + description: Indicates mclk can be equal to bclk, especially for sai interface + $ref: /schemas/types.yaml#/definitions/flag + + required: + - link-name + - cpu + + additionalProperties: false + +required: + - compatible + - model + +additionalProperties: false + +examples: + - | + sound-ak4458 { + compatible = "fsl,imx-audio-card"; + model = "ak4458-audio"; + pri-dai-link { + link-name = "akcodec"; + format = "i2s"; + fsl,mclk-equal-bclk; + cpu { + sound-dai = <&sai1>; + }; + codec { + sound-dai = <&ak4458_1>, <&ak4458_2>; + }; + }; + fe-dai-link { + link-name = "HiFi-ASRC-FE"; + format = "i2s"; + cpu { + sound-dai = <&easrc>; + }; + }; + be-dai-link { + link-name = "HiFi-ASRC-BE"; + format = "dsp_b"; + dai-tdm-slot-num = <8>; + dai-tdm-slot-width = <32>; + fsl,mclk-equal-bclk; + cpu { + sound-dai = <&sai1>; + }; + codec { + sound-dai = <&ak4458_1>, <&ak4458_2>; + }; + }; + }; -- 2.27.0

3 3

[PATCH] ASoC: topology: Fix using uninitialized pointer
by Jaska Uimonen 20 May '21

20 May '21

The original patch changed kcontrol_type to a pointer. In some goto cases the pointer is assigned into a struct member as uninitialized and this will cause a runtime error with UBSan even if it isn't a real bug. So initialize the pointer to NULL. Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Fixes: d29d41e28eea ("ASoC: topology: Add support for multiple kcontrol types to a widget") Signed-off-by: Jaska Uimonen <jaska.uimonen(a)linux.intel.com> Reviewed-by: Kai Vehmanen <kai.vehmanen(a)linux.intel.com> --- sound/soc/soc-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index e71d98d7b116..5e65b72910e9 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1422,7 +1422,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, struct snd_soc_dapm_widget template, *widget; struct snd_soc_tplg_ctl_hdr *control_hdr; struct snd_soc_card *card = tplg->comp->card; - unsigned int *kcontrol_type; + unsigned int *kcontrol_type = NULL; struct snd_kcontrol_new *kc; int mixer_count = 0; int bytes_count = 0; -- 2.24.1

2 1

[PATCH] ASoC: cs35l33: fix an error code in probe()
by Dan Carpenter 20 May '21

20 May '21

This error path returns zero (success) but it should return -EINVAL. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- sound/soc/codecs/cs35l33.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 6f6b3c0c88b7..2a6f5e46d031 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -1202,6 +1202,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client, dev_err(&i2c_client->dev, "CS35L33 Device ID (%X). Expected ID %X\n", devid, CS35L33_CHIP_ID); + ret = -EINVAL; goto err_enable; } -- 2.30.2

3 2

[BUG] ALSA: usb-audio: Scarlett 2 mixer driver fails on ehci-pci
by Geoffrey D. Bennett 20 May '21

20 May '21

Hi there, I'm trying to track down an issue with my Scarlett Gen 2 mixer driver that has been reported by a few people, and I can now reliably reproduce the issue, but I need some help in figuring out where exactly the issue is and how to fix it please. The issue only occurs when attempting to use the interface on a USB port using ehci-pci. xhci_hcd USB ports work fine. The issue occurs when sending the first vendor-specific USB command, but only when sending from the kernel driver. Sending the same USB packets from user-space works fine(!). I did initially think that the fault could have been due to earlier USB messages putting the device into a state where it would reject the vendor-specific USB commands, but I have carefully ruled that out & have gotten identical usbmon traces from device power-on up until the device responds differently, the only difference beforehand being whether the USB packet was sent from the kernel driver or user-space. The messages look like this in "usbmon -s 10000 -fu" when sent from user-space (or when sent from the kernel driver when the interface is plugged in to an xhci_hcd port): ffff888125855200 1006026497 S Ci:2:040:0 s a1 00 0000 0005 0018 24 < ffff888125855200 1006026680 C Ci:2:040:0 0 24 = 66191018 73190604 01000000 01000000 00040000 00000000 And like this when sent from the kernel driver when the interface is plugged in to an ehci-pci port: ffff88810487a300 3686673995 S Ci:2:036:0 s a1 00 0000 0005 0018 24 < ffff88810487a300 3692178724 C Ci:2:036:0 -2 0 Identical messages sent according to usbmon, but they must be different somehow! The kernel code to send that message looks like this: return snd_usb_ctl_msg( dev, usb_sndctrlpipe(dev, 0), usb_req, USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN, 0, interface, buf, size); and helper.c snd_usb_ctl_msg() then calls usb_control_msg(). For sending arbitrary USB packets from user-space for testing, I'm using libusb and: int ret = usb_control_msg( devh, reqtype, request, value, index, buf, size, 1000 ); So, I presume usbmon isn't giving me the full story? How can I determine the difference between the kernel and the user-space usb_control_msg() functions? I see that I can #define EHCI_URB_TRACE in ehci-hcd.c. Can anyone with more experience than me let me know if I'm going in the right direction to track this down? Thanks, Geoffrey.

2 5

Add UCMs for Google Asus Nexus 7 and Acer Iconia A500
by GitHub pull_request - edited 20 May '21

20 May '21

alsa-project/alsa-ucm-conf pull request #92 was edited from digetx: @perexg As was discussed previouly at https://www.spinics.net/lists/alsa-devel/msg126382.html I'm opening PR with the UCMs for Nexus 7 and A500. Both these devices are supported by the mainline Linux kernel. You're right that Tegra ASoC driver doesn't set card's name properly. In particular I found that we need to set the card's `driver_name` to `tegra`, then UCM get a proper lookup path. I rebased UCMs on top of the recent alsa-ucm-conf master and switched Nexus 7 UCM to use generic RT5640 UCM. Everything works great once the card name of the kernel driver is corrected. I'll send the kernel patches ASAP for review. Nexus 7 alsa-info: https://alsa-project.org/db/?f=0a29f1dab39ec5b33e01215dee42dbfd1dbbf08e A500 alsa-info: https://alsa-project.org/db/?f=bde4f7938a39b1d26904b414969fc811e726242f The alsa-info is taken using the updated kernel ASoC driver. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/92 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/92.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

Add UCMs for Google Asus Nexus 7 and Acer Iconial A500
by GitHub pull_request - opened 20 May '21

20 May '21

alsa-project/alsa-ucm-conf pull request #92 was opened from digetx: @perexg As was discussed previouly at https://www.spinics.net/lists/alsa-devel/msg126382.html I'm opening PR with the UCMs for Nexus 7 and A500. Both these devices are supported by the mainline Linux kernel. You're right that Tegra ASoC driver doesn't set card's name properly. In particular I found that we need to set the card's `driver_name` to `tegra`, then UCM get a proper lookup path. I rebased UCMs on top of the recent alsa-ucm-conf master and switched Nexus 7 UCM to use generic RT5640 UCM. Everything works great once the card name of the kernel driver is corrected. I'll send the kernel patches ASAP for review. Nexus 7 alsa-info: https://alsa-project.org/db/?f=0a29f1dab39ec5b33e01215dee42dbfd1dbbf08e A500 alsa-info: https://alsa-project.org/db/?f=bde4f7938a39b1d26904b414969fc811e726242f The alsa-info is taken using the updated kernel ASoC driver. Request URL : https://github.com/alsa-project/alsa-ucm-conf/pull/92 Patch URL : https://github.com/alsa-project/alsa-ucm-conf/pull/92.patch Repository URL: https://github.com/alsa-project/alsa-ucm-conf

1 0

re: ALSA: usb-audio: Handle error for the current selector gracefully [ uninitialized variable issue ]
by Colin Ian King 20 May '21

20 May '21

Hi, Static analysis with Coverity on linux-next has detected an uninitialized variable issue with the following commit: commit 481f17c41803985446fd12887b2c042f9c43b0d5 Author: Takashi Iwai <tiwai(a)suse.de> Date: Tue May 18 17:21:12 2021 +0200 ALSA: usb-audio: Handle error for the current selector gracefully The branching is a bit convoluted and we end up with variable cur not being initialized. Analysis is as follows: 254static int __uac_clock_find_source(struct snd_usb_audio *chip, 255 const struct audioformat *fmt, int entity_id, 256 unsigned long *visited, bool validate) 257{ 258 union uac23_clock_source_desc *source; 259 union uac23_clock_selector_desc *selector; 260 union uac23_clock_multiplier_desc *multiplier; 1. var_decl: Declaring variable cur without initializer. 261 int ret, i, cur, err, pins, clock_id; 262 const u8 *sources; 263 int proto = fmt->protocol; 264 265 entity_id &= 0xff; 266 2. Condition test_and_set_bit(entity_id, visited), taking false branch. 267 if (test_and_set_bit(entity_id, visited)) { 268 usb_audio_warn(chip, 269 "%s(): recursive clock topology detected, id %d.\n", 270 __func__, entity_id); 271 return -EINVAL; 272 } 273 274 /* first, see if the ID we're looking for is a clock source already */ 275 source = snd_usb_find_clock_source(chip, entity_id, proto); 3. Condition source, taking false branch. 276 if (source) { 277 entity_id = GET_VAL(source, proto, bClockID); 278 if (validate && !uac_clock_source_is_valid(chip, fmt, 279 entity_id)) { 280 usb_audio_err(chip, 281 "clock source %d is not valid, cannot use\n", 282 entity_id); 283 return -ENXIO; 284 } 285 return entity_id; 286 } 287 288 selector = snd_usb_find_clock_selector(chip, entity_id, proto); 4. Condition selector, taking true branch. 289 if (selector) { 5. Condition proto == 48, taking true branch. 290 pins = GET_VAL(selector, proto, bNrInPins); 6. Condition proto == 48, taking true branch. 291 clock_id = GET_VAL(selector, proto, bClockID); 7. Condition proto == 48, taking true branch. 292 sources = GET_VAL(selector, proto, baCSourceID); 293 8. Condition pins == 1, taking false branch. 294 if (pins == 1) { 295 ret = 1; 296 goto find_source; 297 } 298 299 /* the entity ID we are looking for is a selector. 300 * find out what it currently selects */ 301 ret = uac_clock_selector_get_val(chip, clock_id); 9. Condition ret < 0, taking true branch. 302 if (ret < 0) { 10. Condition !chip->autoclock, taking false branch. 303 if (!chip->autoclock) 304 return ret; 11. Jumping to label find_others. 305 goto find_others; 306 } 307 308 /* Selector values are one-based */ 309 310 if (ret > pins || ret < 1) { 311 usb_audio_err(chip, 312 "%s(): selector reported illegal value, id %d, ret %d\n", 313 __func__, clock_id, ret); 314 315 if (!chip->autoclock) 316 return -EINVAL; 317 ret = 0; 318 goto find_others; 319 } 320 321 find_source: 322 cur = ret; 323 ret = __uac_clock_find_source(chip, fmt, 324 sources[ret - 1], 325 visited, validate); 326 if (ret > 0) { 327 err = uac_clock_selector_set_val(chip, entity_id, cur); 328 if (err < 0) 329 return err; 330 } 331 332 if (!validate || ret > 0 || !chip->autoclock) 333 return ret; 334 335 find_others: 336 /* The current clock source is invalid, try others. */ 12. Condition i <= pins, taking true branch. 337 for (i = 1; i <= pins; i++) { Uninitialized scalar variable (UNINIT) 13. uninit_use: Using uninitialized value cur. 338 if (i == cur) 339 continue; 340 Colin

2 1

[PATCH 0/8] ALSA: firewire-lib: start processing content of packet at the same cycle in several contexts for each direction
by Takashi Sakamoto 20 May '21

20 May '21

Hi, Within devices supported by drivers in ALSA firewire stack, only DICE ASICs support several pair of isochronous packet streams. As long as I experienced, the ASIC requires drivers to transfer packets at the same isochronous cycle. Unless, it generates no sound. Additionally, in future integration I have a plan to take drivers performing sequence replay for media clock recovery. It's convenient to manage the cycle to start processing content of packet in several IR contexts. This patchset is to start processing content of packet at the same cycle in several contexts for each direction, including code refactoring. Takashi Sakamoto (8): ALSA: firewire-lib: code refactoring for size of CIP header ALSA: firewire-lib: code refactoring for calculation of context payload ALSA: firewire-lib: code refactoring for selection of IT context header length ALSA: firewire-lib: start processing content of packet at the same cycle in several IR contexts ALSA: firewire-lib: skip initial packets instead of scheduling IR context ALSA: firewire-lib: code refactoring to start several IT/IR contexts ALSA: firewire-lib: start processing content of packet at the same cycle in several IT contexts ALSA: firewire-lib: change waking up timing to process packets sound/firewire/amdtp-stream.c | 492 ++++++++++++++------ sound/firewire/amdtp-stream.h | 53 ++- sound/firewire/bebob/bebob_stream.c | 29 +- sound/firewire/dice/dice-stream.c | 15 +- sound/firewire/digi00x/digi00x-stream.c | 7 +- sound/firewire/fireface/ff-stream.c | 7 +- sound/firewire/fireworks/fireworks_stream.c | 8 +- sound/firewire/motu/amdtp-motu.c | 9 +- sound/firewire/motu/motu-stream.c | 7 +- sound/firewire/oxfw/oxfw-stream.c | 14 +- sound/firewire/tascam/tascam-stream.c | 7 +- 11 files changed, 401 insertions(+), 247 deletions(-) -- 2.27.0

2 9