May 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH v2] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin
by Srinivasa Rao Mandadapu 24 May '21

24 May '21

This patch fixes PoP noise of around 15ms observed during audio capture begin. Enables BCLK and LRCLK in snd_soc_dai_ops prepare call for introducing some delay before capture start and clock enable. Signed-off-by: Judy Hsiao <judyhsiao(a)chromium.org> Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org> --- Changes Since V1: -- Enableed BCLK and LRCLK in dai ops prepare API instead of startup API -- Added comments sound/soc/qcom/lpass-cpu.c | 48 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c index c62d2612e8f5..c5bb3f16d25f 100644 --- a/sound/soc/qcom/lpass-cpu.c +++ b/sound/soc/qcom/lpass-cpu.c @@ -93,9 +93,18 @@ static void lpass_cpu_daiops_shutdown(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai); + struct lpaif_i2sctl *i2sctl = drvdata->i2sctl; + unsigned int id = dai->driver->id; clk_disable_unprepare(drvdata->mi2s_osr_clk[dai->driver->id]); - clk_unprepare(drvdata->mi2s_bit_clk[dai->driver->id]); + /* To ensure BCLK/LRCLK disabled even in device node validation. + Will not impact if disabled in trigger suspend */ + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + regmap_fields_write(i2sctl->spken, id, LPAIF_I2SCTL_SPKEN_DISABLE); + else + regmap_fields_write(i2sctl->micen, id, LPAIF_I2SCTL_MICEN_DISABLE); + + clk_disable_unprepare(drvdata->mi2s_bit_clk[dai->driver->id]); } static int lpass_cpu_daiops_hw_params(struct snd_pcm_substream *substream, @@ -275,6 +284,8 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream, case SNDRV_PCM_TRIGGER_START: case SNDRV_PCM_TRIGGER_RESUME: case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: + /* To ensure lpass BCLK/LRCLK is enabled during + device resume. Will not impact if enabled in prepare */ if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { ret = regmap_fields_write(i2sctl->spken, id, LPAIF_I2SCTL_SPKEN_ENABLE); @@ -296,6 +307,8 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream, case SNDRV_PCM_TRIGGER_STOP: case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: + /* To ensure lpass BCLK/LRCLK is disabled during + device suspend */ if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { ret = regmap_fields_write(i2sctl->spken, id, LPAIF_I2SCTL_SPKEN_DISABLE); @@ -308,19 +321,50 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream, ret); clk_disable(drvdata->mi2s_bit_clk[dai->driver->id]); - + break; + default: break; } return ret; } +static int lpass_cpu_daiops_prepare(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai); + struct lpaif_i2sctl *i2sctl = drvdata->i2sctl; + unsigned int id = dai->driver->id; + int ret = -EINVAL; + /* To ensure lpass BCLK/LRCLK is enabled bit before + playback/capture data flow starts */ + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) + ret = regmap_fields_write(i2sctl->spken, id, LPAIF_I2SCTL_SPKEN_ENABLE); + else + ret = regmap_fields_write(i2sctl->micen, id, LPAIF_I2SCTL_MICEN_ENABLE); + + if (ret) + dev_err(dai->dev, "error writing to i2sctl reg: %d\n", + ret); + + ret = clk_enable(drvdata->mi2s_bit_clk[id]); + + if (ret) { + dev_err(dai->dev, "error in enabling mi2s bit clk: %d\n", ret); + clk_disable(drvdata->mi2s_osr_clk[id]); + return ret; + } + return 0; +} + + const struct snd_soc_dai_ops asoc_qcom_lpass_cpu_dai_ops = { .set_sysclk = lpass_cpu_daiops_set_sysclk, .startup = lpass_cpu_daiops_startup, .shutdown = lpass_cpu_daiops_shutdown, .hw_params = lpass_cpu_daiops_hw_params, .trigger = lpass_cpu_daiops_trigger, + .prepare = lpass_cpu_daiops_prepare, }; EXPORT_SYMBOL_GPL(asoc_qcom_lpass_cpu_dai_ops); -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

2 1

Dmix plugin does not update state when sound card is removed.
by GitHub issues - opened 23 May '21

23 May '21

alsa-project/alsa-lib issue #137 was opened from MHoyer12345678: Playing sound using snd_pcm_writei in a dmix setup might result in an infinite loop when sound card is removed. **Setup:** - dmix setup - pcm dmix device opened non blocking - snd_pcm_writei used with poll (POLLERR is not evaluated) **Trigger:** - usb sound card is removed (e.g. by "echo 0 > /sys/bus/usb/x-x/authorized") **Observation:** - snd_pcm_writei returns -EAGAIN on each call - snd_pcm_state report state RUNNING **Expected:** - snd_pcm_writei returns -ENODEV (as happening in case a pure hw configuration is used without dmix plugin) - snd_pcm_state report state DISCONNECTED (as happening in case a pure hw configuration is used without dmix plugin) **Root Cause:** - snd_pcm_writei calls snd_pcm_write_areas - snd_pcm_write_areas requests state of dmix pcm device (state = __snd_pcm_state(pcm);) - dmix implementation of snd_pcm_state requests state from slave hw device (state = snd_pcm_state(dmix->spcm);) - hw implementation of snd_pcm_state executes an ioctl (query_status -> sync_ptr1) - the ioctl call fails with -ENODEV (after the device has been removed) - pcm_hw returns -ENODEV as state - dmix implementation of snd_pcm_state ends in default section of the switch block - this leads to the unchanged dmix->state returned - this way, the -ENODEV from the slave device is finally ignored in dmix plugin **Potential Fix:** - Add the following three lines to snd_pcm_hw_state in pcm_hw.c after query_status_data ``` //disconnected HW is reported via a failed IOCTL return -ENODEV if (err == -ENODEV) return SND_PCM_STATE_DISCONNECTED; ``` - The fix takes -ENODEV as trigger to return state DISCONNECTED Hope this helps ... Issue URL : https://github.com/alsa-project/alsa-lib/issues/137 Repository URL: https://github.com/alsa-project/alsa-lib

1 0

[PATCH 0/3] ALSA: firewire-lib: drop initial NODATA packets or empty packets
by Takashi Sakamoto 23 May '21

23 May '21

Hi, This patchset is for convenience of ALSA bebob and firewire-tascam drivers. The devices based on BeBoB ASICs or the devices in Tascam FireWire series transfer a batch of NODATA packet or empty packet in initial step of streaming. To avoid processing them, current implementation uses an option to skip processing content of tx packet during some initial cycles. However, the hard-coded number is not enough useful. In 1st patch, ALSA IEC 61883-1/6 packet streaming engine becomes to drop the initial packets. As a result, The tx_init_skip_cycles argument of amdtp_domain_start() function changes its meaning. In the following patches, ALSA bebob driver is refactored. Takashi Sakamoto (3): ALSA: firewire-lib: drop initial tx packets with NODATA or empty ALSA: bebob: cancel switching connection order ALSA: bebob: distinguish M-Audio ProFire Lightbridge quirk sound/firewire/amdtp-stream.c | 130 +++++++++++++++++++++------- sound/firewire/amdtp-stream.h | 3 + sound/firewire/bebob/bebob.c | 10 ++- sound/firewire/bebob/bebob.h | 1 + sound/firewire/bebob/bebob_stream.c | 25 ++---- 5 files changed, 119 insertions(+), 50 deletions(-) -- 2.27.0

2 4

[PATCH 0/8] iio: accel: bmc150: Add support for yoga's with dual accelerometers with an ACPI HID of DUAL250E
by Hans de Goede 23 May '21

23 May '21

Hi All, Some 360 degree hinges (yoga) style 2-in-1 devices use 2 bmc150 accels to allow the OS to determine the angle between the display and the base of the device, so that the OS can determine if the 2-in-1 is in laptop or in tablet-mode. We already support this setup on devices using a single ACPI node with a HID of "BOSC0200" to describe both accelerometers. This patch set extends this support to also support the same setup but then using a HID of "DUAL250E". While testing this I found some crashes on rmmod, patches 1-2 fix those patches, patch 3 does some refactoring and patch 4 adds support for the "DUAL250E" HID. Unfortunately we need some more special handling though, which the rest of the patches are for. On Windows both accelerometers are read (polled) by a special service and this service calls a DSM (Device Specific Method), which in turn translates the angles to one of laptop/tablet/tent/stand mode and then notifies the EC about the new mode and the EC then enables or disables the builtin keyboard and touchpad based in the mode. When the 2-in-1 is powered-on or resumed folded in tablet mode the EC senses this independent of the DSM by using a HALL effect sensor which senses that the keyboard has been folded away behind the display. At power-on or resume the EC disables the keyboard based on this and the only way to get the keyboard to work after this is to call the DSM to re-enable it (similar to how we also need to call a special DSM in the kxcjk-1013.c accel driver to re-enable the keyboard). Patches 5-7 deal with the DSM mess and patch 8 adds labels to the 2 accelerometers specifying which one is which. Regards, Hans Hans de Goede (8): iio: accel: bmc150: Fix dereferencing the wrong pointer in bmc150_get/set_second_device iio: accel: bmc150: Don't make the remove function of the second accelerometer unregister itself iio: accel: bmc150: Move check for second ACPI device into a separate function iio: accel: bmc150: Add support for dual-accelerometers with a DUAL250E HID iio: accel: bmc150: Move struct bmc150_accel_data definition to bmc150-accel.h iio: accel: bmc150: Remove bmc150_set/get_second_device() accessor functions iio: accel: bmc150: Add support for DUAL250E ACPI DSM for setting the hinge angle iio: accel: bmc150: Set label based on accel-location for ACPI DUAL250E fwnodes drivers/iio/accel/bmc150-accel-core.c | 87 ++---------- drivers/iio/accel/bmc150-accel-i2c.c | 192 +++++++++++++++++++++----- drivers/iio/accel/bmc150-accel.h | 66 ++++++++- 3 files changed, 239 insertions(+), 106 deletions(-) -- 2.31.1

3 28

[sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
by kernel test robot 23 May '21

23 May '21

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 9ebaef0540a981093bce5df15af32354d32391d9 commit: 265d1a90e4fb6d3264d8122fbd10760e5e733be6 [117/119] ALSA: usb-audio: scarlett2: Improve driver startup messages config: x86_64-randconfig-s021-20210522 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound for-linus git checkout 265d1a90e4fb6d3264d8122fbd10760e5e733be6 # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> sparse warnings: (new ones prefixed by >>) >> sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

3 5

[sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: warning: no previous prototype for function 'snd_scarlett_gen2_controls_create'
by kernel test robot 22 May '21

22 May '21

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 9ebaef0540a981093bce5df15af32354d32391d9 commit: 265d1a90e4fb6d3264d8122fbd10760e5e733be6 [117/119] ALSA: usb-audio: scarlett2: Improve driver startup messages config: x86_64-randconfig-a014-20210522 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e84a9b9bb3051c35dea993cdad7b3d2575638f85) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound for-linus git checkout 265d1a90e4fb6d3264d8122fbd10760e5e733be6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> sound/usb/mixer_scarlett_gen2.c:2000:5: warning: no previous prototype for function 'snd_scarlett_gen2_controls_create' [-Wmissing-prototypes] int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, ^ sound/usb/mixer_scarlett_gen2.c:2000:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, ^ static 1 warning generated. vim +/snd_scarlett_gen2_controls_create +2000 sound/usb/mixer_scarlett_gen2.c 1999 > 2000 int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, 2001 const struct scarlett2_device_info *info) 2002 { 2003 int err; 2004 2005 /* Initialise private data, routing, sequence number */ 2006 err = scarlett2_init_private(mixer, info); 2007 if (err < 0) 2008 return err; 2009 2010 /* Read volume levels and controls from the interface */ 2011 err = scarlett2_read_configs(mixer); 2012 if (err < 0) 2013 return err; 2014 2015 /* Create the analogue output controls */ 2016 err = scarlett2_add_line_out_ctls(mixer); 2017 if (err < 0) 2018 return err; 2019 2020 /* Create the analogue input controls */ 2021 err = scarlett2_add_line_in_ctls(mixer); 2022 if (err < 0) 2023 return err; 2024 2025 /* Create the input, output, and mixer mux input selections */ 2026 err = scarlett2_add_mux_enums(mixer); 2027 if (err < 0) 2028 return err; 2029 2030 /* Create the matrix mixer controls */ 2031 err = scarlett2_add_mixer_ctls(mixer); 2032 if (err < 0) 2033 return err; 2034 2035 /* Create the level meter controls */ 2036 err = scarlett2_add_meter_ctl(mixer); 2037 if (err < 0) 2038 return err; 2039 2040 /* Set up the interrupt polling if there are hardware buttons */ 2041 if (info->button_count) { 2042 err = scarlett2_mixer_status_create(mixer); 2043 if (err < 0) 2044 return err; 2045 } 2046 2047 return 0; 2048 } 2049 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: warning: no previous prototype for 'snd_scarlett_gen2_controls_create'
by kernel test robot 22 May '21

22 May '21

tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus head: 9ebaef0540a981093bce5df15af32354d32391d9 commit: 265d1a90e4fb6d3264d8122fbd10760e5e733be6 [117/119] ALSA: usb-audio: scarlett2: Improve driver startup messages config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=… git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git git fetch --no-tags sound for-linus git checkout 265d1a90e4fb6d3264d8122fbd10760e5e733be6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com> All warnings (new ones prefixed by >>): >> sound/usb/mixer_scarlett_gen2.c:2000:5: warning: no previous prototype for 'snd_scarlett_gen2_controls_create' [-Wmissing-prototypes] 2000 | int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/snd_scarlett_gen2_controls_create +2000 sound/usb/mixer_scarlett_gen2.c 1999 > 2000 int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, 2001 const struct scarlett2_device_info *info) 2002 { 2003 int err; 2004 2005 /* Initialise private data, routing, sequence number */ 2006 err = scarlett2_init_private(mixer, info); 2007 if (err < 0) 2008 return err; 2009 2010 /* Read volume levels and controls from the interface */ 2011 err = scarlett2_read_configs(mixer); 2012 if (err < 0) 2013 return err; 2014 2015 /* Create the analogue output controls */ 2016 err = scarlett2_add_line_out_ctls(mixer); 2017 if (err < 0) 2018 return err; 2019 2020 /* Create the analogue input controls */ 2021 err = scarlett2_add_line_in_ctls(mixer); 2022 if (err < 0) 2023 return err; 2024 2025 /* Create the input, output, and mixer mux input selections */ 2026 err = scarlett2_add_mux_enums(mixer); 2027 if (err < 0) 2028 return err; 2029 2030 /* Create the matrix mixer controls */ 2031 err = scarlett2_add_mixer_ctls(mixer); 2032 if (err < 0) 2033 return err; 2034 2035 /* Create the level meter controls */ 2036 err = scarlett2_add_meter_ctl(mixer); 2037 if (err < 0) 2038 return err; 2039 2040 /* Set up the interrupt polling if there are hardware buttons */ 2041 if (info->button_count) { 2042 err = scarlett2_mixer_status_create(mixer); 2043 if (err < 0) 2044 return err; 2045 } 2046 2047 return 0; 2048 } 2049 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

1 0

[PATCH 0/6] ALSA: firewire-lib: code refactoring for processing rx packets
by Takashi Sakamoto 22 May '21

22 May '21

Hi, This patchset refactors mainly for processing rx packets. Except for devices handled by ALSA bebob and dice drivers, the devices doesn't take care of the value of syt field of CIP header for playback timing. To code it explicitly, the new flag is added in 1st patch. Some of devices based on DICE ASICs supports two pairs of packet streams. In the case, the sequence of rx packet in the streams should be different independently so that each of them deliver timing information from each peer. On the other hand, current implementation pools the sequence in AMDTP domain, then the rx packets are processed with the same pool. It is inconvenient and in 2nd patch the pool is prepared per streams. The other patches are for my future work. Regards Takashi Sakamoto (6): ALSA: firewire-lib: add flag to unaware of syt in CIP header ALSA: firewire-lib: pool sequence of packet in IT context independently ALSA: firewire-lib: code refactoring for generation of packet descriptors ALSA: firewire-lib: code refactoring for generation of syt sequence ALSA: firewire-lib: code refactoring for generation of data block sequence ALSA: firewire-lib: code refactoring for transfer delay sound/firewire/amdtp-stream.c | 267 +++++++++++++-------------- sound/firewire/amdtp-stream.h | 33 ++-- sound/firewire/motu/amdtp-motu.c | 4 +- sound/firewire/tascam/amdtp-tascam.c | 6 +- 4 files changed, 146 insertions(+), 164 deletions(-) -- 2.27.0

2 7

[PATCH] ALSA: hda/realtek: the bass speaker can't output sound on Yoga 9i
by Hui Wang 22 May '21

22 May '21

The Lenovo Yoga 9i has bass speaker, but the bass speaker can't work, that is because there is an i2s amplifier on that speaker, need to run ideapad_s740_coef() to initialize the amplifier. And also needs to apply ALC285_FIXUP_THINKPAD_HEADSET_JACK to rename the speaker's mixer control name, otherwise the PA can't handle them. BugLink: http://bugs.launchpad.net/bugs/1926165 Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4eab336dc739..c6b5db831ed0 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6552,6 +6552,7 @@ enum { ALC295_FIXUP_ASUS_DACS, ALC295_FIXUP_HP_OMEN, ALC285_FIXUP_HP_SPECTRE_X360, + ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, }; static const struct hda_fixup alc269_fixups[] = { @@ -8118,6 +8119,12 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1, }, + [ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP] = { + .type = HDA_FIXUP_FUNC, + .v.func = alc285_fixup_ideapad_s740_coef, + .chained = true, + .chain_id = ALC285_FIXUP_THINKPAD_HEADSET_JACK, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -8486,6 +8493,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x17aa, 0x3178, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), SND_PCI_QUIRK(0x17aa, 0x3818, "Lenovo C940", ALC298_FIXUP_LENOVO_SPK_VOLUME), SND_PCI_QUIRK(0x17aa, 0x3827, "Ideapad S740", ALC285_FIXUP_IDEAPAD_S740_COEF), + SND_PCI_QUIRK(0x17aa, 0x3843, "Yoga 9i", ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP), SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI), SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC), SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI), @@ -8701,6 +8709,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"}, {.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"}, {.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"}, + {.id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name = "alc287-ideapad-bass-spk-amp"}, {} }; #define ALC225_STANDARD_PINS \ -- 2.25.1

2 1

[PATCH] ALSA: hda/realtek: Headphone volume is controlled by Front mixer
by Hui Wang 22 May '21

22 May '21

On some ASUS and MSI machines, the audio codec is alc1220 and the Headphone is connected to audio mixer 0xf and DAC 0x5, in theory the Headphone volume is controlled by DAC 0x5 (Heapdhone Playback Volume), but somehow it is controlled by DAC 0x2 (Front Playback Volume), maybe this is a defect on the codec alc1220. Because of this issue, the PA couldn't switch the headphone and Lineout correctly, If we apply the quirk CLEVO_P950 to those machines, the Lineout and Headphone will share the audio mixer 0xc and DAC 0x2, and generate Headphone+LO mixer, then PA could handle them when switching between them. BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1206 Cc: <stable(a)vger.kernel.org> Signed-off-by: Hui Wang <hui.wang(a)canonical.com> --- sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index c6b5db831ed0..3d40d32ef3ba 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -2603,6 +2603,28 @@ static const struct hda_model_fixup alc882_fixup_models[] = { {} }; +static const struct snd_hda_pin_quirk alc882_pin_fixup_tbl[] = { + SND_HDA_PIN_QUIRK(0x10ec1220, 0x1043, "ASUS", ALC1220_FIXUP_CLEVO_P950, + {0x14, 0x01014010}, + {0x15, 0x01011012}, + {0x16, 0x01016011}, + {0x18, 0x01a19040}, + {0x19, 0x02a19050}, + {0x1a, 0x0181304f}, + {0x1b, 0x0221401f}, + {0x1e, 0x01456130}), + SND_HDA_PIN_QUIRK(0x10ec1220, 0x1462, "MS-7C35", ALC1220_FIXUP_CLEVO_P950, + {0x14, 0x01015010}, + {0x15, 0x01011012}, + {0x16, 0x01011011}, + {0x18, 0x01a11040}, + {0x19, 0x02a19050}, + {0x1a, 0x0181104f}, + {0x1b, 0x0221401f}, + {0x1e, 0x01451130}), + {} +}; + /* * BIOS auto configuration */ @@ -2644,6 +2666,7 @@ static int patch_alc882(struct hda_codec *codec) snd_hda_pick_fixup(codec, alc882_fixup_models, alc882_fixup_tbl, alc882_fixups); + snd_hda_pick_pin_fixup(codec, alc882_pin_fixup_tbl, alc882_fixups, true); snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_PRE_PROBE); alc_auto_parse_customize_define(codec); -- 2.25.1

2 1