December 2021 - Alsa-devel - mailman.alsa-project.org

[PATCH 0/3] ASoC: SOF: remove suport for TRIGGER_RESUME
by Pierre-Louis Bossart 21 Dec '21

21 Dec '21

None of the SOF platforms support INFO_RESUME, and rely on the indirect path used by the ALSA core with the prepare and TRIGGER_START steps. Let's remove the left-over dead code. Ranjani Sridharan (3): ASoC: SOF: pcm: remove support for RESUME trigger ASoC: SOF: Intel: hda: remove support for RESUME trigger ASoC: SOF: Intel: hda: remove support for RESUME in platform trigger sound/soc/sof/intel/hda-dai.c | 10 ---------- sound/soc/sof/intel/hda-stream.c | 1 - sound/soc/sof/pcm.c | 20 -------------------- 3 files changed, 31 deletions(-) -- 2.25.1

2 4

[PATCH] ASoC: SOF: Kconfig: Make the SOF_DEVELOPER_SUPPORT depend on SND_SOC_SOF
by Pierre-Louis Bossart 21 Dec '21

21 Dec '21

From: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> SND_SOC_SOF_DEVELOPER_SUPPORT contains options affecting how the built SOF driver stack will behave, enables debug options and other features. These options have no meaning if the SND_SOC_SOF is not even enabled. If we have SOF client options under developer_support and debug they can be selected to be built even without the core, but they do need symbols from the core (the sof-client API) which can result build failure. In Kconfig we can have SND_SOC_SOF_TOPLEVEL=y SND_SOC_SOF_DEBUG_IPC_FLOOD_TEST=y for example, which will make the flood client to be built, but the SOF core is not as SND_SOC_SOF is not selected. Reviewed-by: Paul Olaru <paul.olaru(a)oss.nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta(a)nxp.com> Reviewed-by: Ranjani Sridharan <ranjani.sridharan(a)intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi(a)linux.intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart(a)linux.intel.com> --- sound/soc/sof/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index ac34c330cf0c..1a7d6cefd3b7 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -63,7 +63,7 @@ config SND_SOC_SOF_DEBUG_PROBES config SND_SOC_SOF_DEVELOPER_SUPPORT bool "SOF developer options support" - depends on EXPERT + depends on EXPERT && SND_SOC_SOF help This option unlocks SOF developer options for debug/performance/ code hardening. -- 2.25.1

2 1

[PATCH v2] ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master
by Kuninori Morimoto 21 Dec '21

21 Dec '21

From: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> snd_soc_daifmt_parse_clock_provider_raw() is handling both bitclock/frame-master, and is supporting both flag/phandle. Current DT is assuming it is flag style. This patch allows both case. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx(a)renesas.com> --- v1 -> v2 - anyOf -> oneOf .../devicetree/bindings/sound/audio-graph-port.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml index 43e7f86e3b23..476dcb49ece6 100644 --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml @@ -42,10 +42,15 @@ patternProperties: $ref: /schemas/types.yaml#/definitions/flag frame-master: description: Indicates dai-link frame master. - $ref: /schemas/types.yaml#/definitions/phandle + oneOf: + - $ref: /schemas/types.yaml#/definitions/flag + - $ref: /schemas/types.yaml#/definitions/phandle bitclock-master: description: Indicates dai-link bit clock master - $ref: /schemas/types.yaml#/definitions/phandle + oneOf: + - $ref: /schemas/types.yaml#/definitions/flag + - $ref: /schemas/types.yaml#/definitions/phandle + dai-format: description: audio format. items: -- 2.25.1

3 2

[PATCH 00/22] ASoC: Use dev_err_probe() helper
by Kuninori Morimoto 21 Dec '21

21 Dec '21

I'm now posting below patch to ASoC/DT ML, sorry for my multi post, but this patch-set is independent from it. ASoC: dt-bindings: audio-graph-port: enable both flag/phandle for bitclock/frame-master https://lore.kernel.org/r/20211208064852.507977-1-kuninori.morimoto.gx@rene… This patch-set tries to use dev_err_probe() helper function instead of manual dev_err() code. I hope ASoC will be more clean code by this patch-set. - if (err < 0) { - if (err != -EPROBE_DEFER) - dev_err(...); - return err; - } + if (err < 0) + return dev_err_probe(...); Kuninori Morimoto (22): ASoC: codecs: ak4118: Use dev_err_probe() helper ASoC: codecs: es7241: Use dev_err_probe() helper ASoC: codecs: max9759: Use dev_err_probe() helper ASoC: codecs: max9860: Use dev_err_probe() helper ASoC: codecs: pcm3168a: Use dev_err_probe() helper ASoC: codecs: sgtl5000: Use dev_err_probe() helper ASoC: codecs: simple-amplifier: Use dev_err_probe() helper ASoC: codecs: simple-mux: Use dev_err_probe() helper ASoC: codecs: ssm2305: Use dev_err_probe() helper ASoC: codecs: tlv320aic31xx: Use dev_err_probe() helper ASoC: ateml: Use dev_err_probe() helper ASoC: ti: Use dev_err_probe() helper ASoC: fsl: Use dev_err_probe() helper ASoC: generic: Use dev_err_probe() helper ASoC: img: Use dev_err_probe() helper ASoC: meson: Use dev_err_probe() helper ASoC: mxs: Use dev_err_probe() helper ASoC: qcom: Use dev_err_probe() helper ASoC: rockchip: Use dev_err_probe() helper ASoC: samsung: Use dev_err_probe() helper ASoC: stm: Use dev_err_probe() helper ASoC: sunxi: Use dev_err_probe() helper sound/soc/atmel/mikroe-proto.c | 6 +-- sound/soc/atmel/tse850-pcm5142.c | 32 +++++-------- sound/soc/codecs/ak4118.c | 18 +++---- sound/soc/codecs/es7241.c | 28 ++++------- sound/soc/codecs/max9759.c | 28 ++++------- sound/soc/codecs/max9860.c | 12 ++--- sound/soc/codecs/pcm3168a.c | 22 +++------ sound/soc/codecs/sgtl5000.c | 5 +- sound/soc/codecs/simple-amplifier.c | 10 ++-- sound/soc/codecs/simple-mux.c | 10 ++-- sound/soc/codecs/ssm2305.c | 11 ++--- sound/soc/codecs/tlv320aic31xx.c | 16 ++----- sound/soc/fsl/fsl-asoc-card.c | 3 +- sound/soc/fsl/imx-card.c | 17 +++---- sound/soc/fsl/imx-sgtl5000.c | 4 +- sound/soc/fsl/imx-spdif.c | 4 +- sound/soc/generic/audio-graph-card.c | 5 +- sound/soc/generic/audio-graph-card2.c | 4 +- sound/soc/generic/simple-card.c | 3 +- sound/soc/img/img-i2s-in.c | 8 ++-- sound/soc/img/img-i2s-out.c | 24 ++++------ sound/soc/img/img-parallel-out.c | 24 ++++------ sound/soc/img/img-spdif-in.c | 8 ++-- sound/soc/img/img-spdif-out.c | 24 ++++------ sound/soc/img/pistachio-internal-dac.c | 9 ++-- sound/soc/meson/aiu.c | 36 +++++--------- sound/soc/meson/axg-fifo.c | 16 ++----- sound/soc/meson/axg-pdm.c | 25 +++------- sound/soc/meson/axg-spdifin.c | 17 ++----- sound/soc/meson/axg-spdifout.c | 17 ++----- sound/soc/meson/axg-tdm-formatter.c | 50 ++++++-------------- sound/soc/meson/axg-tdm-interface.c | 25 +++------- sound/soc/meson/meson-card-utils.c | 8 ++-- sound/soc/meson/t9015.c | 14 ++---- sound/soc/mxs/mxs-sgtl5000.c | 8 +--- sound/soc/qcom/common.c | 10 ++-- sound/soc/rockchip/rk3288_hdmi_analog.c | 10 ++-- sound/soc/samsung/aries_wm8994.c | 17 +++---- sound/soc/samsung/arndale.c | 5 +- sound/soc/samsung/littlemill.c | 5 +- sound/soc/samsung/lowland.c | 5 +- sound/soc/samsung/odroid.c | 4 +- sound/soc/samsung/smdk_wm8994.c | 4 +- sound/soc/samsung/smdk_wm8994pcm.c | 4 +- sound/soc/samsung/snow.c | 9 ++-- sound/soc/samsung/speyside.c | 5 +- sound/soc/samsung/tm2_wm5110.c | 3 +- sound/soc/samsung/tobermory.c | 5 +- sound/soc/stm/stm32_i2s.c | 62 +++++++++---------------- sound/soc/stm/stm32_sai.c | 37 ++++++--------- sound/soc/stm/stm32_sai_sub.c | 25 ++++------ sound/soc/stm/stm32_spdifrx.c | 44 ++++++------------ sound/soc/sunxi/sun4i-codec.c | 3 +- sound/soc/ti/davinci-mcasp.c | 10 ++-- sound/soc/ti/j721e-evm.c | 10 ++-- 55 files changed, 271 insertions(+), 557 deletions(-) -- 2.25.1

2 23

[PATCH] ASoC: mediatek: mt8195: correct default value
by Trevor Wu 21 Dec '21

21 Dec '21

mt8195_cg_patch is used to reset the default value of audio cg, so the register value could be consistent with CCF reference count. Nevertheless, AUDIO_TOP_CON1[1:0] is used to control an internal mux, and it's expected to keep the default value 0. This patch corrects the default value in case an unexpected behavior happens in the future. Fixes: 6746cc8582599 ("ASoC: mediatek: mt8195: add platform driver") Signed-off-by: Trevor Wu <trevor.wu(a)mediatek.com> --- sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c index 8a6db24116e3..e425f868476a 100644 --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c @@ -3029,7 +3029,7 @@ static const struct reg_sequence mt8195_afe_reg_defaults[] = { static const struct reg_sequence mt8195_cg_patch[] = { { AUDIO_TOP_CON0, 0xfffffffb }, - { AUDIO_TOP_CON1, 0xfffffffa }, + { AUDIO_TOP_CON1, 0xfffffff8 }, }; static int mt8195_afe_init_registers(struct mtk_base_afe *afe) -- 2.18.0

2 1

RE: [PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()
by 王擎 20 Dec '21

20 Dec '21

>> From: Wang Qing <wangqing(a)vivo.com> >> >> of_find_device_by_node() takes a reference to the embedded struct device >> which needs to be dropped when error return. > >... > >> data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); >> if (!data) { >> + put_device(&cpu_pdev->dev); > >If it's of_find_device_by_node() you need an of_node_put() since you're >dropping a reference on the OF node. > Label fail will drop a reference on the OF node. Also, put_device() is called later except this branch, we just need to add put_device() here. Thanks, Qing >> ret = -ENOMEM; >> goto fail;

2 1

[PATCH 0/3] Fix Tegra194 HDA regression
by Sameer Pujar 20 Dec '21

20 Dec '21

HDA probe failure is observed on Tegra194 based platforms and this happens due to a reset failure. The series fixes this problem by avoiding explicit resets on BPMP based devices. Sameer Pujar (3): ALSA: hda/tegra: Skip reset on BPMP devices dt-bindings: sound: tegra: Update HDA resets arm64: tegra: Remove non existent Tegra194 reset .../bindings/sound/nvidia,tegra30-hda.yaml | 13 ++++++++---- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 ++--- sound/pci/hda/hda_tegra.c | 24 +++++++++++++++++----- 3 files changed, 30 insertions(+), 12 deletions(-) -- 2.7.4

5 39

Missing profile 7.1
by GitHub issues - opened 19 Dec '21

19 Dec '21

alsa-project/alsa-utils issue #128 was opened from raven2cz: Hello, I have several years profile 7.1 which is missing now around 1.5-2months. I already write these issues * https://bbs.archlinux.org/viewtopic.php?id=272280 * https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1309 It seems that the problem can be in alsa-utils. ``` control.45 { iface PCM name 'Playback Channel Map' value.0 0 value.1 0 value.2 0 value.3 0 value.4 0 value.5 0 comment { access read type INTEGER count 6 range '0 - 36' } } ``` I already try to change kernels, not help. See inside the issues whole test env. Can you help me? Issue URL : https://github.com/alsa-project/alsa-utils/issues/128 Repository URL: https://github.com/alsa-project/alsa-utils

1 0

[PATCH 1/3] ASoC: dt-bindings: Use name-prefix schema
by Alexander Stein 18 Dec '21

18 Dec '21

name-prefix.txt does not exist anymore, just reference the schema instead. Signed-off-by: Alexander Stein <alexander.stein(a)mailbox.org> --- .../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml index 26379377a7ac..1f0327474744 100644 --- a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml +++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml @@ -9,6 +9,9 @@ title: Simple Audio Amplifier Device Tree Bindings maintainers: - Jerome Brunet <jbrunet(a)baylibre.com> +allOf: + - $ref: name-prefix.yaml# + properties: compatible: enum: @@ -22,10 +25,7 @@ properties: description: > power supply for the device - sound-name-prefix: - $ref: /schemas/types.yaml#/definitions/string - description: > - See ./name-prefix.txt + sound-name-prefix: pass required: - compatible -- 2.34.1

1 2

Re: [syzbot] KMSAN: uninit-value in snd_rawmidi_ioctl
by Jaroslav Kysela 18 Dec '21

18 Dec '21

On 18. 12. 21 12:17, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 8b936c96768e kmsan: core: remove the accidentally committe.. > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=11791d89b00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=e00a8959fdd3f3e8 > dashboard link: https://syzkaller.appspot.com/bug?extid=88412ee8811832b00dbe > compiler: clang version 14.0.0 (git@github.com:llvm/llvm-project.git 0996585c8e3b3d409494eb5f1cad714b9e1f7fb5), GNU ld (GNU Binutils for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13a7abf9b00000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=172410b9b00000 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+88412ee8811832b00dbe(a)syzkaller.appspotmail.com > > ===================================================== > BUG: KMSAN: uninit-value in snd_rawmidi_ioctl+0xf1e/0x1330 sound/core/rawmidi.c:887 > snd_rawmidi_ioctl+0xf1e/0x1330 sound/core/rawmidi.c:887 Nice catch. I wonder why the problem was not detected by tests. The patch bellow should initialize the user_pversion variable: diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index 6f30231bdb88..befa9809ff00 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -447,6 +447,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file) err = -ENOMEM; goto __error; } + rawmidi_file->user_pversion = 0; init_waitqueue_entry(&wait, current); add_wait_queue(&rmidi->open_wait, &wait); while (1) { I'll send the path in the proper format ASAP. Jaroslav -- Jaroslav Kysela <perex(a)perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

1 0